)]}'
{"quantum/openstack/common/rpc/impl_zmq.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"3e2a593095d105e7730ad5931ef216de663159ee","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        #TODO(ewindisch): use zero-copy (i.e. references, not copying)"},{"line_number":429,"context_line":"        data \u003d sock.recv()"},{"line_number":430,"context_line":"        topic, msg_id, style, in_msg \u003d data"},{"line_number":431,"context_line":"        topic \u003d topic.split(\u0027.\u0027, 1)[0]"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        LOG.debug(_(\"CONSUMER GOT %s\"), \u0027 \u0027.join(map(pformat, data)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FU38%3D","line":430,"updated":"2012-09-21 00:43:41.000000000","message":"I cannot find that style is used anywhere.","commit_id":"cea201ad17ac8bde73c18e876ef9c01b3e5c7918"},{"author":{"_account_id":159,"name":"Eric Windisch","email":"ewindisch@docker.com","username":"ewindisch"},"unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        #TODO(ewindisch): use zero-copy (i.e. references, not copying)"},{"line_number":429,"context_line":"        data \u003d sock.recv()"},{"line_number":430,"context_line":"        topic, msg_id, style, in_msg \u003d data"},{"line_number":431,"context_line":"        topic \u003d topic.split(\u0027.\u0027, 1)[0]"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        LOG.debug(_(\"CONSUMER GOT %s\"), \u0027 \u0027.join(map(pformat, data)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FU3g%3D","line":430,"in_reply_to":"AAAALH%2F%2FU38%3D","updated":"2012-09-21 00:58:37.000000000","message":"It isn\u0027t, not here anyway. We can\u0027t assign to None and all the other variables are used here, so I preferred doing this to using indexes.","commit_id":"cea201ad17ac8bde73c18e876ef9c01b3e5c7918"},{"author":{"_account_id":159,"name":"Eric Windisch","email":"ewindisch@docker.com","username":"ewindisch"},"unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        #TODO(ewindisch): use zero-copy (i.e. references, not copying)"},{"line_number":429,"context_line":"        data \u003d sock.recv()"},{"line_number":430,"context_line":"        topic, msg_id, style, in_msg \u003d data"},{"line_number":431,"context_line":"        topic \u003d topic.split(\u0027.\u0027, 1)[0]"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        LOG.debug(_(\"CONSUMER GOT %s\"), \u0027 \u0027.join(map(pformat, data)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FU14%3D","line":430,"in_reply_to":"AAAALH%2F%2FU3U%3D","updated":"2012-09-21 01:41:56.000000000","message":"It might not be. It was originally used for handling message replies, but that code was refactored. It might still be used again. Either way, we probably will have to leave that field in to maintain wire-format compatibility in the future, since I don\u0027t expect that I can remove it from Nova and Ceilometer before Folsom lands. However, since no released code will have ever used it, we might be able to repurpose the field.","commit_id":"cea201ad17ac8bde73c18e876ef9c01b3e5c7918"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"3e2a593095d105e7730ad5931ef216de663159ee","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        #TODO(ewindisch): use zero-copy (i.e. references, not copying)"},{"line_number":429,"context_line":"        data \u003d sock.recv()"},{"line_number":430,"context_line":"        topic, msg_id, style, in_msg \u003d data"},{"line_number":431,"context_line":"        topic \u003d topic.split(\u0027.\u0027, 1)[0]"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        LOG.debug(_(\"CONSUMER GOT %s\"), \u0027 \u0027.join(map(pformat, data)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FU3U%3D","line":430,"in_reply_to":"AAAALH%2F%2FU3g%3D","updated":"2012-09-21 01:09:56.000000000","message":"I cannot find it used in the whole impl_zmq module. Is it used?","commit_id":"cea201ad17ac8bde73c18e876ef9c01b3e5c7918"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"3e2a593095d105e7730ad5931ef216de663159ee","unresolved":false,"context_lines":[{"line_number":531,"context_line":"            return"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        reactor \u003d CallbackReactor(CONF, callback)"},{"line_number":534,"context_line":"        self._consume_fanout(reactor, topic, None, bind\u003dFalse)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    def create_consumer(self, topic, proxy, fanout\u003dFalse):"},{"line_number":537,"context_line":"        # Only consume on the base topic name."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FU4Q%3D","line":534,"updated":"2012-09-21 00:43:41.000000000","message":"why call the _consume_fanout in declare_topic_consumer()?","commit_id":"cea201ad17ac8bde73c18e876ef9c01b3e5c7918"},{"author":{"_account_id":159,"name":"Eric Windisch","email":"ewindisch@docker.com","username":"ewindisch"},"unresolved":false,"context_lines":[{"line_number":531,"context_line":"            return"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        reactor \u003d CallbackReactor(CONF, callback)"},{"line_number":534,"context_line":"        self._consume_fanout(reactor, topic, None, bind\u003dFalse)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    def create_consumer(self, topic, proxy, fanout\u003dFalse):"},{"line_number":537,"context_line":"        # Only consume on the base topic name."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FU10%3D","line":534,"in_reply_to":"AAAALH%2F%2FU3Y%3D","updated":"2012-09-21 01:41:56.000000000","message":"_consume_fanout does consume a fanout queue. I just realized that we might not necessarily want that when we call declare_topic_consumer. That might seem obvious now, but declare_topic_consumer isn\u0027t actually part of the public API, so I  overlooked this important detail...\n\nThis is resolvable, of course, but we\u0027re looking at tomorrow at the earliest. I\u0027ll need to also add a variant of what exists on line 420 that does a PUSH, rather (or in addition to) the PUB that it does currently.","commit_id":"cea201ad17ac8bde73c18e876ef9c01b3e5c7918"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"3e2a593095d105e7730ad5931ef216de663159ee","unresolved":false,"context_lines":[{"line_number":531,"context_line":"            return"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        reactor \u003d CallbackReactor(CONF, callback)"},{"line_number":534,"context_line":"        self._consume_fanout(reactor, topic, None, bind\u003dFalse)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    def create_consumer(self, topic, proxy, fanout\u003dFalse):"},{"line_number":537,"context_line":"        # Only consume on the base topic name."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FU3Y%3D","line":534,"in_reply_to":"AAAALH%2F%2FU3k%3D","updated":"2012-09-21 01:09:56.000000000","message":"If the _consume_fanout is not exchange type specific, why not change it into just _consume()","commit_id":"cea201ad17ac8bde73c18e876ef9c01b3e5c7918"},{"author":{"_account_id":159,"name":"Eric Windisch","email":"ewindisch@docker.com","username":"ewindisch"},"unresolved":false,"context_lines":[{"line_number":531,"context_line":"            return"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        reactor \u003d CallbackReactor(CONF, callback)"},{"line_number":534,"context_line":"        self._consume_fanout(reactor, topic, None, bind\u003dFalse)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    def create_consumer(self, topic, proxy, fanout\u003dFalse):"},{"line_number":537,"context_line":"        # Only consume on the base topic name."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FU3k%3D","line":534,"in_reply_to":"AAAALH%2F%2FU4Q%3D","updated":"2012-09-21 00:58:37.000000000","message":"Code reuse. It is also called this from create_consumer.","commit_id":"cea201ad17ac8bde73c18e876ef9c01b3e5c7918"}]}