)]}'
{"neutron/agent/linux/ovs_lib.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"361668e87e1851a0bc8505348fec6eae53d83cc0","unresolved":false,"context_lines":[{"line_number":566,"context_line":"            \"find\", \"Bridge\", \"datapath_id\u003d%s\" % datapath_id]"},{"line_number":567,"context_line":"    try:"},{"line_number":568,"context_line":"        result_str \u003d utils.execute(args, root_helper\u003droot_helper)"},{"line_number":569,"context_line":"    except Exception as e:"},{"line_number":570,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":571,"context_line":"            LOG.exception(_LE(\"Unable to execute %(cmd)s. \""},{"line_number":572,"context_line":"                              \"Exception: %(exception)s\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_9297b0eb","line":569,"updated":"2014-11-15 00:31:45.000000000","message":"can we narrow this exception?","commit_id":"163b02b07652660c2e98b622f520b9367c184151"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e055b96cb2afdeac4c1bee84abc0e5e1f5603ff1","unresolved":false,"context_lines":[{"line_number":566,"context_line":"            \"find\", \"Bridge\", \"datapath_id\u003d%s\" % datapath_id]"},{"line_number":567,"context_line":"    try:"},{"line_number":568,"context_line":"        result_str \u003d utils.execute(args, root_helper\u003droot_helper)"},{"line_number":569,"context_line":"    except Exception as e:"},{"line_number":570,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":571,"context_line":"            LOG.exception(_LE(\"Unable to execute %(cmd)s. \""},{"line_number":572,"context_line":"                              \"Exception: %(exception)s\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_b552c832","line":569,"in_reply_to":"5a890539_9297b0eb","updated":"2014-11-17 01:07:18.000000000","message":"this pattern is commonly used in this file.\nbut i changed it to RuntimeError.","commit_id":"163b02b07652660c2e98b622f520b9367c184151"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"361668e87e1851a0bc8505348fec6eae53d83cc0","unresolved":false,"context_lines":[{"line_number":572,"context_line":"                              \"Exception: %(exception)s\"),"},{"line_number":573,"context_line":"                          {\u0027cmd\u0027: args, \u0027exception\u0027: e})"},{"line_number":574,"context_line":"    (row,) \u003d jsonutils.loads(result_str.strip())[\u0027data\u0027]"},{"line_number":575,"context_line":"    (name,) \u003d row"},{"line_number":576,"context_line":"    return name"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_522d48a7","line":575,"updated":"2014-11-15 00:31:45.000000000","message":"why not just: return jsonutils.loads(result_str.strip())[\u0027data\u0027][0][0]","commit_id":"163b02b07652660c2e98b622f520b9367c184151"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e055b96cb2afdeac4c1bee84abc0e5e1f5603ff1","unresolved":false,"context_lines":[{"line_number":572,"context_line":"                              \"Exception: %(exception)s\"),"},{"line_number":573,"context_line":"                          {\u0027cmd\u0027: args, \u0027exception\u0027: e})"},{"line_number":574,"context_line":"    (row,) \u003d jsonutils.loads(result_str.strip())[\u0027data\u0027]"},{"line_number":575,"context_line":"    (name,) \u003d row"},{"line_number":576,"context_line":"    return name"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_153b9ceb","line":575,"in_reply_to":"5a890539_522d48a7","updated":"2014-11-17 01:07:18.000000000","message":"because i want to ensure that lists have appropriate number of elements.","commit_id":"163b02b07652660c2e98b622f520b9367c184151"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"361668e87e1851a0bc8505348fec6eae53d83cc0","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                          {\u0027cmd\u0027: args, \u0027exception\u0027: e})"},{"line_number":574,"context_line":"    (row,) \u003d jsonutils.loads(result_str.strip())[\u0027data\u0027]"},{"line_number":575,"context_line":"    (name,) \u003d row"},{"line_number":576,"context_line":"    return name"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"def _build_flow_expr_str(flow_dict, cmd):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_f2155449","line":576,"updated":"2014-11-15 00:31:45.000000000","message":"and what if we cannot find the bridge of the datapath_id?\nI tried, it  returned :{\"data\":[],\"headings\":[\"name\"]}\nand\n\n (row,) \u003d jsonutils.loads(\u0027{\"data\":[],\"headings\":[\"name\"]}\u0027)[\u0027data\u0027]\nTraceback (most recent call last):\n\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n\nValueError: need more than 0 values to unpack","commit_id":"163b02b07652660c2e98b622f520b9367c184151"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e055b96cb2afdeac4c1bee84abc0e5e1f5603ff1","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                          {\u0027cmd\u0027: args, \u0027exception\u0027: e})"},{"line_number":574,"context_line":"    (row,) \u003d jsonutils.loads(result_str.strip())[\u0027data\u0027]"},{"line_number":575,"context_line":"    (name,) \u003d row"},{"line_number":576,"context_line":"    return name"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"def _build_flow_expr_str(flow_dict, cmd):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_5528c499","line":576,"in_reply_to":"5a890539_f2155449","updated":"2014-11-17 01:07:18.000000000","message":"fixed","commit_id":"163b02b07652660c2e98b622f520b9367c184151"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"fd3ec06ce9e0716838843bbb489b94f968650f58","unresolved":false,"context_lines":[{"line_number":570,"context_line":"    \"\"\""},{"line_number":571,"context_line":"    args \u003d [\"ovs-vsctl\", \"--timeout\u003d%d\" % cfg.CONF.ovs_vsctl_timeout,"},{"line_number":572,"context_line":"            \"--format\u003djson\", \"--\", \"--columns\u003dname\","},{"line_number":573,"context_line":"            \"find\", \"Bridge\", \"datapath_id\u003d%s\" % datapath_id]"},{"line_number":574,"context_line":"    try:"},{"line_number":575,"context_line":"        result_str \u003d utils.execute(args, root_helper\u003droot_helper)"},{"line_number":576,"context_line":"    except RuntimeError as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_189f5104","line":573,"updated":"2014-11-17 02:38:47.000000000","message":"regarding how to pass in datapath_id, I have a bridge with datapath_id \"0000ca94b780a24d\":\n\ngongysh@localhost:/opt/stack/neutron$ sudo ovs-vsctl --timeout\u003d100 --format\u003djson -- --columns\u003dname find bridge datapath_id\u003d0000ca94b780a24d\n\n{\"data\":[[\"br-ex\"]],\"headings\":[\"name\"]}\n\ngongysh@localhost:/opt/stack/neutron$ sudo ovs-vsctl --timeout\u003d100 --format\u003djson -- --columns\u003dname find bridge datapath_id\u003d0x0000ca94b780a24d\n{\"data\":[],\"headings\":[\"name\"]}\n\ngongysh@localhost:/opt/stack/neutron$ python\nPython 2.7.5 (default, Nov  3 2014, 14:26:24) \n[GCC 4.8.3 20140911 (Red Hat 4.8.3-7)] on linux2\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e \"xx \u003d%s\" % 0x0000ca94b780a24d\n\u0027xx \u003d222740082631245\u0027\n\n\u003e\u003e\u003e quit()\ngongysh@localhost:/opt/stack/neutron$ sudo ovs-vsctl --timeout\u003d100 --format\u003djson -- --columns\u003dname find bridge datapath_id\u003d222740082631245\n{\"data\":[],\"headings\":[\"name\"]}","commit_id":"25edc1acdc895b8445e517a8eb21edd1f1fe89f3"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"814d11e32dfdc46e4cc466c41077f1faabde6c99","unresolved":false,"context_lines":[{"line_number":567,"context_line":"    message \u003d _(\"Datapath with ID %(datapath_id)s not found\")"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"def get_bridge_name_for_datapath_id(root_helper, datapath_id):"},{"line_number":571,"context_line":"    \"\"\"Return the name of the bridge with the given datapath-id"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    :param datapath_id: datapath-id as a hex string"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_5c85a9cd","line":570,"updated":"2015-01-13 20:06:46.000000000","message":"According to [1], the function should be a method of BaseOVS and it allows to use BaseOVS.run_vsctl instead of utils.execute.\n\n\n[1] https://review.openstack.org/#/c/141134/12/neutron/agent/linux/ovs_lib.py","commit_id":"94f7ac7d6a67381973129357ac274460b3c9b043"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1ab19ad3df00606438f24f5edd86d9b3f10f8485","unresolved":false,"context_lines":[{"line_number":567,"context_line":"    message \u003d _(\"Datapath with ID %(datapath_id)s not found\")"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"def get_bridge_name_for_datapath_id(root_helper, datapath_id):"},{"line_number":571,"context_line":"    \"\"\"Return the name of the bridge with the given datapath-id"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    :param datapath_id: datapath-id as a hex string"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_a019f4d2","line":570,"in_reply_to":"3a961159_5c85a9cd","updated":"2015-01-14 05:27:48.000000000","message":"i\u0027ll update.  thank you.","commit_id":"94f7ac7d6a67381973129357ac274460b3c9b043"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"45374a3aaa4ed72c43058f9c83db2d5347e0220d","unresolved":false,"context_lines":[{"line_number":567,"context_line":"    message \u003d _(\"Datapath with ID %(datapath_id)s not found\")"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"def get_bridge_name_for_datapath_id(root_helper, datapath_id):"},{"line_number":571,"context_line":"    \"\"\"Return the name of the bridge with the given datapath-id"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    :param datapath_id: datapath-id as a hex string"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_e0969cee","line":570,"in_reply_to":"3a961159_a019f4d2","updated":"2015-01-14 05:34:55.000000000","message":"after looking further, i found that the patch you referred has not merged yet.\nso i don\u0027t think i should update this patch for it right now.","commit_id":"94f7ac7d6a67381973129357ac274460b3c9b043"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"cc1dab4ad86b318a1ac4a884a4a61391c899b994","unresolved":false,"context_lines":[{"line_number":567,"context_line":"    message \u003d _(\"Datapath with ID %(datapath_id)s not found\")"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"def get_bridge_name_for_datapath_id(root_helper, datapath_id):"},{"line_number":571,"context_line":"    \"\"\"Return the name of the bridge with the given datapath-id"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    :param datapath_id: datapath-id as a hex string"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_e34d7473","line":570,"in_reply_to":"3a961159_e0969cee","updated":"2015-01-16 00:20:18.000000000","message":"as the patch in question has been merged now, i\u0027ll update this later.","commit_id":"94f7ac7d6a67381973129357ac274460b3c9b043"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"814d11e32dfdc46e4cc466c41077f1faabde6c99","unresolved":false,"context_lines":[{"line_number":591,"context_line":"    data \u003d jsonutils.loads(result_str.strip())[\u0027data\u0027]"},{"line_number":592,"context_line":"    if not data:"},{"line_number":593,"context_line":"        raise DatapathIdNotFound(datapath_id\u003ddatapath_id)"},{"line_number":594,"context_line":"    (row,) \u003d data"},{"line_number":595,"context_line":"    (name,) \u003d row"},{"line_number":596,"context_line":"    return name"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_1cdfa10d","line":594,"updated":"2015-01-13 20:06:46.000000000","message":"() are not required and \"name \u003d data[0][0]\" seems clearer","commit_id":"94f7ac7d6a67381973129357ac274460b3c9b043"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8583b4dbd3c1c7d6dc630155b4d1741f1ba9fa5a","unresolved":false,"context_lines":[{"line_number":591,"context_line":"    data \u003d jsonutils.loads(result_str.strip())[\u0027data\u0027]"},{"line_number":592,"context_line":"    if not data:"},{"line_number":593,"context_line":"        raise DatapathIdNotFound(datapath_id\u003ddatapath_id)"},{"line_number":594,"context_line":"    (row,) \u003d data"},{"line_number":595,"context_line":"    (name,) \u003d row"},{"line_number":596,"context_line":"    return name"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_80c6b866","line":594,"in_reply_to":"3a961159_1cdfa10d","updated":"2015-01-14 05:15:49.000000000","message":"the intention of this coding is to ensure the number of items in the tuple.","commit_id":"94f7ac7d6a67381973129357ac274460b3c9b043"}],"neutron/tests/functional/agent/linux/test_ovs_lib.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"b76681250c040661c7d7d2f64fa817853e665bf7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def setUp(self):"},{"line_number":23,"context_line":"        super(TestOvsLib, self).setUp()"},{"line_number":24,"context_line":"        self.bridge \u003d self.create_ovs_bridge()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_get_bridge_name_for_datapath_id(self):"},{"line_number":27,"context_line":"        datapath_id \u003d self.bridge.get_datapath_id()"},{"line_number":28,"context_line":"        name \u003d ovs_lib.get_bridge_name_for_datapath_id(self.root_helper,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_31f0b190","line":25,"updated":"2014-11-16 09:24:51.000000000","message":"You should have negative tests... What if the ID isn\u0027t found?","commit_id":"163b02b07652660c2e98b622f520b9367c184151"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9a3b824654711c5c043cdda3f7c89eb1178bc0be","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def setUp(self):"},{"line_number":23,"context_line":"        super(TestOvsLib, self).setUp()"},{"line_number":24,"context_line":"        self.bridge \u003d self.create_ovs_bridge()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_get_bridge_name_for_datapath_id(self):"},{"line_number":27,"context_line":"        datapath_id \u003d self.bridge.get_datapath_id()"},{"line_number":28,"context_line":"        name \u003d ovs_lib.get_bridge_name_for_datapath_id(self.root_helper,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_5816394d","line":25,"in_reply_to":"5a890539_31f0b190","updated":"2014-11-17 01:07:44.000000000","message":"Done","commit_id":"163b02b07652660c2e98b622f520b9367c184151"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"fd3ec06ce9e0716838843bbb489b94f968650f58","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class TestOvsLib(base.BaseOVSLinuxTestCase):"},{"line_number":22,"context_line":"    def setUp(self):"},{"line_number":23,"context_line":"        super(TestOvsLib, self).setUp()"},{"line_number":24,"context_line":"        self.bridge \u003d self.create_ovs_bridge()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_get_bridge_name_for_datapath_id(self):"},{"line_number":27,"context_line":"        datapath_id \u003d self.bridge.get_datapath_id()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_d815c99c","line":24,"updated":"2014-11-17 02:38:47.000000000","message":"Is there a place to delete the created bridge?","commit_id":"25edc1acdc895b8445e517a8eb21edd1f1fe89f3"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d5e97ceff23eb799f577c5e66c882743252e324","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class TestOvsLib(base.BaseOVSLinuxTestCase):"},{"line_number":22,"context_line":"    def setUp(self):"},{"line_number":23,"context_line":"        super(TestOvsLib, self).setUp()"},{"line_number":24,"context_line":"        self.bridge \u003d self.create_ovs_bridge()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_get_bridge_name_for_datapath_id(self):"},{"line_number":27,"context_line":"        datapath_id \u003d self.bridge.get_datapath_id()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_3847ad78","line":24,"in_reply_to":"5a890539_d815c99c","updated":"2014-11-17 02:48:06.000000000","message":"create_ovs_bridge adds its cleanup hook by itself.","commit_id":"25edc1acdc895b8445e517a8eb21edd1f1fe89f3"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"fd3ec06ce9e0716838843bbb489b94f968650f58","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # the top most bits 0."},{"line_number":36,"context_line":"        self.assertRaises(ovs_lib.DatapathIdNotFound,"},{"line_number":37,"context_line":"                          ovs_lib.get_bridge_name_for_datapath_id,"},{"line_number":38,"context_line":"                          self.root_helper, 0xffff000000000000)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_d8ca291a","line":38,"updated":"2014-11-17 02:38:47.000000000","message":"I am afraid we should not pass in number format, we should just use the string \"ffff000000000000\"","commit_id":"25edc1acdc895b8445e517a8eb21edd1f1fe89f3"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d5e97ceff23eb799f577c5e66c882743252e324","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # the top most bits 0."},{"line_number":36,"context_line":"        self.assertRaises(ovs_lib.DatapathIdNotFound,"},{"line_number":37,"context_line":"                          ovs_lib.get_bridge_name_for_datapath_id,"},{"line_number":38,"context_line":"                          self.root_helper, 0xffff000000000000)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_7875b5c9","line":38,"in_reply_to":"5a890539_d8ca291a","updated":"2014-11-17 02:48:06.000000000","message":"right.","commit_id":"25edc1acdc895b8445e517a8eb21edd1f1fe89f3"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e060d9ac7adbcf46695c41581a1f8838d3956579","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2014 VA Linux Systems Japan K.K."},{"line_number":2,"context_line":"# Copyright (C) 2014 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_9db95dce","line":1,"updated":"2014-11-17 16:54:41.000000000","message":"Please remove this copyright","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d44dc44e0b38670922553d89f5334dde208f246f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2014 VA Linux Systems Japan K.K."},{"line_number":2,"context_line":"# Copyright (C) 2014 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_229814cc","line":1,"in_reply_to":"5a890539_22059313","updated":"2014-12-05 07:44:56.000000000","message":"i left this because, looking at recently merged patches, there seems no consensus.","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"81c92e0a378a37041c0b65d03e7924f8b9b05073","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2014 VA Linux Systems Japan K.K."},{"line_number":2,"context_line":"# Copyright (C) 2014 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_a21fc359","line":1,"in_reply_to":"5a890539_2e701f71","updated":"2014-11-18 04:35:47.000000000","message":"who is \"we\" here?\nwho recommended it?\nis it a recommendation or a requirement?\ndo you have any references?","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"20a96f62c4a5058e5faec9a2490ee23051b69b8b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2014 VA Linux Systems Japan K.K."},{"line_number":2,"context_line":"# Copyright (C) 2014 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_ae532f15","line":1,"in_reply_to":"5a890539_7f29fb88","updated":"2014-11-18 03:29:23.000000000","message":"Vendor copyrights aren\u0027t referenced a norm on core openstack files.","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c87e5a99c90e086a2f9699dc3a2775714cdf6cc5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2014 VA Linux Systems Japan K.K."},{"line_number":2,"context_line":"# Copyright (C) 2014 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_7f29fb88","line":1,"in_reply_to":"5a890539_9db95dce","updated":"2014-11-17 23:23:56.000000000","message":"why?","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"0966e8950983bf6a54ae9c37d2a48e05bbf7d32a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2014 VA Linux Systems Japan K.K."},{"line_number":2,"context_line":"# Copyright (C) 2014 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_22059313","line":1,"in_reply_to":"5a890539_a21fc359","updated":"2014-11-18 05:34:51.000000000","message":"we here meant the dvr side developers.  \r\n\r\nIt is a recommendation.\r\n\r\nTake it or leave it...","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"11905043e6a73be3e1892e0dae9968541636fb6f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2014 VA Linux Systems Japan K.K."},{"line_number":2,"context_line":"# Copyright (C) 2014 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_cec95bad","line":1,"in_reply_to":"5a890539_ae532f15","updated":"2014-11-18 03:40:30.000000000","message":"can you explain a bit further?\nactually there are a lot of core openstack files with vendor copyrights.","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e1e7626d751b94957553ffd1c0202815a01e58b5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2014 VA Linux Systems Japan K.K."},{"line_number":2,"context_line":"# Copyright (C) 2014 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_2e701f71","line":1,"in_reply_to":"5a890539_cec95bad","updated":"2014-11-18 03:43:38.000000000","message":"What is probably out there need to be fixed.  \r\n\r\nWhen we committed features for juno, we were recommended to use copyright as below:\r\n\r\n# Copyright (c) 2014 OpenStack Foundation.  All rights reserved.","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e060d9ac7adbcf46695c41581a1f8838d3956579","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def test_get_bridge_name_for_datapath_id_nonexistent(self):"},{"line_number":33,"context_line":"        # NOTE(yamamoto): The datapath-id below can not be found because"},{"line_number":34,"context_line":"        # datapath-id auto-generated by Open vSwitch always have"},{"line_number":35,"context_line":"        # the top most bits 0."},{"line_number":36,"context_line":"        self.assertRaises(ovs_lib.DatapathIdNotFound,"},{"line_number":37,"context_line":"                          ovs_lib.get_bridge_name_for_datapath_id,"},{"line_number":38,"context_line":"                          self.root_helper, \"ffff000000000000\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_7dd591e3","line":35,"updated":"2014-11-17 16:54:41.000000000","message":"nit: You may want to say LSB is 0 , instead of \u0027top most\u0027 Ybits.","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d44dc44e0b38670922553d89f5334dde208f246f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def test_get_bridge_name_for_datapath_id_nonexistent(self):"},{"line_number":33,"context_line":"        # NOTE(yamamoto): The datapath-id below can not be found because"},{"line_number":34,"context_line":"        # datapath-id auto-generated by Open vSwitch always have"},{"line_number":35,"context_line":"        # the top most bits 0."},{"line_number":36,"context_line":"        self.assertRaises(ovs_lib.DatapathIdNotFound,"},{"line_number":37,"context_line":"                          ovs_lib.get_bridge_name_for_datapath_id,"},{"line_number":38,"context_line":"                          self.root_helper, \"ffff000000000000\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_621dbc62","line":35,"in_reply_to":"5a890539_2e757fca","updated":"2014-12-05 07:44:56.000000000","message":"i commented the assumption here.","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"81c92e0a378a37041c0b65d03e7924f8b9b05073","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def test_get_bridge_name_for_datapath_id_nonexistent(self):"},{"line_number":33,"context_line":"        # NOTE(yamamoto): The datapath-id below can not be found because"},{"line_number":34,"context_line":"        # datapath-id auto-generated by Open vSwitch always have"},{"line_number":35,"context_line":"        # the top most bits 0."},{"line_number":36,"context_line":"        self.assertRaises(ovs_lib.DatapathIdNotFound,"},{"line_number":37,"context_line":"                          ovs_lib.get_bridge_name_for_datapath_id,"},{"line_number":38,"context_line":"                          self.root_helper, \"ffff000000000000\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_2e757fca","line":35,"in_reply_to":"5a890539_2e7adf23","updated":"2014-11-18 04:35:47.000000000","message":"given that you can create bridges with any datapath-id at any time,\nthere are no guaranteed to be safe id to use here.\nwhile the current value here is merely a guess of unlikely-used value,\ni don\u0027t consider it a problem.\n\nalternatives i can think of right now are:\n- do not have negative tests\n- try many ids and declare success if any of them raises","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"9d299ed2714914e5a1185285049fc47606fd125b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def test_get_bridge_name_for_datapath_id_nonexistent(self):"},{"line_number":33,"context_line":"        # NOTE(yamamoto): The datapath-id below can not be found because"},{"line_number":34,"context_line":"        # datapath-id auto-generated by Open vSwitch always have"},{"line_number":35,"context_line":"        # the top most bits 0."},{"line_number":36,"context_line":"        self.assertRaises(ovs_lib.DatapathIdNotFound,"},{"line_number":37,"context_line":"                          ovs_lib.get_bridge_name_for_datapath_id,"},{"line_number":38,"context_line":"                          self.root_helper, \"ffff000000000000\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_2e7adf23","line":35,"in_reply_to":"5a890539_4ebd6b01","updated":"2014-11-18 04:00:25.000000000","message":"so why not try datapath id 1 which must be not found","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c87e5a99c90e086a2f9699dc3a2775714cdf6cc5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def test_get_bridge_name_for_datapath_id_nonexistent(self):"},{"line_number":33,"context_line":"        # NOTE(yamamoto): The datapath-id below can not be found because"},{"line_number":34,"context_line":"        # datapath-id auto-generated by Open vSwitch always have"},{"line_number":35,"context_line":"        # the top most bits 0."},{"line_number":36,"context_line":"        self.assertRaises(ovs_lib.DatapathIdNotFound,"},{"line_number":37,"context_line":"                          ovs_lib.get_bridge_name_for_datapath_id,"},{"line_number":38,"context_line":"                          self.root_helper, \"ffff000000000000\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_7f501b0b","line":35,"in_reply_to":"5a890539_7dd591e3","updated":"2014-11-17 23:23:56.000000000","message":"i meant MSBs.\nauto-generated ids look like 0000xxxxxxxxxxxx.","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"35536815597f803c8f741b1730c2c967ae739101","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def test_get_bridge_name_for_datapath_id_nonexistent(self):"},{"line_number":33,"context_line":"        # NOTE(yamamoto): The datapath-id below can not be found because"},{"line_number":34,"context_line":"        # datapath-id auto-generated by Open vSwitch always have"},{"line_number":35,"context_line":"        # the top most bits 0."},{"line_number":36,"context_line":"        self.assertRaises(ovs_lib.DatapathIdNotFound,"},{"line_number":37,"context_line":"                          ovs_lib.get_bridge_name_for_datapath_id,"},{"line_number":38,"context_line":"                          self.root_helper, \"ffff000000000000\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_ee0b7721","line":35,"in_reply_to":"5a890539_7f501b0b","updated":"2014-11-18 03:23:05.000000000","message":"what if user use \"\novs-vsctl set bridge \u003cmybr\u003e other-config:datapath-id\u003d\u003cdatapathid\u003e\" to set it ...","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"11905043e6a73be3e1892e0dae9968541636fb6f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def test_get_bridge_name_for_datapath_id_nonexistent(self):"},{"line_number":33,"context_line":"        # NOTE(yamamoto): The datapath-id below can not be found because"},{"line_number":34,"context_line":"        # datapath-id auto-generated by Open vSwitch always have"},{"line_number":35,"context_line":"        # the top most bits 0."},{"line_number":36,"context_line":"        self.assertRaises(ovs_lib.DatapathIdNotFound,"},{"line_number":37,"context_line":"                          ovs_lib.get_bridge_name_for_datapath_id,"},{"line_number":38,"context_line":"                          self.root_helper, \"ffff000000000000\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_4ebd6b01","line":35,"in_reply_to":"5a890539_ee0b7721","updated":"2014-11-18 03:40:30.000000000","message":"in that case this test fails,\ndo you think it\u0027s a problem?","commit_id":"160ad40a66f29941707faa468c0dbbad53d081dd"}]}
