)]}'
{"quantum/db/l3_db.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b0229ec8dda82e76261ef80aa72013646e6b6165","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        try:"},{"line_number":256,"context_line":"            rport_qry \u003d context.session.query(models_v2.Port)"},{"line_number":257,"context_line":"            rports \u003d rport_qry.filter_by("},{"line_number":258,"context_line":"                device_id\u003drouter_id,).all()"},{"line_number":259,"context_line":"            # its possible these ports on on the same network, but"},{"line_number":260,"context_line":"            # different subnet"},{"line_number":261,"context_line":"            new_cidr \u003d self._get_subnet(context, subnet_id)[\u0027cidr\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FStk%3D","line":258,"updated":"2012-09-25 14:14:42.000000000","message":"A trailing comma after \"router_id\" seems to be unnecessary.","commit_id":"342e37624a96b6d08d4605b7c1f88176a7405397"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":196,"context_line":"            subnets \u003d self._get_subnets_by_network(context,"},{"line_number":197,"context_line":"                                                   network_id)"},{"line_number":198,"context_line":"            for subnet in subnets:"},{"line_number":199,"context_line":"                self._check_for_dup_router_subnet(context, router_id,"},{"line_number":200,"context_line":"                                                  network_id, subnet[\u0027id\u0027])"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"            # Port has no \u0027tenant-id\u0027, as it is hidden from user"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2F0Y0%3D","line":199,"updated":"2012-11-04 07:16:44.000000000","message":"When I tested the code I Got the following error message:\nopenstack@openstack:~/devstack$ quantum router-interface-add 5fae46f1-75f2-4211-a298-4c6dbae07b65 e5d323f2-aef0-4d24-b693-61be4b1c365f\nUnable to find subnet with name \u0027e5d323f2-aef0-4d24-b693-61be4b1c365f\u0027\n\nMaybe consider having a appropriate error message here.","commit_id":"9343c44818ba8b472903973bfd190e478062ef83"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":196,"context_line":"            subnets \u003d self._get_subnets_by_network(context,"},{"line_number":197,"context_line":"                                                   network_id)"},{"line_number":198,"context_line":"            for subnet in subnets:"},{"line_number":199,"context_line":"                self._check_for_dup_router_subnet(context, router_id,"},{"line_number":200,"context_line":"                                                  network_id, subnet[\u0027id\u0027])"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"            # Port has no \u0027tenant-id\u0027, as it is hidden from user"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2Fz30%3D","line":199,"in_reply_to":"AAAALn%2F%2F0Y0%3D","updated":"2012-11-05 14:00:28.000000000","message":"This message is produced by quantum client side (quantumclient/quantum/v2_0/__init__.py find_resourceid_by_name_or_id), so it should be fixed by a separate patch.","commit_id":"9343c44818ba8b472903973bfd190e478062ef83"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":196,"context_line":"            subnets \u003d self._get_subnets_by_network(context,"},{"line_number":197,"context_line":"                                                   network_id)"},{"line_number":198,"context_line":"            for subnet in subnets:"},{"line_number":199,"context_line":"                self._check_for_dup_router_subnet(context, router_id,"},{"line_number":200,"context_line":"                                                  network_id, subnet[\u0027id\u0027])"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"            # Port has no \u0027tenant-id\u0027, as it is hidden from user"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2Fzs0%3D","line":199,"in_reply_to":"AAAALn%2F%2Fz30%3D","updated":"2012-11-05 16:23:28.000000000","message":"Correct my bad.","commit_id":"9343c44818ba8b472903973bfd190e478062ef83"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"6dc8510468584bee07b7d88f2e4db92ce4d61f79","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                                    filters\u003dfilters, fields\u003dfields)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def _check_for_dup_router_subnet(self, context, router_id,"},{"line_number":255,"context_line":"                                     network_id, subnet_id):"},{"line_number":256,"context_line":"        try:"},{"line_number":257,"context_line":"            rport_qry \u003d context.session.query(models_v2.Port)"},{"line_number":258,"context_line":"            rports \u003d rport_qry.filter_by("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2F0jY%3D","line":255,"updated":"2012-11-03 12:16:43.000000000","message":"This isn\u0027t your patch problem. \u0027network_id\u0027 looks like unuseful in this function.","commit_id":"9343c44818ba8b472903973bfd190e478062ef83"}],"quantum/tests/unit/test_l3_plugin.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":578,"context_line":"                                                     s[\u0027subnet\u0027][\u0027id\u0027],"},{"line_number":579,"context_line":"                                                     None)"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"    def test_router_add_gateway_dup_subnet2(self):"},{"line_number":582,"context_line":"        with self.router() as r:"},{"line_number":583,"context_line":"            with self.subnet() as s:"},{"line_number":584,"context_line":"                self._set_net_external(s[\u0027subnet\u0027][\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALn%2F%2F0dk%3D","line":581,"updated":"2012-11-03 19:42:55.000000000","message":"Minor suggestion - I guess the general convention has been to use more meaningful function names rather than alphabets/numerals as prefixes/suffixes to distinguish/order  functions.","commit_id":"9343c44818ba8b472903973bfd190e478062ef83"}]}