)]}'
{"quantum/db/db_base_plugin_v2.py":[{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"0efca5cc960c8ef7f0f756ba6c46f3deb40384eb","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        #                must override __init__ and setup the database"},{"line_number":72,"context_line":"        #                and not call into this class\u0027s __init__."},{"line_number":73,"context_line":"        #                This connection is setup as memory for the tests."},{"line_number":74,"context_line":"        sql_connection \u003d \u0027sqlite:///quantum.test.db\u0027"},{"line_number":75,"context_line":"        db.configure_db({\u0027sql_connection\u0027: sql_connection,"},{"line_number":76,"context_line":"                         \u0027base\u0027: models_v2.model_base.BASEV2})"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FT%2BU%3D","line":74,"updated":"2012-09-22 15:38:57.000000000","message":"Where does this store the file? Unit tests are run as a normal user, so cannot require write access to /.","commit_id":"6774d4e4a46c9eccb12b30ea722aebe049ab4c92"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":71,"context_line":"        #                must override __init__ and setup the database"},{"line_number":72,"context_line":"        #                and not call into this class\u0027s __init__."},{"line_number":73,"context_line":"        #                This connection is setup as memory for the tests."},{"line_number":74,"context_line":"        sql_connection \u003d \u0027sqlite:///quantum.test.db\u0027"},{"line_number":75,"context_line":"        db.configure_db({\u0027sql_connection\u0027: sql_connection,"},{"line_number":76,"context_line":"                         \u0027base\u0027: models_v2.model_base.BASEV2})"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FT7c%3D","line":74,"in_reply_to":"AAAALH%2F%2FT%2BU%3D","updated":"2012-09-22 21:50:04.000000000","message":"sqlite:///  is the prefix for relative paths\nsqlite://// is the prefix for absolute paths\n\nI think storing the tests in the local directory where they are run it\u0027s ok. The user executing the tests should have write permission to it (after all he/she is developing in that directory)","commit_id":"6774d4e4a46c9eccb12b30ea722aebe049ab4c92"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":72,"context_line":"        #                must override __init__ and setup the database"},{"line_number":73,"context_line":"        #                and not call into this class\u0027s __init__."},{"line_number":74,"context_line":"        #                This connection is setup as memory for the tests."},{"line_number":75,"context_line":"        db.configure_db({\u0027sql_connection\u0027: \"sqlite:///%s\" % TEST_DB,"},{"line_number":76,"context_line":"                         \u0027base\u0027: models_v2.model_base.BASEV2})"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _get_tenant_id_for_create(self, context, resource):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FT3k%3D","line":75,"updated":"2012-09-23 05:26:04.000000000","message":"Why not use - cfg.CONF.DATABASE.sql_connection\nIf I understand correctly this should be read from the test configuration file and you have updated that to include the test db.","commit_id":"ef68494072438ec1f694314139ff37ae33655f9d"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":72,"context_line":"        #                must override __init__ and setup the database"},{"line_number":73,"context_line":"        #                and not call into this class\u0027s __init__."},{"line_number":74,"context_line":"        #                This connection is setup as memory for the tests."},{"line_number":75,"context_line":"        db.configure_db({\u0027sql_connection\u0027: \"sqlite:///%s\" % TEST_DB,"},{"line_number":76,"context_line":"                         \u0027base\u0027: models_v2.model_base.BASEV2})"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _get_tenant_id_for_create(self, context, resource):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FT14%3D","line":75,"in_reply_to":"AAAALH%2F%2FT3k%3D","updated":"2012-09-23 12:26:42.000000000","message":"I wanted to, but this base plugin does not import any configuration module besides quantum.openstack.common.cfg; this means that cfg.CONF.DATABASE.sql_connection is not registered yet - registering it here might then cause an exception for derived plugins.\n\nLet me see if I can do anything better here.","commit_id":"ef68494072438ec1f694314139ff37ae33655f9d"}],"quantum/tests/etc/quantum.conf.test":[{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"0efca5cc960c8ef7f0f756ba6c46f3deb40384eb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"rpc_backend \u003d quantum.openstack.common.rpc.impl_fake"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[DATABASE]"},{"line_number":24,"context_line":"sql_connection \u003d \u0027sqlite:///quantum.test.db\u0027"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAALH%2F%2FT%2BQ%3D","line":24,"updated":"2012-09-22 15:38:57.000000000","message":"Why does this need to be set if its the default?","commit_id":"6774d4e4a46c9eccb12b30ea722aebe049ab4c92"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":21,"context_line":"rpc_backend \u003d quantum.openstack.common.rpc.impl_fake"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[DATABASE]"},{"line_number":24,"context_line":"sql_connection \u003d \u0027sqlite:///quantum.test.db\u0027"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAALH%2F%2FT7Y%3D","line":24,"in_reply_to":"AAAALH%2F%2FT%2BQ%3D","updated":"2012-09-22 21:50:04.000000000","message":"Good point. Actually QuantumDBPluginV2 is the only plugin which does not use a configuration file.\nHence I added the path to the test db in the __init__ method.\n\nAll the other plugins load it from the configuration file. And most of them do not even invoke __init__ in QuantumDBPluginV2 (ad you know very well given the amount of work you\u0027ve done with OVS \u0026 LB plugins)\n\nSo I think it is acceptable to leave the name of the test db in the __init__ method of QuantumDBPluginV2.","commit_id":"6774d4e4a46c9eccb12b30ea722aebe049ab4c92"}],"quantum/tests/unit/openvswitch/test_openvswitch_plugin.py":[{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"0efca5cc960c8ef7f0f756ba6c46f3deb40384eb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"#class TestOpenvswitchSubnetsV2(test_plugin.TestSubnetsV2,"},{"line_number":49,"context_line":"#                               OpenvswitchPluginV2TestCase):"},{"line_number":50,"context_line":"#    pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FT%2BM%3D","line":48,"updated":"2012-09-22 15:38:57.000000000","message":"I\u0027d prefer not to leave commented out code. Similar code for linuxbridge was removed.","commit_id":"6774d4e4a46c9eccb12b30ea722aebe049ab4c92"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"    pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"#class TestOpenvswitchSubnetsV2(test_plugin.TestSubnetsV2,"},{"line_number":49,"context_line":"#                               OpenvswitchPluginV2TestCase):"},{"line_number":50,"context_line":"#    pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FT7U%3D","line":48,"in_reply_to":"AAAALH%2F%2FT%2BM%3D","updated":"2012-09-22 21:50:04.000000000","message":"Thanks I forgot to remove this code.\nI hope you agree with removing these unit tests - they don\u0027t actually add any coverage as the plugins do not override these methods from the base DB plugin.","commit_id":"6774d4e4a46c9eccb12b30ea722aebe049ab4c92"}]}
