)]}'
{"quantum/rootwrap/filters.py":[{"author":{"_account_id":2974,"name":"jrd-q","email":"jrd@redhat.com","username":"jrd-q"},"change_message_id":"5465397117fe815451e8ed9f6058f41f95df575e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        not using netns) or \"ip\" \"netns\" \"exec\" \u003cfoo\u003e \"dnsmasq\""},{"line_number":119,"context_line":"        (for the case where we are)\"\"\""},{"line_number":120,"context_line":"        if (userargs[0].startswith(\"QUANTUM_RELAY_SOCKET_PATH\u003d\") and"},{"line_number":121,"context_line":"            userargs[1].startswith(\"QUANTUM_NETWORK_ID\u003d\") and"},{"line_number":122,"context_line":"            self.is_ip_netns_cmd(userargs[2:]) and"},{"line_number":123,"context_line":"            self.is_dnsmasq_cmd(userargs[6:])):"},{"line_number":124,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FTg8%3D","line":121,"updated":"2012-09-24 15:19:18.000000000","message":"Would it be worth trying to hoist out the common tests for env vars into a method on the base class?  I\u0027m thinking in terms of future code maintainability...","commit_id":"1f866911d1e16f7f52b7df4acf3dd4121ad7e1fd"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":118,"context_line":"        not using netns) or \"ip\" \"netns\" \"exec\" \u003cfoo\u003e \"dnsmasq\""},{"line_number":119,"context_line":"        (for the case where we are)\"\"\""},{"line_number":120,"context_line":"        if (userargs[0].startswith(\"QUANTUM_RELAY_SOCKET_PATH\u003d\") and"},{"line_number":121,"context_line":"            userargs[1].startswith(\"QUANTUM_NETWORK_ID\u003d\") and"},{"line_number":122,"context_line":"            self.is_ip_netns_cmd(userargs[2:]) and"},{"line_number":123,"context_line":"            self.is_dnsmasq_cmd(userargs[6:])):"},{"line_number":124,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FTgA%3D","line":121,"in_reply_to":"AAAALH%2F%2FTg8%3D","updated":"2012-09-24 15:40:26.000000000","message":"+1","commit_id":"1f866911d1e16f7f52b7df4acf3dd4121ad7e1fd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":118,"context_line":"        not using netns) or \"ip\" \"netns\" \"exec\" \u003cfoo\u003e \"dnsmasq\""},{"line_number":119,"context_line":"        (for the case where we are)\"\"\""},{"line_number":120,"context_line":"        if (userargs[0].startswith(\"QUANTUM_RELAY_SOCKET_PATH\u003d\") and"},{"line_number":121,"context_line":"            userargs[1].startswith(\"QUANTUM_NETWORK_ID\u003d\") and"},{"line_number":122,"context_line":"            self.is_ip_netns_cmd(userargs[2:]) and"},{"line_number":123,"context_line":"            self.is_dnsmasq_cmd(userargs[6:])):"},{"line_number":124,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FTeY%3D","line":121,"in_reply_to":"AAAALH%2F%2FTg8%3D","updated":"2012-09-24 16:01:58.000000000","message":"Done","commit_id":"1f866911d1e16f7f52b7df4acf3dd4121ad7e1fd"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":91,"context_line":"        \"\"\"This matches the combination of the leading env"},{"line_number":92,"context_line":"        vars, plus either \"dnsmasq\" (for the case where we\u0027re"},{"line_number":93,"context_line":"        not using netns) or \"ip\" \"netns\" \"exec\" \u003cfoo\u003e \"dnsmasq\""},{"line_number":94,"context_line":"        (for the case where we are)\"\"\""},{"line_number":95,"context_line":"        if (self.is_dnsmasq_env_vars(userargs) and"},{"line_number":96,"context_line":"            self.is_dnsmasq_cmd(userargs[2:])):"},{"line_number":97,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FTcQ%3D","line":94,"updated":"2012-09-24 16:31:02.000000000","message":"is this comment correct?  I don\u0027t see logic here to handle the netns case.  It seems like that is handled in the sub-class only.","commit_id":"99571ffa683c1f0341385af4c422e2b46b5b68b8"}]}
