)]}'
{"neutron/tests/unit/test_l3_plugin.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"40aec73d22ce41629c369f42d4cb8de2deb79421","unresolved":false,"context_lines":[{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    def test_router_add_interface_ipv6_subnet_without_gateway_ip(self):"},{"line_number":769,"context_line":"        with self.router() as r:"},{"line_number":770,"context_line":"            with self.subnet(ip_version\u003d6, cidr\u003d\u0027fe80::/64\u0027,"},{"line_number":771,"context_line":"                             gateway_ip\u003dNone) as s:"},{"line_number":772,"context_line":"                error_code \u003d exc.HTTPBadRequest.code"},{"line_number":773,"context_line":"                self._router_interface_action(\u0027add\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_df4b5d57","line":770,"updated":"2014-12-09 19:15:17.000000000","message":"s/fe80/fd00","commit_id":"66dcb8b935a00e7f7566802d662ebb1f265eab1f"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"1516bcfe9d65a6a188f4b42bdbf91619b9e4526a","unresolved":false,"context_lines":[{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    def test_router_add_interface_ipv6_subnet_without_gateway_ip(self):"},{"line_number":769,"context_line":"        with self.router() as r:"},{"line_number":770,"context_line":"            with self.subnet(ip_version\u003d6, cidr\u003d\u0027fe80::/64\u0027,"},{"line_number":771,"context_line":"                             gateway_ip\u003dNone) as s:"},{"line_number":772,"context_line":"                error_code \u003d exc.HTTPBadRequest.code"},{"line_number":773,"context_line":"                self._router_interface_action(\u0027add\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_a2b34308","line":770,"in_reply_to":"3a961159_52d997f1","updated":"2014-12-15 03:12:15.000000000","message":"I like this proposal, let\u0027s approve this code and the  make sure we address all v6 subnets in a separate patch.","commit_id":"66dcb8b935a00e7f7566802d662ebb1f265eab1f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1c88565c10b12488e1aac7e9fcb24913e590dc99","unresolved":false,"context_lines":[{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    def test_router_add_interface_ipv6_subnet_without_gateway_ip(self):"},{"line_number":769,"context_line":"        with self.router() as r:"},{"line_number":770,"context_line":"            with self.subnet(ip_version\u003d6, cidr\u003d\u0027fe80::/64\u0027,"},{"line_number":771,"context_line":"                             gateway_ip\u003dNone) as s:"},{"line_number":772,"context_line":"                error_code \u003d exc.HTTPBadRequest.code"},{"line_number":773,"context_line":"                self._router_interface_action(\u0027add\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_52d997f1","line":770,"in_reply_to":"3a961159_699965c3","updated":"2014-12-13 22:19:53.000000000","message":"Brian are you OK with fixing the allowed prefixes for v6 subnets in a separate patch? Then we can approve this patch now.","commit_id":"66dcb8b935a00e7f7566802d662ebb1f265eab1f"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"9a40ebb66d9d9bd38e4f0263944b1c6a87abb6a6","unresolved":false,"context_lines":[{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    def test_router_add_interface_ipv6_subnet_without_gateway_ip(self):"},{"line_number":769,"context_line":"        with self.router() as r:"},{"line_number":770,"context_line":"            with self.subnet(ip_version\u003d6, cidr\u003d\u0027fe80::/64\u0027,"},{"line_number":771,"context_line":"                             gateway_ip\u003dNone) as s:"},{"line_number":772,"context_line":"                error_code \u003d exc.HTTPBadRequest.code"},{"line_number":773,"context_line":"                self._router_interface_action(\u0027add\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_3c4224ae","line":770,"in_reply_to":"3a961159_699965c3","updated":"2014-12-13 15:51:23.000000000","message":"Yes its true that normally a user will not create a subnet with LLA as CIDR (similar to creating a IPv4 subnet with 169.254.x.x) but currently in Neutron we allow creation of such subnets. Even my point was that it can be taken up as a separate patch. \n\nThanks Henry and Brian for reviewing the patch.","commit_id":"66dcb8b935a00e7f7566802d662ebb1f265eab1f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"069c40f454224acd0e2b08f442cfafc3d113ae16","unresolved":false,"context_lines":[{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    def test_router_add_interface_ipv6_subnet_without_gateway_ip(self):"},{"line_number":769,"context_line":"        with self.router() as r:"},{"line_number":770,"context_line":"            with self.subnet(ip_version\u003d6, cidr\u003d\u0027fe80::/64\u0027,"},{"line_number":771,"context_line":"                             gateway_ip\u003dNone) as s:"},{"line_number":772,"context_line":"                error_code \u003d exc.HTTPBadRequest.code"},{"line_number":773,"context_line":"                self._router_interface_action(\u0027add\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_2098191b","line":770,"in_reply_to":"3a961159_a2b34308","updated":"2014-12-15 15:57:45.000000000","message":"Yes, I think we can fix the allowed prefixes in a follow-on patch.  Thanks.","commit_id":"66dcb8b935a00e7f7566802d662ebb1f265eab1f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"3032fdd2bc9a401ab75c1145db4846f31b674d4b","unresolved":false,"context_lines":[{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    def test_router_add_interface_ipv6_subnet_without_gateway_ip(self):"},{"line_number":769,"context_line":"        with self.router() as r:"},{"line_number":770,"context_line":"            with self.subnet(ip_version\u003d6, cidr\u003d\u0027fe80::/64\u0027,"},{"line_number":771,"context_line":"                             gateway_ip\u003dNone) as s:"},{"line_number":772,"context_line":"                error_code \u003d exc.HTTPBadRequest.code"},{"line_number":773,"context_line":"                self._router_interface_action(\u0027add\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_d4bd94d9","line":770,"in_reply_to":"3a961159_c2cc5964","updated":"2014-12-12 13:25:15.000000000","message":"Yes this is harmless in unit tests, although I agree with Brian it feels wrong to see a subnet being given an LLA prefix. Maybe the create subnet API should fail when given an LLA cidr? That can be investigated and a separate patch done if needed.","commit_id":"66dcb8b935a00e7f7566802d662ebb1f265eab1f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"87ea659d4273711d00905e2960f57773edd3d88d","unresolved":false,"context_lines":[{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    def test_router_add_interface_ipv6_subnet_without_gateway_ip(self):"},{"line_number":769,"context_line":"        with self.router() as r:"},{"line_number":770,"context_line":"            with self.subnet(ip_version\u003d6, cidr\u003d\u0027fe80::/64\u0027,"},{"line_number":771,"context_line":"                             gateway_ip\u003dNone) as s:"},{"line_number":772,"context_line":"                error_code \u003d exc.HTTPBadRequest.code"},{"line_number":773,"context_line":"                self._router_interface_action(\u0027add\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_699965c3","line":770,"in_reply_to":"3a961159_d4bd94d9","updated":"2014-12-12 15:55:53.000000000","message":"@Sridhar - Henry stated it better that you won\u0027t see someone add a subnet with fe80::/64 as the prefix, that was really my complaint.  I would almost think the call should fail since there\u0027s already by default an fe80::/64 on all interfaces, which is perhaps another bug.  And when that is fixed it will break this test.","commit_id":"66dcb8b935a00e7f7566802d662ebb1f265eab1f"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"b655d46e33066ecab7d5cd67d3ea4ff87778f754","unresolved":false,"context_lines":[{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    def test_router_add_interface_ipv6_subnet_without_gateway_ip(self):"},{"line_number":769,"context_line":"        with self.router() as r:"},{"line_number":770,"context_line":"            with self.subnet(ip_version\u003d6, cidr\u003d\u0027fe80::/64\u0027,"},{"line_number":771,"context_line":"                             gateway_ip\u003dNone) as s:"},{"line_number":772,"context_line":"                error_code \u003d exc.HTTPBadRequest.code"},{"line_number":773,"context_line":"                self._router_interface_action(\u0027add\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_c2cc5964","line":770,"in_reply_to":"3a961159_df4b5d57","updated":"2014-12-10 03:28:35.000000000","message":"@Brian, as you know, this is only a unit testcase and the IPv6 address (fe80::/64) is not assigned to any interface. \n\nOn the other hand, there are lots of places in Neutron unit tests where we use \"fe80::\". One example - https://github.com/openstack/neutron/blob/master/neutron/tests/unit/test_db_plugin.py#L1424","commit_id":"66dcb8b935a00e7f7566802d662ebb1f265eab1f"}]}