)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix bug 1055822"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch adds a gloval configuration option for enabling or disabling"},{"line_number":12,"context_line":"overlapping IPs for subnets in different networks."},{"line_number":13,"context_line":"If they are disabled, the validation of the CIDR against overlapping"},{"line_number":14,"context_line":"ones should be performed globally and not just among subnets defined for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAALH%2F%2FS5Q%3D","line":11,"updated":"2012-09-25 08:24:52.000000000","message":"typo - gloval \u003d\u003e global","commit_id":"65bbc84a22917d110b40b592e87d31aa48937c5e"}],"quantum/db/db_base_plugin_v2.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":649,"context_line":"                           \"overlaps with subnet: %s)\" % (new_subnet_cidr,"},{"line_number":650,"context_line":"                                                          network.id,"},{"line_number":651,"context_line":"                                                          subnet.cidr))"},{"line_number":652,"context_line":"                LOG.error(err_msg)"},{"line_number":653,"context_line":"                raise q_exc.InvalidInput(error_message\u003derr_msg)"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    def _validate_allocation_pools(self, ip_pools, gateway_ip, subnet_cidr):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FTD4%3D","side":"PARENT","line":652,"updated":"2012-09-25 00:51:15.000000000","message":"I agree that this should not be logged as an error, assuming the API properly returns an error code.  My assumption is that this will show up in the request logs as a 4XX?","commit_id":"6194ab2becbd255e6b795c828844db2f3ab85659"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":649,"context_line":"                           \"overlaps with subnet: %s)\" % (new_subnet_cidr,"},{"line_number":650,"context_line":"                                                          network.id,"},{"line_number":651,"context_line":"                                                          subnet.cidr))"},{"line_number":652,"context_line":"                LOG.error(err_msg)"},{"line_number":653,"context_line":"                raise q_exc.InvalidInput(error_message\u003derr_msg)"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    def _validate_allocation_pools(self, ip_pools, gateway_ip, subnet_cidr):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FS6Q%3D","side":"PARENT","line":652,"in_reply_to":"AAAALH%2F%2FTD4%3D","updated":"2012-09-25 07:48:59.000000000","message":"Eventually it will return a 4xx - it might make sense logging anyway for putting more details (such as the conflicting subnet)","commit_id":"6194ab2becbd255e6b795c828844db2f3ab85659"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"aed3c921995e1472fa4a507d0fa59db4dca91f94","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            # a lot of stress on the db. Consider adding a cache layer"},{"line_number":201,"context_line":"            return context.session.query(models_v2.Subnet).all()"},{"line_number":202,"context_line":"        except exc.NoResultFound:"},{"line_number":203,"context_line":"            return []"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def _fields(self, resource, fields):"},{"line_number":206,"context_line":"        if fields:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FTCQ%3D","line":203,"updated":"2012-09-25 01:18:02.000000000","message":"I don\u0027t think all() will raise NoResultFound exception.","commit_id":"afba3954f688d07dbaf148cb5bad32a566becdb5"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":200,"context_line":"            # a lot of stress on the db. Consider adding a cache layer"},{"line_number":201,"context_line":"            return context.session.query(models_v2.Subnet).all()"},{"line_number":202,"context_line":"        except exc.NoResultFound:"},{"line_number":203,"context_line":"            return []"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def _fields(self, resource, fields):"},{"line_number":206,"context_line":"        if fields:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FS6U%3D","line":203,"in_reply_to":"AAAALH%2F%2FTCQ%3D","updated":"2012-09-25 07:48:59.000000000","message":"Done","commit_id":"afba3954f688d07dbaf148cb5bad32a566becdb5"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":646,"context_line":"        \"\"\"Validate the CIDR for a subnet."},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        Verifies the specified CIDR does not overlap with the ones defined"},{"line_number":649,"context_line":"        for the other subnets specified for this network."},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        \"\"\""},{"line_number":652,"context_line":"        subnet_list \u003d network.subnets"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FTD8%3D","line":649,"updated":"2012-09-25 00:51:15.000000000","message":"this comment probably needs an update, as the set of subnets compared against now depends on the allow_overlapping_ips flag.","commit_id":"afba3954f688d07dbaf148cb5bad32a566becdb5"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":646,"context_line":"        \"\"\"Validate the CIDR for a subnet."},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        Verifies the specified CIDR does not overlap with the ones defined"},{"line_number":649,"context_line":"        for the other subnets specified for this network."},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        \"\"\""},{"line_number":652,"context_line":"        subnet_list \u003d network.subnets"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FS6g%3D","line":649,"in_reply_to":"AAAALH%2F%2FTD8%3D","updated":"2012-09-25 07:48:59.000000000","message":"Done","commit_id":"afba3954f688d07dbaf148cb5bad32a566becdb5"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":654,"context_line":"            subnet_list \u003d self._get_all_subnets(context)"},{"line_number":655,"context_line":"        for subnet in subnet_list:"},{"line_number":656,"context_line":"            if (netaddr.IPSet([subnet.cidr]) \u0026"},{"line_number":657,"context_line":"                    netaddr.IPSet([new_subnet_cidr])):"},{"line_number":658,"context_line":"                # don\u0027t give out details of the overlapping subnet"},{"line_number":659,"context_line":"                err_msg \u003d (\"Requested subnet with cidr: %s \""},{"line_number":660,"context_line":"                           \"for network: %s overlaps with another subnet\" %"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FTDs%3D","line":657,"updated":"2012-09-25 00:51:15.000000000","message":"now that subnet_list is potentially large, seems a bit wasteful to keep reconstructing the netaddr.IPSet([\u0027new_subnet_cidr])","commit_id":"afba3954f688d07dbaf148cb5bad32a566becdb5"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":654,"context_line":"            subnet_list \u003d self._get_all_subnets(context)"},{"line_number":655,"context_line":"        for subnet in subnet_list:"},{"line_number":656,"context_line":"            if (netaddr.IPSet([subnet.cidr]) \u0026"},{"line_number":657,"context_line":"                    netaddr.IPSet([new_subnet_cidr])):"},{"line_number":658,"context_line":"                # don\u0027t give out details of the overlapping subnet"},{"line_number":659,"context_line":"                err_msg \u003d (\"Requested subnet with cidr: %s \""},{"line_number":660,"context_line":"                           \"for network: %s overlaps with another subnet\" %"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FS6c%3D","line":657,"in_reply_to":"AAAALH%2F%2FTDs%3D","updated":"2012-09-25 07:48:59.000000000","message":"Done","commit_id":"afba3954f688d07dbaf148cb5bad32a566becdb5"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"2e8f6acd428adaa2ecb93d80af0fe1bf32b61feb","unresolved":false,"context_lines":[{"line_number":656,"context_line":"            if (netaddr.IPSet([subnet.cidr]) \u0026"},{"line_number":657,"context_line":"                    netaddr.IPSet([new_subnet_cidr])):"},{"line_number":658,"context_line":"                # don\u0027t give out details of the overlapping subnet"},{"line_number":659,"context_line":"                err_msg \u003d (\"Requested subnet with cidr: %s \""},{"line_number":660,"context_line":"                           \"for network: %s overlaps with another subnet\" %"},{"line_number":661,"context_line":"                           (new_subnet_cidr, network.id))"},{"line_number":662,"context_line":"                raise q_exc.InvalidInput(error_message\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FTG0%3D","line":659,"updated":"2012-09-24 23:32:24.000000000","message":"Should this string be wrapped in _()?","commit_id":"afba3954f688d07dbaf148cb5bad32a566becdb5"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":656,"context_line":"            if (netaddr.IPSet([subnet.cidr]) \u0026"},{"line_number":657,"context_line":"                    netaddr.IPSet([new_subnet_cidr])):"},{"line_number":658,"context_line":"                # don\u0027t give out details of the overlapping subnet"},{"line_number":659,"context_line":"                err_msg \u003d (\"Requested subnet with cidr: %s \""},{"line_number":660,"context_line":"                           \"for network: %s overlaps with another subnet\" %"},{"line_number":661,"context_line":"                           (new_subnet_cidr, network.id))"},{"line_number":662,"context_line":"                raise q_exc.InvalidInput(error_message\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FS6Y%3D","line":659,"in_reply_to":"AAAALH%2F%2FTDo%3D","updated":"2012-09-25 07:48:59.000000000","message":"Done","commit_id":"afba3954f688d07dbaf148cb5bad32a566becdb5"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":656,"context_line":"            if (netaddr.IPSet([subnet.cidr]) \u0026"},{"line_number":657,"context_line":"                    netaddr.IPSet([new_subnet_cidr])):"},{"line_number":658,"context_line":"                # don\u0027t give out details of the overlapping subnet"},{"line_number":659,"context_line":"                err_msg \u003d (\"Requested subnet with cidr: %s \""},{"line_number":660,"context_line":"                           \"for network: %s overlaps with another subnet\" %"},{"line_number":661,"context_line":"                           (new_subnet_cidr, network.id))"},{"line_number":662,"context_line":"                raise q_exc.InvalidInput(error_message\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FTDo%3D","line":659,"in_reply_to":"AAAALH%2F%2FTG0%3D","updated":"2012-09-25 00:51:15.000000000","message":"seems like a good idea.","commit_id":"afba3954f688d07dbaf148cb5bad32a566becdb5"}]}