)]}'
{"neutron/agent/linux/ra.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"e90d7efa1ca4826fd799639e34345156e8c1848c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"stateless_fmt \u003d \"\"\"interface %s"},{"line_number":50,"context_line":"{"},{"line_number":51,"context_line":"   AdvSendAdvert on;"},{"line_number":52,"context_line":"   AdvOtherConfigFlag on;"},{"line_number":53,"context_line":"   MinRtrAdvInterval 3;"},{"line_number":54,"context_line":"   MaxRtrAdvInterval 10;"},{"line_number":55,"context_line":"   prefix %s"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_202ad2e7","line":52,"updated":"2014-12-15 18:50:46.000000000","message":"not excited about repeating so much of the config...Seems we\u0027re converging on using jinja2 and template out the config","commit_id":"c858a20e6e7ece81cefacd9b233ad61e930d4b80"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"16da8ebb9a6a003207ac8c3ea805be47c83a7586","unresolved":false,"context_lines":[{"line_number":49,"context_line":"stateless_fmt \u003d \"\"\"interface %s"},{"line_number":50,"context_line":"{"},{"line_number":51,"context_line":"   AdvSendAdvert on;"},{"line_number":52,"context_line":"   AdvOtherConfigFlag on;"},{"line_number":53,"context_line":"   MinRtrAdvInterval 3;"},{"line_number":54,"context_line":"   MaxRtrAdvInterval 10;"},{"line_number":55,"context_line":"   prefix %s"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_e160ccd1","line":52,"in_reply_to":"3a961159_202ad2e7","updated":"2014-12-15 20:07:14.000000000","message":"I will look into templating it properly, though it won\u0027t be applicable for Juno (new requirement), so we need to have the fix in this form to be able to backport.","commit_id":"c858a20e6e7ece81cefacd9b233ad61e930d4b80"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"71183e5f44cb37dd750eec1f948890b8b0c4fded","unresolved":false,"context_lines":[{"line_number":52,"context_line":"   };"},{"line_number":53,"context_line":"   {% endif %}"},{"line_number":54,"context_line":"};"},{"line_number":55,"context_line":"\"\"\")"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def _generate_radvd_conf(router_id, router_ports, dev_name_helper):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_cb1caa7a","line":55,"updated":"2014-12-16 19:45:33.000000000","message":"Nit: this generates many blank lines. Can you add trim_blocks\u003dTrue, lstrip_blocks\u003dTrue here?","commit_id":"b4591da6d545b3e09275b75d2499a5f1dbb569b3"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"99be3f754ce5f83e4f9c1e32f366732daea4deaf","unresolved":false,"context_lines":[{"line_number":52,"context_line":"   };"},{"line_number":53,"context_line":"   {% endif %}"},{"line_number":54,"context_line":"};"},{"line_number":55,"context_line":"\"\"\")"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def _generate_radvd_conf(router_id, router_ports, dev_name_helper):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_cbfb9f45","line":55,"in_reply_to":"3a961159_93f39e09","updated":"2014-12-17 21:35:20.000000000","message":"Sorry for not checking the version requirements.\n\nNo I don\u0027t think it\u0027s worth it in this patch. It can be worked on for the future, maybe.","commit_id":"b4591da6d545b3e09275b75d2499a5f1dbb569b3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8e6b73a30a91cb2aa5189788d17bffc2cc4bb950","unresolved":false,"context_lines":[{"line_number":52,"context_line":"   };"},{"line_number":53,"context_line":"   {% endif %}"},{"line_number":54,"context_line":"};"},{"line_number":55,"context_line":"\"\"\")"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def _generate_radvd_conf(router_id, router_ports, dev_name_helper):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_93f39e09","line":55,"in_reply_to":"3a961159_cb1caa7a","updated":"2014-12-17 11:12:32.000000000","message":"To use those options, we\u0027ll need to bump Jinja2 version from \u003e\u003d2.6 to \u003e\u003d2.7 (the first version that supports those options). Do you think it\u0027s worth it?","commit_id":"b4591da6d545b3e09275b75d2499a5f1dbb569b3"}]}