)]}'
{"neutron/plugins/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b45bc328080ecf15e5fbd454df46739a0e4c0485","unresolved":false,"context_lines":[{"line_number":993,"context_line":"                sync \u003d False"},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"            if (self._device_info_has_changes(device_info)"},{"line_number":996,"context_line":"                    or self.firewall_refresh_needed()):"},{"line_number":997,"context_line":"                LOG.debug(\"Agent loop found changes! %s\", device_info)"},{"line_number":998,"context_line":"                try:"},{"line_number":999,"context_line":"                    sync \u003d self.process_network_devices(device_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_140667ce","line":996,"updated":"2014-12-02 23:39:40.000000000","message":"nit: align better with line above it, although it passes pep8","commit_id":"29fcc0f7d531364a96f423ef321675988ba56b14"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"f4ec7fa19fe6576eb813df55f0115461fd6c5609","unresolved":false,"context_lines":[{"line_number":993,"context_line":"                sync \u003d False"},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"            if (self._device_info_has_changes(device_info)"},{"line_number":996,"context_line":"                    or self.firewall_refresh_needed()):"},{"line_number":997,"context_line":"                LOG.debug(\"Agent loop found changes! %s\", device_info)"},{"line_number":998,"context_line":"                try:"},{"line_number":999,"context_line":"                    sync \u003d self.process_network_devices(device_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_3dd31bd6","line":996,"in_reply_to":"5a890539_140667ce","updated":"2014-12-22 15:58:08.000000000","message":"Done","commit_id":"29fcc0f7d531364a96f423ef321675988ba56b14"}],"neutron/tests/unit/linuxbridge/test_lb_neutron_agent.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"f04f901577d96a625e2f230bb5d2e13b934a70f1","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        agent.process_network_devices(device_info)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        agent.setup_port_filters.assert_called_with(set([\u0027tap3\u0027, \u0027tap4\u0027]),"},{"line_number":297,"context_line":"                                                    set([\u0027tap2\u0027, \u0027tap3\u0027]))"},{"line_number":298,"context_line":"        agent.treat_devices_added_updated.assert_called_with(set([\u0027tap2\u0027,"},{"line_number":299,"context_line":"                                                                  \u0027tap3\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_fea346af","line":296,"updated":"2014-12-22 19:33:28.000000000","message":"nit: please avoid hard coding tap3, tap4. Prefer: device_info.get(\u0027added\u0027) . Same for devices updated. I know the code was like that before your change but since you are modifying it, it would be good to fix it","commit_id":"32355807db9a982f5f2598fb12cf65e1eb91d7c8"}],"neutron/tests/unit/plugins/linuxbridge/agent/test_linuxbridge_neutron_agent.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"e644b393beb12314729335e5cfebabf9eefb89e1","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        agent.process_network_devices(device_info)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        agent.sg_agent.setup_port_filters.assert_called_with("},{"line_number":287,"context_line":"                set([\u0027tap3\u0027, \u0027tap4\u0027]),"},{"line_number":288,"context_line":"                set([\u0027tap2\u0027, \u0027tap3\u0027]))"},{"line_number":289,"context_line":"        agent.treat_devices_added_updated.assert_called_with(set([\u0027tap2\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_ff79f493","line":286,"updated":"2015-06-24 09:31:59.000000000","message":"can you please address my comment at PS2?","commit_id":"facec73f172450241eb250dfbc625aec9ad92bc1"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"b34784e032c605c97bed313b7a2fbc9aeb88dfca","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        agent.process_network_devices(device_info)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        agent.sg_agent.setup_port_filters.assert_called_with("},{"line_number":287,"context_line":"                set([\u0027tap3\u0027, \u0027tap4\u0027]),"},{"line_number":288,"context_line":"                set([\u0027tap2\u0027, \u0027tap3\u0027]))"},{"line_number":289,"context_line":"        agent.treat_devices_added_updated.assert_called_with(set([\u0027tap2\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_82a7284f","line":286,"in_reply_to":"fa32b979_ff79f493","updated":"2015-06-24 11:19:47.000000000","message":"will do","commit_id":"facec73f172450241eb250dfbc625aec9ad92bc1"}]}