)]}'
{"neutron/plugins/openvswitch/agent/ovs_dvr_neutron_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"78122bb18d71f53b1c157e97843b5e9ae51a13f9","unresolved":false,"context_lines":[{"line_number":407,"context_line":"                                     ipv6_dst\u003dip_subnet,"},{"line_number":408,"context_line":"                                     actions\u003d\"strip_vlan,mod_dl_src:%s,\""},{"line_number":409,"context_line":"                                     \"output:%s\" %"},{"line_number":410,"context_line":"                                     (subnet_info[\u0027gateway_mac\u0027], ofports))"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        if ip_version \u003d\u003d 4:"},{"line_number":413,"context_line":"            self.tun_br.add_flow(table\u003dconstants.DVR_PROCESS,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_0056ddcd","line":410,"updated":"2014-12-04 07:44:03.000000000","message":"+1","commit_id":"11157c98e50ed635be6e38be1496f82b081ad199"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"0d891943764db363050934ba1ecc37155c6202cd","unresolved":false,"context_lines":[{"line_number":407,"context_line":"                                     ipv6_dst\u003dip_subnet,"},{"line_number":408,"context_line":"                                     actions\u003d\"strip_vlan,mod_dl_src:%s,\""},{"line_number":409,"context_line":"                                     \"output:%s\" %"},{"line_number":410,"context_line":"                                     (subnet_info[\u0027gateway_mac\u0027], ofports))"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        if ip_version \u003d\u003d 4:"},{"line_number":413,"context_line":"            self.tun_br.add_flow(table\u003dconstants.DVR_PROCESS,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_0930e154","line":410,"updated":"2014-12-03 20:13:48.000000000","message":"It appears that there is only one keywords that are different between these two calls - ipv6_dst vs. nw_dst - can we instead construct a dictionary of all the keys, then call add_flow with it?\n\nSomething like:\n\nargs \u003d {table,proto,dl_vlan,actions....} etc...\n\nif subnet_info[\u0027ip_version\u0027] \u003d\u003d 4:\n    args[\u0027nw_dst\u0027] \u003d ip_subnet\nelse:\n    args[\u0027ipv6_dst\u0027] \u003d ip_subnet\n\nself.int_br.add_flow(**args)","commit_id":"11157c98e50ed635be6e38be1496f82b081ad199"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"bcc57643834ed5a0ad3811efbc763b8968cfa186","unresolved":false,"context_lines":[{"line_number":407,"context_line":"                                     ipv6_dst\u003dip_subnet,"},{"line_number":408,"context_line":"                                     actions\u003d\"strip_vlan,mod_dl_src:%s,\""},{"line_number":409,"context_line":"                                     \"output:%s\" %"},{"line_number":410,"context_line":"                                     (subnet_info[\u0027gateway_mac\u0027], ofports))"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        if ip_version \u003d\u003d 4:"},{"line_number":413,"context_line":"            self.tun_br.add_flow(table\u003dconstants.DVR_PROCESS,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_27fca60c","line":410,"in_reply_to":"5a890539_0056ddcd","updated":"2014-12-05 07:03:48.000000000","message":"Done","commit_id":"11157c98e50ed635be6e38be1496f82b081ad199"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"78122bb18d71f53b1c157e97843b5e9ae51a13f9","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                                     \"output:%s\" %"},{"line_number":410,"context_line":"                                     (subnet_info[\u0027gateway_mac\u0027], ofports))"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        if ip_version \u003d\u003d 4:"},{"line_number":413,"context_line":"            self.tun_br.add_flow(table\u003dconstants.DVR_PROCESS,"},{"line_number":414,"context_line":"                                 priority\u003d3,"},{"line_number":415,"context_line":"                                 dl_vlan\u003dlocal_vlan,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_205919fd","line":412,"updated":"2014-12-04 07:44:03.000000000","message":"same here. don\u0027t dup the whole function call for a couple of args changes.","commit_id":"11157c98e50ed635be6e38be1496f82b081ad199"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"bcc57643834ed5a0ad3811efbc763b8968cfa186","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                                     \"output:%s\" %"},{"line_number":410,"context_line":"                                     (subnet_info[\u0027gateway_mac\u0027], ofports))"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        if ip_version \u003d\u003d 4:"},{"line_number":413,"context_line":"            self.tun_br.add_flow(table\u003dconstants.DVR_PROCESS,"},{"line_number":414,"context_line":"                                 priority\u003d3,"},{"line_number":415,"context_line":"                                 dl_vlan\u003dlocal_vlan,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_6706ae1e","line":412,"in_reply_to":"5a890539_205919fd","updated":"2014-12-05 07:03:48.000000000","message":"Done","commit_id":"11157c98e50ed635be6e38be1496f82b081ad199"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"a7d0e66f6c60ee677797ea7b010c1daf8620c58e","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        ofports \u003d \u0027,\u0027.join(map(str, ldm.get_compute_ofports().values()))"},{"line_number":389,"context_line":"        if csnat_ofport !\u003d constants.OFPORT_INVALID:"},{"line_number":390,"context_line":"            ofports \u003d str(csnat_ofport) + \u0027,\u0027 + ofports"},{"line_number":391,"context_line":"        ip_version \u003d subnet_info[\u0027ip_version\u0027]"},{"line_number":392,"context_line":"        if ofports:"},{"line_number":393,"context_line":"            args \u003d {\u0027table\u0027: constants.DVR_TO_SRC_MAC,"},{"line_number":394,"context_line":"                    \u0027priority\u0027: 2,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_8436fe50","line":391,"updated":"2014-12-09 10:58:31.000000000","message":"my suggestion is to extract whole changed block into a separate private method for clarity.","commit_id":"bdceaa5b2269e2b134c4750891f9e1bb51d17dc6"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"ceb533f6a4bb8560b52053ca468b25743bca2edb","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        ofports \u003d \u0027,\u0027.join(map(str, ldm.get_compute_ofports().values()))"},{"line_number":389,"context_line":"        if csnat_ofport !\u003d constants.OFPORT_INVALID:"},{"line_number":390,"context_line":"            ofports \u003d str(csnat_ofport) + \u0027,\u0027 + ofports"},{"line_number":391,"context_line":"        ip_version \u003d subnet_info[\u0027ip_version\u0027]"},{"line_number":392,"context_line":"        if ofports:"},{"line_number":393,"context_line":"            args \u003d {\u0027table\u0027: constants.DVR_TO_SRC_MAC,"},{"line_number":394,"context_line":"                    \u0027priority\u0027: 2,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_ee4bff84","line":391,"in_reply_to":"3a961159_8436fe50","updated":"2014-12-10 06:51:29.000000000","message":"Done","commit_id":"bdceaa5b2269e2b134c4750891f9e1bb51d17dc6"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"a7d0e66f6c60ee677797ea7b010c1daf8620c58e","unresolved":false,"context_lines":[{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        # TODO(xuhanp) remove the IPv6 related add_flow once SNAT is not"},{"line_number":556,"context_line":"        # used for IPv6 DVR."},{"line_number":557,"context_line":"        ip_version \u003d subnet_info[\u0027ip_version\u0027]"},{"line_number":558,"context_line":"        args \u003d {\u0027table\u0027: constants.DVR_TO_SRC_MAC,"},{"line_number":559,"context_line":"                \u0027priority\u0027: 2,"},{"line_number":560,"context_line":"                \u0027dl_vlan\u0027: local_vlan,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_447a56f2","line":557,"updated":"2014-12-09 10:58:31.000000000","message":"i see similarity between this block and lines 492-506, can we extract that into a method?","commit_id":"bdceaa5b2269e2b134c4750891f9e1bb51d17dc6"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"ceb533f6a4bb8560b52053ca468b25743bca2edb","unresolved":false,"context_lines":[{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        # TODO(xuhanp) remove the IPv6 related add_flow once SNAT is not"},{"line_number":556,"context_line":"        # used for IPv6 DVR."},{"line_number":557,"context_line":"        ip_version \u003d subnet_info[\u0027ip_version\u0027]"},{"line_number":558,"context_line":"        args \u003d {\u0027table\u0027: constants.DVR_TO_SRC_MAC,"},{"line_number":559,"context_line":"                \u0027priority\u0027: 2,"},{"line_number":560,"context_line":"                \u0027dl_vlan\u0027: local_vlan,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_0e4f6b93","line":557,"in_reply_to":"3a961159_447a56f2","updated":"2014-12-10 06:51:29.000000000","message":"Done","commit_id":"bdceaa5b2269e2b134c4750891f9e1bb51d17dc6"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"7cddd16bdcb2b7e1ef2d5ccb6bae5d322db638de","unresolved":false,"context_lines":[{"line_number":619,"context_line":""},{"line_number":620,"context_line":"            args \u003d {\u0027table\u0027: constants.DVR_PROCESS,"},{"line_number":621,"context_line":"                    \u0027dl_vlan\u0027: local_vlan}"},{"line_number":622,"context_line":"            if ip_version \u003d\u003d 4:"},{"line_number":623,"context_line":"                args[\u0027proto\u0027] \u003d \u0027arp\u0027"},{"line_number":624,"context_line":"                args[\u0027nw_dst\u0027] \u003d subnet_info[\u0027gateway_ip\u0027]"},{"line_number":625,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_c2df6f38","line":622,"updated":"2014-12-15 03:08:16.000000000","message":"I remember some other reviewers were suggesting to create a method to simplify the duplication of code between here and lines 403-09. Thoughts?","commit_id":"d42fac3bde99cb772ee0ff63af66964b49f2b944"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"1c41b209c2b97d815494add6c40a9fee8e5bb71c","unresolved":false,"context_lines":[{"line_number":619,"context_line":""},{"line_number":620,"context_line":"            args \u003d {\u0027table\u0027: constants.DVR_PROCESS,"},{"line_number":621,"context_line":"                    \u0027dl_vlan\u0027: local_vlan}"},{"line_number":622,"context_line":"            if ip_version \u003d\u003d 4:"},{"line_number":623,"context_line":"                args[\u0027proto\u0027] \u003d \u0027arp\u0027"},{"line_number":624,"context_line":"                args[\u0027nw_dst\u0027] \u003d subnet_info[\u0027gateway_ip\u0027]"},{"line_number":625,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_beced7b2","line":622,"in_reply_to":"3a961159_c2df6f38","updated":"2014-12-16 02:39:24.000000000","message":"Thanks for the review! By other reviewer\u0027s suggestion, I already created a method _get_flow_args_by_version at line 742 to simplify duplication of code for adding flows to table DVR_TO_SRC_MAC. Since we only need two places of code like 622-629. Do you think creating a method is still needed?","commit_id":"d42fac3bde99cb772ee0ff63af66964b49f2b944"}],"neutron/tests/unit/openvswitch/test_ovs_neutron_agent.py":[{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"c8748fc4b9a0bbf6e5498a883e3e9120487c9b50","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                self.assertTrue(add_flow_int_fn.called)"},{"line_number":291,"context_line":"                self.assertTrue(delete_flows_int_fn.called)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def _test_port_bound_for_dvr_ipv6_subnet(self, device_owner):"},{"line_number":294,"context_line":"        self._setup_for_dvr_test()"},{"line_number":295,"context_line":"        with mock.patch(\u0027neutron.agent.linux.ovs_lib.OVSBridge.\u0027"},{"line_number":296,"context_line":"                        \u0027set_db_attribute\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_c1862d13","line":293,"updated":"2014-12-09 15:40:40.000000000","message":"To be mindful of code duplication, is it possible to add parameters to this method so that it can be used for both IPV4 and IPV6 ?","commit_id":"bdceaa5b2269e2b134c4750891f9e1bb51d17dc6"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"ceb533f6a4bb8560b52053ca468b25743bca2edb","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                self.assertTrue(add_flow_int_fn.called)"},{"line_number":291,"context_line":"                self.assertTrue(delete_flows_int_fn.called)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def _test_port_bound_for_dvr_ipv6_subnet(self, device_owner):"},{"line_number":294,"context_line":"        self._setup_for_dvr_test()"},{"line_number":295,"context_line":"        with mock.patch(\u0027neutron.agent.linux.ovs_lib.OVSBridge.\u0027"},{"line_number":296,"context_line":"                        \u0027set_db_attribute\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_8ecd1b60","line":293,"in_reply_to":"3a961159_c1862d13","updated":"2014-12-10 06:51:29.000000000","message":"Done","commit_id":"bdceaa5b2269e2b134c4750891f9e1bb51d17dc6"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"c8748fc4b9a0bbf6e5498a883e3e9120487c9b50","unresolved":false,"context_lines":[{"line_number":473,"context_line":"                self.assertTrue(delete_flows_int_fn.called)"},{"line_number":474,"context_line":"                self.assertTrue(delete_flows_tun_fn.called)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    def test_treat_devices_removed_for_dvr_interface_ipv6(self, ofport\u003d10):"},{"line_number":477,"context_line":"        self._setup_for_dvr_test()"},{"line_number":478,"context_line":"        with mock.patch(\u0027neutron.agent.linux.ovs_lib.OVSBridge.\u0027"},{"line_number":479,"context_line":"                        \u0027set_db_attribute\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_61901944","line":476,"updated":"2014-12-09 15:40:40.000000000","message":"Same comment as earlier: To be mindful of code duplication, is it possible to add parameters to this method so that it can be used for both IPV4 and IPV6 ?","commit_id":"bdceaa5b2269e2b134c4750891f9e1bb51d17dc6"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"ceb533f6a4bb8560b52053ca468b25743bca2edb","unresolved":false,"context_lines":[{"line_number":473,"context_line":"                self.assertTrue(delete_flows_int_fn.called)"},{"line_number":474,"context_line":"                self.assertTrue(delete_flows_tun_fn.called)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    def test_treat_devices_removed_for_dvr_interface_ipv6(self, ofport\u003d10):"},{"line_number":477,"context_line":"        self._setup_for_dvr_test()"},{"line_number":478,"context_line":"        with mock.patch(\u0027neutron.agent.linux.ovs_lib.OVSBridge.\u0027"},{"line_number":479,"context_line":"                        \u0027set_db_attribute\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_ae82d791","line":476,"in_reply_to":"3a961159_61901944","updated":"2014-12-10 06:51:29.000000000","message":"Done","commit_id":"bdceaa5b2269e2b134c4750891f9e1bb51d17dc6"}]}
