)]}'
{"quantum/tests/unit/test_l3_plugin.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"fc11257cbecb1afe832f6f5b7208b099957945b3","unresolved":false,"context_lines":[{"line_number":892,"context_line":"                                  query_params\u003d\"%s\u003dFalse\" % l3.EXTERNAL)"},{"line_number":893,"context_line":"                self.assertEquals(len(body[\u0027networks\u0027]), 1)"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"    def test_network_get_network(self):"},{"line_number":896,"context_line":"        plugin \u003d manager.QuantumManager.get_plugin()"},{"line_number":897,"context_line":"        ctx \u003d context.Context(None, None, is_admin\u003dTrue)"},{"line_number":898,"context_line":"        result \u003d plugin.get_networks(ctx)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FOsA%3D","line":895,"updated":"2012-10-02 13:59:13.000000000","message":"I would prefer to see a more focused test (i.e. directly testing _filter_nets_l3 rather than the higher-level call), but I understand that the current test structure makes this challenging.  \n\nI would like to see a more descriptive test name, at least, i.e. test_get_network_succeeds_without_filter, so that the intent of the test is clearly communicated to aid in future maintenance.   Consider also explicitly passing filters\u003dNone to get_networks() to further reinforce this.","commit_id":"5845cd2e2ce7e56d7e2d6c38653ca3873f6b3bfa"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"unresolved":false,"context_lines":[{"line_number":892,"context_line":"                                  query_params\u003d\"%s\u003dFalse\" % l3.EXTERNAL)"},{"line_number":893,"context_line":"                self.assertEquals(len(body[\u0027networks\u0027]), 1)"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"    def test_network_get_network(self):"},{"line_number":896,"context_line":"        plugin \u003d manager.QuantumManager.get_plugin()"},{"line_number":897,"context_line":"        ctx \u003d context.Context(None, None, is_admin\u003dTrue)"},{"line_number":898,"context_line":"        result \u003d plugin.get_networks(ctx)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FOrE%3D","line":895,"in_reply_to":"AAAALH%2F%2FOsA%3D","updated":"2012-10-02 14:59:43.000000000","message":"Done","commit_id":"5845cd2e2ce7e56d7e2d6c38653ca3873f6b3bfa"}]}
