)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7125,"name":"Alexander Ignatov","email":"aignatov@mirantis.com","username":"aignatov"},"change_message_id":"e87b01d1c4f3b754bb17cfef387a2af768de5177","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: blueprint neutron-flavor-framework"},{"line_number":16,"context_line":"Change-Id: I99ba0ce520ae3d8696eca5c994777c7d5ba3d4b1"},{"line_number":17,"context_line":"Co-Authored-By: Doug Wiegley \u003cdougw@a10networks.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"baa041b7_e2d33437","line":17,"updated":"2015-04-02 16:02:43.000000000","message":"I think here is mistake and this line should look as: \nCo-Authored-By: Eugene Nikanorov \u003cenikanorov@mirantis.com\u003e","commit_id":"e59fca67dc07048d9fddd1100b6823dfbccf198d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"c121dd5c223a480979159ddf946bdb07e6836d3d","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: blueprint neutron-flavor-framework"},{"line_number":16,"context_line":"Change-Id: I99ba0ce520ae3d8696eca5c994777c7d5ba3d4b1"},{"line_number":17,"context_line":"Co-Authored-By: Doug Wiegley \u003cdougw@a10networks.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"baa041b7_552de344","line":17,"in_reply_to":"baa041b7_e2d33437","updated":"2015-04-03 06:44:12.000000000","message":"No, I think It\u0027s correct, since I\u0027m the author of commit and my name is at the top of commit msg","commit_id":"e59fca67dc07048d9fddd1100b6823dfbccf198d"}],"etc/policy.json":[{"author":{"_account_id":162,"name":"Bob Melander","email":"bob.melander@gmail.com","username":"bob-melander"},"change_message_id":"cd4ace3cdabe6275ce05d1727c71d04c0ea007b3","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    \"create_flavor\": \"rule:admin_only\","},{"line_number":147,"context_line":"    \"update_flavor\": \"rule:admin_only\","},{"line_number":148,"context_line":"    \"delete_flavor\": \"rule:admin_only\","},{"line_number":149,"context_line":"    \"get_flavors\": \"rule:regular_user\","},{"line_number":150,"context_line":"    \"get_flavor\": \"rule:regular_user\","},{"line_number":151,"context_line":"    \"create_service_profile\": \"rule:admin_only\","},{"line_number":152,"context_line":"    \"update_service_profile\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":12,"id":"9a80dd14_d56252d7","line":149,"updated":"2015-03-07 14:02:48.000000000","message":"Given that service profile CRUDs are admin only one could filter the service profile attribute for non admin users","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"19e9eebfb8eb40b4ceb72080d5fe48f13cbfe3ba","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    \"create_flavor\": \"rule:admin_only\","},{"line_number":147,"context_line":"    \"update_flavor\": \"rule:admin_only\","},{"line_number":148,"context_line":"    \"delete_flavor\": \"rule:admin_only\","},{"line_number":149,"context_line":"    \"get_flavors\": \"rule:regular_user\","},{"line_number":150,"context_line":"    \"get_flavor\": \"rule:regular_user\","},{"line_number":151,"context_line":"    \"create_service_profile\": \"rule:admin_only\","},{"line_number":152,"context_line":"    \"update_service_profile\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":12,"id":"9a80dd14_8b8a1f19","line":149,"in_reply_to":"9a80dd14_d56252d7","updated":"2015-03-08 07:49:51.000000000","message":"that\u0027s ok: a user should be able to list and get details of the flavor","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"}],"neutron/api/v2/base.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"45ca3ce4ec83596097e1e7ff3a7d5205c6c8d4c3","unresolved":false,"context_lines":[{"line_number":399,"context_line":"            policy.enforce(request.context,"},{"line_number":400,"context_line":"                           action,"},{"line_number":401,"context_line":"                           item[self._resource])"},{"line_number":402,"context_line":"            if \u0027tenant_id\u0027 not in item[self._resource]:"},{"line_number":403,"context_line":"                # no tenant_id - no quota check"},{"line_number":404,"context_line":"                continue"},{"line_number":405,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_2bcdb385","line":402,"updated":"2015-03-08 07:53:06.000000000","message":"this does not look like it is related to the flavor support. consider adding it in as a separate patch and then have this based on that.","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"45ca3ce4ec83596097e1e7ff3a7d5205c6c8d4c3","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        if is_create and \u0027tenant_id\u0027 not in res_dict:"},{"line_number":565,"context_line":"            if context.tenant_id:"},{"line_number":566,"context_line":"                res_dict[\u0027tenant_id\u0027] \u003d context.tenant_id"},{"line_number":567,"context_line":"            elif \u0027tenant_id\u0027 in attr_info:"},{"line_number":568,"context_line":"                msg \u003d _(\"Running without keystone AuthN requires \""},{"line_number":569,"context_line":"                        \"that tenant_id is specified\")"},{"line_number":570,"context_line":"                raise webob.exc.HTTPBadRequest(msg)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_cba97791","line":567,"updated":"2015-03-08 07:53:06.000000000","message":"ditto","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"bb93aed38925a5e02c30d82e7d5034d830cdd26a","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                           pluralized\u003dself._collection)"},{"line_number":417,"context_line":"            if \u0027tenant_id\u0027 not in item[self._resource]:"},{"line_number":418,"context_line":"                # no tenant_id - no quota check"},{"line_number":419,"context_line":"                continue"},{"line_number":420,"context_line":"            try:"},{"line_number":421,"context_line":"                tenant_id \u003d item[self._resource][\u0027tenant_id\u0027]"},{"line_number":422,"context_line":"                count \u003d quota.QUOTAS.count(request.context, self._resource,"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a41bdd9_f5b265e4","line":419,"updated":"2015-07-15 13:04:58.000000000","message":"How are the \u0027tenant_id\u0027 changes in this file related to flavor implementation?","commit_id":"cf27e1a2d278f67ce38f59bf8f8c77e119840331"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"7c7238b8f38f4c20d66c7ab0581d5585440755be","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                           pluralized\u003dself._collection)"},{"line_number":417,"context_line":"            if \u0027tenant_id\u0027 not in item[self._resource]:"},{"line_number":418,"context_line":"                # no tenant_id - no quota check"},{"line_number":419,"context_line":"                continue"},{"line_number":420,"context_line":"            try:"},{"line_number":421,"context_line":"                tenant_id \u003d item[self._resource][\u0027tenant_id\u0027]"},{"line_number":422,"context_line":"                count \u003d quota.QUOTAS.count(request.context, self._resource,"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a41bdd9_c993e959","line":419,"in_reply_to":"9a41bdd9_f5b265e4","updated":"2015-07-16 03:27:34.000000000","message":"If there is no tenant_id in the response body when creating flavors, then there wont be any quota checks, meaning - \u0027no quota checks\u0027 as this is not going to be tenant specific flavors.","commit_id":"cf27e1a2d278f67ce38f59bf8f8c77e119840331"}],"neutron/db/flavors_db.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"2a617fb1a687edaf786c1739ce2629c68d1f458d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_18f1bbcd","line":1,"updated":"2014-12-08 10:37:16.000000000","message":"Copyright 2014 OpenStack Foundation ?","commit_id":"3d73d8366a9ae7ece907a184bbce357fce880294"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"2a617fb1a687edaf786c1739ce2629c68d1f458d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"class FlavorServiceProfileBinding(model_base.BASEV2):"},{"line_number":83,"context_line":"    flavor_id \u003d sa.Column(sa.String(36),"},{"line_number":84,"context_line":"                          sa.ForeignKey(\"flavors.id\","},{"line_number":85,"context_line":"                                        ondelete\u003d\"CASCADE\"),"},{"line_number":86,"context_line":"                          nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":87,"context_line":"    service_profile_id \u003d sa.Column(sa.String(36),"},{"line_number":88,"context_line":"                                   sa.ForeignKey(\"serviceprofiles.id\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_58d34338","line":85,"updated":"2014-12-08 10:37:16.000000000","message":"This foreign key is skipped in migration.","commit_id":"3d73d8366a9ae7ece907a184bbce357fce880294"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"2a617fb1a687edaf786c1739ce2629c68d1f458d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                          nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":87,"context_line":"    service_profile_id \u003d sa.Column(sa.String(36),"},{"line_number":88,"context_line":"                                   sa.ForeignKey(\"serviceprofiles.id\","},{"line_number":89,"context_line":"                                                 ondelete\u003d\"CASCADE\"),"},{"line_number":90,"context_line":"                                   nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_78d8ff53","line":89,"updated":"2014-12-08 10:37:16.000000000","message":"The same","commit_id":"3d73d8366a9ae7ece907a184bbce357fce880294"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"2557eaa5fe3e85cdd5a46940438da9785dcfab1d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        if fl:"},{"line_number":157,"context_line":"            raise ServiceProfileInUse(sp_id\u003dsp_id)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def create_flavor(self, context, flavor):"},{"line_number":160,"context_line":"        fl \u003d flavor[\u0027flavor\u0027]"},{"line_number":161,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":162,"context_line":"            fl_db \u003d Flavor(id\u003duuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_09a557a1","line":159,"updated":"2015-02-04 22:45:00.000000000","message":"Isn\u0027t it allowed to associate service profiles to flavors when flavors get created? Is the association to be done as a separate step? If yes, how is that done?","commit_id":"416a7c1f59cf38a36f7c407a561072cb06abfbee"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"3939dd430aec0650bed00d20e8bf6527c354e435","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        if fl:"},{"line_number":157,"context_line":"            raise ServiceProfileInUse(sp_id\u003dsp_id)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def create_flavor(self, context, flavor):"},{"line_number":160,"context_line":"        fl \u003d flavor[\u0027flavor\u0027]"},{"line_number":161,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":162,"context_line":"            fl_db \u003d Flavor(id\u003duuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_eeed1bf1","line":159,"in_reply_to":"da86d52c_09a557a1","updated":"2015-02-19 23:08:34.000000000","message":"Separate. Peek at the unit test for an example.","commit_id":"416a7c1f59cf38a36f7c407a561072cb06abfbee"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"49d815c78bd771a61eaff84a521e7058ede84783","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _ensure_flavor_not_in_use(self, context, flavor_id):"},{"line_number":149,"context_line":"        \"\"\"Checks that flavor is not associated with service instance.\"\"\""},{"line_number":150,"context_line":"        # TODO(enikanorov): check that there is no binding to instances"},{"line_number":151,"context_line":"        pass"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _ensure_service_profile_not_in_use(self, context, sp_id):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_9925bcad","line":150,"updated":"2015-02-20 07:56:32.000000000","message":"does this method need to be implemented or just removed?","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"49d815c78bd771a61eaff84a521e7058ede84783","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _ensure_service_profile_not_in_use(self, context, sp_id):"},{"line_number":154,"context_line":"        # TODO(enikanorov): check that there is no binding to instances"},{"line_number":155,"context_line":"        # and no binding to flavors"},{"line_number":156,"context_line":"        fl \u003d (context.session.query(FlavorServiceProfileBinding)."},{"line_number":157,"context_line":"              filter_by(service_profile_id\u003dsp_id).first())"},{"line_number":158,"context_line":"        if fl:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_3974d09b","line":155,"updated":"2015-02-20 07:56:32.000000000","message":"looks like this todo has been achieved, though maybe not the check for beinding to instances.","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"45ca3ce4ec83596097e1e7ff3a7d5205c6c8d4c3","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    def update_flavor(self, context, flavor_id, flavor):"},{"line_number":172,"context_line":"        fl \u003d flavor[\u0027flavor\u0027]"},{"line_number":173,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":174,"context_line":"            self._ensure_flavor_not_in_use(context, flavor_id)"},{"line_number":175,"context_line":"            fl_db \u003d self._get_flavor(context, flavor_id)"},{"line_number":176,"context_line":"            fl_db.update(fl)"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_6b716b43","line":174,"updated":"2015-03-08 07:53:06.000000000","message":"why does this need to be in the db transaction","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"45ca3ce4ec83596097e1e7ff3a7d5205c6c8d4c3","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            svc_type \u003d driver_klass.get_service_type()"},{"line_number":257,"context_line":"            plugin \u003d self.manager.get_service_plugins()[svc_type]"},{"line_number":258,"context_line":"            plugin.driver_loaded(driver_klass(plugin), sp_db)"},{"line_number":259,"context_line":"        except Exception:"},{"line_number":260,"context_line":"            # TODO(enikanorov): raise proper exception"},{"line_number":261,"context_line":"            self.delete_service_profile(context, sp_db[\u0027id\u0027])"},{"line_number":262,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_ab8fe328","line":259,"updated":"2015-03-08 07:53:06.000000000","message":"any reason why we are not using:\nwith excutils.save_and_reraise_exception():","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"49d815c78bd771a61eaff84a521e7058ede84783","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            plugin \u003d self.manager.get_service_plugins()[svc_type]"},{"line_number":258,"context_line":"            plugin.driver_loaded(driver_klass(plugin), sp_db)"},{"line_number":259,"context_line":"        except Exception:"},{"line_number":260,"context_line":"            # TODO(enikanorov): raise proper exception"},{"line_number":261,"context_line":"            self.delete_service_profile(context, sp_db[\u0027id\u0027])"},{"line_number":262,"context_line":"            raise"},{"line_number":263,"context_line":"        return self._make_service_profile_dict(sp_db)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_b9c36089","line":260,"updated":"2015-02-20 07:56:32.000000000","message":"TODO still needs to be achieved and looks like a log is needed here at least.","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":162,"name":"Bob Melander","email":"bob.melander@gmail.com","username":"bob-melander"},"change_message_id":"cd4ace3cdabe6275ce05d1727c71d04c0ea007b3","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            plugin \u003d self.manager.get_service_plugins()[svc_type]"},{"line_number":258,"context_line":"            plugin.driver_loaded(driver_klass(plugin), sp_db)"},{"line_number":259,"context_line":"        except Exception:"},{"line_number":260,"context_line":"            # TODO(enikanorov): raise proper exception"},{"line_number":261,"context_line":"            self.delete_service_profile(context, sp_db[\u0027id\u0027])"},{"line_number":262,"context_line":"            raise"},{"line_number":263,"context_line":"        return self._make_service_profile_dict(sp_db)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_10a58146","line":260,"in_reply_to":"ba7be1f8_b9c36089","updated":"2015-03-07 14:02:48.000000000","message":"Consider using:\n\nwith excutils.save_and_reraise_exception():","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"49d815c78bd771a61eaff84a521e7058ede84783","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        except Exception:"},{"line_number":260,"context_line":"            # TODO(enikanorov): raise proper exception"},{"line_number":261,"context_line":"            self.delete_service_profile(context, sp_db[\u0027id\u0027])"},{"line_number":262,"context_line":"            raise"},{"line_number":263,"context_line":"        return self._make_service_profile_dict(sp_db)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def update_service_profile(self, context,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_395e90ea","line":262,"updated":"2015-02-20 07:56:32.000000000","message":"does this work?","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"45ca3ce4ec83596097e1e7ff3a7d5205c6c8d4c3","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        sp \u003d service_profile[\u0027service_profile\u0027]"},{"line_number":268,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":269,"context_line":"            self._ensure_service_profile_not_in_use(context,"},{"line_number":270,"context_line":"                                                    service_profile_id)"},{"line_number":271,"context_line":"            sp_db \u003d self._get_service_profile(context, service_profile_id)"},{"line_number":272,"context_line":"            sp_db.update(sp)"},{"line_number":273,"context_line":"        return self._make_service_profile_dict(sp_db)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_4b74a735","line":270,"updated":"2015-03-08 07:53:06.000000000","message":"why does this need to be done int he DB transaction?","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"45ca3ce4ec83596097e1e7ff3a7d5205c6c8d4c3","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def delete_service_profile(self, context, sp_id):"},{"line_number":280,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":281,"context_line":"            self._ensure_service_profile_not_in_use(context, sp_id)"},{"line_number":282,"context_line":"            sp_db \u003d self._get_service_profile(context, sp_id)"},{"line_number":283,"context_line":"            context.session.delete(sp_db)"},{"line_number":284,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_eb855b07","line":281,"updated":"2015-03-08 07:53:06.000000000","message":"why does the line above need to be done in the with?","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b2cc34ef3dfea80001681d69d80642e442b4422d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                \"with flavor %(fl_id)s\")"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class DummyCorePlugin(object):"},{"line_number":62,"context_line":"    pass"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_3fe8e2b3","line":61,"updated":"2015-06-09 05:41:45.000000000","message":"Are these dummies really necessary?","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"018868a58c56803236405b834b002376da8cf040","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                \"with flavor %(fl_id)s\")"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class DummyCorePlugin(object):"},{"line_number":62,"context_line":"    pass"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_1a9b8967","line":61,"in_reply_to":"3afb71cf_3fe8e2b3","updated":"2015-06-11 00:20:11.000000000","message":"Based on my understanding, there are no flavor\u0027s supported driver available at the moment. Looks like, dummy\u0027s instances are necessary in moving forward to make sure the implementaion is working.","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b2cc34ef3dfea80001681d69d80642e442b4422d","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _ensure_flavor_not_in_use(self, context, flavor_id):"},{"line_number":174,"context_line":"        \"\"\"Checks that flavor is not associated with service instance.\"\"\""},{"line_number":175,"context_line":"        # TODO(enikanorov): check that there is no binding to instances"},{"line_number":176,"context_line":"        pass"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _ensure_service_profile_not_in_use(self, context, sp_id):"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_38e91881","line":175,"updated":"2015-06-09 05:41:45.000000000","message":"should this be implemented before this gets the go ahead? That said, I personally don\u0027t think that this pattern of getting/insert is sensible. It\u0027s potentially race-y and sub-optimal as it requires more DB operations than are strictly necessary.","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"018868a58c56803236405b834b002376da8cf040","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _ensure_flavor_not_in_use(self, context, flavor_id):"},{"line_number":174,"context_line":"        \"\"\"Checks that flavor is not associated with service instance.\"\"\""},{"line_number":175,"context_line":"        # TODO(enikanorov): check that there is no binding to instances"},{"line_number":176,"context_line":"        pass"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _ensure_service_profile_not_in_use(self, context, sp_id):"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_3a0be57e","line":175,"in_reply_to":"3afb71cf_38e91881","updated":"2015-06-11 00:20:11.000000000","message":"I am not sure on this implementation, but am open to have lengthy discussion from the community moving forward.","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"d99588786c8cdb9f2201e1b81f8ea653525ce054","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _ensure_flavor_not_in_use(self, context, flavor_id):"},{"line_number":174,"context_line":"        \"\"\"Checks that flavor is not associated with service instance.\"\"\""},{"line_number":175,"context_line":"        # TODO(enikanorov): check that there is no binding to instances"},{"line_number":176,"context_line":"        pass"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _ensure_service_profile_not_in_use(self, context, sp_id):"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_7bb39c4d","line":175,"in_reply_to":"3afb71cf_3a0be57e","updated":"2015-06-11 03:26:19.000000000","message":"I think we will need that when deleting a flavor. If a user still has an instance of a certain flavor running we can\u0027t delete it -- so we are not orphaning that instance. So the expectation is that in order to remove a flavor all users need to migrate to a new/different one.","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9aacc1ec71070c324e3828d0e4bcf2eca862ec09","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _ensure_flavor_not_in_use(self, context, flavor_id):"},{"line_number":174,"context_line":"        \"\"\"Checks that flavor is not associated with service instance.\"\"\""},{"line_number":175,"context_line":"        # TODO(enikanorov): check that there is no binding to instances"},{"line_number":176,"context_line":"        pass"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _ensure_service_profile_not_in_use(self, context, sp_id):"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_9f406437","line":175,"in_reply_to":"3afb71cf_7bb39c4d","updated":"2015-06-11 17:39:25.000000000","message":"I am not suggesting that we don\u0027t validate the deletion, only that the proposed implementation is problematic.","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"d99588786c8cdb9f2201e1b81f8ea653525ce054","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _ensure_service_profile_not_in_use(self, context, sp_id):"},{"line_number":179,"context_line":"        # TODO(enikanorov): check that there is no binding to instances"},{"line_number":180,"context_line":"        # and no binding to flavors"},{"line_number":181,"context_line":"        fl \u003d (context.session.query(FlavorServiceProfileBinding)."},{"line_number":182,"context_line":"              filter_by(service_profile_id\u003dsp_id).first())"},{"line_number":183,"context_line":"        if fl:"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_1b7b887c","line":180,"updated":"2015-06-11 03:26:19.000000000","message":"Same here is mentioned above but for service profile.","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"aa418ea8dabeb9eed0b0520bf0bc75467283f38f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.db import models_v2"},{"line_number":26,"context_line":"from neutron.plugins.common import constants"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from neutron.openstack.common import uuidutils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa32b979_58e3faa4","line":28,"updated":"2015-06-26 01:10:02.000000000","message":"neutron.openstack.common.uuidutils was switched oslo_utils.uuidutils.","commit_id":"2fabcb040770169e7adeb0cc1d63882abc26020a"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"e3fa54a7dc01ccffecca371dc2856f4e6b97e435","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.db import models_v2"},{"line_number":26,"context_line":"from neutron.plugins.common import constants"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from neutron.openstack.common import uuidutils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa32b979_f2020609","line":28,"in_reply_to":"fa32b979_58e3faa4","updated":"2015-06-26 17:31:44.000000000","message":"great catch. I didn\u0027t realize this one and was not sure when this has reflected. Anyways, incorporated the changes in the next patch","commit_id":"2fabcb040770169e7adeb0cc1d63882abc26020a"},{"author":{"_account_id":16041,"name":"huxining","email":"xining@unitedstack.com","username":"huxining"},"change_message_id":"a45d77995a5d8557cc089c7a916f8930d567a942","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    enabled \u003d sa.Column(sa.Boolean, nullable\u003dFalse, default\u003dTrue,"},{"line_number":91,"context_line":"                        server_default\u003dsa.sql.true())"},{"line_number":92,"context_line":"    # Make it True for multi-type flavors"},{"line_number":93,"context_line":"    service_type \u003d sa.Column(sa.String(36), nullable\u003dTrue)"},{"line_number":94,"context_line":"    service_profiles \u003d orm.relationship(\"FlavorServiceProfileBinding\","},{"line_number":95,"context_line":"        cascade\u003d\"all, delete-orphan\")"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"fa32b979_b377c73a","line":93,"updated":"2015-06-26 01:51:21.000000000","message":"service_type may list of string, if 36 too smalll?","commit_id":"2fabcb040770169e7adeb0cc1d63882abc26020a"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"e3fa54a7dc01ccffecca371dc2856f4e6b97e435","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    enabled \u003d sa.Column(sa.Boolean, nullable\u003dFalse, default\u003dTrue,"},{"line_number":91,"context_line":"                        server_default\u003dsa.sql.true())"},{"line_number":92,"context_line":"    # Make it True for multi-type flavors"},{"line_number":93,"context_line":"    service_type \u003d sa.Column(sa.String(36), nullable\u003dTrue)"},{"line_number":94,"context_line":"    service_profiles \u003d orm.relationship(\"FlavorServiceProfileBinding\","},{"line_number":95,"context_line":"        cascade\u003d\"all, delete-orphan\")"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"fa32b979_cf295bf4","line":93,"in_reply_to":"fa32b979_b377c73a","updated":"2015-06-26 17:31:44.000000000","message":"I suspect 36 is good enough for just naming service type. I could not think of any service which has more than 36.","commit_id":"2fabcb040770169e7adeb0cc1d63882abc26020a"},{"author":{"_account_id":16041,"name":"huxining","email":"xining@unitedstack.com","username":"huxining"},"change_message_id":"68b30c651541d54433faa08b6007357af2f967a6","unresolved":false,"context_lines":[{"line_number":153,"context_line":"               \u0027name\u0027: flavor_db[\u0027name\u0027],"},{"line_number":154,"context_line":"               \u0027description\u0027: flavor_db[\u0027description\u0027],"},{"line_number":155,"context_line":"               \u0027enabled\u0027: flavor_db[\u0027enabled\u0027],"},{"line_number":156,"context_line":"               \u0027service_profiles\u0027: []}"},{"line_number":157,"context_line":"        if flavor_db.service_profiles:"},{"line_number":158,"context_line":"            res[\u0027service_profiles\u0027] \u003d [sp[\u0027service_profile_id\u0027]"},{"line_number":159,"context_line":"                                       for sp in flavor_db.service_profiles]"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa32b979_d87f0a16","line":156,"updated":"2015-06-26 01:13:59.000000000","message":"not service_type?","commit_id":"2fabcb040770169e7adeb0cc1d63882abc26020a"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"e3fa54a7dc01ccffecca371dc2856f4e6b97e435","unresolved":false,"context_lines":[{"line_number":153,"context_line":"               \u0027name\u0027: flavor_db[\u0027name\u0027],"},{"line_number":154,"context_line":"               \u0027description\u0027: flavor_db[\u0027description\u0027],"},{"line_number":155,"context_line":"               \u0027enabled\u0027: flavor_db[\u0027enabled\u0027],"},{"line_number":156,"context_line":"               \u0027service_profiles\u0027: []}"},{"line_number":157,"context_line":"        if flavor_db.service_profiles:"},{"line_number":158,"context_line":"            res[\u0027service_profiles\u0027] \u003d [sp[\u0027service_profile_id\u0027]"},{"line_number":159,"context_line":"                                       for sp in flavor_db.service_profiles]"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa32b979_cf771b07","line":156,"in_reply_to":"fa32b979_d87f0a16","updated":"2015-06-26 17:31:44.000000000","message":"nope. Because it is constant and needs to be static all the time. For info: https://review.openstack.org/#/c/102723/9/specs/kilo/neutron-flavor-framework.rst","commit_id":"2fabcb040770169e7adeb0cc1d63882abc26020a"},{"author":{"_account_id":16041,"name":"huxining","email":"xining@unitedstack.com","username":"huxining"},"change_message_id":"a45d77995a5d8557cc089c7a916f8930d567a942","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            binding \u003d FlavorServiceProfileBinding("},{"line_number":234,"context_line":"                service_profile_id\u003dsp[\u0027id\u0027],"},{"line_number":235,"context_line":"                flavor_id\u003dflavor_id)"},{"line_number":236,"context_line":"            context.session.add(binding)"},{"line_number":237,"context_line":"        fl_db \u003d self._get_flavor(context, flavor_id)"},{"line_number":238,"context_line":"        sps \u003d [x[\u0027service_profile_id\u0027] for x in fl_db.service_profiles]"},{"line_number":239,"context_line":"        return sps"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa32b979_b3682723","line":236,"updated":"2015-06-26 01:51:21.000000000","message":"the svc_type of service profile do not found in service_types of flavor, If raise exception?","commit_id":"2fabcb040770169e7adeb0cc1d63882abc26020a"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"e3fa54a7dc01ccffecca371dc2856f4e6b97e435","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            binding \u003d FlavorServiceProfileBinding("},{"line_number":234,"context_line":"                service_profile_id\u003dsp[\u0027id\u0027],"},{"line_number":235,"context_line":"                flavor_id\u003dflavor_id)"},{"line_number":236,"context_line":"            context.session.add(binding)"},{"line_number":237,"context_line":"        fl_db \u003d self._get_flavor(context, flavor_id)"},{"line_number":238,"context_line":"        sps \u003d [x[\u0027service_profile_id\u0027] for x in fl_db.service_profiles]"},{"line_number":239,"context_line":"        return sps"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa32b979_8f427367","line":236,"in_reply_to":"fa32b979_b3682723","updated":"2015-06-26 17:31:44.000000000","message":"nope. we are not defining the service_type in flavors and as a result, there wouldn\u0027t be any exception when creating service profile. Also, the attributes can be found in the blueprint as well.","commit_id":"2fabcb040770169e7adeb0cc1d63882abc26020a"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"b333b0d21a280be513adacca8195171548ba7c69","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_28de3a11","line":1,"updated":"2015-07-08 22:29:45.000000000","message":"\"All Rights Reserved\" can/should be removed, and a copyright statement added.","commit_id":"121bab7731709bb5aa0b61a3d512a7cc03924221"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"663842ec59069163d9b2c547f4d43abf51f8f523","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_597eeeaf","line":1,"in_reply_to":"ba3cc151_28de3a11","updated":"2015-07-08 23:38:28.000000000","message":"sure, will take a note of it and thanks for your comment","commit_id":"121bab7731709bb5aa0b61a3d512a7cc03924221"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"b333b0d21a280be513adacca8195171548ba7c69","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        return self._fields(res, fields)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def _ensure_flavor_not_in_use(self, context, flavor_id):"},{"line_number":173,"context_line":"        \"\"\"Checks that flavor is not associated with service instance.\"\"\""},{"line_number":174,"context_line":"        # TODO(enikanorov): check that there is no binding to instances"},{"line_number":175,"context_line":"        pass"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_085c967b","line":173,"updated":"2015-07-08 22:29:45.000000000","message":"This function doesn\u0027t do anything.  Address the TODO?","commit_id":"121bab7731709bb5aa0b61a3d512a7cc03924221"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"663842ec59069163d9b2c547f4d43abf51f8f523","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        return self._fields(res, fields)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def _ensure_flavor_not_in_use(self, context, flavor_id):"},{"line_number":173,"context_line":"        \"\"\"Checks that flavor is not associated with service instance.\"\"\""},{"line_number":174,"context_line":"        # TODO(enikanorov): check that there is no binding to instances"},{"line_number":175,"context_line":"        pass"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_397f6ae1","line":173,"in_reply_to":"ba3cc151_085c967b","updated":"2015-07-08 23:38:28.000000000","message":"yeah, actually I preferred to come back to this point when we have flavor supported driver and address all TODOs in this file.","commit_id":"121bab7731709bb5aa0b61a3d512a7cc03924221"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"b333b0d21a280be513adacca8195171548ba7c69","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _ensure_service_profile_not_in_use(self, context, sp_id):"},{"line_number":178,"context_line":"        # TODO(enikanorov): check that there is no binding to instances"},{"line_number":179,"context_line":"        # and no binding to flavors"},{"line_number":180,"context_line":"        fl \u003d (context.session.query(FlavorServiceProfileBinding)."},{"line_number":181,"context_line":"              filter_by(service_profile_id\u003dsp_id).first())"},{"line_number":182,"context_line":"        if fl:"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_28ef1a88","line":179,"updated":"2015-07-08 22:29:45.000000000","message":"TODO?","commit_id":"121bab7731709bb5aa0b61a3d512a7cc03924221"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"b333b0d21a280be513adacca8195171548ba7c69","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            plugin \u003d DummyServicePlugin()"},{"line_number":295,"context_line":"            plugin.driver_loaded(driver_klass(svc_type), sp_db)"},{"line_number":296,"context_line":"        except Exception:"},{"line_number":297,"context_line":"            # TODO(enikanorov): raise proper exception"},{"line_number":298,"context_line":"            self.delete_service_profile(context, sp_db[\u0027id\u0027])"},{"line_number":299,"context_line":"            raise"},{"line_number":300,"context_line":"        return self._make_service_profile_dict(sp_db)"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_28c87a21","line":297,"updated":"2015-07-08 22:29:45.000000000","message":"TODO?","commit_id":"121bab7731709bb5aa0b61a3d512a7cc03924221"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"663842ec59069163d9b2c547f4d43abf51f8f523","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            plugin \u003d DummyServicePlugin()"},{"line_number":295,"context_line":"            plugin.driver_loaded(driver_klass(svc_type), sp_db)"},{"line_number":296,"context_line":"        except Exception:"},{"line_number":297,"context_line":"            # TODO(enikanorov): raise proper exception"},{"line_number":298,"context_line":"            self.delete_service_profile(context, sp_db[\u0027id\u0027])"},{"line_number":299,"context_line":"            raise"},{"line_number":300,"context_line":"        return self._make_service_profile_dict(sp_db)"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_798df2d1","line":297,"in_reply_to":"ba3cc151_28c87a21","updated":"2015-07-08 23:38:28.000000000","message":"Used dummy service \u0026 plugin to move forward and then come back with the right implementation when we have right drivers in place.","commit_id":"121bab7731709bb5aa0b61a3d512a7cc03924221"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"b333b0d21a280be513adacca8195171548ba7c69","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            plugin \u003d self.manager.get_service_plugins()[svc_type]"},{"line_number":317,"context_line":"            plugin.driver_loaded(driver_klass(plugin), sp_db)"},{"line_number":318,"context_line":"        except Exception:"},{"line_number":319,"context_line":"            # TODO(enikanorov): raise proper exception"},{"line_number":320,"context_line":"            self.delete_service_profile(context, sp_db[\u0027id\u0027])"},{"line_number":321,"context_line":"            raise"},{"line_number":322,"context_line":"        return self._make_service_profile_dict(sp_db)"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_687442fd","line":319,"updated":"2015-07-08 22:29:45.000000000","message":"Does this TODO need to be done?","commit_id":"121bab7731709bb5aa0b61a3d512a7cc03924221"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"bb93aed38925a5e02c30d82e7d5034d830cdd26a","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class ServiceProfileInUse(qexception.InUse):"},{"line_number":47,"context_line":"    message \u003d _(\"Service Profile %(sp_id)s is used by some service instance\")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class FlavorServiceProfileBindingExists(qexception.Conflict):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a41bdd9_95a519a3","line":47,"updated":"2015-07-15 13:04:58.000000000","message":"Suggest \"already being used by another service instance\" or \"already in use by another service instance\".\n\nAlso, is this an exception that a particular service implementation _may_ raise, if something about it requires only one running instance at a time; or is it a restriction that the flavor framework itself imposes, over all possible service implementations?","commit_id":"cf27e1a2d278f67ce38f59bf8f8c77e119840331"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"7c7238b8f38f4c20d66c7ab0581d5585440755be","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class ServiceProfileInUse(qexception.InUse):"},{"line_number":47,"context_line":"    message \u003d _(\"Service Profile %(sp_id)s is used by some service instance\")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class FlavorServiceProfileBindingExists(qexception.Conflict):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a41bdd9_69a97d23","line":47,"in_reply_to":"9a41bdd9_95a519a3","updated":"2015-07-16 03:27:34.000000000","message":"This message will raise as a part of exception in-case an admin tries to delete the service profile. This is required because admin want to make sure the service profile is not in binding to flavors/instances running before deleting it as a precautionary measure.","commit_id":"cf27e1a2d278f67ce38f59bf8f8c77e119840331"}],"neutron/db/migration/alembic_migrations/versions/31337ec0ffee_flavors.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"250ce9708c136d3a16112b7c8030adcd266d371d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_94e680e6","line":1,"updated":"2015-02-06 11:20:08.000000000","message":"2015","commit_id":"82eef26433b3585619091c5684aafd8700a1af94"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"d5d1fa586385283adf042e898b755fe0dbe7fb43","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_8ef73f8c","line":1,"in_reply_to":"da86d52c_94e680e6","updated":"2015-02-19 23:12:21.000000000","message":"Done","commit_id":"82eef26433b3585619091c5684aafd8700a1af94"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"250ce9708c136d3a16112b7c8030adcd266d371d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import sqlalchemy as sa"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":33,"context_line":"    op.create_table("},{"line_number":34,"context_line":"        \u0027flavors\u0027,"},{"line_number":35,"context_line":"        sa.Column(\u0027id\u0027, sa.String(36)),"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_f4c7bc42","line":32,"updated":"2015-02-06 11:20:08.000000000","message":"active_plugins and options are not needed now.","commit_id":"82eef26433b3585619091c5684aafd8700a1af94"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"d5d1fa586385283adf042e898b755fe0dbe7fb43","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import sqlalchemy as sa"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":33,"context_line":"    op.create_table("},{"line_number":34,"context_line":"        \u0027flavors\u0027,"},{"line_number":35,"context_line":"        sa.Column(\u0027id\u0027, sa.String(36)),"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_4efe276d","line":32,"in_reply_to":"da86d52c_f4c7bc42","updated":"2015-02-19 23:12:21.000000000","message":"Done","commit_id":"82eef26433b3585619091c5684aafd8700a1af94"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"250ce9708c136d3a16112b7c8030adcd266d371d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def downgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":67,"context_line":"    op.drop_table(\u0027flavorserviceprofilebindings\u0027)"},{"line_number":68,"context_line":"    op.drop_table(\u0027serviceprofiles\u0027)"},{"line_number":69,"context_line":"    op.drop_table(\u0027flavors\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_74e3ccd8","line":66,"updated":"2015-02-06 11:20:08.000000000","message":"the same","commit_id":"82eef26433b3585619091c5684aafd8700a1af94"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"d5d1fa586385283adf042e898b755fe0dbe7fb43","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def downgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":67,"context_line":"    op.drop_table(\u0027flavorserviceprofilebindings\u0027)"},{"line_number":68,"context_line":"    op.drop_table(\u0027serviceprofiles\u0027)"},{"line_number":69,"context_line":"    op.drop_table(\u0027flavors\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_6e03eb73","line":66,"in_reply_to":"da86d52c_74e3ccd8","updated":"2015-02-19 23:12:21.000000000","message":"Done","commit_id":"82eef26433b3585619091c5684aafd8700a1af94"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"49d815c78bd771a61eaff84a521e7058ede84783","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        sa.Column(\u0027id\u0027, sa.String(36)),"},{"line_number":36,"context_line":"        sa.Column(\u0027name\u0027, sa.String(255)),"},{"line_number":37,"context_line":"        sa.Column(\u0027description\u0027, sa.String(1024)),"},{"line_number":38,"context_line":"        sa.Column(\u0027enabled\u0027, sa.Boolean, nullable\u003dFalse,"},{"line_number":39,"context_line":"                  server_default\u003dsa.sql.true()),"},{"line_number":40,"context_line":"        sa.Column(\u0027service_type\u0027, sa.String(36), nullable\u003dTrue),"},{"line_number":41,"context_line":"        sa.PrimaryKeyConstraint(\u0027id\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_fe2e9ea4","line":38,"updated":"2015-02-20 07:56:32.000000000","message":"i actually prefer enabled, but is there a precedent set for admin_state_up being the enable/disable switch for all things neutron?","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"49d815c78bd771a61eaff84a521e7058ede84783","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \u0027flavorserviceprofilebindings\u0027,"},{"line_number":57,"context_line":"        sa.Column(\u0027service_profile_id\u0027, sa.String(36), nullable\u003dFalse),"},{"line_number":58,"context_line":"        sa.Column(\u0027flavor_id\u0027, sa.String(36), nullable\u003dFalse),"},{"line_number":59,"context_line":"        sa.ForeignKeyConstraint([\u0027service_profile_id\u0027],"},{"line_number":60,"context_line":"                                [\u0027serviceprofiles.id\u0027]),"},{"line_number":61,"context_line":"        sa.ForeignKeyConstraint([\u0027flavor_id\u0027], [\u0027flavors.id\u0027]),"},{"line_number":62,"context_line":"        sa.PrimaryKeyConstraint(\u0027service_profile_id\u0027, \u0027flavor_id\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_7e12ae63","line":59,"updated":"2015-02-20 07:56:32.000000000","message":"i\u0027ve been dinged on not specifying fk names.  Plus its a good way to see foreign key errors at a glance if they\u0027re named appropriately.  Unless alembic/Sqlalchemy by default gives them names.","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"599aa6ded35a82a68d79cb69ab2fd90a67474e6b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# revision identifiers, used by Alembic."},{"line_number":24,"context_line":"revision \u003d \u0027313373c0ffee\u0027"},{"line_number":25,"context_line":"down_revision \u003d \u0027034883111f\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"da9b358b_fc098d2d","line":24,"updated":"2015-03-31 00:54:34.000000000","message":"It is forbidden to use amusing codes in OpenStack!! We are not allowed to have fun! I shall report this to the authorities.","commit_id":"efc95d0e5e756e6949f232daf01fe6161172b2e7"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"495e99d725ff6286f4723b811fd137211e2b0e95","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def downgrade():"},{"line_number":67,"context_line":"    op.drop_table(\u0027flavorserviceprofilebindings\u0027)"},{"line_number":68,"context_line":"    op.drop_table(\u0027serviceprofiles\u0027)"},{"line_number":69,"context_line":"    op.drop_table(\u0027flavors\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa963961_640ce294","line":66,"updated":"2015-03-27 08:21:30.000000000","message":"remove downgrade","commit_id":"efc95d0e5e756e6949f232daf01fe6161172b2e7"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"834abf7420b49f2d812e9f6b57359a56f7be96f9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def downgrade():"},{"line_number":67,"context_line":"    op.drop_table(\u0027flavorserviceprofilebindings\u0027)"},{"line_number":68,"context_line":"    op.drop_table(\u0027serviceprofiles\u0027)"},{"line_number":69,"context_line":"    op.drop_table(\u0027flavors\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da9b358b_9863a4dc","line":66,"in_reply_to":"da9b358b_d91dbcbe","updated":"2015-03-31 07:50:29.000000000","message":"I wrote an email to openstack-dev http://lists.openstack.org/pipermail/openstack-dev/2015-March/059735.html This was agreed on TC meeting.","commit_id":"efc95d0e5e756e6949f232daf01fe6161172b2e7"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"9fc5389d24a3376b822fefb56199d21748cbb952","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def downgrade():"},{"line_number":67,"context_line":"    op.drop_table(\u0027flavorserviceprofilebindings\u0027)"},{"line_number":68,"context_line":"    op.drop_table(\u0027serviceprofiles\u0027)"},{"line_number":69,"context_line":"    op.drop_table(\u0027flavors\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da9b358b_f9588058","line":66,"in_reply_to":"da9b358b_d91dbcbe","updated":"2015-03-31 00:04:24.000000000","message":"Jamie I believe this is the ML thread:\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-January/055586.html","commit_id":"efc95d0e5e756e6949f232daf01fe6161172b2e7"},{"author":{"_account_id":8179,"name":"Jamie McCarthy","email":"jamie@mccarthy.vg","username":"jamiemccarthy"},"change_message_id":"d1c555adcc6f1609081b1e5d83bbb3eae8cfcd2a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def downgrade():"},{"line_number":67,"context_line":"    op.drop_table(\u0027flavorserviceprofilebindings\u0027)"},{"line_number":68,"context_line":"    op.drop_table(\u0027serviceprofiles\u0027)"},{"line_number":69,"context_line":"    op.drop_table(\u0027flavors\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da9b358b_f9a51f04","line":66,"in_reply_to":"da9b358b_f9588058","updated":"2015-03-31 00:14:07.000000000","message":"I see. Well, I don\u0027t know if I 100% agree with the argument in this case, but there was clearly consensus.","commit_id":"efc95d0e5e756e6949f232daf01fe6161172b2e7"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"0771293828e961231c33e6252f49aa0ec8ccb995","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def downgrade():"},{"line_number":67,"context_line":"    op.drop_table(\u0027flavorserviceprofilebindings\u0027)"},{"line_number":68,"context_line":"    op.drop_table(\u0027serviceprofiles\u0027)"},{"line_number":69,"context_line":"    op.drop_table(\u0027flavors\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da9b358b_b94c3743","line":66,"in_reply_to":"da9b358b_f9a51f04","updated":"2015-03-31 00:16:56.000000000","message":"\"I don\u0027t know if I 100% agree with the argument in this case, but there was clearly consensus.\"  \u003c-- openstack in a nutshell!","commit_id":"efc95d0e5e756e6949f232daf01fe6161172b2e7"},{"author":{"_account_id":8179,"name":"Jamie McCarthy","email":"jamie@mccarthy.vg","username":"jamiemccarthy"},"change_message_id":"478243b61fd79c265c1ce35d5ab78af64d31c4bf","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def downgrade():"},{"line_number":67,"context_line":"    op.drop_table(\u0027flavorserviceprofilebindings\u0027)"},{"line_number":68,"context_line":"    op.drop_table(\u0027serviceprofiles\u0027)"},{"line_number":69,"context_line":"    op.drop_table(\u0027flavors\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da9b358b_d91dbcbe","line":66,"in_reply_to":"fa963961_640ce294","updated":"2015-03-30 23:54:08.000000000","message":"Ann, can you explain why, please? It\u0027s useful and serves a purpose, as far as I know.","commit_id":"efc95d0e5e756e6949f232daf01fe6161172b2e7"}],"neutron/extensions/flavors.py":[{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"2557eaa5fe3e85cdd5a46940438da9785dcfab1d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":53,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":54,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":55,"context_line":"        \u0027description\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":56,"context_line":"                        \u0027is_visible\u0027: True},"},{"line_number":57,"context_line":"        # service_profile belong to one service type for now"},{"line_number":58,"context_line":"        #\u0027service_types\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_c3b24005","line":55,"updated":"2015-02-04 22:45:00.000000000","message":"Don\u0027t need validate here as well?","commit_id":"416a7c1f59cf38a36f7c407a561072cb06abfbee"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"3939dd430aec0650bed00d20e8bf6527c354e435","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":53,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":54,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":55,"context_line":"        \u0027description\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":56,"context_line":"                        \u0027is_visible\u0027: True},"},{"line_number":57,"context_line":"        # service_profile belong to one service type for now"},{"line_number":58,"context_line":"        #\u0027service_types\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_8e949f45","line":55,"in_reply_to":"da86d52c_c3b24005","updated":"2015-02-19 23:08:34.000000000","message":"Done","commit_id":"416a7c1f59cf38a36f7c407a561072cb06abfbee"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"45ca3ce4ec83596097e1e7ff3a7d5205c6c8d4c3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def _validate_json_string(data, valid_values\u003dNone):"},{"line_number":87,"context_line":"    try:"},{"line_number":88,"context_line":"        jsonutils.loads(data)"},{"line_number":89,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_cb97b738","line":86,"updated":"2015-03-08 07:53:06.000000000","message":"this look slike it could be a generic validation. consider adding it to attributes.py","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"45ca3ce4ec83596097e1e7ff3a7d5205c6c8d4c3","unresolved":false,"context_lines":[{"line_number":86,"context_line":"def _validate_json_string(data, valid_values\u003dNone):"},{"line_number":87,"context_line":"    try:"},{"line_number":88,"context_line":"        jsonutils.loads(data)"},{"line_number":89,"context_line":"    except ValueError:"},{"line_number":90,"context_line":"        msg \u003d _(\"Invalid json string \u0027%s\u0027\") % data"},{"line_number":91,"context_line":"        return msg"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_6ba88b77","line":89,"updated":"2015-03-08 07:53:06.000000000","message":"do we have a test for this - maybe i missed it","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a01c4136e7dbe09dd2a22ce34c11117689d8588d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"FLAVORS \u003d \u0027flavors\u0027"},{"line_number":26,"context_line":"SERVICE_PROFILES \u003d \u0027service_profiles\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":29,"context_line":"    FLAVORS: {"},{"line_number":30,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":31,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_8125140a","line":28,"updated":"2015-06-09 18:55:09.000000000","message":"It seems we have completed the circle, and came back to the origin?\nhttps://review.openstack.org/#/c/17686/11/quantum/extensions/servicetype.py\n\nThis however as a better and more functional description of a service profile (called service definition in the other patch)","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"018868a58c56803236405b834b002376da8cf040","unresolved":false,"context_lines":[{"line_number":25,"context_line":"FLAVORS \u003d \u0027flavors\u0027"},{"line_number":26,"context_line":"SERVICE_PROFILES \u003d \u0027service_profiles\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":29,"context_line":"    FLAVORS: {"},{"line_number":30,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":31,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_9a4899b4","line":28,"in_reply_to":"3afb71cf_8125140a","updated":"2015-06-11 00:20:11.000000000","message":"Ah, I think based on the blueprint implementation, isn\u0027t \u0027service_profiles\u0027 been defined in the list of attributes. But, thanks for pointing the patch and need to spend some time on this though","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"d99588786c8cdb9f2201e1b81f8ea653525ce054","unresolved":false,"context_lines":[{"line_number":25,"context_line":"FLAVORS \u003d \u0027flavors\u0027"},{"line_number":26,"context_line":"SERVICE_PROFILES \u003d \u0027service_profiles\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":29,"context_line":"    FLAVORS: {"},{"line_number":30,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":31,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_bbe59409","line":28,"in_reply_to":"3afb71cf_9a4899b4","updated":"2015-06-11 03:26:19.000000000","message":"Salvatore, history tends to repeat itself. I think we are good with that one and can proceed?","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a01c4136e7dbe09dd2a22ce34c11117689d8588d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                        \u0027is_visible\u0027: True},"},{"line_number":62,"context_line":"        # service_profile belong to one service type for now"},{"line_number":63,"context_line":"        #\u0027service_types\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":64,"context_line":"        #                  \u0027is_visible\u0027: True},"},{"line_number":65,"context_line":"        \u0027driver\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":66,"context_line":"                   \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":67,"context_line":"                   \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_e1ce082c","line":64,"updated":"2015-06-09 18:55:09.000000000","message":"but if you do not add it now you might break bw compatibility when it will be time to add it, because older clients will err since service_types is not specified.\n\nAlso, unless you have a single driver that can server multiple services, having a list of service types is not really going to be helpful.","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"d99588786c8cdb9f2201e1b81f8ea653525ce054","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                        \u0027is_visible\u0027: True},"},{"line_number":62,"context_line":"        # service_profile belong to one service type for now"},{"line_number":63,"context_line":"        #\u0027service_types\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":64,"context_line":"        #                  \u0027is_visible\u0027: True},"},{"line_number":65,"context_line":"        \u0027driver\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":66,"context_line":"                   \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":67,"context_line":"                   \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_db98507a","line":64,"in_reply_to":"3afb71cf_9a7bf9bd","updated":"2015-06-11 03:26:19.000000000","message":"A list of service types was meant for (hardware) devices which can say be a firewall and a VPN. So I am with Salvatore if we think we want to support that in the future we should add it.","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"1b26d648b17a18414e7c0a56030ee446ed53fd6b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                        \u0027is_visible\u0027: True},"},{"line_number":62,"context_line":"        # service_profile belong to one service type for now"},{"line_number":63,"context_line":"        #\u0027service_types\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":64,"context_line":"        #                  \u0027is_visible\u0027: True},"},{"line_number":65,"context_line":"        \u0027driver\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":66,"context_line":"                   \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":67,"context_line":"                   \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa32b979_9d7ad424","line":64,"in_reply_to":"3afb71cf_db98507a","updated":"2015-06-26 00:14:00.000000000","message":"yes, if we want to support the different devices in future, we should add it else, it is good to go for now.","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"018868a58c56803236405b834b002376da8cf040","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                        \u0027is_visible\u0027: True},"},{"line_number":62,"context_line":"        # service_profile belong to one service type for now"},{"line_number":63,"context_line":"        #\u0027service_types\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":64,"context_line":"        #                  \u0027is_visible\u0027: True},"},{"line_number":65,"context_line":"        \u0027driver\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":66,"context_line":"                   \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":67,"context_line":"                   \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_9a7bf9bd","line":64,"in_reply_to":"3afb71cf_e1ce082c","updated":"2015-06-11 00:20:11.000000000","message":"well, you got the point here. For now, I only think of loadbalancer service at the moment, and having a list of services_types is not going to be helpful. I need to start looking into the loadbalancer drivers, but would like to have some directions to work against flavor supported driver instead of dummy driver","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"0ec6f8ba4cd48fdbd88c13e4080b7e50a4f65aa8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"SERVICE_PROFILES \u003d \u0027service_profiles\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":29,"context_line":"    FLAVORS: {"},{"line_number":30,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":31,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":32,"context_line":"               \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba3cc151_337ff767","line":29,"updated":"2015-07-07 04:26:56.000000000","message":"According to the spec [1], this resource is missing both supported_extensions and selection_algorithm attributes. Are these being added in a subsequent patch?\n\n[1] http://specs.openstack.org/openstack/neutron-specs/specs/liberty/neutron-flavor-framework.html","commit_id":"4311ddacb1b2cf13a8f5218afc7d4014d43a8ddd"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"a1085c1db57508785c0495025e24f6caf86a60de","unresolved":false,"context_lines":[{"line_number":26,"context_line":"SERVICE_PROFILES \u003d \u0027service_profiles\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":29,"context_line":"    FLAVORS: {"},{"line_number":30,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":31,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":32,"context_line":"               \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba3cc151_ec5d0d16","line":29,"in_reply_to":"ba3cc151_337ff767","updated":"2015-07-07 17:51:08.000000000","message":"I think, these attributes are going to be added in a subsequent patch.","commit_id":"4311ddacb1b2cf13a8f5218afc7d4014d43a8ddd"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"0ec6f8ba4cd48fdbd88c13e4080b7e50a4f65aa8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    \u0027default\u0027: True,"},{"line_number":53,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":54,"context_line":"    },"},{"line_number":55,"context_line":"    SERVICE_PROFILES: {"},{"line_number":56,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":57,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":58,"context_line":"               \u0027primary_key\u0027: True},"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba3cc151_33f617fa","line":55,"updated":"2015-07-07 04:26:56.000000000","message":"The spec [1] shows different attributes for SERVICE_PROFILES than what is defined here. Specifically, entry_point and metadata are not here, and appear to be replaced with driver and metainfo. Additionally, a tenant_id is specified here. Why the difference?\n\nAlso, is the tenant_id meant to allow the creation of SERVICE_PROFILES per-tenant?\n\n[1] http://specs.openstack.org/openstack/neutron-specs/specs/liberty/neutron-flavor-framework.html","commit_id":"4311ddacb1b2cf13a8f5218afc7d4014d43a8ddd"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"f73935047c4939c8b0a99fc0cf4c825780141ded","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    \u0027default\u0027: True,"},{"line_number":53,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":54,"context_line":"    },"},{"line_number":55,"context_line":"    SERVICE_PROFILES: {"},{"line_number":56,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":57,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":58,"context_line":"               \u0027primary_key\u0027: True},"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba3cc151_786bba1e","line":55,"in_reply_to":"ba3cc151_103e348b","updated":"2015-07-08 18:20:36.000000000","message":"OK, this makes sense. Thanks!","commit_id":"4311ddacb1b2cf13a8f5218afc7d4014d43a8ddd"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"a712d1cb9e27e60fdfc196ec8596e9ef07ff9498","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    \u0027default\u0027: True,"},{"line_number":53,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":54,"context_line":"    },"},{"line_number":55,"context_line":"    SERVICE_PROFILES: {"},{"line_number":56,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":57,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":58,"context_line":"               \u0027primary_key\u0027: True},"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba3cc151_a155c3c6","line":55,"in_reply_to":"ba3cc151_2c9f7551","updated":"2015-07-07 21:42:33.000000000","message":"Thanks for the clarification. I\u0027d be ok with adding it for both flavor and service_profiles, but if it makes things more complicated then lets leave it for now.","commit_id":"4311ddacb1b2cf13a8f5218afc7d4014d43a8ddd"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"a1085c1db57508785c0495025e24f6caf86a60de","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    \u0027default\u0027: True,"},{"line_number":53,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":54,"context_line":"    },"},{"line_number":55,"context_line":"    SERVICE_PROFILES: {"},{"line_number":56,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":57,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":58,"context_line":"               \u0027primary_key\u0027: True},"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba3cc151_2c9f7551","line":55,"in_reply_to":"ba3cc151_33f617fa","updated":"2015-07-07 17:51:08.000000000","message":"Yes. Those are replaced with driver and metainfo. Shall push another patch with the right attributes names to avoid confusion.\n\nFor tenant_id attribute, it meant tenant specific service-profile. Just a question, do we also want to add tenant_id in the list of attributes for flavor and service_profiles?","commit_id":"4311ddacb1b2cf13a8f5218afc7d4014d43a8ddd"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"e02e67282a297477ebf8ec5dbb910e933b1606ef","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    \u0027default\u0027: True,"},{"line_number":53,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":54,"context_line":"    },"},{"line_number":55,"context_line":"    SERVICE_PROFILES: {"},{"line_number":56,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":57,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":58,"context_line":"               \u0027primary_key\u0027: True},"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba3cc151_103e348b","line":55,"in_reply_to":"ba3cc151_a155c3c6","updated":"2015-07-07 23:31:12.000000000","message":"I wanted to clarify once again regarding this part: \" Also, is the tenant_id meant to allow the creation of SERVICE_PROFILES per-tenant? \"\n\nThe answer is, the tenant_id is not meant to allow the creation of service_profiles/flavors per-tenant. It is just used strictly because of the keystone checks present in base.py and it is not being stored in the db.\n\nFor the blueprint update, \u0027driver\u0027 and \u0027metainfo\u0027 attributes needs to be reflected.","commit_id":"4311ddacb1b2cf13a8f5218afc7d4014d43a8ddd"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d2f77d478c7f802fee97dcfab80a041b8c6eb494","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                   \u0027is_visible\u0027: True,"},{"line_number":69,"context_line":"                   \u0027default\u0027: attr.ATTR_NOT_SPECIFIED},"},{"line_number":70,"context_line":"        \u0027metainfo\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":71,"context_line":"                     \u0027validate\u0027: {\u0027type:json_string\u0027: None},"},{"line_number":72,"context_line":"                     \u0027is_visible\u0027: True},"},{"line_number":73,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":74,"context_line":"                      \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a41bdd9_31425369","line":71,"updated":"2015-07-14 16:58:05.000000000","message":"I\u0027m not sure that we should require users to double encode(escape) this in the json.\nWhy should the user need to escape the metainfo strings in their json?","commit_id":"cf27e1a2d278f67ce38f59bf8f8c77e119840331"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"7c7238b8f38f4c20d66c7ab0581d5585440755be","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                   \u0027is_visible\u0027: True,"},{"line_number":69,"context_line":"                   \u0027default\u0027: attr.ATTR_NOT_SPECIFIED},"},{"line_number":70,"context_line":"        \u0027metainfo\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":71,"context_line":"                     \u0027validate\u0027: {\u0027type:json_string\u0027: None},"},{"line_number":72,"context_line":"                     \u0027is_visible\u0027: True},"},{"line_number":73,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":74,"context_line":"                      \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a41bdd9_6902ddb5","line":71,"in_reply_to":"9a41bdd9_31425369","updated":"2015-07-16 03:27:34.000000000","message":"Great question.Minor changes has been made, where operators need not to escape the metainfo strings in their json from now on!","commit_id":"cf27e1a2d278f67ce38f59bf8f8c77e119840331"}],"neutron/manager.py":[{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"bb93aed38925a5e02c30d82e7d5034d830cdd26a","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                      {\"type\": plugin_inst.get_plugin_type(),"},{"line_number":212,"context_line":"                       \"desc\": plugin_inst.get_plugin_description()})"},{"line_number":213,"context_line":"        # do it after the loading from conf to avoid conflict with"},{"line_number":214,"context_line":"        # configuration provided by unit tests."},{"line_number":215,"context_line":"        self._load_flavors_manager()"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a41bdd9_5556b12a","line":214,"updated":"2015-07-15 13:04:58.000000000","message":"Out of interest, why don\u0027t you want the flavors manager to be loaded via config as other service plugins are?","commit_id":"cf27e1a2d278f67ce38f59bf8f8c77e119840331"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"7c7238b8f38f4c20d66c7ab0581d5585440755be","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                      {\"type\": plugin_inst.get_plugin_type(),"},{"line_number":212,"context_line":"                       \"desc\": plugin_inst.get_plugin_description()})"},{"line_number":213,"context_line":"        # do it after the loading from conf to avoid conflict with"},{"line_number":214,"context_line":"        # configuration provided by unit tests."},{"line_number":215,"context_line":"        self._load_flavors_manager()"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a41bdd9_2c3aa399","line":214,"in_reply_to":"9a41bdd9_5556b12a","updated":"2015-07-16 03:27:34.000000000","message":"It is with the best interests to maintain the consistency related to the configuration provided by unit tests. When dealing with the flavors creation, flavor supported plugins needs to be loaded first, then the respective flavor will be handled by the manager.","commit_id":"cf27e1a2d278f67ce38f59bf8f8c77e119840331"}],"neutron/plugins/common/constants.py":[{"author":{"_account_id":162,"name":"Bob Melander","email":"bob.melander@gmail.com","username":"bob-melander"},"change_message_id":"cd4ace3cdabe6275ce05d1727c71d04c0ea007b3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"VPN \u003d \"VPN\""},{"line_number":23,"context_line":"METERING \u003d \"METERING\""},{"line_number":24,"context_line":"L3_ROUTER_NAT \u003d \"L3_ROUTER_NAT\""},{"line_number":25,"context_line":"FLAVORS \u003d \"FLAVORS\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"#maps extension alias to service type"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_907091dd","line":25,"updated":"2015-03-07 14:02:48.000000000","message":"Is usage of plural form intentional?\n\nAsking since the other service constants are written singular.","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":162,"name":"Bob Melander","email":"bob.melander@gmail.com","username":"bob-melander"},"change_message_id":"cd4ace3cdabe6275ce05d1727c71d04c0ea007b3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    VPN: \"/vpn\","},{"line_number":51,"context_line":"    METERING: \"/metering\","},{"line_number":52,"context_line":"    L3_ROUTER_NAT: \"\","},{"line_number":53,"context_line":"    FLAVORS: \"\","},{"line_number":54,"context_line":"}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Service operation status constants"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_d023e9ba","line":53,"updated":"2015-03-07 14:02:48.000000000","message":"Any special reason for empty  prefix, rather than say \"/flavors\"","commit_id":"d0c59e6f8c979be3fb95d83a05fdd5628c203703"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"e8ae356d3486c1eaf3210be401c4aeb633cee03a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    LOADBALANCERV2: \"/lbaas\","},{"line_number":42,"context_line":"    FIREWALL: \"/fw\","},{"line_number":43,"context_line":"    VPN: \"/vpn\","},{"line_number":44,"context_line":"    METERING: \"/metering\","},{"line_number":45,"context_line":"    L3_ROUTER_NAT: \"\","},{"line_number":46,"context_line":"    FLAVORS: \"\""},{"line_number":47,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba3cc151_5f072481","line":44,"updated":"2015-07-07 01:52:34.000000000","message":"Pedantic nit: The metering and l3_router_nat changes seem unrelated here.","commit_id":"4311ddacb1b2cf13a8f5218afc7d4014d43a8ddd"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"cff8d496dd426547af72302ea1b7422edc36756c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    LOADBALANCERV2: \"/lbaas\","},{"line_number":42,"context_line":"    FIREWALL: \"/fw\","},{"line_number":43,"context_line":"    VPN: \"/vpn\","},{"line_number":44,"context_line":"    METERING: \"/metering\","},{"line_number":45,"context_line":"    L3_ROUTER_NAT: \"\","},{"line_number":46,"context_line":"    FLAVORS: \"\""},{"line_number":47,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba3cc151_58989a1b","line":44,"in_reply_to":"ba3cc151_5f072481","updated":"2015-07-07 04:11:21.000000000","message":"You are right Kyle. This needs to be removed and it is unrelated here. Will remove it right away. Thanks for pointing!","commit_id":"4311ddacb1b2cf13a8f5218afc7d4014d43a8ddd"}],"neutron/tests/api/test_flavors_extensions.py":[{"author":{"_account_id":12999,"name":"James Arendt","email":"james.arendt@hpe.com","username":"jwarendt"},"change_message_id":"f28d3226ef81531f30c9635047e421ac8f3b32d5","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    @test.idempotent_id(\u0027ec8e15ff-95d0-433b-b8a6-b466bddb1e50\u0027)"},{"line_number":86,"context_line":"    def test_create_update_delete_flavor(self):"},{"line_number":87,"context_line":"        # Creates a flavor"},{"line_number":88,"context_line":"        description \u003d \"service_profile created by tempest\""},{"line_number":89,"context_line":"        service \u003d \"LOADBALANCERS\""},{"line_number":90,"context_line":"        name \u003d \"Best flavor created by tempest\""},{"line_number":91,"context_line":"        body \u003d self.admin_client.create_flavor(name\u003dname, service_type\u003dservice,"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_2f6da604","line":88,"updated":"2015-06-05 17:09:11.000000000","message":"This description is off; should be \"flavor created by tempest\".","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"743115a0364949ac9b9b804bc14c0d8cf0f41978","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    @test.idempotent_id(\u0027ec8e15ff-95d0-433b-b8a6-b466bddb1e50\u0027)"},{"line_number":86,"context_line":"    def test_create_update_delete_flavor(self):"},{"line_number":87,"context_line":"        # Creates a flavor"},{"line_number":88,"context_line":"        description \u003d \"service_profile created by tempest\""},{"line_number":89,"context_line":"        service \u003d \"LOADBALANCERS\""},{"line_number":90,"context_line":"        name \u003d \"Best flavor created by tempest\""},{"line_number":91,"context_line":"        body \u003d self.admin_client.create_flavor(name\u003dname, service_type\u003dservice,"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afb71cf_a8498cd2","line":88,"in_reply_to":"3afb71cf_2f6da604","updated":"2015-06-05 18:33:16.000000000","message":"Nice catch James :) Shall modify it in the next patch!","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"1b26d648b17a18414e7c0a56030ee446ed53fd6b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    @test.idempotent_id(\u0027ec8e15ff-95d0-433b-b8a6-b466bddb1e50\u0027)"},{"line_number":86,"context_line":"    def test_create_update_delete_flavor(self):"},{"line_number":87,"context_line":"        # Creates a flavor"},{"line_number":88,"context_line":"        description \u003d \"service_profile created by tempest\""},{"line_number":89,"context_line":"        service \u003d \"LOADBALANCERS\""},{"line_number":90,"context_line":"        name \u003d \"Best flavor created by tempest\""},{"line_number":91,"context_line":"        body \u003d self.admin_client.create_flavor(name\u003dname, service_type\u003dservice,"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa32b979_ff475878","line":88,"in_reply_to":"3afb71cf_a8498cd2","updated":"2015-06-26 00:14:00.000000000","message":"updated in the next patch!","commit_id":"717dac46c3c7293c3d1e61160340ee8e80a35a07"}],"neutron/tests/unit/extensions/test_flavors.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"89c091fab616f7048c4eeca13ca4e7e34567bc9e","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    def setUp(self):"},{"line_number":279,"context_line":"        super(FlavorManagerTestCase, self).setUp()"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        args \u003d [\u0027--config-file\u0027, base.etcdir(\u0027neutron.conf.test\u0027)]"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        self.config_parse(args\u003dargs)"},{"line_number":284,"context_line":"        cfg.CONF.set_override("}],"source_content_type":"text/x-python","patch_set":25,"id":"fa32b979_c1484a8d","line":281,"updated":"2015-06-26 19:57:54.000000000","message":"Remove the args argument, so that line 283 becomes \"self.config_parse()\".\n\nSee:\nhttps://review.openstack.org/#/c/165237/","commit_id":"e0db004bf3df2bfbb07fca80cfb5fec056a50a4f"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"8ea5da7291431f6c98cdb9bc1a443c4f372c98b7","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    def setUp(self):"},{"line_number":279,"context_line":"        super(FlavorManagerTestCase, self).setUp()"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        args \u003d [\u0027--config-file\u0027, base.etcdir(\u0027neutron.conf.test\u0027)]"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        self.config_parse(args\u003dargs)"},{"line_number":284,"context_line":"        cfg.CONF.set_override("}],"source_content_type":"text/x-python","patch_set":25,"id":"fa32b979_d3d6e126","line":281,"in_reply_to":"fa32b979_c1484a8d","updated":"2015-06-26 20:08:21.000000000","message":"Great catch. Thanks!","commit_id":"e0db004bf3df2bfbb07fca80cfb5fec056a50a4f"},{"author":{"_account_id":12999,"name":"James Arendt","email":"james.arendt@hpe.com","username":"jwarendt"},"change_message_id":"bb76ea621f2cd30514d6c5539183a4ac5dc6547b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_2590a342","line":1,"updated":"2015-07-08 22:01:26.000000000","message":"Should add a copyright here.","commit_id":"121bab7731709bb5aa0b61a3d512a7cc03924221"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"663842ec59069163d9b2c547f4d43abf51f8f523","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_1932a610","line":1,"in_reply_to":"ba3cc151_2590a342","updated":"2015-07-08 23:38:28.000000000","message":"thanks for the note James, shall update the copyright","commit_id":"121bab7731709bb5aa0b61a3d512a7cc03924221"}],"neutron/tests/unit/test_flavors.py":[{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"2557eaa5fe3e85cdd5a46940438da9785dcfab1d","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        self._create_service_profile(description\u003d\u0027another sp\u0027)"},{"line_number":372,"context_line":"        self.assertEqual(2, len(self.plugin.get_service_profiles(self.ctx)))"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def test_associate_profile_with_flavor(self):"},{"line_number":375,"context_line":"        sp, data \u003d self._create_service_profile()"},{"line_number":376,"context_line":"        fl, data \u003d self._create_flavor()"},{"line_number":377,"context_line":"        self.plugin.create_flavor_service_profile("}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_29405b33","line":374,"updated":"2015-02-04 22:45:00.000000000","message":"Shouldn\u0027t we use either associate_service_profile_with_flavor or associate_profile_with_flavor consistently? May be there is reason for using these different names here that I am missing.","commit_id":"416a7c1f59cf38a36f7c407a561072cb06abfbee"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"3939dd430aec0650bed00d20e8bf6527c354e435","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        self._create_service_profile(description\u003d\u0027another sp\u0027)"},{"line_number":372,"context_line":"        self.assertEqual(2, len(self.plugin.get_service_profiles(self.ctx)))"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def test_associate_profile_with_flavor(self):"},{"line_number":375,"context_line":"        sp, data \u003d self._create_service_profile()"},{"line_number":376,"context_line":"        fl, data \u003d self._create_flavor()"},{"line_number":377,"context_line":"        self.plugin.create_flavor_service_profile("}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_0e8fcf24","line":374,"in_reply_to":"da86d52c_29405b33","updated":"2015-02-19 23:08:34.000000000","message":"Done","commit_id":"416a7c1f59cf38a36f7c407a561072cb06abfbee"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"250ce9708c136d3a16112b7c8030adcd266d371d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 VMware, Inc."},{"line_number":2,"context_line":"# All rights reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_740aec8a","line":1,"updated":"2015-02-06 11:20:08.000000000","message":"2015","commit_id":"82eef26433b3585619091c5684aafd8700a1af94"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"d5d1fa586385283adf042e898b755fe0dbe7fb43","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 VMware, Inc."},{"line_number":2,"context_line":"# All rights reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_6eb5abcc","line":1,"in_reply_to":"da86d52c_740aec8a","updated":"2015-02-19 23:12:21.000000000","message":"I think that\u0027s copy-paste cruft.  Nuked.","commit_id":"82eef26433b3585619091c5684aafd8700a1af94"}]}
