)]}'
{"neutron/tests/unit/agent/metadata/test_driver.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"ddf5a1a897c8c1817e3b58178e6fa8db4cbb30cf","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            metadata_driver.MetadataDriver.metadata_nat_rules(8775))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_metadata_filter_rules(self):"},{"line_number":44,"context_line":"        rules \u003d (\u0027INPUT\u0027, \u0027-s 0.0.0.0/0 -p tcp -m tcp --dport 8775 -j ACCEPT\u0027)"},{"line_number":45,"context_line":"        self.assertEqual("},{"line_number":46,"context_line":"            [rules],"},{"line_number":47,"context_line":"            metadata_driver.MetadataDriver.metadata_filter_rules(8775))"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_2eb0a7dc","line":44,"updated":"2015-01-02 20:59:18.000000000","message":"I\u0027m not sure there\u0027s value in duplicating the filter rule here in its entirety.  Maybe a constant should be used for the template or a simple check that the returned filter rule targets the appropriate port (e.g. --dport [port number] in rule) instead?","commit_id":"1f07a966e75967ce73882fb722ac611010f3177a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"aebd633f49ff7c6574295a8c3ed8794f457ce524","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            metadata_driver.MetadataDriver.metadata_nat_rules(8775))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_metadata_filter_rules(self):"},{"line_number":44,"context_line":"        rules \u003d (\u0027INPUT\u0027, \u0027-s 0.0.0.0/0 -p tcp -m tcp --dport 8775 -j ACCEPT\u0027)"},{"line_number":45,"context_line":"        self.assertEqual("},{"line_number":46,"context_line":"            [rules],"},{"line_number":47,"context_line":"            metadata_driver.MetadataDriver.metadata_filter_rules(8775))"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_e254d2c7","line":44,"in_reply_to":"3a961159_2eb0a7dc","updated":"2015-01-05 19:29:52.000000000","message":"I agree with @Maru\u0027s suggestion but think it might be considered out of the scope of this change.","commit_id":"1f07a966e75967ce73882fb722ac611010f3177a"}]}