)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8ecd0cb236b98efc04461869885055d247610ccf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"More to follow, with working examples, as we bootstrap this"},{"line_number":14,"context_line":"effort."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially-implements: bp/core-vendor-decomposition"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib8b6cc5fd72eb1b8b4b4b2bdbda132062c81cbc1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_b8964b3d","line":16,"updated":"2014-12-12 02:38:21.000000000","message":"it seems gerrit doesn\u0027t create a link for bp/foo.","commit_id":"4bdce939efa2e619e3d6de00b16be5217bb56d90"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3161fc8fef6ab30c7142f0fa6252f491a0268282","unresolved":false,"context_lines":[{"line_number":13,"context_line":"More to follow, with working examples, as we bootstrap this"},{"line_number":14,"context_line":"effort."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially-implements: bp/core-vendor-decomposition"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib8b6cc5fd72eb1b8b4b4b2bdbda132062c81cbc1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_9b28a987","line":16,"in_reply_to":"3a961159_b8964b3d","updated":"2014-12-12 02:45:41.000000000","message":"Done","commit_id":"4bdce939efa2e619e3d6de00b16be5217bb56d90"}],"doc/source/devref/contribute.rst":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Neutron has a pluggable architecture, with a number of extension points."},{"line_number":5,"context_line":"This documentation covers aspects relevant to contributing new Neutron"},{"line_number":6,"context_line":"v2 core (aka monolithic) plugins and ML2 mechanism drivers, and L3 service"},{"line_number":7,"context_line":"plugins. This document will initially cover a number of process-oriented"},{"line_number":8,"context_line":"aspects of the contribution process, to then provide an how-to guide that"},{"line_number":9,"context_line":"shows how to go from 0 LOC\u0027s to successfully contributing new extensions"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_92d5ee1d","line":6,"updated":"2014-12-12 01:32:20.000000000","message":"plugins and -\u003e plugins,","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Neutron has a pluggable architecture, with a number of extension points."},{"line_number":5,"context_line":"This documentation covers aspects relevant to contributing new Neutron"},{"line_number":6,"context_line":"v2 core (aka monolithic) plugins and ML2 mechanism drivers, and L3 service"},{"line_number":7,"context_line":"plugins. This document will initially cover a number of process-oriented"},{"line_number":8,"context_line":"aspects of the contribution process, to then provide an how-to guide that"},{"line_number":9,"context_line":"shows how to go from 0 LOC\u0027s to successfully contributing new extensions"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d5fcc074","line":6,"in_reply_to":"3a961159_92d5ee1d","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"This documentation covers aspects relevant to contributing new Neutron"},{"line_number":6,"context_line":"v2 core (aka monolithic) plugins and ML2 mechanism drivers, and L3 service"},{"line_number":7,"context_line":"plugins. This document will initially cover a number of process-oriented"},{"line_number":8,"context_line":"aspects of the contribution process, to then provide an how-to guide that"},{"line_number":9,"context_line":"shows how to go from 0 LOC\u0027s to successfully contributing new extensions"},{"line_number":10,"context_line":"with Neutron Development. In the remainder of this guide, we will try to"},{"line_number":11,"context_line":"use practical examples as much as we can so that people have working"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b2a82a8e","line":8,"updated":"2014-12-12 01:32:20.000000000","message":"process, to -\u003e and proceed to\n\n(uk vs us, so optional) an how-to -\u003e a how-to","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"This documentation covers aspects relevant to contributing new Neutron"},{"line_number":6,"context_line":"v2 core (aka monolithic) plugins and ML2 mechanism drivers, and L3 service"},{"line_number":7,"context_line":"plugins. This document will initially cover a number of process-oriented"},{"line_number":8,"context_line":"aspects of the contribution process, to then provide an how-to guide that"},{"line_number":9,"context_line":"shows how to go from 0 LOC\u0027s to successfully contributing new extensions"},{"line_number":10,"context_line":"with Neutron Development. In the remainder of this guide, we will try to"},{"line_number":11,"context_line":"use practical examples as much as we can so that people have working"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f538dc3e","line":8,"in_reply_to":"3a961159_b2a82a8e","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"plugins. This document will initially cover a number of process-oriented"},{"line_number":8,"context_line":"aspects of the contribution process, to then provide an how-to guide that"},{"line_number":9,"context_line":"shows how to go from 0 LOC\u0027s to successfully contributing new extensions"},{"line_number":10,"context_line":"with Neutron Development. In the remainder of this guide, we will try to"},{"line_number":11,"context_line":"use practical examples as much as we can so that people have working"},{"line_number":12,"context_line":"solutions they can start from."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f2855207","line":10,"updated":"2014-12-12 01:32:20.000000000","message":"with Neutron Development -\u003e to Neutron","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"plugins. This document will initially cover a number of process-oriented"},{"line_number":8,"context_line":"aspects of the contribution process, to then provide an how-to guide that"},{"line_number":9,"context_line":"shows how to go from 0 LOC\u0027s to successfully contributing new extensions"},{"line_number":10,"context_line":"with Neutron Development. In the remainder of this guide, we will try to"},{"line_number":11,"context_line":"use practical examples as much as we can so that people have working"},{"line_number":12,"context_line":"solutions they can start from."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d50a0078","line":10,"in_reply_to":"3a961159_f2855207","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"In fact, from the Kilo release onwards, the Neutron core team propose that"},{"line_number":20,"context_line":"additions to the codebase adopt a structure where the *monolithic plugins*,"},{"line_number":21,"context_line":"*ML2 MechanismDrivers*, and *L3 service plugins* are integration-only"},{"line_number":22,"context_line":"(called vendor integration hereinafter) to code that lives outside the"},{"line_number":23,"context_line":"tree (called vendor library hereinafter); the same applies for any"},{"line_number":24,"context_line":"vendor-specific agents: the only part that is to stay in the tree is the"},{"line_number":25,"context_line":"agent \u0027main\u0027 (a small python file that imports agent code from the vendor"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_92916e49","line":22,"updated":"2014-12-12 01:32:20.000000000","message":"vendor integration -\u003e \"vendor integration\"\n\nAlso, hereinafter?  I\u0027m beginning to suspect you are studying for law school after all.","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"In fact, from the Kilo release onwards, the Neutron core team propose that"},{"line_number":20,"context_line":"additions to the codebase adopt a structure where the *monolithic plugins*,"},{"line_number":21,"context_line":"*ML2 MechanismDrivers*, and *L3 service plugins* are integration-only"},{"line_number":22,"context_line":"(called vendor integration hereinafter) to code that lives outside the"},{"line_number":23,"context_line":"tree (called vendor library hereinafter); the same applies for any"},{"line_number":24,"context_line":"vendor-specific agents: the only part that is to stay in the tree is the"},{"line_number":25,"context_line":"agent \u0027main\u0027 (a small python file that imports agent code from the vendor"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_75722c12","line":22,"in_reply_to":"3a961159_92916e49","updated":"2014-12-12 02:11:52.000000000","message":"gotta have a backup plan if this effort doesn\u0027t pan out, don\u0027t I? :)","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"additions to the codebase adopt a structure where the *monolithic plugins*,"},{"line_number":21,"context_line":"*ML2 MechanismDrivers*, and *L3 service plugins* are integration-only"},{"line_number":22,"context_line":"(called vendor integration hereinafter) to code that lives outside the"},{"line_number":23,"context_line":"tree (called vendor library hereinafter); the same applies for any"},{"line_number":24,"context_line":"vendor-specific agents: the only part that is to stay in the tree is the"},{"line_number":25,"context_line":"agent \u0027main\u0027 (a small python file that imports agent code from the vendor"},{"line_number":26,"context_line":"library and starts it). The \u0027outside the tree\u0027 can be anything which the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_12a57ea1","line":23,"updated":"2014-12-12 01:32:20.000000000","message":"vendor library -\u003e \"vendor library\"","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"additions to the codebase adopt a structure where the *monolithic plugins*,"},{"line_number":21,"context_line":"*ML2 MechanismDrivers*, and *L3 service plugins* are integration-only"},{"line_number":22,"context_line":"(called vendor integration hereinafter) to code that lives outside the"},{"line_number":23,"context_line":"tree (called vendor library hereinafter); the same applies for any"},{"line_number":24,"context_line":"vendor-specific agents: the only part that is to stay in the tree is the"},{"line_number":25,"context_line":"agent \u0027main\u0027 (a small python file that imports agent code from the vendor"},{"line_number":26,"context_line":"library and starts it). The \u0027outside the tree\u0027 can be anything which the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b567344c","line":23,"in_reply_to":"3a961159_12a57ea1","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"*ML2 MechanismDrivers*, and *L3 service plugins* are integration-only"},{"line_number":22,"context_line":"(called vendor integration hereinafter) to code that lives outside the"},{"line_number":23,"context_line":"tree (called vendor library hereinafter); the same applies for any"},{"line_number":24,"context_line":"vendor-specific agents: the only part that is to stay in the tree is the"},{"line_number":25,"context_line":"agent \u0027main\u0027 (a small python file that imports agent code from the vendor"},{"line_number":26,"context_line":"library and starts it). The \u0027outside the tree\u0027 can be anything which the"},{"line_number":27,"context_line":"vendor is comfortable with: it may be a stackforge repo for instance, a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_92b88ec9","line":24,"updated":"2014-12-12 01:32:20.000000000","message":"agents: the -\u003e agents.  The","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"*ML2 MechanismDrivers*, and *L3 service plugins* are integration-only"},{"line_number":22,"context_line":"(called vendor integration hereinafter) to code that lives outside the"},{"line_number":23,"context_line":"tree (called vendor library hereinafter); the same applies for any"},{"line_number":24,"context_line":"vendor-specific agents: the only part that is to stay in the tree is the"},{"line_number":25,"context_line":"agent \u0027main\u0027 (a small python file that imports agent code from the vendor"},{"line_number":26,"context_line":"library and starts it). The \u0027outside the tree\u0027 can be anything which the"},{"line_number":27,"context_line":"vendor is comfortable with: it may be a stackforge repo for instance, a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_1556485c","line":24,"in_reply_to":"3a961159_92b88ec9","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"tree (called vendor library hereinafter); the same applies for any"},{"line_number":24,"context_line":"vendor-specific agents: the only part that is to stay in the tree is the"},{"line_number":25,"context_line":"agent \u0027main\u0027 (a small python file that imports agent code from the vendor"},{"line_number":26,"context_line":"library and starts it). The \u0027outside the tree\u0027 can be anything which the"},{"line_number":27,"context_line":"vendor is comfortable with: it may be a stackforge repo for instance, a"},{"line_number":28,"context_line":"tarball, a pypi package, etc. It is however important that this vendor library"},{"line_number":29,"context_line":"be publicly accessible. A plugin/drivers maintainer team self-governs in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_52c2a634","line":26,"updated":"2014-12-12 01:32:20.000000000","message":"The \u0027outside -\u003e \u0027Outside","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"tree (called vendor library hereinafter); the same applies for any"},{"line_number":24,"context_line":"vendor-specific agents: the only part that is to stay in the tree is the"},{"line_number":25,"context_line":"agent \u0027main\u0027 (a small python file that imports agent code from the vendor"},{"line_number":26,"context_line":"library and starts it). The \u0027outside the tree\u0027 can be anything which the"},{"line_number":27,"context_line":"vendor is comfortable with: it may be a stackforge repo for instance, a"},{"line_number":28,"context_line":"tarball, a pypi package, etc. It is however important that this vendor library"},{"line_number":29,"context_line":"be publicly accessible. A plugin/drivers maintainer team self-governs in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_554c50c8","line":26,"in_reply_to":"3a961159_52c2a634","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"tarball, a pypi package, etc. It is however important that this vendor library"},{"line_number":29,"context_line":"be publicly accessible. A plugin/drivers maintainer team self-governs in"},{"line_number":30,"context_line":"order to promote sharing, reuse, innovation, and release of the \u0027out-of-tree\u0027"},{"line_number":31,"context_line":"backbone. It should not be required for any member of the core team to be"},{"line_number":32,"context_line":"involved with this process, although core members of the Neutron team can"},{"line_number":33,"context_line":"be in whichever capacity necessary for out-of-tree development."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_12d3be04","line":31,"updated":"2014-12-12 01:32:20.000000000","message":"\u0027backbone\u0027 is a little strange here.  Suggest \u0027deliverable\u0027 instead.","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"tarball, a pypi package, etc. It is however important that this vendor library"},{"line_number":29,"context_line":"be publicly accessible. A plugin/drivers maintainer team self-governs in"},{"line_number":30,"context_line":"order to promote sharing, reuse, innovation, and release of the \u0027out-of-tree\u0027"},{"line_number":31,"context_line":"backbone. It should not be required for any member of the core team to be"},{"line_number":32,"context_line":"involved with this process, although core members of the Neutron team can"},{"line_number":33,"context_line":"be in whichever capacity necessary for out-of-tree development."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b5ce542c","line":31,"in_reply_to":"3a961159_12d3be04","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"order to promote sharing, reuse, innovation, and release of the \u0027out-of-tree\u0027"},{"line_number":31,"context_line":"backbone. It should not be required for any member of the core team to be"},{"line_number":32,"context_line":"involved with this process, although core members of the Neutron team can"},{"line_number":33,"context_line":"be in whichever capacity necessary for out-of-tree development."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Below, the following strategies will be documented:"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_52f0e690","line":33,"updated":"2014-12-12 01:32:20.000000000","message":"be in -\u003e participate in\n\nnecessary -\u003e is deemed necessary\n\nfor -\u003e to facilitate","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"order to promote sharing, reuse, innovation, and release of the \u0027out-of-tree\u0027"},{"line_number":31,"context_line":"backbone. It should not be required for any member of the core team to be"},{"line_number":32,"context_line":"involved with this process, although core members of the Neutron team can"},{"line_number":33,"context_line":"be in whichever capacity necessary for out-of-tree development."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Below, the following strategies will be documented:"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b5f57458","line":33,"in_reply_to":"3a961159_52f0e690","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"simply be submitted for code review, with the proviso that adequate"},{"line_number":52,"context_line":"documentation and 3rd CI party is supplied at the time of the code"},{"line_number":53,"context_line":"submission. For tracking purposes, the review itself can be tagged"},{"line_number":54,"context_line":"with a Launchpad bug report, marked as wishlist; design documents can still"},{"line_number":55,"context_line":"be supplied in form of RST documents, within the same vendor library repo,"},{"line_number":56,"context_line":"for documentation purposes;  If substantial changes to the common Neutron"},{"line_number":57,"context_line":"code are required, a spec that targets the work to common Neutron code will"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_927b2ef4","line":54,"updated":"2014-12-12 01:32:20.000000000","message":"report, marked as wishlist; design -\u003e report.  The bug should be marked as wishlist to avoid complicating tracking of Neutron\u0027s primary deliverables.  Design\n\ndocuments, within..purposes; -\u003e documents (within...repo).","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"simply be submitted for code review, with the proviso that adequate"},{"line_number":52,"context_line":"documentation and 3rd CI party is supplied at the time of the code"},{"line_number":53,"context_line":"submission. For tracking purposes, the review itself can be tagged"},{"line_number":54,"context_line":"with a Launchpad bug report, marked as wishlist; design documents can still"},{"line_number":55,"context_line":"be supplied in form of RST documents, within the same vendor library repo,"},{"line_number":56,"context_line":"for documentation purposes;  If substantial changes to the common Neutron"},{"line_number":57,"context_line":"code are required, a spec that targets the work to common Neutron code will"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b56ad4eb","line":54,"in_reply_to":"3a961159_927b2ef4","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"be typically needed, and a contributor is invited to seek guidance from"},{"line_number":59,"context_line":"the Neutron core team as to what steps to follow."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Once again, for submitting the integration module, no spec is required."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Development Strategy"},{"line_number":64,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d28136c4","line":61,"updated":"2014-12-12 01:32:20.000000000","message":"module -\u003e module to the Neutron codebase","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":58,"context_line":"be typically needed, and a contributor is invited to seek guidance from"},{"line_number":59,"context_line":"the Neutron core team as to what steps to follow."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Once again, for submitting the integration module, no spec is required."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Development Strategy"},{"line_number":64,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f570dcdd","line":61,"in_reply_to":"3a961159_d28136c4","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"--------------------"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* The following elements are suggested to be contributed in the tree"},{"line_number":67,"context_line":"  for plugins and drivers (called vendor integration hereinafter):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  * Data models;"},{"line_number":70,"context_line":"  * Extension definitions;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_527546f8","line":67,"updated":"2014-12-12 01:32:20.000000000","message":"Is it necessary to repeat these definitions from line 22 and 23 here?","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"--------------------"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* The following elements are suggested to be contributed in the tree"},{"line_number":67,"context_line":"  for plugins and drivers (called vendor integration hereinafter):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  * Data models;"},{"line_number":70,"context_line":"  * Extension definitions;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d5420067","line":67,"in_reply_to":"3a961159_527546f8","updated":"2014-12-12 02:11:52.000000000","message":"I was being more prescriptive here that\u0027s all.","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"* The following elements are suggested to be contributed in the tree"},{"line_number":67,"context_line":"  for plugins and drivers (called vendor integration hereinafter):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  * Data models;"},{"line_number":70,"context_line":"  * Extension definitions;"},{"line_number":71,"context_line":"  * Configuration files;"},{"line_number":72,"context_line":"  * Requirements file targeting vendor code;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b2674a4c","line":69,"updated":"2014-12-12 01:32:20.000000000","message":"Are these semicolons necessary or are you just missing java again?","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"* The following elements are suggested to be contributed in the tree"},{"line_number":67,"context_line":"  for plugins and drivers (called vendor integration hereinafter):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  * Data models;"},{"line_number":70,"context_line":"  * Extension definitions;"},{"line_number":71,"context_line":"  * Configuration files;"},{"line_number":72,"context_line":"  * Requirements file targeting vendor code;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_757cecb5","line":69,"in_reply_to":"3a961159_b2674a4c","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"The idea here would be to provide in-tree the plugin/driver code that"},{"line_number":80,"context_line":"implements an API, but have it delegate to out-of-tree code for"},{"line_number":81,"context_line":"backend-specific interactions; the vendor integration will then typically"},{"line_number":82,"context_line":"involve minor passthrough/parsing of parameters, minor handling of DB objects"},{"line_number":83,"context_line":"as well as handling of responses, whereas the vendor library will do the"},{"line_number":84,"context_line":"heavylifting and implement the vendor-specific logic. The boundary between"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f2eb9275","line":81,"updated":"2014-12-12 01:32:20.000000000","message":"interactions; the -\u003e interactions.  The","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"The idea here would be to provide in-tree the plugin/driver code that"},{"line_number":80,"context_line":"implements an API, but have it delegate to out-of-tree code for"},{"line_number":81,"context_line":"backend-specific interactions; the vendor integration will then typically"},{"line_number":82,"context_line":"involve minor passthrough/parsing of parameters, minor handling of DB objects"},{"line_number":83,"context_line":"as well as handling of responses, whereas the vendor library will do the"},{"line_number":84,"context_line":"heavylifting and implement the vendor-specific logic. The boundary between"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b53814f0","line":81,"in_reply_to":"3a961159_f2eb9275","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"while asking these types of questions:"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  * If something changes in my backend, do I need to alter the integration"},{"line_number":89,"context_line":"    layer drastically? Clearly, the least impact there is, the better the"},{"line_number":90,"context_line":"    separation being achieved;"},{"line_number":91,"context_line":"  * If I expose vendor details (e.g. protocols, auth, e.g.), can easily swap"},{"line_number":92,"context_line":"    and replace (e.g. a hardware with a newer version being supplied) without"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_52faa643","line":89,"updated":"2014-12-12 01:32:20.000000000","message":"least -\u003e less","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":86,"context_line":"while asking these types of questions:"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  * If something changes in my backend, do I need to alter the integration"},{"line_number":89,"context_line":"    layer drastically? Clearly, the least impact there is, the better the"},{"line_number":90,"context_line":"    separation being achieved;"},{"line_number":91,"context_line":"  * If I expose vendor details (e.g. protocols, auth, e.g.), can easily swap"},{"line_number":92,"context_line":"    and replace (e.g. a hardware with a newer version being supplied) without"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_352424c4","line":89,"in_reply_to":"3a961159_52faa643","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  * If something changes in my backend, do I need to alter the integration"},{"line_number":89,"context_line":"    layer drastically? Clearly, the least impact there is, the better the"},{"line_number":90,"context_line":"    separation being achieved;"},{"line_number":91,"context_line":"  * If I expose vendor details (e.g. protocols, auth, e.g.), can easily swap"},{"line_number":92,"context_line":"    and replace (e.g. a hardware with a newer version being supplied) without"},{"line_number":93,"context_line":"    affecting the integration too much? Clearly, the more reusable the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_9297aeeb","line":90,"updated":"2014-12-12 01:32:20.000000000","message":"achieved; -\u003e achieved.","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  * If something changes in my backend, do I need to alter the integration"},{"line_number":89,"context_line":"    layer drastically? Clearly, the least impact there is, the better the"},{"line_number":90,"context_line":"    separation being achieved;"},{"line_number":91,"context_line":"  * If I expose vendor details (e.g. protocols, auth, e.g.), can easily swap"},{"line_number":92,"context_line":"    and replace (e.g. a hardware with a newer version being supplied) without"},{"line_number":93,"context_line":"    affecting the integration too much? Clearly, the more reusable the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_752a2c91","line":90,"in_reply_to":"3a961159_9297aeeb","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  * If something changes in my backend, do I need to alter the integration"},{"line_number":89,"context_line":"    layer drastically? Clearly, the least impact there is, the better the"},{"line_number":90,"context_line":"    separation being achieved;"},{"line_number":91,"context_line":"  * If I expose vendor details (e.g. protocols, auth, e.g.), can easily swap"},{"line_number":92,"context_line":"    and replace (e.g. a hardware with a newer version being supplied) without"},{"line_number":93,"context_line":"    affecting the integration too much? Clearly, the more reusable the"},{"line_number":94,"context_line":"    integration the better separation."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b29caa10","line":91,"updated":"2014-12-12 01:32:20.000000000","message":"can -\u003e can I","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  * If something changes in my backend, do I need to alter the integration"},{"line_number":89,"context_line":"    layer drastically? Clearly, the least impact there is, the better the"},{"line_number":90,"context_line":"    separation being achieved;"},{"line_number":91,"context_line":"  * If I expose vendor details (e.g. protocols, auth, e.g.), can easily swap"},{"line_number":92,"context_line":"    and replace (e.g. a hardware with a newer version being supplied) without"},{"line_number":93,"context_line":"    affecting the integration too much? Clearly, the more reusable the"},{"line_number":94,"context_line":"    integration the better separation."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f5153c49","line":91,"in_reply_to":"3a961159_b29caa10","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    layer drastically? Clearly, the least impact there is, the better the"},{"line_number":90,"context_line":"    separation being achieved;"},{"line_number":91,"context_line":"  * If I expose vendor details (e.g. protocols, auth, e.g.), can easily swap"},{"line_number":92,"context_line":"    and replace (e.g. a hardware with a newer version being supplied) without"},{"line_number":93,"context_line":"    affecting the integration too much? Clearly, the more reusable the"},{"line_number":94,"context_line":"    integration the better separation."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d29db60b","line":92,"updated":"2014-12-12 01:32:20.000000000","message":"replace -\u003e replace the targeted backend","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    layer drastically? Clearly, the least impact there is, the better the"},{"line_number":90,"context_line":"    separation being achieved;"},{"line_number":91,"context_line":"  * If I expose vendor details (e.g. protocols, auth, e.g.), can easily swap"},{"line_number":92,"context_line":"    and replace (e.g. a hardware with a newer version being supplied) without"},{"line_number":93,"context_line":"    affecting the integration too much? Clearly, the more reusable the"},{"line_number":94,"context_line":"    integration the better separation."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_55045017","line":92,"in_reply_to":"3a961159_d29db60b","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  * If I expose vendor details (e.g. protocols, auth, e.g.), can easily swap"},{"line_number":92,"context_line":"    and replace (e.g. a hardware with a newer version being supplied) without"},{"line_number":93,"context_line":"    affecting the integration too much? Clearly, the more reusable the"},{"line_number":94,"context_line":"    integration the better separation."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The vendor code *must* be publicly available via pypi, or public source"},{"line_number":97,"context_line":"repository compatible with pip requirements; this requirements file should not"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f2a2b249","line":94,"updated":"2014-12-12 01:32:20.000000000","message":"better -\u003e better the","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  * If I expose vendor details (e.g. protocols, auth, e.g.), can easily swap"},{"line_number":92,"context_line":"    and replace (e.g. a hardware with a newer version being supplied) without"},{"line_number":93,"context_line":"    affecting the integration too much? Clearly, the more reusable the"},{"line_number":94,"context_line":"    integration the better separation."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The vendor code *must* be publicly available via pypi, or public source"},{"line_number":97,"context_line":"repository compatible with pip requirements; this requirements file should not"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_9828af87","line":94,"in_reply_to":"3a961159_f2a2b249","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    integration the better separation."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The vendor code *must* be publicly available via pypi, or public source"},{"line_number":97,"context_line":"repository compatible with pip requirements; this requirements file should not"},{"line_number":98,"context_line":"be confused with the Neutron requirements file that lists all common"},{"line_number":99,"context_line":"dependencies); instead it is a file \u0027requirements.txt\u0027 that is located in"},{"line_number":100,"context_line":"neutron/plugins/pluginXXX/, whose content is something along the lines of"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_728ec2d1","line":97,"updated":"2014-12-12 01:32:20.000000000","message":"requirements; this -\u003e requirements. This","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    integration the better separation."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The vendor code *must* be publicly available via pypi, or public source"},{"line_number":97,"context_line":"repository compatible with pip requirements; this requirements file should not"},{"line_number":98,"context_line":"be confused with the Neutron requirements file that lists all common"},{"line_number":99,"context_line":"dependencies); instead it is a file \u0027requirements.txt\u0027 that is located in"},{"line_number":100,"context_line":"neutron/plugins/pluginXXX/, whose content is something along the lines of"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_38397bd7","line":97,"in_reply_to":"3a961159_728ec2d1","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"The vendor code *must* be publicly available via pypi, or public source"},{"line_number":97,"context_line":"repository compatible with pip requirements; this requirements file should not"},{"line_number":98,"context_line":"be confused with the Neutron requirements file that lists all common"},{"line_number":99,"context_line":"dependencies); instead it is a file \u0027requirements.txt\u0027 that is located in"},{"line_number":100,"context_line":"neutron/plugins/pluginXXX/, whose content is something along the lines of"},{"line_number":101,"context_line":"\u0027my_plugin_xxx_library\u003e\u003dX.Y.Z\u0027. Vendors should be responsible for ensuring that"},{"line_number":102,"context_line":"their library did not depend on libraries conflicting with global requirements,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b2c3caeb","line":99,"updated":"2014-12-12 01:32:20.000000000","message":"dependencies); instead it is -\u003e dependencies.  Instead it should be","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":96,"context_line":"The vendor code *must* be publicly available via pypi, or public source"},{"line_number":97,"context_line":"repository compatible with pip requirements; this requirements file should not"},{"line_number":98,"context_line":"be confused with the Neutron requirements file that lists all common"},{"line_number":99,"context_line":"dependencies); instead it is a file \u0027requirements.txt\u0027 that is located in"},{"line_number":100,"context_line":"neutron/plugins/pluginXXX/, whose content is something along the lines of"},{"line_number":101,"context_line":"\u0027my_plugin_xxx_library\u003e\u003dX.Y.Z\u0027. Vendors should be responsible for ensuring that"},{"line_number":102,"context_line":"their library did not depend on libraries conflicting with global requirements,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d855d7fa","line":99,"in_reply_to":"3a961159_b2c3caeb","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"be confused with the Neutron requirements file that lists all common"},{"line_number":99,"context_line":"dependencies); instead it is a file \u0027requirements.txt\u0027 that is located in"},{"line_number":100,"context_line":"neutron/plugins/pluginXXX/, whose content is something along the lines of"},{"line_number":101,"context_line":"\u0027my_plugin_xxx_library\u003e\u003dX.Y.Z\u0027. Vendors should be responsible for ensuring that"},{"line_number":102,"context_line":"their library did not depend on libraries conflicting with global requirements,"},{"line_number":103,"context_line":"but could include libraries not included in the global requirements. Versioning"},{"line_number":104,"context_line":"can be used to pin vendor code to specific versions;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f2b9d279","line":101,"updated":"2014-12-12 01:32:20.000000000","message":"should be -\u003e are","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":98,"context_line":"be confused with the Neutron requirements file that lists all common"},{"line_number":99,"context_line":"dependencies); instead it is a file \u0027requirements.txt\u0027 that is located in"},{"line_number":100,"context_line":"neutron/plugins/pluginXXX/, whose content is something along the lines of"},{"line_number":101,"context_line":"\u0027my_plugin_xxx_library\u003e\u003dX.Y.Z\u0027. Vendors should be responsible for ensuring that"},{"line_number":102,"context_line":"their library did not depend on libraries conflicting with global requirements,"},{"line_number":103,"context_line":"but could include libraries not included in the global requirements. Versioning"},{"line_number":104,"context_line":"can be used to pin vendor code to specific versions;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_1843df42","line":101,"in_reply_to":"3a961159_f2b9d279","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"dependencies); instead it is a file \u0027requirements.txt\u0027 that is located in"},{"line_number":100,"context_line":"neutron/plugins/pluginXXX/, whose content is something along the lines of"},{"line_number":101,"context_line":"\u0027my_plugin_xxx_library\u003e\u003dX.Y.Z\u0027. Vendors should be responsible for ensuring that"},{"line_number":102,"context_line":"their library did not depend on libraries conflicting with global requirements,"},{"line_number":103,"context_line":"but could include libraries not included in the global requirements. Versioning"},{"line_number":104,"context_line":"can be used to pin vendor code to specific versions;"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_52a8e61f","line":102,"updated":"2014-12-12 01:32:20.000000000","message":"did -\u003e does","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"dependencies); instead it is a file \u0027requirements.txt\u0027 that is located in"},{"line_number":100,"context_line":"neutron/plugins/pluginXXX/, whose content is something along the lines of"},{"line_number":101,"context_line":"\u0027my_plugin_xxx_library\u003e\u003dX.Y.Z\u0027. Vendors should be responsible for ensuring that"},{"line_number":102,"context_line":"their library did not depend on libraries conflicting with global requirements,"},{"line_number":103,"context_line":"but could include libraries not included in the global requirements. Versioning"},{"line_number":104,"context_line":"can be used to pin vendor code to specific versions;"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_38409b33","line":102,"in_reply_to":"3a961159_52a8e61f","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"\u0027my_plugin_xxx_library\u003e\u003dX.Y.Z\u0027. Vendors should be responsible for ensuring that"},{"line_number":102,"context_line":"their library did not depend on libraries conflicting with global requirements,"},{"line_number":103,"context_line":"but could include libraries not included in the global requirements. Versioning"},{"line_number":104,"context_line":"can be used to pin vendor code to specific versions;"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"For instance a vendor integration module can become as simple as one that"},{"line_number":107,"context_line":"contains only the following:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b26aeaeb","line":104,"updated":"2014-12-12 01:32:20.000000000","message":"versions -\u003e versions.","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"\u0027my_plugin_xxx_library\u003e\u003dX.Y.Z\u0027. Vendors should be responsible for ensuring that"},{"line_number":102,"context_line":"their library did not depend on libraries conflicting with global requirements,"},{"line_number":103,"context_line":"but could include libraries not included in the global requirements. Versioning"},{"line_number":104,"context_line":"can be used to pin vendor code to specific versions;"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"For instance a vendor integration module can become as simple as one that"},{"line_number":107,"context_line":"contains only the following:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_7846a350","line":104,"in_reply_to":"3a961159_b26aeaeb","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"but could include libraries not included in the global requirements. Versioning"},{"line_number":104,"context_line":"can be used to pin vendor code to specific versions;"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"For instance a vendor integration module can become as simple as one that"},{"line_number":107,"context_line":"contains only the following:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* Registering config options;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f270f2dd","line":106,"updated":"2014-12-12 01:32:20.000000000","message":"instance -\u003e instance,","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":103,"context_line":"but could include libraries not included in the global requirements. Versioning"},{"line_number":104,"context_line":"can be used to pin vendor code to specific versions;"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"For instance a vendor integration module can become as simple as one that"},{"line_number":107,"context_line":"contains only the following:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* Registering config options;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d86cf7d2","line":106,"in_reply_to":"3a961159_f270f2dd","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"For instance a vendor integration module can become as simple as one that"},{"line_number":107,"context_line":"contains only the following:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* Registering config options;"},{"line_number":110,"context_line":"* Registering the plugin class;"},{"line_number":111,"context_line":"* Registering the models;"},{"line_number":112,"context_line":"* Registering the extensions."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_527f06ab","line":109,"updated":"2014-12-12 01:32:20.000000000","message":"Are you getting paid by the semicolon?  Or is there some rst formating requirement that I am not aware of?","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"For instance a vendor integration module can become as simple as one that"},{"line_number":107,"context_line":"contains only the following:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* Registering config options;"},{"line_number":110,"context_line":"* Registering the plugin class;"},{"line_number":111,"context_line":"* Registering the models;"},{"line_number":112,"context_line":"* Registering the extensions."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_186affb2","line":109,"in_reply_to":"3a961159_527f06ab","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"* There will be no unit tests for plugins and drivers in the tree; The"},{"line_number":120,"context_line":"  expectation is that contributors would run unit test in their own external"},{"line_number":121,"context_line":"  library (e.g. in stackforge where Jenkins setup is for free); For unit tests"},{"line_number":122,"context_line":"  that validate the vendor library, it is responsibility of the vendor to"},{"line_number":123,"context_line":"  choose what CI system they see fit to run them; there is no need or"},{"line_number":124,"context_line":"  requirement to use OpenStack CI resources if they do not want to;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_5256262b","line":121,"updated":"2014-12-12 01:32:20.000000000","message":"); -\u003e ).","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"* There will be no unit tests for plugins and drivers in the tree; The"},{"line_number":120,"context_line":"  expectation is that contributors would run unit test in their own external"},{"line_number":121,"context_line":"  library (e.g. in stackforge where Jenkins setup is for free); For unit tests"},{"line_number":122,"context_line":"  that validate the vendor library, it is responsibility of the vendor to"},{"line_number":123,"context_line":"  choose what CI system they see fit to run them; there is no need or"},{"line_number":124,"context_line":"  requirement to use OpenStack CI resources if they do not want to;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_785dc314","line":121,"in_reply_to":"3a961159_5256262b","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"* There will be no unit tests for plugins and drivers in the tree; The"},{"line_number":120,"context_line":"  expectation is that contributors would run unit test in their own external"},{"line_number":121,"context_line":"  library (e.g. in stackforge where Jenkins setup is for free); For unit tests"},{"line_number":122,"context_line":"  that validate the vendor library, it is responsibility of the vendor to"},{"line_number":123,"context_line":"  choose what CI system they see fit to run them; there is no need or"},{"line_number":124,"context_line":"  requirement to use OpenStack CI resources if they do not want to;"},{"line_number":125,"context_line":"  ultimately these tests can run as part of the 3rd party CI system that is"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b2382af0","line":122,"updated":"2014-12-12 01:32:20.000000000","message":"it is -\u003e it is the","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":119,"context_line":"* There will be no unit tests for plugins and drivers in the tree; The"},{"line_number":120,"context_line":"  expectation is that contributors would run unit test in their own external"},{"line_number":121,"context_line":"  library (e.g. in stackforge where Jenkins setup is for free); For unit tests"},{"line_number":122,"context_line":"  that validate the vendor library, it is responsibility of the vendor to"},{"line_number":123,"context_line":"  choose what CI system they see fit to run them; there is no need or"},{"line_number":124,"context_line":"  requirement to use OpenStack CI resources if they do not want to;"},{"line_number":125,"context_line":"  ultimately these tests can run as part of the 3rd party CI system that is"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_989d0fbf","line":122,"in_reply_to":"3a961159_b2382af0","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  expectation is that contributors would run unit test in their own external"},{"line_number":121,"context_line":"  library (e.g. in stackforge where Jenkins setup is for free); For unit tests"},{"line_number":122,"context_line":"  that validate the vendor library, it is responsibility of the vendor to"},{"line_number":123,"context_line":"  choose what CI system they see fit to run them; there is no need or"},{"line_number":124,"context_line":"  requirement to use OpenStack CI resources if they do not want to;"},{"line_number":125,"context_line":"  ultimately these tests can run as part of the 3rd party CI system that is"},{"line_number":126,"context_line":"  currently required, based on specific filters, if necessary."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_32243ac4","line":123,"updated":"2014-12-12 01:32:20.000000000","message":"them; there -\u003e them. There","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  expectation is that contributors would run unit test in their own external"},{"line_number":121,"context_line":"  library (e.g. in stackforge where Jenkins setup is for free); For unit tests"},{"line_number":122,"context_line":"  that validate the vendor library, it is responsibility of the vendor to"},{"line_number":123,"context_line":"  choose what CI system they see fit to run them; there is no need or"},{"line_number":124,"context_line":"  requirement to use OpenStack CI resources if they do not want to;"},{"line_number":125,"context_line":"  ultimately these tests can run as part of the 3rd party CI system that is"},{"line_number":126,"context_line":"  currently required, based on specific filters, if necessary."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f8a8d3dc","line":123,"in_reply_to":"3a961159_32243ac4","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  library (e.g. in stackforge where Jenkins setup is for free); For unit tests"},{"line_number":122,"context_line":"  that validate the vendor library, it is responsibility of the vendor to"},{"line_number":123,"context_line":"  choose what CI system they see fit to run them; there is no need or"},{"line_number":124,"context_line":"  requirement to use OpenStack CI resources if they do not want to;"},{"line_number":125,"context_line":"  ultimately these tests can run as part of the 3rd party CI system that is"},{"line_number":126,"context_line":"  currently required, based on specific filters, if necessary."},{"line_number":127,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_722a4291","line":124,"updated":"2014-12-12 01:32:20.000000000","message":"to; -\u003e to.","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  library (e.g. in stackforge where Jenkins setup is for free); For unit tests"},{"line_number":122,"context_line":"  that validate the vendor library, it is responsibility of the vendor to"},{"line_number":123,"context_line":"  choose what CI system they see fit to run them; there is no need or"},{"line_number":124,"context_line":"  requirement to use OpenStack CI resources if they do not want to;"},{"line_number":125,"context_line":"  ultimately these tests can run as part of the 3rd party CI system that is"},{"line_number":126,"context_line":"  currently required, based on specific filters, if necessary."},{"line_number":127,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d8a317fe","line":124,"in_reply_to":"3a961159_722a4291","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  that validate the vendor library, it is responsibility of the vendor to"},{"line_number":123,"context_line":"  choose what CI system they see fit to run them; there is no need or"},{"line_number":124,"context_line":"  requirement to use OpenStack CI resources if they do not want to;"},{"line_number":125,"context_line":"  ultimately these tests can run as part of the 3rd party CI system that is"},{"line_number":126,"context_line":"  currently required, based on specific filters, if necessary."},{"line_number":127,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":128,"context_line":"  functional testing; 3rd Party CI is a communication mechanism. This objective"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b21f4a6b","line":125,"updated":"2014-12-12 01:32:20.000000000","message":"ultimately -\u003e Ultimately","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  that validate the vendor library, it is responsibility of the vendor to"},{"line_number":123,"context_line":"  choose what CI system they see fit to run them; there is no need or"},{"line_number":124,"context_line":"  requirement to use OpenStack CI resources if they do not want to;"},{"line_number":125,"context_line":"  ultimately these tests can run as part of the 3rd party CI system that is"},{"line_number":126,"context_line":"  currently required, based on specific filters, if necessary."},{"line_number":127,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":128,"context_line":"  functional testing; 3rd Party CI is a communication mechanism. This objective"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_38aedbe6","line":125,"in_reply_to":"3a961159_b21f4a6b","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"  choose what CI system they see fit to run them; there is no need or"},{"line_number":124,"context_line":"  requirement to use OpenStack CI resources if they do not want to;"},{"line_number":125,"context_line":"  ultimately these tests can run as part of the 3rd party CI system that is"},{"line_number":126,"context_line":"  currently required, based on specific filters, if necessary."},{"line_number":127,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":128,"context_line":"  functional testing; 3rd Party CI is a communication mechanism. This objective"},{"line_number":129,"context_line":"  of this mechanism  is threefold:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_320b5a2b","line":126,"updated":"2014-12-12 01:32:20.000000000","message":"This line is pretty confusing.  Can you rephrase for clarity?","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":123,"context_line":"  choose what CI system they see fit to run them; there is no need or"},{"line_number":124,"context_line":"  requirement to use OpenStack CI resources if they do not want to;"},{"line_number":125,"context_line":"  ultimately these tests can run as part of the 3rd party CI system that is"},{"line_number":126,"context_line":"  currently required, based on specific filters, if necessary."},{"line_number":127,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":128,"context_line":"  functional testing; 3rd Party CI is a communication mechanism. This objective"},{"line_number":129,"context_line":"  of this mechanism  is threefold:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_78b4e334","line":126,"in_reply_to":"3a961159_320b5a2b","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  ultimately these tests can run as part of the 3rd party CI system that is"},{"line_number":126,"context_line":"  currently required, based on specific filters, if necessary."},{"line_number":127,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":128,"context_line":"  functional testing; 3rd Party CI is a communication mechanism. This objective"},{"line_number":129,"context_line":"  of this mechanism  is threefold:"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_95015807","line":128,"updated":"2014-12-12 01:32:20.000000000","message":"testing; -\u003e testing.","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  ultimately these tests can run as part of the 3rd party CI system that is"},{"line_number":126,"context_line":"  currently required, based on specific filters, if necessary."},{"line_number":127,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":128,"context_line":"  functional testing; 3rd Party CI is a communication mechanism. This objective"},{"line_number":129,"context_line":"  of this mechanism  is threefold:"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_588e477a","line":128,"in_reply_to":"3a961159_95015807","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  of this mechanism  is threefold:"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"},{"line_number":132,"context_line":"    a change that is potentially breaking. It is then up to the a given"},{"line_number":133,"context_line":"    contributor maintaining the affected plugin to determine whether the"},{"line_number":134,"context_line":"    failure is transient or real, and resolve the problem if it is;"},{"line_number":135,"context_line":"  * it communicates to a patch author that they may be breaking a plugin/driver."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b506541b","line":132,"updated":"2014-12-12 01:32:20.000000000","message":"the a -\u003e a","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  of this mechanism  is threefold:"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"},{"line_number":132,"context_line":"    a change that is potentially breaking. It is then up to the a given"},{"line_number":133,"context_line":"    contributor maintaining the affected plugin to determine whether the"},{"line_number":134,"context_line":"    failure is transient or real, and resolve the problem if it is;"},{"line_number":135,"context_line":"  * it communicates to a patch author that they may be breaking a plugin/driver."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_58e56736","line":132,"in_reply_to":"3a961159_b506541b","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"},{"line_number":132,"context_line":"    a change that is potentially breaking. It is then up to the a given"},{"line_number":133,"context_line":"    contributor maintaining the affected plugin to determine whether the"},{"line_number":134,"context_line":"    failure is transient or real, and resolve the problem if it is;"},{"line_number":135,"context_line":"  * it communicates to a patch author that they may be breaking a plugin/driver."},{"line_number":136,"context_line":"    If they have the time/energy/relationship with the maintainer of the"},{"line_number":137,"context_line":"    plugin/driver in question, then they can (at their discretion) work to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d5076016","line":134,"updated":"2014-12-12 01:32:20.000000000","message":"is; -\u003e is.","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"},{"line_number":132,"context_line":"    a change that is potentially breaking. It is then up to the a given"},{"line_number":133,"context_line":"    contributor maintaining the affected plugin to determine whether the"},{"line_number":134,"context_line":"    failure is transient or real, and resolve the problem if it is;"},{"line_number":135,"context_line":"  * it communicates to a patch author that they may be breaking a plugin/driver."},{"line_number":136,"context_line":"    If they have the time/energy/relationship with the maintainer of the"},{"line_number":137,"context_line":"    plugin/driver in question, then they can (at their discretion) work to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_78e22330","line":134,"in_reply_to":"3a961159_d5076016","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"  * it communicates to a patch author that they may be breaking a plugin/driver."},{"line_number":136,"context_line":"    If they have the time/energy/relationship with the maintainer of the"},{"line_number":137,"context_line":"    plugin/driver in question, then they can (at their discretion) work to"},{"line_number":138,"context_line":"    resolve the breakage;"},{"line_number":139,"context_line":"  * it communicates to the community at large whether a given plugin/driver"},{"line_number":140,"context_line":"    is being actively maintained."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f50c5c3d","line":138,"updated":"2014-12-12 01:32:20.000000000","message":"breakage; -\u003e breakage.","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":135,"context_line":"  * it communicates to a patch author that they may be breaking a plugin/driver."},{"line_number":136,"context_line":"    If they have the time/energy/relationship with the maintainer of the"},{"line_number":137,"context_line":"    plugin/driver in question, then they can (at their discretion) work to"},{"line_number":138,"context_line":"    resolve the breakage;"},{"line_number":139,"context_line":"  * it communicates to the community at large whether a given plugin/driver"},{"line_number":140,"context_line":"    is being actively maintained."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_98d26f5a","line":138,"in_reply_to":"3a961159_f50c5c3d","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    plugin/driver in question, then they can (at their discretion) work to"},{"line_number":138,"context_line":"    resolve the breakage;"},{"line_number":139,"context_line":"  * it communicates to the community at large whether a given plugin/driver"},{"line_number":140,"context_line":"    is being actively maintained."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Review and Defect Management Strategies"},{"line_number":143,"context_line":"---------------------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_95287887","line":140,"updated":"2014-12-12 01:32:20.000000000","message":"Maybe add something like the following to this point?\n\n \u0027A maintainer that perceived to be responsive to failures in their 3rd party CI jobs is likely to generate community goodwill\u0027","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    plugin/driver in question, then they can (at their discretion) work to"},{"line_number":138,"context_line":"    resolve the breakage;"},{"line_number":139,"context_line":"  * it communicates to the community at large whether a given plugin/driver"},{"line_number":140,"context_line":"    is being actively maintained."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Review and Defect Management Strategies"},{"line_number":143,"context_line":"---------------------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b8d72b4a","line":140,"in_reply_to":"3a961159_95287887","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"precisely:"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* Bugs that affect vendor code can be filed against the Neutron integration,"},{"line_number":149,"context_line":"  if the integration code is at fault; otherwise, the code maintainer may"},{"line_number":150,"context_line":"  decide to fix a bug without oversight, and issue a new version pin against"},{"line_number":151,"context_line":"  the requirements file for the code in question in case the vendor library is"},{"line_number":152,"context_line":"  being pinned; it makes sense to require 3rd party CI for a given"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f5237ca4","line":149,"updated":"2014-12-12 01:32:20.000000000","message":"fault; otherwise -\u003e fault.  Otherwise","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":146,"context_line":"precisely:"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* Bugs that affect vendor code can be filed against the Neutron integration,"},{"line_number":149,"context_line":"  if the integration code is at fault; otherwise, the code maintainer may"},{"line_number":150,"context_line":"  decide to fix a bug without oversight, and issue a new version pin against"},{"line_number":151,"context_line":"  the requirements file for the code in question in case the vendor library is"},{"line_number":152,"context_line":"  being pinned; it makes sense to require 3rd party CI for a given"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_381fbb09","line":149,"in_reply_to":"3a961159_f5237ca4","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* Bugs that affect vendor code can be filed against the Neutron integration,"},{"line_number":149,"context_line":"  if the integration code is at fault; otherwise, the code maintainer may"},{"line_number":150,"context_line":"  decide to fix a bug without oversight, and issue a new version pin against"},{"line_number":151,"context_line":"  the requirements file for the code in question in case the vendor library is"},{"line_number":152,"context_line":"  being pinned; it makes sense to require 3rd party CI for a given"},{"line_number":153,"context_line":"  plugin/driver to pass when changing their dependency before merging to any"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_752f8c88","line":150,"updated":"2014-12-12 01:32:20.000000000","message":"issue a new version pin...\n\nSomething like the following may make more sense\n\nand update their requirements file to target an updated version of their vendor library.","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* Bugs that affect vendor code can be filed against the Neutron integration,"},{"line_number":149,"context_line":"  if the integration code is at fault; otherwise, the code maintainer may"},{"line_number":150,"context_line":"  decide to fix a bug without oversight, and issue a new version pin against"},{"line_number":151,"context_line":"  the requirements file for the code in question in case the vendor library is"},{"line_number":152,"context_line":"  being pinned; it makes sense to require 3rd party CI for a given"},{"line_number":153,"context_line":"  plugin/driver to pass when changing their dependency before merging to any"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_58bc8706","line":150,"in_reply_to":"3a961159_752f8c88","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":151,"context_line":"  the requirements file for the code in question in case the vendor library is"},{"line_number":152,"context_line":"  being pinned; it makes sense to require 3rd party CI for a given"},{"line_number":153,"context_line":"  plugin/driver to pass when changing their dependency before merging to any"},{"line_number":154,"context_line":"  branch (i.e. both master and stable branches);"},{"line_number":155,"context_line":"* Vendor specific code follow the same review guidelines as any other code in"},{"line_number":156,"context_line":"  the tree, however, the code being reviewed strictly applies to integration"},{"line_number":157,"context_line":"  code or requirements\u0027 version bumps; as for the vendor library, it becomes"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d555a0fa","line":154,"updated":"2014-12-12 01:32:20.000000000","message":"branches); -\u003e branches).","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":151,"context_line":"  the requirements file for the code in question in case the vendor library is"},{"line_number":152,"context_line":"  being pinned; it makes sense to require 3rd party CI for a given"},{"line_number":153,"context_line":"  plugin/driver to pass when changing their dependency before merging to any"},{"line_number":154,"context_line":"  branch (i.e. both master and stable branches);"},{"line_number":155,"context_line":"* Vendor specific code follow the same review guidelines as any other code in"},{"line_number":156,"context_line":"  the tree, however, the code being reviewed strictly applies to integration"},{"line_number":157,"context_line":"  code or requirements\u0027 version bumps; as for the vendor library, it becomes"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_98398fa6","line":154,"in_reply_to":"3a961159_d555a0fa","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  being pinned; it makes sense to require 3rd party CI for a given"},{"line_number":153,"context_line":"  plugin/driver to pass when changing their dependency before merging to any"},{"line_number":154,"context_line":"  branch (i.e. both master and stable branches);"},{"line_number":155,"context_line":"* Vendor specific code follow the same review guidelines as any other code in"},{"line_number":156,"context_line":"  the tree, however, the code being reviewed strictly applies to integration"},{"line_number":157,"context_line":"  code or requirements\u0027 version bumps; as for the vendor library, it becomes"},{"line_number":158,"context_line":"  an external repo; the vendor can choose anyone to approve/merge changes in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_1543a842","line":155,"updated":"2014-12-12 01:32:20.000000000","message":"follow -\u003e should follow","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  being pinned; it makes sense to require 3rd party CI for a given"},{"line_number":153,"context_line":"  plugin/driver to pass when changing their dependency before merging to any"},{"line_number":154,"context_line":"  branch (i.e. both master and stable branches);"},{"line_number":155,"context_line":"* Vendor specific code follow the same review guidelines as any other code in"},{"line_number":156,"context_line":"  the tree, however, the code being reviewed strictly applies to integration"},{"line_number":157,"context_line":"  code or requirements\u0027 version bumps; as for the vendor library, it becomes"},{"line_number":158,"context_line":"  an external repo; the vendor can choose anyone to approve/merge changes in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b83e4b8a","line":155,"in_reply_to":"3a961159_1543a842","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"  plugin/driver to pass when changing their dependency before merging to any"},{"line_number":154,"context_line":"  branch (i.e. both master and stable branches);"},{"line_number":155,"context_line":"* Vendor specific code follow the same review guidelines as any other code in"},{"line_number":156,"context_line":"  the tree, however, the code being reviewed strictly applies to integration"},{"line_number":157,"context_line":"  code or requirements\u0027 version bumps; as for the vendor library, it becomes"},{"line_number":158,"context_line":"  an external repo; the vendor can choose anyone to approve/merge changes in"},{"line_number":159,"context_line":"  this repo;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_7546ac50","line":156,"updated":"2014-12-12 01:32:20.000000000","message":"tree, however, -\u003e tree. However,\n\nthe phrase starting with \u0027the code being reviewed\u0027  doesn\u0027t make sense to me.  Can you rephrase?","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":153,"context_line":"  plugin/driver to pass when changing their dependency before merging to any"},{"line_number":154,"context_line":"  branch (i.e. both master and stable branches);"},{"line_number":155,"context_line":"* Vendor specific code follow the same review guidelines as any other code in"},{"line_number":156,"context_line":"  the tree, however, the code being reviewed strictly applies to integration"},{"line_number":157,"context_line":"  code or requirements\u0027 version bumps; as for the vendor library, it becomes"},{"line_number":158,"context_line":"  an external repo; the vendor can choose anyone to approve/merge changes in"},{"line_number":159,"context_line":"  this repo;"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d83f9785","line":156,"in_reply_to":"3a961159_7546ac50","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"  branch (i.e. both master and stable branches);"},{"line_number":155,"context_line":"* Vendor specific code follow the same review guidelines as any other code in"},{"line_number":156,"context_line":"  the tree, however, the code being reviewed strictly applies to integration"},{"line_number":157,"context_line":"  code or requirements\u0027 version bumps; as for the vendor library, it becomes"},{"line_number":158,"context_line":"  an external repo; the vendor can choose anyone to approve/merge changes in"},{"line_number":159,"context_line":"  this repo;"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b57bb48a","line":157,"updated":"2014-12-12 01:32:20.000000000","message":"bumps; as -\u003e bumps. As","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":154,"context_line":"  branch (i.e. both master and stable branches);"},{"line_number":155,"context_line":"* Vendor specific code follow the same review guidelines as any other code in"},{"line_number":156,"context_line":"  the tree, however, the code being reviewed strictly applies to integration"},{"line_number":157,"context_line":"  code or requirements\u0027 version bumps; as for the vendor library, it becomes"},{"line_number":158,"context_line":"  an external repo; the vendor can choose anyone to approve/merge changes in"},{"line_number":159,"context_line":"  this repo;"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_9860afa6","line":157,"in_reply_to":"3a961159_b57bb48a","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"* Vendor specific code follow the same review guidelines as any other code in"},{"line_number":156,"context_line":"  the tree, however, the code being reviewed strictly applies to integration"},{"line_number":157,"context_line":"  code or requirements\u0027 version bumps; as for the vendor library, it becomes"},{"line_number":158,"context_line":"  an external repo; the vendor can choose anyone to approve/merge changes in"},{"line_number":159,"context_line":"  this repo;"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Documentation Strategies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d56cc0d2","line":158,"updated":"2014-12-12 01:32:20.000000000","message":"repo; the -\u003e repo. The","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":155,"context_line":"* Vendor specific code follow the same review guidelines as any other code in"},{"line_number":156,"context_line":"  the tree, however, the code being reviewed strictly applies to integration"},{"line_number":157,"context_line":"  code or requirements\u0027 version bumps; as for the vendor library, it becomes"},{"line_number":158,"context_line":"  an external repo; the vendor can choose anyone to approve/merge changes in"},{"line_number":159,"context_line":"  this repo;"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Documentation Strategies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f85b73f3","line":158,"in_reply_to":"3a961159_d56cc0d2","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  the tree, however, the code being reviewed strictly applies to integration"},{"line_number":157,"context_line":"  code or requirements\u0027 version bumps; as for the vendor library, it becomes"},{"line_number":158,"context_line":"  an external repo; the vendor can choose anyone to approve/merge changes in"},{"line_number":159,"context_line":"  this repo;"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Documentation Strategies"},{"line_number":162,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f571bca8","line":159,"updated":"2014-12-12 01:32:20.000000000","message":"repo; -\u003e repo.","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  the tree, however, the code being reviewed strictly applies to integration"},{"line_number":157,"context_line":"  code or requirements\u0027 version bumps; as for the vendor library, it becomes"},{"line_number":158,"context_line":"  an external repo; the vendor can choose anyone to approve/merge changes in"},{"line_number":159,"context_line":"  this repo;"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Documentation Strategies"},{"line_number":162,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_1874bf66","line":159,"in_reply_to":"3a961159_f571bca8","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"Documentation Strategies"},{"line_number":162,"context_line":"------------------------"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"It is a duty of the new contributor to provide working links to be referenced"},{"line_number":165,"context_line":"from the OpenStack upstream documentation."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"How-to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_15b1e846","line":164,"updated":"2014-12-12 01:32:20.000000000","message":"a duty of the new contributor -\u003e the duty of new contributors\n\nto be referenced -\u003e that can be referenced","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":161,"context_line":"Documentation Strategies"},{"line_number":162,"context_line":"------------------------"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"It is a duty of the new contributor to provide working links to be referenced"},{"line_number":165,"context_line":"from the OpenStack upstream documentation."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"How-to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_586ac781","line":164,"in_reply_to":"3a961159_15b1e846","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":175,"context_line":"  worth noting that you only get one shot at creating this repository. If you"},{"line_number":176,"context_line":"  want to prepulate this repository from another public github repo, you can"},{"line_number":177,"context_line":"  do so by specifying the upstream section for your project in"},{"line_number":178,"context_line":"  project-config/gerrit/project.yaml. This will help peserves the git history."},{"line_number":179,"context_line":"  Having said that, you can still import a repo at a later stage, but the"},{"line_number":180,"context_line":"  steps are more involved and require active help from the infra team;"},{"line_number":181,"context_line":"* TODO(armax)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d57a0076","line":178,"updated":"2014-12-12 01:32:20.000000000","message":"help peserves -\u003e preserve","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":175,"context_line":"  worth noting that you only get one shot at creating this repository. If you"},{"line_number":176,"context_line":"  want to prepulate this repository from another public github repo, you can"},{"line_number":177,"context_line":"  do so by specifying the upstream section for your project in"},{"line_number":178,"context_line":"  project-config/gerrit/project.yaml. This will help peserves the git history."},{"line_number":179,"context_line":"  Having said that, you can still import a repo at a later stage, but the"},{"line_number":180,"context_line":"  steps are more involved and require active help from the infra team;"},{"line_number":181,"context_line":"* TODO(armax)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_9807cfc9","line":178,"in_reply_to":"3a961159_d57a0076","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"5ac5c05729545682e4866a3685f58d96089dda6c","unresolved":false,"context_lines":[{"line_number":177,"context_line":"  do so by specifying the upstream section for your project in"},{"line_number":178,"context_line":"  project-config/gerrit/project.yaml. This will help peserves the git history."},{"line_number":179,"context_line":"  Having said that, you can still import a repo at a later stage, but the"},{"line_number":180,"context_line":"  steps are more involved and require active help from the infra team;"},{"line_number":181,"context_line":"* TODO(armax)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"The \u0027ODL ML2 Mechanism Driver\u0027 example"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f57ffc63","line":180,"updated":"2014-12-12 01:32:20.000000000","message":"team; -\u003e team.","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56fd109338911ddba56ca141500c3bff687d99d8","unresolved":false,"context_lines":[{"line_number":177,"context_line":"  do so by specifying the upstream section for your project in"},{"line_number":178,"context_line":"  project-config/gerrit/project.yaml. This will help peserves the git history."},{"line_number":179,"context_line":"  Having said that, you can still import a repo at a later stage, but the"},{"line_number":180,"context_line":"  steps are more involved and require active help from the infra team;"},{"line_number":181,"context_line":"* TODO(armax)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"The \u0027ODL ML2 Mechanism Driver\u0027 example"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b80c8bee","line":180,"in_reply_to":"3a961159_f57ffc63","updated":"2014-12-12 02:11:52.000000000","message":"Done","commit_id":"e0cc07d818b8ffe446052ef1aa526215a51adfdd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6d776dde67da5c11f299c4520fa556d965534c4c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    more reusable the integration the better the separation."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The vendor code *must* be publicly available via pypi, or public source"},{"line_number":100,"context_line":"repository compatible with pip requirements. This requirements file should not"},{"line_number":101,"context_line":"be confused with the Neutron requirements file that lists all common"},{"line_number":102,"context_line":"dependencies. Instead it should be a file \u0027requirements.txt\u0027 that is located in"},{"line_number":103,"context_line":"neutron/plugins/pluginXXX/, whose content is something along the lines of"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_b26c9fd1","line":100,"updated":"2014-12-12 09:56:39.000000000","message":"First, we talk about pypi/repo for vendor library, then we switch to requirements.txt file located in neutron repo itself. It should be rephrased somehow to avoid that mix.","commit_id":"4bdce939efa2e619e3d6de00b16be5217bb56d90"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d75b2b6f596c40b5e9e74a57580a2652dcb03b8d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    more reusable the integration the better the separation."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The vendor code *must* be publicly available via pypi, or public source"},{"line_number":100,"context_line":"repository compatible with pip requirements. This requirements file should not"},{"line_number":101,"context_line":"be confused with the Neutron requirements file that lists all common"},{"line_number":102,"context_line":"dependencies. Instead it should be a file \u0027requirements.txt\u0027 that is located in"},{"line_number":103,"context_line":"neutron/plugins/pluginXXX/, whose content is something along the lines of"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_d1291b9c","line":100,"in_reply_to":"3a961159_b26c9fd1","updated":"2014-12-12 17:47:37.000000000","message":"I\u0027ll rephrase, thanks","commit_id":"4bdce939efa2e619e3d6de00b16be5217bb56d90"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8ecd0cb236b98efc04461869885055d247610ccf","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  requirement to use OpenStack CI resources if they do not want to."},{"line_number":128,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":129,"context_line":"  functional testing. 3rd Party CI is a communication mechanism. This objective"},{"line_number":130,"context_line":"  of this mechanism  is threefold:"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"},{"line_number":133,"context_line":"    a change that is potentially breaking. It is then up to a given"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_78f78359","line":130,"range":{"start_line":130,"start_character":20,"end_line":130,"end_character":21},"updated":"2014-12-12 02:38:21.000000000","message":"extra whitespace","commit_id":"4bdce939efa2e619e3d6de00b16be5217bb56d90"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8ecd0cb236b98efc04461869885055d247610ccf","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  requirement to use OpenStack CI resources if they do not want to."},{"line_number":128,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":129,"context_line":"  functional testing. 3rd Party CI is a communication mechanism. This objective"},{"line_number":130,"context_line":"  of this mechanism  is threefold:"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"},{"line_number":133,"context_line":"    a change that is potentially breaking. It is then up to a given"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_38889bc4","line":130,"range":{"start_line":130,"start_character":24,"end_line":130,"end_character":33},"updated":"2014-12-12 02:38:21.000000000","message":"threefold?  there seems to be 4.","commit_id":"4bdce939efa2e619e3d6de00b16be5217bb56d90"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3161fc8fef6ab30c7142f0fa6252f491a0268282","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  requirement to use OpenStack CI resources if they do not want to."},{"line_number":128,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":129,"context_line":"  functional testing. 3rd Party CI is a communication mechanism. This objective"},{"line_number":130,"context_line":"  of this mechanism  is threefold:"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"},{"line_number":133,"context_line":"    a change that is potentially breaking. It is then up to a given"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_db1eb15e","line":130,"in_reply_to":"3a961159_38889bc4","updated":"2014-12-12 02:45:41.000000000","message":"Done","commit_id":"4bdce939efa2e619e3d6de00b16be5217bb56d90"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3161fc8fef6ab30c7142f0fa6252f491a0268282","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  requirement to use OpenStack CI resources if they do not want to."},{"line_number":128,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":129,"context_line":"  functional testing. 3rd Party CI is a communication mechanism. This objective"},{"line_number":130,"context_line":"  of this mechanism  is threefold:"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"},{"line_number":133,"context_line":"    a change that is potentially breaking. It is then up to a given"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_bb2d6597","line":130,"in_reply_to":"3a961159_78f78359","updated":"2014-12-12 02:45:41.000000000","message":"Done","commit_id":"4bdce939efa2e619e3d6de00b16be5217bb56d90"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6d776dde67da5c11f299c4520fa556d965534c4c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"------------------------"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"It is the duty of the new contributor to provide working links that can be"},{"line_number":165,"context_line":"referenced from the OpenStack upstream documentation."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"How-to"},{"line_number":168,"context_line":"------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_d2f68bf8","line":165,"updated":"2014-12-12 09:56:39.000000000","message":"Do we have a specific place to update with those links?","commit_id":"4bdce939efa2e619e3d6de00b16be5217bb56d90"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d75b2b6f596c40b5e9e74a57580a2652dcb03b8d","unresolved":false,"context_lines":[{"line_number":162,"context_line":"------------------------"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"It is the duty of the new contributor to provide working links that can be"},{"line_number":165,"context_line":"referenced from the OpenStack upstream documentation."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"How-to"},{"line_number":168,"context_line":"------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_6fa882db","line":165,"in_reply_to":"3a961159_d2f68bf8","updated":"2014-12-12 17:47:37.000000000","message":"I need to check with Anne and https://review.openstack.org/#/c/133372/\n\nIf I am unable to get more detailed information, I\u0027ll add a TODO here so that we can clean this up later.","commit_id":"4bdce939efa2e619e3d6de00b16be5217bb56d90"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8ecd0cb236b98efc04461869885055d247610ccf","unresolved":false,"context_lines":[{"line_number":181,"context_line":"* TODO(armax)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"The \u0027ODL ML2 Mechanism Driver\u0027 example"},{"line_number":184,"context_line":"--------------------------------------"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"* Create the StackForge repo: https://review.openstack.org/#/c/136854/"},{"line_number":187,"context_line":"* TODO(armax)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_d8423767","line":184,"updated":"2014-12-12 02:38:21.000000000","message":"please let me know if you want another example.","commit_id":"4bdce939efa2e619e3d6de00b16be5217bb56d90"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3161fc8fef6ab30c7142f0fa6252f491a0268282","unresolved":false,"context_lines":[{"line_number":181,"context_line":"* TODO(armax)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"The \u0027ODL ML2 Mechanism Driver\u0027 example"},{"line_number":184,"context_line":"--------------------------------------"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"* Create the StackForge repo: https://review.openstack.org/#/c/136854/"},{"line_number":187,"context_line":"* TODO(armax)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_1b3cb9c7","line":184,"in_reply_to":"3a961159_d8423767","updated":"2014-12-12 02:45:41.000000000","message":"we can add more over time, thanks for the offer, I\u0027ll certainly reach out to you!","commit_id":"4bdce939efa2e619e3d6de00b16be5217bb56d90"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"343f22caf257b9d67f1fb2d24c3e593630db4cb1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"with a Launchpad bug report. The bug should be marked as wishlist to"},{"line_number":56,"context_line":"avoid complicating tracking of Neutron\u0027s primary deliverables. Design"},{"line_number":57,"context_line":"documents can still be supplied in form of RST documents, within the same"},{"line_number":58,"context_line":"vendor library repo; if substantial change to the common Neutron code are"},{"line_number":59,"context_line":"required, a spec that targets the work to common Neutron code will be"},{"line_number":60,"context_line":"typically needed, and a contributor is invited to seek guidance from the"},{"line_number":61,"context_line":"Neutron core team as to what steps to follow."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_43755362","line":58,"updated":"2014-12-13 04:13:02.000000000","message":"repo; if -\u003e repo. If","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e6576fc3ee471b3a401db2ae1f1b3c71e558be13","unresolved":false,"context_lines":[{"line_number":55,"context_line":"with a Launchpad bug report. The bug should be marked as wishlist to"},{"line_number":56,"context_line":"avoid complicating tracking of Neutron\u0027s primary deliverables. Design"},{"line_number":57,"context_line":"documents can still be supplied in form of RST documents, within the same"},{"line_number":58,"context_line":"vendor library repo; if substantial change to the common Neutron code are"},{"line_number":59,"context_line":"required, a spec that targets the work to common Neutron code will be"},{"line_number":60,"context_line":"typically needed, and a contributor is invited to seek guidance from the"},{"line_number":61,"context_line":"Neutron core team as to what steps to follow."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_43fb9378","line":58,"in_reply_to":"3a961159_43755362","updated":"2014-12-13 04:54:38.000000000","message":"Done","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"343f22caf257b9d67f1fb2d24c3e593630db4cb1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"documents can still be supplied in form of RST documents, within the same"},{"line_number":58,"context_line":"vendor library repo; if substantial change to the common Neutron code are"},{"line_number":59,"context_line":"required, a spec that targets the work to common Neutron code will be"},{"line_number":60,"context_line":"typically needed, and a contributor is invited to seek guidance from the"},{"line_number":61,"context_line":"Neutron core team as to what steps to follow."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Once again, for submitting the integration module to the Neutron codebase,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_836bbb83","line":60,"updated":"2014-12-13 04:13:02.000000000","message":"be typically needed -\u003e typically be needed","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e6576fc3ee471b3a401db2ae1f1b3c71e558be13","unresolved":false,"context_lines":[{"line_number":57,"context_line":"documents can still be supplied in form of RST documents, within the same"},{"line_number":58,"context_line":"vendor library repo; if substantial change to the common Neutron code are"},{"line_number":59,"context_line":"required, a spec that targets the work to common Neutron code will be"},{"line_number":60,"context_line":"typically needed, and a contributor is invited to seek guidance from the"},{"line_number":61,"context_line":"Neutron core team as to what steps to follow."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Once again, for submitting the integration module to the Neutron codebase,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_63f6cf90","line":60,"in_reply_to":"3a961159_836bbb83","updated":"2014-12-13 04:54:38.000000000","message":"Done","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"343f22caf257b9d67f1fb2d24c3e593630db4cb1","unresolved":false,"context_lines":[{"line_number":103,"context_line":"a file \u0027requirements.txt\u0027 that is located in neutron/plugins/pluginXXX/,"},{"line_number":104,"context_line":"whose content is something along the lines of \u0027my_plugin_xxx_library\u003e\u003dX.Y.Z\u0027."},{"line_number":105,"context_line":"Vendors are responsible for ensuring that their library does not depend on"},{"line_number":106,"context_line":"libraries conflicting with global requirements, but could include libraries"},{"line_number":107,"context_line":"not included in the global requirements. Versioning can be used to pin vendor"},{"line_number":108,"context_line":"code to specific versions."},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_030fcbe1","line":106,"updated":"2014-12-13 04:13:02.000000000","message":"could include -\u003e it could depend on","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e6576fc3ee471b3a401db2ae1f1b3c71e558be13","unresolved":false,"context_lines":[{"line_number":103,"context_line":"a file \u0027requirements.txt\u0027 that is located in neutron/plugins/pluginXXX/,"},{"line_number":104,"context_line":"whose content is something along the lines of \u0027my_plugin_xxx_library\u003e\u003dX.Y.Z\u0027."},{"line_number":105,"context_line":"Vendors are responsible for ensuring that their library does not depend on"},{"line_number":106,"context_line":"libraries conflicting with global requirements, but could include libraries"},{"line_number":107,"context_line":"not included in the global requirements. Versioning can be used to pin vendor"},{"line_number":108,"context_line":"code to specific versions."},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_a3ec37bc","line":106,"in_reply_to":"3a961159_030fcbe1","updated":"2014-12-13 04:54:38.000000000","message":"Done","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"343f22caf257b9d67f1fb2d24c3e593630db4cb1","unresolved":false,"context_lines":[{"line_number":104,"context_line":"whose content is something along the lines of \u0027my_plugin_xxx_library\u003e\u003dX.Y.Z\u0027."},{"line_number":105,"context_line":"Vendors are responsible for ensuring that their library does not depend on"},{"line_number":106,"context_line":"libraries conflicting with global requirements, but could include libraries"},{"line_number":107,"context_line":"not included in the global requirements. Versioning can be used to pin vendor"},{"line_number":108,"context_line":"code to specific versions."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"For instance, a vendor integration module can become as simple as one that"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_43fc73b8","line":107,"updated":"2014-12-13 04:13:02.000000000","message":"Versioning... -\u003e Just as in Neutron\u0027s main requirements.txt, it will be possible to pin the version of the vendor library.","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e6576fc3ee471b3a401db2ae1f1b3c71e558be13","unresolved":false,"context_lines":[{"line_number":104,"context_line":"whose content is something along the lines of \u0027my_plugin_xxx_library\u003e\u003dX.Y.Z\u0027."},{"line_number":105,"context_line":"Vendors are responsible for ensuring that their library does not depend on"},{"line_number":106,"context_line":"libraries conflicting with global requirements, but could include libraries"},{"line_number":107,"context_line":"not included in the global requirements. Versioning can be used to pin vendor"},{"line_number":108,"context_line":"code to specific versions."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"For instance, a vendor integration module can become as simple as one that"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_03350b45","line":107,"in_reply_to":"3a961159_43fc73b8","updated":"2014-12-13 04:54:38.000000000","message":"Done","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"343f22caf257b9d67f1fb2d24c3e593630db4cb1","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"},{"line_number":134,"context_line":"    a change that is potentially breaking. It is then up to a given"},{"line_number":135,"context_line":"    contributor maintaining the affected plugin to determine whether the"},{"line_number":136,"context_line":"    failure is transient or real, and resolve the problem if it is."},{"line_number":137,"context_line":"  * it communicates to a patch author that they may be breaking a plugin/driver."},{"line_number":138,"context_line":"    If they have the time/energy/relationship with the maintainer of the"},{"line_number":139,"context_line":"    plugin/driver in question, then they can (at their discretion) work to"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_a3fd17b3","line":136,"updated":"2014-12-13 04:13:02.000000000","message":"if it is -\u003e","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e6576fc3ee471b3a401db2ae1f1b3c71e558be13","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"},{"line_number":134,"context_line":"    a change that is potentially breaking. It is then up to a given"},{"line_number":135,"context_line":"    contributor maintaining the affected plugin to determine whether the"},{"line_number":136,"context_line":"    failure is transient or real, and resolve the problem if it is."},{"line_number":137,"context_line":"  * it communicates to a patch author that they may be breaking a plugin/driver."},{"line_number":138,"context_line":"    If they have the time/energy/relationship with the maintainer of the"},{"line_number":139,"context_line":"    plugin/driver in question, then they can (at their discretion) work to"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_633def2a","line":136,"in_reply_to":"3a961159_a3fd17b3","updated":"2014-12-13 04:54:38.000000000","message":"?","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"343f22caf257b9d67f1fb2d24c3e593630db4cb1","unresolved":false,"context_lines":[{"line_number":152,"context_line":"* Bugs that affect vendor code can be filed against the Neutron integration,"},{"line_number":153,"context_line":"  if the integration code is at fault. Otherwise, the code maintainer may"},{"line_number":154,"context_line":"  decide to fix a bug without oversight, and update their requirements file"},{"line_number":155,"context_line":"  to target an updated version of their vendor library. It makes sense to"},{"line_number":156,"context_line":"  require 3rd party CI for a given plugin/driver to pass when changing their"},{"line_number":157,"context_line":"  dependency before merging to any branch (i.e. both master and stable branches)."},{"line_number":158,"context_line":"* Vendor specific code should follow the same review guidelines as any other"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_e332bfa5","line":155,"updated":"2014-12-13 04:13:02.000000000","message":"an updated -\u003e a new","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e6576fc3ee471b3a401db2ae1f1b3c71e558be13","unresolved":false,"context_lines":[{"line_number":152,"context_line":"* Bugs that affect vendor code can be filed against the Neutron integration,"},{"line_number":153,"context_line":"  if the integration code is at fault. Otherwise, the code maintainer may"},{"line_number":154,"context_line":"  decide to fix a bug without oversight, and update their requirements file"},{"line_number":155,"context_line":"  to target an updated version of their vendor library. It makes sense to"},{"line_number":156,"context_line":"  require 3rd party CI for a given plugin/driver to pass when changing their"},{"line_number":157,"context_line":"  dependency before merging to any branch (i.e. both master and stable branches)."},{"line_number":158,"context_line":"* Vendor specific code should follow the same review guidelines as any other"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_83481bcd","line":155,"in_reply_to":"3a961159_e332bfa5","updated":"2014-12-13 04:54:38.000000000","message":"Done","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"343f22caf257b9d67f1fb2d24c3e593630db4cb1","unresolved":false,"context_lines":[{"line_number":170,"context_line":"------"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"In case you wanted the vendor library to be hosted on StackForge, there are"},{"line_number":173,"context_line":"a number of steps to get you started, some of them may be optionals. Roughly"},{"line_number":174,"context_line":"this is what you need to do:"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"* Create a StackForge repository with the help of OpenStack Infra. The"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_0326eb67","line":173,"updated":"2014-12-13 04:13:02.000000000","message":"optionals -\u003e optional\n\nRoughly -\u003e Roughly,","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"343f22caf257b9d67f1fb2d24c3e593630db4cb1","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  worth noting that you only get one shot at creating this repository. If you"},{"line_number":179,"context_line":"  want to prepulate this repository from another public github repo, you can"},{"line_number":180,"context_line":"  do so by specifying the upstream section for your project in"},{"line_number":181,"context_line":"  project-config/gerrit/project.yaml. This will help peserve the git history."},{"line_number":182,"context_line":"  Having said that, a repo can still be imported at a later stage, but the"},{"line_number":183,"context_line":"  steps are more involved and require active help from the infra team, which"},{"line_number":184,"context_line":"  should be avoided to ease their burden."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_43239355","line":181,"updated":"2014-12-13 04:13:02.000000000","message":"help peserve -\u003e preserve","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e6576fc3ee471b3a401db2ae1f1b3c71e558be13","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  worth noting that you only get one shot at creating this repository. If you"},{"line_number":179,"context_line":"  want to prepulate this repository from another public github repo, you can"},{"line_number":180,"context_line":"  do so by specifying the upstream section for your project in"},{"line_number":181,"context_line":"  project-config/gerrit/project.yaml. This will help peserve the git history."},{"line_number":182,"context_line":"  Having said that, a repo can still be imported at a later stage, but the"},{"line_number":183,"context_line":"  steps are more involved and require active help from the infra team, which"},{"line_number":184,"context_line":"  should be avoided to ease their burden."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_c315c39c","line":181,"in_reply_to":"3a961159_43239355","updated":"2014-12-13 04:54:38.000000000","message":"Done","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"343f22caf257b9d67f1fb2d24c3e593630db4cb1","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    https://github.com/openstack-dev/cookiecutter to get a blank template"},{"line_number":188,"context_line":"    for a project to start from."},{"line_number":189,"context_line":"  * If you are contributing an existing driver/plugin, you may want to"},{"line_number":190,"context_line":"    preserve an existent history. This is what you need to do:"},{"line_number":191,"context_line":"    * ..."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"* TODO(armax)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_8319fb23","line":190,"updated":"2014-12-13 04:13:02.000000000","message":"existent -\u003e existing","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e6576fc3ee471b3a401db2ae1f1b3c71e558be13","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    https://github.com/openstack-dev/cookiecutter to get a blank template"},{"line_number":188,"context_line":"    for a project to start from."},{"line_number":189,"context_line":"  * If you are contributing an existing driver/plugin, you may want to"},{"line_number":190,"context_line":"    preserve an existent history. This is what you need to do:"},{"line_number":191,"context_line":"    * ..."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"* TODO(armax)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_030c2b93","line":190,"in_reply_to":"3a961159_8319fb23","updated":"2014-12-13 04:54:38.000000000","message":"Done","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"cbdb64a18dbcf89b10af0148f8280caf442f7163","unresolved":false,"context_lines":[{"line_number":189,"context_line":"  * If you are contributing an existing driver/plugin, you may want to"},{"line_number":190,"context_line":"    preserve an existent history. This is what you need to do:"},{"line_number":191,"context_line":"    * ..."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"* TODO(armax)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"The \u0027ODL ML2 Mechanism Driver\u0027 - example 1"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_c33a2398","line":192,"updated":"2014-12-13 03:48:14.000000000","message":"The infra steps are different for a fresh repo versus preserving history, and infra does not like to push history to stackforge if you\u0027ve already created an empty repo.  The decision fork is probably worth calling out.","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d4dbbdcb5d922b8f7ad5783a350a7fdeb87afee6","unresolved":false,"context_lines":[{"line_number":189,"context_line":"  * If you are contributing an existing driver/plugin, you may want to"},{"line_number":190,"context_line":"    preserve an existent history. This is what you need to do:"},{"line_number":191,"context_line":"    * ..."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"* TODO(armax)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"The \u0027ODL ML2 Mechanism Driver\u0027 - example 1"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_a366f7b8","line":192,"in_reply_to":"3a961159_c33a2398","updated":"2014-12-13 04:00:41.000000000","message":"yeah...I made the point on line 177, but I\u0027ll tweak the wording to stress this further.","commit_id":"7914f8400ed2d272302dd3e2a0350e00598dc7c1"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"13c2ae3299e4907b42111091f6b5e23608c30cc4","unresolved":false,"context_lines":[{"line_number":167,"context_line":"referenced from the OpenStack upstream documentation."},{"line_number":168,"context_line":"#TODO(armax): provide more info, when available."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"How-to"},{"line_number":171,"context_line":"------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"The how-to below assumes that the vendor library will be hosted on StackForge."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_8133b3f4","line":170,"updated":"2014-12-13 08:41:24.000000000","message":"Let\u0027s not duplicate information, instead link to http://docs.openstack.org/infra/manual/creators.html\n\nIf something essential is missing, add it to the infra-manuals repository.\n\nThis whole section shouldn\u0027t be needed besides mentioning tools/split.sh","commit_id":"259ac8cce4a3829a0a99040531edf7d4f2924ea4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"fb7101a38c5f2d451b95fe549b3799566c22768a","unresolved":false,"context_lines":[{"line_number":167,"context_line":"referenced from the OpenStack upstream documentation."},{"line_number":168,"context_line":"#TODO(armax): provide more info, when available."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"How-to"},{"line_number":171,"context_line":"------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"The how-to below assumes that the vendor library will be hosted on StackForge."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_bc1b747f","line":170,"in_reply_to":"3a961159_8133b3f4","updated":"2014-12-13 17:05:54.000000000","message":"Hi Andreas, I am all in for not duplicating information, in fact I haven\u0027t forgotten about your suggestion made elsewhere :)\n\nHowever, my objective here is to provide an excerpt that makes sense and applies directly to the context of Neutron and the vendor decomposition. \n\nDuring this process, if I find that information is missing in the link above, I\u0027ll beef that documentation up; at the same time, I am also referencing other available doc material, without duplication.\n\nI\u0027d rather give people a clear and short list of steps that surely applies to them (target audience here is the Neutron plugin developer, rather than the OpenStack project creator), than a much more verbose one to pick and mix from.","commit_id":"259ac8cce4a3829a0a99040531edf7d4f2924ea4"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"e38fa87702f96dd4103bf11844a224d2c3fb2c4e","unresolved":false,"context_lines":[{"line_number":167,"context_line":"referenced from the OpenStack upstream documentation."},{"line_number":168,"context_line":"#TODO(armax): provide more info, when available."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"How-to"},{"line_number":171,"context_line":"------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"The how-to below assumes that the vendor library will be hosted on StackForge."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_f711955d","line":170,"in_reply_to":"3a961159_97f6915b","updated":"2014-12-13 20:39:14.000000000","message":"Armando, why not make it smaller like (I\u0027m paraphrasing):\n\nHow-to\n----------\n\nRead the complete instructions at docs.openstack.org/infra/manual/creators.html first. The following is a condensed form for neutron vendor libraries.\n\nDo the following steps:\n*. Create a public repository.\n* ...\n* Ask the infra team to create your group as described in http://docs.openstack.org/infra/manual/creators.html#update-the-gerrit-group-members\n* ...","commit_id":"259ac8cce4a3829a0a99040531edf7d4f2924ea4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b49385cb17f9c0d27cb35bfa7807602fcdebdc84","unresolved":false,"context_lines":[{"line_number":167,"context_line":"referenced from the OpenStack upstream documentation."},{"line_number":168,"context_line":"#TODO(armax): provide more info, when available."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"How-to"},{"line_number":171,"context_line":"------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"The how-to below assumes that the vendor library will be hosted on StackForge."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_97f6915b","line":170,"in_reply_to":"3a961159_b7854d5b","updated":"2014-12-13 20:20:55.000000000","message":"\u003e we created the infra manual since many people duplicated the original content and tried to distill just the appropriate information - and then that become quickly outdated.\n\nI am not copying content over, but I am referencing practices and procedures that live elsewhere. Besides, your point presumes that it\u0027s not my responsibility to keep the documentation current. If others caused docs to rot, it doesn\u0027t necessarily mean that the same will happen here!\n\n\u003e Doug created the new content taking in what was used for oslo and generalized it.\n\nNot everyone has the same level of diligence or desire of looking at multiple sources and apply them to their task at hand.\n\n\u003e Please help us making infra manual useful for everybody\n\nAs I said elsewhere, I will. I just don\u0027t think that the two tasks (filling the gaps in the infra man and documenting the steps involved for the core/vendor decomp) are mutually exclusive.","commit_id":"259ac8cce4a3829a0a99040531edf7d4f2924ea4"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"29bf40661e6c0e34cd25e48a91e3bf2e027eef59","unresolved":false,"context_lines":[{"line_number":167,"context_line":"referenced from the OpenStack upstream documentation."},{"line_number":168,"context_line":"#TODO(armax): provide more info, when available."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"How-to"},{"line_number":171,"context_line":"------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"The how-to below assumes that the vendor library will be hosted on StackForge."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_b7854d5b","line":170,"in_reply_to":"3a961159_bc1b747f","updated":"2014-12-13 18:17:14.000000000","message":"Armando, we created the infra manual since many people duplicated the original content and tried to distill just the appropriate information - and then that become quickly outdated.\n\nDoug created the new content taking in what was used for oslo and generalized it.\n\nPlease help us making infra manual useful for everybody.","commit_id":"259ac8cce4a3829a0a99040531edf7d4f2924ea4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"01134775fd8b82df60ea8826f35802b2b35c0165","unresolved":false,"context_lines":[{"line_number":167,"context_line":"referenced from the OpenStack upstream documentation."},{"line_number":168,"context_line":"#TODO(armax): provide more info, when available."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"How-to"},{"line_number":171,"context_line":"------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"The how-to below assumes that the vendor library will be hosted on StackForge."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_120c6f3a","line":170,"in_reply_to":"3a961159_f711955d","updated":"2014-12-13 20:42:14.000000000","message":"I\u0027ll see what it makes sense to slim down, thanks!","commit_id":"259ac8cce4a3829a0a99040531edf7d4f2924ea4"},{"author":{"_account_id":13523,"name":"Vadivel Poonathan","email":"vadivel.openstack@gmail.com","username":"vpoonathan"},"change_message_id":"01d5e8ba03cc336f30b15d9c63a8d32095bb1875","unresolved":false,"context_lines":[{"line_number":111,"context_line":"For instance, a vendor integration module can become as simple as one that"},{"line_number":112,"context_line":"contains only the following:"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* Registering config options"},{"line_number":115,"context_line":"* Registering the plugin class"},{"line_number":116,"context_line":"* Registering the models"},{"line_number":117,"context_line":"* Registering the extensions"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_a2395f43","line":114,"updated":"2014-12-16 00:21:11.000000000","message":"Why do we need to have config parameters of the vendor plugin/mech_driver to be part of integration code?... cant we have it in the vendor library itself?... Bcos if the vendor adds/modifies/removes any of the config parameter later or its definition or default values etc, it unnecessarily calls for changes in the \"intergration\" code too. So keeping them in the vendor library would server the intended purpose (remember \u0027more reusable the integration the better the separation\u0027 etc).","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e92680e0afe256ea9ba273c23274fc25c3e31e48","unresolved":false,"context_lines":[{"line_number":111,"context_line":"For instance, a vendor integration module can become as simple as one that"},{"line_number":112,"context_line":"contains only the following:"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* Registering config options"},{"line_number":115,"context_line":"* Registering the plugin class"},{"line_number":116,"context_line":"* Registering the models"},{"line_number":117,"context_line":"* Registering the extensions"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_d0d46049","line":114,"in_reply_to":"3a961159_a2395f43","updated":"2014-12-16 14:14:24.000000000","message":"because of the way some of docs are currently generated?","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f26c130c14048ea30c30976fe822400b11ab38a6","unresolved":false,"context_lines":[{"line_number":111,"context_line":"For instance, a vendor integration module can become as simple as one that"},{"line_number":112,"context_line":"contains only the following:"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* Registering config options"},{"line_number":115,"context_line":"* Registering the plugin class"},{"line_number":116,"context_line":"* Registering the models"},{"line_number":117,"context_line":"* Registering the extensions"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_06aa27d4","line":114,"in_reply_to":"3a961159_d0d46049","updated":"2014-12-16 19:54:42.000000000","message":"The initial rationale is that we want to make sure that these modifications are captured by a DocImpact change, so that they end up being reflected in the docs somehow.  If we skip this part, it\u0027s easy to \u0027forget\u0027 :(\n\nWe can revise this later, though","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":13523,"name":"Vadivel Poonathan","email":"vadivel.openstack@gmail.com","username":"vpoonathan"},"change_message_id":"01d5e8ba03cc336f30b15d9c63a8d32095bb1875","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  requirement to use OpenStack CI resources if they do not want to."},{"line_number":130,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":131,"context_line":"  functional testing. 3rd Party CI is a communication mechanism. This objective"},{"line_number":132,"context_line":"  of this mechanism is as follows:"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"},{"line_number":135,"context_line":"    a change that is potentially breaking. It is then up to a given"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_627db7e7","line":132,"updated":"2014-12-16 00:21:11.000000000","message":"How about the CI test results/logs of the vendor plugin/driers?... Do they have to be automatically uploaded back to the Neutron and so on?.. Anything is gated on this test results?...","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"97668c5889c5dc8e7ede9de9be5093dcf8c249b4","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  requirement to use OpenStack CI resources if they do not want to."},{"line_number":130,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":131,"context_line":"  functional testing. 3rd Party CI is a communication mechanism. This objective"},{"line_number":132,"context_line":"  of this mechanism is as follows:"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"},{"line_number":135,"context_line":"    a change that is potentially breaking. It is then up to a given"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_45c34c8a","line":132,"in_reply_to":"3a961159_627db7e7","updated":"2014-12-16 17:06:43.000000000","message":"This question isn\u0027t related to the documentation here. There are no changes in what we expect from third party CI for those having a shim in-tree. It\u0027s still the same requirements as before.","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"97668c5889c5dc8e7ede9de9be5093dcf8c249b4","unresolved":false,"context_lines":[{"line_number":209,"context_line":"  * (Optional) If the repository has already being initialized with"},{"line_number":210,"context_line":"    cookiecutter, you need to pull first; if not, you can either push"},{"line_number":211,"context_line":"    the existing commits/tags or apply and commit further changes to fix"},{"line_number":212,"context_line":"    up the structure of repo the way you see fit."},{"line_number":213,"context_line":"  * Finally, push commits and tags to the repository."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    ::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_45f8acc4","line":212,"updated":"2014-12-16 17:06:43.000000000","message":"I think only infra can do this step, unless I\u0027m missing something. I think you have to create the repository with the set of history commits, which is easier for infra.","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f26c130c14048ea30c30976fe822400b11ab38a6","unresolved":false,"context_lines":[{"line_number":209,"context_line":"  * (Optional) If the repository has already being initialized with"},{"line_number":210,"context_line":"    cookiecutter, you need to pull first; if not, you can either push"},{"line_number":211,"context_line":"    the existing commits/tags or apply and commit further changes to fix"},{"line_number":212,"context_line":"    up the structure of repo the way you see fit."},{"line_number":213,"context_line":"  * Finally, push commits and tags to the repository."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    ::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_c63bbf9a","line":212,"in_reply_to":"3a961159_45f8acc4","updated":"2014-12-16 19:54:42.000000000","message":"I meant commit locally, I\u0027ll rephrase.","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"97668c5889c5dc8e7ede9de9be5093dcf8c249b4","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    cookiecutter, you need to pull first; if not, you can either push"},{"line_number":211,"context_line":"    the existing commits/tags or apply and commit further changes to fix"},{"line_number":212,"context_line":"    up the structure of repo the way you see fit."},{"line_number":213,"context_line":"  * Finally, push commits and tags to the repository."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    ::"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_850294b2","line":213,"updated":"2014-12-16 17:06:43.000000000","message":"Again, only infra can do this step.","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f26c130c14048ea30c30976fe822400b11ab38a6","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    cookiecutter, you need to pull first; if not, you can either push"},{"line_number":211,"context_line":"    the existing commits/tags or apply and commit further changes to fix"},{"line_number":212,"context_line":"    up the structure of repo the way you see fit."},{"line_number":213,"context_line":"  * Finally, push commits and tags to the repository."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    ::"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_2671e377","line":213,"in_reply_to":"3a961159_850294b2","updated":"2014-12-16 19:54:42.000000000","message":"At this point you\u0027d be pushing to the public repo created to the first bullet. I\u0027ll rephrase to clarify.","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e92680e0afe256ea9ba273c23274fc25c3e31e48","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    ::"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        git remote add \u003cfoo\u003e https://github.com/john-doe/foo.git"},{"line_number":218,"context_line":"        git pull foo master # this is in case you already have commits in foo"},{"line_number":219,"context_line":"        git push --all foo \u0026\u0026 git push --tags foo"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"* Create a StackForge repository: for this you need the help of the OpenStack"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_5047901d","line":218,"updated":"2014-12-16 14:14:24.000000000","message":"in that case the following push will be non fast-forward?\n\nit\u0027s simpler to just say \"start with the empty repo\".","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f26c130c14048ea30c30976fe822400b11ab38a6","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    ::"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        git remote add \u003cfoo\u003e https://github.com/john-doe/foo.git"},{"line_number":218,"context_line":"        git pull foo master # this is in case you already have commits in foo"},{"line_number":219,"context_line":"        git push --all foo \u0026\u0026 git push --tags foo"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"* Create a StackForge repository: for this you need the help of the OpenStack"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_466eef97","line":218,"in_reply_to":"3a961159_5047901d","updated":"2014-12-16 19:54:42.000000000","message":"Can do.","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"eee85b39bf4e4fd852b64e5a0780e0202f05768c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"  to start from a clean slate, or you want to import the repo created during"},{"line_number":225,"context_line":"  the previous step. In the latter case, you can do so by specifying the"},{"line_number":226,"context_line":"  upstream section for your project in project-config/gerrit/project.yaml."},{"line_number":227,"context_line":"  Steps are documented on: http://ci.openstack.org/stackforge.html."},{"line_number":228,"context_line":"* Ask for a Launchpad user to be assigned to the core team created. This"},{"line_number":229,"context_line":"  can be done by filing a task on http://storyboard.openstack.org and/or"},{"line_number":230,"context_line":"  reaching out a member of the infra team on irc #openstack-infra."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_fe27adc7","line":227,"updated":"2014-12-14 08:10:26.000000000","message":"The page mainly redirects now to:\nhttp://docs.openstack.org/infra/manual/creators.html","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8624189c2e91b5460cf978b6707528f3ed2d37e6","unresolved":false,"context_lines":[{"line_number":224,"context_line":"  to start from a clean slate, or you want to import the repo created during"},{"line_number":225,"context_line":"  the previous step. In the latter case, you can do so by specifying the"},{"line_number":226,"context_line":"  upstream section for your project in project-config/gerrit/project.yaml."},{"line_number":227,"context_line":"  Steps are documented on: http://ci.openstack.org/stackforge.html."},{"line_number":228,"context_line":"* Ask for a Launchpad user to be assigned to the core team created. This"},{"line_number":229,"context_line":"  can be done by filing a task on http://storyboard.openstack.org and/or"},{"line_number":230,"context_line":"  reaching out a member of the infra team on irc #openstack-infra."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_678df0d2","line":227,"in_reply_to":"3a961159_fe27adc7","updated":"2014-12-14 17:53:01.000000000","message":"Sure thing.\n\nAs far as these instructions go, I am still working out to what length I need to go here, and what I will eventually pull out and move to the infra manual. For now, it\u0027s easier if I iterate just in one place, rather than two, and revise later.","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"eee85b39bf4e4fd852b64e5a0780e0202f05768c","unresolved":false,"context_lines":[{"line_number":227,"context_line":"  Steps are documented on: http://ci.openstack.org/stackforge.html."},{"line_number":228,"context_line":"* Ask for a Launchpad user to be assigned to the core team created. This"},{"line_number":229,"context_line":"  can be done by filing a task on http://storyboard.openstack.org and/or"},{"line_number":230,"context_line":"  reaching out a member of the infra team on irc #openstack-infra."},{"line_number":231,"context_line":"* Fix, fix, fix: at this point you have an external base to work on. You"},{"line_number":232,"context_line":"  can develop against the new stackforge project, the same way you work"},{"line_number":233,"context_line":"  with any other OpenStack project: you have pep8, docs, and python27 CI"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_3e2e95a5","line":230,"updated":"2014-12-14 08:10:26.000000000","message":"Link to http://docs.openstack.org/infra/manual/creators.html#update-the-gerrit-group-members","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8624189c2e91b5460cf978b6707528f3ed2d37e6","unresolved":false,"context_lines":[{"line_number":227,"context_line":"  Steps are documented on: http://ci.openstack.org/stackforge.html."},{"line_number":228,"context_line":"* Ask for a Launchpad user to be assigned to the core team created. This"},{"line_number":229,"context_line":"  can be done by filing a task on http://storyboard.openstack.org and/or"},{"line_number":230,"context_line":"  reaching out a member of the infra team on irc #openstack-infra."},{"line_number":231,"context_line":"* Fix, fix, fix: at this point you have an external base to work on. You"},{"line_number":232,"context_line":"  can develop against the new stackforge project, the same way you work"},{"line_number":233,"context_line":"  with any other OpenStack project: you have pep8, docs, and python27 CI"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_c79ea406","line":230,"in_reply_to":"3a961159_3e2e95a5","updated":"2014-12-14 17:53:01.000000000","message":"Done","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"ec11668e573c63fef17fd7c8f8437567781c619e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Development Strategy"},{"line_number":67,"context_line":"--------------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* The following elements are suggested to be contributed in the tree"},{"line_number":70,"context_line":"  for plugins and drivers (called vendor integration hereinafter):"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  * Data models"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_3c69f225","line":69,"updated":"2014-12-16 20:56:04.000000000","message":"Can you please clarify regarding contribution process of the \u0027in the tree\u0027 elements. Is spec required for initial submission as well as for further enchantments?","commit_id":"3e0eb70f8ee662715d4ba2f9cd127edaf05bff1c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"deefb93fd51ceaa3043936630ca3f9d656fc84a6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Development Strategy"},{"line_number":67,"context_line":"--------------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* The following elements are suggested to be contributed in the tree"},{"line_number":70,"context_line":"  for plugins and drivers (called vendor integration hereinafter):"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  * Data models"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_2209c12c","line":69,"in_reply_to":"3a961159_3c69f225","updated":"2014-12-17 03:19:26.000000000","message":"Done","commit_id":"3e0eb70f8ee662715d4ba2f9cd127edaf05bff1c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"73637324575f79ab6caee29bbe00fe5c7d7f9634","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    At this point you will have the project pruned of everything else but"},{"line_number":207,"context_line":"    the files you want to export, with their history. The next steps are:"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"  * Add a remote that points to the repository created before."},{"line_number":210,"context_line":"  * (Optional) If the repository has already being initialized with"},{"line_number":211,"context_line":"    cookiecutter, you need to pull first; if not, you can either push"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_8c470e1d","line":208,"updated":"2014-12-17 02:05:21.000000000","message":"you need to commit .gitreview changes made by the script here.","commit_id":"3e0eb70f8ee662715d4ba2f9cd127edaf05bff1c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"deefb93fd51ceaa3043936630ca3f9d656fc84a6","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    At this point you will have the project pruned of everything else but"},{"line_number":207,"context_line":"    the files you want to export, with their history. The next steps are:"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"  * Add a remote that points to the repository created before."},{"line_number":210,"context_line":"  * (Optional) If the repository has already being initialized with"},{"line_number":211,"context_line":"    cookiecutter, you need to pull first; if not, you can either push"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_c230fdea","line":208,"in_reply_to":"3a961159_8c470e1d","updated":"2014-12-17 03:19:26.000000000","message":"whoever calls the script certainly needs to do so; do I really have to spell it out? People who read this should be capable enough to figure that out :)\n\nRead line 212: \"apply and commit further changes...\"\n\nBut, if you feel strongly I can certainly make the instructions more detailed","commit_id":"3e0eb70f8ee662715d4ba2f9cd127edaf05bff1c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d7085faa726fffea825143e3126d2f34f012e934","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    At this point you will have the project pruned of everything else but"},{"line_number":207,"context_line":"    the files you want to export, with their history. The next steps are:"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"  * Add a remote that points to the repository created before."},{"line_number":210,"context_line":"  * (Optional) If the repository has already being initialized with"},{"line_number":211,"context_line":"    cookiecutter, you need to pull first; if not, you can either push"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_a2f051ca","line":208,"in_reply_to":"3a961159_c230fdea","updated":"2014-12-17 03:32:48.000000000","message":"i don\u0027t feel so strong.  but the script leaving unstaged changes might surprise people.","commit_id":"3e0eb70f8ee662715d4ba2f9cd127edaf05bff1c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e1df9e63422fcc0eeb23c1a4da7a96e00a89bbc2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Below, the following strategies will be documented:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Design and Development;"},{"line_number":39,"context_line":"* Testing and Continous Integration;"},{"line_number":40,"context_line":"* Defect Management;"},{"line_number":41,"context_line":"* Documentation;"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_3f192cd1","line":39,"updated":"2014-12-23 21:30:38.000000000","message":"continuous","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b6bc01ef3bf020652794b94e8eaa62e503397205","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Below, the following strategies will be documented:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Design and Development;"},{"line_number":39,"context_line":"* Testing and Continous Integration;"},{"line_number":40,"context_line":"* Defect Management;"},{"line_number":41,"context_line":"* Documentation;"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_b9883823","line":39,"in_reply_to":"3a961159_3f192cd1","updated":"2015-01-06 00:13:22.000000000","message":"Done","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"b1e766c81aa39987f3aad91a86186488a6193749","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  * If something changes in my backend, do I need to alter the integration"},{"line_number":93,"context_line":"    layer drastically? Clearly, the less impact there is, the better the"},{"line_number":94,"context_line":"    separation being achieved."},{"line_number":95,"context_line":"  * If I expose vendor details (e.g. protocols, auth, e.g.), can I easily swap"},{"line_number":96,"context_line":"    and replace the targeted backend (e.g. a hardware with a newer version"},{"line_number":97,"context_line":"    being supplied) without affecting the integration too much? Clearly, the"},{"line_number":98,"context_line":"    more reusable the integration the better the separation."}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_ae02d7b1","line":95,"updated":"2015-01-02 20:47:44.000000000","message":"auth, e.g. -\u003e auth, etc.","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b6bc01ef3bf020652794b94e8eaa62e503397205","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  * If something changes in my backend, do I need to alter the integration"},{"line_number":93,"context_line":"    layer drastically? Clearly, the less impact there is, the better the"},{"line_number":94,"context_line":"    separation being achieved."},{"line_number":95,"context_line":"  * If I expose vendor details (e.g. protocols, auth, e.g.), can I easily swap"},{"line_number":96,"context_line":"    and replace the targeted backend (e.g. a hardware with a newer version"},{"line_number":97,"context_line":"    being supplied) without affecting the integration too much? Clearly, the"},{"line_number":98,"context_line":"    more reusable the integration the better the separation."}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_f97e401a","line":95,"in_reply_to":"3a961159_ae02d7b1","updated":"2015-01-06 00:13:22.000000000","message":"Done","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"b1e766c81aa39987f3aad91a86186488a6193749","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    layer drastically? Clearly, the less impact there is, the better the"},{"line_number":94,"context_line":"    separation being achieved."},{"line_number":95,"context_line":"  * If I expose vendor details (e.g. protocols, auth, e.g.), can I easily swap"},{"line_number":96,"context_line":"    and replace the targeted backend (e.g. a hardware with a newer version"},{"line_number":97,"context_line":"    being supplied) without affecting the integration too much? Clearly, the"},{"line_number":98,"context_line":"    more reusable the integration the better the separation."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_cefd63b3","line":96,"updated":"2015-01-02 20:47:44.000000000","message":"a hardware -\u003e hardware","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b6bc01ef3bf020652794b94e8eaa62e503397205","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    layer drastically? Clearly, the less impact there is, the better the"},{"line_number":94,"context_line":"    separation being achieved."},{"line_number":95,"context_line":"  * If I expose vendor details (e.g. protocols, auth, e.g.), can I easily swap"},{"line_number":96,"context_line":"    and replace the targeted backend (e.g. a hardware with a newer version"},{"line_number":97,"context_line":"    being supplied) without affecting the integration too much? Clearly, the"},{"line_number":98,"context_line":"    more reusable the integration the better the separation."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_1984ec09","line":96,"in_reply_to":"3a961159_cefd63b3","updated":"2015-01-06 00:13:22.000000000","message":"Done","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"b1e766c81aa39987f3aad91a86186488a6193749","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    being supplied) without affecting the integration too much? Clearly, the"},{"line_number":98,"context_line":"    more reusable the integration the better the separation."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"As mentioned above, the vendor code *must* be available via a public (git)"},{"line_number":101,"context_line":"repository. By doing so, the module itself can be made accessible using a"},{"line_number":102,"context_line":"pip requirements file. This file  should not be confused with the Neutron"},{"line_number":103,"context_line":"requirements file that lists all common dependencies. Instead it should be"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_ce1483eb","line":100,"updated":"2015-01-02 20:47:44.000000000","message":"The sentence starting on line 26, requiring that code be available via stackforge, tarball or pypi, would appear to contradict this sentence\u0027s requirement.  \n\nSeparately, what are your thoughts on how a requirement for publicly-available source should be enforced?","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b6bc01ef3bf020652794b94e8eaa62e503397205","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    being supplied) without affecting the integration too much? Clearly, the"},{"line_number":98,"context_line":"    more reusable the integration the better the separation."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"As mentioned above, the vendor code *must* be available via a public (git)"},{"line_number":101,"context_line":"repository. By doing so, the module itself can be made accessible using a"},{"line_number":102,"context_line":"pip requirements file. This file  should not be confused with the Neutron"},{"line_number":103,"context_line":"requirements file that lists all common dependencies. Instead it should be"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_99eb7ca3","line":100,"in_reply_to":"3a961159_ce1483eb","updated":"2015-01-06 00:13:22.000000000","message":"You\u0027re right, I\u0027ll tweak the wording.\n\nAs for enforcing the requirement, I think we\u0027re only left with manual verification; having said that, I would find hard to believe that anyone would have a hard time complying with this requirement, it\u0027s in their best interest.","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e1df9e63422fcc0eeb23c1a4da7a96e00a89bbc2","unresolved":false,"context_lines":[{"line_number":107,"context_line":"libraries conflicting with global requirements, but it could depend on"},{"line_number":108,"context_line":"libraries not included in the global requirements. Just as in Neutron\u0027s"},{"line_number":109,"context_line":"main requirements.txt, it will be possible to pin the version of the vendor"},{"line_number":110,"context_line":"library."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"For instance, a vendor integration module can become as simple as one that"},{"line_number":113,"context_line":"contains only the following:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_3fde8cda","line":110,"updated":"2014-12-23 21:30:38.000000000","message":"Do we track backports that require version bump the same way as for main requirements (not allowing any version bump)?","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b6bc01ef3bf020652794b94e8eaa62e503397205","unresolved":false,"context_lines":[{"line_number":107,"context_line":"libraries conflicting with global requirements, but it could depend on"},{"line_number":108,"context_line":"libraries not included in the global requirements. Just as in Neutron\u0027s"},{"line_number":109,"context_line":"main requirements.txt, it will be possible to pin the version of the vendor"},{"line_number":110,"context_line":"library."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"For instance, a vendor integration module can become as simple as one that"},{"line_number":113,"context_line":"contains only the following:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_797df0b1","line":110,"in_reply_to":"3a961159_3fde8cda","updated":"2015-01-06 00:13:22.000000000","message":"I can see both sides of the argument: there may be changes that would call for a more relaxed approach and changes that do not. I\u0027d be tempted to say that we\u0027d need to vet any case individually.","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"b1e766c81aa39987f3aad91a86186488a6193749","unresolved":false,"context_lines":[{"line_number":110,"context_line":"library."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"For instance, a vendor integration module can become as simple as one that"},{"line_number":113,"context_line":"contains only the following:"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"* Registering config options"},{"line_number":116,"context_line":"* Registering the plugin class"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_eed21f33","line":113,"updated":"2015-01-02 20:47:44.000000000","message":"contains -\u003e performs","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b6bc01ef3bf020652794b94e8eaa62e503397205","unresolved":false,"context_lines":[{"line_number":110,"context_line":"library."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"For instance, a vendor integration module can become as simple as one that"},{"line_number":113,"context_line":"contains only the following:"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"* Registering config options"},{"line_number":116,"context_line":"* Registering the plugin class"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_195cec7c","line":113,"in_reply_to":"3a961159_eed21f33","updated":"2015-01-06 00:13:22.000000000","message":"Done","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e1df9e63422fcc0eeb23c1a4da7a96e00a89bbc2","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  choose what CI system they see fit to run them. There is no need or"},{"line_number":130,"context_line":"  requirement to use OpenStack CI resources if they do not want to."},{"line_number":131,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":132,"context_line":"  functional testing. 3rd Party CI is a communication mechanism. This objective"},{"line_number":133,"context_line":"  of this mechanism is as follows:"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_bfa0bc42","line":132,"updated":"2014-12-23 21:30:38.000000000","message":"What\u0027s our take for those CI setups in terms of running their jobs against stable branches? Do we expect them to track those, or master only?","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b6bc01ef3bf020652794b94e8eaa62e503397205","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  choose what CI system they see fit to run them. There is no need or"},{"line_number":130,"context_line":"  requirement to use OpenStack CI resources if they do not want to."},{"line_number":131,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":132,"context_line":"  functional testing. 3rd Party CI is a communication mechanism. This objective"},{"line_number":133,"context_line":"  of this mechanism is as follows:"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_5c3e62b9","line":132,"in_reply_to":"3a961159_aec73763","updated":"2015-01-06 00:13:22.000000000","message":"As Maru points out, the existing policy regarding 3rd party CI stands.\n\nIMO we should track stable branches too, and it should not be too much hard work. If the plugin/driver is sane at release, it\u0027s reasonable it remains so during the life of the stable branch.","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"b1e766c81aa39987f3aad91a86186488a6193749","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  choose what CI system they see fit to run them. There is no need or"},{"line_number":130,"context_line":"  requirement to use OpenStack CI resources if they do not want to."},{"line_number":131,"context_line":"* 3rd Party CI will continue to validate vendor integration with Neutron via"},{"line_number":132,"context_line":"  functional testing. 3rd Party CI is a communication mechanism. This objective"},{"line_number":133,"context_line":"  of this mechanism is as follows:"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  * it communicates to plugin/driver contributors when someone has contributed"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_aec73763","line":132,"in_reply_to":"3a961159_bfa0bc42","updated":"2015-01-02 20:47:44.000000000","message":"Good question.  What is the current policy regarding 3rd party CI requirements for stable branches?  If 3rd party CI for a a given plugin/driver is no longer stable against any given branch, what kind of actions can be taken given stability requirements?  Against master, there is the potential for removal from the tree, but that would seem untenable for stable releases.  What about a a doc-only change indicating that a plugin/driver has become effectively unsupported for a given stable release?","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e1df9e63422fcc0eeb23c1a4da7a96e00a89bbc2","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"It is the duty of the new contributor to provide working links that can be"},{"line_number":168,"context_line":"referenced from the OpenStack upstream documentation."},{"line_number":169,"context_line":"#TODO(armax): provide more info, when available."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"How-to"},{"line_number":172,"context_line":"------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_5f65181c","line":169,"updated":"2014-12-23 21:30:38.000000000","message":"note that it\u0027s not handled yet, though can be merged as-is and be followed up later.","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b6bc01ef3bf020652794b94e8eaa62e503397205","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"It is the duty of the new contributor to provide working links that can be"},{"line_number":168,"context_line":"referenced from the OpenStack upstream documentation."},{"line_number":169,"context_line":"#TODO(armax): provide more info, when available."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"How-to"},{"line_number":172,"context_line":"------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_dc87b25f","line":169,"in_reply_to":"3a961159_5f65181c","updated":"2015-01-06 00:13:22.000000000","message":"I\u0027ll do that as a follow-up","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"b1e766c81aa39987f3aad91a86186488a6193749","unresolved":false,"context_lines":[{"line_number":174,"context_line":"The how-to below assumes that the vendor library will be hosted on StackForge."},{"line_number":175,"context_line":"Stackforge lets you tap in the entire OpenStack CI infrastructure and can be"},{"line_number":176,"context_line":"a great place to start from to contribute your new or existing driver/plugin."},{"line_number":177,"context_line":"The list of steps below are somewhat the tl;td; version of what you can find"},{"line_number":178,"context_line":"on http://docs.openstack.org/infra/manual/creators.html. They are meant to"},{"line_number":179,"context_line":"be the bare minimum you have to complete in order to get you off the ground."},{"line_number":180,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_cec2c352","line":177,"updated":"2015-01-02 20:47:44.000000000","message":"tl;td; -\u003e tl;dr;","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b6bc01ef3bf020652794b94e8eaa62e503397205","unresolved":false,"context_lines":[{"line_number":174,"context_line":"The how-to below assumes that the vendor library will be hosted on StackForge."},{"line_number":175,"context_line":"Stackforge lets you tap in the entire OpenStack CI infrastructure and can be"},{"line_number":176,"context_line":"a great place to start from to contribute your new or existing driver/plugin."},{"line_number":177,"context_line":"The list of steps below are somewhat the tl;td; version of what you can find"},{"line_number":178,"context_line":"on http://docs.openstack.org/infra/manual/creators.html. They are meant to"},{"line_number":179,"context_line":"be the bare minimum you have to complete in order to get you off the ground."},{"line_number":180,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_dca092f6","line":177,"in_reply_to":"3a961159_cec2c352","updated":"2015-01-06 00:13:22.000000000","message":"Done","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"be925245a1a89d15acce4dd358952b6d5c8e4cba","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        git clone https://github.com/openstack/neutron.git"},{"line_number":203,"context_line":"        cd neutron"},{"line_number":204,"context_line":"        ./tools/split.sh [ args list ]"},{"line_number":205,"context_line":"        # Sit and wait for a while, or grab a cup of your favorite drink"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    At this point you will have the project pruned of everything else but"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_1e094e2c","line":204,"updated":"2015-01-04 22:17:17.000000000","message":"It\u0027s redundant with split.sh documentation but perhaps we should explicit what are split.sh args list.","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b6bc01ef3bf020652794b94e8eaa62e503397205","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        git clone https://github.com/openstack/neutron.git"},{"line_number":203,"context_line":"        cd neutron"},{"line_number":204,"context_line":"        ./tools/split.sh [ args list ]"},{"line_number":205,"context_line":"        # Sit and wait for a while, or grab a cup of your favorite drink"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    At this point you will have the project pruned of everything else but"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_fc78ee7f","line":204,"in_reply_to":"3a961159_1e094e2c","updated":"2015-01-06 00:13:22.000000000","message":"Done","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"be925245a1a89d15acce4dd358952b6d5c8e4cba","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        # Sit and wait for a while, or grab a cup of your favorite drink"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    At this point you will have the project pruned of everything else but"},{"line_number":208,"context_line":"    the files you want to export, with their history. The next steps are:"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"  * Add a remote that points to the repository created before."},{"line_number":211,"context_line":"  * (Optional) If the repository has already being initialized with"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_9e1c5e6c","line":208,"updated":"2015-01-04 22:17:17.000000000","message":"we should define vendor extension entry_point in vendor repo setup.cfg?","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b6bc01ef3bf020652794b94e8eaa62e503397205","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        # Sit and wait for a while, or grab a cup of your favorite drink"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    At this point you will have the project pruned of everything else but"},{"line_number":208,"context_line":"    the files you want to export, with their history. The next steps are:"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"  * Add a remote that points to the repository created before."},{"line_number":211,"context_line":"  * (Optional) If the repository has already being initialized with"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_9c136a00","line":208,"in_reply_to":"3a961159_9e1c5e6c","updated":"2015-01-06 00:13:22.000000000","message":"That\u0027s a good point, but wouldn\u0027t that be mainly a manual edit? I\u0027ll mention this down below.","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"f603007f92753280e0390e0d837248577b91f2f4","unresolved":false,"context_lines":[{"line_number":244,"context_line":"------------------------------------------"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"* Create the StackForge repo: https://review.openstack.org/#/c/136854/"},{"line_number":247,"context_line":"* TODO(armax): continue with adding meat on the bone here"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"The \u0027OVSvAPP Mechanism Driver\u0027 - example 2"},{"line_number":250,"context_line":"------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_48745236","line":247,"updated":"2014-12-27 03:08:11.000000000","message":"Note: I can add more in a followup patch here.","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b6bc01ef3bf020652794b94e8eaa62e503397205","unresolved":false,"context_lines":[{"line_number":244,"context_line":"------------------------------------------"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"* Create the StackForge repo: https://review.openstack.org/#/c/136854/"},{"line_number":247,"context_line":"* TODO(armax): continue with adding meat on the bone here"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"The \u0027OVSvAPP Mechanism Driver\u0027 - example 2"},{"line_number":250,"context_line":"------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3a961159_fc31ce59","line":247,"in_reply_to":"3a961159_48745236","updated":"2015-01-06 00:13:22.000000000","message":"sweet","commit_id":"fcd5a17aa44861c4a8d423a8e3c209ad5a24f43f"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"3fa2ae06ec4c79c672cf03e3f7397a929c775194","unresolved":false,"context_lines":[{"line_number":65,"context_line":"Development Strategy"},{"line_number":66,"context_line":"--------------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* The following elements are suggested to be contributed in the tree"},{"line_number":69,"context_line":"  for plugins and drivers (called vendor integration hereinafter):"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  * Data models"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3a961159_6f17c9a3","line":68,"updated":"2015-01-06 18:10:39.000000000","message":"nit: /are suggested/can be/\n\nIf some reviewer decides to hold patches to the standard defined here, this could lead to vendors not having the option to pull all four of these things out of tree, if desired.","commit_id":"9391526a5871d35f129ff42c33119ecc4c34e40d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"06f146aa38e737e2bfd728c12a7db1d8385d49f4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"Development Strategy"},{"line_number":66,"context_line":"--------------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* The following elements are suggested to be contributed in the tree"},{"line_number":69,"context_line":"  for plugins and drivers (called vendor integration hereinafter):"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  * Data models"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3a961159_71ac0389","line":68,"in_reply_to":"3a961159_6f17c9a3","updated":"2015-01-06 23:04:57.000000000","message":"We can further relax this in words, but in practice this is still pretty relaxed :)","commit_id":"9391526a5871d35f129ff42c33119ecc4c34e40d"}],"tools/split.sh":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e92680e0afe256ea9ba273c23274fc25c3e31e48","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Such a list can be generated with a command like this:"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# find $path -type f  # path is the base dir you want to list files for"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"set -ex"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"3a961159_e241cba9","line":18,"updated":"2014-12-16 14:14:24.000000000","message":"it\u0027s better to document where this script came from.\nfrom oslo graduation script, via split-repo effort?\nprobably credit in the commit log or this comment block?","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f26c130c14048ea30c30976fe822400b11ab38a6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Such a list can be generated with a command like this:"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# find $path -type f  # path is the base dir you want to list files for"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"set -ex"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"3a961159_e60efbe4","line":18,"in_reply_to":"3a961159_e241cba9","updated":"2014-12-16 19:54:42.000000000","message":"can do","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"13123b52da938536bb91898dc64b5263d0cf9220","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    --parent-filter \"$set_roots\" \\"},{"line_number":82,"context_line":"    --commit-filter \"$skip_empty\" \\"},{"line_number":83,"context_line":"    --tag-name-filter cat \\"},{"line_number":84,"context_line":"    -- --all"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3a961159_306e7997","line":84,"updated":"2014-12-16 19:03:02.000000000","message":"I\u0027d recommend rewriting .gitreview as the last step, as forgetting to do that leads to some confused gerrit.","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f26c130c14048ea30c30976fe822400b11ab38a6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    --parent-filter \"$set_roots\" \\"},{"line_number":82,"context_line":"    --commit-filter \"$skip_empty\" \\"},{"line_number":83,"context_line":"    --tag-name-filter cat \\"},{"line_number":84,"context_line":"    -- --all"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3a961159_26f803c4","line":84,"in_reply_to":"3a961159_306e7997","updated":"2014-12-16 19:54:42.000000000","message":"Good point, I\u0027ll whip something up!","commit_id":"95f88b8c8648963335380ff517f2bbf83fed6d59"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"95158b0bdcfa1475be9624a8de223bc15b6ec500","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    -- --all"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# Generate the new .gitreview file"},{"line_number":92,"context_line":"echo \"Generating new .gitreview file...\""},{"line_number":93,"context_line":"cat \u003e .gitreview \u003c\u003cEOF"},{"line_number":94,"context_line":"[gerrit]"},{"line_number":95,"context_line":"host\u003dreview.openstack.org"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3a961159_e20419c8","line":92,"updated":"2014-12-17 03:31:41.000000000","message":"how about: \"(This file is expected to be committed manually.)\"","commit_id":"3e0eb70f8ee662715d4ba2f9cd127edaf05bff1c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"308b29f7f6866d392b76acbfcb173863774134eb","unresolved":false,"context_lines":[{"line_number":97,"context_line":"project\u003dstackforge/${project_name}.git"},{"line_number":98,"context_line":"EOF"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"git add . \u0026\u0026 git commit -m \"Generated new .gitreview file for ${project_name}.\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"echo \"Done.\""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3a961159_f3678923","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":9},"updated":"2014-12-17 06:37:14.000000000","message":"\"git add .gitreview\" would be safer.","commit_id":"3702db61d90fed22bfcf4a8ea2ebe702d74a2cac"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"71c3f9e7a33503e1a4c44d8da4f5d698c1e6cff7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"project\u003dstackforge/${project_name}.git"},{"line_number":98,"context_line":"EOF"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"git add . \u0026\u0026 git commit -m \"Generated new .gitreview file for ${project_name}.\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"echo \"Done.\""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3a961159_867ebbad","line":100,"in_reply_to":"3a961159_aec03a2b","updated":"2014-12-19 02:27:32.000000000","message":"right.  however, at least i often have some junk files around!","commit_id":"3702db61d90fed22bfcf4a8ea2ebe702d74a2cac"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"914ff3ff9840e67f2ebd62a488c59b834f101d67","unresolved":false,"context_lines":[{"line_number":97,"context_line":"project\u003dstackforge/${project_name}.git"},{"line_number":98,"context_line":"EOF"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"git add . \u0026\u0026 git commit -m \"Generated new .gitreview file for ${project_name}.\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"echo \"Done.\""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3a961159_aec03a2b","line":100,"in_reply_to":"3a961159_f3678923","updated":"2014-12-17 07:09:53.000000000","message":"If one followed the instructions, this is really not gonna be any different, as nothing else would be unstaged, but whatever","commit_id":"3702db61d90fed22bfcf4a8ea2ebe702d74a2cac"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"3fa2ae06ec4c79c672cf03e3f7397a929c775194","unresolved":false,"context_lines":[{"line_number":26,"context_line":"file_list_path\u003d\"$1\""},{"line_number":27,"context_line":"project_name\u003d\"$2\""},{"line_number":28,"context_line":"files_to_keep\u003d$(cat $file_list_path)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# Build the grep pattern for ignoring files that we want to keep"},{"line_number":32,"context_line":"keep_pattern\u003d\"\\($(echo $files_to_keep | sed -e \u0027s/^/\\^/\u0027 -e \u0027s/ /\\\\|\\^/g\u0027)\\)\""}],"source_content_type":"text/x-sh","patch_set":12,"id":"3a961159_6fbfc9d0","line":29,"updated":"2015-01-06 18:10:39.000000000","message":"if there\u0027s another rev:\n\nif [ -z \"$file_list_path\" -o -z \"$project_name\" -o -z \"$files_to_keep\" ]; then\n  echo \"usage: `basename $0` \u003cfile-list-path\u003e \u003cproject-name\u003e\"\n  exit 1\nfi","commit_id":"9391526a5871d35f129ff42c33119ecc4c34e40d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"06f146aa38e737e2bfd728c12a7db1d8385d49f4","unresolved":false,"context_lines":[{"line_number":26,"context_line":"file_list_path\u003d\"$1\""},{"line_number":27,"context_line":"project_name\u003d\"$2\""},{"line_number":28,"context_line":"files_to_keep\u003d$(cat $file_list_path)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# Build the grep pattern for ignoring files that we want to keep"},{"line_number":32,"context_line":"keep_pattern\u003d\"\\($(echo $files_to_keep | sed -e \u0027s/^/\\^/\u0027 -e \u0027s/ /\\\\|\\^/g\u0027)\\)\""}],"source_content_type":"text/x-sh","patch_set":12,"id":"3a961159_31dd1b15","line":29,"in_reply_to":"3a961159_6fbfc9d0","updated":"2015-01-06 23:04:57.000000000","message":"Fair point, I can add this separately, as I am sure there\u0027s lots of room for UX improvement","commit_id":"9391526a5871d35f129ff42c33119ecc4c34e40d"}]}
