)]}'
{"quantum/common/config.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0229147c7ca62057043263340b0f9f0f2077ac0e","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    handler.setFormatter(formatter)"},{"line_number":120,"context_line":"    root_logger.addHandler(handler)"},{"line_number":121,"context_line":"    LOG.info(\"Service started and logging enabled!\")"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"def load_paste_app(app_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FLMo%3D","line":121,"updated":"2012-10-09 10:48:23.000000000","message":"I don\u0027t think the service has been ready (started) here.","commit_id":"b097927458f7291a1ce3794e39c2e0019a991cbb"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    handler.setFormatter(formatter)"},{"line_number":120,"context_line":"    root_logger.addHandler(handler)"},{"line_number":121,"context_line":"    LOG.info(\"Service started and logging enabled!\")"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"def load_paste_app(app_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FLLQ%3D","line":121,"in_reply_to":"AAAALH%2F%2FLMo%3D","updated":"2012-10-09 11:11:30.000000000","message":"How about \"Logging enabled\". It would be good that we have an indication that the process has started. Hence I wrote service started.\nWhat do you suggest?","commit_id":"b097927458f7291a1ce3794e39c2e0019a991cbb"}],"quantum/plugins/linuxbridge/agent/linuxbridge_quantum_agent.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0229147c7ca62057043263340b0f9f0f2077ac0e","unresolved":false,"context_lines":[{"line_number":636,"context_line":"            if devices:"},{"line_number":637,"context_line":"                mac \u003d utils.get_interface_mac(devices[0].name)"},{"line_number":638,"context_line":"            else:"},{"line_number":639,"context_line":"                LOG.error(\"Unable to obtain MAC of any device for agent_id. \""},{"line_number":640,"context_line":"                          \"Service terminating!\")"},{"line_number":641,"context_line":"                exit(1)"},{"line_number":642,"context_line":"        self.agent_id \u003d \u0027%s%s\u0027 % (\u0027lb\u0027, (mac.replace(\":\", \"\")))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FLMY%3D","line":639,"updated":"2012-10-09 10:48:23.000000000","message":"what do u mean by \u0027agent_id\u0027?","commit_id":"b097927458f7291a1ce3794e39c2e0019a991cbb"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":636,"context_line":"            if devices:"},{"line_number":637,"context_line":"                mac \u003d utils.get_interface_mac(devices[0].name)"},{"line_number":638,"context_line":"            else:"},{"line_number":639,"context_line":"                LOG.error(\"Unable to obtain MAC of any device for agent_id. \""},{"line_number":640,"context_line":"                          \"Service terminating!\")"},{"line_number":641,"context_line":"                exit(1)"},{"line_number":642,"context_line":"        self.agent_id \u003d \u0027%s%s\u0027 % (\u0027lb\u0027, (mac.replace(\":\", \"\")))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FLLM%3D","line":639,"in_reply_to":"AAAALH%2F%2FLMY%3D","updated":"2012-10-09 11:11:30.000000000","message":"The agent_id is used by the RPC. This is internal information. I\u0027ll remove it.","commit_id":"b097927458f7291a1ce3794e39c2e0019a991cbb"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0229147c7ca62057043263340b0f9f0f2077ac0e","unresolved":false,"context_lines":[{"line_number":637,"context_line":"                mac \u003d utils.get_interface_mac(devices[0].name)"},{"line_number":638,"context_line":"            else:"},{"line_number":639,"context_line":"                LOG.error(\"Unable to obtain MAC of any device for agent_id. \""},{"line_number":640,"context_line":"                          \"Service terminating!\")"},{"line_number":641,"context_line":"                exit(1)"},{"line_number":642,"context_line":"        self.agent_id \u003d \u0027%s%s\u0027 % (\u0027lb\u0027, (mac.replace(\":\", \"\")))"},{"line_number":643,"context_line":"        LOG.info(\"RPC agent_id: %s\" % self.agent_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FLMQ%3D","line":640,"updated":"2012-10-09 10:48:23.000000000","message":"Service terminating! or Service is terminated!?","commit_id":"b097927458f7291a1ce3794e39c2e0019a991cbb"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":637,"context_line":"                mac \u003d utils.get_interface_mac(devices[0].name)"},{"line_number":638,"context_line":"            else:"},{"line_number":639,"context_line":"                LOG.error(\"Unable to obtain MAC of any device for agent_id. \""},{"line_number":640,"context_line":"                          \"Service terminating!\")"},{"line_number":641,"context_line":"                exit(1)"},{"line_number":642,"context_line":"        self.agent_id \u003d \u0027%s%s\u0027 % (\u0027lb\u0027, (mac.replace(\":\", \"\")))"},{"line_number":643,"context_line":"        LOG.info(\"RPC agent_id: %s\" % self.agent_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FLLI%3D","line":640,"in_reply_to":"AAAALH%2F%2FLMQ%3D","updated":"2012-10-09 11:11:30.000000000","message":"Done","commit_id":"b097927458f7291a1ce3794e39c2e0019a991cbb"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0229147c7ca62057043263340b0f9f0f2077ac0e","unresolved":false,"context_lines":[{"line_number":802,"context_line":"                      (physical_network, physical_interface))"},{"line_number":803,"context_line":"        except ValueError as ex:"},{"line_number":804,"context_line":"            LOG.error(\"Invalid physical interface mapping: \\\u0027%s\\\u0027 - %s. \""},{"line_number":805,"context_line":"                      \"Service terminating!\" %"},{"line_number":806,"context_line":"                      (mapping, ex))"},{"line_number":807,"context_line":"            sys.exit(1)"},{"line_number":808,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FLL0%3D","line":805,"updated":"2012-10-09 10:48:23.000000000","message":"Is there need for \\ to escape the \u0027?\nalso consider the I18n these string and use keys to to replacement.","commit_id":"b097927458f7291a1ce3794e39c2e0019a991cbb"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":802,"context_line":"                      (physical_network, physical_interface))"},{"line_number":803,"context_line":"        except ValueError as ex:"},{"line_number":804,"context_line":"            LOG.error(\"Invalid physical interface mapping: \\\u0027%s\\\u0027 - %s. \""},{"line_number":805,"context_line":"                      \"Service terminating!\" %"},{"line_number":806,"context_line":"                      (mapping, ex))"},{"line_number":807,"context_line":"            sys.exit(1)"},{"line_number":808,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FLLE%3D","line":805,"in_reply_to":"AAAALH%2F%2FLL0%3D","updated":"2012-10-09 11:11:30.000000000","message":"Done","commit_id":"b097927458f7291a1ce3794e39c2e0019a991cbb"}],"quantum/plugins/linuxbridge/lb_quantum_plugin.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                            constants.TYPE_VLAN,"},{"line_number":165,"context_line":"                                            constants.TYPE_NONE]:"},{"line_number":166,"context_line":"            LOG.error(\"Invalid tenant_network_type: %s. \""},{"line_number":167,"context_line":"                      \"Service terminating!\" %"},{"line_number":168,"context_line":"                      self.tenant_network_type)"},{"line_number":169,"context_line":"            sys.exit(1)"},{"line_number":170,"context_line":"        self.agent_rpc \u003d cfg.CONF.AGENT.rpc"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FLKY%3D","line":167,"updated":"2012-10-09 11:39:22.000000000","message":"\"Service terminated!\"?","commit_id":"b08974b332f0081c826a4afd8219265f9b8d7697"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                            constants.TYPE_VLAN,"},{"line_number":165,"context_line":"                                            constants.TYPE_NONE]:"},{"line_number":166,"context_line":"            LOG.error(\"Invalid tenant_network_type: %s. \""},{"line_number":167,"context_line":"                      \"Service terminating!\" %"},{"line_number":168,"context_line":"                      self.tenant_network_type)"},{"line_number":169,"context_line":"            sys.exit(1)"},{"line_number":170,"context_line":"        self.agent_rpc \u003d cfg.CONF.AGENT.rpc"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FK6I%3D","line":167,"in_reply_to":"AAAALH%2F%2FLKY%3D","updated":"2012-10-09 16:41:16.000000000","message":"Done","commit_id":"b08974b332f0081c826a4afd8219265f9b8d7697"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":195,"context_line":"                                                 int(vlan_min),"},{"line_number":196,"context_line":"                                                 int(vlan_max))"},{"line_number":197,"context_line":"                except ValueError as ex:"},{"line_number":198,"context_line":"                    LOG.error(\"Invalid network VLAN range: \\\u0027%s\\\u0027 - %s. \""},{"line_number":199,"context_line":"                              \"Service terminating!\" %"},{"line_number":200,"context_line":"                              (entry, ex))"},{"line_number":201,"context_line":"                    sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FLKk%3D","line":198,"updated":"2012-10-09 11:39:22.000000000","message":"Backslashes before single quote are unnecesasry.","commit_id":"b08974b332f0081c826a4afd8219265f9b8d7697"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":195,"context_line":"                                                 int(vlan_min),"},{"line_number":196,"context_line":"                                                 int(vlan_max))"},{"line_number":197,"context_line":"                except ValueError as ex:"},{"line_number":198,"context_line":"                    LOG.error(\"Invalid network VLAN range: \\\u0027%s\\\u0027 - %s. \""},{"line_number":199,"context_line":"                              \"Service terminating!\" %"},{"line_number":200,"context_line":"                              (entry, ex))"},{"line_number":201,"context_line":"                    sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FK6E%3D","line":198,"in_reply_to":"AAAALH%2F%2FLKk%3D","updated":"2012-10-09 16:41:16.000000000","message":"Done","commit_id":"b08974b332f0081c826a4afd8219265f9b8d7697"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                            constants.TYPE_VLAN,"},{"line_number":165,"context_line":"                                            constants.TYPE_NONE]:"},{"line_number":166,"context_line":"            LOG.error(\"Invalid tenant_network_type: %s. \""},{"line_number":167,"context_line":"                      \"Service terminated!\" %"},{"line_number":168,"context_line":"                      self.tenant_network_type)"},{"line_number":169,"context_line":"            sys.exit(1)"},{"line_number":170,"context_line":"        self.agent_rpc \u003d cfg.CONF.AGENT.rpc"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJdk%3D","line":167,"updated":"2012-10-11 08:32:19.000000000","message":"Yes, this in in the plugin side - hence \"service\"","commit_id":"15604abab694cb1edb1df61e2f20b20adf415206"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0229147c7ca62057043263340b0f9f0f2077ac0e","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                            constants.TYPE_VLAN,"},{"line_number":165,"context_line":"                                            constants.TYPE_NONE]:"},{"line_number":166,"context_line":"            LOG.error(\"Invalid tenant_network_type: %s. \""},{"line_number":167,"context_line":"                      \"Service terminated!\" %"},{"line_number":168,"context_line":"                      self.tenant_network_type)"},{"line_number":169,"context_line":"            sys.exit(1)"},{"line_number":170,"context_line":"        self.agent_rpc \u003d cfg.CONF.AGENT.rpc"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJkE%3D","line":167,"updated":"2012-10-11 03:57:44.000000000","message":"service -\u003e agent?","commit_id":"15604abab694cb1edb1df61e2f20b20adf415206"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                            constants.TYPE_VLAN,"},{"line_number":165,"context_line":"                                            constants.TYPE_NONE]:"},{"line_number":166,"context_line":"            LOG.error(\"Invalid tenant_network_type: %s. \""},{"line_number":167,"context_line":"                      \"Service terminated!\" %"},{"line_number":168,"context_line":"                      self.tenant_network_type)"},{"line_number":169,"context_line":"            sys.exit(1)"},{"line_number":170,"context_line":"        self.agent_rpc \u003d cfg.CONF.AGENT.rpc"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJio%3D","line":167,"in_reply_to":"AAAALH%2F%2FJkE%3D","updated":"2012-10-11 04:34:33.000000000","message":"It is in the plugin logic, so \"service\" is appropriate I think.","commit_id":"15604abab694cb1edb1df61e2f20b20adf415206"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":196,"context_line":"                                                 int(vlan_max))"},{"line_number":197,"context_line":"                except ValueError as ex:"},{"line_number":198,"context_line":"                    LOG.error(\"Invalid network VLAN range: \u0027%s\u0027 - %s. \""},{"line_number":199,"context_line":"                              \"Service terminated!\" %"},{"line_number":200,"context_line":"                              (entry, ex))"},{"line_number":201,"context_line":"                    sys.exit(1)"},{"line_number":202,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJdg%3D","line":199,"updated":"2012-10-11 08:32:19.000000000","message":"Ditto","commit_id":"15604abab694cb1edb1df61e2f20b20adf415206"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0229147c7ca62057043263340b0f9f0f2077ac0e","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                                                 int(vlan_max))"},{"line_number":197,"context_line":"                except ValueError as ex:"},{"line_number":198,"context_line":"                    LOG.error(\"Invalid network VLAN range: \u0027%s\u0027 - %s. \""},{"line_number":199,"context_line":"                              \"Service terminated!\" %"},{"line_number":200,"context_line":"                              (entry, ex))"},{"line_number":201,"context_line":"                    sys.exit(1)"},{"line_number":202,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJkA%3D","line":199,"updated":"2012-10-11 03:57:44.000000000","message":"service -\u003e agent?","commit_id":"15604abab694cb1edb1df61e2f20b20adf415206"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":196,"context_line":"                                                 int(vlan_max))"},{"line_number":197,"context_line":"                except ValueError as ex:"},{"line_number":198,"context_line":"                    LOG.error(\"Invalid network VLAN range: \u0027%s\u0027 - %s. \""},{"line_number":199,"context_line":"                              \"Service terminated!\" %"},{"line_number":200,"context_line":"                              (entry, ex))"},{"line_number":201,"context_line":"                    sys.exit(1)"},{"line_number":202,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJik%3D","line":199,"in_reply_to":"AAAALH%2F%2FJkA%3D","updated":"2012-10-11 04:34:33.000000000","message":"Ditto.","commit_id":"15604abab694cb1edb1df61e2f20b20adf415206"}],"quantum/plugins/openvswitch/ovs_quantum_plugin.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":201,"context_line":"                                            constants.TYPE_GRE,"},{"line_number":202,"context_line":"                                            constants.TYPE_NONE]:"},{"line_number":203,"context_line":"            LOG.error(\"Invalid tenant_network_type: %s. \""},{"line_number":204,"context_line":"                      \"Service terminating!\","},{"line_number":205,"context_line":"                      self.tenant_network_type)"},{"line_number":206,"context_line":"            sys.exit(1)"},{"line_number":207,"context_line":"        self.enable_tunneling \u003d cfg.CONF.OVS.enable_tunneling"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FLKc%3D","line":204,"updated":"2012-10-09 11:39:22.000000000","message":"\u0027Service terminated\u0027? (It is just a symmetry for a agent)","commit_id":"b08974b332f0081c826a4afd8219265f9b8d7697"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":201,"context_line":"                                            constants.TYPE_GRE,"},{"line_number":202,"context_line":"                                            constants.TYPE_NONE]:"},{"line_number":203,"context_line":"            LOG.error(\"Invalid tenant_network_type: %s. \""},{"line_number":204,"context_line":"                      \"Service terminating!\","},{"line_number":205,"context_line":"                      self.tenant_network_type)"},{"line_number":206,"context_line":"            sys.exit(1)"},{"line_number":207,"context_line":"        self.enable_tunneling \u003d cfg.CONF.OVS.enable_tunneling"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FK54%3D","line":204,"in_reply_to":"AAAALH%2F%2FLKc%3D","updated":"2012-10-09 16:41:16.000000000","message":"Done","commit_id":"b08974b332f0081c826a4afd8219265f9b8d7697"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":241,"context_line":"                                                 int(vlan_min),"},{"line_number":242,"context_line":"                                                 int(vlan_max))"},{"line_number":243,"context_line":"                except ValueError as ex:"},{"line_number":244,"context_line":"                    LOG.error(\"Invalid network VLAN range: \\\u0027%s\\\u0027 - %s. \""},{"line_number":245,"context_line":"                              \"Service terminating!\","},{"line_number":246,"context_line":"                              entry, ex)"},{"line_number":247,"context_line":"                    sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FLKg%3D","line":244,"updated":"2012-10-09 11:39:22.000000000","message":"Backslashes before single quote are unnecesasry.","commit_id":"b08974b332f0081c826a4afd8219265f9b8d7697"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":241,"context_line":"                                                 int(vlan_min),"},{"line_number":242,"context_line":"                                                 int(vlan_max))"},{"line_number":243,"context_line":"                except ValueError as ex:"},{"line_number":244,"context_line":"                    LOG.error(\"Invalid network VLAN range: \\\u0027%s\\\u0027 - %s. \""},{"line_number":245,"context_line":"                              \"Service terminating!\","},{"line_number":246,"context_line":"                              entry, ex)"},{"line_number":247,"context_line":"                    sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FK5w%3D","line":244,"in_reply_to":"AAAALH%2F%2FLKg%3D","updated":"2012-10-09 16:41:16.000000000","message":"Done","commit_id":"b08974b332f0081c826a4afd8219265f9b8d7697"}]}