)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Quantum Security Groups API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements blueprint Quantum Security Groups API"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I2c5219ed1d44a43ce1bf03d49df9f5c1af23352b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAALH%2F%2FKQ4%3D","line":9,"updated":"2012-10-10 11:48:08.000000000","message":"\"blueprint quantum-security-groups\" is better since it is autolinked to BP on launchpad.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Quantum Security Groups API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements blueprint Quantum Security Groups API"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I2c5219ed1d44a43ce1bf03d49df9f5c1af23352b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAALH%2F%2FJ%2Bg%3D","line":9,"in_reply_to":"AAAALH%2F%2FKQ4%3D","updated":"2012-10-10 18:29:09.000000000","message":"Thanks! Done","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"}],"quantum/db/securitygroups_db.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f899865839709e116ed9b75056f7362d6600fc58","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from quantum.extensions import securitygroup as ext_sg"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class SecurityGroup(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):"},{"line_number":35,"context_line":"    \"\"\"Represents a v2 quantum security group.\"\"\""},{"line_number":36,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":37,"context_line":"    description \u003d sa.Column(sa.String(255))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKd4%3D","line":34,"updated":"2012-10-10 00:55:06.000000000","message":"Maybe we need a shared securitygroup so that other tenants can create security rules under it or use the rules in it directly.","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from quantum.extensions import securitygroup as ext_sg"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class SecurityGroup(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):"},{"line_number":35,"context_line":"    \"\"\"Represents a v2 quantum security group.\"\"\""},{"line_number":36,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":37,"context_line":"    description \u003d sa.Column(sa.String(255))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKco%3D","line":34,"in_reply_to":"AAAALH%2F%2FKd4%3D","updated":"2012-10-10 02:01:59.000000000","message":"let me ponder this, I\u0027ll reply again to this comment.","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f899865839709e116ed9b75056f7362d6600fc58","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Represents a v2 quantum security group.\"\"\""},{"line_number":36,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":37,"context_line":"    description \u003d sa.Column(sa.String(255))"},{"line_number":38,"context_line":"    external_id \u003d sa.Column(sa.Integer, unique\u003dTrue)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class SecurityGroupPortBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKeM%3D","line":38,"updated":"2012-10-10 00:55:06.000000000","message":"we have uuid, why we still need external_id?","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Represents a v2 quantum security group.\"\"\""},{"line_number":36,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":37,"context_line":"    description \u003d sa.Column(sa.String(255))"},{"line_number":38,"context_line":"    external_id \u003d sa.Column(sa.Integer, unique\u003dTrue)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class SecurityGroupPortBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKc0%3D","line":38,"in_reply_to":"AAAALH%2F%2FKeM%3D","updated":"2012-10-10 02:01:59.000000000","message":"the external_id is used so that quantum can be backwards compatible with nova security groups for the time being via a security group handler in nova. I\u0027ll upload the nova code shortly for this part.","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f899865839709e116ed9b75056f7362d6600fc58","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class SecurityGroupRule(model_base.BASEV2, models_v2.HasId,"},{"line_number":48,"context_line":"                        models_v2.HasTenant):"},{"line_number":49,"context_line":"    \"\"\"Represents a v2 quantum security group rule.\"\"\""},{"line_number":50,"context_line":"    external_id \u003d sa.Column(sa.Integer)"},{"line_number":51,"context_line":"    parent_group_id \u003d sa.Column(sa.String(36),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKd8%3D","line":48,"updated":"2012-10-10 00:55:06.000000000","message":"Do we allow tenantA has rule under teantB\u0027s group?","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f899865839709e116ed9b75056f7362d6600fc58","unresolved":false,"context_lines":[{"line_number":47,"context_line":"class SecurityGroupRule(model_base.BASEV2, models_v2.HasId,"},{"line_number":48,"context_line":"                        models_v2.HasTenant):"},{"line_number":49,"context_line":"    \"\"\"Represents a v2 quantum security group rule.\"\"\""},{"line_number":50,"context_line":"    external_id \u003d sa.Column(sa.Integer)"},{"line_number":51,"context_line":"    parent_group_id \u003d sa.Column(sa.String(36),"},{"line_number":52,"context_line":"        sa.ForeignKey(\"securitygroups.id\", ondelete\u003d\"CASCADE\"), nullable\u003dFalse)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKeI%3D","line":50,"updated":"2012-10-10 00:55:06.000000000","message":"Why we need external_id?","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f899865839709e116ed9b75056f7362d6600fc58","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                        models_v2.HasTenant):"},{"line_number":49,"context_line":"    \"\"\"Represents a v2 quantum security group rule.\"\"\""},{"line_number":50,"context_line":"    external_id \u003d sa.Column(sa.Integer)"},{"line_number":51,"context_line":"    parent_group_id \u003d sa.Column(sa.String(36),"},{"line_number":52,"context_line":"        sa.ForeignKey(\"securitygroups.id\", ondelete\u003d\"CASCADE\"), nullable\u003dFalse)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    group_id \u003d sa.Column(sa.String(36),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKeE%3D","line":51,"updated":"2012-10-10 00:55:06.000000000","message":"why parent_group_id?","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                        models_v2.HasTenant):"},{"line_number":49,"context_line":"    \"\"\"Represents a v2 quantum security group rule.\"\"\""},{"line_number":50,"context_line":"    external_id \u003d sa.Column(sa.Integer)"},{"line_number":51,"context_line":"    parent_group_id \u003d sa.Column(sa.String(36),"},{"line_number":52,"context_line":"        sa.ForeignKey(\"securitygroups.id\", ondelete\u003d\"CASCADE\"), nullable\u003dFalse)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    group_id \u003d sa.Column(sa.String(36),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKck%3D","line":51,"in_reply_to":"AAAALH%2F%2FKeE%3D","updated":"2012-10-10 02:01:59.000000000","message":"parent group id is the same as security group id. I only choose that name because nova security groups used that convention. \n\nmysql\u003e describe security_group_rules;\n\n+-----------------+--------------+------+-----+---------+----------------+\n\n| Field | Type | Null | Key | Default | Extra |\n\n+-----------------+--------------+------+-----+---------+----------------+\n\n| created_at | datetime | YES | | NULL | |\n\n| updated_at | datetime | YES | | NULL | |\n\n| deleted_at | datetime | YES | | NULL | |\n\n| deleted | tinyint(1) | YES | | NULL | |\n\n| id | int(11) | NO | PRI | NULL | auto_increment |\n\n| parent_group_id | int(11) | YES | MUL | NULL | |\n\n| protocol | varchar(255) | YES | | NULL | |\n\n| from_port | int(11) | YES | | NULL | |\n\n| to_port | int(11) | YES | | NULL | |\n\n| cidr | varchar(255) | YES | | NULL | |\n\n| group_id | int(11) | YES | MUL | NULL | | +-----------------+--------------+------+-----+---------+----------------+\n\n11 rows in set (0.00 sec)","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f899865839709e116ed9b75056f7362d6600fc58","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            nullable\u003dTrue)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    direction \u003d sa.Column(sa.Enum(\u0027ingress\u0027, \u0027egress\u0027))"},{"line_number":59,"context_line":"    ethertype \u003d sa.Column(sa.String(5))  # IPv4, IPv6"},{"line_number":60,"context_line":"    protocol \u003d sa.Column(sa.Integer)"},{"line_number":61,"context_line":"    port_range_min \u003d sa.Column(sa.Integer)"},{"line_number":62,"context_line":"    port_range_max \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKds%3D","line":59,"updated":"2012-10-10 00:55:06.000000000","message":"can we use enum here?","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            nullable\u003dTrue)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    direction \u003d sa.Column(sa.Enum(\u0027ingress\u0027, \u0027egress\u0027))"},{"line_number":59,"context_line":"    ethertype \u003d sa.Column(sa.String(5))  # IPv4, IPv6"},{"line_number":60,"context_line":"    protocol \u003d sa.Column(sa.Integer)"},{"line_number":61,"context_line":"    port_range_min \u003d sa.Column(sa.Integer)"},{"line_number":62,"context_line":"    port_range_max \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKcw%3D","line":59,"in_reply_to":"AAAALH%2F%2FKds%3D","updated":"2012-10-10 02:01:59.000000000","message":"Definitely, good call.","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Represents a v2 quantum security group.\"\"\""},{"line_number":36,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":37,"context_line":"    description \u003d sa.Column(sa.String(255))"},{"line_number":38,"context_line":"    external_id \u003d sa.Column(sa.Integer, unique\u003dTrue)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class SecurityGroupPortBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKZ0%3D","line":38,"updated":"2012-10-10 04:01:27.000000000","message":"why do we need to keep it to be compatible with nova\u0027s one? Is there any cases?","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Represents a v2 quantum security group.\"\"\""},{"line_number":36,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":37,"context_line":"    description \u003d sa.Column(sa.String(255))"},{"line_number":38,"context_line":"    external_id \u003d sa.Column(sa.Integer, unique\u003dTrue)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class SecurityGroupPortBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ%2BU%3D","line":38,"in_reply_to":"AAAALH%2F%2FKZ0%3D","updated":"2012-10-10 18:29:09.000000000","message":"This is just to help people migrate from existing deployments using nova security group rules to quantum without having to change their client.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":59,"context_line":"                         nullable\u003dTrue)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    direction \u003d sa.Column(sa.Enum(\u0027ingress\u0027, \u0027egress\u0027))"},{"line_number":62,"context_line":"    ethertype \u003d sa.Column(sa.String(5))  # IPv4, IPv6"},{"line_number":63,"context_line":"    protocol \u003d sa.Column(sa.Integer)"},{"line_number":64,"context_line":"    port_range_min \u003d sa.Column(sa.Integer)"},{"line_number":65,"context_line":"    port_range_max \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKZw%3D","line":62,"updated":"2012-10-10 04:01:27.000000000","message":"no need to use Enum here?","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                         nullable\u003dTrue)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    direction \u003d sa.Column(sa.Enum(\u0027ingress\u0027, \u0027egress\u0027))"},{"line_number":62,"context_line":"    ethertype \u003d sa.Column(sa.String(5))  # IPv4, IPv6"},{"line_number":63,"context_line":"    protocol \u003d sa.Column(sa.Integer)"},{"line_number":64,"context_line":"    port_range_min \u003d sa.Column(sa.Integer)"},{"line_number":65,"context_line":"    port_range_max \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKXQ%3D","line":62,"in_reply_to":"AAAALH%2F%2FKZw%3D","updated":"2012-10-10 18:29:09.000000000","message":"I\u0027ve changed this to sa.String(40) since IPv4/IPv6 aren\u0027t the only ethertypes. We can either change this field to a uint16 or leave it as a string.  I left it as a string so we don\u0027t need to handle the conversion from string to ethertype (and store all of those values/string names.)  This part can be handed in the plugin as I\u0027m guessing not all plugins will support all ethertypes.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        # delete security group rules then group"},{"line_number":131,"context_line":"        filters \u003d {\u0027parent_group_id\u0027: [id]}"},{"line_number":132,"context_line":"        fields \u003d {\u0027id\u0027: None}"},{"line_number":133,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":134,"context_line":"            context.session.delete(sg)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKZs%3D","line":132,"updated":"2012-10-10 04:01:27.000000000","message":"I cannot see these fields are used.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        # delete security group rules then group"},{"line_number":131,"context_line":"        filters \u003d {\u0027parent_group_id\u0027: [id]}"},{"line_number":132,"context_line":"        fields \u003d {\u0027id\u0027: None}"},{"line_number":133,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":134,"context_line":"            context.session.delete(sg)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ9I%3D","line":132,"in_reply_to":"AAAALH%2F%2FKZs%3D","updated":"2012-10-10 18:29:09.000000000","message":"Done","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":153,"context_line":"                                          sgid\u003dsgid)"},{"line_number":154,"context_line":"            context.session.add(db)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def get_port_securitygroup_binding(self, context,"},{"line_number":157,"context_line":"                                       filters\u003dNone, fields\u003dNone):"},{"line_number":158,"context_line":"        return self._get_collection(context, SecurityGroupPortBinding,"},{"line_number":159,"context_line":"                                    self._make_securitygroup_binding_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKNY%3D","line":156,"updated":"2012-10-10 11:48:08.000000000","message":"This methods returns a list of security group bindings for the port. Is it better to change the method name to *_bindings()?","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                                          sgid\u003dsgid)"},{"line_number":154,"context_line":"            context.session.add(db)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def get_port_securitygroup_binding(self, context,"},{"line_number":157,"context_line":"                                       filters\u003dNone, fields\u003dNone):"},{"line_number":158,"context_line":"        return self._get_collection(context, SecurityGroupPortBinding,"},{"line_number":159,"context_line":"                                    self._make_securitygroup_binding_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ9A%3D","line":156,"in_reply_to":"AAAALH%2F%2FKNY%3D","updated":"2012-10-10 18:29:09.000000000","message":"Done","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":159,"context_line":"                                    self._make_securitygroup_binding_dict,"},{"line_number":160,"context_line":"                                    filters\u003dfilters, fields\u003dfields)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def delete_port_securitygroup_binding(self, context, port_id):"},{"line_number":163,"context_line":"        query \u003d self._model_query(context, SecurityGroupPortBinding)"},{"line_number":164,"context_line":"        bindings \u003d query.filter("},{"line_number":165,"context_line":"            SecurityGroupPortBinding.port_id \u003d\u003d port_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKNc%3D","line":162,"updated":"2012-10-10 11:48:08.000000000","message":"This methods can delete multiple sg association for the port.\nIs it better to change the method name to *_bindings()?","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                                    self._make_securitygroup_binding_dict,"},{"line_number":160,"context_line":"                                    filters\u003dfilters, fields\u003dfields)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def delete_port_securitygroup_binding(self, context, port_id):"},{"line_number":163,"context_line":"        query \u003d self._model_query(context, SecurityGroupPortBinding)"},{"line_number":164,"context_line":"        bindings \u003d query.filter("},{"line_number":165,"context_line":"            SecurityGroupPortBinding.port_id \u003d\u003d port_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ9E%3D","line":162,"in_reply_to":"AAAALH%2F%2FKNc%3D","updated":"2012-10-10 18:29:09.000000000","message":"Done","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":195,"context_line":"                                       port_range_min\u003drule[\u0027port_range_min\u0027],"},{"line_number":196,"context_line":"                                       port_range_max\u003drule[\u0027port_range_max\u0027],"},{"line_number":197,"context_line":"                                       ip_prefix\u003drule.get(\u0027ip_prefix\u0027))"},{"line_number":198,"context_line":"                context.session.add(db)"},{"line_number":199,"context_line":"            ret.append(self._make_security_group_rule_dict(db))"},{"line_number":200,"context_line":"        return ret"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKZc%3D","line":198,"updated":"2012-10-10 04:01:27.000000000","message":"try to imagine the scenario:\n\nthread 1 create a security rule A, the control flow passed the self._check_for_duplicate_rules(context, r),\n\nthread 2 create a same security rule A, and  the control flow passed the self._check_for_duplicate_rules(context, r),\n\nand the run parallel, what will happen? Are these two duplicated rules inserted into DB?","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                                       port_range_min\u003drule[\u0027port_range_min\u0027],"},{"line_number":196,"context_line":"                                       port_range_max\u003drule[\u0027port_range_max\u0027],"},{"line_number":197,"context_line":"                                       ip_prefix\u003drule.get(\u0027ip_prefix\u0027))"},{"line_number":198,"context_line":"                context.session.add(db)"},{"line_number":199,"context_line":"            ret.append(self._make_security_group_rule_dict(db))"},{"line_number":200,"context_line":"        return ret"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ8Y%3D","line":198,"in_reply_to":"AAAALH%2F%2FKZc%3D","updated":"2012-10-10 18:29:09.000000000","message":"Good call, make session scoped_session()","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":306,"context_line":"            port[ext_sg.EXTERNAL].append(sgid[\u0027sgid\u0027])"},{"line_number":307,"context_line":"        return port"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def _process_port_create_securitygroup(self, context, port_id, sgids):"},{"line_number":310,"context_line":"        if not sgids:"},{"line_number":311,"context_line":"            return"},{"line_number":312,"context_line":"        for sgid in sgids:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKNg%3D","line":309,"updated":"2012-10-10 11:48:08.000000000","message":"What is the difference between function names starting with _ and without _?\n\ncreate_port_securitygroup_binding() has a name starting w/o _, but it is just an internal method. _process_port_create_securitygroup() has a name starting with _, but it is called in NVP plugin.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            port[ext_sg.EXTERNAL].append(sgid[\u0027sgid\u0027])"},{"line_number":307,"context_line":"        return port"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def _process_port_create_securitygroup(self, context, port_id, sgids):"},{"line_number":310,"context_line":"        if not sgids:"},{"line_number":311,"context_line":"            return"},{"line_number":312,"context_line":"        for sgid in sgids:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ8U%3D","line":309,"in_reply_to":"AAAALH%2F%2FKNg%3D","updated":"2012-10-10 18:29:09.000000000","message":"Added _ to create/delete _port_securitygroup_binding().","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    direction \u003d sa.Column(sa.Enum(\u0027ingress\u0027, \u0027egress\u0027))"},{"line_number":63,"context_line":"    ethertype \u003d sa.Column(sa.String(40))"},{"line_number":64,"context_line":"    protocol \u003d sa.Column(sa.Integer)"},{"line_number":65,"context_line":"    port_range_min \u003d sa.Column(sa.Integer)"},{"line_number":66,"context_line":"    port_range_max \u003d sa.Column(sa.Integer)"},{"line_number":67,"context_line":"    ip_prefix \u003d sa.Column(sa.String(255))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FJfY%3D","line":64,"updated":"2012-10-11 07:04:41.000000000","message":"In the attribute map, there is no conversion to integer. Do we need to change it to sa.String?","commit_id":"e22be84d9717ff202de4abcd32ee737d866a336e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    direction \u003d sa.Column(sa.Enum(\u0027ingress\u0027, \u0027egress\u0027))"},{"line_number":63,"context_line":"    ethertype \u003d sa.Column(sa.String(40))"},{"line_number":64,"context_line":"    protocol \u003d sa.Column(sa.Integer)"},{"line_number":65,"context_line":"    port_range_min \u003d sa.Column(sa.Integer)"},{"line_number":66,"context_line":"    port_range_max \u003d sa.Column(sa.Integer)"},{"line_number":67,"context_line":"    ip_prefix \u003d sa.Column(sa.String(255))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FJe8%3D","line":64,"in_reply_to":"AAAALH%2F%2FJfY%3D","updated":"2012-10-11 07:13:53.000000000","message":"Done","commit_id":"e22be84d9717ff202de4abcd32ee737d866a336e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":151,"context_line":"                                          sgid\u003dsgid)"},{"line_number":152,"context_line":"            context.session.add(db)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def get_port_securitygroup_bindings(self, context,"},{"line_number":155,"context_line":"                                        filters\u003dNone, fields\u003dNone):"},{"line_number":156,"context_line":"        return self._get_collection(context, SecurityGroupPortBinding,"},{"line_number":157,"context_line":"                                    self._make_securitygroup_binding_dict,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FJfc%3D","line":154,"updated":"2012-10-11 07:04:41.000000000","message":"It is \u0027protected\u0027 method. A method name of other protected method starts with \u0027_\u0027.\n\nActually, I am wondering what is the good way to distinguish protected and private methods. In L3 and SG mixin some methods are used in a plugin class. It is important to clarify which methods are exposed to subclasses to keep code maintenance easier. Any idea?","commit_id":"e22be84d9717ff202de4abcd32ee737d866a336e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                                          sgid\u003dsgid)"},{"line_number":152,"context_line":"            context.session.add(db)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def get_port_securitygroup_bindings(self, context,"},{"line_number":155,"context_line":"                                        filters\u003dNone, fields\u003dNone):"},{"line_number":156,"context_line":"        return self._get_collection(context, SecurityGroupPortBinding,"},{"line_number":157,"context_line":"                                    self._make_securitygroup_binding_dict,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FJe4%3D","line":154,"in_reply_to":"AAAALH%2F%2FJfc%3D","updated":"2012-10-11 07:13:53.000000000","message":"I agree. I think the _ is the right approach, added _","commit_id":"e22be84d9717ff202de4abcd32ee737d866a336e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"class SecurityGroupPortBinding(model_base.BASEV2):"},{"line_number":43,"context_line":"    \"\"\"Represents binding between quantum ports and security profiles\"\"\""},{"line_number":44,"context_line":"    port_id \u003d sa.Column(sa.String(36), primary_key\u003dTrue)"},{"line_number":45,"context_line":"    sgid \u003d sa.Column(sa.String(36), primary_key\u003dTrue)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class SecurityGroupRule(model_base.BASEV2, models_v2.HasId,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJZA%3D","line":45,"updated":"2012-10-11 14:20:17.000000000","message":"maybe we should be consistent with other names and have an underscore","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"class SecurityGroupPortBinding(model_base.BASEV2):"},{"line_number":43,"context_line":"    \"\"\"Represents binding between quantum ports and security profiles\"\"\""},{"line_number":44,"context_line":"    port_id \u003d sa.Column(sa.String(36), primary_key\u003dTrue)"},{"line_number":45,"context_line":"    sgid \u003d sa.Column(sa.String(36), primary_key\u003dTrue)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class SecurityGroupRule(model_base.BASEV2, models_v2.HasId,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJOw%3D","line":45,"in_reply_to":"AAAALH%2F%2FJZA%3D","updated":"2012-10-12 05:33:07.000000000","message":"Done","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"unresolved":false,"context_lines":[{"line_number":49,"context_line":"                        models_v2.HasTenant):"},{"line_number":50,"context_line":"    \"\"\"Represents a v2 quantum security group rule.\"\"\""},{"line_number":51,"context_line":"    external_id \u003d sa.Column(sa.Integer)"},{"line_number":52,"context_line":"    parent_group_id \u003d sa.Column(sa.String(36),"},{"line_number":53,"context_line":"                                sa.ForeignKey(\"securitygroups.id\","},{"line_number":54,"context_line":"                                              ondelete\u003d\"CASCADE\"),"},{"line_number":55,"context_line":"                                nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJZ0%3D","line":52,"updated":"2012-10-11 13:48:32.000000000","message":"see my comments on RESOURCE_ATTRIBUTE_MAP in quantum/extensions/securitygroup.py","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                        models_v2.HasTenant):"},{"line_number":50,"context_line":"    \"\"\"Represents a v2 quantum security group rule.\"\"\""},{"line_number":51,"context_line":"    external_id \u003d sa.Column(sa.Integer)"},{"line_number":52,"context_line":"    parent_group_id \u003d sa.Column(sa.String(36),"},{"line_number":53,"context_line":"                                sa.ForeignKey(\"securitygroups.id\","},{"line_number":54,"context_line":"                                              ondelete\u003d\"CASCADE\"),"},{"line_number":55,"context_line":"                                nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJMg%3D","line":52,"in_reply_to":"AAAALH%2F%2FJZ0%3D","updated":"2012-10-12 05:33:07.000000000","message":"Done","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":60,"context_line":"                         nullable\u003dTrue)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    direction \u003d sa.Column(sa.Enum(\u0027ingress\u0027, \u0027egress\u0027))"},{"line_number":63,"context_line":"    ethertype \u003d sa.Column(sa.String(40))"},{"line_number":64,"context_line":"    protocol \u003d sa.Column(sa.String(40))"},{"line_number":65,"context_line":"    port_range_min \u003d sa.Column(sa.Integer)"},{"line_number":66,"context_line":"    port_range_max \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJY8%3D","line":63,"updated":"2012-10-11 14:20:17.000000000","message":"does this need to be a string?","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                         nullable\u003dTrue)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    direction \u003d sa.Column(sa.Enum(\u0027ingress\u0027, \u0027egress\u0027))"},{"line_number":63,"context_line":"    ethertype \u003d sa.Column(sa.String(40))"},{"line_number":64,"context_line":"    protocol \u003d sa.Column(sa.String(40))"},{"line_number":65,"context_line":"    port_range_min \u003d sa.Column(sa.Integer)"},{"line_number":66,"context_line":"    port_range_max \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJMc%3D","line":63,"in_reply_to":"AAAALH%2F%2FJY8%3D","updated":"2012-10-12 05:33:07.000000000","message":"If we make this a string we don\u0027t need to store a mapping to their int values to convert. Nova also uses a string for this.","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    direction \u003d sa.Column(sa.Enum(\u0027ingress\u0027, \u0027egress\u0027))"},{"line_number":63,"context_line":"    ethertype \u003d sa.Column(sa.String(40))"},{"line_number":64,"context_line":"    protocol \u003d sa.Column(sa.String(40))"},{"line_number":65,"context_line":"    port_range_min \u003d sa.Column(sa.Integer)"},{"line_number":66,"context_line":"    port_range_max \u003d sa.Column(sa.Integer)"},{"line_number":67,"context_line":"    ip_prefix \u003d sa.Column(sa.String(255))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJY4%3D","line":64,"updated":"2012-10-11 14:20:17.000000000","message":"ditto","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    direction \u003d sa.Column(sa.Enum(\u0027ingress\u0027, \u0027egress\u0027))"},{"line_number":63,"context_line":"    ethertype \u003d sa.Column(sa.String(40))"},{"line_number":64,"context_line":"    protocol \u003d sa.Column(sa.String(40))"},{"line_number":65,"context_line":"    port_range_min \u003d sa.Column(sa.Integer)"},{"line_number":66,"context_line":"    port_range_max \u003d sa.Column(sa.Integer)"},{"line_number":67,"context_line":"    ip_prefix \u003d sa.Column(sa.String(255))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJMU%3D","line":64,"updated":"2012-10-12 05:33:07.000000000","message":"same as above.","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def create_securitygroup(self, context, securitygroup, default_sg\u003dFalse):"},{"line_number":79,"context_line":"        \"\"\"Create security group."},{"line_number":80,"context_line":"        if default_sg is true that means a we are creating a default security"},{"line_number":81,"context_line":"        group and we don\u0027t need to check if one exists."},{"line_number":82,"context_line":"        \"\"\""},{"line_number":83,"context_line":"        s \u003d securitygroup[\u0027securitygroup\u0027]"},{"line_number":84,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, s)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJeM%3D","line":81,"updated":"2012-10-11 08:09:14.000000000","message":"How about something like \"If default_sg is true that means we are a default security group for a given tenant if it does not exist.\"?","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def create_securitygroup(self, context, securitygroup, default_sg\u003dFalse):"},{"line_number":79,"context_line":"        \"\"\"Create security group."},{"line_number":80,"context_line":"        if default_sg is true that means a we are creating a default security"},{"line_number":81,"context_line":"        group and we don\u0027t need to check if one exists."},{"line_number":82,"context_line":"        \"\"\""},{"line_number":83,"context_line":"        s \u003d securitygroup[\u0027securitygroup\u0027]"},{"line_number":84,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, s)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJd4%3D","line":81,"in_reply_to":"AAAALH%2F%2FJeM%3D","updated":"2012-10-11 08:14:20.000000000","message":"Sure","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if not default_sg:"},{"line_number":86,"context_line":"            self._ensure_default_securitygroup(context, tenant_id,"},{"line_number":87,"context_line":"                                               securitygroup)"},{"line_number":88,"context_line":"        if s.get(\u0027external_id\u0027) is not None:"},{"line_number":89,"context_line":"            try:"},{"line_number":90,"context_line":"                # Check if security group already exists"},{"line_number":91,"context_line":"                sg \u003d self.get_securitygroup(context, s.get(\u0027external_id\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJY0%3D","line":88,"updated":"2012-10-11 14:20:17.000000000","message":"Does if s.get(\u0027external_id\u0027): work?","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if not default_sg:"},{"line_number":86,"context_line":"            self._ensure_default_securitygroup(context, tenant_id,"},{"line_number":87,"context_line":"                                               securitygroup)"},{"line_number":88,"context_line":"        if s.get(\u0027external_id\u0027) is not None:"},{"line_number":89,"context_line":"            try:"},{"line_number":90,"context_line":"                # Check if security group already exists"},{"line_number":91,"context_line":"                sg \u003d self.get_securitygroup(context, s.get(\u0027external_id\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJMM%3D","line":88,"in_reply_to":"AAAALH%2F%2FJY0%3D","updated":"2012-10-12 05:33:07.000000000","message":"Done","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":348,"context_line":"            return"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        # TODO Optimize, query all at once so we don\u0027t need to query"},{"line_number":351,"context_line":"        # db multiple times."},{"line_number":352,"context_line":"        for i in range(0, len(p[ext_sg.SECURITYGROUP])):"},{"line_number":353,"context_line":"            securitygroup \u003d self.get_securitygroup("},{"line_number":354,"context_line":"                context, p[ext_sg.SECURITYGROUP][i])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJeA%3D","line":351,"updated":"2012-10-11 08:09:14.000000000","message":"The followinng logic queries db once. Is it what you want?\n\navail_sg_set \u003d set(list_securitygroup(the tenant for the port))\nreq_sg_set \u003d set(p[ext_sg.SECURITYGROUP])\nif not req_sg_set.issubnet(avail_sg_set):\n  raise ext_sg.SecurityGroupNotFound(..)","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            return"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        # TODO Optimize, query all at once so we don\u0027t need to query"},{"line_number":351,"context_line":"        # db multiple times."},{"line_number":352,"context_line":"        for i in range(0, len(p[ext_sg.SECURITYGROUP])):"},{"line_number":353,"context_line":"            securitygroup \u003d self.get_securitygroup("},{"line_number":354,"context_line":"                context, p[ext_sg.SECURITYGROUP][i])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJd0%3D","line":351,"in_reply_to":"AAAALH%2F%2FJeA%3D","updated":"2012-10-11 08:14:20.000000000","message":"Yup thanks :)","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"\"\"\""},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright 2012 Nicira Networks, Inc.  All rights reserved."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Fec%3D","line":1,"updated":"2012-10-22 22:50:10.000000000","message":"Why is the license formatted as a docstring?","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\"\"\""},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright 2012 Nicira Networks, Inc.  All rights reserved."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FW0%3D","line":1,"in_reply_to":"AAAALn%2F%2F%2Fec%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from sqlalchemy.orm import exc"},{"line_number":26,"context_line":"from sqlalchemy.orm import scoped_session"},{"line_number":27,"context_line":"import sqlalchemy as sa"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from quantum.api.v2 import attributes"},{"line_number":30,"context_line":"from quantum.common import utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FeY%3D","line":27,"updated":"2012-10-22 22:50:10.000000000","message":"HACKING - Import ordering","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from sqlalchemy.orm import exc"},{"line_number":26,"context_line":"from sqlalchemy.orm import scoped_session"},{"line_number":27,"context_line":"import sqlalchemy as sa"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from quantum.api.v2 import attributes"},{"line_number":30,"context_line":"from quantum.common import utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FCk%3D","line":27,"in_reply_to":"AAAALn%2F%2F%2FKo%3D","updated":"2012-10-23 11:31:23.000000000","message":"You are right I stand corrected","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from sqlalchemy.orm import exc"},{"line_number":26,"context_line":"from sqlalchemy.orm import scoped_session"},{"line_number":27,"context_line":"import sqlalchemy as sa"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from quantum.api.v2 import attributes"},{"line_number":30,"context_line":"from quantum.common import utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FKo%3D","line":27,"in_reply_to":"AAAALn%2F%2F%2FPU%3D","updated":"2012-10-23 05:59:59.000000000","message":"sqlalchemy \u003c sqlalchemy.orm - the chosen alias is not included for sorting purposes, only the absolute module path.","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from sqlalchemy.orm import exc"},{"line_number":26,"context_line":"from sqlalchemy.orm import scoped_session"},{"line_number":27,"context_line":"import sqlalchemy as sa"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from quantum.api.v2 import attributes"},{"line_number":30,"context_line":"from quantum.common import utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FPU%3D","line":27,"in_reply_to":"AAAALn%2F%2F%2FeY%3D","updated":"2012-10-23 02:15:31.000000000","message":"I think this is already ordered properly.\n\n sqlalchemy.orm.exc\n sqlalchemy.orm.sco\n sqlalchemy.sa","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from sqlalchemy.orm import exc"},{"line_number":26,"context_line":"from sqlalchemy.orm import scoped_session"},{"line_number":27,"context_line":"import sqlalchemy as sa"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from quantum.api.v2 import attributes"},{"line_number":30,"context_line":"from quantum.common import utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FTM%3D","line":27,"in_reply_to":"AAAALn%2F%2F%2FeY%3D","updated":"2012-10-23 20:59:27.000000000","message":"Maru is right I had sorted this with the from/import first.","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":68,"context_line":"    source_ip_prefix \u003d sa.Column(sa.String(255))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class SecurityGroup_db_mixin(ext_sg.SecurityGroupPluginBase):"},{"line_number":72,"context_line":"    \"\"\"Mixin class to add security group to db_plugin_base_v2.\"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    __native_bulk_support \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Fd8%3D","line":71,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) Consider following PEP8 for class name (SecuityGroupDbMixin).","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    source_ip_prefix \u003d sa.Column(sa.String(255))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class SecurityGroup_db_mixin(ext_sg.SecurityGroupPluginBase):"},{"line_number":72,"context_line":"    \"\"\"Mixin class to add security group to db_plugin_base_v2.\"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    __native_bulk_support \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FNE%3D","line":71,"in_reply_to":"AAAALn%2F%2F%2Fd8%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":71,"context_line":"class SecurityGroup_db_mixin(ext_sg.SecurityGroupPluginBase):"},{"line_number":72,"context_line":"    \"\"\"Mixin class to add security group to db_plugin_base_v2.\"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    __native_bulk_support \u003d True"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def create_securitygroup_bulk(self, context, securitygrouprule):"},{"line_number":77,"context_line":"        return self._create_bulk(\u0027securitygroup\u0027, context, securitygrouprule)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Fdk%3D","line":74,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) The general convention for private variables includes trailing double-underscores (__native_bulk_support__)","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":71,"context_line":"class SecurityGroup_db_mixin(ext_sg.SecurityGroupPluginBase):"},{"line_number":72,"context_line":"    \"\"\"Mixin class to add security group to db_plugin_base_v2.\"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    __native_bulk_support \u003d True"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def create_securitygroup_bulk(self, context, securitygrouprule):"},{"line_number":77,"context_line":"        return self._create_bulk(\u0027securitygroup\u0027, context, securitygrouprule)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FTA%3D","line":74,"in_reply_to":"AAAALn%2F%2F%2Fdk%3D","updated":"2012-10-23 20:59:27.000000000","message":"FYI: This is used in the API to determine if a plugin supports bulk or not via the __native_bulk_support variable.  https://github.com/openstack/quantum/blob/master/quantum/api/v2/base.py#L125","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    __native_bulk_support \u003d True"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def create_securitygroup_bulk(self, context, securitygrouprule):"},{"line_number":77,"context_line":"        return self._create_bulk(\u0027securitygroup\u0027, context, securitygrouprule)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def create_securitygroup(self, context, securitygroup, default_sg\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Fds%3D","line":76,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) Consider following PEP8 conventions for:\n\n - method name (securitygroup \u003d\u003e security_group)\n - parameter name (securitygrouprule \u003d\u003e security_group_rule)\n\nIs there a reason for not using underscore separation?","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    __native_bulk_support \u003d True"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def create_securitygroup_bulk(self, context, securitygrouprule):"},{"line_number":77,"context_line":"        return self._create_bulk(\u0027securitygroup\u0027, context, securitygrouprule)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def create_securitygroup(self, context, securitygroup, default_sg\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FM0%3D","line":76,"in_reply_to":"AAAALn%2F%2F%2Fds%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def create_securitygroup(self, context, securitygroup, default_sg\u003dFalse):"},{"line_number":80,"context_line":"        \"\"\"Create security group."},{"line_number":81,"context_line":"        If default_sg is true that means we are a default security group for"},{"line_number":82,"context_line":"        a given tenant if it does not exist."},{"line_number":83,"context_line":"        \"\"\""},{"line_number":84,"context_line":"        s \u003d securitygroup[\u0027securitygroup\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FdU%3D","line":81,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) Consider following sphinx formatting convention for parameter documentation.","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                    filters\u003dfilters, fields\u003dfields)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_securitygroup(self, context, id, fields\u003dNone, tenant_id\u003dNone):"},{"line_number":116,"context_line":"        \"\"\"Tenant id is given to handle the case when we"},{"line_number":117,"context_line":"        are creating a securitygroup or securitygrouprules on behalf of"},{"line_number":118,"context_line":"        another use.\"\"\""},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FdM%3D","line":116,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) Consider following HACKING convention for docstring formatting.","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                    filters\u003dfilters, fields\u003dfields)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_securitygroup(self, context, id, fields\u003dNone, tenant_id\u003dNone):"},{"line_number":116,"context_line":"        \"\"\"Tenant id is given to handle the case when we"},{"line_number":117,"context_line":"        are creating a securitygroup or securitygrouprules on behalf of"},{"line_number":118,"context_line":"        another use.\"\"\""},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FMw%3D","line":116,"in_reply_to":"AAAALn%2F%2F%2FdM%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":121,"context_line":"            tmp_context_tenant_id \u003d context.tenant_id"},{"line_number":122,"context_line":"            context.tenant_id \u003d tenant_id"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        ret \u003d self._make_security_group_dict(self._get_securitygroup("},{"line_number":125,"context_line":"            context, id), fields)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        if tenant_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Fc4%3D","line":124,"updated":"2012-10-22 22:50:10.000000000","message":"Please wrap this line in a try/finally clause to ensure that the context.tenant_id is reset in the finally block (if necessary) in the event of any exception being raised in the call to _make_security_group_dict.\n\n(Suggestion only) PEP8 vertical alignment - the second line should be aligned with the first bracket if parameters appear on the first line.","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            tmp_context_tenant_id \u003d context.tenant_id"},{"line_number":122,"context_line":"            context.tenant_id \u003d tenant_id"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        ret \u003d self._make_security_group_dict(self._get_securitygroup("},{"line_number":125,"context_line":"            context, id), fields)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        if tenant_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FMg%3D","line":124,"in_reply_to":"AAAALn%2F%2F%2Fc4%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":233,"context_line":"        tenant_ids \u003d Set()"},{"line_number":234,"context_line":"        for rules in securitygrouprule[\u0027securitygrouprules\u0027]:"},{"line_number":235,"context_line":"            rule \u003d rules.get(\u0027securitygrouprule\u0027)"},{"line_number":236,"context_line":"            if rule[\u0027security_group_id\u0027] not in new_rules:"},{"line_number":237,"context_line":"                new_rules[rule[\u0027security_group_id\u0027]] \u003d []"},{"line_number":238,"context_line":"            new_rules[rule[\u0027security_group_id\u0027]].append(rule)"},{"line_number":239,"context_line":"            if rule[\u0027tenant_id\u0027] not in tenant_ids:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FcM%3D","line":236,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) Consider using setdefault instead:\n\nnew_rules.setdefault(rule[\u0027security_group_id\u0027], [])","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":233,"context_line":"        tenant_ids \u003d Set()"},{"line_number":234,"context_line":"        for rules in securitygrouprule[\u0027securitygrouprules\u0027]:"},{"line_number":235,"context_line":"            rule \u003d rules.get(\u0027securitygrouprule\u0027)"},{"line_number":236,"context_line":"            if rule[\u0027security_group_id\u0027] not in new_rules:"},{"line_number":237,"context_line":"                new_rules[rule[\u0027security_group_id\u0027]] \u003d []"},{"line_number":238,"context_line":"            new_rules[rule[\u0027security_group_id\u0027]].append(rule)"},{"line_number":239,"context_line":"            if rule[\u0027tenant_id\u0027] not in tenant_ids:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FCc%3D","line":236,"in_reply_to":"AAAALn%2F%2F%2FKk%3D","updated":"2012-10-23 11:31:23.000000000","message":"Maybe it is personal preference. I don\u0027t see how it gets more clearer with two lines.","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":233,"context_line":"        tenant_ids \u003d Set()"},{"line_number":234,"context_line":"        for rules in securitygrouprule[\u0027securitygrouprules\u0027]:"},{"line_number":235,"context_line":"            rule \u003d rules.get(\u0027securitygrouprule\u0027)"},{"line_number":236,"context_line":"            if rule[\u0027security_group_id\u0027] not in new_rules:"},{"line_number":237,"context_line":"                new_rules[rule[\u0027security_group_id\u0027]] \u003d []"},{"line_number":238,"context_line":"            new_rules[rule[\u0027security_group_id\u0027]].append(rule)"},{"line_number":239,"context_line":"            if rule[\u0027tenant_id\u0027] not in tenant_ids:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FKk%3D","line":236,"in_reply_to":"AAAALn%2F%2F%2FO4%3D","updated":"2012-10-23 05:59:59.000000000","message":"It is generally preferable (for the sake of clarity) to limit the functional scope of a line to a single logical operation.  There is no reason to combine setting the default and adding the new rule.","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        tenant_ids \u003d Set()"},{"line_number":234,"context_line":"        for rules in securitygrouprule[\u0027securitygrouprules\u0027]:"},{"line_number":235,"context_line":"            rule \u003d rules.get(\u0027securitygrouprule\u0027)"},{"line_number":236,"context_line":"            if rule[\u0027security_group_id\u0027] not in new_rules:"},{"line_number":237,"context_line":"                new_rules[rule[\u0027security_group_id\u0027]] \u003d []"},{"line_number":238,"context_line":"            new_rules[rule[\u0027security_group_id\u0027]].append(rule)"},{"line_number":239,"context_line":"            if rule[\u0027tenant_id\u0027] not in tenant_ids:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FMc%3D","line":236,"in_reply_to":"AAAALn%2F%2F%2FO4%3D","updated":"2012-10-23 20:59:27.000000000","message":"cool thanks!","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":233,"context_line":"        tenant_ids \u003d Set()"},{"line_number":234,"context_line":"        for rules in securitygrouprule[\u0027securitygrouprules\u0027]:"},{"line_number":235,"context_line":"            rule \u003d rules.get(\u0027securitygrouprule\u0027)"},{"line_number":236,"context_line":"            if rule[\u0027security_group_id\u0027] not in new_rules:"},{"line_number":237,"context_line":"                new_rules[rule[\u0027security_group_id\u0027]] \u003d []"},{"line_number":238,"context_line":"            new_rules[rule[\u0027security_group_id\u0027]].append(rule)"},{"line_number":239,"context_line":"            if rule[\u0027tenant_id\u0027] not in tenant_ids:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FO4%3D","line":236,"in_reply_to":"AAAALn%2F%2F%2FcM%3D","updated":"2012-10-23 02:15:31.000000000","message":"I agree with Maru\n\n if rule[\u0027security_group_id\u0027] not in new_rules:\n     new_rules[rule[\u0027security_group_id\u0027]] \u003d []\n new_rules[rule[\u0027security_group_id\u0027]].append(rule)\n\nThese lines could be expressed in one line as below:\n\n new_rules.setdefault(rule[\u0027security_group_id\u0027], []).append(rule)","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":240,"context_line":"                tenant_ids.add(rule[\u0027tenant_id\u0027])"},{"line_number":241,"context_line":"            source_group_id \u003d rule.get(\u0027source_group_id\u0027)"},{"line_number":242,"context_line":"            if source_group_id:"},{"line_number":243,"context_line":"                    self.get_securitygroup(context, source_group_id,"},{"line_number":244,"context_line":"                                           tenant_id\u003drule[\u0027tenant_id\u0027])"},{"line_number":245,"context_line":"        if len(new_rules.keys()) \u003e 1:"},{"line_number":246,"context_line":"            raise ext_sg.SecurityGroupNotSingleGroupRules()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FcI%3D","line":243,"updated":"2012-10-22 22:50:10.000000000","message":"PEP8 vertical alignment","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                tenant_ids.add(rule[\u0027tenant_id\u0027])"},{"line_number":241,"context_line":"            source_group_id \u003d rule.get(\u0027source_group_id\u0027)"},{"line_number":242,"context_line":"            if source_group_id:"},{"line_number":243,"context_line":"                    self.get_securitygroup(context, source_group_id,"},{"line_number":244,"context_line":"                                           tenant_id\u003drule[\u0027tenant_id\u0027])"},{"line_number":245,"context_line":"        if len(new_rules.keys()) \u003e 1:"},{"line_number":246,"context_line":"            raise ext_sg.SecurityGroupNotSingleGroupRules()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FMY%3D","line":243,"in_reply_to":"AAAALn%2F%2F%2FcI%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":242,"context_line":"            if source_group_id:"},{"line_number":243,"context_line":"                    self.get_securitygroup(context, source_group_id,"},{"line_number":244,"context_line":"                                           tenant_id\u003drule[\u0027tenant_id\u0027])"},{"line_number":245,"context_line":"        if len(new_rules.keys()) \u003e 1:"},{"line_number":246,"context_line":"            raise ext_sg.SecurityGroupNotSingleGroupRules()"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # Confirm that the tenant has permission to add rules"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FcA%3D","line":245,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) Consider simplifying (len(new_rules) \u003d\u003d len(new_rules.keys()))","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            if source_group_id:"},{"line_number":243,"context_line":"                    self.get_securitygroup(context, source_group_id,"},{"line_number":244,"context_line":"                                           tenant_id\u003drule[\u0027tenant_id\u0027])"},{"line_number":245,"context_line":"        if len(new_rules.keys()) \u003e 1:"},{"line_number":246,"context_line":"            raise ext_sg.SecurityGroupNotSingleGroupRules()"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # Confirm that the tenant has permission to add rules"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FMU%3D","line":245,"in_reply_to":"AAAALn%2F%2F%2FcA%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":251,"context_line":"            raise ext_sg.SecurityGroupRulesNotSingleTenant()"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        for tenant_id in tenant_ids:"},{"line_number":254,"context_line":"                self.get_securitygroup(context, new_rules.keys()[0],"},{"line_number":255,"context_line":"                                       tenant_id\u003dtenant_id)"},{"line_number":256,"context_line":"        return new_rules.keys()[0]"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Fb4%3D","line":254,"updated":"2012-10-22 22:50:10.000000000","message":"PEP8 vertical alignment","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            raise ext_sg.SecurityGroupRulesNotSingleTenant()"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        for tenant_id in tenant_ids:"},{"line_number":254,"context_line":"                self.get_securitygroup(context, new_rules.keys()[0],"},{"line_number":255,"context_line":"                                       tenant_id\u003dtenant_id)"},{"line_number":256,"context_line":"        return new_rules.keys()[0]"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FMQ%3D","line":254,"in_reply_to":"AAAALn%2F%2F%2Fb4%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":255,"context_line":"                                       tenant_id\u003dtenant_id)"},{"line_number":256,"context_line":"        return new_rules.keys()[0]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def _make_security_group_rule_dict(self, securitygrouprule, fields\u003dNone):"},{"line_number":259,"context_line":"        res \u003d {\u0027id\u0027: securitygrouprule[\u0027id\u0027],"},{"line_number":260,"context_line":"               \u0027tenant_id\u0027: securitygrouprule[\u0027tenant_id\u0027],"},{"line_number":261,"context_line":"               \u0027security_group_id\u0027: securitygrouprule[\u0027security_group_id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Fbc%3D","line":258,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) Consider simplifying this method to filter out  keys not to include or just providing a list of keys to create the dict from, e.g. \n\nfilter_keys \u003d [\u0027unwanted_key1\u0027]\nres \u003d dict((x, y) for x, y in securitygrouprule.iteritems() if x not in filter_keys)","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                                       tenant_id\u003dtenant_id)"},{"line_number":256,"context_line":"        return new_rules.keys()[0]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def _make_security_group_rule_dict(self, securitygrouprule, fields\u003dNone):"},{"line_number":259,"context_line":"        res \u003d {\u0027id\u0027: securitygrouprule[\u0027id\u0027],"},{"line_number":260,"context_line":"               \u0027tenant_id\u0027: securitygrouprule[\u0027tenant_id\u0027],"},{"line_number":261,"context_line":"               \u0027security_group_id\u0027: securitygrouprule[\u0027security_group_id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2B18%3D","line":258,"in_reply_to":"AAAALn%2F%2F%2Fbc%3D","updated":"2012-10-23 20:59:27.000000000","message":"gotcha, I\u0027m leaving this to be consistant with all of the other _make_*dict functions in the db_base class.","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":276,"context_line":"               \u0027security_group_id\u0027: [sgr[\u0027security_group_id\u0027]],"},{"line_number":277,"context_line":"               \u0027direction\u0027: [sgr[\u0027direction\u0027]]}"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        if sgr.get(\u0027protocol\u0027):"},{"line_number":280,"context_line":"            res[\u0027protocol\u0027] \u003d [sgr[\u0027protocol\u0027]]"},{"line_number":281,"context_line":"        if sgr.get(\u0027port_range_max\u0027):"},{"line_number":282,"context_line":"            res[\u0027port_range_max\u0027] \u003d [sgr[\u0027port_range_max\u0027]]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FbI%3D","line":279,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) Consider simplifying e.g.\n\ninclude_if_present \u003d [\u0027protocol\u0027]\nfor key in include_if_present:\n  value \u003d sgr.get(key)\n  if value:\n    res[key] \u003d [value]","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":276,"context_line":"               \u0027security_group_id\u0027: [sgr[\u0027security_group_id\u0027]],"},{"line_number":277,"context_line":"               \u0027direction\u0027: [sgr[\u0027direction\u0027]]}"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        if sgr.get(\u0027protocol\u0027):"},{"line_number":280,"context_line":"            res[\u0027protocol\u0027] \u003d [sgr[\u0027protocol\u0027]]"},{"line_number":281,"context_line":"        if sgr.get(\u0027port_range_max\u0027):"},{"line_number":282,"context_line":"            res[\u0027port_range_max\u0027] \u003d [sgr[\u0027port_range_max\u0027]]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2B14%3D","line":279,"in_reply_to":"AAAALn%2F%2F%2FbI%3D","updated":"2012-10-23 20:59:27.000000000","message":"great thanks!","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def _check_for_duplicate_rules(self, context, securitygrouprules):"},{"line_number":297,"context_line":"        \"\"\" Check for duplicate rules\"\"\""},{"line_number":298,"context_line":"        for i in securitygrouprules:"},{"line_number":299,"context_line":"            found_self \u003d False"},{"line_number":300,"context_line":"            for j in securitygrouprules:"},{"line_number":301,"context_line":"                if i[\u0027securitygrouprule\u0027] \u003d\u003d j[\u0027securitygrouprule\u0027]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FbA%3D","line":298,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) Consider simplifying the duplicate rule check using the set type, e.g.\n\nunique_rules \u003d list(set(x[\u0027securitygrouprule\u0027] for x in securitygrouprules))\nif unique_rules !\u003d security_group_rules:\n   raise","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def _check_for_duplicate_rules(self, context, securitygrouprules):"},{"line_number":297,"context_line":"        \"\"\" Check for duplicate rules\"\"\""},{"line_number":298,"context_line":"        for i in securitygrouprules:"},{"line_number":299,"context_line":"            found_self \u003d False"},{"line_number":300,"context_line":"            for j in securitygrouprules:"},{"line_number":301,"context_line":"                if i[\u0027securitygrouprule\u0027] \u003d\u003d j[\u0027securitygrouprule\u0027]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2B04%3D","line":298,"in_reply_to":"AAAALn%2F%2F%2FbA%3D","updated":"2012-10-23 20:59:27.000000000","message":"This won\u0027t work since set\u0027s  hash and dicts aren\u0027t hashable.","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":309,"context_line":"                raise ext_sg.SecurityGroupRuleExists(rule\u003di)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def get_securitygrouprules(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":312,"context_line":"        return  self._get_collection(context, SecurityGroupRule,"},{"line_number":313,"context_line":"                                     self._make_security_group_rule_dict,"},{"line_number":314,"context_line":"                                     filters\u003dfilters, fields\u003dfields)"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Fa8%3D","line":312,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) unnecessary space after return","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                raise ext_sg.SecurityGroupRuleExists(rule\u003di)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def get_securitygrouprules(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":312,"context_line":"        return  self._get_collection(context, SecurityGroupRule,"},{"line_number":313,"context_line":"                                     self._make_security_group_rule_dict,"},{"line_number":314,"context_line":"                                     filters\u003dfilters, fields\u003dfields)"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2B0U%3D","line":312,"in_reply_to":"AAAALn%2F%2F%2Fa8%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":353,"context_line":"    def _ensure_default_securitygroup(self, context, tenant_id,"},{"line_number":354,"context_line":"                                      securitygroup\u003dNone):"},{"line_number":355,"context_line":"        \"\"\"Create a default security group if one doesn\u0027t exist."},{"line_number":356,"context_line":"        Returns the default security group id."},{"line_number":357,"context_line":"        \"\"\""},{"line_number":358,"context_line":"        filters \u003d {\u0027name\u0027: [\u0027default\u0027], \u0027tenant_id\u0027: [tenant_id]}"},{"line_number":359,"context_line":"        default_group \u003d self.get_securitygroups(context, filters)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Fak%3D","line":356,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) Consider using sphinx docstring formatting for return values.","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    def _ensure_default_securitygroup(self, context, tenant_id,"},{"line_number":354,"context_line":"                                      securitygroup\u003dNone):"},{"line_number":355,"context_line":"        \"\"\"Create a default security group if one doesn\u0027t exist."},{"line_number":356,"context_line":"        Returns the default security group id."},{"line_number":357,"context_line":"        \"\"\""},{"line_number":358,"context_line":"        filters \u003d {\u0027name\u0027: [\u0027default\u0027], \u0027tenant_id\u0027: [tenant_id]}"},{"line_number":359,"context_line":"        default_group \u003d self.get_securitygroups(context, filters)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Bzo%3D","line":356,"in_reply_to":"AAAALn%2F%2F%2Fak%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":373,"context_line":"            return"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        valid_groups \u003d self.get_securitygroups(context, fields\u003d{\u0027id\u0027: None})"},{"line_number":376,"context_line":"        for valid_group in valid_groups:"},{"line_number":377,"context_line":"            valid_groups_set.add(valid_group[\u0027id\u0027])"},{"line_number":378,"context_line":"        req_sg_set \u003d Set(p[ext_sg.SECURITYGROUP])"},{"line_number":379,"context_line":"        invalid_sg_set \u003d req_sg_set - valid_groups_set"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FaI%3D","line":376,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) Consider removing line 371 and creating the set in one line, e.g.\n\nvalid_groups_set \u003d set([x[\u0027id\u0027] for x in valid_group])","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            return"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        valid_groups \u003d self.get_securitygroups(context, fields\u003d{\u0027id\u0027: None})"},{"line_number":376,"context_line":"        for valid_group in valid_groups:"},{"line_number":377,"context_line":"            valid_groups_set.add(valid_group[\u0027id\u0027])"},{"line_number":378,"context_line":"        req_sg_set \u003d Set(p[ext_sg.SECURITYGROUP])"},{"line_number":379,"context_line":"        invalid_sg_set \u003d req_sg_set - valid_groups_set"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Bzc%3D","line":376,"in_reply_to":"AAAALn%2F%2F%2FaI%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":378,"context_line":"        req_sg_set \u003d Set(p[ext_sg.SECURITYGROUP])"},{"line_number":379,"context_line":"        invalid_sg_set \u003d req_sg_set - valid_groups_set"},{"line_number":380,"context_line":"        if invalid_sg_set:"},{"line_number":381,"context_line":"            msg \u003d \"\""},{"line_number":382,"context_line":"            for sg in invalid_sg_set:"},{"line_number":383,"context_line":"                msg +\u003d \"%s \" % sg"},{"line_number":384,"context_line":"                raise ext_sg.SecurityGroupNotFound(id\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FZ8%3D","line":381,"updated":"2012-10-22 22:50:10.000000000","message":"The raise statement on line 384 appears to be incorrectly included in the \u0027for\u0027 block, so that only the first invalid sg is included in the exception message.\n\n(Suggestion only) Consider using join() to simplify the statement:\n\nmsg \u003d \u0027 \u0027.join(invalid_sg_set)","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        req_sg_set \u003d Set(p[ext_sg.SECURITYGROUP])"},{"line_number":379,"context_line":"        invalid_sg_set \u003d req_sg_set - valid_groups_set"},{"line_number":380,"context_line":"        if invalid_sg_set:"},{"line_number":381,"context_line":"            msg \u003d \"\""},{"line_number":382,"context_line":"            for sg in invalid_sg_set:"},{"line_number":383,"context_line":"                msg +\u003d \"%s \" % sg"},{"line_number":384,"context_line":"                raise ext_sg.SecurityGroupNotFound(id\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2BzI%3D","line":381,"in_reply_to":"AAAALn%2F%2F%2FZ8%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":40,"context_line":"class SecurityGroupPortBinding(model_base.BASEV2):"},{"line_number":41,"context_line":"    \"\"\"Represents binding between quantum ports and security profiles\"\"\""},{"line_number":42,"context_line":"    port_id \u003d sa.Column(sa.String(36), primary_key\u003dTrue)"},{"line_number":43,"context_line":"    sg_id \u003d sa.Column(sa.String(36), primary_key\u003dTrue)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class SecurityGroupRule(model_base.BASEV2, models_v2.HasId,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F9%2BE%3D","line":43,"updated":"2012-10-24 11:20:29.000000000","message":"sg_id and port_id needs to be foreign key?","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"class SecurityGroupPortBinding(model_base.BASEV2):"},{"line_number":41,"context_line":"    \"\"\"Represents binding between quantum ports and security profiles\"\"\""},{"line_number":42,"context_line":"    port_id \u003d sa.Column(sa.String(36), primary_key\u003dTrue)"},{"line_number":43,"context_line":"    sg_id \u003d sa.Column(sa.String(36), primary_key\u003dTrue)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class SecurityGroupRule(model_base.BASEV2, models_v2.HasId,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F9dM%3D","line":43,"in_reply_to":"AAAALn%2F%2F9%2BE%3D","updated":"2012-10-24 19:04:03.000000000","message":"Done","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":79,"context_line":"        If default_sg is true that means we are a default security group for"},{"line_number":80,"context_line":"        a given tenant if it does not exist."},{"line_number":81,"context_line":"        \"\"\""},{"line_number":82,"context_line":"        print security_group"},{"line_number":83,"context_line":"        s \u003d security_group[\u0027security_group\u0027]"},{"line_number":84,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, s)"},{"line_number":85,"context_line":"        if not default_sg:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F%2BMU%3D","line":82,"updated":"2012-10-24 03:11:12.000000000","message":"Oops!","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        If default_sg is true that means we are a default security group for"},{"line_number":80,"context_line":"        a given tenant if it does not exist."},{"line_number":81,"context_line":"        \"\"\""},{"line_number":82,"context_line":"        print security_group"},{"line_number":83,"context_line":"        s \u003d security_group[\u0027security_group\u0027]"},{"line_number":84,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, s)"},{"line_number":85,"context_line":"        if not default_sg:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F%2BHE%3D","line":82,"in_reply_to":"AAAALn%2F%2F%2BMU%3D","updated":"2012-10-24 19:04:03.000000000","message":"Done","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":237,"context_line":"        tenant_ids \u003d set()"},{"line_number":238,"context_line":"        for rules in security_group_rule[\u0027security_group_rules\u0027]:"},{"line_number":239,"context_line":"            rule \u003d rules.get(\u0027security_group_rule\u0027)"},{"line_number":240,"context_line":"            new_rules.setdefault(rule[\u0027security_group_id\u0027], []).append(rule)"},{"line_number":241,"context_line":"            if rule[\u0027tenant_id\u0027] not in tenant_ids:"},{"line_number":242,"context_line":"                tenant_ids.add(rule[\u0027tenant_id\u0027])"},{"line_number":243,"context_line":"            source_group_id \u003d rule.get(\u0027source_group_id\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F%2BMQ%3D","line":240,"updated":"2012-10-24 03:11:12.000000000","message":"(Suggestion only) Limiting the functional scope of a line to a single logical operation aids both in clarity and maintainability.  If a change to a given logical operation is required, only that line need be updated.","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        tenant_ids \u003d set()"},{"line_number":238,"context_line":"        for rules in security_group_rule[\u0027security_group_rules\u0027]:"},{"line_number":239,"context_line":"            rule \u003d rules.get(\u0027security_group_rule\u0027)"},{"line_number":240,"context_line":"            new_rules.setdefault(rule[\u0027security_group_id\u0027], []).append(rule)"},{"line_number":241,"context_line":"            if rule[\u0027tenant_id\u0027] not in tenant_ids:"},{"line_number":242,"context_line":"                tenant_ids.add(rule[\u0027tenant_id\u0027])"},{"line_number":243,"context_line":"            source_group_id \u003d rule.get(\u0027source_group_id\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F%2BGg%3D","line":240,"in_reply_to":"AAAALn%2F%2F%2BMQ%3D","updated":"2012-10-24 19:04:03.000000000","message":"Done","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":288,"context_line":"        return res"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def _check_for_duplicate_rules(self, context, security_group_rules):"},{"line_number":291,"context_line":"        \"\"\" Check for duplicate rules\"\"\""},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        for i in security_group_rules:"},{"line_number":294,"context_line":"            found_self \u003d False"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F990%3D","line":291,"updated":"2012-10-24 11:20:29.000000000","message":"This docstring seems to be unnecessary since it provides no additional information than the funcname.","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        return res"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def _check_for_duplicate_rules(self, context, security_group_rules):"},{"line_number":291,"context_line":"        \"\"\" Check for duplicate rules\"\"\""},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        for i in security_group_rules:"},{"line_number":294,"context_line":"            found_self \u003d False"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F9dA%3D","line":291,"in_reply_to":"AAAALn%2F%2F990%3D","updated":"2012-10-24 19:04:03.000000000","message":"Done","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":349,"context_line":"                                       security_group\u003dNone):"},{"line_number":350,"context_line":"        \"\"\"Create a default security group if one doesn\u0027t exist."},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        Returns:"},{"line_number":353,"context_line":"             The default security group id."},{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        filters \u003d {\u0027name\u0027: [\u0027default\u0027], \u0027tenant_id\u0027: [tenant_id]}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F%2BME%3D","line":352,"updated":"2012-10-24 03:11:12.000000000","message":"(Suggestion only) Apologies for not being more specific, but the format that is generally followed in core projects is the non-google standard (to match how parameters are commonly formatted), e.g.\n\n:returns: the default security group id","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                                       security_group\u003dNone):"},{"line_number":350,"context_line":"        \"\"\"Create a default security group if one doesn\u0027t exist."},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        Returns:"},{"line_number":353,"context_line":"             The default security group id."},{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        filters \u003d {\u0027name\u0027: [\u0027default\u0027], \u0027tenant_id\u0027: [tenant_id]}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F9c8%3D","line":352,"in_reply_to":"AAAALn%2F%2F%2BME%3D","updated":"2012-10-24 19:04:03.000000000","message":"Done","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def _validate_security_groups_on_port(self, context, port):"},{"line_number":367,"context_line":"        p \u003d port[\u0027port\u0027]"},{"line_number":368,"context_line":"        valid_groups_set \u003d set()"},{"line_number":369,"context_line":"        if not p.get(ext_sg.SECURITYGROUP):"},{"line_number":370,"context_line":"            return"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F%2BMA%3D","line":368,"updated":"2012-10-24 03:11:12.000000000","message":"This line is now redundant.","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def _validate_security_groups_on_port(self, context, port):"},{"line_number":367,"context_line":"        p \u003d port[\u0027port\u0027]"},{"line_number":368,"context_line":"        valid_groups_set \u003d set()"},{"line_number":369,"context_line":"        if not p.get(ext_sg.SECURITYGROUP):"},{"line_number":370,"context_line":"            return"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F9c4%3D","line":368,"in_reply_to":"AAAALn%2F%2F%2BMA%3D","updated":"2012-10-24 19:04:03.000000000","message":"Done","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":374,"context_line":"        req_sg_set \u003d set(p[ext_sg.SECURITYGROUP])"},{"line_number":375,"context_line":"        invalid_sg_set \u003d req_sg_set - valid_groups_set"},{"line_number":376,"context_line":"        if invalid_sg_set:"},{"line_number":377,"context_line":"            msg \u003d \"\""},{"line_number":378,"context_line":"            for sg in invalid_sg_set:"},{"line_number":379,"context_line":"                msg +\u003d \"%s \" % sg"},{"line_number":380,"context_line":"            if msg:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F%2BL8%3D","line":377,"updated":"2012-10-24 03:11:12.000000000","message":"This block now executes as intended, but the logic is unnecessarily complicated.  If this block is entered, line 380 is guaranteed to be true.  Consider removing the conditional on 380 and dedenting the raise, or replacing 377-381 with the following:\n\nmsg \u003d \u0027 \u0027.join(invalid_sg_set)\n\nraise ext_sg.SecurityGroupNotFound(id\u003dmsg)","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        req_sg_set \u003d set(p[ext_sg.SECURITYGROUP])"},{"line_number":375,"context_line":"        invalid_sg_set \u003d req_sg_set - valid_groups_set"},{"line_number":376,"context_line":"        if invalid_sg_set:"},{"line_number":377,"context_line":"            msg \u003d \"\""},{"line_number":378,"context_line":"            for sg in invalid_sg_set:"},{"line_number":379,"context_line":"                msg +\u003d \"%s \" % sg"},{"line_number":380,"context_line":"            if msg:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F9cQ%3D","line":377,"in_reply_to":"AAAALn%2F%2F%2BL8%3D","updated":"2012-10-24 19:04:03.000000000","message":"Done, Join is a string method not a set method.","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        req_sg_set \u003d set(p[ext_sg.SECURITYGROUP])"},{"line_number":375,"context_line":"        invalid_sg_set \u003d req_sg_set - valid_groups_set"},{"line_number":376,"context_line":"        if invalid_sg_set:"},{"line_number":377,"context_line":"            msg \u003d \"\""},{"line_number":378,"context_line":"            for sg in invalid_sg_set:"},{"line_number":379,"context_line":"                msg +\u003d \"%s \" % sg"},{"line_number":380,"context_line":"            if msg:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F9Vs%3D","line":377,"in_reply_to":"AAAALn%2F%2F9Ys%3D","updated":"2012-10-24 19:59:32.000000000","message":"Gotcha, you have to iterate it inside. I.e: your first example is false. Done","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":374,"context_line":"        req_sg_set \u003d set(p[ext_sg.SECURITYGROUP])"},{"line_number":375,"context_line":"        invalid_sg_set \u003d req_sg_set - valid_groups_set"},{"line_number":376,"context_line":"        if invalid_sg_set:"},{"line_number":377,"context_line":"            msg \u003d \"\""},{"line_number":378,"context_line":"            for sg in invalid_sg_set:"},{"line_number":379,"context_line":"                msg +\u003d \"%s \" % sg"},{"line_number":380,"context_line":"            if msg:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F9Ys%3D","line":377,"in_reply_to":"AAAALn%2F%2F9cQ%3D","updated":"2012-10-24 19:13:35.000000000","message":"I\u0027m not sure what you mean by that statement.  The target of join is the separator character (space in this instance), and it takes an iterator of strings as an argument (which can be a set), e.g.\n\nmyset \u003d set([\u0027a\u0027, \u0027b\u0027, \u0027c\u0027]); \n\u0027 \u0027.join(myset) \u003d\u003d \u0027a b c\u0027\n\nIn the event that the iterable does not contain strings, simply convert inline with a generator:\n\nmyset \u003d set([1, 2, 3]); \n\u0027 \u0027.join(str(x) for x in myset) \u003d\u003d \u00271 2 3\u0027","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":241,"context_line":"        tenant_ids \u003d set()"},{"line_number":242,"context_line":"        for rules in security_group_rule[\u0027security_group_rules\u0027]:"},{"line_number":243,"context_line":"            rule \u003d rules.get(\u0027security_group_rule\u0027)"},{"line_number":244,"context_line":"            new_rules.setdefault(rule[\u0027security_group_id\u0027], [])"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"            # Check that protocol/ethertype are valid"},{"line_number":247,"context_line":"            protocol \u003d rule.get(\u0027protocol\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALn%2F%2F9GQ%3D","line":244,"updated":"2012-10-24 23:29:51.000000000","message":"It doesn\u0027t appear rules are being appended anymore.  The fact that the tests still pass is a bit of a concern - is this method being adequately tested?","commit_id":"fad6477d7e448471573223d3dbad332432565026"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        tenant_ids \u003d set()"},{"line_number":242,"context_line":"        for rules in security_group_rule[\u0027security_group_rules\u0027]:"},{"line_number":243,"context_line":"            rule \u003d rules.get(\u0027security_group_rule\u0027)"},{"line_number":244,"context_line":"            new_rules.setdefault(rule[\u0027security_group_id\u0027], [])"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"            # Check that protocol/ethertype are valid"},{"line_number":247,"context_line":"            protocol \u003d rule.get(\u0027protocol\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALn%2F%2F9FQ%3D","line":244,"in_reply_to":"AAAALn%2F%2F9GQ%3D","updated":"2012-10-24 23:36:08.000000000","message":"The append wasn\u0027t needed previously. This line is used only store the security_group_id\u0027s as keys in a dict. This is done to check to make sure that if a user installs multiple rules at once that those rules are only for 1 security group. I\u0027ll change this to a set instead.","commit_id":"fad6477d7e448471573223d3dbad332432565026"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":243,"context_line":"            rule \u003d rules.get(\u0027security_group_rule\u0027)"},{"line_number":244,"context_line":"            new_rules.setdefault(rule[\u0027security_group_id\u0027], [])"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"            # Check that protocol/ethertype are valid"},{"line_number":247,"context_line":"            protocol \u003d rule.get(\u0027protocol\u0027)"},{"line_number":248,"context_line":"            if protocol and protocol not in self.sg_supported_protocols:"},{"line_number":249,"context_line":"                raise ext_sg.SecurityGroupInvalidProtocolType(value\u003dprotocol)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALn%2F%2F9Fo%3D","line":246,"updated":"2012-10-24 23:29:51.000000000","message":"(Suggestion only) These lines (246-269) were added in the most recent patches, but there doesn\u0027t appear to be a corresponding increase in test coverage.  Consider ensuring that all paths in this method are verified.","commit_id":"fad6477d7e448471573223d3dbad332432565026"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            rule \u003d rules.get(\u0027security_group_rule\u0027)"},{"line_number":244,"context_line":"            new_rules.setdefault(rule[\u0027security_group_id\u0027], [])"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"            # Check that protocol/ethertype are valid"},{"line_number":247,"context_line":"            protocol \u003d rule.get(\u0027protocol\u0027)"},{"line_number":248,"context_line":"            if protocol and protocol not in self.sg_supported_protocols:"},{"line_number":249,"context_line":"                raise ext_sg.SecurityGroupInvalidProtocolType(value\u003dprotocol)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALn%2F%2F9FM%3D","line":246,"in_reply_to":"AAAALn%2F%2F9Fo%3D","updated":"2012-10-24 23:36:08.000000000","message":"Done","commit_id":"fad6477d7e448471573223d3dbad332432565026"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\"Represents a v2 quantum security group.\"\"\""},{"line_number":35,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":36,"context_line":"    description \u003d sa.Column(sa.String(255))"},{"line_number":37,"context_line":"    external_id \u003d sa.Column(sa.Integer, unique\u003dTrue)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class SecurityGroupPortBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAALn%2F%2F86A%3D","line":37,"updated":"2012-10-25 04:33:42.000000000","message":"This column is marked unique.  I know it\u0027s designed to make porting easier, but how does a tenant discover the first available external_id since they can only see their objects. Can we drop the uniqueness requirement or make it only limited to a tenant?","commit_id":"e4a63e41a5902b87f064b5352b91bac184857586"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\"Represents a v2 quantum security group.\"\"\""},{"line_number":35,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":36,"context_line":"    description \u003d sa.Column(sa.String(255))"},{"line_number":37,"context_line":"    external_id \u003d sa.Column(sa.Integer, unique\u003dTrue)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class SecurityGroupPortBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAALn%2F%2F85A%3D","line":37,"in_reply_to":"AAAALn%2F%2F86A%3D","updated":"2012-10-25 04:49:33.000000000","message":"This external id is the id of a security group in nova (tenant doesn\u0027t use this directly). Unfortunately nova uses an auto increment int for this field so we can run into trouble if one deleted the nova db and not the quantum db and was using security groups through nova. This field unfortunately does have to be unique though to be backward compatible.","commit_id":"e4a63e41a5902b87f064b5352b91bac184857586"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":41,"context_line":"    \"\"\"Represents binding between quantum ports and security profiles\"\"\""},{"line_number":42,"context_line":"    port_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ports.id\"),"},{"line_number":43,"context_line":"                        primary_key\u003dTrue)"},{"line_number":44,"context_line":"    sg_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"securitygroups.id\"),"},{"line_number":45,"context_line":"                      primary_key\u003dTrue)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAALn%2F%2F858%3D","line":44,"updated":"2012-10-25 04:33:42.000000000","message":"This column should probably be called security_group_id to be consistent with the other models.","commit_id":"e4a63e41a5902b87f064b5352b91bac184857586"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    \"\"\"Represents binding between quantum ports and security profiles\"\"\""},{"line_number":42,"context_line":"    port_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ports.id\"),"},{"line_number":43,"context_line":"                        primary_key\u003dTrue)"},{"line_number":44,"context_line":"    sg_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"securitygroups.id\"),"},{"line_number":45,"context_line":"                      primary_key\u003dTrue)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAALn%2F%2F848%3D","line":44,"in_reply_to":"AAAALn%2F%2F858%3D","updated":"2012-10-25 04:49:33.000000000","message":"Done","commit_id":"e4a63e41a5902b87f064b5352b91bac184857586"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":108,"context_line":"                                              external_id\u003ds.get(\u0027external_id\u0027))"},{"line_number":109,"context_line":"            context.session.add(security_group_db)"},{"line_number":110,"context_line":"        if s.get(\u0027name\u0027) \u003d\u003d \u0027default\u0027:"},{"line_number":111,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":112,"context_line":"                for ethertype in self.sg_supported_ethertypes:"},{"line_number":113,"context_line":"                    # Allow all egress traffic"},{"line_number":114,"context_line":"                    db \u003d SecurityGroupRule("}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAALn%2F%2F85s%3D","line":111,"updated":"2012-10-25 04:09:24.000000000","message":"Does this \u0027with\u0027 statement need to be merged into the above \u0027with\u0027 statement? If this session fails, only the above sg is created. I am not sure this session may fail though.","commit_id":"e4a63e41a5902b87f064b5352b91bac184857586"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":108,"context_line":"                                              external_id\u003ds.get(\u0027external_id\u0027))"},{"line_number":109,"context_line":"            context.session.add(security_group_db)"},{"line_number":110,"context_line":"        if s.get(\u0027name\u0027) \u003d\u003d \u0027default\u0027:"},{"line_number":111,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":112,"context_line":"                for ethertype in self.sg_supported_ethertypes:"},{"line_number":113,"context_line":"                    # Allow all egress traffic"},{"line_number":114,"context_line":"                    db \u003d SecurityGroupRule("}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAALn%2F%2F8dA%3D","line":111,"in_reply_to":"AAAALn%2F%2F85c%3D","updated":"2012-10-25 17:50:10.000000000","message":"If you add relationships between the models you don\u0027t have to nest transactions so deeply.  SQLAlchemy can handle the details for you:\n\nhttps://gist.github.com/3954232","commit_id":"e4a63e41a5902b87f064b5352b91bac184857586"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                                              external_id\u003ds.get(\u0027external_id\u0027))"},{"line_number":109,"context_line":"            context.session.add(security_group_db)"},{"line_number":110,"context_line":"        if s.get(\u0027name\u0027) \u003d\u003d \u0027default\u0027:"},{"line_number":111,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":112,"context_line":"                for ethertype in self.sg_supported_ethertypes:"},{"line_number":113,"context_line":"                    # Allow all egress traffic"},{"line_number":114,"context_line":"                    db \u003d SecurityGroupRule("}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAALn%2F%2F85c%3D","line":111,"in_reply_to":"AAAALn%2F%2F85s%3D","updated":"2012-10-25 04:21:48.000000000","message":"You are right. This is something I noticed as well. The issue is because of the foreign key reference between the created SecurityGroup.id and SecurityGroupRule.security_group_id it was giving me a IntegrityError unless it was outside of the with statement. Do you have a suggestion on how to fix this?","commit_id":"e4a63e41a5902b87f064b5352b91bac184857586"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":271,"context_line":"                raise ext_sg.SecurityGroupInvalidEtherType(value\u003dethertype)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"            # Check that port_range\u0027s are valid"},{"line_number":274,"context_line":"            if ((rule[\u0027port_range_min\u0027] and not rule[\u0027port_range_max\u0027]) or"},{"line_number":275,"context_line":"                (not rule[\u0027port_range_min\u0027] and rule[\u0027port_range_max\u0027])):"},{"line_number":276,"context_line":"                raise ext_sg.SecurityGroupInvalidPortRange()"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAALn%2F%2F85U%3D","line":274,"updated":"2012-10-25 04:33:42.000000000","message":"I don\u0027t think this logic will detect port_range_min\u003d0 port_range_max\u003dNone and vice versa.","commit_id":"e4a63e41a5902b87f064b5352b91bac184857586"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                raise ext_sg.SecurityGroupInvalidEtherType(value\u003dethertype)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"            # Check that port_range\u0027s are valid"},{"line_number":274,"context_line":"            if ((rule[\u0027port_range_min\u0027] and not rule[\u0027port_range_max\u0027]) or"},{"line_number":275,"context_line":"                (not rule[\u0027port_range_min\u0027] and rule[\u0027port_range_max\u0027])):"},{"line_number":276,"context_line":"                raise ext_sg.SecurityGroupInvalidPortRange()"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAALn%2F%2F844%3D","line":274,"in_reply_to":"AAAALn%2F%2F85U%3D","updated":"2012-10-25 04:49:33.000000000","message":"good catch, I\u0027ll change these to if rule.get(\u0027port_range_min\u0027) etc.","commit_id":"e4a63e41a5902b87f064b5352b91bac184857586"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":272,"context_line":"                raise ext_sg.SecurityGroupInvalidEtherType(value\u003dethertype)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"            # Check that port_range\u0027s are valid"},{"line_number":275,"context_line":"            if ((rule[\u0027port_range_min\u0027] \u003e\u003d 0 and not rule[\u0027port_range_max\u0027]) or"},{"line_number":276,"context_line":"                (not rule[\u0027port_range_min\u0027] and rule[\u0027port_range_max\u0027] \u003e\u003d 0)):"},{"line_number":277,"context_line":"                raise ext_sg.SecurityGroupInvalidPortRange()"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALn%2F%2F73k%3D","line":275,"updated":"2012-10-26 03:46:46.000000000","message":"Thought about this some more today. Consider this to replace 275-282, 287-289\n\nif rule[\u0027port_range_min\u0027] is None and rule[\u0027port_range_max\u0027] is None:\n    pass\nelif rule[\u0027port_range_min\u0027] is not None and rule[\u0027port_range_min\u0027] \u003c\u003d rule[\u0027port_range_max\u0027]:\n    if not rule[\u0027protocol\u0027]:\n        raise ext_sg.SecurityGroupProtocolRequiredWithPorts()\nelse:\n    raise ext_sg.SecurityGroupInvalidPortRange()","commit_id":"dbd496da920353c5c11727399110a6df5f720752"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                raise ext_sg.SecurityGroupInvalidEtherType(value\u003dethertype)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"            # Check that port_range\u0027s are valid"},{"line_number":275,"context_line":"            if ((rule[\u0027port_range_min\u0027] \u003e\u003d 0 and not rule[\u0027port_range_max\u0027]) or"},{"line_number":276,"context_line":"                (not rule[\u0027port_range_min\u0027] and rule[\u0027port_range_max\u0027] \u003e\u003d 0)):"},{"line_number":277,"context_line":"                raise ext_sg.SecurityGroupInvalidPortRange()"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALn%2F%2F714%3D","line":275,"in_reply_to":"AAAALn%2F%2F73k%3D","updated":"2012-10-26 05:09:56.000000000","message":"Nice! Thanks.","commit_id":"dbd496da920353c5c11727399110a6df5f720752"}],"quantum/extensions/securitygroup.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"3b4f5b1ec99c28a06068b010ce0b66de1b351318","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# supported protocols"},{"line_number":28,"context_line":"TCP \u003d 6"},{"line_number":29,"context_line":"UDP \u003d 17"},{"line_number":30,"context_line":"ICMP \u003d 1"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Security group Exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKdo%3D","line":30,"updated":"2012-10-10 00:53:46.000000000","message":"Do we need to define ICMP6 \u003d 58","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# supported protocols"},{"line_number":28,"context_line":"TCP \u003d 6"},{"line_number":29,"context_line":"UDP \u003d 17"},{"line_number":30,"context_line":"ICMP \u003d 1"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Security group Exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKas%3D","line":30,"in_reply_to":"AAAALH%2F%2FKdo%3D","updated":"2012-10-10 02:01:59.000000000","message":"Good point, changing to protocol names and numbers.","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f899865839709e116ed9b75056f7362d6600fc58","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    if protocol is None:"},{"line_number":92,"context_line":"        return None"},{"line_number":93,"context_line":"    try:"},{"line_number":94,"context_line":"        return int(protocol)"},{"line_number":95,"context_line":"    except TypeError:"},{"line_number":96,"context_line":"        raise SecurityGroupRuleInvalidProtocol(protocol\u003dprotocol,"},{"line_number":97,"context_line":"            values\u003d\"%d %d %d\" % (TCP, UDP, ICMP))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKec%3D","line":94,"updated":"2012-10-10 00:55:06.000000000","message":"Do u want user to give us 6, 17 and 1? I think to allow user to give us TCP, UDP, ICMP will add friendliness.","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    if protocol is None:"},{"line_number":92,"context_line":"        return None"},{"line_number":93,"context_line":"    try:"},{"line_number":94,"context_line":"        return int(protocol)"},{"line_number":95,"context_line":"    except TypeError:"},{"line_number":96,"context_line":"        raise SecurityGroupRuleInvalidProtocol(protocol\u003dprotocol,"},{"line_number":97,"context_line":"            values\u003d\"%d %d %d\" % (TCP, UDP, ICMP))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKa0%3D","line":94,"in_reply_to":"AAAALH%2F%2FKec%3D","updated":"2012-10-10 02:01:59.000000000","message":"sure","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"3b4f5b1ec99c28a06068b010ce0b66de1b351318","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                           \u0027convert_to\u0027: convert_validate_port_value,"},{"line_number":147,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":148,"context_line":"        \u0027ethertype\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":149,"context_line":"                      \u0027validate\u0027: {\u0027type:values\u0027: [\u0027IPv4\u0027, \u0027IPv6\u0027]},"},{"line_number":150,"context_line":"                      \u0027is_visible\u0027: True, \u0027default\u0027: \u0027IPv4\u0027},"},{"line_number":151,"context_line":"        \u0027ip_prefix\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":152,"context_line":"                      \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKd0%3D","line":149,"updated":"2012-10-10 00:53:46.000000000","message":"Should IPv4, and IPv6 be module level constants?  Also should this field be the number value (0x0800, 0x86dd) similar to how tcp, udp, and icmp are their protocol vals?","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                           \u0027convert_to\u0027: convert_validate_port_value,"},{"line_number":147,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":148,"context_line":"        \u0027ethertype\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":149,"context_line":"                      \u0027validate\u0027: {\u0027type:values\u0027: [\u0027IPv4\u0027, \u0027IPv6\u0027]},"},{"line_number":150,"context_line":"                      \u0027is_visible\u0027: True, \u0027default\u0027: \u0027IPv4\u0027},"},{"line_number":151,"context_line":"        \u0027ip_prefix\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":152,"context_line":"                      \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FKaw%3D","line":149,"in_reply_to":"AAAALH%2F%2FKd0%3D","updated":"2012-10-10 02:01:59.000000000","message":"What do you mean by module level constants?\nAre you wanting this? \nIPv4 \u003d \u0027IPv4\u0027,\nIPv6 \u003d \u0027IPv6\u0027\n{\u0027type:values\u0027 [IPv4, IPv6]} ?","commit_id":"2dadc5c6874eeb3667f3da40f658768e6a6d2d4a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":107,"context_line":"        raise SecurityGroupInvalidPortValue(port\u003dport)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# Attribute Map"},{"line_number":110,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":111,"context_line":"    \u0027securitygroups\u0027: {"},{"line_number":112,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":113,"context_line":"               \u0027validate\u0027: {\u0027type:regex\u0027: attr.UUID_PATTERN},"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKPI%3D","line":110,"updated":"2012-10-10 11:48:08.000000000","message":"Updating sg and sgrule is not supported in this patch?\nThe patch for quantumclient also has no support for *-update. Is it intended?","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        raise SecurityGroupInvalidPortValue(port\u003dport)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# Attribute Map"},{"line_number":110,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":111,"context_line":"    \u0027securitygroups\u0027: {"},{"line_number":112,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":113,"context_line":"               \u0027validate\u0027: {\u0027type:regex\u0027: attr.UUID_PATTERN},"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ%2F8%3D","line":110,"in_reply_to":"AAAALH%2F%2FKPI%3D","updated":"2012-10-10 18:29:09.000000000","message":"Yes, it\u0027s the same model as nova currently.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":116,"context_line":"                 \u0027is_visible\u0027: True, \u0027default\u0027: \u0027\u0027},"},{"line_number":117,"context_line":"        \u0027description\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":118,"context_line":"                        \u0027is_visible\u0027: True, \u0027default\u0027: \u0027\u0027},"},{"line_number":119,"context_line":"        \u0027external_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":120,"context_line":"                        \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":121,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":122,"context_line":"                      \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKN8%3D","line":119,"updated":"2012-10-10 11:48:08.000000000","message":"Why external_id is needed? I have not understood it. In db/securitygroup_db.py external_id seems to be another \u0027id\u0027 and have no additional meaning.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                 \u0027is_visible\u0027: True, \u0027default\u0027: \u0027\u0027},"},{"line_number":117,"context_line":"        \u0027description\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":118,"context_line":"                        \u0027is_visible\u0027: True, \u0027default\u0027: \u0027\u0027},"},{"line_number":119,"context_line":"        \u0027external_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":120,"context_line":"                        \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":121,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":122,"context_line":"                      \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ%2F4%3D","line":119,"in_reply_to":"AAAALH%2F%2FKN8%3D","updated":"2012-10-10 18:29:09.000000000","message":"This is used so that nova security groups can be leveraged for the time being.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":139,"context_line":"        \u0027protocol\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":140,"context_line":"                     \u0027is_visible\u0027: True,"},{"line_number":141,"context_line":"                     \u0027convert_to\u0027: convert_protocol_to_int, \u0027default\u0027: None,"},{"line_number":142,"context_line":"                     \u0027validate\u0027: {\u0027type:values\u0027: [TCP, UDP, ICMP, None]}},"},{"line_number":143,"context_line":"        \u0027port_range_min\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":144,"context_line":"                           \u0027convert_to\u0027: convert_validate_port_value,"},{"line_number":145,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKPQ%3D","line":142,"updated":"2012-10-10 11:48:08.000000000","message":"How about changing a type of protocol from integer to string?\nString looks more user-friendly. A type of valid values for \u0027ethertype\u0027 is a string.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        \u0027protocol\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":140,"context_line":"                     \u0027is_visible\u0027: True,"},{"line_number":141,"context_line":"                     \u0027convert_to\u0027: convert_protocol_to_int, \u0027default\u0027: None,"},{"line_number":142,"context_line":"                     \u0027validate\u0027: {\u0027type:values\u0027: [TCP, UDP, ICMP, None]}},"},{"line_number":143,"context_line":"        \u0027port_range_min\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":144,"context_line":"                           \u0027convert_to\u0027: convert_validate_port_value,"},{"line_number":145,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ%2Fs%3D","line":142,"in_reply_to":"AAAALH%2F%2FKPQ%3D","updated":"2012-10-10 18:29:09.000000000","message":"Done","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":146,"context_line":"        \u0027port_range_max\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":147,"context_line":"                           \u0027convert_to\u0027: convert_validate_port_value,"},{"line_number":148,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":149,"context_line":"        \u0027ethertype\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":150,"context_line":"                      \u0027validate\u0027: {\u0027type:values\u0027: [\u0027IPv4\u0027, \u0027IPv6\u0027]},"},{"line_number":151,"context_line":"                      \u0027is_visible\u0027: True, \u0027default\u0027: \u0027IPv4\u0027},"},{"line_number":152,"context_line":"        \u0027ip_prefix\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKPA%3D","line":149,"updated":"2012-10-10 11:48:08.000000000","message":"I prefer \u0027ip_version\u0027. It is more consistent with the attribute name of subnet resource.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        \u0027port_range_max\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":147,"context_line":"                           \u0027convert_to\u0027: convert_validate_port_value,"},{"line_number":148,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":149,"context_line":"        \u0027ethertype\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":150,"context_line":"                      \u0027validate\u0027: {\u0027type:values\u0027: [\u0027IPv4\u0027, \u0027IPv6\u0027]},"},{"line_number":151,"context_line":"                      \u0027is_visible\u0027: True, \u0027default\u0027: \u0027IPv4\u0027},"},{"line_number":152,"context_line":"        \u0027ip_prefix\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ%2Fg%3D","line":149,"in_reply_to":"AAAALH%2F%2FKPA%3D","updated":"2012-10-10 18:29:09.000000000","message":"Technically this could be stuff other than ipv4/ipv6. I removed the validation just limiting it to that.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":158,"context_line":"}"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"EXTERNAL \u003d \u0027securitygroup:sg\u0027"},{"line_number":162,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":163,"context_line":"    \u0027ports\u0027: {EXTERNAL: {\u0027allow_post\u0027: True,"},{"line_number":164,"context_line":"                         \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKN4%3D","line":161,"updated":"2012-10-10 11:48:08.000000000","message":"\u0027sg\u0027 is just an abbrev of \u0027securitygroup\u0027 and provides no additional information. Does \u0027securitygroup\u0027 do the job?\n\nIn addition, \"EXTERNAL\" does not explain its role appropriately.\n\"SECURITYGROUP\", \"SG\", \"SG_LIST\"?","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":158,"context_line":"}"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"EXTERNAL \u003d \u0027securitygroup:sg\u0027"},{"line_number":162,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":163,"context_line":"    \u0027ports\u0027: {EXTERNAL: {\u0027allow_post\u0027: True,"},{"line_number":164,"context_line":"                         \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ%2FY%3D","line":161,"in_reply_to":"AAAALH%2F%2FKN4%3D","updated":"2012-10-10 18:29:09.000000000","message":"Changed to SECURITYGROUP and securitygroup.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"class Securitygroup(object):"},{"line_number":181,"context_line":"    \"\"\" Security group extension"},{"line_number":182,"context_line":"    \"\"\""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    @classmethod"},{"line_number":185,"context_line":"    def get_name(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKO8%3D","line":182,"updated":"2012-10-10 11:48:08.000000000","message":"It is better to make docstring a single line (since it is only one line).","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"class Securitygroup(object):"},{"line_number":181,"context_line":"    \"\"\" Security group extension"},{"line_number":182,"context_line":"    \"\"\""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    @classmethod"},{"line_number":185,"context_line":"    def get_name(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ%2FQ%3D","line":182,"in_reply_to":"AAAALH%2F%2FKO8%3D","updated":"2012-10-10 18:29:09.000000000","message":"Done","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":229,"context_line":"            return {}"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class SecurityGroupPluginBase(object):"},{"line_number":233,"context_line":"    @abstractmethod"},{"line_number":234,"context_line":"    def create_securitygroup(self, context, securitygroup):"},{"line_number":235,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKZY%3D","line":232,"updated":"2012-10-10 04:01:27.000000000","message":"Do we have to have this class?","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            return {}"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class SecurityGroupPluginBase(object):"},{"line_number":233,"context_line":"    @abstractmethod"},{"line_number":234,"context_line":"    def create_securitygroup(self, context, securitygroup):"},{"line_number":235,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ%2FM%3D","line":232,"in_reply_to":"AAAALH%2F%2FKQw%3D","updated":"2012-10-10 18:29:09.000000000","message":"Ditto what Akihiro said.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":229,"context_line":"            return {}"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class SecurityGroupPluginBase(object):"},{"line_number":233,"context_line":"    @abstractmethod"},{"line_number":234,"context_line":"    def create_securitygroup(self, context, securitygroup):"},{"line_number":235,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKQw%3D","line":232,"in_reply_to":"AAAALH%2F%2FKZY%3D","updated":"2012-10-10 11:48:08.000000000","message":"This class acts as an interface class. I think it is useful for an implementer to know what methods are required.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":246,"context_line":"    def get_securitygroups(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":247,"context_line":"        pass"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def get_securitygroup(self, context, id, fields\u003dNone):"},{"line_number":250,"context_line":"        pass"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKQ0%3D","line":249,"updated":"2012-10-10 11:48:08.000000000","message":"This method should be @abstractmethod ?","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    def get_securitygroups(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":247,"context_line":"        pass"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def get_securitygroup(self, context, id, fields\u003dNone):"},{"line_number":250,"context_line":"        pass"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ%2FI%3D","line":249,"in_reply_to":"AAAALH%2F%2FKQ0%3D","updated":"2012-10-10 18:29:09.000000000","message":"Done","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":252,"context_line":"    @abstractmethod"},{"line_number":253,"context_line":"    def create_securitygrouprule(self, context, securitygrouprule):"},{"line_number":254,"context_line":"        pass"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @abstractmethod"},{"line_number":257,"context_line":"    def delete_securitygrouprule(self, context, sgrid):"},{"line_number":258,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FKOw%3D","line":255,"updated":"2012-10-10 11:48:08.000000000","message":"If my understanding is correct, update_securitygrouprule() is needed since use \"create_resource\" expects \"update_*\".","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    @abstractmethod"},{"line_number":253,"context_line":"    def create_securitygrouprule(self, context, securitygrouprule):"},{"line_number":254,"context_line":"        pass"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @abstractmethod"},{"line_number":257,"context_line":"    def delete_securitygrouprule(self, context, sgrid):"},{"line_number":258,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FJ%2Bw%3D","line":255,"in_reply_to":"AAAALH%2F%2FKOw%3D","updated":"2012-10-10 18:29:09.000000000","message":"If you try to do a PUT to any of these resources quantum returns: {\"QuantumError\": \"Cannot update read-only attribute name\"}, In grizzly we can add an update if we think we need it.","commit_id":"a01f653ae3eff21e63f6f9abe7ab661095a7c24a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":126,"context_line":"                      \u0027is_visible\u0027: True,"},{"line_number":127,"context_line":"                      \u0027validate\u0027: {\u0027type:values\u0027: [\u0027ingress\u0027, \u0027egress\u0027]}},"},{"line_number":128,"context_line":"        \u0027protocol\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":129,"context_line":"                     \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":130,"context_line":"        \u0027port_range_min\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":131,"context_line":"                           \u0027convert_to\u0027: convert_validate_port_value,"},{"line_number":132,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FJfE%3D","line":129,"updated":"2012-10-11 07:04:41.000000000","message":"\u0027protocol\u0027 field is changed to \u0027string\u0027 in this patch set, but value checks are also removed. Who validates a value of protocol is acceptable?\n\nSince which protocols are supported depends on a implementaiton, is an individual plugin implementation responsible for it?","commit_id":"e22be84d9717ff202de4abcd32ee737d866a336e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                      \u0027is_visible\u0027: True,"},{"line_number":127,"context_line":"                      \u0027validate\u0027: {\u0027type:values\u0027: [\u0027ingress\u0027, \u0027egress\u0027]}},"},{"line_number":128,"context_line":"        \u0027protocol\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":129,"context_line":"                     \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":130,"context_line":"        \u0027port_range_min\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":131,"context_line":"                           \u0027convert_to\u0027: convert_validate_port_value,"},{"line_number":132,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FJe0%3D","line":129,"in_reply_to":"AAAALH%2F%2FJfE%3D","updated":"2012-10-11 07:13:53.000000000","message":"Since it depends on the plugin implementation I think we should enforce it in the plugin for now.","commit_id":"e22be84d9717ff202de4abcd32ee737d866a336e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":94,"context_line":"    message \u003d _(\"Security group rule exists %(rule)s\")"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def convert_validate_port_value(port):"},{"line_number":98,"context_line":"    try:"},{"line_number":99,"context_line":"        return int(port)"},{"line_number":100,"context_line":"    except TypeError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJYw%3D","line":97,"updated":"2012-10-11 14:20:17.000000000","message":"Should this check that it is less than 65535?","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    message \u003d _(\"Security group rule exists %(rule)s\")"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def convert_validate_port_value(port):"},{"line_number":98,"context_line":"    try:"},{"line_number":99,"context_line":"        return int(port)"},{"line_number":100,"context_line":"    except TypeError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJOk%3D","line":97,"in_reply_to":"AAAALH%2F%2FJYw%3D","updated":"2012-10-12 05:33:07.000000000","message":"Done","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":131,"context_line":"               \u0027validate\u0027: {\u0027type:regex\u0027: attr.UUID_PATTERN},"},{"line_number":132,"context_line":"               \u0027is_visible\u0027: True},"},{"line_number":133,"context_line":"        # external_id can be used to be backwards compatible with nova"},{"line_number":134,"context_line":"        \u0027external_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":135,"context_line":"                        \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":136,"context_line":"        \u0027parent_group_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJYk%3D","line":133,"updated":"2012-10-11 14:20:17.000000000","message":"is this a uuid?","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":131,"context_line":"               \u0027validate\u0027: {\u0027type:regex\u0027: attr.UUID_PATTERN},"},{"line_number":132,"context_line":"               \u0027is_visible\u0027: True},"},{"line_number":133,"context_line":"        # external_id can be used to be backwards compatible with nova"},{"line_number":134,"context_line":"        \u0027external_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":135,"context_line":"                        \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":136,"context_line":"        \u0027parent_group_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJNo%3D","line":133,"in_reply_to":"AAAALH%2F%2FJYk%3D","updated":"2012-10-12 05:33:07.000000000","message":"Unfortunately nova uses an int not a uuid for this.","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # external_id can be used to be backwards compatible with nova"},{"line_number":134,"context_line":"        \u0027external_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":135,"context_line":"                        \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":136,"context_line":"        \u0027parent_group_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":137,"context_line":"                            \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True},"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        \u0027group_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJaA%3D","line":136,"updated":"2012-10-11 13:48:32.000000000","message":"I know this is legacy (from nova db column name), but \"group_id\" or \"security_group_id\" sounds more right to me here.","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # external_id can be used to be backwards compatible with nova"},{"line_number":134,"context_line":"        \u0027external_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":135,"context_line":"                        \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":136,"context_line":"        \u0027parent_group_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":137,"context_line":"                            \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True},"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        \u0027group_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJNk%3D","line":136,"in_reply_to":"AAAALH%2F%2FJaA%3D","updated":"2012-10-12 05:33:07.000000000","message":"changed to security_group_id","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"unresolved":false,"context_lines":[{"line_number":136,"context_line":"        \u0027parent_group_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":137,"context_line":"                            \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True},"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        \u0027group_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":140,"context_line":"                     \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":141,"context_line":"        \u0027direction\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":142,"context_line":"                      \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJag%3D","line":139,"updated":"2012-10-11 13:48:32.000000000","message":"How about \"source_group_id\" or something to differentiate better than the container SG above? It\u0027s confusing with \"parent_group_id\". Actually, Amazon uses \"IpPermissions.n.Groups.m.GroupId\" vs GroupId according to their API ref:\nhttp://docs.amazonwebservices.com/AWSEC2/latest/APIReference/ApiReference-query-AuthorizeSecurityGroupIngress.html","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        \u0027parent_group_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":137,"context_line":"                            \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True},"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        \u0027group_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":140,"context_line":"                     \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":141,"context_line":"        \u0027direction\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":142,"context_line":"                      \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJNg%3D","line":139,"in_reply_to":"AAAALH%2F%2FJag%3D","updated":"2012-10-12 05:33:07.000000000","message":"changed to source_group_id","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":141,"context_line":"        \u0027direction\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":142,"context_line":"                      \u0027is_visible\u0027: True,"},{"line_number":143,"context_line":"                      \u0027validate\u0027: {\u0027type:values\u0027: [\u0027ingress\u0027, \u0027egress\u0027]}},"},{"line_number":144,"context_line":"        \u0027protocol\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":145,"context_line":"                     \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":146,"context_line":"        \u0027port_range_min\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":147,"context_line":"                           \u0027convert_to\u0027: convert_validate_port_value,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJYo%3D","line":144,"updated":"2012-10-11 14:20:17.000000000","message":"should check valid protocol values","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        \u0027direction\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":142,"context_line":"                      \u0027is_visible\u0027: True,"},{"line_number":143,"context_line":"                      \u0027validate\u0027: {\u0027type:values\u0027: [\u0027ingress\u0027, \u0027egress\u0027]}},"},{"line_number":144,"context_line":"        \u0027protocol\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":145,"context_line":"                     \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":146,"context_line":"        \u0027port_range_min\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":147,"context_line":"                           \u0027convert_to\u0027: convert_validate_port_value,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJNc%3D","line":144,"in_reply_to":"AAAALH%2F%2FJYo%3D","updated":"2012-10-12 05:33:07.000000000","message":"This is actually done in the plugin right now since not all plugins are going to be able to support every protocol.","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":149,"context_line":"        \u0027port_range_max\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":150,"context_line":"                           \u0027convert_to\u0027: convert_validate_port_value,"},{"line_number":151,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":152,"context_line":"        \u0027ethertype\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":153,"context_line":"                      \u0027is_visible\u0027: True, \u0027default\u0027: \u0027IPv4\u0027},"},{"line_number":154,"context_line":"        \u0027ip_prefix\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":155,"context_line":"                      \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJYs%3D","line":152,"updated":"2012-10-11 14:20:17.000000000","message":"maybe it is a good idea to have test cases for the valid ethernet types?","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"unresolved":false,"context_lines":[{"line_number":151,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":152,"context_line":"        \u0027ethertype\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":153,"context_line":"                      \u0027is_visible\u0027: True, \u0027default\u0027: \u0027IPv4\u0027},"},{"line_number":154,"context_line":"        \u0027ip_prefix\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":155,"context_line":"                      \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":156,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":157,"context_line":"                      \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJaU%3D","line":154,"updated":"2012-10-11 13:48:32.000000000","message":"\"source_ip_prefix\" or something? (if you agree with the suggestion above to be consistent)","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":152,"context_line":"        \u0027ethertype\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":153,"context_line":"                      \u0027is_visible\u0027: True, \u0027default\u0027: \u0027IPv4\u0027},"},{"line_number":154,"context_line":"        \u0027ip_prefix\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":155,"context_line":"                      \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":156,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":157,"context_line":"                      \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJNY%3D","line":154,"in_reply_to":"AAAALH%2F%2FJaU%3D","updated":"2012-10-12 05:33:07.000000000","message":"Done","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"unresolved":false,"context_lines":[{"line_number":152,"context_line":"        \u0027ethertype\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":153,"context_line":"                      \u0027is_visible\u0027: True, \u0027default\u0027: \u0027IPv4\u0027},"},{"line_number":154,"context_line":"        \u0027ip_prefix\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":155,"context_line":"                      \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":156,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":157,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":158,"context_line":"                      \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJbE%3D","line":155,"updated":"2012-10-11 13:48:32.000000000","message":"What does the default value None semantically mean here? Does it mean \u00270.0.0.0/0\u0027 or should API error out if both group_id and ip_prefix are not present? \nWould be nice if validation occurs at API level as opposed to plugin level.","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        \u0027ethertype\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":153,"context_line":"                      \u0027is_visible\u0027: True, \u0027default\u0027: \u0027IPv4\u0027},"},{"line_number":154,"context_line":"        \u0027ip_prefix\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":155,"context_line":"                      \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":156,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":157,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":158,"context_line":"                      \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJNI%3D","line":155,"in_reply_to":"AAAALH%2F%2FJbE%3D","updated":"2012-10-12 05:33:07.000000000","message":"I agree it would be nice if this was done at the API layer though we don\u0027t have this functionality yet. \n\nIt doesn\u0027t mean 0.0.0.0/0 if both group_id/ip_prefex are specified the validation is done in the plugin to raise an error.","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":21,"context_line":"from quantum.common import exceptions as qexception"},{"line_number":22,"context_line":"from quantum.extensions import extensions"},{"line_number":23,"context_line":"from quantum.openstack.common import cfg"},{"line_number":24,"context_line":"from quantum import manager"},{"line_number":25,"context_line":"from quantum import quota"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FZ4%3D","line":24,"updated":"2012-10-22 22:50:10.000000000","message":"HACKING - absolute import ordering requires this line to appear before the quantum.openstack import","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from quantum.common import exceptions as qexception"},{"line_number":22,"context_line":"from quantum.extensions import extensions"},{"line_number":23,"context_line":"from quantum.openstack.common import cfg"},{"line_number":24,"context_line":"from quantum import manager"},{"line_number":25,"context_line":"from quantum import quota"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Bq8%3D","line":24,"in_reply_to":"AAAALn%2F%2F%2FZ4%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":108,"context_line":"    try:"},{"line_number":109,"context_line":"        val \u003d int(port)"},{"line_number":110,"context_line":"        # Valid port range"},{"line_number":111,"context_line":"        if  val \u003c 0 or val \u003e 65535:"},{"line_number":112,"context_line":"            raise SecurityGroupInvalidPortValue(port\u003dport)"},{"line_number":113,"context_line":"        return val"},{"line_number":114,"context_line":"    except TypeError:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAALn%2F%2F85g%3D","line":111,"updated":"2012-10-25 04:33:42.000000000","message":"consider:\nif port is None not port:\n  return None\n\ntry:\n  val \u003d int(port)\nexcept (ValueError, TypeError):\n  raise SecurityGroupInvalidPortValue(port\u003dport)\n\nif 0 \u003c\u003d val \u003c\u003d 65535:\n   return val\nelse:\n   raise SecurityGroupInvalidPortValue(port\u003dport)","commit_id":"e4a63e41a5902b87f064b5352b91bac184857586"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    try:"},{"line_number":109,"context_line":"        val \u003d int(port)"},{"line_number":110,"context_line":"        # Valid port range"},{"line_number":111,"context_line":"        if  val \u003c 0 or val \u003e 65535:"},{"line_number":112,"context_line":"            raise SecurityGroupInvalidPortValue(port\u003dport)"},{"line_number":113,"context_line":"        return val"},{"line_number":114,"context_line":"    except TypeError:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAALn%2F%2F840%3D","line":111,"in_reply_to":"AAAALn%2F%2F85g%3D","updated":"2012-10-25 04:49:33.000000000","message":"Done","commit_id":"e4a63e41a5902b87f064b5352b91bac184857586"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":147,"context_line":"    try:"},{"line_number":148,"context_line":"        val \u003d int(external_id)"},{"line_number":149,"context_line":"    except (ValueError, TypeError):"},{"line_number":150,"context_line":"        print external_id"},{"line_number":151,"context_line":"        raise SecurityGroupInvalidExternalID()"},{"line_number":152,"context_line":"    if cfg.CONF.SECURITYGROUP.proxy_mode and not external_id:"},{"line_number":153,"context_line":"        raise SecurityGroupProxyMode()"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALn%2F%2F7SQ%3D","line":150,"updated":"2012-10-26 18:15:25.000000000","message":"Please remove.","commit_id":"6e7ed05361edfe5144f7955b00bb53320dda641f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    try:"},{"line_number":148,"context_line":"        val \u003d int(external_id)"},{"line_number":149,"context_line":"    except (ValueError, TypeError):"},{"line_number":150,"context_line":"        print external_id"},{"line_number":151,"context_line":"        raise SecurityGroupInvalidExternalID()"},{"line_number":152,"context_line":"    if cfg.CONF.SECURITYGROUP.proxy_mode and not external_id:"},{"line_number":153,"context_line":"        raise SecurityGroupProxyMode()"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALn%2F%2F7R4%3D","line":150,"in_reply_to":"AAAALn%2F%2F7SQ%3D","updated":"2012-10-26 18:20:50.000000000","message":"Done","commit_id":"6e7ed05361edfe5144f7955b00bb53320dda641f"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":148,"context_line":"        val \u003d int(external_id)"},{"line_number":149,"context_line":"    except (ValueError, TypeError):"},{"line_number":150,"context_line":"        print external_id"},{"line_number":151,"context_line":"        raise SecurityGroupInvalidExternalID()"},{"line_number":152,"context_line":"    if cfg.CONF.SECURITYGROUP.proxy_mode and not external_id:"},{"line_number":153,"context_line":"        raise SecurityGroupProxyMode()"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALn%2F%2F7SI%3D","line":151,"updated":"2012-10-26 18:15:25.000000000","message":"Should the external id in the exception for debugging purposes?","commit_id":"6e7ed05361edfe5144f7955b00bb53320dda641f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        val \u003d int(external_id)"},{"line_number":149,"context_line":"    except (ValueError, TypeError):"},{"line_number":150,"context_line":"        print external_id"},{"line_number":151,"context_line":"        raise SecurityGroupInvalidExternalID()"},{"line_number":152,"context_line":"    if cfg.CONF.SECURITYGROUP.proxy_mode and not external_id:"},{"line_number":153,"context_line":"        raise SecurityGroupProxyMode()"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALn%2F%2F7R0%3D","line":151,"in_reply_to":"AAAALn%2F%2F7SI%3D","updated":"2012-10-26 18:20:50.000000000","message":"Done","commit_id":"6e7ed05361edfe5144f7955b00bb53320dda641f"}],"quantum/tests/unit/test_db_plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        for arg in (\u0027admin_state_up\u0027, \u0027device_id\u0027,"},{"line_number":259,"context_line":"                    \u0027mac_address\u0027, \u0027name\u0027, \u0027fixed_ips\u0027,"},{"line_number":260,"context_line":"                    \u0027tenant_id\u0027, \u0027device_owner\u0027, \u0027securitygroups\u0027):"},{"line_number":261,"context_line":"            # Arg must be present and not empty"},{"line_number":262,"context_line":"            if arg in kwargs and kwargs[arg]:"},{"line_number":263,"context_line":"                data[\u0027port\u0027][arg] \u003d kwargs[arg]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJYc%3D","line":260,"updated":"2012-10-11 14:20:17.000000000","message":"securitygroups - does this not need to appear in the RESOURCE_ATTRIBUTE_MAP under the ports?","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        for arg in (\u0027admin_state_up\u0027, \u0027device_id\u0027,"},{"line_number":259,"context_line":"                    \u0027mac_address\u0027, \u0027name\u0027, \u0027fixed_ips\u0027,"},{"line_number":260,"context_line":"                    \u0027tenant_id\u0027, \u0027device_owner\u0027, \u0027securitygroups\u0027):"},{"line_number":261,"context_line":"            # Arg must be present and not empty"},{"line_number":262,"context_line":"            if arg in kwargs and kwargs[arg]:"},{"line_number":263,"context_line":"                data[\u0027port\u0027][arg] \u003d kwargs[arg]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FJNE%3D","line":260,"in_reply_to":"AAAALH%2F%2FJYc%3D","updated":"2012-10-12 05:33:07.000000000","message":"This is done in extension/securitygroup.py Line 164","commit_id":"3ac54bedf7a570f1f454f05dfd2c250bdcdfbb96"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def deserialize(self, content_type, response):"},{"line_number":162,"context_line":"        ctype \u003d \u0027application/%s\u0027 % content_type"},{"line_number":163,"context_line":"        return self._deserializers[ctype].deserialize(response.body)[\u0027body\u0027]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def _create_bulk(self, fmt, number, resource, data, name\u003d\u0027test\u0027, **kwargs):"},{"line_number":166,"context_line":"        \"\"\" Creates a bulk request for any kind of resource \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F%2BL0%3D","line":163,"updated":"2012-10-24 03:11:12.000000000","message":"This appears to be an unrelated change - please revert.","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def deserialize(self, content_type, response):"},{"line_number":162,"context_line":"        ctype \u003d \u0027application/%s\u0027 % content_type"},{"line_number":163,"context_line":"        return self._deserializers[ctype].deserialize(response.body)[\u0027body\u0027]"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def _create_bulk(self, fmt, number, resource, data, name\u003d\u0027test\u0027, **kwargs):"},{"line_number":166,"context_line":"        \"\"\" Creates a bulk request for any kind of resource \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F9cM%3D","line":163,"in_reply_to":"AAAALn%2F%2F%2BL0%3D","updated":"2012-10-24 19:04:03.000000000","message":"Done","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":258,"context_line":"        for arg in (\u0027admin_state_up\u0027, \u0027device_id\u0027,"},{"line_number":259,"context_line":"                    \u0027mac_address\u0027, \u0027name\u0027, \u0027fixed_ips\u0027,"},{"line_number":260,"context_line":"                    \u0027tenant_id\u0027, \u0027device_owner\u0027, \u0027security_groups\u0027):"},{"line_number":261,"context_line":"            # Arg must be present and not empty"},{"line_number":262,"context_line":"            if arg in kwargs and kwargs[arg]:"},{"line_number":263,"context_line":"                data[\u0027port\u0027][arg] \u003d kwargs[arg]"},{"line_number":264,"context_line":"        port_req \u003d self.new_create_request(\u0027ports\u0027, data, fmt)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F99w%3D","line":261,"updated":"2012-10-24 11:20:29.000000000","message":"Is this comment correct now? If so it is better to remove it.","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        for arg in (\u0027admin_state_up\u0027, \u0027device_id\u0027,"},{"line_number":259,"context_line":"                    \u0027mac_address\u0027, \u0027name\u0027, \u0027fixed_ips\u0027,"},{"line_number":260,"context_line":"                    \u0027tenant_id\u0027, \u0027device_owner\u0027, \u0027security_groups\u0027):"},{"line_number":261,"context_line":"            # Arg must be present and not empty"},{"line_number":262,"context_line":"            if arg in kwargs and kwargs[arg]:"},{"line_number":263,"context_line":"                data[\u0027port\u0027][arg] \u003d kwargs[arg]"},{"line_number":264,"context_line":"        port_req \u003d self.new_create_request(\u0027ports\u0027, data, fmt)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALn%2F%2F9cI%3D","line":261,"in_reply_to":"AAAALn%2F%2F99w%3D","updated":"2012-10-24 19:04:03.000000000","message":"It\u0027s still correct.","commit_id":"206a7055f9b892bf5a536e3aa1706ee89674740c"}],"quantum/tests/unit/test_extension_security_group.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":469,"context_line":"        self.deserialize(\u0027json\u0027, res)"},{"line_number":470,"context_line":"        self.assertEquals(res.status_int, 404)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    def test_create_security_group_rule_exteral_id_proxy_mode(self):"},{"line_number":473,"context_line":"        cfg.CONF.SECURITYGROUP.proxy_mode \u003d True"},{"line_number":474,"context_line":"        with self.security_group(external_id\u003d1) as sg:"},{"line_number":475,"context_line":"            rule \u003d {\u0027security_group_rule\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALn%2F%2F7SA%3D","line":472,"updated":"2012-10-26 18:15:25.000000000","message":"(Suggestion only) DRY - all 3 of these tests are largely duplicative.  Consider extracting common functionality into a helper method.","commit_id":"6e7ed05361edfe5144f7955b00bb53320dda641f"}],"quantum/tests/unit/test_extension_securitygroup.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import contextlib"},{"line_number":17,"context_line":"import itertools"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import unittest2"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FZo%3D","line":18,"updated":"2012-10-22 22:50:10.000000000","message":"HACKING - mock and unittest2 are 3rd-party imports.","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import contextlib"},{"line_number":17,"context_line":"import itertools"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import unittest2"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2Bqk%3D","line":18,"in_reply_to":"AAAALn%2F%2F%2FZo%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"from quantum.api.v2 import attributes"},{"line_number":25,"context_line":"from quantum.api.v2.router import APIRouter"},{"line_number":26,"context_line":"from quantum.common.test_lib import test_config"},{"line_number":27,"context_line":"from quantum.common import config"},{"line_number":28,"context_line":"from quantum import context"},{"line_number":29,"context_line":"from quantum.db import api as db"},{"line_number":30,"context_line":"from quantum.db import db_base_plugin_v2"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FZk%3D","line":27,"updated":"2012-10-22 22:50:10.000000000","message":"HACKING - use absolute import ordering","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a656251bb23f63d099e34e166020669ad9b0e3bb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from quantum.api.v2 import attributes"},{"line_number":25,"context_line":"from quantum.api.v2.router import APIRouter"},{"line_number":26,"context_line":"from quantum.common.test_lib import test_config"},{"line_number":27,"context_line":"from quantum.common import config"},{"line_number":28,"context_line":"from quantum import context"},{"line_number":29,"context_line":"from quantum.db import api as db"},{"line_number":30,"context_line":"from quantum.db import db_base_plugin_v2"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2BaA%3D","line":27,"in_reply_to":"AAAALn%2F%2F%2FZk%3D","updated":"2012-10-23 20:59:27.000000000","message":"Done","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":257,"context_line":"        super(SecurityGroupDBTestCase, self).setUp()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"class TestSecurityGroups(SecurityGroupDBTestCase):"},{"line_number":261,"context_line":"    def test_create_securitygroup(self):"},{"line_number":262,"context_line":"        name \u003d \u0027webservers\u0027"},{"line_number":263,"context_line":"        description \u003d \u0027my webservers\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FYE%3D","line":260,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) The majority of tests in this module are effectively at the integration level (the requirement to make REST requests is a giveaway).  Consider (for future efforts if not this one) writing unit tests that target only the functionality under test for the majority of the functionality and limit integration testing to one or two \u0027golden path\u0027 tests.  Test creation and maintenance using this methodology tends to provide more coverage for a given amount of effort.\n\nSee: The Testing Pyramid","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":335,"context_line":"        name \u003d \u0027webservers\u0027"},{"line_number":336,"context_line":"        description \u003d \u0027my webservers\u0027"},{"line_number":337,"context_line":"        with self.securitygroup(name, description) as sg:"},{"line_number":338,"context_line":"            security_group_id \u003d sg[\u0027securitygroup\u0027][\u0027id\u0027]"},{"line_number":339,"context_line":"            direction \u003d \"ingress\""},{"line_number":340,"context_line":"            source_ip_prefix \u003d \"10.0.0.0/24\""},{"line_number":341,"context_line":"            protocol \u003d \u0027tcp\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F%2FYs%3D","line":338,"updated":"2012-10-22 22:50:10.000000000","message":"(Suggestion only) Consider simplifying, e.g.\nkwargs \u003d dict(\n    source_ip_prefix\u003d\u002710.0.0.0/24\u0027,\n    security_group_id\u003dsg[\u0027securitygroup\u0027][\u0027id\u0027],\n    ...\n    )\nwith self.securitygrouprule(**kwargs) as rule:\n    for k, v in kwargs.iteritems():\n       pass","commit_id":"377d2b3c154a1c8cb9dfbb9d948449082b092694"}]}
