)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"726ac6bc5e81394a3fa4f441ce61bfe5056230b1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Trying to delete default security group from a"},{"line_number":10,"context_line":"non-admin user gives an error \"Removing default"},{"line_number":11,"context_line":"security group not allowed. (HTTP 400)"},{"line_number":12,"context_line":"(Request-ID: req-208b1911-99f6-411f-8429-e05051e71cba) \"."},{"line_number":13,"context_line":"But this messgae is not clear as the user does not"},{"line_number":14,"context_line":"get to know why is he not allowed to remove the"},{"line_number":15,"context_line":"defaulty security group."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a961159_2385a7ce","line":12,"updated":"2014-12-23 13:11:16.000000000","message":"a request id is not really useful in a commit message","commit_id":"fde85bdb146e222cb8b3ca18028f6099962feb0a"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"ce6188c6baa7e4314a7dedac67d63477fbfd55a7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"non-admin user gives an error \"Removing default"},{"line_number":11,"context_line":"security group not allowed. (HTTP 400)"},{"line_number":12,"context_line":"(Request-ID: req-208b1911-99f6-411f-8429-e05051e71cba) \"."},{"line_number":13,"context_line":"But this messgae is not clear as the user does not"},{"line_number":14,"context_line":"get to know why is he not allowed to remove the"},{"line_number":15,"context_line":"defaulty security group."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a961159_a3a35741","line":13,"updated":"2014-12-23 13:17:28.000000000","message":"nit: messgae -\u003e message","commit_id":"fde85bdb146e222cb8b3ca18028f6099962feb0a"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"ce6188c6baa7e4314a7dedac67d63477fbfd55a7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"(Request-ID: req-208b1911-99f6-411f-8429-e05051e71cba) \"."},{"line_number":13,"context_line":"But this messgae is not clear as the user does not"},{"line_number":14,"context_line":"get to know why is he not allowed to remove the"},{"line_number":15,"context_line":"defaulty security group."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"So updated the error message to give a more optimal"},{"line_number":18,"context_line":"message to the user."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a961159_c365c31e","line":15,"updated":"2014-12-23 13:17:28.000000000","message":"nit: defaulty -\u003e default","commit_id":"fde85bdb146e222cb8b3ca18028f6099962feb0a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ec6e12c48ccb162e9511cf98355e08dd4c9ca625","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Confusing message deleting default security group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Trying to delete default security group from a"},{"line_number":10,"context_line":"non-admin user gives an error \"Removing default"},{"line_number":11,"context_line":"security group not allowed. (HTTP 400)."},{"line_number":12,"context_line":"But this message is not clear as the user does not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a961159_d74440b9","line":9,"updated":"2014-12-30 08:21:15.000000000","message":"nit: line length could be a bit higher (smth like 70 or 72 are usual candidates for line wrap).","commit_id":"dc9ea900ac5bdc82e641b5d7a11148a14f60293b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ec6e12c48ccb162e9511cf98355e08dd4c9ca625","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"So updated the error message to give a more optimal"},{"line_number":17,"context_line":"message to the user."},{"line_number":18,"context_line":"Closes-Bug: #1403743"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I25744b854371208d68a5cbdcf83079db7c54f96f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a961159_f7105cad","line":18,"updated":"2014-12-30 08:21:15.000000000","message":"nit: we usually group Closes-Bug with Change-Id, and separate the actual commit message from the section with a newline.","commit_id":"dc9ea900ac5bdc82e641b5d7a11148a14f60293b"}],"neutron/extensions/securitygroup.py":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"f84b32b271c55b1b535da186650e3f3c5ea1a33d","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SecurityGroupCannotRemoveDefault(qexception.InUse):"},{"line_number":57,"context_line":"    message \u003d _(\"Only admin allowed to remove default security group.\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class SecurityGroupCannotUpdateDefault(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_1ea1f2f7","line":57,"updated":"2014-12-22 19:20:30.000000000","message":"Nit - \"Only an admin is allowed to remove the default security group.\"","commit_id":"f399424d8f794a408e4529c1e209441500d56452"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"726ac6bc5e81394a3fa4f441ce61bfe5056230b1","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SecurityGroupCannotRemoveDefault(qexception.InUse):"},{"line_number":57,"context_line":"    message \u003d _(\"Only an admin is allowed to remove the default\""},{"line_number":58,"context_line":"                \"security group.\")"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class SecurityGroupCannotUpdateDefault(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_c37b03f3","line":58,"updated":"2014-12-23 13:11:16.000000000","message":"context.is_admin can be achieved also for non-admin roles by tweaking policy.json appropriately.\n\nTherefore \"insufficient rights for removing default security group\" seems more appropriate","commit_id":"fde85bdb146e222cb8b3ca18028f6099962feb0a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ec6e12c48ccb162e9511cf98355e08dd4c9ca625","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SecurityGroupCannotRemoveDefault(qexception.InUse):"},{"line_number":57,"context_line":"    message \u003d _(\"Only an admin is allowed to remove the default\""},{"line_number":58,"context_line":"                \"security group.\")"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_973ab832","line":57,"updated":"2014-12-30 08:21:15.000000000","message":"missing space between \u0027default\u0027 and \u0027security\u0027","commit_id":"dc9ea900ac5bdc82e641b5d7a11148a14f60293b"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6cb33cefd768cae80529e2e53a392ba55f0bc895","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SecurityGroupCannotRemoveDefault(qexception.InUse):"},{"line_number":57,"context_line":"    message \u003d _(\"Only an admin is allowed to remove the default\""},{"line_number":58,"context_line":"                \"security group.\")"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class SecurityGroupCannotUpdateDefault(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_ca8a21be","line":58,"updated":"2014-12-24 05:41:55.000000000","message":"I agree Salvatore comment in patch set 3.","commit_id":"dc9ea900ac5bdc82e641b5d7a11148a14f60293b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ec6e12c48ccb162e9511cf98355e08dd4c9ca625","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SecurityGroupCannotRemoveDefault(qexception.InUse):"},{"line_number":57,"context_line":"    message \u003d _(\"Only an admin is allowed to remove the default\""},{"line_number":58,"context_line":"                \"security group.\")"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class SecurityGroupCannotUpdateDefault(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_b747b4bb","line":58,"updated":"2014-12-30 08:21:15.000000000","message":"I agree with Salv that you should change the text.","commit_id":"dc9ea900ac5bdc82e641b5d7a11148a14f60293b"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1142f345d69c84300c8df4aab45708fe83dc3e8a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    message \u003d _(\"Security Group %(id)s in use.\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SecurityGroupCannotRemoveDefault(qexception.InUse):"},{"line_number":57,"context_line":"    message \u003d _(\"Insufficient rights for removing default security group.\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_b6ca3e44","line":56,"updated":"2014-12-31 11:06:37.000000000","message":"(no action required): According to the message, the class should inherit qexception.Conflict but it brakes backward compatibility","commit_id":"907693ea9b13819f733462d88fcbc096a5926a4d"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"197941d9fb269e715706d1b1113a6c8ddedc9cd0","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SecurityGroupCannotRemoveDefault(qexception.InUse):"},{"line_number":57,"context_line":"    message \u003d _(\"Insufficient rights for removing default security group.\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class SecurityGroupCannotUpdateDefault(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_d92a80e6","line":57,"updated":"2015-01-05 03:20:41.000000000","message":"What is the difference between saying: \"not allowed\" to insufficient rights\"? For me None!","commit_id":"907693ea9b13819f733462d88fcbc096a5926a4d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"e4533be1d5cc9ff1f5cdae4f8e97df1f02eba0e2","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SecurityGroupCannotRemoveDefault(qexception.InUse):"},{"line_number":57,"context_line":"    message \u003d _(\"Insufficient rights for removing default security group.\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class SecurityGroupCannotUpdateDefault(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_947baff3","line":57,"in_reply_to":"3a961159_72f9334d","updated":"2015-01-12 01:37:44.000000000","message":"I think this is fine and a good improvement.","commit_id":"907693ea9b13819f733462d88fcbc096a5926a4d"},{"author":{"_account_id":12140,"name":"Abhishek Talwar","email":"abhishek.talwar@tcs.com","username":"abhishek.talwar"},"change_message_id":"97e89cf1d17a5933ca215234dd05fca26fa3d076","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SecurityGroupCannotRemoveDefault(qexception.InUse):"},{"line_number":57,"context_line":"    message \u003d _(\"Insufficient rights for removing default security group.\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class SecurityGroupCannotUpdateDefault(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_14c2eae8","line":57,"in_reply_to":"3a961159_8e2ee98a","updated":"2015-01-06 05:17:23.000000000","message":"Hi Ihar,\n\nIf you can look at the comment given by Salvatore Orlando in patch set 3 and relate this change according to that.\n\nThanks and Regards\nAbhishek Talwar","commit_id":"907693ea9b13819f733462d88fcbc096a5926a4d"},{"author":{"_account_id":12140,"name":"Abhishek Talwar","email":"abhishek.talwar@tcs.com","username":"abhishek.talwar"},"change_message_id":"72a35d762e17d5edde15fec10157ded5b130a381","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SecurityGroupCannotRemoveDefault(qexception.InUse):"},{"line_number":57,"context_line":"    message \u003d _(\"Insufficient rights for removing default security group.\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class SecurityGroupCannotUpdateDefault(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_72f9334d","line":57,"in_reply_to":"3a961159_d92a80e6","updated":"2015-01-08 12:05:16.000000000","message":"Hi Edgar,\n\nGiving a message as \"Insufficient rights\" would make the user understand that he does not have the rights to fulfill the operation and that need more rights while \"not allowed\" does not make it clear that why is the user not allowed to perform the operation.","commit_id":"907693ea9b13819f733462d88fcbc096a5926a4d"},{"author":{"_account_id":12140,"name":"Abhishek Talwar","email":"abhishek.talwar@tcs.com","username":"abhishek.talwar"},"change_message_id":"97e89cf1d17a5933ca215234dd05fca26fa3d076","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SecurityGroupCannotRemoveDefault(qexception.InUse):"},{"line_number":57,"context_line":"    message \u003d _(\"Insufficient rights for removing default security group.\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class SecurityGroupCannotUpdateDefault(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_54b8f274","line":57,"in_reply_to":"3a961159_d92a80e6","updated":"2015-01-06 05:17:23.000000000","message":"Hi Ihar,\n\nIf you can look at the comment given by Salvatore Orlando in patch set 3 and relate this change according to that.\n\nThanks and Regards\nAbhishek Talwar","commit_id":"907693ea9b13819f733462d88fcbc096a5926a4d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5cd4cae2b449282c0084efa477f504ee77c7e77f","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SecurityGroupCannotRemoveDefault(qexception.InUse):"},{"line_number":57,"context_line":"    message \u003d _(\"Insufficient rights for removing default security group.\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class SecurityGroupCannotUpdateDefault(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_8e2ee98a","line":57,"in_reply_to":"3a961159_d92a80e6","updated":"2015-01-05 10:00:38.000000000","message":"The main point is that it\u0027s not just about admins. It could also say \u0027Permission denied while removing...\u0027 or smth like that.\n\nI actually think that permissions are more commonly used to refer to access rules and not rights.","commit_id":"907693ea9b13819f733462d88fcbc096a5926a4d"}]}