)]}'
{"neutron/tests/common/agents/l3_agent.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"755ecf37f94cd44603be1be9a569109162d9d315","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        super(TestL3NATAgent, self).__init__(host, conf)"},{"line_number":24,"context_line":"        self.event_observers.observers \u003d set("},{"line_number":25,"context_line":"            observer.__class__(self) for observer in"},{"line_number":26,"context_line":"            self.event_observers.observers)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_ns_name(self, router_id):"},{"line_number":29,"context_line":"        ns_name \u003d super(TestL3NATAgent, self).get_ns_name(router_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_7ec04050","line":26,"updated":"2014-12-22 13:34:22.000000000","message":"I think it would be better to explicitly set the new agent in the singleton(s) or clear the singleton instances so that they are re-created, versus patching them here. It\u0027s not as obvious to the reader of the final unit test case.","commit_id":"1e562decdc03295dec4cb37d26162e5d9aa31079"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d8892c2d9a2e815fd9a8c0ab376cce9d1b1edfef","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        super(TestL3NATAgent, self).__init__(host, conf)"},{"line_number":24,"context_line":"        self.event_observers.observers \u003d set("},{"line_number":25,"context_line":"            observer.__class__(self) for observer in"},{"line_number":26,"context_line":"            self.event_observers.observers)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_ns_name(self, router_id):"},{"line_number":29,"context_line":"        ns_name \u003d super(TestL3NATAgent, self).get_ns_name(router_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_9756ae28","line":26,"in_reply_to":"3a961159_7ec04050","updated":"2014-12-22 15:07:48.000000000","message":"I\u0027m not 100% with this fix either. It obviously makes you wonder if we really want the observers to be singletons: Conceptually I still think they should be, and to solve this specific problem, yes, we absolutely can update the agent that the observer singletons are pointing at instead of re-creating the observers - I see why that would be safer. Let\u0027s think what\u0027s the best way to deal with this together with Carl and anyone who\u0027s interested, then we can file another fix-up, we just have to make sure that the functional job stays unbroken :)","commit_id":"1e562decdc03295dec4cb37d26162e5d9aa31079"}]}
