)]}'
{"neutron/plugins/plumgrid/plumgrid_plugin/plumgrid_plugin.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"76735207cc0fd58ded94c9377c290ecac362a155","unresolved":false,"context_lines":[{"line_number":370,"context_line":"            except Exception as err_message:"},{"line_number":371,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        return tenant_id"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def update_subnet(self, context, subnet_id, subnet):"},{"line_number":376,"context_line":"        \"\"\"Update subnet core Neutron API.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_674fde34","line":373,"updated":"2014-12-22 06:42:29.000000000","message":"we should not return stuff. in fact, to unit test it, just to mock plumlib.delete_subnet to make sure the right tenant_id is passed.","commit_id":"bb80410bd38309fc85b0aa140b8ff69584f17825"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8ac46f5fb202bd82611291e1ed494dc0ec6f0141","unresolved":false,"context_lines":[{"line_number":370,"context_line":"            except Exception as err_message:"},{"line_number":371,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        return tenant_id"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def update_subnet(self, context, subnet_id, subnet):"},{"line_number":376,"context_line":"        \"\"\"Update subnet core Neutron API.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_f800d367","line":373,"updated":"2014-12-21 21:50:45.000000000","message":"why do you return the tenant here? This method is not supposed to return anything.","commit_id":"bb80410bd38309fc85b0aa140b8ff69584f17825"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"f2ab8c22d8e657cc4d4dc8e27799cd02fd122f53","unresolved":false,"context_lines":[{"line_number":370,"context_line":"            except Exception as err_message:"},{"line_number":371,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        return tenant_id"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def update_subnet(self, context, subnet_id, subnet):"},{"line_number":376,"context_line":"        \"\"\"Update subnet core Neutron API.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_5c7b94bd","line":373,"in_reply_to":"3a961159_674fde34","updated":"2014-12-22 09:27:28.000000000","message":"thanks for the pointer gongysh. mock plumlib.delete_subnet wouldn\u0027t help either. I have used get_network for unit test and that catches the issue. Coming in the next patch shortly.","commit_id":"bb80410bd38309fc85b0aa140b8ff69584f17825"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"5e7b373f6064ed81db2df3cfece127b013a18a32","unresolved":false,"context_lines":[{"line_number":370,"context_line":"            except Exception as err_message:"},{"line_number":371,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        return tenant_id"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def update_subnet(self, context, subnet_id, subnet):"},{"line_number":376,"context_line":"        \"\"\"Update subnet core Neutron API.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_4c5209df","line":373,"in_reply_to":"3a961159_f800d367","updated":"2014-12-22 05:48:41.000000000","message":"Agree. I added this to get a unit test case out of the bug. Can you please suggest a method otherwise so UT can be added as well.","commit_id":"bb80410bd38309fc85b0aa140b8ff69584f17825"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"208a222ddf956f6c3323cbcba3d61e9dce105473","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        sub_db \u003d self._get_subnet(context, subnet_id)"},{"line_number":359,"context_line":"        net_id \u003d sub_db[\"network_id\"]"},{"line_number":360,"context_line":"        net_db \u003d self.get_network(context, net_id)"},{"line_number":361,"context_line":"        tenant_id \u003d net_db[\"tenant_id\"]"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":364,"context_line":"            # Plugin DB - Subnet Delete"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_4fc2f853","line":361,"updated":"2014-12-22 09:47:17.000000000","message":"It is tricky, just remind of subnet\u0027s tenant id possibly being different with net\u0027s one.","commit_id":"6746f49e236f18f78692701fd818b2a9e318c2cf"}]}