)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c8f46fed0e8721ef027d016c800b89ac601b835d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move L3 agent constants to a specific module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"L3 agent module imports metadata driver module which will use (in"},{"line_number":10,"context_line":"daughter change) L3 agent constants. That\u0027s why L3 agent constants"},{"line_number":11,"context_line":"must be moved outside of L3 agent module to avoid an import loop"},{"line_number":12,"context_line":"between the 2 modules."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a961159_3bd080c8","line":9,"updated":"2014-12-22 19:06:34.000000000","message":"I\u0027d like to fix this instead by moving the constants from the L3 agent file to router_info.py (will soon be renamed router.py).  This was a step that I was going to eventually make with this [1] and other follow-on efforts.  The import loop should be gone at that point.  Also, this conflicts with this one [2].\n\n [1] https://review.openstack.org/#/c/142863/\n [2] https://review.openstack.org/#/c/142946/","commit_id":"b77e4ef5c52d351a1f7b105f1779cb9fae8f24e6"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"4d91fb0cf59d2a2d842339932eaebb179adfaff7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move L3 agent constants to a specific module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"L3 agent module imports metadata driver module which will use (in"},{"line_number":10,"context_line":"daughter change) L3 agent constants. That\u0027s why L3 agent constants"},{"line_number":11,"context_line":"must be moved outside of L3 agent module to avoid an import loop"},{"line_number":12,"context_line":"between the 2 modules."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a961159_de8ccad9","line":9,"in_reply_to":"3a961159_3bd080c8","updated":"2014-12-22 19:52:56.000000000","message":"Done\n\n[1] will be rebased to become a daughter change","commit_id":"b77e4ef5c52d351a1f7b105f1779cb9fae8f24e6"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"691a71dabb4c896235dda4d528d33d34225147e7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Move L3 agent constants to L3 router_info module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"L3 agent module imports metadata driver module which will use (in"},{"line_number":10,"context_line":"daughter change) L3 agent constants. That\u0027s why L3 agent constants"},{"line_number":11,"context_line":"must be moved outside of L3 agent module to avoid an import loop"},{"line_number":12,"context_line":"between the 2 modules."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a961159_df7fafdd","line":10,"updated":"2015-01-05 19:06:54.000000000","message":"This comment is mis-leading.  These aren\u0027t agent constants.  These are router constants.  Since we\u0027re trying to decouple the router from the agent this is a logical step.  This would be better as \"That\u0027s why the L3 router constants must be moved out of the L3 agent module.\"","commit_id":"0ac1e541b0f187c91b37240172d9cde19995f3b5"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"29e7f982ab3ffc7b9b50b41676ac36f2ccee9367","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Move L3 agent constants to L3 router_info module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"L3 agent module imports metadata driver module which will use (in"},{"line_number":10,"context_line":"daughter change) L3 agent constants. That\u0027s why L3 agent constants"},{"line_number":11,"context_line":"must be moved outside of L3 agent module to avoid an import loop"},{"line_number":12,"context_line":"between the 2 modules."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a961159_5b1d6872","line":10,"in_reply_to":"3a961159_df7fafdd","updated":"2015-01-06 22:25:31.000000000","message":"Done","commit_id":"0ac1e541b0f187c91b37240172d9cde19995f3b5"}],"neutron/agent/l3/agent.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"1a6cf161858ef1a87686f71d5f2661aeaaa80222","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from neutron.openstack.common import loopingcall"},{"line_number":54,"context_line":"from neutron.openstack.common import periodic_task"},{"line_number":55,"context_line":"from neutron.openstack.common import service"},{"line_number":56,"context_line":"from neutron import service as neutron_service"},{"line_number":57,"context_line":"from neutron.services import advanced_service as adv_svc"},{"line_number":58,"context_line":"try:"},{"line_number":59,"context_line":"    from neutron_fwaas.services.firewall.agents.l3reference \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_253db98f","side":"PARENT","line":56,"updated":"2014-12-22 23:45:10.000000000","message":"Why agent.py? I\u0027m wondering if agent/l3/constants.py is in order?","commit_id":"49d6879bc9b57c1bdd5c4f3da80b570e62327cae"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"42749f12911c9b2ae5102fb8c780a1bc441a0393","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from neutron.openstack.common import loopingcall"},{"line_number":54,"context_line":"from neutron.openstack.common import periodic_task"},{"line_number":55,"context_line":"from neutron.openstack.common import service"},{"line_number":56,"context_line":"from neutron import service as neutron_service"},{"line_number":57,"context_line":"from neutron.services import advanced_service as adv_svc"},{"line_number":58,"context_line":"try:"},{"line_number":59,"context_line":"    from neutron_fwaas.services.firewall.agents.l3reference \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_aebd7704","side":"PARENT","line":56,"in_reply_to":"3a961159_253db98f","updated":"2015-01-02 20:22:08.000000000","message":"+1","commit_id":"49d6879bc9b57c1bdd5c4f3da80b570e62327cae"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"691a71dabb4c896235dda4d528d33d34225147e7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from neutron.openstack.common import loopingcall"},{"line_number":54,"context_line":"from neutron.openstack.common import periodic_task"},{"line_number":55,"context_line":"from neutron.openstack.common import service"},{"line_number":56,"context_line":"from neutron import service as neutron_service"},{"line_number":57,"context_line":"from neutron.services import advanced_service as adv_svc"},{"line_number":58,"context_line":"try:"},{"line_number":59,"context_line":"    from neutron_fwaas.services.firewall.agents.l3reference \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_bfa023f5","side":"PARENT","line":56,"in_reply_to":"3a961159_aebd7704","updated":"2015-01-05 19:06:54.000000000","message":"Why agent.py?  agent.py is where the constants are being removed from.  Do you mean to ask \"why is router_info.py the new location?\"  The answer is because these are router implementation related constants and the agent shouldn\u0027t have them.\n\nMost are actually dvr related constants and a future refactoring step will move them to the dvr.py file.  Actually, I think this patch should probably get behind that one.\n\nI\u0027d rather not lump all l3 constants together.  Most are only related to DVR, some may be HA related constants, etc.  It doesn\u0027t make sense to me to lump all of these in to one constants module.  If we want to create a constants module for each router implementation down the road, that is fine.  However, I don\u0027t think that creating the constants module at this stage is necessary or good.","commit_id":"49d6879bc9b57c1bdd5c4f3da80b570e62327cae"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"89f632303b2f083c72ca685f036ff5b7bddc3835","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from neutron.openstack.common import loopingcall"},{"line_number":54,"context_line":"from neutron.openstack.common import periodic_task"},{"line_number":55,"context_line":"from neutron.openstack.common import service"},{"line_number":56,"context_line":"from neutron import service as neutron_service"},{"line_number":57,"context_line":"from neutron.services import advanced_service as adv_svc"},{"line_number":58,"context_line":"try:"},{"line_number":59,"context_line":"    from neutron_fwaas.services.firewall.agents.l3reference \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_300c6042","side":"PARENT","line":56,"in_reply_to":"3a961159_bfa023f5","updated":"2015-01-05 21:03:51.000000000","message":"I realize I should have commented inline rather than just +1ing here, the lack of context is apparent.\n\nMy intention wasn\u0027t to express support for constants to be centralized in a single module, but rather that it might make sense to separate heavily-used constants from code to minimize the potential for circular references.  If that doesn\u0027t make sense at this point, fair enough.","commit_id":"49d6879bc9b57c1bdd5c4f3da80b570e62327cae"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"691a71dabb4c896235dda4d528d33d34225147e7","unresolved":false,"context_lines":[{"line_number":78,"context_line":"# Rule priority range for FIPs"},{"line_number":79,"context_line":"FIP_PR_START \u003d 32768"},{"line_number":80,"context_line":"FIP_PR_END \u003d FIP_PR_START + 40000"},{"line_number":81,"context_line":"RPC_LOOP_INTERVAL \u003d 1"},{"line_number":82,"context_line":"FLOATING_IP_CIDR_SUFFIX \u003d \u0027/32\u0027"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_ff0aab1e","side":"PARENT","line":81,"updated":"2015-01-05 19:06:54.000000000","message":"I don\u0027t think this constant above should move.  This is an agent constant.","commit_id":"49d6879bc9b57c1bdd5c4f3da80b570e62327cae"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"29e7f982ab3ffc7b9b50b41676ac36f2ccee9367","unresolved":false,"context_lines":[{"line_number":78,"context_line":"# Rule priority range for FIPs"},{"line_number":79,"context_line":"FIP_PR_START \u003d 32768"},{"line_number":80,"context_line":"FIP_PR_END \u003d FIP_PR_START + 40000"},{"line_number":81,"context_line":"RPC_LOOP_INTERVAL \u003d 1"},{"line_number":82,"context_line":"FLOATING_IP_CIDR_SUFFIX \u003d \u0027/32\u0027"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_7605d90e","side":"PARENT","line":81,"in_reply_to":"3a961159_ff0aab1e","updated":"2015-01-06 22:25:31.000000000","message":"Done","commit_id":"49d6879bc9b57c1bdd5c4f3da80b570e62327cae"}]}
