)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"3ae970702bc9ba241d923185efd5adc202af1454","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix IPv6 Subnet Slaac Check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, \"is_slaac_subnet\" method only check \"ipv6_address_mode\"."},{"line_number":10,"context_line":"This will let neutron allocate a stateful IPv6 address for instance"},{"line_number":11,"context_line":"when set ipv6_ra_mode to stateless or slaac and set none to \"ipv6_"},{"line_number":12,"context_line":"address_mode\". But actually, instance get IPv6 address prefix from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_91bf28fc","line":9,"updated":"2014-12-30 03:56:44.000000000","message":"nit: check-\u003e checks","commit_id":"262d18902c28d717edb152af139c3c24272f2057"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"4240536d4147e9655d0280242833094c9cd81351","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix IPv6 Subnet Slaac Check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, \"is_slaac_subnet\" method only check \"ipv6_address_mode\"."},{"line_number":10,"context_line":"This will let neutron allocate a stateful IPv6 address for instance"},{"line_number":11,"context_line":"when set ipv6_ra_mode to stateless or slaac and set none to \"ipv6_"},{"line_number":12,"context_line":"address_mode\". But actually, instance get IPv6 address prefix from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_3143d46d","line":9,"in_reply_to":"3a961159_91bf28fc","updated":"2014-12-30 05:42:25.000000000","message":"Done","commit_id":"262d18902c28d717edb152af139c3c24272f2057"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"7535d522a78e13c615397963d7011d537228978d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, \"is_slaac_subnet\" method only checks \"ipv6_address_mode\"."},{"line_number":10,"context_line":"This will let neutron allocate a stateful IPv6 address for instance"},{"line_number":11,"context_line":"when set ipv6_ra_mode to stateless or slaac and set none to \"ipv6_"},{"line_number":12,"context_line":"address_mode\". But actually, instance get IPv6 address prefix from"},{"line_number":13,"context_line":"radvd, and auto configured by itself. This change will let \"is_slaac_"},{"line_number":14,"context_line":"subnet\" also check ipv6_ra_mode attribute."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a961159_bdaba4d4","line":11,"updated":"2015-01-06 20:54:11.000000000","message":"When ipv6_ra_mode is set to \"stateless\" or \"slaac\", and \"ipv6_address_mode\" is unset.","commit_id":"d3b201e90767b71cbdeb7fb9b9161ca117afe4dd"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"8efcd78b5217cbdd4c8a99b39d322f132845459c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, \"is_slaac_subnet\" method only checks \"ipv6_address_mode\"."},{"line_number":10,"context_line":"This will let neutron allocate a stateful IPv6 address for instance"},{"line_number":11,"context_line":"when set ipv6_ra_mode to stateless or slaac and set none to \"ipv6_"},{"line_number":12,"context_line":"address_mode\". But actually, instance get IPv6 address prefix from"},{"line_number":13,"context_line":"radvd, and auto configured by itself. This change will let \"is_slaac_"},{"line_number":14,"context_line":"subnet\" also check ipv6_ra_mode attribute."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a961159_58c0072b","line":11,"in_reply_to":"3a961159_bdaba4d4","updated":"2015-01-07 02:32:34.000000000","message":"Will do in next patch.","commit_id":"d3b201e90767b71cbdeb7fb9b9161ca117afe4dd"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"15a45a6a4af99391d470699b0a6fba3d6f0eeead","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, \"is_slaac_subnet\" method only checks \"ipv6_address_mode\"."},{"line_number":10,"context_line":"This will let neutron allocate a stateful IPv6 address for instance"},{"line_number":11,"context_line":"when ipv6_ra_mode set to \"stateless\" or \"slaac\", and \"ipv6_address_mode\""},{"line_number":12,"context_line":"unset. But actually, instance get IPv6 address prefix from radvd, and"},{"line_number":13,"context_line":"auto configure IPv6 address by itself. This change will let \"is_slaac_"},{"line_number":14,"context_line":"subnet\" also check ipv6_ra_mode attribute."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a961159_8a3e5989","line":11,"updated":"2015-01-08 21:28:22.000000000","message":"Do you think it would be good to prevent an inconsistent setting between ipv6_ra_mode and ipv6_address_mode in the server?\n\nI guess that in current deployments, the damage may already have been done but maybe a migration could fix it.","commit_id":"9091604c4f04fd13a101919b30d387cc4026f625"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"04452b6955634b4d3485cf10107afd95ab488d1f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, \"is_slaac_subnet\" method only checks \"ipv6_address_mode\"."},{"line_number":10,"context_line":"This will let neutron allocate a stateful IPv6 address for instance"},{"line_number":11,"context_line":"when ipv6_ra_mode set to \"stateless\" or \"slaac\", and \"ipv6_address_mode\""},{"line_number":12,"context_line":"unset. But actually, instance get IPv6 address prefix from radvd, and"},{"line_number":13,"context_line":"auto configure IPv6 address by itself. This change will let \"is_slaac_"},{"line_number":14,"context_line":"subnet\" also check ipv6_ra_mode attribute."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a961159_2d649fb1","line":11,"in_reply_to":"3a961159_8a3e5989","updated":"2015-01-08 22:24:43.000000000","message":"Carl, these checks are already in place in the server. It is not possible to create a subnet with inconsistent v6 mode settings. This patch changes whether fixed IPs can be allocated on auto-address subnets. (And see my comment below.)","commit_id":"9091604c4f04fd13a101919b30d387cc4026f625"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"04452b6955634b4d3485cf10107afd95ab488d1f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"when ipv6_ra_mode set to \"stateless\" or \"slaac\", and \"ipv6_address_mode\""},{"line_number":12,"context_line":"unset. But actually, instance get IPv6 address prefix from radvd, and"},{"line_number":13,"context_line":"auto configure IPv6 address by itself. This change will let \"is_slaac_"},{"line_number":14,"context_line":"subnet\" also check ipv6_ra_mode attribute."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ic99193a0a2669fb281759d9b47c7aae6a4f6ecce"},{"line_number":17,"context_line":"Closes-Bug: 1406436"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a961159_0daa8370","line":14,"updated":"2015-01-08 22:24:43.000000000","message":"I think it would be good to mention explicitly what this fixes:\n\n1. No longer allow fixed IPs on auto-address subnets.\n\n2. Delete subnet will now correctly delete auto-address ports.","commit_id":"9091604c4f04fd13a101919b30d387cc4026f625"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"2d90a0c62ea6e163accf75dfcc9c659b04931112","unresolved":false,"context_lines":[{"line_number":11,"context_line":"when ipv6_ra_mode set to \"stateless\" or \"slaac\", and \"ipv6_address_mode\""},{"line_number":12,"context_line":"unset. But actually, instance get IPv6 address prefix from radvd, and"},{"line_number":13,"context_line":"auto configure IPv6 address by itself. This change will let \"is_slaac_"},{"line_number":14,"context_line":"subnet\" also check ipv6_ra_mode attribute."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ic99193a0a2669fb281759d9b47c7aae6a4f6ecce"},{"line_number":17,"context_line":"Closes-Bug: 1406436"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a961159_64ba3cc1","line":14,"in_reply_to":"3a961159_0daa8370","updated":"2015-01-09 03:00:41.000000000","message":"Will add it in next patch. Thanks.","commit_id":"9091604c4f04fd13a101919b30d387cc4026f625"}],"neutron/common/ipv6_utils.py":[{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"b4833933be35858b769f9a3db97ec420eebb74dd","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def is_slaac_subnet(subnet):"},{"line_number":68,"context_line":"    \"\"\"Check if subnet uses SLAAC addressing.\"\"\""},{"line_number":69,"context_line":"    modes \u003d [constants.IPV6_SLAAC, constants.DHCPV6_STATELESS]"},{"line_number":70,"context_line":"    return (subnet[\u0027ipv6_address_mode\u0027] in modes"},{"line_number":71,"context_line":"            or subnet[\u0027ipv6_ra_mode\u0027] in modes)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_3cfd6b6f","line":69,"updated":"2014-12-30 07:08:47.000000000","message":"is_slaac_subnet() is used at couple of places in db_base_plugin_v2.py and the error message displays the address mode. For an IPv6 subnet with ra_mode set to SLAAC and address_mode not set, the error message could be misleading. It would be better to modify the error message by removing the reference to address_mode and simply mentioning that its a SLAAC subnet. \n\nExample:\nhttps://github.com/openstack/neutron/blob/master/neutron/db/db_base_plugin_v2.py#L453\n\nWhen trying to create a port with fixed_ip on an IPv6 SLAAC subnet with ra_mode set and address_mode not set, the error message would be as follows. \n\"Invalid input for operation: IPv6 address 2021::201 can not be directly assigned to a port on subnet 3e789234-2bd5-4d6c-81d9-01f29a07859c with None address mode.\"","commit_id":"664968e79b58870ee9ab56834b1b7d43bbb6cdfd"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"732bc428a7afcfa67fd1a752d504be6c35899c68","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def is_slaac_subnet(subnet):"},{"line_number":68,"context_line":"    \"\"\"Check if subnet uses SLAAC addressing.\"\"\""},{"line_number":69,"context_line":"    modes \u003d [constants.IPV6_SLAAC, constants.DHCPV6_STATELESS]"},{"line_number":70,"context_line":"    return (subnet[\u0027ipv6_address_mode\u0027] in modes"},{"line_number":71,"context_line":"            or subnet[\u0027ipv6_ra_mode\u0027] in modes)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c9eca8f6","line":69,"in_reply_to":"3a961159_3cfd6b6f","updated":"2014-12-30 10:29:31.000000000","message":"Thanks for your remind. But either stateless or slaac for ipv6-address-mode or ipv6-ra-mode can raise this error, seems we can not just mention it is a slaac subnet. What about change it to \"Invalid input for operation: IPv6 address 2021::201 can not be directly assigned to a port on subnet 3e789234-2bd5-4d6c-81d9-01f29a07859c with none dhcpv6-stateful address mode\". Since only address mode is dhcpv6-stateful, instance can get ip from dnsmasq with stateful mode. Reference https://github.com/openstack/neutron-specs/blob/master/specs/juno/ipv6-radvd-ra.rst","commit_id":"664968e79b58870ee9ab56834b1b7d43bbb6cdfd"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fc77b6b9e53364cf1946f1e6c3b7511de03c98fb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    return _IS_IPV6_ENABLED"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def is_slaac_subnet(subnet):"},{"line_number":68,"context_line":"    \"\"\"Check if subnet uses SLAAC addressing.\"\"\""},{"line_number":69,"context_line":"    modes \u003d [constants.IPV6_SLAAC, constants.DHCPV6_STATELESS]"},{"line_number":70,"context_line":"    return (subnet[\u0027ipv6_address_mode\u0027] in modes"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_2bd6a04f","line":67,"updated":"2015-01-06 10:48:32.000000000","message":"considering your change this method should be renamed to is_auto_address_subnet or something like that.\n\nIndeed it will return true also if neither address_mode or ra_mode are SLAAC - in the case where they\u0027re both set to DHCP stateless","commit_id":"d3b201e90767b71cbdeb7fb9b9161ca117afe4dd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e2e15879e1dd6fdf2416595cbffead244aae45f2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    return _IS_IPV6_ENABLED"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def is_slaac_subnet(subnet):"},{"line_number":68,"context_line":"    \"\"\"Check if subnet uses SLAAC addressing.\"\"\""},{"line_number":69,"context_line":"    modes \u003d [constants.IPV6_SLAAC, constants.DHCPV6_STATELESS]"},{"line_number":70,"context_line":"    return (subnet[\u0027ipv6_address_mode\u0027] in modes"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_872139a0","line":67,"in_reply_to":"3a961159_2bd6a04f","updated":"2015-01-06 19:32:20.000000000","message":"I had considered the same, but isn\u0027t that what AA in slaac stands for? :)","commit_id":"d3b201e90767b71cbdeb7fb9b9161ca117afe4dd"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"8efcd78b5217cbdd4c8a99b39d322f132845459c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    return _IS_IPV6_ENABLED"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def is_slaac_subnet(subnet):"},{"line_number":68,"context_line":"    \"\"\"Check if subnet uses SLAAC addressing.\"\"\""},{"line_number":69,"context_line":"    modes \u003d [constants.IPV6_SLAAC, constants.DHCPV6_STATELESS]"},{"line_number":70,"context_line":"    return (subnet[\u0027ipv6_address_mode\u0027] in modes"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_183f5f26","line":67,"in_reply_to":"3a961159_872139a0","updated":"2015-01-07 02:32:34.000000000","message":"Since slaac means \"Stateless address autoconfiguration\", I think we the original name is fine. :)","commit_id":"d3b201e90767b71cbdeb7fb9b9161ca117afe4dd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4f9f6007bd8116a5ae09c1358af33b83ca59ef94","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def is_slaac_subnet(subnet):"},{"line_number":68,"context_line":"    \"\"\"Check if subnet uses SLAAC addressing.\"\"\""},{"line_number":69,"context_line":"    modes \u003d [constants.IPV6_SLAAC, constants.DHCPV6_STATELESS]"},{"line_number":70,"context_line":"    return (subnet[\u0027ipv6_address_mode\u0027] in modes"},{"line_number":71,"context_line":"            or subnet[\u0027ipv6_ra_mode\u0027] in modes)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_56c1e47e","line":69,"updated":"2015-01-05 21:41:59.000000000","message":"this could be a tuple","commit_id":"d3b201e90767b71cbdeb7fb9b9161ca117afe4dd"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"8efcd78b5217cbdd4c8a99b39d322f132845459c","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def is_slaac_subnet(subnet):"},{"line_number":68,"context_line":"    \"\"\"Check if subnet uses SLAAC addressing.\"\"\""},{"line_number":69,"context_line":"    modes \u003d [constants.IPV6_SLAAC, constants.DHCPV6_STATELESS]"},{"line_number":70,"context_line":"    return (subnet[\u0027ipv6_address_mode\u0027] in modes"},{"line_number":71,"context_line":"            or subnet[\u0027ipv6_ra_mode\u0027] in modes)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_38797b2f","line":69,"in_reply_to":"3a961159_56c1e47e","updated":"2015-01-07 02:32:34.000000000","message":"yep.","commit_id":"d3b201e90767b71cbdeb7fb9b9161ca117afe4dd"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"04452b6955634b4d3485cf10107afd95ab488d1f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    return _IS_IPV6_ENABLED"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def is_slaac_subnet(subnet):"},{"line_number":68,"context_line":"    \"\"\"Check if subnet uses SLAAC addressing.\"\"\""},{"line_number":69,"context_line":"    modes \u003d [constants.IPV6_SLAAC, constants.DHCPV6_STATELESS]"},{"line_number":70,"context_line":"    return (subnet[\u0027ipv6_address_mode\u0027] in modes"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_ad35ef45","line":67,"updated":"2015-01-08 22:24:43.000000000","message":"Actually I have thought about it some more and I am now siding with Salvatore\u0027s comment on patch set 6. I think \"is_slaac_subnet\" will too easily confuse people into assuming it just checks for IPV6_SLAAC.\n\nSince this function is used to check whether a subnet is configured for automatic addresses, please rename it to \"is_auto_address_subnet\".","commit_id":"9091604c4f04fd13a101919b30d387cc4026f625"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"2d90a0c62ea6e163accf75dfcc9c659b04931112","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    return _IS_IPV6_ENABLED"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def is_slaac_subnet(subnet):"},{"line_number":68,"context_line":"    \"\"\"Check if subnet uses SLAAC addressing.\"\"\""},{"line_number":69,"context_line":"    modes \u003d [constants.IPV6_SLAAC, constants.DHCPV6_STATELESS]"},{"line_number":70,"context_line":"    return (subnet[\u0027ipv6_address_mode\u0027] in modes"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_445f00e5","line":67,"in_reply_to":"3a961159_ad35ef45","updated":"2015-01-09 03:00:41.000000000","message":"Will do in next patch.","commit_id":"9091604c4f04fd13a101919b30d387cc4026f625"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"fdd0f5be96d40b4e40dedfacb9bd6d32887d1e12","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                        constants.ROUTER_INTERFACE_OWNERS):"},{"line_number":450,"context_line":"                    msg \u003d (_(\"IPv6 address %(address)s can not be directly \""},{"line_number":451,"context_line":"                            \"assigned to a port on subnet %(id)s with none \""},{"line_number":452,"context_line":"                            \"dhcpv6-stateful address mode\") %"},{"line_number":453,"context_line":"                           {\u0027address\u0027: fixed[\u0027ip_address\u0027],"},{"line_number":454,"context_line":"                            \u0027id\u0027: subnet_id})"},{"line_number":455,"context_line":"                    raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_8ffb5246","line":452,"updated":"2015-01-04 04:37:21.000000000","message":"... on subnet %(id)s since the subnet is not configured for dhcpv6-stateful address mode.","commit_id":"2adc299120442d0b7823024c9b90304d2496bc18"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"fc77b6b9e53364cf1946f1e6c3b7511de03c98fb","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                    msg \u003d (_(\"IPv6 address %(address)s can not be directly \""},{"line_number":451,"context_line":"                            \"assigned to a port on subnet %(id)s since the \""},{"line_number":452,"context_line":"                            \"subnet is not configured for dhcpv6-stateful \""},{"line_number":453,"context_line":"                            \"address mode\") %"},{"line_number":454,"context_line":"                           {\u0027address\u0027: fixed[\u0027ip_address\u0027],"},{"line_number":455,"context_line":"                            \u0027id\u0027: subnet_id})"},{"line_number":456,"context_line":"                    raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_8b4b142a","line":453,"updated":"2015-01-06 10:48:32.000000000","message":"I kind of think that the previous error message was more informative. Why did you change it?","commit_id":"d3b201e90767b71cbdeb7fb9b9161ca117afe4dd"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"8efcd78b5217cbdd4c8a99b39d322f132845459c","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                    msg \u003d (_(\"IPv6 address %(address)s can not be directly \""},{"line_number":451,"context_line":"                            \"assigned to a port on subnet %(id)s since the \""},{"line_number":452,"context_line":"                            \"subnet is not configured for dhcpv6-stateful \""},{"line_number":453,"context_line":"                            \"address mode\") %"},{"line_number":454,"context_line":"                           {\u0027address\u0027: fixed[\u0027ip_address\u0027],"},{"line_number":455,"context_line":"                            \u0027id\u0027: subnet_id})"},{"line_number":456,"context_line":"                    raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_38cb3b73","line":453,"in_reply_to":"3a961159_8b4b142a","updated":"2015-01-07 02:32:34.000000000","message":"There is a comment for this change in patch 2. I think he is right. The original message can be misleading. Reference https://github.com/openstack/neutron-specs/blob/master/specs/juno/ipv6-radvd-ra.rst, we can know that only set subnet ip address mode to dhcpv6-stateful, user can assign an IPv6 address to a port from this subnet.","commit_id":"d3b201e90767b71cbdeb7fb9b9161ca117afe4dd"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"04452b6955634b4d3485cf10107afd95ab488d1f","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                    msg \u003d (_(\"IPv6 address %(address)s can not be directly \""},{"line_number":451,"context_line":"                            \"assigned to a port on subnet %(id)s since the \""},{"line_number":452,"context_line":"                            \"subnet is not configured for dhcpv6-stateful \""},{"line_number":453,"context_line":"                            \"address mode\") %"},{"line_number":454,"context_line":"                           {\u0027address\u0027: fixed[\u0027ip_address\u0027],"},{"line_number":455,"context_line":"                            \u0027id\u0027: subnet_id})"},{"line_number":456,"context_line":"                    raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_edfd373c","line":453,"updated":"2015-01-08 22:24:43.000000000","message":"Salvatore\u0027s comment on patch set 6 made me think about this too.\n\nHow about \"... on  subnet %(id)s since the subnet is configured for automatic addresses\"?\n\nI would like to hear Salvatore\u0027s opinion on this.","commit_id":"9091604c4f04fd13a101919b30d387cc4026f625"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d443a4bc4b97e4a809e59b474c36761185b8d1a7","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                    msg \u003d (_(\"IPv6 address %(address)s can not be directly \""},{"line_number":451,"context_line":"                            \"assigned to a port on subnet %(id)s since the \""},{"line_number":452,"context_line":"                            \"subnet is not configured for dhcpv6-stateful \""},{"line_number":453,"context_line":"                            \"address mode\") %"},{"line_number":454,"context_line":"                           {\u0027address\u0027: fixed[\u0027ip_address\u0027],"},{"line_number":455,"context_line":"                            \u0027id\u0027: subnet_id})"},{"line_number":456,"context_line":"                    raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_b120e149","line":453,"in_reply_to":"3a961159_a48264fc","updated":"2015-01-09 04:41:54.000000000","message":"The problem with that is ip_address_mode could be None, which I think would be confusing.","commit_id":"9091604c4f04fd13a101919b30d387cc4026f625"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"2d90a0c62ea6e163accf75dfcc9c659b04931112","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                    msg \u003d (_(\"IPv6 address %(address)s can not be directly \""},{"line_number":451,"context_line":"                            \"assigned to a port on subnet %(id)s since the \""},{"line_number":452,"context_line":"                            \"subnet is not configured for dhcpv6-stateful \""},{"line_number":453,"context_line":"                            \"address mode\") %"},{"line_number":454,"context_line":"                           {\u0027address\u0027: fixed[\u0027ip_address\u0027],"},{"line_number":455,"context_line":"                            \u0027id\u0027: subnet_id})"},{"line_number":456,"context_line":"                    raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_a48264fc","line":453,"in_reply_to":"3a961159_edfd373c","updated":"2015-01-09 03:00:41.000000000","message":"OK, let\u0027s see Salvatore\u0027s opinion. But after think twice about this, I think the original message can provide more information(ip address mode).","commit_id":"9091604c4f04fd13a101919b30d387cc4026f625"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5d510ca042e8606a4ba922b87eddd2eccaaf5259","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                    msg \u003d _(\u0027IP address %s is not a valid IP for the defined \u0027"},{"line_number":446,"context_line":"                            \u0027subnet\u0027) % fixed[\u0027ip_address\u0027]"},{"line_number":447,"context_line":"                    raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":448,"context_line":"                if (ipv6_utils.is_auto_address_subnet(subnet) and device_owner not in"},{"line_number":449,"context_line":"                        constants.ROUTER_INTERFACE_OWNERS):"},{"line_number":450,"context_line":"                    msg \u003d (_(\"IPv6 address %(address)s can not be directly \""},{"line_number":451,"context_line":"                            \"assigned to a port on subnet %(id)s since the \""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_915845fa","line":448,"updated":"2015-01-09 04:42:16.000000000","message":"PEP8: Line too long","commit_id":"12328f7924d9b10842e9493892bd0ffcc2bee6b7"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"0620bbf860ff51188a415d882357698dac4b09f3","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                    msg \u003d _(\u0027IP address %s is not a valid IP for the defined \u0027"},{"line_number":446,"context_line":"                            \u0027subnet\u0027) % fixed[\u0027ip_address\u0027]"},{"line_number":447,"context_line":"                    raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":448,"context_line":"                if (ipv6_utils.is_auto_address_subnet(subnet) and device_owner not in"},{"line_number":449,"context_line":"                        constants.ROUTER_INTERFACE_OWNERS):"},{"line_number":450,"context_line":"                    msg \u003d (_(\"IPv6 address %(address)s can not be directly \""},{"line_number":451,"context_line":"                            \"assigned to a port on subnet %(id)s since the \""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_311311b9","line":448,"in_reply_to":"3a961159_915845fa","updated":"2015-01-09 05:22:28.000000000","message":"Done","commit_id":"12328f7924d9b10842e9493892bd0ffcc2bee6b7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5d510ca042e8606a4ba922b87eddd2eccaaf5259","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                        constants.ROUTER_INTERFACE_OWNERS):"},{"line_number":450,"context_line":"                    msg \u003d (_(\"IPv6 address %(address)s can not be directly \""},{"line_number":451,"context_line":"                            \"assigned to a port on subnet %(id)s since the \""},{"line_number":452,"context_line":"                            \"subnet is configured for automatic address\") %"},{"line_number":453,"context_line":"                           {\u0027address\u0027: fixed[\u0027ip_address\u0027],"},{"line_number":454,"context_line":"                            \u0027id\u0027: subnet_id})"},{"line_number":455,"context_line":"                    raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_910f65df","line":452,"updated":"2015-01-09 04:42:16.000000000","message":"s/address/addresses/","commit_id":"12328f7924d9b10842e9493892bd0ffcc2bee6b7"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"0620bbf860ff51188a415d882357698dac4b09f3","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                        constants.ROUTER_INTERFACE_OWNERS):"},{"line_number":450,"context_line":"                    msg \u003d (_(\"IPv6 address %(address)s can not be directly \""},{"line_number":451,"context_line":"                            \"assigned to a port on subnet %(id)s since the \""},{"line_number":452,"context_line":"                            \"subnet is configured for automatic address\") %"},{"line_number":453,"context_line":"                           {\u0027address\u0027: fixed[\u0027ip_address\u0027],"},{"line_number":454,"context_line":"                            \u0027id\u0027: subnet_id})"},{"line_number":455,"context_line":"                    raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_5116dda7","line":452,"in_reply_to":"3a961159_910f65df","updated":"2015-01-09 05:22:28.000000000","message":"Done","commit_id":"12328f7924d9b10842e9493892bd0ffcc2bee6b7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5d510ca042e8606a4ba922b87eddd2eccaaf5259","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"            # Remove network owned ports, and delete IP allocations"},{"line_number":1278,"context_line":"            # for IPv6 addresses which were automatically generated"},{"line_number":1279,"context_line":"            # via SLAAC"},{"line_number":1280,"context_line":"            is_ipv6_auto_address_subnet \u003d ipv6_utils.is_auto_address_subnet(subnet)"},{"line_number":1281,"context_line":"            for a in allocated:"},{"line_number":1282,"context_line":"                if (is_ipv6_auto_address_subnet or"},{"line_number":1283,"context_line":"                    a.ports.device_owner in AUTO_DELETE_PORT_OWNERS):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_31d4f11e","line":1280,"updated":"2015-01-09 04:42:16.000000000","message":"Line too long. You can do away with the variable.","commit_id":"12328f7924d9b10842e9493892bd0ffcc2bee6b7"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"0620bbf860ff51188a415d882357698dac4b09f3","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"            # Remove network owned ports, and delete IP allocations"},{"line_number":1278,"context_line":"            # for IPv6 addresses which were automatically generated"},{"line_number":1279,"context_line":"            # via SLAAC"},{"line_number":1280,"context_line":"            is_ipv6_auto_address_subnet \u003d ipv6_utils.is_auto_address_subnet(subnet)"},{"line_number":1281,"context_line":"            for a in allocated:"},{"line_number":1282,"context_line":"                if (is_ipv6_auto_address_subnet or"},{"line_number":1283,"context_line":"                    a.ports.device_owner in AUTO_DELETE_PORT_OWNERS):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_b1d1c1fc","line":1280,"in_reply_to":"3a961159_31d4f11e","updated":"2015-01-09 05:22:28.000000000","message":"Please forgive my careless.","commit_id":"12328f7924d9b10842e9493892bd0ffcc2bee6b7"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5d510ca042e8606a4ba922b87eddd2eccaaf5259","unresolved":false,"context_lines":[{"line_number":731,"context_line":"                qry_allocated \u003d (session.query(models_v2.IPAllocation)."},{"line_number":732,"context_line":"                                 filter_by(subnet_id\u003did)."},{"line_number":733,"context_line":"                                 join(models_v2.Port))"},{"line_number":734,"context_line":"                is_ipv6_auto_address_subnet \u003d ipv6_utils.is_auto_address_subnet(subnet)"},{"line_number":735,"context_line":"                # Remove network owned ports, and delete IP allocations"},{"line_number":736,"context_line":"                # for IPv6 addresses which were automatically generated"},{"line_number":737,"context_line":"                # via SLAAC"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_b1e70111","line":734,"updated":"2015-01-09 04:42:16.000000000","message":"Line too long. You can do away with the variable.","commit_id":"12328f7924d9b10842e9493892bd0ffcc2bee6b7"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"0620bbf860ff51188a415d882357698dac4b09f3","unresolved":false,"context_lines":[{"line_number":731,"context_line":"                qry_allocated \u003d (session.query(models_v2.IPAllocation)."},{"line_number":732,"context_line":"                                 filter_by(subnet_id\u003did)."},{"line_number":733,"context_line":"                                 join(models_v2.Port))"},{"line_number":734,"context_line":"                is_ipv6_auto_address_subnet \u003d ipv6_utils.is_auto_address_subnet(subnet)"},{"line_number":735,"context_line":"                # Remove network owned ports, and delete IP allocations"},{"line_number":736,"context_line":"                # for IPv6 addresses which were automatically generated"},{"line_number":737,"context_line":"                # via SLAAC"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_116ff528","line":734,"in_reply_to":"3a961159_b1e70111","updated":"2015-01-09 05:22:28.000000000","message":"Done","commit_id":"12328f7924d9b10842e9493892bd0ffcc2bee6b7"}],"neutron/tests/unit/test_ipv6.py":[{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"c5bf4d5a2e822449d9a3aff9416e6b92d19a57c0","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_not_slaac(self):"},{"line_number":111,"context_line":"        # Test for both ra and address mode are \u0027None\u0027 case."},{"line_number":112,"context_line":"        self._not_slaac()"},{"line_number":113,"context_line":"        self.subnet[\u0027ipv6_address_mode\u0027] \u003d constants.DHCPV6_STATEFUL"},{"line_number":114,"context_line":"        self._not_slaac()"},{"line_number":115,"context_line":"        self.subnet[\u0027ipv6_ra_mode\u0027] \u003d constants.DHCPV6_STATEFUL"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_cb539fe0","line":112,"updated":"2015-01-01 08:39:33.000000000","message":"nit: a lot of duplicated code in test_not_slaac and test_is_slaac method below. Can we use a loop instead?","commit_id":"c42900b12c8c09dc7aeef02ba6ccfbf782434c99"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"15a340983e95479ff045652173e37d2feab26c15","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_not_slaac(self):"},{"line_number":111,"context_line":"        # Test for both ra and address mode are \u0027None\u0027 case."},{"line_number":112,"context_line":"        self._not_slaac()"},{"line_number":113,"context_line":"        self.subnet[\u0027ipv6_address_mode\u0027] \u003d constants.DHCPV6_STATEFUL"},{"line_number":114,"context_line":"        self._not_slaac()"},{"line_number":115,"context_line":"        self.subnet[\u0027ipv6_ra_mode\u0027] \u003d constants.DHCPV6_STATEFUL"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_6fd70650","line":112,"in_reply_to":"3a961159_cb539fe0","updated":"2015-01-04 03:04:24.000000000","message":"Will do in next patch.","commit_id":"c42900b12c8c09dc7aeef02ba6ccfbf782434c99"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"fdd0f5be96d40b4e40dedfacb9bd6d32887d1e12","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        # Test for both ra and address mode are \u0027None\u0027 case."},{"line_number":112,"context_line":"        self._not_slaac()"},{"line_number":113,"context_line":"        for attr in [\u0027ipv6_address_mode\u0027, \u0027ipv6_ra_mode\u0027]:"},{"line_number":114,"context_line":"            if attr \u003d\u003d \u0027ipv6_address_mode\u0027:"},{"line_number":115,"context_line":"                self.subnet[\u0027ipv6_ra_mode\u0027] \u003d None"},{"line_number":116,"context_line":"            else:"},{"line_number":117,"context_line":"                self.subnet[\u0027ipv6_address_mode\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_0f9f6204","line":114,"updated":"2015-01-04 04:37:21.000000000","message":"It is not a good idea to have conditional logic like this in a test case. I would have just one test method that loops through a table of the possible combinations. Something like this:\n\n    def test_slaac_combinations(self):\n        Mode \u003d collections.namedtuple(\u0027Mode\u0027, \u0027addr_mode ra_mode is_slaac\u0027)\n        subnets \u003d [\n            Mode(None, None, False),\n            Mode(constants.DHCPV6_STATEFUL, None, False),\n            Mode(constants.DHCPV6_STATELESS, None, True),\n            Mode(constants.IPV6_SLAAC, None, True),\n            Mode(None, constants.DHCPV6_STATEFUL, False),\n            Mode(None, constants.DHCPV6_STATELESS, True),\n            Mode(None, constants.IPV6_SLAAC, True),\n            Mode(constants.DHCPV6_STATEFUL, constants.DHCPV6_STATEFUL, False),\n            Mode(constants.DHCPV6_STATELESS, constants.DHCPV6_STATELESS, True),\n            Mode(constants.IPV6_SLAAC, constants.IPV6_SLAAC, True),\n        ]\n        for subnet in subnets:\n            self.subnet[\u0027ipv6_address_mode\u0027] \u003d subnet.addr_mode\n            self.subnet[\u0027ipv6_ra_mode\u0027] \u003d subnet.ra_mode\n            self.assertEqual(subnet.is_slaac,\n                             ipv6_utils.is_slaac_subnet(self.subnet))","commit_id":"2adc299120442d0b7823024c9b90304d2496bc18"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"819053621aae1e1134724eedf7a8ace1bc654502","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        # Test for both ra and address mode are \u0027None\u0027 case."},{"line_number":112,"context_line":"        self._not_slaac()"},{"line_number":113,"context_line":"        for attr in [\u0027ipv6_address_mode\u0027, \u0027ipv6_ra_mode\u0027]:"},{"line_number":114,"context_line":"            if attr \u003d\u003d \u0027ipv6_address_mode\u0027:"},{"line_number":115,"context_line":"                self.subnet[\u0027ipv6_ra_mode\u0027] \u003d None"},{"line_number":116,"context_line":"            else:"},{"line_number":117,"context_line":"                self.subnet[\u0027ipv6_address_mode\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_854df1c6","line":114,"in_reply_to":"3a961159_0f9f6204","updated":"2015-01-04 10:02:35.000000000","message":"That\u0027s seems good. Thanks. Will do in next patch.","commit_id":"2adc299120442d0b7823024c9b90304d2496bc18"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5d510ca042e8606a4ba922b87eddd2eccaaf5259","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        super(TestIsAutoAddressSubnet, self).setUp()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_combinations(self):"},{"line_number":108,"context_line":"        Mode \u003d collections.namedtuple(\u0027Mode\u0027, \u0027addr_mode ra_mode is_auto_address\u0027)"},{"line_number":109,"context_line":"        subnets \u003d ["},{"line_number":110,"context_line":"            Mode(None, None, False),"},{"line_number":111,"context_line":"            Mode(constants.DHCPV6_STATEFUL, None, False),"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_31bb11e6","line":108,"updated":"2015-01-09 04:42:16.000000000","message":"Line too long.","commit_id":"12328f7924d9b10842e9493892bd0ffcc2bee6b7"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"0620bbf860ff51188a415d882357698dac4b09f3","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        super(TestIsAutoAddressSubnet, self).setUp()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_combinations(self):"},{"line_number":108,"context_line":"        Mode \u003d collections.namedtuple(\u0027Mode\u0027, \u0027addr_mode ra_mode is_auto_address\u0027)"},{"line_number":109,"context_line":"        subnets \u003d ["},{"line_number":110,"context_line":"            Mode(None, None, False),"},{"line_number":111,"context_line":"            Mode(constants.DHCPV6_STATEFUL, None, False),"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_f1a6e952","line":108,"in_reply_to":"3a961159_31bb11e6","updated":"2015-01-09 05:22:28.000000000","message":"Done","commit_id":"12328f7924d9b10842e9493892bd0ffcc2bee6b7"}]}
