)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b9a258b374e14607c9935e00fab78b04b7fced41","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configures RADVD to send RA for DHCP_STATEFUL"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RADVD process is configured to send RA for the"},{"line_number":10,"context_line":"subnets with ra_mode set to DHCP_STATEFUL. One"},{"line_number":11,"context_line":"UT case to check managed flag and auto flag is"},{"line_number":12,"context_line":"added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a930d6b_32aa1471","line":9,"updated":"2015-01-21 12:14:33.000000000","message":"RAs are always sent in IPv6 subnets. What this change achieves is setting Managed (M) flag in those RAs to inform clients about address configuration available from DHCP servers.\n\nI think this commit message should be more clear about its intent, as per above.","commit_id":"f3ee7cfa0d2828893912c3fc176c8aebc56595dc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b9a258b374e14607c9935e00fab78b04b7fced41","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RADVD process is configured to send RA for the"},{"line_number":10,"context_line":"subnets with ra_mode set to DHCP_STATEFUL. One"},{"line_number":11,"context_line":"UT case to check managed flag and auto flag is"},{"line_number":12,"context_line":"added."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If685846c0c0f67bf4c40f4f268b9d03bfa2b1654"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a930d6b_12c4383f","line":11,"updated":"2015-01-21 12:14:33.000000000","message":"Strictly speaking, the test for Other, O (not auto!) flag was already present before.","commit_id":"f3ee7cfa0d2828893912c3fc176c8aebc56595dc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"54c726b967da9bdf0952a2646a287c9b840fea99","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configures RADVD to send RA for DHCP_STATEFUL"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RADVD process is configured to send RA for the"},{"line_number":10,"context_line":"subnets with ra_mode set to DHCP_STATEFUL. One"},{"line_number":11,"context_line":"UT case to check managed flag and auto flag is"},{"line_number":12,"context_line":"added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da86d52c_22a39b9f","line":9,"updated":"2015-02-02 12:00:14.000000000","message":"Comments from patchset 6 for commit message are not handled.","commit_id":"d06fd665b9ec70136131dce2e7fc74fd97d1091a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"56aeca89cb1804e7909abe1a84cfbdc364be3a43","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     singhannie \u003caniruddha.gautam@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-02 23:02:17 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configures RADVD to send managed flag in RA"},{"line_number":8,"context_line":"for DHCP_STATEFUL"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RADVD process is configured so that it sends"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da86d52c_2b026a0b","line":7,"updated":"2015-02-03 07:41:50.000000000","message":"Titles are one line","commit_id":"1f337c761bf73df050e435214935c498a2b3d028"}],"neutron/agent/linux/ra.py":[{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"c290902732d11eeb74881dbec5fc92e0685802c3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   {% if ra_mode \u003d\u003d constants.DHCPV6_STATEFUL %}"},{"line_number":46,"context_line":"   AdvManagedFlag on;"},{"line_number":47,"context_line":"   {% endif %}"},{"line_number":48,"context_line":"   prefix {{ prefix }}"},{"line_number":49,"context_line":"   {"},{"line_number":50,"context_line":"        AdvOnLink on;"},{"line_number":51,"context_line":"        {% if ra_mode in (constants.IPV6_SLAAC, constants.DHCPV6_STATELESS) %}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_79a1a945","line":48,"updated":"2014-12-31 13:30:50.000000000","message":"As prefix is now included by default, this seems to cause issues for the following test.\nhttp://logs.openstack.org/30/144630/1/check/gate-neutron-python27/c1a9c6e/testr_results.html.gz\n\nAlso please add the associated test cases for this change.","commit_id":"488250f766839c5e7cd72619ffa7e6143640af7c"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"a6b2dbfbd3c6a96cdf9cb21173cd79aa9485ce55","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        AdvOnLink on;"},{"line_number":51,"context_line":"        {% if ra_mode in (constants.IPV6_SLAAC, constants.DHCPV6_STATELESS) %}"},{"line_number":52,"context_line":"        AdvAutonomous on;"},{"line_number":53,"context_line":"        {% endif %}"},{"line_number":54,"context_line":"        {% if ra_mode \u003d\u003d constants.DHCPV6_STATEFUL %}"},{"line_number":55,"context_line":"        AdvAutonomous off;"},{"line_number":56,"context_line":"        {% endif %}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_b905d116","line":53,"updated":"2014-12-31 13:41:24.000000000","message":"You can consider clubbing this into elif as follows.\n{% elif ra_mode \u003d\u003d constants.DHCPV6_STATEFUL %}","commit_id":"488250f766839c5e7cd72619ffa7e6143640af7c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c3fc67e1d84736189e7931a1a5b643a8225d46d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"   MinRtrAdvInterval 3;"},{"line_number":41,"context_line":"   MaxRtrAdvInterval 10;"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"   {% if ra_mode in (constants.DHCPV6_STATELESS, constants.DHCPV6_STATEFUL) %}"},{"line_number":44,"context_line":"   AdvOtherConfigFlag on;"},{"line_number":45,"context_line":"   {% endif %}"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_b73931a5","line":43,"updated":"2015-01-05 14:42:37.000000000","message":"Though I believe that it\u0027s not really needed to set the flag when Stateful since clients will fully rely on DHCP server anyway, it\u0027s not a bad thing to have it here. That said, I would like to see this part split from the bug fix and pushed separately. The shorter the fix, the easier it is to backport it.\n\nFor completeness, quoting RFC4861 here:\n\"\n                     If the M flag is set, the O flag is redundant and\n                     can be ignored because DHCPv6 will return all\n                     available configuration information.\n\"","commit_id":"7266f2953e5ddfe24ac2b4c79da0118b6fe590fc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c3fc67e1d84736189e7931a1a5b643a8225d46d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   {% endif %}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"   {% if ra_mode \u003d\u003d constants.DHCPV6_STATEFUL %}"},{"line_number":48,"context_line":"   AdvManagedFlag on;"},{"line_number":49,"context_line":"   {% endif %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"   {% if ra_mode in (constants.IPV6_SLAAC, constants.DHCPV6_STATELESS) %}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_d7407d09","line":48,"updated":"2015-01-05 14:42:37.000000000","message":"I\u0027m impressed we didn\u0027t have it before. :|","commit_id":"7266f2953e5ddfe24ac2b4c79da0118b6fe590fc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c3fc67e1d84736189e7931a1a5b643a8225d46d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"   };"},{"line_number":57,"context_line":"   {% endif %}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"   {% if ra_mode \u003d\u003d constants.DHCPV6_STATEFUL %}"},{"line_number":60,"context_line":"   prefix {{ prefix }}"},{"line_number":61,"context_line":"   {"},{"line_number":62,"context_line":"        AdvOnLink on;"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_f743b910","line":59,"updated":"2015-01-05 14:42:37.000000000","message":"So if we need this section for all modes, why not merging two \u0027if\u0027s and just make AdvAutonomous part conditional?","commit_id":"7266f2953e5ddfe24ac2b4c79da0118b6fe590fc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e145a6347ceeef503d450eb5387435aab9d33b6b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"   {% endif %}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"   {% if ra_mode \u003d\u003d constants.DHCPV6_STATEFUL %}"},{"line_number":60,"context_line":"   prefix {{ prefix }}"},{"line_number":61,"context_line":"   {"},{"line_number":62,"context_line":"        AdvOnLink on;"},{"line_number":63,"context_line":"        AdvAutonomous off;"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_d70ebde4","line":60,"updated":"2015-01-05 14:44:38.000000000","message":"I don\u0027t actually think we should advertise any prefix in stateful mode. Default gateway is set without prefix advertised.","commit_id":"7266f2953e5ddfe24ac2b4c79da0118b6fe590fc"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"6bed645ab34db188cb2dcba1799af52961be52be","unresolved":false,"context_lines":[{"line_number":57,"context_line":"   {% endif %}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"   {% if ra_mode \u003d\u003d constants.DHCPV6_STATEFUL %}"},{"line_number":60,"context_line":"   prefix {{ prefix }}"},{"line_number":61,"context_line":"   {"},{"line_number":62,"context_line":"        AdvOnLink on;"},{"line_number":63,"context_line":"        AdvAutonomous off;"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_6da17ca8","line":60,"in_reply_to":"3a961159_ceeb75a2","updated":"2015-01-07 11:55:56.000000000","message":"I agree with @Ihar and @xuhanp, the whole of the prefix {  AdvOnLink ..., AdvAutonomous ...} section is not required for a stateful mode. Please delete the following code L59 to L65","commit_id":"7266f2953e5ddfe24ac2b4c79da0118b6fe590fc"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"9c3734161616f6900ebe36045aab5b8594951e57","unresolved":false,"context_lines":[{"line_number":57,"context_line":"   {% endif %}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"   {% if ra_mode \u003d\u003d constants.DHCPV6_STATEFUL %}"},{"line_number":60,"context_line":"   prefix {{ prefix }}"},{"line_number":61,"context_line":"   {"},{"line_number":62,"context_line":"        AdvOnLink on;"},{"line_number":63,"context_line":"        AdvAutonomous off;"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_ceeb75a2","line":60,"in_reply_to":"3a961159_d70ebde4","updated":"2015-01-06 03:25:35.000000000","message":"+1","commit_id":"7266f2953e5ddfe24ac2b4c79da0118b6fe590fc"}],"neutron/tests/unit/test_l3_agent.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c3fc67e1d84736189e7931a1a5b643a8225d46d","unresolved":false,"context_lines":[{"line_number":2225,"context_line":"            ra._generate_radvd_conf(ri.router[\u0027id\u0027],"},{"line_number":2226,"context_line":"                                    router[l3_constants.INTERFACE_KEY],"},{"line_number":2227,"context_line":"                                    mock.Mock())"},{"line_number":2228,"context_line":"            assertrt \u003d self.assertIn if flag_set else self.assertNotIn"},{"line_number":2229,"context_line":"            asserter \u003d self.assertNotIn if flag_set else self.assertIn"},{"line_number":2230,"context_line":"            assertrt(\u0027AdvAutonomous on;\u0027,"},{"line_number":2231,"context_line":"                     self.utils_replace_file.call_args[0][1])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_9736f5b2","line":2228,"updated":"2015-01-05 14:42:37.000000000","message":"I don\u0027t get what \u0027assertrt\u0027 and \u0027asserter\u0027 names mean. Do you abbreviate something with \u0027rt\u0027 and \u0027er\u0027?","commit_id":"7266f2953e5ddfe24ac2b4c79da0118b6fe590fc"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"a41fcee4028768909d0e18b3cf2d26953aa810c5","unresolved":false,"context_lines":[{"line_number":2210,"context_line":"            ra._generate_radvd_conf(ri.router[\u0027id\u0027],"},{"line_number":2211,"context_line":"                                    router[l3_constants.INTERFACE_KEY],"},{"line_number":2212,"context_line":"                                    mock.Mock())"},{"line_number":2213,"context_line":"            assertOtherFlag \u003d self.assertIn if flag_set[0] \\"},{"line_number":2214,"context_line":"                else self.assertNotIn"},{"line_number":2215,"context_line":"            assertOtherFlag(\u0027AdvOtherConfigFlag on;\u0027,"},{"line_number":2216,"context_line":"                self.utils_replace_file.call_args[0][1])"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_6eb5afcc","line":2213,"updated":"2015-01-20 20:23:00.000000000","message":"Wrap this in parens instead of using the escape character \\","commit_id":"8726777a6702fe47b2e1ee560b26b75dae2d1b9d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b9a258b374e14607c9935e00fab78b04b7fced41","unresolved":false,"context_lines":[{"line_number":2196,"context_line":"        self.assertIn(_join(\u0027-m\u0027, \u0027syslog\u0027), cmd)"},{"line_number":2197,"context_line":""},{"line_number":2198,"context_line":"    def test_generate_radvd_conf_other_and_managed_flag(self):"},{"line_number":2199,"context_line":"        # Other flag is redundant for stateful,"},{"line_number":2200,"context_line":"        # so not included in config file for RADVD, as per RFC4861"},{"line_number":2201,"context_line":"        expected \u003d {l3_constants.IPV6_SLAAC: [False, False],"},{"line_number":2202,"context_line":"                    l3_constants.DHCPV6_STATELESS: [True, False],"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a930d6b_1220b8f6","line":2199,"updated":"2015-01-21 12:14:33.000000000","message":"I don\u0027t believe we should actually test Other flag for stateful mode since this means we test implementation and not correctness of behaviour (Other flag is irrelevant for stateful mode, so it can have any value, so we should not check it).","commit_id":"f3ee7cfa0d2828893912c3fc176c8aebc56595dc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8139fef7a816f0e03655036d6a967c9164b50e56","unresolved":false,"context_lines":[{"line_number":2196,"context_line":"        self.assertIn(_join(\u0027-m\u0027, \u0027syslog\u0027), cmd)"},{"line_number":2197,"context_line":""},{"line_number":2198,"context_line":"    def test_generate_radvd_conf_other_and_managed_flag(self):"},{"line_number":2199,"context_line":"        # Other flag is redundant for stateful,"},{"line_number":2200,"context_line":"        # so not included in config file for RADVD, as per RFC4861"},{"line_number":2201,"context_line":"        expected \u003d {l3_constants.IPV6_SLAAC: [False, False],"},{"line_number":2202,"context_line":"                    l3_constants.DHCPV6_STATELESS: [True, False],"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a930d6b_721d7c73","line":2199,"in_reply_to":"1a930d6b_1220b8f6","updated":"2015-01-21 12:19:46.000000000","message":"You can define a special marker to put into your tuples to skip the check. Like:\n\n_skip_check \u003d object()\nexpected \u003d {l3_constants.DHCPV6_STATEFUL: (_skip_check, True), ...}\n...\nskip \u003d lambda flag: flag is _skip_check()\nfor ra_mode, flags_set ...:\n    other, managed \u003d flags_set\n    if skip(other):\n        ...\n    if skip(managed):\n        ...","commit_id":"f3ee7cfa0d2828893912c3fc176c8aebc56595dc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b9a258b374e14607c9935e00fab78b04b7fced41","unresolved":false,"context_lines":[{"line_number":2198,"context_line":"    def test_generate_radvd_conf_other_and_managed_flag(self):"},{"line_number":2199,"context_line":"        # Other flag is redundant for stateful,"},{"line_number":2200,"context_line":"        # so not included in config file for RADVD, as per RFC4861"},{"line_number":2201,"context_line":"        expected \u003d {l3_constants.IPV6_SLAAC: [False, False],"},{"line_number":2202,"context_line":"                    l3_constants.DHCPV6_STATELESS: [True, False],"},{"line_number":2203,"context_line":"                    l3_constants.DHCPV6_STATEFUL: [False, True]}"},{"line_number":2204,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a930d6b_d253906a","line":2201,"updated":"2015-01-21 12:14:33.000000000","message":"very tiny nit: I would prefer using tuples in cases like that where we don\u0027t need the iterable to be modifiable.","commit_id":"f3ee7cfa0d2828893912c3fc176c8aebc56595dc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b9a258b374e14607c9935e00fab78b04b7fced41","unresolved":false,"context_lines":[{"line_number":2202,"context_line":"                    l3_constants.DHCPV6_STATELESS: [True, False],"},{"line_number":2203,"context_line":"                    l3_constants.DHCPV6_STATEFUL: [False, True]}"},{"line_number":2204,"context_line":""},{"line_number":2205,"context_line":"        for ra_mode, flag_set in expected.iteritems():"},{"line_number":2206,"context_line":"            router \u003d prepare_router_data()"},{"line_number":2207,"context_line":"            ri \u003d self._process_router_ipv6_interface_added(router,"},{"line_number":2208,"context_line":"                                                           ra_mode\u003dra_mode)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a930d6b_1277d803","line":2205,"updated":"2015-01-21 12:14:33.000000000","message":"now it\u0027s flags_set, since multiple flags are defined there.","commit_id":"f3ee7cfa0d2828893912c3fc176c8aebc56595dc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b9a258b374e14607c9935e00fab78b04b7fced41","unresolved":false,"context_lines":[{"line_number":2210,"context_line":"            ra._generate_radvd_conf(ri.router[\u0027id\u0027],"},{"line_number":2211,"context_line":"                                    router[l3_constants.INTERFACE_KEY],"},{"line_number":2212,"context_line":"                                    mock.Mock())"},{"line_number":2213,"context_line":"            assertOtherFlag \u003d (self.assertIn if flag_set[0]"},{"line_number":2214,"context_line":"                else self.assertNotIn)"},{"line_number":2215,"context_line":"            assertOtherFlag(\u0027AdvOtherConfigFlag on;\u0027,"},{"line_number":2216,"context_line":"                self.utils_replace_file.call_args[0][1])"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a930d6b_b2ed248e","line":2213,"updated":"2015-01-21 12:14:33.000000000","message":"nit: how about using tuple unpacking instead of accessing flags by index?\n\ne.g. like:\n\nother, managed \u003d flags_set\nassertOtherFlag \u003d sefl.assertIn if other else self.assertNotIn","commit_id":"f3ee7cfa0d2828893912c3fc176c8aebc56595dc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b9a258b374e14607c9935e00fab78b04b7fced41","unresolved":false,"context_lines":[{"line_number":2214,"context_line":"                else self.assertNotIn)"},{"line_number":2215,"context_line":"            assertOtherFlag(\u0027AdvOtherConfigFlag on;\u0027,"},{"line_number":2216,"context_line":"                self.utils_replace_file.call_args[0][1])"},{"line_number":2217,"context_line":"            assertManagedFlag \u003d (self.assertIn if flag_set[1]"},{"line_number":2218,"context_line":"                else self.assertNotIn)"},{"line_number":2219,"context_line":"            assertManagedFlag(\u0027AdvManagedFlag on;\u0027,"},{"line_number":2220,"context_line":"                self.utils_replace_file.call_args[0][1])"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a930d6b_b2a44458","line":2217,"updated":"2015-01-21 12:14:33.000000000","message":"assert???Flag \u003d ...\nassert???Flag(...)\n\nseems to be used twice, so consider moving it into a local subfunction.","commit_id":"f3ee7cfa0d2828893912c3fc176c8aebc56595dc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"54c726b967da9bdf0952a2646a287c9b840fea99","unresolved":false,"context_lines":[{"line_number":2197,"context_line":""},{"line_number":2198,"context_line":"    def test_generate_radvd_conf_other_and_managed_flag(self):"},{"line_number":2199,"context_line":"        # Other flag is redundant for stateful,"},{"line_number":2200,"context_line":"        # so not included in config file for RADVD, as per RFC4861"},{"line_number":2201,"context_line":"        _skip_check \u003d object()"},{"line_number":2202,"context_line":"        skip \u003d lambda flag: True if flag is _skip_check else False"},{"line_number":2203,"context_line":"        expected \u003d {l3_constants.IPV6_SLAAC: (False, False),"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_e2b0a3df","line":2200,"updated":"2015-02-02 12:00:14.000000000","message":"We don\u0027t check that it\u0027s included or not now, so please revert to original comment. Also, I guess the comment is better to be moved into line prior to 2205.","commit_id":"d06fd665b9ec70136131dce2e7fc74fd97d1091a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"676a0a0b38e727e4e45de4275b6f0cc19f9677ff","unresolved":false,"context_lines":[{"line_number":2201,"context_line":""},{"line_number":2202,"context_line":"        expected \u003d {l3_constants.IPV6_SLAAC: (False, False),"},{"line_number":2203,"context_line":"                    l3_constants.DHCPV6_STATELESS: (True, False),"},{"line_number":2204,"context_line":"        # we don\u0027t check other flag for stateful since it\u0027s redundant"},{"line_number":2205,"context_line":"        # for this mode and can be ignored by clients, as per RFC4861"},{"line_number":2206,"context_line":"                    l3_constants.DHCPV6_STATEFUL: (_skip_check, True)}"},{"line_number":2207,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_6b3542f6","line":2204,"updated":"2015-02-03 07:40:20.000000000","message":"I wonder if pep8 will be ok with that.","commit_id":"1f337c761bf73df050e435214935c498a2b3d028"}]}