)]}'
{"neutron/tests/unit/ml2/drivers/cisco/apic/test_cisco_apic_mechanism_driver.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"623fc46f527866c5301558f65b604dc7f23e2e5a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            mocked.APIC_TENANT, mocked.APIC_NETWORK, HOST_ID1,"},{"line_number":89,"context_line":"            ENCAP, transaction\u003d\u0027transaction\u0027)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_create_port_postcommit(self):"},{"line_number":92,"context_line":"        net_ctx \u003d self._get_network_context(mocked.APIC_TENANT,"},{"line_number":93,"context_line":"                                            mocked.APIC_NETWORK,"},{"line_number":94,"context_line":"                                            TEST_SEGMENT1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_a2379f4c","line":91,"updated":"2015-01-10 01:09:14.000000000","message":"What exactly is being tested here?  The test name gives no useful indication.","commit_id":"a6c5cc7bfd00835ee066e9736f3c8056210a6071"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"67427698edcc376aa81e6faca79b20f1eab8b6e0","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            mocked.APIC_TENANT, mocked.APIC_NETWORK, HOST_ID1,"},{"line_number":89,"context_line":"            ENCAP, transaction\u003d\u0027transaction\u0027)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_create_port_postcommit(self):"},{"line_number":92,"context_line":"        net_ctx \u003d self._get_network_context(mocked.APIC_TENANT,"},{"line_number":93,"context_line":"                                            mocked.APIC_NETWORK,"},{"line_number":94,"context_line":"                                            TEST_SEGMENT1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_f9cdce5f","line":91,"in_reply_to":"3a961159_a2379f4c","updated":"2015-01-11 23:57:15.000000000","message":"Good point, I\u0027ll change with something better","commit_id":"a6c5cc7bfd00835ee066e9736f3c8056210a6071"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"623fc46f527866c5301558f65b604dc7f23e2e5a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                          device_owner\u003d\u0027any\u0027)"},{"line_number":99,"context_line":"        mgr \u003d self.driver.apic_manager"},{"line_number":100,"context_line":"        self.driver.create_port_postcommit(port_ctx)"},{"line_number":101,"context_line":"        mgr.ensure_path_created_for_port.assert_called_once_with("},{"line_number":102,"context_line":"            mocked.APIC_TENANT, mocked.APIC_NETWORK, HOST_ID1,"},{"line_number":103,"context_line":"            ENCAP, transaction\u003d\u0027transaction\u0027)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_7ec9cf24","line":101,"updated":"2015-01-10 01:09:14.000000000","message":"Behavior verification is an anti-pattern - isn\u0027t there another way you can test this?\n\nSee: http://googletesting.blogspot.com/2013/03/testing-on-toilet-testing-state-vs.html","commit_id":"a6c5cc7bfd00835ee066e9736f3c8056210a6071"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"67427698edcc376aa81e6faca79b20f1eab8b6e0","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                          device_owner\u003d\u0027any\u0027)"},{"line_number":99,"context_line":"        mgr \u003d self.driver.apic_manager"},{"line_number":100,"context_line":"        self.driver.create_port_postcommit(port_ctx)"},{"line_number":101,"context_line":"        mgr.ensure_path_created_for_port.assert_called_once_with("},{"line_number":102,"context_line":"            mocked.APIC_TENANT, mocked.APIC_NETWORK, HOST_ID1,"},{"line_number":103,"context_line":"            ENCAP, transaction\u003d\u0027transaction\u0027)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_b9e426e1","line":101,"in_reply_to":"3a961159_7ec9cf24","updated":"2015-01-11 23:57:15.000000000","message":"This case is somewhat similar to what is presented in the latest point of your linked article (the MVC case). The final state of the tested method is actually determined by the \"ensure_path_created_for_port\" call, which is a method defined in a vendor (apicapi) library which ultimately calls the backed APIs. So its behavior is abstracted from the logic of the tested method.","commit_id":"a6c5cc7bfd00835ee066e9736f3c8056210a6071"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0bdb9a64daf037e95d484c07cf0db149de248fdf","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                          device_owner\u003d\u0027any\u0027)"},{"line_number":99,"context_line":"        mgr \u003d self.driver.apic_manager"},{"line_number":100,"context_line":"        self.driver.create_port_postcommit(port_ctx)"},{"line_number":101,"context_line":"        mgr.ensure_path_created_for_port.assert_called_once_with("},{"line_number":102,"context_line":"            mocked.APIC_TENANT, mocked.APIC_NETWORK, HOST_ID1,"},{"line_number":103,"context_line":"            ENCAP, transaction\u003d\u0027transaction\u0027)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_9fee4eec","line":101,"in_reply_to":"3a961159_b9e426e1","updated":"2015-01-12 20:12:46.000000000","message":"I agree with Ivar here. It seems like ensure_path_created is pushing the end state into what is essentially a black box.","commit_id":"a6c5cc7bfd00835ee066e9736f3c8056210a6071"}]}
