)]}'
{"neutron/agent/l3/agent.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"d4ffc3c252ce970441c8dfc29645a1d87e791912","unresolved":false,"context_lines":[{"line_number":704,"context_line":"                if is_first:"},{"line_number":705,"context_line":"                    self._create_agent_gateway_port(ri, ext_net_id)"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"            if self.agent_gateway_port:"},{"line_number":708,"context_line":"                if floating_ips and ri.dist_fip_count \u003d\u003d 0:"},{"line_number":709,"context_line":"                    self.create_rtr_2_fip_link(ri, ext_net_id)"},{"line_number":710,"context_line":"                return fip_ns.get_rtr_ext_device_name(ri.router_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_f84fbabb","line":707,"updated":"2015-01-08 19:53:12.000000000","message":"Agent_gateway_port here is not a list and specific to the agent.\nIf we need to address multiple external networks per agent, then the agent_gateway_port should be list containing all the agent_gateway_ports for that particular agent.\n\nOtherwise since the \"agent_gateway_port\" is specific to the external_network and fip namespace, this variable \"agent_gateway_port\" should be part of the fip-namespace class.\n\nIf it makes sense we can even move this function to the fip namespace class.","commit_id":"c2c0e412c82e4d84ca9657146f61a9b5c65b2496"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d7bdf237456321736dd402b9e38e5d1c6c89dad1","unresolved":false,"context_lines":[{"line_number":704,"context_line":"                if is_first:"},{"line_number":705,"context_line":"                    self._create_agent_gateway_port(ri, ext_net_id)"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"            if self.agent_gateway_port:"},{"line_number":708,"context_line":"                if floating_ips and ri.dist_fip_count \u003d\u003d 0:"},{"line_number":709,"context_line":"                    self.create_rtr_2_fip_link(ri, ext_net_id)"},{"line_number":710,"context_line":"                return fip_ns.get_rtr_ext_device_name(ri.router_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_139c6069","line":707,"in_reply_to":"3a961159_f84fbabb","updated":"2015-01-08 23:34:38.000000000","message":"Swami, thanks.  I\u0027ll take a look today to see if it makes sense to move this all the way to the fip namespace class with this patch.  I agree that this method will definitely move at some point in the coming weeks.  At the least, it will go to the DvrRouter class.\n\nTeasing all of this code apart has proven to be a very laborious task.  :)","commit_id":"c2c0e412c82e4d84ca9657146f61a9b5c65b2496"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e0e317fc00a0f3bf668fd652374a97d72eee2044","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        ri.iptables_manager.apply()"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"    def _get_external_device_interface_name(self, ri, ex_gw_port,"},{"line_number":697,"context_line":"                                            floating_ips):"},{"line_number":698,"context_line":"        if ri.router[\u0027distributed\u0027]:"},{"line_number":699,"context_line":"            # filter out only FIPs for this host/agent"},{"line_number":700,"context_line":"            floating_ips \u003d [i for i in floating_ips if i[\u0027host\u0027] \u003d\u003d self.host]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_3221bd9e","side":"PARENT","line":697,"updated":"2015-01-14 19:02:20.000000000","message":"Maybe I don\u0027t need to inline this here.  Eventually, this code will all be relocated.","commit_id":"f45139efaafbd653ef7eb94696cab6c15069f71d"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"d0c9d359ea8a01172e62bf1c205f0764878c48b0","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        if ri.router[\u0027distributed\u0027]:"},{"line_number":749,"context_line":"            # filter out only FIPs for this host/agent"},{"line_number":750,"context_line":"            # TODO(Carl) I think this is redundant now."},{"line_number":751,"context_line":"            floating_ips \u003d [i for i in floating_ips if i[\u0027host\u0027] \u003d\u003d self.host]"},{"line_number":752,"context_line":"            ext_net_id \u003d ex_gw_port[\u0027network_id\u0027]"},{"line_number":753,"context_line":"            fip_ns \u003d self.get_fip_ns(ext_net_id)"},{"line_number":754,"context_line":"            if floating_ips:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_1ca69a0f","line":751,"updated":"2015-01-14 20:18:34.000000000","message":"Yes, this would be redundant because get_floating_ips(...) already returns host specific values.","commit_id":"7967de8f13a13f91816a8fe543ae958cdd6b1e2e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"d7b1214182fa359f4634e5ebc3ded13acc385b7c","unresolved":false,"context_lines":[{"line_number":708,"context_line":"                    agent_gateway_port \u003d ("},{"line_number":709,"context_line":"                        self.plugin_rpc.get_agent_gateway_port("},{"line_number":710,"context_line":"                            self.context, ext_net_id))"},{"line_number":711,"context_line":"                    if \u0027subnet\u0027 not in agent_gateway_port:"},{"line_number":712,"context_line":"                        LOG.error(_LE(\u0027Missing subnet/agent_gateway_port\u0027))"},{"line_number":713,"context_line":"                    else:"},{"line_number":714,"context_line":"                        self._set_subnet_info(agent_gateway_port)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_596486b2","line":711,"updated":"2015-01-15 17:35:03.000000000","message":"Seems like we\u0027re adding some error checking here. Do we have test cases that exercise these paths?","commit_id":"9d91573836f17d3a6f92ffb074eb346de6249c9a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b3bab851327d567992461c97d132d0ef27430740","unresolved":false,"context_lines":[{"line_number":708,"context_line":"                    agent_gateway_port \u003d ("},{"line_number":709,"context_line":"                        self.plugin_rpc.get_agent_gateway_port("},{"line_number":710,"context_line":"                            self.context, ext_net_id))"},{"line_number":711,"context_line":"                    if \u0027subnet\u0027 not in agent_gateway_port:"},{"line_number":712,"context_line":"                        LOG.error(_LE(\u0027Missing subnet/agent_gateway_port\u0027))"},{"line_number":713,"context_line":"                    else:"},{"line_number":714,"context_line":"                        self._set_subnet_info(agent_gateway_port)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_2fb92c16","line":711,"in_reply_to":"3a961159_596486b2","updated":"2015-01-15 18:29:27.000000000","message":"Paul, this code was moved from neutron/agent/l3/dvr.py:L256.  So, it wasn\u0027t exactly added and this will not be its final resting place.  Would you mind if I defer adding a test until it reaches its final resting place?","commit_id":"9d91573836f17d3a6f92ffb074eb346de6249c9a"},{"author":{"_account_id":10971,"name":"Michael Smith","email":"michael.smith6@hp.com","username":"mrsmith"},"change_message_id":"8d07e830ec86a0c627216b84543fa194761b4389","unresolved":false,"context_lines":[{"line_number":722,"context_line":"                    # configured"},{"line_number":723,"context_line":"                    self.process_router_add(ri)"},{"line_number":724,"context_line":"                return fip_ns.get_rtr_ext_device_name(ri.router_id)"},{"line_number":725,"context_line":"            else:"},{"line_number":726,"context_line":"                # there are no fips or agent port, no work to do"},{"line_number":727,"context_line":"                return None"},{"line_number":728,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_dd4c0579","line":725,"updated":"2015-01-15 00:14:56.000000000","message":"Have you seen Sylvain\u0027s refactor patch for  _get_external_device_interface_name? It splits up the functionality nicely. https://review.openstack.org/#/c/136042/ Any chance to go more in that direction here?  Or getting that one merged?","commit_id":"9d91573836f17d3a6f92ffb074eb346de6249c9a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"535c304a55ce131fc487e774bbfc89373272c8af","unresolved":false,"context_lines":[{"line_number":674,"context_line":""},{"line_number":675,"context_line":"                # kicks the FW Agent to add rules for the IR namespace if"},{"line_number":676,"context_line":"                # configured"},{"line_number":677,"context_line":"                self.process_router_add(ri)"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"    def _get_external_device_interface_name(self, ri, ex_gw_port):"},{"line_number":680,"context_line":"        if ri.router[\u0027distributed\u0027]:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a930d6b_9934a8df","line":677,"updated":"2015-01-22 10:40:19.000000000","message":"nit/question: this isn\u0027t out of the scope of this patch ^? was it missing before?","commit_id":"8b432c942b0fe68205b2810dc3459a95d31b46f3"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ab52a3a1fbfceb7d5c0824f6956eb7278f863563","unresolved":false,"context_lines":[{"line_number":674,"context_line":""},{"line_number":675,"context_line":"                # kicks the FW Agent to add rules for the IR namespace if"},{"line_number":676,"context_line":"                # configured"},{"line_number":677,"context_line":"                self.process_router_add(ri)"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"    def _get_external_device_interface_name(self, ri, ex_gw_port):"},{"line_number":680,"context_line":"        if ri.router[\u0027distributed\u0027]:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a930d6b_e48140c4","line":677,"in_reply_to":"1a930d6b_9934a8df","updated":"2015-01-23 20:48:37.000000000","message":"This popped out of here [1].  It is part of teasing all of this apart.  Since I couldn\u0027t exactly move it cleanly in to create_rtr_2_fip_link, it had to pop out here.  So, it is definitely in scope for this patch.\n\nI know it looks a bit funny for this code to suddenly pop out here but it must be done.\n\n[1] https://review.openstack.org/#/c/145565/12/neutron/agent/l3/dvr.py L308 in the old version.","commit_id":"8b432c942b0fe68205b2810dc3459a95d31b46f3"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9b9ce9fce6215ea51a43b230a2b65e92e8f25c52","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                    fip_ns.create_gateway_port(agent_gateway_port)"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        if fip_ns.agent_gateway_port and floating_ips:"},{"line_number":672,"context_line":"            if floating_ips and ri.dist_fip_count \u003d\u003d 0:"},{"line_number":673,"context_line":"                fip_ns.create_rtr_2_fip_link(ri)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"                # kicks the FW Agent to add rules for the IR namespace if"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a930d6b_75041818","line":672,"updated":"2015-01-23 22:34:59.000000000","message":"Checking floating_ips in this conditional is redundant.","commit_id":"59afccbbe449af9fe79a668d69104e93ca231f74"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1a125da293c5c8e8934072e9b9e599020c6c8983","unresolved":false,"context_lines":[{"line_number":679,"context_line":"    def _get_external_device_interface_name(self, ri, ex_gw_port):"},{"line_number":680,"context_line":"        if ri.router[\u0027distributed\u0027]:"},{"line_number":681,"context_line":"            ext_net_id \u003d ex_gw_port[\u0027network_id\u0027]"},{"line_number":682,"context_line":"            fip_ns \u003d self.get_fip_ns(ext_net_id)"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"            fip_int \u003d self.get_fip_int_device_name(ri.router_id)"},{"line_number":685,"context_line":"            ns_name \u003d self.get_fip_ns_name(fip_ns.get_name())"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a930d6b_b57be0f3","line":682,"updated":"2015-01-23 22:31:32.000000000","message":"ex_net_id could be inlined here.","commit_id":"59afccbbe449af9fe79a668d69104e93ca231f74"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1a125da293c5c8e8934072e9b9e599020c6c8983","unresolved":false,"context_lines":[{"line_number":682,"context_line":"            fip_ns \u003d self.get_fip_ns(ext_net_id)"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"            fip_int \u003d self.get_fip_int_device_name(ri.router_id)"},{"line_number":685,"context_line":"            ns_name \u003d self.get_fip_ns_name(fip_ns.get_name())"},{"line_number":686,"context_line":"            if ip_lib.device_exists(fip_int,"},{"line_number":687,"context_line":"                                    root_helper\u003dself.root_helper,"},{"line_number":688,"context_line":"                                    namespace\u003dns_name):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a930d6b_55d0fcf5","line":685,"updated":"2015-01-23 22:31:32.000000000","message":"Oops.  This is all just fip_ns.get_name()","commit_id":"59afccbbe449af9fe79a668d69104e93ca231f74"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"777015b361f313849913c6d38fc6064c0c29f7be","unresolved":false,"context_lines":[{"line_number":581,"context_line":"        # TODO(mrsmith) - we shouldn\u0027t need to check here"},{"line_number":582,"context_line":"        if \u0027distributed\u0027 not in ri.router:"},{"line_number":583,"context_line":"            ri.router[\u0027distributed\u0027] \u003d False"},{"line_number":584,"context_line":"        self.scan_fip_ports(ri)"},{"line_number":585,"context_line":"        self._process_internal_ports(ri)"},{"line_number":586,"context_line":"        self._process_external(ri)"},{"line_number":587,"context_line":"        # Process static routes for router"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a930d6b_853928a6","line":584,"updated":"2015-01-26 18:42:24.000000000","message":"Need to know the fip_ns in order to call this.  This should only be done in dvr context.  Might look messy in this patch but soon the refactoring will clean it up.","commit_id":"c8bcd0cc13f11a036d17f710be4628738a97b164"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"777015b361f313849913c6d38fc6064c0c29f7be","unresolved":false,"context_lines":[{"line_number":679,"context_line":"        if ri.router[\u0027distributed\u0027]:"},{"line_number":680,"context_line":"            fip_ns \u003d self.get_fip_ns(ex_gw_port[\u0027network_id\u0027])"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"            fip_int \u003d self.get_fip_int_device_name(ri.router_id)"},{"line_number":683,"context_line":"            if ip_lib.device_exists(fip_int,"},{"line_number":684,"context_line":"                                    root_helper\u003dself.root_helper,"},{"line_number":685,"context_line":"                                    namespace\u003dfip_ns.get_name()):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a930d6b_1afaf374","line":682,"updated":"2015-01-26 18:42:24.000000000","message":"This needs to change to fip_ns.get_int_device_name(...)","commit_id":"c8bcd0cc13f11a036d17f710be4628738a97b164"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"93fc8539c5c7cee960a7f90b8197bb7da9e9a13f","unresolved":false,"context_lines":[{"line_number":574,"context_line":"                # All floating IPs must be put in error state"},{"line_number":575,"context_line":"                fip_statuses \u003d self._put_fips_in_error_state(ri)"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        self._update_fip_statuses(ri, existing_floating_ips, fip_statuses)"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"    @common_utils.exception_logger()"},{"line_number":580,"context_line":"    def process_router(self, ri):"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa81d914_99e6a715","line":577,"updated":"2015-01-27 20:52:52.000000000","message":"If there is a FloatingIpSetupException the fip_statuses will not be defined and result in Name error here ?","commit_id":"aada1fa816738a6f92e4654aa97f9eb5b8459424"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"e18de1adbb5cf64ce4046e14871f2fee13b72e10","unresolved":false,"context_lines":[{"line_number":574,"context_line":"                # All floating IPs must be put in error state"},{"line_number":575,"context_line":"                fip_statuses \u003d self._put_fips_in_error_state(ri)"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        self._update_fip_statuses(ri, existing_floating_ips, fip_statuses)"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"    @common_utils.exception_logger()"},{"line_number":580,"context_line":"    def process_router(self, ri):"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa81d914_bf850baf","line":577,"in_reply_to":"fa81d914_1f829752","updated":"2015-01-27 21:36:45.000000000","message":"Thanks I see it, my bad.","commit_id":"aada1fa816738a6f92e4654aa97f9eb5b8459424"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ab5dea0787aa50a222599865f99f7d4e6593aa2f","unresolved":false,"context_lines":[{"line_number":574,"context_line":"                # All floating IPs must be put in error state"},{"line_number":575,"context_line":"                fip_statuses \u003d self._put_fips_in_error_state(ri)"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        self._update_fip_statuses(ri, existing_floating_ips, fip_statuses)"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"    @common_utils.exception_logger()"},{"line_number":580,"context_line":"    def process_router(self, ri):"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa81d914_1f829752","line":577,"in_reply_to":"fa81d914_99e6a715","updated":"2015-01-27 21:21:57.000000000","message":"No.  fip_statuses is defined on L575 in the exception case.  This discussion is out of this patch\u0027s scope, no?","commit_id":"aada1fa816738a6f92e4654aa97f9eb5b8459424"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"2a8b5afccce41c52a4be53f7ea3665eeb8362a1a","unresolved":false,"context_lines":[{"line_number":664,"context_line":"                agent_gateway_port \u003d ("},{"line_number":665,"context_line":"                    self.plugin_rpc.get_agent_gateway_port("},{"line_number":666,"context_line":"                        self.context, ext_net_id))"},{"line_number":667,"context_line":"                if \u0027subnet\u0027 not in agent_gateway_port:"},{"line_number":668,"context_line":"                    LOG.error(_LE(\u0027Missing subnet/agent_gateway_port\u0027))"},{"line_number":669,"context_line":"                else:"},{"line_number":670,"context_line":"                    self._set_subnet_info(agent_gateway_port)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a930d6b_9c940c8c","line":667,"updated":"2015-01-27 01:53:34.000000000","message":"Why would this happen out of curiosity?","commit_id":"aada1fa816738a6f92e4654aa97f9eb5b8459424"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2fe880b1d61a13cc423b7974e045e3ce8d429638","unresolved":false,"context_lines":[{"line_number":664,"context_line":"                agent_gateway_port \u003d ("},{"line_number":665,"context_line":"                    self.plugin_rpc.get_agent_gateway_port("},{"line_number":666,"context_line":"                        self.context, ext_net_id))"},{"line_number":667,"context_line":"                if \u0027subnet\u0027 not in agent_gateway_port:"},{"line_number":668,"context_line":"                    LOG.error(_LE(\u0027Missing subnet/agent_gateway_port\u0027))"},{"line_number":669,"context_line":"                else:"},{"line_number":670,"context_line":"                    self._set_subnet_info(agent_gateway_port)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a930d6b_46055812","line":667,"in_reply_to":"1a930d6b_9c940c8c","updated":"2015-01-27 16:41:40.000000000","message":"Honestly, I don\u0027t know.  I include it here because the old code did the same in neutron/agent/l3/dvr.py L301.\n\nThis is a part of _create_agent_gateway_port which couldn\u0027t be easily moved to dvr_fip_ns.py because it makes an rpc call which I felt was an awkward thing to do at that point.  So, I punted it out here to the agent to be refactored in a later step.\n\nThis code preserves the behavior of the old code which is a major goal of this patch.","commit_id":"aada1fa816738a6f92e4654aa97f9eb5b8459424"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"93fc8539c5c7cee960a7f90b8197bb7da9e9a13f","unresolved":false,"context_lines":[{"line_number":670,"context_line":"                    self._set_subnet_info(agent_gateway_port)"},{"line_number":671,"context_line":"                    fip_ns.create_gateway_port(agent_gateway_port)"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"        if fip_ns.agent_gateway_port and floating_ips:"},{"line_number":674,"context_line":"            if ri.dist_fip_count \u003d\u003d 0:"},{"line_number":675,"context_line":"                fip_ns.create_rtr_2_fip_link(ri)"},{"line_number":676,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"1a930d6b_b6cc65bc","line":673,"updated":"2015-01-27 20:52:52.000000000","message":"Can this check be avoided by adding this code to the \u0027if\u0027 block started at line 661?","commit_id":"aada1fa816738a6f92e4654aa97f9eb5b8459424"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ab5dea0787aa50a222599865f99f7d4e6593aa2f","unresolved":false,"context_lines":[{"line_number":670,"context_line":"                    self._set_subnet_info(agent_gateway_port)"},{"line_number":671,"context_line":"                    fip_ns.create_gateway_port(agent_gateway_port)"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"        if fip_ns.agent_gateway_port and floating_ips:"},{"line_number":674,"context_line":"            if ri.dist_fip_count \u003d\u003d 0:"},{"line_number":675,"context_line":"                fip_ns.create_rtr_2_fip_link(ri)"},{"line_number":676,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"fa81d914_1fe9b71a","line":673,"in_reply_to":"1a930d6b_b6cc65bc","updated":"2015-01-27 21:21:57.000000000","message":"That could be done but I don\u0027t think this patch needs to do it (the original was the same).  It is already large and difficult to review as it is.","commit_id":"aada1fa816738a6f92e4654aa97f9eb5b8459424"}],"neutron/agent/l3/dvr.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"d4ffc3c252ce970441c8dfc29645a1d87e791912","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class AgentMixin(object):"},{"line_number":36,"context_line":"    def __init__(self, host):"},{"line_number":37,"context_line":"        # dvr data"},{"line_number":38,"context_line":"        self.agent_gateway_port \u003d None"},{"line_number":39,"context_line":"        self._fip_nses \u003d {}"},{"line_number":40,"context_line":"        self.local_subnets \u003d lla.LinkLocalAllocator("},{"line_number":41,"context_line":"            os.path.join(self.conf.state_path, \u0027fip-linklocal-networks\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_38ddc2dd","line":38,"updated":"2015-01-08 19:53:12.000000000","message":"I think this \"agent_gateway_port\" should be a list rather an a variable. This one holds that agent_gateway_port for every external network. \nIf there are multiple external networks on the same agent, then we may override this port.\n\nAs mentioned in my previous comment, this can also be moved to the \"fipnamespace class\".","commit_id":"c2c0e412c82e4d84ca9657146f61a9b5c65b2496"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d7bdf237456321736dd402b9e38e5d1c6c89dad1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class AgentMixin(object):"},{"line_number":36,"context_line":"    def __init__(self, host):"},{"line_number":37,"context_line":"        # dvr data"},{"line_number":38,"context_line":"        self.agent_gateway_port \u003d None"},{"line_number":39,"context_line":"        self._fip_nses \u003d {}"},{"line_number":40,"context_line":"        self.local_subnets \u003d lla.LinkLocalAllocator("},{"line_number":41,"context_line":"            os.path.join(self.conf.state_path, \u0027fip-linklocal-networks\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_336ebc64","line":38,"in_reply_to":"3a961159_38ddc2dd","updated":"2015-01-08 23:34:38.000000000","message":"I will look at it.  I see what you\u0027re getting at.  I\u0027ll see if it makes sense to handle this in this patch or in a subsequent step.","commit_id":"c2c0e412c82e4d84ca9657146f61a9b5c65b2496"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"00c72213e0feece59391563e0e40ddf2d599bd90","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        if ext_net_id not in self._fip_nses:"},{"line_number":52,"context_line":"            fip_ns \u003d dvr_fip_ns.FipNamespace(self.driver, ext_net_id)"},{"line_number":53,"context_line":"            self._fip_nses[ext_net_id] \u003d fip_ns"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        return self._fip_nses[ext_net_id]"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_6ad76d23","line":53,"updated":"2015-01-08 21:27:51.000000000","message":"I did not see a removal of fip_ns from fip_nses, assuming that is in progress. Placing a -1 for this reason.","commit_id":"c2c0e412c82e4d84ca9657146f61a9b5c65b2496"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d7bdf237456321736dd402b9e38e5d1c6c89dad1","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        if ext_net_id not in self._fip_nses:"},{"line_number":52,"context_line":"            fip_ns \u003d dvr_fip_ns.FipNamespace(self.driver, ext_net_id)"},{"line_number":53,"context_line":"            self._fip_nses[ext_net_id] \u003d fip_ns"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        return self._fip_nses[ext_net_id]"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_f3c5143d","line":53,"in_reply_to":"3a961159_6ad76d23","updated":"2015-01-08 23:34:38.000000000","message":"You\u0027re right.  I haven\u0027t handled the namespace removal code yet.  That is part of the reason this is still marked WIP.","commit_id":"c2c0e412c82e4d84ca9657146f61a9b5c65b2496"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"00c72213e0feece59391563e0e40ddf2d599bd90","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            ns_ip.del_veth(fip_2_rtr_name)"},{"line_number":343,"context_line":"            is_last \u003d fip_ns.unsubscribe(ri.router_id)"},{"line_number":344,"context_line":"            # clean up fip-namespace if this is the last FIP"},{"line_number":345,"context_line":"            if is_last:"},{"line_number":346,"context_line":"                self._destroy_fip_namespace(fip_ns_name)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def _snat_redirect_add(self, ri, gateway, sn_port, sn_int):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_2a972546","line":345,"updated":"2015-01-08 21:27:51.000000000","message":"would it make sense to invoke the destructor for the FipNamespace at this point and have it clean up the ports and delete the namespace?","commit_id":"c2c0e412c82e4d84ca9657146f61a9b5c65b2496"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d7bdf237456321736dd402b9e38e5d1c6c89dad1","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            ns_ip.del_veth(fip_2_rtr_name)"},{"line_number":343,"context_line":"            is_last \u003d fip_ns.unsubscribe(ri.router_id)"},{"line_number":344,"context_line":"            # clean up fip-namespace if this is the last FIP"},{"line_number":345,"context_line":"            if is_last:"},{"line_number":346,"context_line":"                self._destroy_fip_namespace(fip_ns_name)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def _snat_redirect_add(self, ri, gateway, sn_port, sn_int):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_732f64f6","line":345,"in_reply_to":"3a961159_2a972546","updated":"2015-01-08 23:34:38.000000000","message":"Yes, it would.  I\u0027ll tackle that next as part of this same patch.  Thanks for the feedback.","commit_id":"c2c0e412c82e4d84ca9657146f61a9b5c65b2496"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"d0c9d359ea8a01172e62bf1c205f0764878c48b0","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        ip_wrapper.netns.execute([\u0027ip\u0027, \u0027addr\u0027, \u0027add\u0027,"},{"line_number":169,"context_line":"                                  ip_cidr, \u0027dev\u0027, interface_name])"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _handle_router_fip_nat_rules(self, ri, interface_name, action):"},{"line_number":172,"context_line":"        \"\"\"Configures NAT rules for Floating IPs for DVR."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"           Remove all the rules. This is safe because if"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_48f85cc4","side":"PARENT","line":171,"updated":"2015-01-14 20:18:34.000000000","message":"These rules get added to the router namespace so this method should not be moved to the fip namespace class","commit_id":"f45139efaafbd653ef7eb94696cab6c15069f71d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"61a698d3fddf2cabc80e21a61b9ce514e69ae545","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        ip_wrapper.netns.execute([\u0027ip\u0027, \u0027addr\u0027, \u0027add\u0027,"},{"line_number":169,"context_line":"                                  ip_cidr, \u0027dev\u0027, interface_name])"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _handle_router_fip_nat_rules(self, ri, interface_name, action):"},{"line_number":172,"context_line":"        \"\"\"Configures NAT rules for Floating IPs for DVR."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"           Remove all the rules. This is safe because if"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a930d6b_1f1bb873","side":"PARENT","line":171,"in_reply_to":"1a930d6b_7b73864d","updated":"2015-01-26 21:25:23.000000000","message":"I moved it because it is only referenced from create_rtr_2_fip_link which indicated to me that it is only used in the case when dvr fip is in use.  It would be awkward to not move it because of the way it is called.  That is why I moved it with this patch.  I will move it to the dvr_router class where it is more appropriate.","commit_id":"f45139efaafbd653ef7eb94696cab6c15069f71d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8c94341a03cc5758c38067cae6e5bee42978b218","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        ip_wrapper.netns.execute([\u0027ip\u0027, \u0027addr\u0027, \u0027add\u0027,"},{"line_number":169,"context_line":"                                  ip_cidr, \u0027dev\u0027, interface_name])"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _handle_router_fip_nat_rules(self, ri, interface_name, action):"},{"line_number":172,"context_line":"        \"\"\"Configures NAT rules for Floating IPs for DVR."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"           Remove all the rules. This is safe because if"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a930d6b_7b73864d","side":"PARENT","line":171,"in_reply_to":"3a961159_48f85cc4","updated":"2015-01-21 19:39:59.000000000","message":"Rajeev.  Sorry I missed this comment until today.  I will take another look.  Don\u0027t be shy to -1 if you make a comment like this in order to get my attention.","commit_id":"f45139efaafbd653ef7eb94696cab6c15069f71d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"535c304a55ce131fc487e774bbfc89373272c8af","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def get_fip_ns(self, ext_net_id):"},{"line_number":37,"context_line":"        # TODO(Carl) is this necessary?  Code that this replaced was careful to"},{"line_number":38,"context_line":"        # convert these to string like this so I preserved that."},{"line_number":39,"context_line":"        ext_net_id \u003d str(ext_net_id)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        if ext_net_id not in self._fip_nses:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a930d6b_d9d0f055","line":38,"updated":"2015-01-22 10:40:19.000000000","message":"Yes, seems weird to me too.., generally we get here by splicing strings, so why str( again?, a mystery to solve.","commit_id":"8b432c942b0fe68205b2810dc3459a95d31b46f3"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ab52a3a1fbfceb7d5c0824f6956eb7278f863563","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def get_fip_ns(self, ext_net_id):"},{"line_number":37,"context_line":"        # TODO(Carl) is this necessary?  Code that this replaced was careful to"},{"line_number":38,"context_line":"        # convert these to string like this so I preserved that."},{"line_number":39,"context_line":"        ext_net_id \u003d str(ext_net_id)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        if ext_net_id not in self._fip_nses:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a930d6b_0f5bc52e","line":38,"in_reply_to":"1a930d6b_d9d0f055","updated":"2015-01-23 20:48:37.000000000","message":"It isn\u0027t hurting anything and I have bigger fish to fry.  Maybe I\u0027ll follow up with another patch later which tries to remove it.","commit_id":"8b432c942b0fe68205b2810dc3459a95d31b46f3"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"777015b361f313849913c6d38fc6064c0c29f7be","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                if f[\u0027subnet_id\u0027] \u003d\u003d subnet_id:"},{"line_number":98,"context_line":"                    return port"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def scan_fip_ports(self, ri):"},{"line_number":101,"context_line":"        # don\u0027t scan if not dvr or count is not None"},{"line_number":102,"context_line":"        if not ri.router.get(\u0027distributed\u0027) or ri.dist_fip_count is not None:"},{"line_number":103,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a930d6b_256794ea","line":100,"updated":"2015-01-26 18:42:24.000000000","message":"This should probably move to dvr_fip_ns.py","commit_id":"c8bcd0cc13f11a036d17f710be4628738a97b164"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"777015b361f313849913c6d38fc6064c0c29f7be","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        if floating_ip in ri.floating_ips_dict:"},{"line_number":228,"context_line":"            rule_pr \u003d ri.floating_ips_dict[floating_ip]"},{"line_number":229,"context_line":"            ip_rule_rtr.delete_rule_priority(rule_pr)"},{"line_number":230,"context_line":"            self.fip_priorities.add(rule_pr)"},{"line_number":231,"context_line":"            #TODO(rajeev): Handle else case - exception/log?"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        device \u003d ip_lib.IPDevice(fip_2_rtr_name, self.root_helper,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a930d6b_0bdf076a","line":230,"updated":"2015-01-26 18:42:24.000000000","message":"Yikes!  fip_priorities is gone!  I must have missed this in the rebase conflict resolution.","commit_id":"c8bcd0cc13f11a036d17f710be4628738a97b164"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8cdd2fdc35fb4c19a8b03cb73e36ec6ac31ff9c7","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            rule_pr \u003d ri.floating_ips_dict[floating_ip]"},{"line_number":207,"context_line":"            ip_rule \u003d ip_lib.IpRule(self.root_helper, namespace\u003dri.ns_name)"},{"line_number":208,"context_line":"            ip_rule.delete(floating_ip, FIP_RT_TBL, rule_pr)"},{"line_number":209,"context_line":"            self.fip_priorities.add(rule_pr)"},{"line_number":210,"context_line":"            ri.fip_ns.deallocate_rule_priority(rule_pr)"},{"line_number":211,"context_line":"            #TODO(rajeev): Handle else case - exception/log?"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"da86d52c_5ee7b1e4","line":209,"updated":"2015-01-30 23:43:28.000000000","message":"This line above shouldn\u0027t be there.","commit_id":"6c625efae1f5b4c17b9a21f982eb9058a21eaf52"}],"neutron/agent/l3/dvr_fip_ns.py":[{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"00c72213e0feece59391563e0e40ddf2d599bd90","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def __init__(self, driver, ext_net_id):"},{"line_number":26,"context_line":"        self._ext_net_id \u003d ext_net_id"},{"line_number":27,"context_line":"        self._subscribers \u003d set()"},{"line_number":28,"context_line":"        self._rule_priorities \u003d set(range(FIP_PR_START, FIP_PR_END))"},{"line_number":29,"context_line":"        self.driver \u003d driver"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def get_name(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_e43ab3cb","line":28,"updated":"2015-01-08 21:27:51.000000000","message":"Moving the rule priorities here should work fine because these are shared by multiple routers so fip ns is a good distribution point.\n\nThe fip_iptables_manager, agent_gateway_port (after being renamed to something more appropriate) can be moved into this class because their scope is fip namespace.\n\nAll of the logic in _create_agent_gateway_port can be moved into this class\nso that namespace creation as well as plugging the gateway port can be encapsulated in this class.","commit_id":"c2c0e412c82e4d84ca9657146f61a9b5c65b2496"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d7bdf237456321736dd402b9e38e5d1c6c89dad1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def __init__(self, driver, ext_net_id):"},{"line_number":26,"context_line":"        self._ext_net_id \u003d ext_net_id"},{"line_number":27,"context_line":"        self._subscribers \u003d set()"},{"line_number":28,"context_line":"        self._rule_priorities \u003d set(range(FIP_PR_START, FIP_PR_END))"},{"line_number":29,"context_line":"        self.driver \u003d driver"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def get_name(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_33415ca6","line":28,"in_reply_to":"3a961159_e43ab3cb","updated":"2015-01-08 23:34:38.000000000","message":"Thanks!  I will start looking at that today and tomorrow.","commit_id":"c2c0e412c82e4d84ca9657146f61a9b5c65b2496"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"697c7dadc76def4accab42cf711e5f2bd51cf3d2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self._subscribers.discard(router_id)"},{"line_number":53,"context_line":"        return not self.has_subscribers()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def get_rule_priority(self):"},{"line_number":56,"context_line":"        return self._rule_priorities.pop()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def return_rule_priority(self, rule_pr):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_e7aba085","line":55,"updated":"2015-01-08 15:38:20.000000000","message":"nit: the name \"get_\" implies to me that it is returning it, but not removing. Would it be clearer to use pop_rule_priority(), use_next_rule_priority(), or next_rule_priority()?","commit_id":"c2c0e412c82e4d84ca9657146f61a9b5c65b2496"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d7bdf237456321736dd402b9e38e5d1c6c89dad1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self._subscribers.discard(router_id)"},{"line_number":53,"context_line":"        return not self.has_subscribers()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def get_rule_priority(self):"},{"line_number":56,"context_line":"        return self._rule_priorities.pop()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def return_rule_priority(self, rule_pr):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_93093086","line":55,"in_reply_to":"3a961159_e7aba085","updated":"2015-01-08 23:34:38.000000000","message":"fair enough","commit_id":"c2c0e412c82e4d84ca9657146f61a9b5c65b2496"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"697c7dadc76def4accab42cf711e5f2bd51cf3d2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def get_rule_priority(self):"},{"line_number":56,"context_line":"        return self._rule_priorities.pop()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def return_rule_priority(self, rule_pr):"},{"line_number":59,"context_line":"        self._rule_priorities.add(rule_pr)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_67d33001","line":58,"updated":"2015-01-08 15:38:20.000000000","message":"nit: Might be me, but when I read this, the name made me think it was returning/getting the rule priority. Maybe push_rule_priority(),  restore_rule_priority(), save_rule_priority()?","commit_id":"c2c0e412c82e4d84ca9657146f61a9b5c65b2496"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d7bdf237456321736dd402b9e38e5d1c6c89dad1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def get_rule_priority(self):"},{"line_number":56,"context_line":"        return self._rule_priorities.pop()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def return_rule_priority(self, rule_pr):"},{"line_number":59,"context_line":"        self._rule_priorities.add(rule_pr)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_f32194fc","line":58,"in_reply_to":"3a961159_67d33001","updated":"2015-01-08 23:34:38.000000000","message":"fair enough","commit_id":"c2c0e412c82e4d84ca9657146f61a9b5c65b2496"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"d0c9d359ea8a01172e62bf1c205f0764878c48b0","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        # no connection tracking needed in fip namespace"},{"line_number":172,"context_line":"        self._iptables_manager.ipv4[\u0027raw\u0027].add_rule(\u0027PREROUTING\u0027,"},{"line_number":173,"context_line":"                                                    \u0027-j CT --notrack\u0027)"},{"line_number":174,"context_line":"        self._iptables_manager.apply()"},{"line_number":175,"context_line":"        iface_name \u003d self.get_ext_device_name(agent_gateway_port[\u0027id\u0027])"},{"line_number":176,"context_line":"        self._gateway_added(agent_gateway_port, iface_name)"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_ad971244","line":174,"updated":"2015-01-14 20:18:34.000000000","message":"Above 2 iptable lines can be moved into create() so that these are added as the namespace gets created.","commit_id":"7967de8f13a13f91816a8fe543ae958cdd6b1e2e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"61a698d3fddf2cabc80e21a61b9ce514e69ae545","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        # no connection tracking needed in fip namespace"},{"line_number":172,"context_line":"        self._iptables_manager.ipv4[\u0027raw\u0027].add_rule(\u0027PREROUTING\u0027,"},{"line_number":173,"context_line":"                                                    \u0027-j CT --notrack\u0027)"},{"line_number":174,"context_line":"        self._iptables_manager.apply()"},{"line_number":175,"context_line":"        iface_name \u003d self.get_ext_device_name(agent_gateway_port[\u0027id\u0027])"},{"line_number":176,"context_line":"        self._gateway_added(agent_gateway_port, iface_name)"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a930d6b_24e30da5","line":174,"in_reply_to":"1a930d6b_db99da6f","updated":"2015-01-26 21:25:23.000000000","message":"Done","commit_id":"7967de8f13a13f91816a8fe543ae958cdd6b1e2e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8c94341a03cc5758c38067cae6e5bee42978b218","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        # no connection tracking needed in fip namespace"},{"line_number":172,"context_line":"        self._iptables_manager.ipv4[\u0027raw\u0027].add_rule(\u0027PREROUTING\u0027,"},{"line_number":173,"context_line":"                                                    \u0027-j CT --notrack\u0027)"},{"line_number":174,"context_line":"        self._iptables_manager.apply()"},{"line_number":175,"context_line":"        iface_name \u003d self.get_ext_device_name(agent_gateway_port[\u0027id\u0027])"},{"line_number":176,"context_line":"        self._gateway_added(agent_gateway_port, iface_name)"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a930d6b_db99da6f","line":174,"in_reply_to":"3a961159_ad971244","updated":"2015-01-21 19:39:59.000000000","message":"I\u0027ll have a look.","commit_id":"7967de8f13a13f91816a8fe543ae958cdd6b1e2e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"535c304a55ce131fc487e774bbfc89373272c8af","unresolved":false,"context_lines":[{"line_number":29,"context_line":"ROUTER_2_FIP_DEV_PREFIX \u003d \u0027rfp-\u0027"},{"line_number":30,"context_line":"# Route Table index for FIPs"},{"line_number":31,"context_line":"FIP_RT_TBL \u003d 16"},{"line_number":32,"context_line":"FIP_LL_SUBNET \u003d \u0027169.254.30.0/23\u0027"},{"line_number":33,"context_line":"# Rule priority range for FIPs"},{"line_number":34,"context_line":"FIP_PR_START \u003d 32768"},{"line_number":35,"context_line":"FIP_PR_END \u003d FIP_PR_START + 40000"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a930d6b_d9bab0e0","line":32,"updated":"2015-01-22 10:40:19.000000000","message":"Just a side comment, nothing to address on this patch: \n\nWe start to rely on lots of 169.254.xx.xx subnets for different things (VRRP, DVR, metadata), shouldn\u0027t we manage them from a global constants file to make it evident to the writer when he\u0027s stepping on something else\u0027s subnet?.","commit_id":"8b432c942b0fe68205b2810dc3459a95d31b46f3"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ab52a3a1fbfceb7d5c0824f6956eb7278f863563","unresolved":false,"context_lines":[{"line_number":29,"context_line":"ROUTER_2_FIP_DEV_PREFIX \u003d \u0027rfp-\u0027"},{"line_number":30,"context_line":"# Route Table index for FIPs"},{"line_number":31,"context_line":"FIP_RT_TBL \u003d 16"},{"line_number":32,"context_line":"FIP_LL_SUBNET \u003d \u0027169.254.30.0/23\u0027"},{"line_number":33,"context_line":"# Rule priority range for FIPs"},{"line_number":34,"context_line":"FIP_PR_START \u003d 32768"},{"line_number":35,"context_line":"FIP_PR_END \u003d FIP_PR_START + 40000"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a930d6b_04164c55","line":32,"in_reply_to":"1a930d6b_d9bab0e0","updated":"2015-01-23 20:48:37.000000000","message":"I started thinking about that here [1].  Note that patch replicates this constant in another file and then adds this get_free_range method.  Seems like it is getting harder and harder to manage this IP space.\n\n[1] https://review.openstack.org/#/c/143714/5/neutron/agent/linux/keepalived.py L158","commit_id":"8b432c942b0fe68205b2810dc3459a95d31b46f3"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9aa89f67663b0032c2c883a3ad94f34755493bb0","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                                 namespace\u003dri.ns_name)"},{"line_number":218,"context_line":"        device.route.add_gateway(str(fip_2_rtr.ip), table\u003dFIP_RT_TBL)"},{"line_number":219,"context_line":"        #setup the NAT rules and chains"},{"line_number":220,"context_line":"        ri._handle_router_fip_nat_rules(rtr_2_fip_name, \u0027add_rules\u0027)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def scan_fip_ports(self, ri):"},{"line_number":223,"context_line":"        # don\u0027t scan if not dvr or count is not None"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a930d6b_6d233156","line":220,"updated":"2015-01-27 00:38:47.000000000","message":"Wrong name.  And guess what, I mocked it so that the unit test didn\u0027t fail.  Removing the mock and renaming it to the right name.  One more patch coming.","commit_id":"c10b0694525cb08004a852406defd9fe7c2c2e56"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"2a8b5afccce41c52a4be53f7ea3665eeb8362a1a","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"FIP_NS_PREFIX \u003d \u0027fip-\u0027"},{"line_number":28,"context_line":"FIP_EXT_DEV_PREFIX \u003d \u0027fg-\u0027"},{"line_number":29,"context_line":"FIP_2_ROUTER_DEV_PREFIX \u003d \u0027fpr-\u0027"},{"line_number":30,"context_line":"ROUTER_2_FIP_DEV_PREFIX \u003d \u0027rfp-\u0027"},{"line_number":31,"context_line":"# Route Table index for FIPs"},{"line_number":32,"context_line":"FIP_RT_TBL \u003d 16"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a930d6b_5c5b84f5","line":29,"updated":"2015-01-27 01:53:34.000000000","message":"nit: When I first read this I was confused by the 2. I think we should say TO instead.","commit_id":"aada1fa816738a6f92e4654aa97f9eb5b8459424"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2fe880b1d61a13cc423b7974e045e3ce8d429638","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"FIP_NS_PREFIX \u003d \u0027fip-\u0027"},{"line_number":28,"context_line":"FIP_EXT_DEV_PREFIX \u003d \u0027fg-\u0027"},{"line_number":29,"context_line":"FIP_2_ROUTER_DEV_PREFIX \u003d \u0027fpr-\u0027"},{"line_number":30,"context_line":"ROUTER_2_FIP_DEV_PREFIX \u003d \u0027rfp-\u0027"},{"line_number":31,"context_line":"# Route Table index for FIPs"},{"line_number":32,"context_line":"FIP_RT_TBL \u003d 16"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a930d6b_1198e876","line":29,"in_reply_to":"1a930d6b_5c5b84f5","updated":"2015-01-27 16:41:40.000000000","message":"I only moved this constant from another file without changing the name.  I could change it here but would like to wait to see if there is another reason to crack open this patch.","commit_id":"aada1fa816738a6f92e4654aa97f9eb5b8459424"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"2a8b5afccce41c52a4be53f7ea3665eeb8362a1a","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        ip_wrapper.netns.execute([\u0027ip\u0027, \u0027addr\u0027, \u0027add\u0027,"},{"line_number":184,"context_line":"                                  ip_cidr, \u0027dev\u0027, interface_name])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def create_rtr_2_fip_link(self, ri):"},{"line_number":187,"context_line":"        \"\"\"Create interface between router and Floating IP namespace.\"\"\""},{"line_number":188,"context_line":"        rtr_2_fip_name \u003d self.get_rtr_ext_device_name(ri.router_id)"},{"line_number":189,"context_line":"        fip_2_rtr_name \u003d self.get_int_device_name(ri.router_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a930d6b_9c708c73","line":186,"updated":"2015-01-27 01:53:34.000000000","message":"s/2/to","commit_id":"aada1fa816738a6f92e4654aa97f9eb5b8459424"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2fe880b1d61a13cc423b7974e045e3ce8d429638","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        ip_wrapper.netns.execute([\u0027ip\u0027, \u0027addr\u0027, \u0027add\u0027,"},{"line_number":184,"context_line":"                                  ip_cidr, \u0027dev\u0027, interface_name])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def create_rtr_2_fip_link(self, ri):"},{"line_number":187,"context_line":"        \"\"\"Create interface between router and Floating IP namespace.\"\"\""},{"line_number":188,"context_line":"        rtr_2_fip_name \u003d self.get_rtr_ext_device_name(ri.router_id)"},{"line_number":189,"context_line":"        fip_2_rtr_name \u003d self.get_int_device_name(ri.router_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a930d6b_6ce15329","line":186,"in_reply_to":"1a930d6b_9c708c73","updated":"2015-01-27 16:41:40.000000000","message":"ditto","commit_id":"aada1fa816738a6f92e4654aa97f9eb5b8459424"}],"neutron/agent/l3/dvr_router.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1893597ce6ace3660d83eb841dd9b5ac77668091","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def _handle_fip_nat_rules(self, interface_name, action):"},{"line_number":29,"context_line":"        \"\"\"Configures NAT rules for Floating IPs for DVR."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"           Remove all the rules. This is safe because if"},{"line_number":32,"context_line":"           use_namespaces is set as False then the agent can"},{"line_number":33,"context_line":"           only configure one router, otherwise each router\u0027s"},{"line_number":34,"context_line":"           NAT rules will be in their own namespace."}],"source_content_type":"text/x-python","patch_set":18,"id":"1a930d6b_acbc1bbc","line":31,"updated":"2015-01-27 16:52:37.000000000","message":"Nit: subsequent comment lines aligned with first quote mark. PEP257","commit_id":"aada1fa816738a6f92e4654aa97f9eb5b8459424"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"de8decdcf29e074cebfc7c3e9da9fbabd2c9016e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def _handle_fip_nat_rules(self, interface_name, action):"},{"line_number":29,"context_line":"        \"\"\"Configures NAT rules for Floating IPs for DVR."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"           Remove all the rules. This is safe because if"},{"line_number":32,"context_line":"           use_namespaces is set as False then the agent can"},{"line_number":33,"context_line":"           only configure one router, otherwise each router\u0027s"},{"line_number":34,"context_line":"           NAT rules will be in their own namespace."}],"source_content_type":"text/x-python","patch_set":18,"id":"fa81d914_adc6c947","line":31,"in_reply_to":"1a930d6b_acbc1bbc","updated":"2015-01-27 18:55:25.000000000","message":"Why doesn\u0027t our pep check that.  I\u0027m not inclined to follow a bunch of minor style rules that our tools don\u0027t enforce.  But, if I have to role the patch again, I will fix it.","commit_id":"aada1fa816738a6f92e4654aa97f9eb5b8459424"}],"neutron/tests/unit/test_l3_agent.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"535c304a55ce131fc487e774bbfc89373272c8af","unresolved":false,"context_lines":[{"line_number":1901,"context_line":"        with mock.patch.object(lla.LinkLocalAllocator, \u0027_write\u0027):"},{"line_number":1902,"context_line":"            agent.create_rtr_2_fip_link(ri, {})"},{"line_number":1903,"context_line":"        self.assertFalse(self.mock_ip.add_veth.called)"},{"line_number":1904,"context_line":""},{"line_number":1905,"context_line":"    def test_floating_ip_added_dist(self):"},{"line_number":1906,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":1907,"context_line":"        router \u003d prepare_router_data()"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a930d6b_543a07ce","side":"PARENT","line":1904,"updated":"2015-01-22 10:40:19.000000000","message":"Just checked all those tests were moved to the previous test as encapsulated. :)","commit_id":"b8c6da5f7c25deb0365c31e0bdb1a6cc05b1623c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ab52a3a1fbfceb7d5c0824f6956eb7278f863563","unresolved":false,"context_lines":[{"line_number":1901,"context_line":"        with mock.patch.object(lla.LinkLocalAllocator, \u0027_write\u0027):"},{"line_number":1902,"context_line":"            agent.create_rtr_2_fip_link(ri, {})"},{"line_number":1903,"context_line":"        self.assertFalse(self.mock_ip.add_veth.called)"},{"line_number":1904,"context_line":""},{"line_number":1905,"context_line":"    def test_floating_ip_added_dist(self):"},{"line_number":1906,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":1907,"context_line":"        router \u003d prepare_router_data()"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a930d6b_4f122d58","side":"PARENT","line":1904,"in_reply_to":"1a930d6b_543a07ce","updated":"2015-01-23 20:48:37.000000000","message":":)  My goal is for the new code to be *better* tested than the old code from a UT perspective.","commit_id":"b8c6da5f7c25deb0365c31e0bdb1a6cc05b1623c"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"535c304a55ce131fc487e774bbfc89373272c8af","unresolved":false,"context_lines":[{"line_number":2041,"context_line":"        is_last \u003d agent._fip_ns_unsubscribe(router_id)"},{"line_number":2042,"context_line":"        self.assertFalse(is_last)"},{"line_number":2043,"context_line":"        self.assertEqual(len(agent.fip_ns_subscribers), 1)"},{"line_number":2044,"context_line":""},{"line_number":2045,"context_line":"    def test_external_gateway_removed_ext_gw_port_and_fip(self):"},{"line_number":2046,"context_line":"        self.conf.set_override(\u0027state_path\u0027, \u0027/tmp\u0027)"},{"line_number":2047,"context_line":"        self.conf.set_override(\u0027router_delete_namespaces\u0027, True)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a930d6b_345d7b22","side":"PARENT","line":2044,"updated":"2015-01-22 10:40:19.000000000","message":"Those too.","commit_id":"b8c6da5f7c25deb0365c31e0bdb1a6cc05b1623c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ab52a3a1fbfceb7d5c0824f6956eb7278f863563","unresolved":false,"context_lines":[{"line_number":2041,"context_line":"        is_last \u003d agent._fip_ns_unsubscribe(router_id)"},{"line_number":2042,"context_line":"        self.assertFalse(is_last)"},{"line_number":2043,"context_line":"        self.assertEqual(len(agent.fip_ns_subscribers), 1)"},{"line_number":2044,"context_line":""},{"line_number":2045,"context_line":"    def test_external_gateway_removed_ext_gw_port_and_fip(self):"},{"line_number":2046,"context_line":"        self.conf.set_override(\u0027state_path\u0027, \u0027/tmp\u0027)"},{"line_number":2047,"context_line":"        self.conf.set_override(\u0027router_delete_namespaces\u0027, True)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a930d6b_0f24a5ad","side":"PARENT","line":2044,"in_reply_to":"1a930d6b_345d7b22","updated":"2015-01-23 20:48:37.000000000","message":"ditto","commit_id":"b8c6da5f7c25deb0365c31e0bdb1a6cc05b1623c"}]}
