)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1545e63bb2ebf0a3b7b43eb66d2a6c4293355cc0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Active validate check of user input name when creating"},{"line_number":10,"context_line":"network subnet and port."},{"line_number":11,"context_line":"Limit the attribute of name from None to 255."},{"line_number":12,"context_line":"[Before fix]"},{"line_number":13,"context_line":"DB returns 500 internal DB Error."},{"line_number":14,"context_line":"[After fix]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_3bacf134","line":11,"updated":"2015-01-08 05:39:58.000000000","message":"Just question: Is the condition mentioned in document? I cannot find it in document, I find the condition in code only.","commit_id":"40e6131cbfd0307f056cec0a80c8bea90e84e690"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"4c83bd0741ba043c4beb1e2e17fab03c6751e94a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Active validate check of user input name when creating"},{"line_number":10,"context_line":"network subnet and port."},{"line_number":11,"context_line":"Limit the attribute of name from None to 255."},{"line_number":12,"context_line":"[Before fix]"},{"line_number":13,"context_line":"DB returns 500 internal DB Error."},{"line_number":14,"context_line":"[After fix]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_6dca406f","line":11,"in_reply_to":"3a961159_3bacf134","updated":"2015-01-08 06:44:47.000000000","message":"Could you tell me which document are you looking at, please?\n\nBTW, I am going to fix the API reference [1] POST /v2.0/networks, etc. in another fix, after this fix is approved.\n\n[1]:http://developer.openstack.org/api-ref-networking-v2.html#netconn-v2-ext","commit_id":"40e6131cbfd0307f056cec0a80c8bea90e84e690"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"ba54c61920386e14a565b23af697db79c192a68f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Active validate check of user input name when creating"},{"line_number":10,"context_line":"network subnet and port."},{"line_number":11,"context_line":"Limit the attribute of name from None to 255."},{"line_number":12,"context_line":"[Before fix]"},{"line_number":13,"context_line":"DB returns 500 internal DB Error."},{"line_number":14,"context_line":"[After fix]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_90e21f9e","line":11,"in_reply_to":"3a961159_6dca406f","updated":"2015-01-08 07:25:52.000000000","message":"I checked the API reference and Administrator Guide[1].\n\nI think that fixing API reference is better.\n\n[1]: http://docs.openstack.org/admin-guide-cloud/content/nova_with_neutron_api.html","commit_id":"40e6131cbfd0307f056cec0a80c8bea90e84e690"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e89c07b8808e376a6fa67d90aff22c58b8ea58fc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"DB returns 500 internal DB Error."},{"line_number":14,"context_line":"[After fix]"},{"line_number":15,"context_line":"Neutron returns 400 Bad Request Error (\"XXX\" exceeds maximum length of 255)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ide98f347da563c5df10daca00491027a1b78523b"},{"line_number":18,"context_line":"Closes-Bug: 1408230"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_8169f38d","line":16,"updated":"2015-01-08 09:27:40.000000000","message":"Need to add APIImpact","commit_id":"40e6131cbfd0307f056cec0a80c8bea90e84e690"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"c9ea2c332d65f741b6fe6b49c3ce9d959981e2a6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"DB returns 500 internal DB Error."},{"line_number":14,"context_line":"[After fix]"},{"line_number":15,"context_line":"Neutron returns 400 Bad Request Error (\"XXX\" exceeds maximum length of 255)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ide98f347da563c5df10daca00491027a1b78523b"},{"line_number":18,"context_line":"Closes-Bug: 1408230"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_1188d569","line":16,"in_reply_to":"3a961159_8169f38d","updated":"2015-01-09 04:52:28.000000000","message":"Done","commit_id":"40e6131cbfd0307f056cec0a80c8bea90e84e690"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"393be0bbdada05e6df44a6702e74eb0671301d91","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     watanabe.isao \u003czou.yun@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-09 14:02:38 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug fix: active validate check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Active validate check of user input name when creating"},{"line_number":10,"context_line":"network subnet and port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_0527afc7","line":7,"updated":"2015-01-09 10:07:22.000000000","message":"No need to include \"Bug fix\" to commit message. Also \u0027active validate check\u0027 is quite confusing. Consider \u0027Validate name string length at API level\u0027","commit_id":"fb821cbe65519cab4c9ab310acf393d89c120555"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"53ad925506d4354ef4f05eac2875ba2da5319665","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     watanabe.isao \u003czou.yun@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-09 14:02:38 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug fix: active validate check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Active validate check of user input name when creating"},{"line_number":10,"context_line":"network subnet and port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_4716d859","line":7,"in_reply_to":"3a961159_0527afc7","updated":"2015-01-13 00:44:45.000000000","message":"Done","commit_id":"fb821cbe65519cab4c9ab310acf393d89c120555"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"393be0bbdada05e6df44a6702e74eb0671301d91","unresolved":false,"context_lines":[{"line_number":13,"context_line":"[Before fix]"},{"line_number":14,"context_line":"DB returns 500 internal DB Error."},{"line_number":15,"context_line":"[After fix]"},{"line_number":16,"context_line":"Neutron returns 400 Bad Request Error (\"XXX\" exceeds maximum length of 255)."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"APIImpact"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_650f9339","line":16,"updated":"2015-01-09 10:07:22.000000000","message":"nit: please keep up to 72 chars on one line","commit_id":"fb821cbe65519cab4c9ab310acf393d89c120555"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"53ad925506d4354ef4f05eac2875ba2da5319665","unresolved":false,"context_lines":[{"line_number":13,"context_line":"[Before fix]"},{"line_number":14,"context_line":"DB returns 500 internal DB Error."},{"line_number":15,"context_line":"[After fix]"},{"line_number":16,"context_line":"Neutron returns 400 Bad Request Error (\"XXX\" exceeds maximum length of 255)."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"APIImpact"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_6a271bb6","line":16,"in_reply_to":"3a961159_650f9339","updated":"2015-01-13 00:44:45.000000000","message":"Hello, Oleg Bondarev. Thank you for your advice. I\u0027ll me more careful about this next time.","commit_id":"fb821cbe65519cab4c9ab310acf393d89c120555"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"a5d085320f7b6b2c4bed704fcd1fa2d691b0b39a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Validate name string length at API level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Active validate check of user input name when creating"},{"line_number":10,"context_line":"network subnet and port."},{"line_number":11,"context_line":"Limit the attribute of name from None to 255."},{"line_number":12,"context_line":"[Before fix]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da86d52c_e41433f7","line":9,"updated":"2015-02-02 10:50:52.000000000","message":"Please consider rewording this sentence, Eg.\n\n\"Add validation of the \"name\" field for network, subnet and port create operations.\"","commit_id":"b4347d813fd368852c39d0a51b6b895e5c986a1e"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"1e4c54bc2cf2dd7316a1013703645938a51757b6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Validate name string length at API level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Active validate check of user input name when creating"},{"line_number":10,"context_line":"network subnet and port."},{"line_number":11,"context_line":"Limit the attribute of name from None to 255."},{"line_number":12,"context_line":"[Before fix]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da86d52c_047843c3","line":9,"in_reply_to":"da86d52c_e41433f7","updated":"2015-02-03 00:03:52.000000000","message":"Done","commit_id":"b4347d813fd368852c39d0a51b6b895e5c986a1e"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"fc28caa1bd97a13014eff00f3bafa670ca14c76d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Validate name string length at API level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add validation of the \"name\" field for network, subnet and port create"},{"line_number":10,"context_line":"operations."},{"line_number":11,"context_line":"Limit the attribute of name from None to 255 in a DB backend plugin."},{"line_number":12,"context_line":"[Before fix]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da86d52c_b7758fcc","line":9,"updated":"2015-02-04 19:44:28.000000000","message":"The validation is also done for router resources, on update operations.\n\nYou should add also firewall/policy/rule/secgroup name validation.","commit_id":"3c9254878c5abad91d47abb1be441a2ef9702d8b"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"dbd2a9e03f70dd7743fdda8f31e37fc604e12499","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Validate name string length at API level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add validation of the \"name\" field for network, subnet and port create"},{"line_number":10,"context_line":"operations."},{"line_number":11,"context_line":"Limit the attribute of name from None to 255 in a DB backend plugin."},{"line_number":12,"context_line":"[Before fix]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da86d52c_1d53d16b","line":9,"in_reply_to":"da86d52c_b7758fcc","updated":"2015-02-05 01:43:52.000000000","message":"Done","commit_id":"3c9254878c5abad91d47abb1be441a2ef9702d8b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d80bc949092fe285c456963341c4aa8b36bd396f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Validate string length at API level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add validation of string field."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[Before fix]"},{"line_number":12,"context_line":"DB returns 500 internal DB Error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba7be1f8_c4590190","line":9,"updated":"2015-02-27 08:56:12.000000000","message":"Could you mention the length of API validation matches max length of DB entries?","commit_id":"658bc30adf955f4e2c462fc72bbd302e469ece3f"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"7922f12d2494f272a2167223d0865d2a54f07f98","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Validate string length at API level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add validation of string field."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[Before fix]"},{"line_number":12,"context_line":"DB returns 500 internal DB Error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba7be1f8_ffac8e8e","line":9,"in_reply_to":"ba7be1f8_c4590190","updated":"2015-03-02 04:22:59.000000000","message":"Done","commit_id":"658bc30adf955f4e2c462fc72bbd302e469ece3f"}],"neutron/api/v2/attributes.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"2a7e9d9d08be3382d05c6737f51257187effb7da","unresolved":false,"context_lines":[{"line_number":659,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":660,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":661,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":662,"context_line":"        \u0027name\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":663,"context_line":"                 \u0027validate\u0027: {\u0027type:string\u0027: 255},"},{"line_number":664,"context_line":"                 \u0027default\u0027: \u0027\u0027, \u0027is_visible\u0027: True},"},{"line_number":665,"context_line":"        \u0027subnets\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_03fc2b71","line":662,"updated":"2015-01-08 08:03:02.000000000","message":"Shouldn\u0027t this be tied to the DB model, so that if it ever changes, so will the validation?\n\nYou can take it from:\nmodels_v2.{Network/Subnet/Port}.name.property.columns[0].type.length","commit_id":"40e6131cbfd0307f056cec0a80c8bea90e84e690"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"c9ea2c332d65f741b6fe6b49c3ce9d959981e2a6","unresolved":false,"context_lines":[{"line_number":659,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":660,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":661,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":662,"context_line":"        \u0027name\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":663,"context_line":"                 \u0027validate\u0027: {\u0027type:string\u0027: 255},"},{"line_number":664,"context_line":"                 \u0027default\u0027: \u0027\u0027, \u0027is_visible\u0027: True},"},{"line_number":665,"context_line":"        \u0027subnets\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_51ba5dc0","line":662,"in_reply_to":"3a961159_03fc2b71","updated":"2015-01-09 04:52:28.000000000","message":"Done","commit_id":"40e6131cbfd0307f056cec0a80c8bea90e84e690"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8e78f9fc9acf60b38c840c016b4b3517841e2fc1","unresolved":false,"context_lines":[{"line_number":662,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":663,"context_line":"        \u0027name\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":664,"context_line":"                 \u0027validate\u0027: {\u0027type:string\u0027: models_v2.Network.name."},{"line_number":665,"context_line":"                              property.columns[0].type.length},"},{"line_number":666,"context_line":"                 \u0027default\u0027: \u0027\u0027, \u0027is_visible\u0027: True},"},{"line_number":667,"context_line":"        \u0027subnets\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":668,"context_line":"                    \u0027default\u0027: [],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_d771a00d","line":665,"updated":"2015-01-12 18:50:11.000000000","message":"Does this really need to be dynamic? After all the string sizes are hardcoded now in model_v2, so I\u0027d argue to define the size constant and use that to define both the limit here and the limit on the column definition. \n\nIt would be a lot cleaner and we\u0027d not pollute the API layer with DB layer internals.\n\nAs for the test, someone has already pointed this out this patch needs one; now whether this is tested via the usual \"unit\" test that validates the wsgi layer or proper api test, I am not strongly opinionated, but we do do need one.","commit_id":"fb821cbe65519cab4c9ab310acf393d89c120555"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"cdf035359ba9532a7df785f5c5c034a482f3eabd","unresolved":false,"context_lines":[{"line_number":662,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":663,"context_line":"        \u0027name\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":664,"context_line":"                 \u0027validate\u0027: {\u0027type:string\u0027: models_v2.Network.name."},{"line_number":665,"context_line":"                              property.columns[0].type.length},"},{"line_number":666,"context_line":"                 \u0027default\u0027: \u0027\u0027, \u0027is_visible\u0027: True},"},{"line_number":667,"context_line":"        \u0027subnets\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":668,"context_line":"                    \u0027default\u0027: [],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_856a6619","line":665,"in_reply_to":"3a961159_33bd8ab2","updated":"2015-01-13 13:36:08.000000000","message":"To Armando Migliaccio. Could you teach me, where we can write the regression tests in neutron branch, please? If someone is thinking of wsgi layer test, a module must already been created or on its way to kilo, which I just did not find it.","commit_id":"fb821cbe65519cab4c9ab310acf393d89c120555"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"53ad925506d4354ef4f05eac2875ba2da5319665","unresolved":false,"context_lines":[{"line_number":662,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":663,"context_line":"        \u0027name\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":664,"context_line":"                 \u0027validate\u0027: {\u0027type:string\u0027: models_v2.Network.name."},{"line_number":665,"context_line":"                              property.columns[0].type.length},"},{"line_number":666,"context_line":"                 \u0027default\u0027: \u0027\u0027, \u0027is_visible\u0027: True},"},{"line_number":667,"context_line":"        \u0027subnets\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":668,"context_line":"                    \u0027default\u0027: [],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_2a6513af","line":665,"in_reply_to":"3a961159_a713fc63","updated":"2015-01-13 00:44:45.000000000","message":"To Assaf Muller:\n\nI see. I will roll back to patch set 1.\n\nTo Armando Migliaccio:\n\nAs far as I know, this is tested in method test_validate_string of module neutron/tests/unit/test_attributes.py. Do you think the coverage of the unit test is not enough?","commit_id":"fb821cbe65519cab4c9ab310acf393d89c120555"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5f68ba47dfa487b7b82c02b12c5a9030aa85d8bb","unresolved":false,"context_lines":[{"line_number":662,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":663,"context_line":"        \u0027name\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":664,"context_line":"                 \u0027validate\u0027: {\u0027type:string\u0027: models_v2.Network.name."},{"line_number":665,"context_line":"                              property.columns[0].type.length},"},{"line_number":666,"context_line":"                 \u0027default\u0027: \u0027\u0027, \u0027is_visible\u0027: True},"},{"line_number":667,"context_line":"        \u0027subnets\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":668,"context_line":"                    \u0027default\u0027: [],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_33bd8ab2","line":665,"in_reply_to":"3a961159_a713fc63","updated":"2015-01-13 03:08:41.000000000","message":"so let me get this straight, how do you intent to protect yourself from regressions?","commit_id":"fb821cbe65519cab4c9ab310acf393d89c120555"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"237a69d2b22804df2527bf2a19da2a1d5956c96e","unresolved":false,"context_lines":[{"line_number":662,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":663,"context_line":"        \u0027name\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":664,"context_line":"                 \u0027validate\u0027: {\u0027type:string\u0027: models_v2.Network.name."},{"line_number":665,"context_line":"                              property.columns[0].type.length},"},{"line_number":666,"context_line":"                 \u0027default\u0027: \u0027\u0027, \u0027is_visible\u0027: True},"},{"line_number":667,"context_line":"        \u0027subnets\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":668,"context_line":"                    \u0027default\u0027: [],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_a713fc63","line":665,"in_reply_to":"3a961159_d771a00d","updated":"2015-01-13 00:30:44.000000000","message":"I originally suggested tying the validation to the actual size the model declares. I agree that using a constant to achieve that makes more sense than that is currently proposed.\n\nAs for testing - I\u0027ll voice my opinion again (But this time here): I don\u0027t think this change requires a test. I think we should assume that API validations generally work and I don\u0027t see why this is a special case. Why not have a test for every allow_post True/False, allow_put True/False on every attribute on every resource, for example? Because that\u0027d be insane, that\u0027s why. You test the different validations once then assume that functionality works, there\u0027s no need to test every specific validation.","commit_id":"fb821cbe65519cab4c9ab310acf393d89c120555"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4d344a96928e7add6e3f9ec7901d2b554fd6fbf8","unresolved":false,"context_lines":[{"line_number":660,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":661,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":662,"context_line":"        \u0027name\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":663,"context_line":"                 \u0027validate\u0027: {\u0027type:string\u0027: 255},"},{"line_number":664,"context_line":"                 \u0027default\u0027: \u0027\u0027, \u0027is_visible\u0027: True},"},{"line_number":665,"context_line":"        \u0027subnets\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":666,"context_line":"                    \u0027default\u0027: [],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_fb25095b","line":663,"updated":"2015-01-16 13:46:45.000000000","message":"I\u0027d second Armando\u0027s suggestion on patch set 2 to define a constant and use both here and in db models","commit_id":"87fe901d3d3f21bba33f500852061cab82430170"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"406985fa3126a1236db828726a2fedfb81898739","unresolved":false,"context_lines":[{"line_number":660,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":661,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":662,"context_line":"        \u0027name\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":663,"context_line":"                 \u0027validate\u0027: {\u0027type:string\u0027: 255},"},{"line_number":664,"context_line":"                 \u0027default\u0027: \u0027\u0027, \u0027is_visible\u0027: True},"},{"line_number":665,"context_line":"        \u0027subnets\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":666,"context_line":"                    \u0027default\u0027: [],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_3b4daa99","line":663,"in_reply_to":"3a961159_fb25095b","updated":"2015-01-19 09:01:43.000000000","message":"Thank you for the correction. I had a misunderstand on Armando\u0027s comment.","commit_id":"87fe901d3d3f21bba33f500852061cab82430170"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"a5d085320f7b6b2c4bed704fcd1fa2d691b0b39a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"UNLIMITED \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Common definitions for maximum string field length"},{"line_number":36,"context_line":"#MAXLEN_NAME \u003d 255"},{"line_number":37,"context_line":"MAXLEN_NAME \u003d 255 if sa.__version__ else None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_c46e4fc9","line":36,"updated":"2015-02-02 10:50:52.000000000","message":"I guess, this commented out line should be removed.","commit_id":"b4347d813fd368852c39d0a51b6b895e5c986a1e"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"1e4c54bc2cf2dd7316a1013703645938a51757b6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"UNLIMITED \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Common definitions for maximum string field length"},{"line_number":36,"context_line":"#MAXLEN_NAME \u003d 255"},{"line_number":37,"context_line":"MAXLEN_NAME \u003d 255 if sa.__version__ else None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_44595b59","line":36,"in_reply_to":"da86d52c_c46e4fc9","updated":"2015-02-03 00:03:52.000000000","message":"Done","commit_id":"b4347d813fd368852c39d0a51b6b895e5c986a1e"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"a5d085320f7b6b2c4bed704fcd1fa2d691b0b39a","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Common definitions for maximum string field length"},{"line_number":36,"context_line":"#MAXLEN_NAME \u003d 255"},{"line_number":37,"context_line":"MAXLEN_NAME \u003d 255 if sa.__version__ else None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _verify_dict_keys(expected_keys, target_dict, strict\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_24ac8bed","line":37,"updated":"2015-02-02 10:50:52.000000000","message":"This constant has be moved to common/constants so that it can be used for db models too.\n\nnit: the constant name could be changed to something more readable, like \"NAME_MAX_LEN\"","commit_id":"b4347d813fd368852c39d0a51b6b895e5c986a1e"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"1e4c54bc2cf2dd7316a1013703645938a51757b6","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Common definitions for maximum string field length"},{"line_number":36,"context_line":"#MAXLEN_NAME \u003d 255"},{"line_number":37,"context_line":"MAXLEN_NAME \u003d 255 if sa.__version__ else None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _verify_dict_keys(expected_keys, target_dict, strict\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_44079b1c","line":37,"in_reply_to":"da86d52c_24ac8bed","updated":"2015-02-03 00:03:52.000000000","message":"Wloud like to fix db module (and others if neseccary) to use this constant in next Patch Set. Please correct me if I misunderstand anything.\n\nGood name received.","commit_id":"b4347d813fd368852c39d0a51b6b895e5c986a1e"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"90e7db0f66dcdf22f23cffa2106224e07fae0a37","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Common definitions for maximum string field length"},{"line_number":36,"context_line":"#MAXLEN_NAME \u003d 255"},{"line_number":37,"context_line":"MAXLEN_NAME \u003d 255 if sa.__version__ else None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _verify_dict_keys(expected_keys, target_dict, strict\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_be269a14","line":37,"in_reply_to":"da86d52c_44079b1c","updated":"2015-02-04 04:52:06.000000000","message":"Hello, Elena Ezhova.\n\nI\u0027ve looked around the code in neutron, epically in db.\n\nYou see, the max length of name in db module (like agents_db.py) is hard coded to 255. But here in API level, I need to consider about non-db backend plugin, which gives a situation of NAME_MAX_LEN\u003dNone. And I cannot pass None to DB module.\n\nSo I would like to suggest that let us wait and see what others say about this.","commit_id":"b4347d813fd368852c39d0a51b6b895e5c986a1e"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"6e218b7875adfcaffa8ee460058da9578ef11463","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Common definitions for maximum string field length"},{"line_number":36,"context_line":"#MAXLEN_NAME \u003d 255"},{"line_number":37,"context_line":"MAXLEN_NAME \u003d 255 if sa.__version__ else None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _verify_dict_keys(expected_keys, target_dict, strict\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_c146d44e","line":37,"in_reply_to":"da86d52c_be269a14","updated":"2015-02-04 11:38:49.000000000","message":"Ok, that sounds reasonable. Let\u0027s wait for what others have to say.","commit_id":"b4347d813fd368852c39d0a51b6b895e5c986a1e"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"fc28caa1bd97a13014eff00f3bafa670ca14c76d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Used by range check to indicate no limit for a bound."},{"line_number":33,"context_line":"UNLIMITED \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Common definitions for maximum string field length"},{"line_number":36,"context_line":"NAME_MAX_LEN \u003d 255 if sa.__version__ else None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_b7002f35","line":35,"updated":"2015-02-04 19:44:28.000000000","message":"An explanation would be great why NAME_MAX_LEN depends on sa.__version__","commit_id":"3c9254878c5abad91d47abb1be441a2ef9702d8b"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"7ebdb185cb68757d753713dd07b035ae93a8f98d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Used by range check to indicate no limit for a bound."},{"line_number":33,"context_line":"UNLIMITED \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Common definitions for maximum string field length"},{"line_number":36,"context_line":"NAME_MAX_LEN \u003d 255 if sa.__version__ else None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_8247c276","line":35,"in_reply_to":"da86d52c_015442fd","updated":"2015-02-10 00:07:18.000000000","message":"Yes, you are right. It will not be evaluated to False if it can be imported.","commit_id":"3c9254878c5abad91d47abb1be441a2ef9702d8b"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"dbd2a9e03f70dd7743fdda8f31e37fc604e12499","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Used by range check to indicate no limit for a bound."},{"line_number":33,"context_line":"UNLIMITED \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Common definitions for maximum string field length"},{"line_number":36,"context_line":"NAME_MAX_LEN \u003d 255 if sa.__version__ else None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_dd7059de","line":35,"in_reply_to":"da86d52c_b7002f35","updated":"2015-02-05 01:43:52.000000000","message":"Would \"When DB is installed validate the value(s) less than 255 to fit the length of DB column.\" be good?","commit_id":"3c9254878c5abad91d47abb1be441a2ef9702d8b"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"90c42176e45de2f2f1423598684c76c46fae77ff","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Used by range check to indicate no limit for a bound."},{"line_number":33,"context_line":"UNLIMITED \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Common definitions for maximum string field length"},{"line_number":36,"context_line":"NAME_MAX_LEN \u003d 255 if sa.__version__ else None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_015442fd","line":35,"in_reply_to":"da86d52c_dd7059de","updated":"2015-02-05 08:53:19.000000000","message":"I don\u0027t understand when sa.__version__ can be evaluated to False","commit_id":"3c9254878c5abad91d47abb1be441a2ef9702d8b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eaeb9edbcf63d94ffb5100a1449505f7d0d7e6a7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"UNLIMITED \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Common definitions for maximum string field length"},{"line_number":36,"context_line":"NAME_MAX_LEN \u003d 255 if sa.__version__ else None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _verify_dict_keys(expected_keys, target_dict, strict\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_21b4e6f0","line":36,"updated":"2015-02-05 09:22:10.000000000","message":"I can\u0027t understand what this condition does. Could you clarify how it works? The module of API layer is always used as long as neutron-server is running, so this always returns True. In addition, sqlalchemy is always installed because it is specified in requirements.txt","commit_id":"3c9254878c5abad91d47abb1be441a2ef9702d8b"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"7ebdb185cb68757d753713dd07b035ae93a8f98d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"UNLIMITED \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Common definitions for maximum string field length"},{"line_number":36,"context_line":"NAME_MAX_LEN \u003d 255 if sa.__version__ else None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _verify_dict_keys(expected_keys, target_dict, strict\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_626d6e04","line":36,"in_reply_to":"da86d52c_21b4e6f0","updated":"2015-02-10 00:07:18.000000000","message":"Thanks for your check. I didn\u0027t know we have this:\n\nSQLAlchemy\u003e\u003d0.9.7,\u003c\u003d0.9.99\n\nI was trying to find a way to test the non-db plugin situation. Maybe we have any configuration about this which currently I haven\u0027t figure it out.","commit_id":"3c9254878c5abad91d47abb1be441a2ef9702d8b"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"aeb2794dd14610ffd88b38726c9204154cf46901","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Used by range check to indicate no limit for a bound."},{"line_number":32,"context_line":"UNLIMITED \u003d None"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Common definitions for maximum string field length"},{"line_number":35,"context_line":"# In a non-db plugin module, when attribute module has been imported,"},{"line_number":36,"context_line":"# it is necessary to reset the definitions to default value."},{"line_number":37,"context_line":"NAME_MAX_LEN \u003d 255          # default: None"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_71c151e3","line":34,"updated":"2015-02-18 23:40:19.000000000","message":"These restrictions appear related to the field lengths defined in the models.  Is there a good reason that the models and the api definition don\u0027t share the constant definition to ensure that they stay in sync?","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3a11ac3f0fee671754c9934b1fb7b380275be495","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Used by range check to indicate no limit for a bound."},{"line_number":32,"context_line":"UNLIMITED \u003d None"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Common definitions for maximum string field length"},{"line_number":35,"context_line":"# In a non-db plugin module, when attribute module has been imported,"},{"line_number":36,"context_line":"# it is necessary to reset the definitions to default value."},{"line_number":37,"context_line":"NAME_MAX_LEN \u003d 255          # default: None"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_334afaac","line":34,"in_reply_to":"ba7be1f8_19ed33c4","updated":"2015-02-22 17:17:37.000000000","message":"I second to Maru. These values should match the lengths of DB models, so it is nice both share same values.","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"79bf2dccbd6dc70a78496836daafaa5187e3751d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Used by range check to indicate no limit for a bound."},{"line_number":32,"context_line":"UNLIMITED \u003d None"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Common definitions for maximum string field length"},{"line_number":35,"context_line":"# In a non-db plugin module, when attribute module has been imported,"},{"line_number":36,"context_line":"# it is necessary to reset the definitions to default value."},{"line_number":37,"context_line":"NAME_MAX_LEN \u003d 255          # default: None"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_19ed33c4","line":34,"in_reply_to":"ba7be1f8_2f2c8a4a","updated":"2015-02-20 18:57:06.000000000","message":"The field length definition in the models (e.g. [1]) and the length limits set here should be defined once rather than being defined separately.  A common constant would be one way of accomplishing this.\n\n1: https://github.com/openstack/neutron/blob/master/neutron/db/models_v2.py#L64","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"ac3a29063af9f4b58303cd9aa1d582a38e2a04ee","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Used by range check to indicate no limit for a bound."},{"line_number":32,"context_line":"UNLIMITED \u003d None"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Common definitions for maximum string field length"},{"line_number":35,"context_line":"# In a non-db plugin module, when attribute module has been imported,"},{"line_number":36,"context_line":"# it is necessary to reset the definitions to default value."},{"line_number":37,"context_line":"NAME_MAX_LEN \u003d 255          # default: None"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_6072b6e6","line":34,"in_reply_to":"ba7be1f8_334afaac","updated":"2015-02-23 21:12:29.000000000","message":"So, I need to reuse the values in db modules, it that right?\n\nIf so, it will become a big work, but I would like to work it out, too.","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"02eb791d09cb194c369322238fc48da70eb5b2b9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Used by range check to indicate no limit for a bound."},{"line_number":32,"context_line":"UNLIMITED \u003d None"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Common definitions for maximum string field length"},{"line_number":35,"context_line":"# In a non-db plugin module, when attribute module has been imported,"},{"line_number":36,"context_line":"# it is necessary to reset the definitions to default value."},{"line_number":37,"context_line":"NAME_MAX_LEN \u003d 255          # default: None"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_d91bb41a","line":34,"in_reply_to":"ba7be1f8_4fdafa4c","updated":"2015-02-27 01:30:36.000000000","message":"Thank you for teach me this.","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2081a01380bd9b5f045d8e53c77ac00ebeaa187c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Used by range check to indicate no limit for a bound."},{"line_number":32,"context_line":"UNLIMITED \u003d None"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Common definitions for maximum string field length"},{"line_number":35,"context_line":"# In a non-db plugin module, when attribute module has been imported,"},{"line_number":36,"context_line":"# it is necessary to reset the definitions to default value."},{"line_number":37,"context_line":"NAME_MAX_LEN \u003d 255          # default: None"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_4fdafa4c","line":34,"in_reply_to":"ba7be1f8_6072b6e6","updated":"2015-02-25 08:17:39.000000000","message":"I don\u0027t think it\u0027s going be a big work. You just need to use these same constants in neutron/db/models_v2","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"a1832587fcca925887df558a7753664a88de9ebc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# Used by range check to indicate no limit for a bound."},{"line_number":32,"context_line":"UNLIMITED \u003d None"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Common definitions for maximum string field length"},{"line_number":35,"context_line":"# In a non-db plugin module, when attribute module has been imported,"},{"line_number":36,"context_line":"# it is necessary to reset the definitions to default value."},{"line_number":37,"context_line":"NAME_MAX_LEN \u003d 255          # default: None"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_2f2c8a4a","line":34,"in_reply_to":"da86d52c_71c151e3","updated":"2015-02-20 04:11:22.000000000","message":"I\u0027m not sure I am 100% got your point. If I am wrong, please correct me.\n\nBecause we should not set these value to the field length in non-db modules, and that is because they don\u0027t have a DB, and 255 is set for the DB schema length.","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3a11ac3f0fee671754c9934b1fb7b380275be495","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# Common definitions for maximum string field length"},{"line_number":35,"context_line":"# In a non-db plugin module, when attribute module has been imported,"},{"line_number":36,"context_line":"# it is necessary to reset the definitions to default value."},{"line_number":37,"context_line":"NAME_MAX_LEN \u003d 255          # default: None"},{"line_number":38,"context_line":"TENANT_ID_MAX_LEN \u003d 255     # default: None"},{"line_number":39,"context_line":"DESCRIPTION_MAX_LEN \u003d 255   # default: None"},{"line_number":40,"context_line":"DEVICE_ID_MAX_LEN \u003d 255     # default: None"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_53c84e22","line":37,"updated":"2015-02-22 17:17:37.000000000","message":"I think \"default None\" is a bit confusing. After this patch, None is no longer a default value.","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"ac3a29063af9f4b58303cd9aa1d582a38e2a04ee","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# Common definitions for maximum string field length"},{"line_number":35,"context_line":"# In a non-db plugin module, when attribute module has been imported,"},{"line_number":36,"context_line":"# it is necessary to reset the definitions to default value."},{"line_number":37,"context_line":"NAME_MAX_LEN \u003d 255          # default: None"},{"line_number":38,"context_line":"TENANT_ID_MAX_LEN \u003d 255     # default: None"},{"line_number":39,"context_line":"DESCRIPTION_MAX_LEN \u003d 255   # default: None"},{"line_number":40,"context_line":"DEVICE_ID_MAX_LEN \u003d 255     # default: None"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_8055ea51","line":37,"in_reply_to":"ba7be1f8_53c84e22","updated":"2015-02-23 21:12:29.000000000","message":"Done","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4c6785b013c8cc6930757493fa99cdabd598320d","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# TODO(watanabe.isao): A fix like in neutron/db/models_v2.py needs to be"},{"line_number":35,"context_line":"# done in other db modules, to reuse the following constants."},{"line_number":36,"context_line":"# Common definitions for maximum string field length"},{"line_number":37,"context_line":"NAME_MAX_LEN \u003d 255"},{"line_number":38,"context_line":"TENANT_ID_MAX_LEN \u003d 255"},{"line_number":39,"context_line":"DESCRIPTION_MAX_LEN \u003d 255"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_b4f35709","line":36,"updated":"2015-03-23 11:20:09.000000000","message":"Is this comment still valid? This fix changes db modules other than models_v2.py.","commit_id":"3d1d08e0085d45c61fd19e4d1dcedda386f040f8"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"25e08ab2ac366bc6925a7bfc388757a41bb61fad","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# TODO(watanabe.isao): A fix like in neutron/db/models_v2.py needs to be"},{"line_number":35,"context_line":"# done in other db modules, to reuse the following constants."},{"line_number":36,"context_line":"# Common definitions for maximum string field length"},{"line_number":37,"context_line":"NAME_MAX_LEN \u003d 255"},{"line_number":38,"context_line":"TENANT_ID_MAX_LEN \u003d 255"},{"line_number":39,"context_line":"DESCRIPTION_MAX_LEN \u003d 255"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_2c4a9c80","line":36,"in_reply_to":"1a6ced46_b4f35709","updated":"2015-03-24 02:35:22.000000000","message":"Yes, I think it is still valid. Because there are many other modules in neutron/db/ using string field. And I would like to do a more careful list up in another fix.","commit_id":"3d1d08e0085d45c61fd19e4d1dcedda386f040f8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e72aadd8e7405a3883aadf6a8c19a0bd9b8c71dd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"TENANT_ID_MAX_LEN \u003d 255"},{"line_number":39,"context_line":"DESCRIPTION_MAX_LEN \u003d 255"},{"line_number":40,"context_line":"DEVICE_ID_MAX_LEN \u003d 255"},{"line_number":41,"context_line":"DEVICE_OWNER_MAX_LEN \u003d 255"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def _verify_dict_keys(expected_keys, target_dict, strict\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_2d6c0bd0","line":41,"updated":"2015-03-03 03:46:56.000000000","message":"i prefer to have a set of dedicated validators like \u0027type:name\u0027 instead,\nat least for commonly used ones.\nbut it\u0027s probably a matter of taste.","commit_id":"3d1d08e0085d45c61fd19e4d1dcedda386f040f8"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"25e08ab2ac366bc6925a7bfc388757a41bb61fad","unresolved":false,"context_lines":[{"line_number":38,"context_line":"TENANT_ID_MAX_LEN \u003d 255"},{"line_number":39,"context_line":"DESCRIPTION_MAX_LEN \u003d 255"},{"line_number":40,"context_line":"DEVICE_ID_MAX_LEN \u003d 255"},{"line_number":41,"context_line":"DEVICE_OWNER_MAX_LEN \u003d 255"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def _verify_dict_keys(expected_keys, target_dict, strict\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_c7ff2300","line":41,"in_reply_to":"1a6ced46_41db471b","updated":"2015-03-24 02:35:22.000000000","message":"If there is a request from core, I\u0027d like to obey. However, one note is that the name changed from MAXLEN_XXX to XXX_MAX_LEN(now) due to the suggest of Elena Ezhova in Patch Set 4. And I\u0027m ok with each of them.","commit_id":"3d1d08e0085d45c61fd19e4d1dcedda386f040f8"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9f16e9f9ff5336a5874dba25d37ded9d92938849","unresolved":false,"context_lines":[{"line_number":38,"context_line":"TENANT_ID_MAX_LEN \u003d 255"},{"line_number":39,"context_line":"DESCRIPTION_MAX_LEN \u003d 255"},{"line_number":40,"context_line":"DEVICE_ID_MAX_LEN \u003d 255"},{"line_number":41,"context_line":"DEVICE_OWNER_MAX_LEN \u003d 255"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def _verify_dict_keys(expected_keys, target_dict, strict\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_0b1ea563","line":41,"in_reply_to":"1a6ced46_c7ff2300","updated":"2015-03-24 02:45:37.000000000","message":"I think the constants as you did are fine","commit_id":"3d1d08e0085d45c61fd19e4d1dcedda386f040f8"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2e4ec8b22917d478335a98a2878e8c3334cea2f8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"TENANT_ID_MAX_LEN \u003d 255"},{"line_number":39,"context_line":"DESCRIPTION_MAX_LEN \u003d 255"},{"line_number":40,"context_line":"DEVICE_ID_MAX_LEN \u003d 255"},{"line_number":41,"context_line":"DEVICE_OWNER_MAX_LEN \u003d 255"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def _verify_dict_keys(expected_keys, target_dict, strict\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_3a5fbb10","line":41,"in_reply_to":"ba7be1f8_2d6c0bd0","updated":"2015-03-03 17:17:18.000000000","message":"I think that is what Watanabe is doing isn\u0027t it?","commit_id":"3d1d08e0085d45c61fd19e4d1dcedda386f040f8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4c6785b013c8cc6930757493fa99cdabd598320d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"TENANT_ID_MAX_LEN \u003d 255"},{"line_number":39,"context_line":"DESCRIPTION_MAX_LEN \u003d 255"},{"line_number":40,"context_line":"DEVICE_ID_MAX_LEN \u003d 255"},{"line_number":41,"context_line":"DEVICE_OWNER_MAX_LEN \u003d 255"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def _verify_dict_keys(expected_keys, target_dict, strict\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_41db471b","line":41,"in_reply_to":"ba7be1f8_3a5fbb10","updated":"2015-03-23 11:20:09.000000000","message":"I think what yamamoto suggests is to define individual validators like _validate_name, _validate_tenant_id.\nIt may make sense for some common fields like tenant_id or name. I am okay with the current version and let\u0027s improve it later.","commit_id":"3d1d08e0085d45c61fd19e4d1dcedda386f040f8"}],"neutron/db/models_v2.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2e4ec8b22917d478335a98a2878e8c3334cea2f8","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    are used for the IP allocation."},{"line_number":183,"context_line":"    \"\"\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":186,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027networks.id\u0027))"},{"line_number":187,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":188,"context_line":"    cidr \u003d sa.Column(sa.String(64), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_baf00bfe","line":185,"updated":"2015-03-03 17:17:18.000000000","message":"the only interesting thing to check is whether changing these constants triggers a failure in the migration test (should be a func test) - It should trigger a failure and if it doesn\u0027t we might have something else to fix.","commit_id":"3d1d08e0085d45c61fd19e4d1dcedda386f040f8"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9f16e9f9ff5336a5874dba25d37ded9d92938849","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    are used for the IP allocation."},{"line_number":183,"context_line":"    \"\"\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":186,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027networks.id\u0027))"},{"line_number":187,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":188,"context_line":"    cidr \u003d sa.Column(sa.String(64), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_2b30c1e7","line":185,"in_reply_to":"1a6ced46_27e39708","updated":"2015-03-24 02:45:37.000000000","message":"The functional tests should detect failures.\nThis means that if we change the NAME_MAX_LEN in the future a migration will be needed.\n\nThis is true regardless of the use of the constants - the only difference being that a developer might not realise the implications, but as the tests will fail in that case there should be no problem","commit_id":"3d1d08e0085d45c61fd19e4d1dcedda386f040f8"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"25e08ab2ac366bc6925a7bfc388757a41bb61fad","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    are used for the IP allocation."},{"line_number":183,"context_line":"    \"\"\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":186,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027networks.id\u0027))"},{"line_number":187,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":188,"context_line":"    cidr \u003d sa.Column(sa.String(64), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_27e39708","line":185,"in_reply_to":"1a6ced46_749b9fc9","updated":"2015-03-24 02:35:22.000000000","message":"I think the risk of db table length inconsistency is always there, with or without this fix. If it is not been covered I would be my pleasure to start a new topice to improve it.\n\nAnd define constantes in one place do help us to managment the risk, also will simplifies the future additional function tests (if nesessery).","commit_id":"3d1d08e0085d45c61fd19e4d1dcedda386f040f8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4c6785b013c8cc6930757493fa99cdabd598320d","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    are used for the IP allocation."},{"line_number":183,"context_line":"    \"\"\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":186,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027networks.id\u0027))"},{"line_number":187,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":188,"context_line":"    cidr \u003d sa.Column(sa.String(64), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_749b9fc9","line":185,"in_reply_to":"9a80dd14_a45b6920","updated":"2015-03-23 11:20:09.000000000","message":"I think Salvatore\u0027s point is important. If we change a value of some constants like NAME_MAX_LEN *in the future* (from some reason or by mistake), we will have inconsistency between db models here and actual db tables. Can we detect the inconsistency by our (func) tests for such case?\n\nPreviously we explicitly specified a number and the risk of these cases were low, but now we need to check it.\n\nIdeally it would be nice that our current tests catch such change. If not, we need to implement such tests.\n\nHowever, it may be a bit beyond the scope of this patch.\nIt might help us if we define these constants in one place so that everyone can notice that he/she is changing a constant which affects db models.\n\nThought?","commit_id":"3d1d08e0085d45c61fd19e4d1dcedda386f040f8"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"da6a0a37633142213ce03bac6dbd363737209333","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    are used for the IP allocation."},{"line_number":183,"context_line":"    \"\"\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":186,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027networks.id\u0027))"},{"line_number":187,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":188,"context_line":"    cidr \u003d sa.Column(sa.String(64), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_a45b6920","line":185,"in_reply_to":"ba7be1f8_baf00bfe","updated":"2015-03-16 00:53:11.000000000","message":"Tested the following test are ok with this fix. [neutron/tests/functional/db/test_migrations.py], [neutron/tests/unit/test_db_migration.py]","commit_id":"3d1d08e0085d45c61fd19e4d1dcedda386f040f8"}],"neutron/plugins/ibm/sdnve_api.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"79bf2dccbd6dc70a78496836daafaa5187e3751d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"SDNVE_TENANT_TYPE_OVERLAY \u003d u\u0027DOVE\u0027"},{"line_number":40,"context_line":"SDNVE_URL \u003d \u0027https://%s:%s%s\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# Reset attribute value to default in a non-db plugin module,"},{"line_number":43,"context_line":"# when attibutes module has been imported."},{"line_number":44,"context_line":"attributes.NAME_MAX_LEN \u003d None"},{"line_number":45,"context_line":"attributes.TENANT_ID_MAX_LEN \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_395e7746","line":42,"updated":"2015-02-20 18:57:06.000000000","message":"Given the requirement for consistent API behavior, I don\u0027t think relaxing the constraint for non-db plugins is suggested, so this should not be necessary.\n\nEven if you wanted to provide differential behavior, the approach taken here wouldn\u0027t work.  Setting the values of the constants does not change the value of previous assignments, e.g.\n\n \u003e\u003e\u003e CONSTANT \u003d 1\n \u003e\u003e\u003e my_dict \u003d dict(foo\u003dCONSTANT)\n \u003e\u003e\u003e CONSTANT \u003d 2\n \u003e\u003e\u003e my_dict\n {\u0027foo\u0027: 1}\n\nThis patch would have detected this problem if it had attempted to validate name length restrictions for a non-db plugin.","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"ac3a29063af9f4b58303cd9aa1d582a38e2a04ee","unresolved":false,"context_lines":[{"line_number":39,"context_line":"SDNVE_TENANT_TYPE_OVERLAY \u003d u\u0027DOVE\u0027"},{"line_number":40,"context_line":"SDNVE_URL \u003d \u0027https://%s:%s%s\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# Reset attribute value to default in a non-db plugin module,"},{"line_number":43,"context_line":"# when attibutes module has been imported."},{"line_number":44,"context_line":"attributes.NAME_MAX_LEN \u003d None"},{"line_number":45,"context_line":"attributes.TENANT_ID_MAX_LEN \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_5b0e8335","line":42,"in_reply_to":"ba7be1f8_395e7746","updated":"2015-02-23 21:12:29.000000000","message":"Thanks for the test.\n\nSo maybe we need a user configure to condition the CONSTANT at the very first time when creating them in API modules.","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"02eb791d09cb194c369322238fc48da70eb5b2b9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"SDNVE_TENANT_TYPE_OVERLAY \u003d u\u0027DOVE\u0027"},{"line_number":40,"context_line":"SDNVE_URL \u003d \u0027https://%s:%s%s\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# Reset attribute value to default in a non-db plugin module,"},{"line_number":43,"context_line":"# when attibutes module has been imported."},{"line_number":44,"context_line":"attributes.NAME_MAX_LEN \u003d None"},{"line_number":45,"context_line":"attributes.TENANT_ID_MAX_LEN \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_19c46c5e","line":42,"in_reply_to":"ba7be1f8_4fbd9ab6","updated":"2015-02-27 01:30:36.000000000","message":"Thanks. I will remove these resets out of non-db backend plugins.","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2081a01380bd9b5f045d8e53c77ac00ebeaa187c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"SDNVE_TENANT_TYPE_OVERLAY \u003d u\u0027DOVE\u0027"},{"line_number":40,"context_line":"SDNVE_URL \u003d \u0027https://%s:%s%s\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# Reset attribute value to default in a non-db plugin module,"},{"line_number":43,"context_line":"# when attibutes module has been imported."},{"line_number":44,"context_line":"attributes.NAME_MAX_LEN \u003d None"},{"line_number":45,"context_line":"attributes.TENANT_ID_MAX_LEN \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_4fbd9ab6","line":42,"in_reply_to":"ba7be1f8_5b0e8335","updated":"2015-02-25 08:17:39.000000000","message":"also, there is another point about consistency in API changes - for any change, even validation. The point being, in my opinion, that the same constraints should be enforced regardless of the backend.\n\nI don\u0027t know if you have been explicitly advised to not enforce lenghth constraints for non-db plugins. Fwiw, in this case it\u0027s not like there are no constraints. It\u0027s just that you don\u0027t know what the constraints are.","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"}],"neutron/plugins/vmware/extensions/networkgw.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3a11ac3f0fee671754c9934b1fb7b380275be495","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                  \u0027is_visible\u0027: True},"},{"line_number":50,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":51,"context_line":"                      \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":52,"context_line":"                                   attributes.TENANT_ID_MAX_LEN},"},{"line_number":53,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":54,"context_line":"                      \u0027is_visible\u0027: True}"},{"line_number":55,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_73f2b270","line":52,"updated":"2015-02-22 17:17:37.000000000","message":"Hmm... tenant_id of nsx network gateway model has 36 char length. I am not sure the reason but apparently it does not match the real value.\nhttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/plugins/vmware/dbexts/nsx_models.py#n177\n\nI think Salvatore can clarify the situation.","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"02eb791d09cb194c369322238fc48da70eb5b2b9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                  \u0027is_visible\u0027: True},"},{"line_number":50,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":51,"context_line":"                      \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":52,"context_line":"                                   attributes.TENANT_ID_MAX_LEN},"},{"line_number":53,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":54,"context_line":"                      \u0027is_visible\u0027: True}"},{"line_number":55,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_992a1c2b","line":52,"in_reply_to":"ba7be1f8_0f9ac26d","updated":"2015-02-27 01:30:36.000000000","message":"Thank you for the confirm.","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2081a01380bd9b5f045d8e53c77ac00ebeaa187c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                  \u0027is_visible\u0027: True},"},{"line_number":50,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":51,"context_line":"                      \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":52,"context_line":"                                   attributes.TENANT_ID_MAX_LEN},"},{"line_number":53,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":54,"context_line":"                      \u0027is_visible\u0027: True}"},{"line_number":55,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_0f9ac26d","line":52,"in_reply_to":"ba7be1f8_3b22afa4","updated":"2015-02-25 08:17:39.000000000","message":"that tenant id length was established when the tenant id was supposed to be always an uuid (I think it still is)\nAnyway, you can keep your patch as it is, and I will update the nsx models with another patch","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"ac3a29063af9f4b58303cd9aa1d582a38e2a04ee","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                  \u0027is_visible\u0027: True},"},{"line_number":50,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":51,"context_line":"                      \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":52,"context_line":"                                   attributes.TENANT_ID_MAX_LEN},"},{"line_number":53,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":54,"context_line":"                      \u0027is_visible\u0027: True}"},{"line_number":55,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_3b22afa4","line":52,"in_reply_to":"ba7be1f8_73f2b270","updated":"2015-02-23 21:12:29.000000000","message":"Thanks for the information and confirmation.","commit_id":"6c0cc8f1d7cd3559b575785cd12cde2d89e35c3f"}]}
