)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"db3352e9e2223c048e7caf0b6879d2dd5e1498f5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-01-08 22:46:25 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DHCP agent restructuring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Wrap dhcp agent into its own module and break out configuration and"},{"line_number":10,"context_line":"entry point for better seperation."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_a5afbbe1","line":8,"updated":"2015-01-09 09:27:37.000000000","message":"I think that the entry point should be in the dhcp directory. I find that confusing, but I realize this is very subjective.","commit_id":"5d7395814af7ea4a445f81b748d38acf144e2d6e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"79d566b587397dda145997cba59fa8a1f0f8b3b9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-01-08 22:46:25 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DHCP agent restructuring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Wrap dhcp agent into its own module and break out configuration and"},{"line_number":10,"context_line":"entry point for better seperation."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_725af0f3","line":8,"in_reply_to":"3a961159_65da334c","updated":"2015-01-09 14:59:19.000000000","message":"I don\u0027t mind having the entry points for the agents all in one place, so long as they are separate from the rest of the logic. That would be my opinion","commit_id":"5d7395814af7ea4a445f81b748d38acf144e2d6e"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"bd4ee22b2c9a6a6e56352939fce88047746c4597","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-01-08 22:46:25 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DHCP agent restructuring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Wrap dhcp agent into its own module and break out configuration and"},{"line_number":10,"context_line":"entry point for better seperation."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_65da334c","line":8,"in_reply_to":"3a961159_a5afbbe1","updated":"2015-01-09 09:34:50.000000000","message":"I see you did the same in the L3 agent patch. Is there a technical reason then to keep the entry point in its existing place?","commit_id":"5d7395814af7ea4a445f81b748d38acf144e2d6e"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"190e90800f681ba3bcb6ca8c3d2066030f91c0fe","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When/if the dhcp agent goes through a restructuring along the same"},{"line_number":13,"context_line":"lines of the L3 agent\u0027s, this would be the step to start from."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I87d9f1079ed4e71c731984ec00e2f785024fd5f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a961159_cd3bf737","line":14,"updated":"2015-01-10 18:58:07.000000000","message":"No BP or bug for this? It\u0027s quite trivial but many lines of code are being shuffled around.","commit_id":"99218f9b17a184558c5f5ed9672904aa5bbe8ae7"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7dfd62bc3bbf0fec55cc427b39d7658f8b0238d9","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When/if the dhcp agent goes through a restructuring along the same"},{"line_number":13,"context_line":"lines of the L3 agent\u0027s, this would be the step to start from."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I87d9f1079ed4e71c731984ec00e2f785024fd5f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a961159_f8e06ffa","line":14,"in_reply_to":"3a961159_cd3bf737","updated":"2015-01-10 21:55:37.000000000","message":"Done","commit_id":"99218f9b17a184558c5f5ed9672904aa5bbe8ae7"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"db3352e9e2223c048e7caf0b6879d2dd5e1498f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_a5ddfb71","line":1,"updated":"2015-01-09 09:27:37.000000000","message":"Copyright year.","commit_id":"5d7395814af7ea4a445f81b748d38acf144e2d6e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"62d2786c211df3f2de21711451937707de3e985a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_01a4f849","line":1,"in_reply_to":"3a961159_320788cb","updated":"2015-01-09 17:58:09.000000000","message":"um...I am not sure whether this is me or gerrit ([1]).\n\n[1] https://code.google.com/p/gerrit/issues/detail?id\u003d593","commit_id":"5d7395814af7ea4a445f81b748d38acf144e2d6e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"79d566b587397dda145997cba59fa8a1f0f8b3b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_320788cb","line":1,"in_reply_to":"3a961159_a5ddfb71","updated":"2015-01-09 14:59:19.000000000","message":"this should\u0027ve a rename, not sure why git didn\u0027t get it...let me fix it.","commit_id":"5d7395814af7ea4a445f81b748d38acf144e2d6e"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"db3352e9e2223c048e7caf0b6879d2dd5e1498f5","unresolved":false,"context_lines":[{"line_number":394,"context_line":"            network.namespace)"},{"line_number":395,"context_line":"        pm.disable()"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"class DhcpPluginApi(object):"},{"line_number":399,"context_line":"    \"\"\"Agent side of the dhcp rpc API."},{"line_number":400,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_65f073fd","line":397,"updated":"2015-01-09 09:27:37.000000000","message":"This and \u0027NetworkCache\u0027 should be split into their own modules as well. Do you want to do that in a follow up patch? I think it makes sense to do it in this one.","commit_id":"5d7395814af7ea4a445f81b748d38acf144e2d6e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56c2924e20789fde99a2a2a6b6d7d3e9c18ae13e","unresolved":false,"context_lines":[{"line_number":394,"context_line":"            network.namespace)"},{"line_number":395,"context_line":"        pm.disable()"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"class DhcpPluginApi(object):"},{"line_number":399,"context_line":"    \"\"\"Agent side of the dhcp rpc API."},{"line_number":400,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_617f7c18","line":397,"in_reply_to":"3a961159_65f073fd","updated":"2015-01-09 17:44:28.000000000","message":"I\u0027d rather do it as a next step to make the patch easier to digest","commit_id":"5d7395814af7ea4a445f81b748d38acf144e2d6e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"428a33d162b424d3a0200a34f1d5f481018a5073","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_578690dc","line":1,"updated":"2015-01-12 18:51:48.000000000","message":"should this be 2015?","commit_id":"869e77cf1833317d5b9c7e622cedd2c60d21349f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4977a21ed3d2600b608bdd9f8418fefe94177b50","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_a774bfd0","line":1,"in_reply_to":"3a961159_578690dc","updated":"2015-01-13 17:03:30.000000000","message":"this is a rename, for whatever reason gerrit does not show it (see PS1)...since many people tripped on this I am going to split this patch into two to work around gerrit\u0027s idiocy).","commit_id":"869e77cf1833317d5b9c7e622cedd2c60d21349f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"428a33d162b424d3a0200a34f1d5f481018a5073","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import eventlet"},{"line_number":20,"context_line":"eventlet.monkey_patch()"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.config import cfg"},{"line_number":23,"context_line":"from oslo import messaging"},{"line_number":24,"context_line":"from oslo.utils import importutils"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_f75dbc7d","line":21,"updated":"2015-01-12 18:51:48.000000000","message":"we should drop the new line here","commit_id":"869e77cf1833317d5b9c7e622cedd2c60d21349f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4977a21ed3d2600b608bdd9f8418fefe94177b50","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import eventlet"},{"line_number":20,"context_line":"eventlet.monkey_patch()"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.config import cfg"},{"line_number":23,"context_line":"from oslo import messaging"},{"line_number":24,"context_line":"from oslo.utils import importutils"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_a75bdf53","line":21,"in_reply_to":"3a961159_f75dbc7d","updated":"2015-01-13 17:03:30.000000000","message":"Done","commit_id":"869e77cf1833317d5b9c7e622cedd2c60d21349f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"652f0470e794ccd9bdaeffc54aa07295d8af05f4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import eventlet"},{"line_number":20,"context_line":"eventlet.monkey_patch()"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.config import cfg"},{"line_number":23,"context_line":"from oslo import messaging"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_cdbc146f","line":20,"updated":"2015-01-16 14:34:38.000000000","message":"I think it is better to place eventlet.monkey_patch in l3_agent.py.\nThe heart of this is to apply monkey_patch as first as we can when dhcp-agent is invoked. By moving monkey_patch to l3_agent.py we can apply monkey_patch and avoid a situation some other module load a module which need to be monkey_patch-ed. neutron/server/__init__.py does this. The change was done in commit 6ca8cb84fd8f703367e1bd8ee1a2f26071116725.","commit_id":"066238042aacaf04c3c1741d483f75862808734c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a00d87c02b09dad6a4baa330cc137bf5b46fd08e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import eventlet"},{"line_number":20,"context_line":"eventlet.monkey_patch()"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.config import cfg"},{"line_number":23,"context_line":"from oslo import messaging"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_77b5a530","line":20,"in_reply_to":"3a961159_cdbc146f","updated":"2015-01-16 16:40:50.000000000","message":"Hi Akihiro, do you mean dhcp_agent? Btw, have the same structure, I guess they\u0027ll need to follow too, right?\n\n [1] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/agent.py#L17\n [2] https://github.com/openstack/neutron/blob/master/neutron/agent/metadata/agent.py#L21","commit_id":"066238042aacaf04c3c1741d483f75862808734c"}],"neutron/agent/dhcp/config.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"428a33d162b424d3a0200a34f1d5f481018a5073","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                      \u0027socket\u0027)),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"DHCP_OPTS \u003d ["},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027dhcp_confs\u0027,"},{"line_number":41,"context_line":"               default\u003d\u0027$state_path/dhcp\u0027,"},{"line_number":42,"context_line":"               help\u003d_(\u0027Location to store DHCP server config files\u0027)),"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_172ec8fa","line":39,"updated":"2015-01-12 18:51:48.000000000","message":"i think that the dnsmasq config options should be in a seperate file. essentially the dhcp is plugable and we may use different backends for the dhcp service.\n\nIf you decide to leave this then at least change the name of the variable to reflect that is is for dnsmasq","commit_id":"869e77cf1833317d5b9c7e622cedd2c60d21349f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4977a21ed3d2600b608bdd9f8418fefe94177b50","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                      \u0027socket\u0027)),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"DHCP_OPTS \u003d ["},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027dhcp_confs\u0027,"},{"line_number":41,"context_line":"               default\u003d\u0027$state_path/dhcp\u0027,"},{"line_number":42,"context_line":"               help\u003d_(\u0027Location to store DHCP server config files\u0027)),"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_a2102d50","line":39,"in_reply_to":"3a961159_172ec8fa","updated":"2015-01-13 17:03:30.000000000","message":"I had considered naming it DNSMASQ_OPTS, but the problem is that these opts mix both dnsmasq and non-dnsmasq options; I can untangle, but it\u0027ll be more work, which is fine.","commit_id":"869e77cf1833317d5b9c7e622cedd2c60d21349f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"30de3936215b063e8e8a4fa6c195e5bc6b79ae11","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"DHCP_AGENT_OPTS \u003d ["},{"line_number":20,"context_line":"    cfg.IntOpt(\u0027resync_interval\u0027, default\u003d5,"},{"line_number":21,"context_line":"               help\u003d_(\"Interval to resync.\")),"},{"line_number":22,"context_line":"    cfg.StrOpt(\u0027dhcp_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a961159_59d60928","line":19,"updated":"2015-01-18 11:00:27.000000000","message":"i do not think that we should have all of the configurations in the same file. \nthe dhcp agent is meant to be pluggable. look at line 22.\n\nyou are adding the DHCP configurations for that pluggable entity here too, i do not think that is correct\n\nthose should be coupled with that code.","commit_id":"b35c004204206c7c92b0450b80a812bf21b2af71"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"99c397657fd41e1f28f13694e3b21aef310b5fe6","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"DHCP_AGENT_OPTS \u003d ["},{"line_number":20,"context_line":"    cfg.IntOpt(\u0027resync_interval\u0027, default\u003d5,"},{"line_number":21,"context_line":"               help\u003d_(\"Interval to resync.\")),"},{"line_number":22,"context_line":"    cfg.StrOpt(\u0027dhcp_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a961159_9f569103","line":19,"in_reply_to":"3a961159_59d60928","updated":"2015-01-18 16:01:19.000000000","message":"What are you saying that this should go back to where it was? I wanted the config to stand out of the main code for easy access/discovery. I could make the dnsmasq config to its own file but since this file it\u0027s less than 80 lines I figured it was not worthwhile, and could revisit when we do have more than one driver available, besides dnsmasq.","commit_id":"b35c004204206c7c92b0450b80a812bf21b2af71"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"be730749f71e043870c3e9f099aeb65fcfedd253","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"DHCP_AGENT_OPTS \u003d ["},{"line_number":20,"context_line":"    cfg.IntOpt(\u0027resync_interval\u0027, default\u003d5,"},{"line_number":21,"context_line":"               help\u003d_(\"Interval to resync.\")),"},{"line_number":22,"context_line":"    cfg.StrOpt(\u0027dhcp_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a961159_68eaeed9","line":19,"in_reply_to":"3a961159_9f569103","updated":"2015-01-20 10:29:39.000000000","message":"I am okay with the current proposed style. Once we have multiple DHCP agent implementations, we will have a separate file per implementation and we can revisit config option locations.","commit_id":"b35c004204206c7c92b0450b80a812bf21b2af71"}],"neutron/agent/dhcp/netns_cleanup_util.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"db3352e9e2223c048e7caf0b6879d2dd5e1498f5","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo.config import cfg"},{"line_number":22,"context_line":"from oslo.utils import importutils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from neutron.agent.common import config as agent_config"},{"line_number":25,"context_line":"from neutron.agent.dhcp import agent"},{"line_number":26,"context_line":"from neutron.agent.dhcp import config as dhcp_config"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_c5bf67fa","line":23,"updated":"2015-01-09 09:27:37.000000000","message":"Eh? Why did you move this file? It\u0027s not DHCP specific.","commit_id":"5d7395814af7ea4a445f81b748d38acf144e2d6e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"79d566b587397dda145997cba59fa8a1f0f8b3b9","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo.config import cfg"},{"line_number":22,"context_line":"from oslo.utils import importutils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from neutron.agent.common import config as agent_config"},{"line_number":25,"context_line":"from neutron.agent.dhcp import agent"},{"line_number":26,"context_line":"from neutron.agent.dhcp import config as dhcp_config"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_72b670fb","line":23,"in_reply_to":"3a961159_c5bf67fa","updated":"2015-01-09 14:59:19.000000000","message":"I am still not convinced about this yet, and you\u0027re right this is not strictly dhcp related, but it does seem to worry about dhcp the most ;)","commit_id":"5d7395814af7ea4a445f81b748d38acf144e2d6e"}],"neutron/agent/dhcp_agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"428a33d162b424d3a0200a34f1d5f481018a5073","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_77d8ecf0","line":1,"updated":"2015-01-12 18:51:48.000000000","message":"why do you need to change this?","commit_id":"869e77cf1833317d5b9c7e622cedd2c60d21349f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4977a21ed3d2600b608bdd9f8418fefe94177b50","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_422789b5","line":1,"in_reply_to":"3a961159_77d8ecf0","updated":"2015-01-13 17:03:30.000000000","message":"um, this should have been a new file :(","commit_id":"869e77cf1833317d5b9c7e622cedd2c60d21349f"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"b928d6fe1ab306709ffa87caa3bba63c02d2959f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1a930d6b_31094896","updated":"2015-01-20 20:56:42.000000000","message":"How about:\nneutron/agent/dhcp/agent.py\nneutron/agent/dhcp/drivers/base.py (Up to lines 289)\nneutron/agent/dhcp/drivers/dnsmasq.py (Lines 290+)\n\nCould be done in a follow up patch of course.","commit_id":"b35c004204206c7c92b0450b80a812bf21b2af71"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ad59237666fca8f3b40cb3f228acb13626659cb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1a930d6b_a5afb22a","in_reply_to":"1a930d6b_31094896","updated":"2015-01-20 23:58:35.000000000","message":"I\u0027ll look into it, and follow up if necessary. Stand-by :)","commit_id":"b35c004204206c7c92b0450b80a812bf21b2af71"}],"neutron/api/rpc/agentnotifiers/dhcp_rpc_agent_api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"428a33d162b424d3a0200a34f1d5f481018a5073","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class DhcpAgentNotifyAPI(object):"},{"line_number":31,"context_line":"    \"\"\"API for plugin to notify DHCP agent."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    This class implements the client side of an rpc interface.  The server side"},{"line_number":34,"context_line":"    is neutron.agent.dhcp_agent.DhcpAgent.  For more information about changing"},{"line_number":35,"context_line":"    rpc interfaces, please see doc/source/devref/rpc_api.rst."}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_f7ebfc78","side":"PARENT","line":32,"updated":"2015-01-12 18:51:48.000000000","message":"do we need this change","commit_id":"f83b08abf59a915206e93051af96bdcc5b7724c2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4977a21ed3d2600b608bdd9f8418fefe94177b50","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class DhcpAgentNotifyAPI(object):"},{"line_number":31,"context_line":"    \"\"\"API for plugin to notify DHCP agent."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    This class implements the client side of an rpc interface.  The server side"},{"line_number":34,"context_line":"    is neutron.agent.dhcp_agent.DhcpAgent.  For more information about changing"},{"line_number":35,"context_line":"    rpc interfaces, please see doc/source/devref/rpc_api.rst."}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_c23299f2","side":"PARENT","line":32,"in_reply_to":"3a961159_f7ebfc78","updated":"2015-01-13 17:03:30.000000000","message":"Done","commit_id":"f83b08abf59a915206e93051af96bdcc5b7724c2"}],"neutron/tests/unit/test_dhcp_agent.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"5d4ad79015a28d8bff2c3608dd3680b878de1efc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3a961159_7bd9d627","updated":"2015-01-20 00:09:16.000000000","message":"I\u0027d argue that this file should be moved to\nneutron/tests/unit/dhcp/test_agent.py","commit_id":"b35c004204206c7c92b0450b80a812bf21b2af71"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3658f2e58dd89875076bc7f1c34b7434bc173e89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1a930d6b_0cf2619a","in_reply_to":"1a930d6b_05a7a650","updated":"2015-01-21 11:12:58.000000000","message":"Thanks for clarifying it.","commit_id":"b35c004204206c7c92b0450b80a812bf21b2af71"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ad59237666fca8f3b40cb3f228acb13626659cb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1a930d6b_05a7a650","in_reply_to":"1a930d6b_6bbbe172","updated":"2015-01-20 23:58:35.000000000","message":"+1 to Henry. Maru should be on top of that, I wasn\u0027t going to clash with him.","commit_id":"b35c004204206c7c92b0450b80a812bf21b2af71"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"be730749f71e043870c3e9f099aeb65fcfedd253","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3a961159_8a546323","in_reply_to":"3a961159_7bd9d627","updated":"2015-01-20 10:29:39.000000000","message":"+1","commit_id":"b35c004204206c7c92b0450b80a812bf21b2af71"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"41204fdf0cf358c0a74d9753e2a9fee08164a376","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1a930d6b_6bbbe172","in_reply_to":"3a961159_8a546323","updated":"2015-01-20 20:03:46.000000000","message":"It could also be done separately for blueprint reorganize-unit-test-tree","commit_id":"b35c004204206c7c92b0450b80a812bf21b2af71"}],"neutron/tests/unit/test_linux_dhcp.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"5d4ad79015a28d8bff2c3608dd3680b878de1efc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3a961159_bbe33ed7","updated":"2015-01-20 00:09:16.000000000","message":"I\u0027d argue that this file should be move to\nneutron/tests/unit/dhcp/test_linux.py","commit_id":"b35c004204206c7c92b0450b80a812bf21b2af71"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ad59237666fca8f3b40cb3f228acb13626659cb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1a930d6b_4568cef5","in_reply_to":"1a930d6b_abace936","updated":"2015-01-20 23:58:35.000000000","message":"as I said in:\n\nhttps://review.openstack.org/#/c/146024/13/neutron/tests/unit/test_dhcp_agent.py","commit_id":"b35c004204206c7c92b0450b80a812bf21b2af71"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"41204fdf0cf358c0a74d9753e2a9fee08164a376","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1a930d6b_abace936","in_reply_to":"3a961159_aa511f32","updated":"2015-01-20 20:03:46.000000000","message":"It could also be done separately for blueprint reorganize-unit-test-tree","commit_id":"b35c004204206c7c92b0450b80a812bf21b2af71"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"be730749f71e043870c3e9f099aeb65fcfedd253","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3a961159_aa511f32","in_reply_to":"3a961159_bbe33ed7","updated":"2015-01-20 10:29:39.000000000","message":"+1","commit_id":"b35c004204206c7c92b0450b80a812bf21b2af71"}]}