)]}'
{"etc/neutron/plugins/ml2/ml2_conf_odl.ini":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"2b200614d26c9048a812a5d217e7717043ffadf5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Configuration for the OpenDaylight MechanismDriver"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[odl_rest]"},{"line_number":4,"context_line":"# (StrOpt) OpenDaylight REST URL"},{"line_number":5,"context_line":"# If this is not set then no HTTP requests will be made."},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3a961159_9e0cbbee","line":3,"updated":"2015-01-10 00:27:58.000000000","message":"nit: This change has enough ripple effects that it masks the rest of your review.","commit_id":"4dbdd5a89531c4695eb4b9138277b92f88e4e084"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"4c1bc44a93fcc6c442884a51e4c86e84f0a9398e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Configuration for the OpenDaylight MechanismDriver"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[odl_rest]"},{"line_number":4,"context_line":"# (StrOpt) OpenDaylight REST URL"},{"line_number":5,"context_line":"# If this is not set then no HTTP requests will be made."},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3a961159_a41de864","line":3,"in_reply_to":"3a961159_9e0cbbee","updated":"2015-01-10 03:10:49.000000000","message":"I think there is no need to make this change","commit_id":"4dbdd5a89531c4695eb4b9138277b92f88e4e084"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"b2cab1a8b5a1b70c105344258bf0ea6dfe36b290","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Configuration for the OpenDaylight MechanismDriver"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[odl_rest]"},{"line_number":4,"context_line":"# (StrOpt) OpenDaylight REST URL"},{"line_number":5,"context_line":"# If this is not set then no HTTP requests will be made."},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3a961159_627f5467","line":3,"in_reply_to":"3a961159_a41de864","updated":"2015-01-12 15:39:02.000000000","message":"I\u0027ll do this as a follow-on change. Good idea.","commit_id":"4dbdd5a89531c4695eb4b9138277b92f88e4e084"}],"neutron/plugins/ml2/drivers/mechanism_odl.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"07b14c9ad50418b0db8ce834882fda9827e5147e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               help\u003d_(\"Tomcat session timeout in minutes.\")),"},{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"cfg.CONF.register_opts(odl_opts, \"odl_rest\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class OpenDaylightMechanismDriver(api.MechanismDriver):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_44b3644d","line":44,"updated":"2015-01-10 03:32:07.000000000","message":"not sure if there are deployments out there, but you could add:\n\ndeprecated_group\u003d\u0027ml2_odl\u0027 to each of the odl_opts options to keep the old config working.\n\nJust a suggestion.","commit_id":"4dbdd5a89531c4695eb4b9138277b92f88e4e084"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"e184798eb124fdb939b89cfad44c0065682207cd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.openstack.common import log"},{"line_number":21,"context_line":"from neutron.plugins.common import constants"},{"line_number":22,"context_line":"from neutron.plugins.ml2 import driver_api as api"},{"line_number":23,"context_line":"from odldrivers.ml2 import mech_driver"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_85860ab9","line":23,"updated":"2015-01-12 16:13:56.000000000","message":"nit: this is a third-party lib, so it goes in the second import block, not here with neutron.","commit_id":"67cc660658abe8e02ed72e36edc467b3cb537652"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"494db94655342f94930222a894d9c2a521ee3910","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.openstack.common import log"},{"line_number":21,"context_line":"from neutron.plugins.common import constants"},{"line_number":22,"context_line":"from neutron.plugins.ml2 import driver_api as api"},{"line_number":23,"context_line":"from odldrivers.ml2 import mech_driver"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_68ebb578","line":23,"in_reply_to":"3a961159_85860ab9","updated":"2015-01-12 16:36:53.000000000","message":"Done","commit_id":"67cc660658abe8e02ed72e36edc467b3cb537652"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"95facd2b7569b217797ab8b2ab3679dbdaf23af4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from networking_odl.ml2 import mech_driver"},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.common import constants as n_const"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_c492c657","line":16,"updated":"2015-01-12 23:40:56.000000000","message":"where is the networking_odl.ml2 module? Do we need to add it into requirement?","commit_id":"5f07423ed1be5eda6361b042de44849d2fd54719"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"e61c92bbedfcf703fe4896e9b0b7b796d13c8885","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from networking_odl.ml2 import mech_driver"},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.common import constants as n_const"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_b3b17ae2","line":16,"in_reply_to":"3a961159_b8831902","updated":"2015-01-13 03:08:08.000000000","message":"I do plan to remove the unit tests, and will do so in the next rev of this patch. Thanks!","commit_id":"5f07423ed1be5eda6361b042de44849d2fd54719"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"aeacfa6bef23ffb9d2baa74a43a5fc59ef8ba9b8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from networking_odl.ml2 import mech_driver"},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.common import constants as n_const"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_b8831902","line":16,"in_reply_to":"3a961159_c492c657","updated":"2015-01-13 02:09:24.000000000","message":"This is not going to work as is, if you plan on exercising the unit tests by keeping them in the Neutron\u0027s tree. I suspect you won\u0027t, as I can see them in [1], and running successfully in [2]. Bear in mind, in the the vendor decomp spec, we suggested to move the UT with the code itself. So this patch would need to remove the UT with the thinning down of the driver. However if you want to keep them here, the import needs to become dynamic and tests will need to revised to accommodate the new loading mechanism.\n\n[1] https://github.com/stackforge/networking-odl/blob/master/networking-odl/tests/unit/ml2/test_mechanism_odl.py\n[2] https://review.openstack.org/#/c/146668/","commit_id":"5f07423ed1be5eda6361b042de44849d2fd54719"}],"neutron/tests/unit/ml2/test_mechanism_odl.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1e8c8a5ea51e2a8ae6b0d70af0e55fac8e587eb3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"ODL_PORTS \u003d \u0027ports\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"with mock.patch.dict(sys.modules, {\u0027network_odl.ml2\u0027: mock.Mock()}):"},{"line_number":29,"context_line":"    from neutron.plugins.ml2.drivers import mechanism_odl"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_49313458","line":28,"updated":"2015-01-15 03:58:14.000000000","message":"this should be networking_odl, no?","commit_id":"801cdcd159fa8306dbe093c7bc024acbed20a3ef"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"56cc146861e0e2f852aa3d4da607bc525707ff2e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"ODL_PORTS \u003d \u0027ports\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"with mock.patch.dict(sys.modules, {\u0027network_odl.ml2\u0027: mock.Mock()}):"},{"line_number":29,"context_line":"    from neutron.plugins.ml2.drivers import mechanism_odl"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_e96f4026","line":28,"in_reply_to":"3a961159_49313458","updated":"2015-01-15 04:01:28.000000000","message":"I got this passing with:\n\n  with mock.patch.dict(sys.modules, {\u0027networking_odl\u0027: mock.Mock(), \u0027networking_odl.ml2\u0027: mock.Mock()}):\n\nbut I am not sure I am right, I am brain dead at this time of the day.","commit_id":"801cdcd159fa8306dbe093c7bc024acbed20a3ef"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"ec218ae2ef922f3d8cea09c2a9a06b8d1fd0a57d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"ODL_PORTS \u003d \u0027ports\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"with mock.patch.dict(sys.modules, {\u0027network_odl.ml2\u0027: mock.Mock()}):"},{"line_number":29,"context_line":"    from neutron.plugins.ml2.drivers import mechanism_odl"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_446af9b5","line":28,"in_reply_to":"3a961159_e96f4026","updated":"2015-01-15 04:15:10.000000000","message":"That still fails for me when I run:\n\ntox -v -epy27 neutron.tests.unit.ml2.test_mechanism_odl","commit_id":"801cdcd159fa8306dbe093c7bc024acbed20a3ef"}],"setup.cfg":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"2b200614d26c9048a812a5d217e7717043ffadf5","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    gre \u003d neutron.plugins.ml2.drivers.type_gre:GreTypeDriver"},{"line_number":169,"context_line":"    vxlan \u003d neutron.plugins.ml2.drivers.type_vxlan:VxlanTypeDriver"},{"line_number":170,"context_line":"neutron.ml2.mechanism_drivers \u003d"},{"line_number":171,"context_line":"    odl \u003d neutron.plugins.ml2.drivers.mechanism_odl:OpenDaylightMechanismDriver"},{"line_number":172,"context_line":"    logger \u003d neutron.tests.unit.ml2.drivers.mechanism_logger:LoggerMechanismDriver"},{"line_number":173,"context_line":"    test \u003d neutron.tests.unit.ml2.drivers.mechanism_test:TestMechanismDriver"},{"line_number":174,"context_line":"    bulkless \u003d neutron.tests.unit.ml2.drivers.mechanism_bulkless:BulklessMechanismDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3a961159_be117706","line":171,"updated":"2015-01-10 00:27:58.000000000","message":"I\u0027d suggest leaving both, for backwards compatibility (unless opendaylight was a token added for Kilo.)","commit_id":"4dbdd5a89531c4695eb4b9138277b92f88e4e084"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"4c1bc44a93fcc6c442884a51e4c86e84f0a9398e","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    gre \u003d neutron.plugins.ml2.drivers.type_gre:GreTypeDriver"},{"line_number":169,"context_line":"    vxlan \u003d neutron.plugins.ml2.drivers.type_vxlan:VxlanTypeDriver"},{"line_number":170,"context_line":"neutron.ml2.mechanism_drivers \u003d"},{"line_number":171,"context_line":"    odl \u003d neutron.plugins.ml2.drivers.mechanism_odl:OpenDaylightMechanismDriver"},{"line_number":172,"context_line":"    logger \u003d neutron.tests.unit.ml2.drivers.mechanism_logger:LoggerMechanismDriver"},{"line_number":173,"context_line":"    test \u003d neutron.tests.unit.ml2.drivers.mechanism_test:TestMechanismDriver"},{"line_number":174,"context_line":"    bulkless \u003d neutron.tests.unit.ml2.drivers.mechanism_bulkless:BulklessMechanismDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3a961159_c422f4a2","line":171,"in_reply_to":"3a961159_be117706","updated":"2015-01-10 03:10:49.000000000","message":"I think there is no need to make this change.","commit_id":"4dbdd5a89531c4695eb4b9138277b92f88e4e084"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"07b14c9ad50418b0db8ce834882fda9827e5147e","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    gre \u003d neutron.plugins.ml2.drivers.type_gre:GreTypeDriver"},{"line_number":169,"context_line":"    vxlan \u003d neutron.plugins.ml2.drivers.type_vxlan:VxlanTypeDriver"},{"line_number":170,"context_line":"neutron.ml2.mechanism_drivers \u003d"},{"line_number":171,"context_line":"    odl \u003d neutron.plugins.ml2.drivers.mechanism_odl:OpenDaylightMechanismDriver"},{"line_number":172,"context_line":"    logger \u003d neutron.tests.unit.ml2.drivers.mechanism_logger:LoggerMechanismDriver"},{"line_number":173,"context_line":"    test \u003d neutron.tests.unit.ml2.drivers.mechanism_test:TestMechanismDriver"},{"line_number":174,"context_line":"    bulkless \u003d neutron.tests.unit.ml2.drivers.mechanism_bulkless:BulklessMechanismDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3a961159_647f806a","line":171,"in_reply_to":"3a961159_be117706","updated":"2015-01-10 03:32:07.000000000","message":"having the old alias would be more friendly.","commit_id":"4dbdd5a89531c4695eb4b9138277b92f88e4e084"}]}
