)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1167e29a15ae525c80710a9f017e4af7239d4910","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sukhdev \u003csukhdev@aristanetworks.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-09 17:27:36 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Shared networks do not work with Arista ML2 driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a shared network is created, it is stored"},{"line_number":10,"context_line":"in arista_provisioned_nets under the teant_id of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_6543f7af","line":7,"updated":"2015-01-11 08:58:29.000000000","message":"Reword to describe the patch instead of the bug. e.g.\n\nFix shared networks in the Arista ML2 driver","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"fcc6e092b6c0999e732e0e2626f69868e6027584","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sukhdev \u003csukhdev@aristanetworks.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-09 17:27:36 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Shared networks do not work with Arista ML2 driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a shared network is created, it is stored"},{"line_number":10,"context_line":"in arista_provisioned_nets under the teant_id of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_4e10b64f","line":7,"in_reply_to":"3a961159_6543f7af","updated":"2015-01-12 22:47:23.000000000","message":"Done","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1167e29a15ae525c80710a9f017e4af7239d4910","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Shared networks do not work with Arista ML2 driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a shared network is created, it is stored"},{"line_number":10,"context_line":"in arista_provisioned_nets under the teant_id of"},{"line_number":11,"context_line":"owner of the network. Later, when a different"},{"line_number":12,"context_line":"tenant launches an intance on the shared network,"},{"line_number":13,"context_line":"above mentioned DB is looked to find the network"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_850f038b","line":10,"updated":"2015-01-11 08:58:29.000000000","message":"tenant_id","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"fcc6e092b6c0999e732e0e2626f69868e6027584","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Shared networks do not work with Arista ML2 driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a shared network is created, it is stored"},{"line_number":10,"context_line":"in arista_provisioned_nets under the teant_id of"},{"line_number":11,"context_line":"owner of the network. Later, when a different"},{"line_number":12,"context_line":"tenant launches an intance on the shared network,"},{"line_number":13,"context_line":"above mentioned DB is looked to find the network"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_ee76c2a2","line":10,"in_reply_to":"3a961159_850f038b","updated":"2015-01-12 22:47:23.000000000","message":"Done","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"}],"neutron/plugins/ml2/drivers/arista/db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1167e29a15ae525c80710a9f017e4af7239d4910","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def get_shared_network_owner_id(self, network_id):"},{"line_number":399,"context_line":"        network \u003d self._get_network_details(network_id)"},{"line_number":400,"context_line":"        t_id \u003d None"},{"line_number":401,"context_line":"        if network:"},{"line_number":402,"context_line":"            if network[0][\u0027shared\u0027]:"},{"line_number":403,"context_line":"                t_id \u003d network[0][\u0027tenant_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_05231307","line":400,"updated":"2015-01-11 08:58:29.000000000","message":"remove this","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"fcc6e092b6c0999e732e0e2626f69868e6027584","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def get_shared_network_owner_id(self, network_id):"},{"line_number":399,"context_line":"        network \u003d self._get_network_details(network_id)"},{"line_number":400,"context_line":"        t_id \u003d None"},{"line_number":401,"context_line":"        if network:"},{"line_number":402,"context_line":"            if network[0][\u0027shared\u0027]:"},{"line_number":403,"context_line":"                t_id \u003d network[0][\u0027tenant_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_f3d5c91b","line":400,"in_reply_to":"3a961159_05231307","updated":"2015-01-12 22:47:23.000000000","message":"Done","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1167e29a15ae525c80710a9f017e4af7239d4910","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        t_id \u003d None"},{"line_number":401,"context_line":"        if network:"},{"line_number":402,"context_line":"            if network[0][\u0027shared\u0027]:"},{"line_number":403,"context_line":"                t_id \u003d network[0][\u0027tenant_id\u0027]"},{"line_number":404,"context_line":"        return t_id"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def _get_network_details(self, network_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_25200ff8","line":403,"updated":"2015-01-11 08:58:29.000000000","message":"return network[0][\u0027tenant_id\u0027]","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"fcc6e092b6c0999e732e0e2626f69868e6027584","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        t_id \u003d None"},{"line_number":401,"context_line":"        if network:"},{"line_number":402,"context_line":"            if network[0][\u0027shared\u0027]:"},{"line_number":403,"context_line":"                t_id \u003d network[0][\u0027tenant_id\u0027]"},{"line_number":404,"context_line":"        return t_id"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def _get_network_details(self, network_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_33e031fa","line":403,"in_reply_to":"3a961159_25200ff8","updated":"2015-01-12 22:47:23.000000000","message":"Done","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1167e29a15ae525c80710a9f017e4af7239d4910","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        if network:"},{"line_number":402,"context_line":"            if network[0][\u0027shared\u0027]:"},{"line_number":403,"context_line":"                t_id \u003d network[0][\u0027tenant_id\u0027]"},{"line_number":404,"context_line":"        return t_id"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def _get_network_details(self, network_id):"},{"line_number":407,"context_line":"        filters \u003d {\u0027id\u0027: [network_id]}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_451d1bbe","line":404,"updated":"2015-01-11 08:58:29.000000000","message":"then remove this as well. function will return None by default","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"fcc6e092b6c0999e732e0e2626f69868e6027584","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        if network:"},{"line_number":402,"context_line":"            if network[0][\u0027shared\u0027]:"},{"line_number":403,"context_line":"                t_id \u003d network[0][\u0027tenant_id\u0027]"},{"line_number":404,"context_line":"        return t_id"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def _get_network_details(self, network_id):"},{"line_number":407,"context_line":"        filters \u003d {\u0027id\u0027: [network_id]}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_53e4dd0d","line":404,"in_reply_to":"3a961159_451d1bbe","updated":"2015-01-12 22:47:23.000000000","message":"Done","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1167e29a15ae525c80710a9f017e4af7239d4910","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                t_id \u003d network[0][\u0027tenant_id\u0027]"},{"line_number":404,"context_line":"        return t_id"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def _get_network_details(self, network_id):"},{"line_number":407,"context_line":"        filters \u003d {\u0027id\u0027: [network_id]}"},{"line_number":408,"context_line":"        return super(NeutronNets,"},{"line_number":409,"context_line":"                     self).get_networks(self.admin_ctx, filters\u003dfilters) or []"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_651a17c8","line":406,"updated":"2015-01-11 08:58:29.000000000","message":"since this is just one function call and isn\u0027t used anywhere other than the above, I would just move it up there. Also, since you don\u0027t have the get_networks method overwritten, you don\u0027t have to call \u0027super\u0027.\n\n\ndef get_shared_network_owner_id(self, network_id):\n    nets \u003d self.get_networks(self.admin_ctx, filters\u003d{\u0027id\u0027: [network_id]})\n    if not nets:\n        return\n    if nets[0][\u0027shared\u0027]:\n        return nets[0][\u0027tenant_id\u0027]","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"fcc6e092b6c0999e732e0e2626f69868e6027584","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                t_id \u003d network[0][\u0027tenant_id\u0027]"},{"line_number":404,"context_line":"        return t_id"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def _get_network_details(self, network_id):"},{"line_number":407,"context_line":"        filters \u003d {\u0027id\u0027: [network_id]}"},{"line_number":408,"context_line":"        return super(NeutronNets,"},{"line_number":409,"context_line":"                     self).get_networks(self.admin_ctx, filters\u003dfilters) or []"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_73e1d9fb","line":406,"in_reply_to":"3a961159_651a17c8","updated":"2015-01-12 22:47:23.000000000","message":"Done","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"078f5fc99b1c54f2a60233eee78cbd809e9aca4d","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def get_shared_network_owner_id(self, network_id):"},{"line_number":399,"context_line":"        filters \u003d {\u0027id\u0027: [network_id]}"},{"line_number":400,"context_line":"        nets \u003d self.get_networks(self.admin_ctx, filters\u003dfilters) or []"},{"line_number":401,"context_line":"        if not nets:"},{"line_number":402,"context_line":"            return"},{"line_number":403,"context_line":"        if nets[0][\u0027shared\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_386354b2","line":400,"updated":"2015-01-15 01:43:53.000000000","message":"(no action needed)\n\nYou don\u0027t even need the \"or []\" at the end of this because even if None comes back, the next line is just going to return false anyway.","commit_id":"141e7d19e275a7a301ead273fb323aff56333271"}],"neutron/plugins/ml2/drivers/arista/mechanism_arista.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1167e29a15ae525c80710a9f017e4af7239d4910","unresolved":false,"context_lines":[{"line_number":685,"context_line":"                            db_nets[net_id][\u0027segmentationTypeId\u0027],"},{"line_number":686,"context_line":"                         \u0027network_name\u0027:"},{"line_number":687,"context_line":"                            neutron_nets.get(net_id, {\u0027name\u0027: \u0027\u0027})[\u0027name\u0027],"},{"line_number":688,"context_line":"                         \u0027shared\u0027: neutron_nets.get(net_id)[\u0027shared\u0027]}"},{"line_number":689,"context_line":"                        for net_id in nets_to_update"},{"line_number":690,"context_line":"                    ]"},{"line_number":691,"context_line":"                    self._rpc.create_network_bulk(tenant, networks)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_a514ff9f","line":688,"updated":"2015-01-11 08:58:29.000000000","message":"in the line above this one, you protected against the net_id being missing by using the default specifier to \u0027.get\u0027. If you expect that the network might not be present in neutron_nets, you should do the same here\n\n\u0027shared\u0027: neutron_nets.get(net_id, {\u0027shared\u0027: \u0027\u0027})[\u0027shared\u0027]","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"fcc6e092b6c0999e732e0e2626f69868e6027584","unresolved":false,"context_lines":[{"line_number":685,"context_line":"                            db_nets[net_id][\u0027segmentationTypeId\u0027],"},{"line_number":686,"context_line":"                         \u0027network_name\u0027:"},{"line_number":687,"context_line":"                            neutron_nets.get(net_id, {\u0027name\u0027: \u0027\u0027})[\u0027name\u0027],"},{"line_number":688,"context_line":"                         \u0027shared\u0027: neutron_nets.get(net_id)[\u0027shared\u0027]}"},{"line_number":689,"context_line":"                        for net_id in nets_to_update"},{"line_number":690,"context_line":"                    ]"},{"line_number":691,"context_line":"                    self._rpc.create_network_bulk(tenant, networks)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_93ee45ec","line":688,"in_reply_to":"3a961159_a514ff9f","updated":"2015-01-12 22:47:23.000000000","message":"Actually it the default for shared is False not \u0027\u0027, So, I fixed it.","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1167e29a15ae525c80710a9f017e4af7239d4910","unresolved":false,"context_lines":[{"line_number":914,"context_line":"                                                            network_id)"},{"line_number":915,"context_line":"                # If network does not exist under this tenant,"},{"line_number":916,"context_line":"                # it may be a shared network. Get shared network owner Id"},{"line_number":917,"context_line":"                if not net_provisioned:"},{"line_number":918,"context_line":"                    shared_net_owner_id \u003d self.ndb.get_shared_network_owner_id("},{"line_number":919,"context_line":"                                                                    network_id)"},{"line_number":920,"context_line":"                    if shared_net_owner_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c5090b86","line":917,"updated":"2015-01-11 08:58:29.000000000","message":"if you wanted, you could make this all part of one variable assignment\n\nnet_provisioned \u003d (\n    db.is_network_provisioned(tenant_id, network_id) or\n    self.ndb.get_shared_network_owner_id(network_id)\n)","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"fcc6e092b6c0999e732e0e2626f69868e6027584","unresolved":false,"context_lines":[{"line_number":914,"context_line":"                                                            network_id)"},{"line_number":915,"context_line":"                # If network does not exist under this tenant,"},{"line_number":916,"context_line":"                # it may be a shared network. Get shared network owner Id"},{"line_number":917,"context_line":"                if not net_provisioned:"},{"line_number":918,"context_line":"                    shared_net_owner_id \u003d self.ndb.get_shared_network_owner_id("},{"line_number":919,"context_line":"                                                                    network_id)"},{"line_number":920,"context_line":"                    if shared_net_owner_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_b3eb41db","line":917,"in_reply_to":"3a961159_c5090b86","updated":"2015-01-12 22:47:23.000000000","message":"Done","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1167e29a15ae525c80710a9f017e4af7239d4910","unresolved":false,"context_lines":[{"line_number":984,"context_line":"                                                            network_id,"},{"line_number":985,"context_line":"                                                            segmentation_id)"},{"line_number":986,"context_line":"                # If network does not exist under this tenant,"},{"line_number":987,"context_line":"                # it may be a shared network. Get shared network owner Id"},{"line_number":988,"context_line":"                if not net_provisioned:"},{"line_number":989,"context_line":"                    shared_net_owner_id \u003d self.ndb.get_shared_network_owner_id("},{"line_number":990,"context_line":"                                                                    network_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e50e078c","line":987,"updated":"2015-01-11 08:58:29.000000000","message":"same here","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"fcc6e092b6c0999e732e0e2626f69868e6027584","unresolved":false,"context_lines":[{"line_number":984,"context_line":"                                                            network_id,"},{"line_number":985,"context_line":"                                                            segmentation_id)"},{"line_number":986,"context_line":"                # If network does not exist under this tenant,"},{"line_number":987,"context_line":"                # it may be a shared network. Get shared network owner Id"},{"line_number":988,"context_line":"                if not net_provisioned:"},{"line_number":989,"context_line":"                    shared_net_owner_id \u003d self.ndb.get_shared_network_owner_id("},{"line_number":990,"context_line":"                                                                    network_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_d3b7edf6","line":987,"in_reply_to":"3a961159_e50e078c","updated":"2015-01-12 22:47:23.000000000","message":"Done","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"c53a4a309e34bccdc15a1b1d1abf4ba72446aa55","unresolved":false,"context_lines":[{"line_number":685,"context_line":"                            db_nets[net_id][\u0027segmentationTypeId\u0027],"},{"line_number":686,"context_line":"                         \u0027network_name\u0027:"},{"line_number":687,"context_line":"                            neutron_nets.get(net_id, {\u0027name\u0027: \u0027\u0027})[\u0027name\u0027],"},{"line_number":688,"context_line":"                         \u0027shared\u0027: neutron_nets.get(net_id,"},{"line_number":689,"context_line":"                                                  {\u0027shared\u0027: False})[\u0027shared\u0027]}"},{"line_number":690,"context_line":"                        for net_id in nets_to_update"},{"line_number":691,"context_line":"                    ]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_746c0e37","line":688,"updated":"2015-01-14 21:57:37.000000000","message":"This indent is all out of whack. It\u0027s lined up with the hash that is the first element of the networks list, but by syntax, it\u0027s actually part of the hash that\u0027s passed to nets.get().","commit_id":"b67161b98711505b1c08d1c03d5f21e0ac4cc7ae"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"8418bb346f0a0140c87d4f026ffa073fd464a724","unresolved":false,"context_lines":[{"line_number":685,"context_line":"                            db_nets[net_id][\u0027segmentationTypeId\u0027],"},{"line_number":686,"context_line":"                         \u0027network_name\u0027:"},{"line_number":687,"context_line":"                            neutron_nets.get(net_id, {\u0027name\u0027: \u0027\u0027})[\u0027name\u0027],"},{"line_number":688,"context_line":"                         \u0027shared\u0027: neutron_nets.get(net_id,"},{"line_number":689,"context_line":"                                                  {\u0027shared\u0027: False})[\u0027shared\u0027]}"},{"line_number":690,"context_line":"                        for net_id in nets_to_update"},{"line_number":691,"context_line":"                    ]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_3d9a6962","line":688,"in_reply_to":"3a961159_746c0e37","updated":"2015-01-14 23:30:03.000000000","message":"Done","commit_id":"b67161b98711505b1c08d1c03d5f21e0ac4cc7ae"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"c53a4a309e34bccdc15a1b1d1abf4ba72446aa55","unresolved":false,"context_lines":[{"line_number":983,"context_line":"                    db.is_network_provisioned(tenant_id, network_id,"},{"line_number":984,"context_line":"                                              segmentation_id) or"},{"line_number":985,"context_line":"                    self.ndb.get_shared_network_owner_id(network_id)"},{"line_number":986,"context_line":"                )"},{"line_number":987,"context_line":"                if vm_provisioned and net_provisioned:"},{"line_number":988,"context_line":"                    try:"},{"line_number":989,"context_line":"                        self.rpc.plug_port_into_network(device_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_94697a27","line":986,"updated":"2015-01-14 21:57:37.000000000","message":"This is dup\u0027ed, which implies it\u0027d make a good helper func.","commit_id":"b67161b98711505b1c08d1c03d5f21e0ac4cc7ae"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"8418bb346f0a0140c87d4f026ffa073fd464a724","unresolved":false,"context_lines":[{"line_number":983,"context_line":"                    db.is_network_provisioned(tenant_id, network_id,"},{"line_number":984,"context_line":"                                              segmentation_id) or"},{"line_number":985,"context_line":"                    self.ndb.get_shared_network_owner_id(network_id)"},{"line_number":986,"context_line":"                )"},{"line_number":987,"context_line":"                if vm_provisioned and net_provisioned:"},{"line_number":988,"context_line":"                    try:"},{"line_number":989,"context_line":"                        self.rpc.plug_port_into_network(device_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_9d719d47","line":986,"in_reply_to":"3a961159_94697a27","updated":"2015-01-14 23:30:03.000000000","message":"Even though it looks identical, it is slightly different (different number of parameters). Other than these two places it is not used anywhere - so, it is toss as to create a separate method leave it as-is.","commit_id":"b67161b98711505b1c08d1c03d5f21e0ac4cc7ae"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"d61f29122ec1e5697a93659d0f27c19bfb14231f","unresolved":false,"context_lines":[{"line_number":983,"context_line":"                    db.is_network_provisioned(tenant_id, network_id,"},{"line_number":984,"context_line":"                                              segmentation_id) or"},{"line_number":985,"context_line":"                    self.ndb.get_shared_network_owner_id(network_id)"},{"line_number":986,"context_line":"                )"},{"line_number":987,"context_line":"                if vm_provisioned and net_provisioned:"},{"line_number":988,"context_line":"                    try:"},{"line_number":989,"context_line":"                        self.rpc.plug_port_into_network(device_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_9da51d4a","line":986,"in_reply_to":"3a961159_9d719d47","updated":"2015-01-14 23:35:38.000000000","message":"I\u0027d use a default arg for the difference. Personally, I\u0027d fix it, but I\u0027m not going to -1 for that part.","commit_id":"b67161b98711505b1c08d1c03d5f21e0ac4cc7ae"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"041e2b34d5a983871c3d73df1aa2e3a9725959af","unresolved":false,"context_lines":[{"line_number":983,"context_line":"                    db.is_network_provisioned(tenant_id, network_id,"},{"line_number":984,"context_line":"                                              segmentation_id) or"},{"line_number":985,"context_line":"                    self.ndb.get_shared_network_owner_id(network_id)"},{"line_number":986,"context_line":"                )"},{"line_number":987,"context_line":"                if vm_provisioned and net_provisioned:"},{"line_number":988,"context_line":"                    try:"},{"line_number":989,"context_line":"                        self.rpc.plug_port_into_network(device_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_a867f9b6","line":986,"in_reply_to":"3a961159_9da51d4a","updated":"2015-01-14 23:50:43.000000000","message":"Thanks - appreciate it..","commit_id":"b67161b98711505b1c08d1c03d5f21e0ac4cc7ae"}],"neutron/tests/unit/ml2/drivers/arista/test_arista_mechanism_driver.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1167e29a15ae525c80710a9f017e4af7239d4910","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            \u0027network_id\u0027: \u0027net-id-%d\u0027 % net_id,"},{"line_number":347,"context_line":"            \u0027network_name\u0027: \u0027net-name-%d\u0027 % net_id,"},{"line_number":348,"context_line":"            \u0027segmentation_id\u0027: net_id,"},{"line_number":349,"context_line":"            \u0027shared\u0027: shared_network} for net_id in range(1, num_networks)"},{"line_number":350,"context_line":"        ]"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        self.drv.create_network_bulk(tenant_id, networks)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_4546fbc1","line":349,"updated":"2015-01-11 08:58:29.000000000","message":"The shared_network variable isn\u0027t referenced anywhere else, it\u0027s just as easy to follow and a little shorter if you just put \"\u0027shared\u0027: True\" here.","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"fcc6e092b6c0999e732e0e2626f69868e6027584","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            \u0027network_id\u0027: \u0027net-id-%d\u0027 % net_id,"},{"line_number":347,"context_line":"            \u0027network_name\u0027: \u0027net-name-%d\u0027 % net_id,"},{"line_number":348,"context_line":"            \u0027segmentation_id\u0027: net_id,"},{"line_number":349,"context_line":"            \u0027shared\u0027: shared_network} for net_id in range(1, num_networks)"},{"line_number":350,"context_line":"        ]"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        self.drv.create_network_bulk(tenant_id, networks)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_73aab91b","line":349,"in_reply_to":"3a961159_4546fbc1","updated":"2015-01-12 22:47:23.000000000","message":"Done","commit_id":"6fc89ff0811be99887fb9dda36c28482fe93e1d6"}]}