)]}'
{"quantum/agent/linux/interface.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7de8dfb9ce72c3bf1edc37b91f2d45f17b135d13","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            root_veth, dhcp_veth \u003d ip.add_veth(tap_name, device_name)"},{"line_number":179,"context_line":"            root_veth.link.set_address(mac_address)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            if self.conf.network_device_mtu:"},{"line_number":182,"context_line":"                root_veth.link.set_mtu(self.conf.network_device_mtu)"},{"line_number":183,"context_line":"                dhcp_veth.link.set_mtu(self.conf.network_device_mtu)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F%2Be4%3D","line":181,"updated":"2012-10-23 19:38:59.000000000","message":"Would this not be better if it were per network?","commit_id":"3316ee028efc6eb2a2ef6a7140ea945c9c39d1f3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"94e6f790f3a6e02585ff7656095f24fe42bb7df3","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            root_veth, dhcp_veth \u003d ip.add_veth(tap_name, device_name)"},{"line_number":179,"context_line":"            root_veth.link.set_address(mac_address)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            if self.conf.network_device_mtu:"},{"line_number":182,"context_line":"                root_veth.link.set_mtu(self.conf.network_device_mtu)"},{"line_number":183,"context_line":"                dhcp_veth.link.set_mtu(self.conf.network_device_mtu)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F%2BWA%3D","line":181,"in_reply_to":"AAAALn%2F%2F%2BbE%3D","updated":"2012-10-23 22:03:42.000000000","message":"I\u0027m not sure I see the harm in accepting this now as parity is a good thing (this should have been in my original version of the lib and overlooked when writing it).  Implementers should understand the ramifications of adjusting the MTU (they\u0027re likely to make it bigger).  \n\nRkukura\u0027s provider network changes could make setting the MTU more versatile, but that is a milestone or 2 away.  For the folks closely tracking master they get jumbo frame support now and when we replace it with a better implementation we\u0027re only throwing out 3 lines of code.","commit_id":"3316ee028efc6eb2a2ef6a7140ea945c9c39d1f3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":178,"context_line":"            root_veth, dhcp_veth \u003d ip.add_veth(tap_name, device_name)"},{"line_number":179,"context_line":"            root_veth.link.set_address(mac_address)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            if self.conf.network_device_mtu:"},{"line_number":182,"context_line":"                root_veth.link.set_mtu(self.conf.network_device_mtu)"},{"line_number":183,"context_line":"                dhcp_veth.link.set_mtu(self.conf.network_device_mtu)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F%2BbE%3D","line":181,"in_reply_to":"AAAALn%2F%2F%2Bcc%3D","updated":"2012-10-23 20:27:29.000000000","message":"I understand. When the drivers where first added the provider networks did not exist. I think with the fact that we now have the provider networks - these enable one to create vlan tag etc on the network, we should consider extending this to attributes like MTU.\nI just think that this vey limiting and maybe impractical with the configuration variable - worst case scenario is that the MTU is small and all VM\u0027s will suffer.","commit_id":"3316ee028efc6eb2a2ef6a7140ea945c9c39d1f3"},{"author":{"_account_id":2109,"name":"Jonathan LaCour","email":"jonathan@cleverdevil.org","username":"cleverdevil"},"change_message_id":"650d14f3d3adae4a43eb4f18162c7343f4a45426","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            root_veth, dhcp_veth \u003d ip.add_veth(tap_name, device_name)"},{"line_number":179,"context_line":"            root_veth.link.set_address(mac_address)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            if self.conf.network_device_mtu:"},{"line_number":182,"context_line":"                root_veth.link.set_mtu(self.conf.network_device_mtu)"},{"line_number":183,"context_line":"                dhcp_veth.link.set_mtu(self.conf.network_device_mtu)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2F%2Bcc%3D","line":181,"in_reply_to":"AAAALn%2F%2F%2Be4%3D","updated":"2012-10-23 20:12:13.000000000","message":"Potentially, but that\u0027s a different problem, and a different ticket down the line. This change simply brings parity to the Linux bridge interface. Down the line, we could add the ability to specify different MTUs, but its a larger change.","commit_id":"3316ee028efc6eb2a2ef6a7140ea945c9c39d1f3"}]}