)]}'
{"etc/dhcp_agent.ini":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"01316695887b8326bf00f75fd2a1857dad6f18b8","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# Use broadcast in DHCP replies"},{"line_number":76,"context_line":"# dhcp_broadcast_reply \u003d False"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# User (uid or name) running metadata proxy after its initialization"},{"line_number":79,"context_line":"# (if empty: L3 agent effective user)"},{"line_number":80,"context_line":"# metadata_proxy_user \u003d"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa81d914_1147954c","line":78,"updated":"2015-01-29 11:53:29.000000000","message":"I think we should move those settings to neutron.conf and into agent section and reuse those for all agents. Same as we did for process monitor related settings from Miguel\u0027s patches.\n\nProbably it would belong to a separate patch to facilitate quicker merge.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"93995511c1c84de9b6f337cd2f211862266733ef","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# Use broadcast in DHCP replies"},{"line_number":76,"context_line":"# dhcp_broadcast_reply \u003d False"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# User (uid or name) running metadata proxy after its initialization"},{"line_number":79,"context_line":"# (if empty: L3 agent effective user)"},{"line_number":80,"context_line":"# metadata_proxy_user \u003d"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa81d914_c8f2a7d1","line":78,"in_reply_to":"fa81d914_1147954c","updated":"2015-01-29 14:06:54.000000000","message":"I agree. If they are going to be replicated across agents, better to have them all in a single point.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1c5a5491dae0c74f99e37814350d0752910628bb","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# Use broadcast in DHCP replies"},{"line_number":76,"context_line":"# dhcp_broadcast_reply \u003d False"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# User (uid or name) running metadata proxy after its initialization"},{"line_number":79,"context_line":"# (if empty: L3 agent effective user)"},{"line_number":80,"context_line":"# metadata_proxy_user \u003d"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa81d914_580da63d","line":78,"in_reply_to":"fa81d914_3872b2e5","updated":"2015-01-29 15:24:30.000000000","message":"It\u0027s confusing as deployers (it includes mylself) could assume neutron.conf is for shared options between ALL services not just some.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5c7e94e7d74a1bd2fe0d0a02b5e898090e397945","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# Use broadcast in DHCP replies"},{"line_number":76,"context_line":"# dhcp_broadcast_reply \u003d False"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# User (uid or name) running metadata proxy after its initialization"},{"line_number":79,"context_line":"# (if empty: L3 agent effective user)"},{"line_number":80,"context_line":"# metadata_proxy_user \u003d"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa81d914_3872b2e5","line":78,"in_reply_to":"fa81d914_4343f813","updated":"2015-01-29 15:03:38.000000000","message":"What\u0027s wrong with having those config options maintained in single place and not duplicated throughout agent configs?","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"487169d00418a1b358762ae57e12a189b31ada32","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# Use broadcast in DHCP replies"},{"line_number":76,"context_line":"# dhcp_broadcast_reply \u003d False"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# User (uid or name) running metadata proxy after its initialization"},{"line_number":79,"context_line":"# (if empty: L3 agent effective user)"},{"line_number":80,"context_line":"# metadata_proxy_user \u003d"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-properties","patch_set":6,"id":"da86d52c_426a4f1b","line":78,"in_reply_to":"fa81d914_580da63d","updated":"2015-02-02 12:11:14.000000000","message":"No, we have plenty of other options that are not shared between all services, like [database] or [service_providers] or comment_iptables_rules\u003d.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"870e8ee762fb81cb0e84fbd7001cbcda9281aa21","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# Use broadcast in DHCP replies"},{"line_number":76,"context_line":"# dhcp_broadcast_reply \u003d False"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# User (uid or name) running metadata proxy after its initialization"},{"line_number":79,"context_line":"# (if empty: L3 agent effective user)"},{"line_number":80,"context_line":"# metadata_proxy_user \u003d"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa81d914_4ee87ce2","line":78,"in_reply_to":"fa81d914_580da63d","updated":"2015-01-29 15:32:52.000000000","message":"well, all services spawning a metadata_proxy would pull from there, may be we must list them there.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ce96bc8b202d349c6c03a723c05fe04dae717914","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# Use broadcast in DHCP replies"},{"line_number":76,"context_line":"# dhcp_broadcast_reply \u003d False"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# User (uid or name) running metadata proxy after its initialization"},{"line_number":79,"context_line":"# (if empty: L3 agent effective user)"},{"line_number":80,"context_line":"# metadata_proxy_user \u003d"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa81d914_4343f813","line":78,"in_reply_to":"fa81d914_c8f2a7d1","updated":"2015-01-29 14:14:43.000000000","message":"It concerns some agents not all agents nor neutron-server so i don\u0027t understand why we should pollute neutron.conf with such config options.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"870e8ee762fb81cb0e84fbd7001cbcda9281aa21","unresolved":false,"context_lines":[{"line_number":76,"context_line":"# dhcp_broadcast_reply \u003d False"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# User (uid or name) running metadata proxy after its initialization"},{"line_number":79,"context_line":"# (if empty: L3 agent effective user)"},{"line_number":80,"context_line":"# metadata_proxy_user \u003d"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Group (gid or name) running metadata proxy after its initialization"}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa81d914_aeed78f1","line":79,"updated":"2015-01-29 15:32:52.000000000","message":"anyway if we keep it here L3-\u003edhcp","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"870e8ee762fb81cb0e84fbd7001cbcda9281aa21","unresolved":false,"context_lines":[{"line_number":80,"context_line":"# metadata_proxy_user \u003d"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Group (gid or name) running metadata proxy after its initialization"},{"line_number":83,"context_line":"# (if empty: L3 agent effective group)"},{"line_number":84,"context_line":"# metadata_proxy_group \u003d"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Location of Metadata Proxy UNIX domain socket"}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa81d914_cebb8ce3","line":83,"updated":"2015-01-29 15:32:52.000000000","message":"ditto.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b3245d2a0cef8cab323663731624e642267eb47f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"# metadata_proxy_group \u003d"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Location of Metadata Proxy UNIX domain socket"},{"line_number":87,"context_line":"# metadata_proxy_socket \u003d $state_path/metadata_proxy"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# dhcp_delete_namespaces, which is false by default, can be set to True if"},{"line_number":90,"context_line":"# namespaces can be deleted cleanly on the host running the dhcp agent."}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa81d914_75452416","line":87,"updated":"2015-01-29 08:00:41.000000000","message":"This line should be remove if dhcp_agent doesn\u0027t use metadata_proxy_socket.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ada126163d0bccb2c30f68655125a79f8c9a55a4","unresolved":false,"context_lines":[{"line_number":84,"context_line":"# metadata_proxy_group \u003d"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Location of Metadata Proxy UNIX domain socket"},{"line_number":87,"context_line":"# metadata_proxy_socket \u003d $state_path/metadata_proxy"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# dhcp_delete_namespaces, which is false by default, can be set to True if"},{"line_number":90,"context_line":"# namespaces can be deleted cleanly on the host running the dhcp agent."}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa81d914_c702a33d","line":87,"in_reply_to":"fa81d914_75452416","updated":"2015-01-29 09:08:23.000000000","message":"@Hirofumi: It uses it","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"01316695887b8326bf00f75fd2a1857dad6f18b8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"# metadata_proxy_group \u003d"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Location of Metadata Proxy UNIX domain socket"},{"line_number":87,"context_line":"# metadata_proxy_socket \u003d $state_path/metadata_proxy"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# dhcp_delete_namespaces, which is false by default, can be set to True if"},{"line_number":90,"context_line":"# namespaces can be deleted cleanly on the host running the dhcp agent."}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa81d914_b14b292a","line":87,"in_reply_to":"fa81d914_8adef23d","updated":"2015-01-29 11:53:29.000000000","message":"Since the option is used by multiple agents, I guess it also belongs to neutron.conf, preferably agent section. Though if we go switching the section, we\u0027ll need to specify deprecated section for the option in metadata driver so that existing consumers are not broken.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ce96bc8b202d349c6c03a723c05fe04dae717914","unresolved":false,"context_lines":[{"line_number":84,"context_line":"# metadata_proxy_group \u003d"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Location of Metadata Proxy UNIX domain socket"},{"line_number":87,"context_line":"# metadata_proxy_socket \u003d $state_path/metadata_proxy"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# dhcp_delete_namespaces, which is false by default, can be set to True if"},{"line_number":90,"context_line":"# namespaces can be deleted cleanly on the host running the dhcp agent."}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa81d914_635d5ce9","line":87,"in_reply_to":"fa81d914_b14b292a","updated":"2015-01-29 14:14:43.000000000","message":"same remark","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c5f798176877584d573185e1add95b40c23d7ca","unresolved":false,"context_lines":[{"line_number":84,"context_line":"# metadata_proxy_group \u003d"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Location of Metadata Proxy UNIX domain socket"},{"line_number":87,"context_line":"# metadata_proxy_socket \u003d $state_path/metadata_proxy"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# dhcp_delete_namespaces, which is false by default, can be set to True if"},{"line_number":90,"context_line":"# namespaces can be deleted cleanly on the host running the dhcp agent."}],"source_content_type":"text/x-properties","patch_set":6,"id":"fa81d914_8adef23d","line":87,"in_reply_to":"fa81d914_c702a33d","updated":"2015-01-29 09:29:18.000000000","message":"I might be wrong , but I don\u0027t know where does dhcp agent use it except dhcp/agent.py removed code using it by this patch.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"12e15c0a295115e66c9e2e99b3e6c7c1a1e47829","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# User (uid or name) running metadata proxy after its initialization"},{"line_number":79,"context_line":"# (if empty: dhcp agent effective user)"},{"line_number":80,"context_line":"# metadata_proxy_user \u003d"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Group (gid or name) running metadata proxy after its initialization"},{"line_number":83,"context_line":"# (if empty: dhcp agent effective group)"}],"source_content_type":"text/x-properties","patch_set":10,"id":"da86d52c_62775303","line":80,"updated":"2015-02-02 12:11:05.000000000","message":"I still think those definitions belong to neutron.conf","commit_id":"9c9fcb8b3f3d4642ac114ccb8b958a2dfef62e96"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"224fc711506ac98f8c0802a82bbebd49f32c59bc","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# User (uid or name) running metadata proxy after its initialization"},{"line_number":79,"context_line":"# (if empty: dhcp agent effective user)"},{"line_number":80,"context_line":"# metadata_proxy_user \u003d"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Group (gid or name) running metadata proxy after its initialization"},{"line_number":83,"context_line":"# (if empty: dhcp agent effective group)"}],"source_content_type":"text/x-properties","patch_set":10,"id":"da86d52c_78bb840e","line":80,"in_reply_to":"da86d52c_62775303","updated":"2015-02-02 12:53:49.000000000","message":"Me too (as soon as we start sharing it among agents). IT needs more work, like changing it for the l3_agent too, and adding the deprecated opts support...","commit_id":"9c9fcb8b3f3d4642ac114ccb8b958a2dfef62e96"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e34d231f48738251e2da89e31a20029c73c8580f","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# User (uid or name) running metadata proxy after its initialization"},{"line_number":79,"context_line":"# (if empty: dhcp agent effective user)"},{"line_number":80,"context_line":"# metadata_proxy_user \u003d"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Group (gid or name) running metadata proxy after its initialization"},{"line_number":83,"context_line":"# (if empty: dhcp agent effective group)"}],"source_content_type":"text/x-properties","patch_set":10,"id":"da86d52c_a007431b","line":80,"in_reply_to":"da86d52c_78bb840e","updated":"2015-02-03 15:47:59.000000000","message":"The rule seems unclear to me (look at metadata_proxy_socket option), so i would prefer we address it in a follow-up change. Moreover it seems to me to be a bad practice: typically database connection information are in neutron.conf but only used by the plugin/neutron-server and we end with agents loading db connection information without needing them.","commit_id":"9c9fcb8b3f3d4642ac114ccb8b958a2dfef62e96"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2a6d16a1509be3e5ab0968171071e5395cf88de7","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# User (uid or name) running metadata proxy after its initialization"},{"line_number":79,"context_line":"# (if empty: dhcp agent effective user)"},{"line_number":80,"context_line":"# metadata_proxy_user \u003d"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Group (gid or name) running metadata proxy after its initialization"},{"line_number":83,"context_line":"# (if empty: dhcp agent effective group)"}],"source_content_type":"text/x-properties","patch_set":10,"id":"da86d52c_5af726f5","line":80,"in_reply_to":"da86d52c_a007431b","updated":"2015-02-04 14:44:07.000000000","message":"That is also a fair point. I think we should rethink how we manage our config files. There is some balance between reusing configuration descriptions as in proposal of Miguel and me, and in reducing loading time in your comment.\n\nNow that I think about it, it should definitely be handled in separate patches, if at all. Though in any case, there should be some consistency in where we put agent specific config values that are not global but used in multiple agents.","commit_id":"9c9fcb8b3f3d4642ac114ccb8b958a2dfef62e96"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"01316695887b8326bf00f75fd2a1857dad6f18b8","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                neutron_lookup_param \u003d (\u0027--router_id\u003d%s\u0027 %"},{"line_number":362,"context_line":"                                        router_ports[0].device_id)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("},{"line_number":365,"context_line":"            self._process_monitor, network.id, network.namespace,"},{"line_number":366,"context_line":"            neutron_lookup_param, dhcp.METADATA_PORT, self.conf)"},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_f1776100","line":364,"updated":"2015-01-29 11:53:29.000000000","message":"That is cool.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"01316695887b8326bf00f75fd2a1857dad6f18b8","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("},{"line_number":365,"context_line":"            self._process_monitor, network.id, network.namespace,"},{"line_number":366,"context_line":"            neutron_lookup_param, dhcp.METADATA_PORT, self.conf)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def disable_isolated_metadata_proxy(self, network):"},{"line_number":369,"context_line":"        metadata_driver.MetadataDriver.destroy_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_ecc86676","line":366,"updated":"2015-01-29 11:53:29.000000000","message":"(No action required)\n\nSince you are deeply involved in the code, can you elaborate on why we have it hardcoded here and not as a conf option as in l3 agent? I would greatly appreciate it.\n\nI wonder whether we can define the option on self.conf and get rid of that port argument.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1c5a5491dae0c74f99e37814350d0752910628bb","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("},{"line_number":365,"context_line":"            self._process_monitor, network.id, network.namespace,"},{"line_number":366,"context_line":"            neutron_lookup_param, dhcp.METADATA_PORT, self.conf)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def disable_isolated_metadata_proxy(self, network):"},{"line_number":369,"context_line":"        metadata_driver.MetadataDriver.destroy_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_6bca926f","line":366,"in_reply_to":"fa81d914_082d9ffe","updated":"2015-01-29 15:24:30.000000000","message":"It looks strange but dhcp/l3 agents run metadata proxies differently:\n\n* l3 agent metadata proxies listen on an unprivileged (configurable) port + iptables redirection from tcp 80\n* dhcp agent metadata proxy listen directly on tcp 80 (not configurable).\n\nThe aim of the change is not to choose which one is better than the other (if any). :-)","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"870e8ee762fb81cb0e84fbd7001cbcda9281aa21","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("},{"line_number":365,"context_line":"            self._process_monitor, network.id, network.namespace,"},{"line_number":366,"context_line":"            neutron_lookup_param, dhcp.METADATA_PORT, self.conf)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def disable_isolated_metadata_proxy(self, network):"},{"line_number":369,"context_line":"        metadata_driver.MetadataDriver.destroy_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_ee93f04c","line":366,"in_reply_to":"fa81d914_6bca926f","updated":"2015-01-29 15:32:52.000000000","message":"I suppose dhcp agent doesn\u0027t set any iptables rules, so it was simpler to stay on the standard port the instance will talk to.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"93995511c1c84de9b6f337cd2f211862266733ef","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("},{"line_number":365,"context_line":"            self._process_monitor, network.id, network.namespace,"},{"line_number":366,"context_line":"            neutron_lookup_param, dhcp.METADATA_PORT, self.conf)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def disable_isolated_metadata_proxy(self, network):"},{"line_number":369,"context_line":"        metadata_driver.MetadataDriver.destroy_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_082d9ffe","line":366,"in_reply_to":"fa81d914_ecc86676","updated":"2015-01-29 14:06:54.000000000","message":"Very nice refactor, indeed!.\n\nBy the way, I believe we should scind the spawning methods to a separate class, since MetadataDriver accepts events from the l3_agent, calling those methods as classmethods is weird.\n\nI would separate spawning into a MetadataProxyManager or something\nequivalent, which is the usual naming we have for system interacting stuff.\n\nNot: not asking to do it in this patch if you don\u0027t have the time, but I believe it\u0027s a good idea to separate both (MetadataDriver receiving events from l3, and MetadataProxyManager just in charge of spawning/disabling metadata proxies where we need).","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0ba0e13472f463ccac08f95edd4671e6976e1600","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("},{"line_number":365,"context_line":"            self._process_monitor, network.id, network.namespace,"},{"line_number":366,"context_line":"            neutron_lookup_param, dhcp.METADATA_PORT, self.conf)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def disable_isolated_metadata_proxy(self, network):"},{"line_number":369,"context_line":"        metadata_driver.MetadataDriver.destroy_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_f9480e89","line":366,"in_reply_to":"fa81d914_ee93f04c","updated":"2015-01-29 21:12:05.000000000","message":"I think it comes from the dark age when quantum used no namespace and uses nova-api-metadata as \"metadata-proxy\" ... which implies to redirect tcp 80 to nova-api unprivileged port ... and l3-agent metadata-proxy used the same logic.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"}],"neutron/agent/dhcp/config.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"93995511c1c84de9b6f337cd2f211862266733ef","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.StrOpt(\u0027metadata_proxy_socket\u0027,"},{"line_number":34,"context_line":"               default\u003d\u0027$state_path/metadata_proxy\u0027,"},{"line_number":35,"context_line":"               help\u003d_(\u0027Location of Metadata Proxy UNIX domain \u0027"},{"line_number":36,"context_line":"                      \u0027socket\u0027)),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"DHCP_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_2817c3a4","side":"PARENT","line":36,"updated":"2015-01-29 14:06:54.000000000","message":"why is it removed here but not in the .ini file?.","commit_id":"f373c6998c512a3e4bbded27f6ec22ecb48f2577"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e980f460ba2ca6a23fbf9f8d96445ad2b23bdf8d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.StrOpt(\u0027metadata_proxy_socket\u0027,"},{"line_number":34,"context_line":"               default\u003d\u0027$state_path/metadata_proxy\u0027,"},{"line_number":35,"context_line":"               help\u003d_(\u0027Location of Metadata Proxy UNIX domain \u0027"},{"line_number":36,"context_line":"                      \u0027socket\u0027)),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"DHCP_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_f899fa1f","side":"PARENT","line":36,"in_reply_to":"fa81d914_2817c3a4","updated":"2015-01-29 15:02:23.000000000","message":"I guess because the option is still imported into the agent, from metadata driver.","commit_id":"f373c6998c512a3e4bbded27f6ec22ecb48f2577"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1c5a5491dae0c74f99e37814350d0752910628bb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.StrOpt(\u0027metadata_proxy_socket\u0027,"},{"line_number":34,"context_line":"               default\u003d\u0027$state_path/metadata_proxy\u0027,"},{"line_number":35,"context_line":"               help\u003d_(\u0027Location of Metadata Proxy UNIX domain \u0027"},{"line_number":36,"context_line":"                      \u0027socket\u0027)),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"DHCP_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_b83062e9","side":"PARENT","line":36,"in_reply_to":"fa81d914_2817c3a4","updated":"2015-01-29 15:24:30.000000000","message":"it\u0027s not removed but moved to MetadataDriver.OPTS","commit_id":"f373c6998c512a3e4bbded27f6ec22ecb48f2577"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"870e8ee762fb81cb0e84fbd7001cbcda9281aa21","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.StrOpt(\u0027metadata_proxy_socket\u0027,"},{"line_number":34,"context_line":"               default\u003d\u0027$state_path/metadata_proxy\u0027,"},{"line_number":35,"context_line":"               help\u003d_(\u0027Location of Metadata Proxy UNIX domain \u0027"},{"line_number":36,"context_line":"                      \u0027socket\u0027)),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"DHCP_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_aea9f87c","side":"PARENT","line":36,"in_reply_to":"fa81d914_b83062e9","updated":"2015-01-29 15:32:52.000000000","message":"Ahh, ack!, sorry.","commit_id":"f373c6998c512a3e4bbded27f6ec22ecb48f2577"}],"neutron/agent/exceptions.py":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"dcb1c9a56f3d63917697f006a44d26ff0d5e2de3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class NetworkIdOrRouterIdRequiredError(ValueError):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    def __init__(self):"},{"line_number":20,"context_line":"        super(NetworkIdOrRouterIdRequiredError, self).__init__("}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_7a63bc41","line":17,"updated":"2015-02-06 06:51:26.000000000","message":"Do we really want to add a new exceptions file?\nI would rather use the neutron.common import exceptions","commit_id":"512d5882389e368997fbbe15d1a037559cbf0b35"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"8ff6e6744a4c284a6a6574f3f6c4a070abbef2a9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class NetworkIdOrRouterIdRequiredError(ValueError):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    def __init__(self):"},{"line_number":20,"context_line":"        super(NetworkIdOrRouterIdRequiredError, self).__init__("}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_0be51008","line":17,"in_reply_to":"da86d52c_7a63bc41","updated":"2015-02-06 09:09:53.000000000","message":"Done","commit_id":"512d5882389e368997fbbe15d1a037559cbf0b35"}],"neutron/agent/metadata/driver.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"01316695887b8326bf00f75fd2a1857dad6f18b8","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @classmethod"},{"line_number":98,"context_line":"    def spawn_monitored_metadata_proxy(cls, monitor, uuid, ns_name,"},{"line_number":99,"context_line":"                                       lookup_param, port, conf):"},{"line_number":100,"context_line":"        callback \u003d cls._get_metadata_proxy_callback("},{"line_number":101,"context_line":"            uuid, lookup_param, port, conf)"},{"line_number":102,"context_line":"        monitor.enable(uuid, callback, ns_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_f1f121ce","line":99,"updated":"2015-01-29 11:53:29.000000000","message":"It\u0027s either router or network, right? Then how about adding two kwargs - network\u003dNone and router\u003dNone and requiring one of those is passed? Or it may be a dictionary like {\u0027router_id\u0027: ...} that will be parsed into --router_id\u003d... for each key of the collection.\n\nI don\u0027t like the idea of consumers of the method passing around command line arguments.","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1c5a5491dae0c74f99e37814350d0752910628bb","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @classmethod"},{"line_number":98,"context_line":"    def spawn_monitored_metadata_proxy(cls, monitor, uuid, ns_name,"},{"line_number":99,"context_line":"                                       lookup_param, port, conf):"},{"line_number":100,"context_line":"        callback \u003d cls._get_metadata_proxy_callback("},{"line_number":101,"context_line":"            uuid, lookup_param, port, conf)"},{"line_number":102,"context_line":"        monitor.enable(uuid, callback, ns_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_2ef8a8e4","line":99,"in_reply_to":"fa81d914_f1f121ce","updated":"2015-01-29 15:24:30.000000000","message":"Done","commit_id":"571f7a82b8cbbd9201cb4fa1b7101b9ad4e49d6a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"12e15c0a295115e66c9e2e99b3e6c7c1a1e47829","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                     router_id\u003dNone):"},{"line_number":97,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":98,"context_line":"        if uuid is None:"},{"line_number":99,"context_line":"            raise ValueError(\u0027network_id and router_id are None. \u0027"},{"line_number":100,"context_line":"                             \u0027One must be provided\u0027)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if network_id:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_02ee9788","line":99,"updated":"2015-02-02 12:11:05.000000000","message":"So we raise the exception to user? Should we make it translatable then?","commit_id":"9c9fcb8b3f3d4642ac114ccb8b958a2dfef62e96"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e34d231f48738251e2da89e31a20029c73c8580f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                     router_id\u003dNone):"},{"line_number":97,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":98,"context_line":"        if uuid is None:"},{"line_number":99,"context_line":"            raise ValueError(\u0027network_id and router_id are None. \u0027"},{"line_number":100,"context_line":"                             \u0027One must be provided\u0027)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if network_id:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_ca1616f1","line":99,"in_reply_to":"da86d52c_02ee9788","updated":"2015-02-03 15:47:59.000000000","message":"Done","commit_id":"9c9fcb8b3f3d4642ac114ccb8b958a2dfef62e96"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"224fc711506ac98f8c0802a82bbebd49f32c59bc","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                     router_id\u003dNone):"},{"line_number":97,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":98,"context_line":"        if uuid is None:"},{"line_number":99,"context_line":"            raise ValueError(\u0027network_id and router_id are None. \u0027"},{"line_number":100,"context_line":"                             \u0027One must be provided\u0027)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if network_id:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_18dd2871","line":99,"in_reply_to":"da86d52c_02ee9788","updated":"2015-02-02 12:53:49.000000000","message":"That doesn\u0027t seem like a user message, but more like a check for the developer that uses this method incorrectly.","commit_id":"9c9fcb8b3f3d4642ac114ccb8b958a2dfef62e96"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e34d231f48738251e2da89e31a20029c73c8580f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                     router_id\u003dNone):"},{"line_number":97,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":98,"context_line":"        if uuid is None:"},{"line_number":99,"context_line":"            raise ValueError(\u0027network_id and router_id are None. \u0027"},{"line_number":100,"context_line":"                             \u0027One must be provided\u0027)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if network_id:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_8a1c1e15","line":99,"in_reply_to":"da86d52c_18dd2871","updated":"2015-02-03 15:47:59.000000000","message":"It comes from namespace_proxy as i didn\u0027t know how we should check/raise it.\n\n\n[1]https://github.com/openstack/neutron/blob/master/neutron/agent/metadata/namespace_proxy.py#L62","commit_id":"9c9fcb8b3f3d4642ac114ccb8b958a2dfef62e96"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"12e15c0a295115e66c9e2e99b3e6c7c1a1e47829","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":98,"context_line":"        if uuid is None:"},{"line_number":99,"context_line":"            raise ValueError(\u0027network_id and router_id are None. \u0027"},{"line_number":100,"context_line":"                             \u0027One must be provided\u0027)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if network_id:"},{"line_number":103,"context_line":"            lookup_param \u003d \u0027--network_id\u003d%s\u0027 % network_id"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_62fcb33f","line":100,"updated":"2015-02-02 12:11:05.000000000","message":"nit: add dot at the end.","commit_id":"9c9fcb8b3f3d4642ac114ccb8b958a2dfef62e96"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e34d231f48738251e2da89e31a20029c73c8580f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":98,"context_line":"        if uuid is None:"},{"line_number":99,"context_line":"            raise ValueError(\u0027network_id and router_id are None. \u0027"},{"line_number":100,"context_line":"                             \u0027One must be provided\u0027)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if network_id:"},{"line_number":103,"context_line":"            lookup_param \u003d \u0027--network_id\u003d%s\u0027 % network_id"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_aa1ba219","line":100,"in_reply_to":"da86d52c_62fcb33f","updated":"2015-02-03 15:47:59.000000000","message":"Done","commit_id":"9c9fcb8b3f3d4642ac114ccb8b958a2dfef62e96"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"224fc711506ac98f8c0802a82bbebd49f32c59bc","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        return callback"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @classmethod"},{"line_number":125,"context_line":"    def spawn_monitored_metadata_proxy(cls, monitor, ns_name, port, conf,"},{"line_number":126,"context_line":"                                       network_id\u003dNone, router_id\u003dNone):"},{"line_number":127,"context_line":"        callback \u003d cls._get_metadata_proxy_callback("}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_785f040f","line":124,"updated":"2015-02-02 12:53:49.000000000","message":"(No action required)\nCedric, did you see my comments about splitting out the spawn/destroy method to a MetadataProxy manager instead of reusing the MetadataDriver which receives events from the l3 agent in other agents via the class methods?\n\nI believe we may go that way into a follow up patch later to make this as clean as possible.","commit_id":"9c9fcb8b3f3d4642ac114ccb8b958a2dfef62e96"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e34d231f48738251e2da89e31a20029c73c8580f","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        return callback"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @classmethod"},{"line_number":125,"context_line":"    def spawn_monitored_metadata_proxy(cls, monitor, ns_name, port, conf,"},{"line_number":126,"context_line":"                                       network_id\u003dNone, router_id\u003dNone):"},{"line_number":127,"context_line":"        callback \u003d cls._get_metadata_proxy_callback("}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_c502890a","line":124,"in_reply_to":"da86d52c_785f040f","updated":"2015-02-03 15:47:59.000000000","message":"A follow-up change will move class methods:\n\n* _get_metdata_proxy_user_group\n* _get_metadata_proxy_callback\n* spawn_monitored_metadata_proxy\n* destroy_monitored_metadata_proxy\n\nto module level or to a specific class.","commit_id":"9c9fcb8b3f3d4642ac114ccb8b958a2dfef62e96"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"55a35ba9731ea458ef9924f819a1c4991c4d5104","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_socket\u0027,"},{"line_number":32,"context_line":"                   default\u003d\u0027$state_path/metadata_proxy\u0027,"},{"line_number":33,"context_line":"                   help\u003d_(\u0027Location of Metadata Proxy UNIX domain \u0027"},{"line_number":34,"context_line":"                          \u0027socket\u0027)),"},{"line_number":35,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_user\u0027,"},{"line_number":36,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":37,"context_line":"                   help\u003d_(\"User (uid or name) running metadata proxy after \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da86d52c_586744e9","line":34,"updated":"2015-02-04 03:23:50.000000000","message":"Should the help message here be changed here? spawn_monitored_metadata_proxy can be called by both l3 agent and dhcp agent now so the default (if empty) should not l3 agent effective user only.","commit_id":"30335491c906586c14d6e50efd91d8d2849f47cb"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"9dad3be908eee191b16c9771a28909604ceb6bfc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_socket\u0027,"},{"line_number":32,"context_line":"                   default\u003d\u0027$state_path/metadata_proxy\u0027,"},{"line_number":33,"context_line":"                   help\u003d_(\u0027Location of Metadata Proxy UNIX domain \u0027"},{"line_number":34,"context_line":"                          \u0027socket\u0027)),"},{"line_number":35,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_user\u0027,"},{"line_number":36,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":37,"context_line":"                   help\u003d_(\"User (uid or name) running metadata proxy after \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da86d52c_e1f03869","line":34,"in_reply_to":"da86d52c_586744e9","updated":"2015-02-04 12:04:38.000000000","message":"Done","commit_id":"30335491c906586c14d6e50efd91d8d2849f47cb"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f0ffa1196acbe4ac4e46f5ab3b2141f7ba3865e4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_socket\u0027,"},{"line_number":32,"context_line":"                   default\u003d\u0027$state_path/metadata_proxy\u0027,"},{"line_number":33,"context_line":"                   help\u003d_(\u0027Location of Metadata Proxy UNIX domain \u0027"},{"line_number":34,"context_line":"                          \u0027socket\u0027)),"},{"line_number":35,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_user\u0027,"},{"line_number":36,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":37,"context_line":"                   help\u003d_(\"User (uid or name) running metadata proxy after \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da86d52c_d1606fa7","line":34,"in_reply_to":"da86d52c_586744e9","updated":"2015-02-04 06:31:09.000000000","message":"True.","commit_id":"30335491c906586c14d6e50efd91d8d2849f47cb"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"55a35ba9731ea458ef9924f819a1c4991c4d5104","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":37,"context_line":"                   help\u003d_(\"User (uid or name) running metadata proxy after \""},{"line_number":38,"context_line":"                          \"its initialization (if empty: L3 agent effective \""},{"line_number":39,"context_line":"                          \"user)\")),"},{"line_number":40,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_group\u0027,"},{"line_number":41,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":42,"context_line":"                   help\u003d_(\"Group (gid or name) running metadata proxy after \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da86d52c_b89da0be","line":39,"updated":"2015-02-04 03:23:50.000000000","message":"same comment as above.","commit_id":"30335491c906586c14d6e50efd91d8d2849f47cb"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f0ffa1196acbe4ac4e46f5ab3b2141f7ba3865e4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":37,"context_line":"                   help\u003d_(\"User (uid or name) running metadata proxy after \""},{"line_number":38,"context_line":"                          \"its initialization (if empty: L3 agent effective \""},{"line_number":39,"context_line":"                          \"user)\")),"},{"line_number":40,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_group\u0027,"},{"line_number":41,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":42,"context_line":"                   help\u003d_(\"Group (gid or name) running metadata proxy after \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da86d52c_115767cb","line":39,"in_reply_to":"da86d52c_b89da0be","updated":"2015-02-04 06:31:09.000000000","message":"+1","commit_id":"30335491c906586c14d6e50efd91d8d2849f47cb"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"9dad3be908eee191b16c9771a28909604ceb6bfc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":37,"context_line":"                   help\u003d_(\"User (uid or name) running metadata proxy after \""},{"line_number":38,"context_line":"                          \"its initialization (if empty: L3 agent effective \""},{"line_number":39,"context_line":"                          \"user)\")),"},{"line_number":40,"context_line":"        cfg.StrOpt(\u0027metadata_proxy_group\u0027,"},{"line_number":41,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":42,"context_line":"                   help\u003d_(\"Group (gid or name) running metadata proxy after \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da86d52c_01f62c63","line":39,"in_reply_to":"da86d52c_b89da0be","updated":"2015-02-04 12:04:38.000000000","message":"Done","commit_id":"30335491c906586c14d6e50efd91d8d2849f47cb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4c1f7a9e89ad7764db17ff7519d6a8000857baea","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                     router_id\u003dNone):"},{"line_number":97,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":98,"context_line":"        if uuid is None:"},{"line_number":99,"context_line":"            raise ValueError(_(\u0027network_id and router_id are None. \u0027"},{"line_number":100,"context_line":"                               \u0027One must be provided.\u0027))"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if network_id:"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_da15d6e5","line":99,"updated":"2015-02-04 14:44:26.000000000","message":"Hm, if that is the same message as in metadata_proxy, isn\u0027t it better to store it in one place and reuse from there? We may eventually change it in one place only and introduce another unneeded translatable message.","commit_id":"b7fcc4569d243bb387a90c881ab79005f350f865"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1d079c6e56a992b886d0e712b8879bb9a9a6e0ce","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                     router_id\u003dNone):"},{"line_number":97,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":98,"context_line":"        if uuid is None:"},{"line_number":99,"context_line":"            raise ValueError(_(\u0027network_id and router_id are None. \u0027"},{"line_number":100,"context_line":"                               \u0027One must be provided.\u0027))"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if network_id:"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_eda718a5","line":99,"in_reply_to":"da86d52c_0d862c66","updated":"2015-02-05 13:13:02.000000000","message":"I don\u0027t know. Maybe you can create a new file like neutron.common.messages?","commit_id":"b7fcc4569d243bb387a90c881ab79005f350f865"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"bb03bf933ff11173841950894ccc4d1c9eb15a63","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                     router_id\u003dNone):"},{"line_number":97,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":98,"context_line":"        if uuid is None:"},{"line_number":99,"context_line":"            raise ValueError(_(\u0027network_id and router_id are None. \u0027"},{"line_number":100,"context_line":"                               \u0027One must be provided.\u0027))"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if network_id:"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_0d862c66","line":99,"in_reply_to":"da86d52c_da15d6e5","updated":"2015-02-05 13:03:02.000000000","message":"Any idea where we should define it? As i don\u0027t really want to import server side code in client side code (and the reverse).","commit_id":"b7fcc4569d243bb387a90c881ab79005f350f865"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"367843f3eb0cafa24e5dee01b639bf7d5ab78b32","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                     router_id\u003dNone):"},{"line_number":97,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":98,"context_line":"        if uuid is None:"},{"line_number":99,"context_line":"            raise ValueError(_(\u0027network_id and router_id are None. \u0027"},{"line_number":100,"context_line":"                               \u0027One must be provided.\u0027))"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if network_id:"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_d4e65d43","line":99,"in_reply_to":"da86d52c_eda718a5","updated":"2015-02-05 14:54:16.000000000","message":"Done","commit_id":"b7fcc4569d243bb387a90c881ab79005f350f865"}],"neutron/tests/unit/test_dhcp_agent.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"5158708c67310e5b9eecb5543544a929d81f2601","unresolved":false,"context_lines":[{"line_number":768,"context_line":"                                          network.namespace,"},{"line_number":769,"context_line":"                                          dhcp.METADATA_PORT,"},{"line_number":770,"context_line":"                                          cfg.CONF,"},{"line_number":771,"context_line":"                                          router_id\u003d\u0027forzanapoli\u0027)"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"    def test_enable_isolated_metadata_proxy_with_metadata_network(self):"},{"line_number":774,"context_line":"        self._test_metadata_network(fake_meta_network)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_4643d56b","line":771,"updated":"2015-02-04 13:37:09.000000000","message":"interesting \u0027router_id\u0027 :) ...good that you preserved it","commit_id":"b7fcc4569d243bb387a90c881ab79005f350f865"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4c1f7a9e89ad7764db17ff7519d6a8000857baea","unresolved":false,"context_lines":[{"line_number":768,"context_line":"                                          network.namespace,"},{"line_number":769,"context_line":"                                          dhcp.METADATA_PORT,"},{"line_number":770,"context_line":"                                          cfg.CONF,"},{"line_number":771,"context_line":"                                          router_id\u003d\u0027forzanapoli\u0027)"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"    def test_enable_isolated_metadata_proxy_with_metadata_network(self):"},{"line_number":774,"context_line":"        self._test_metadata_network(fake_meta_network)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_3ab3520b","line":771,"in_reply_to":"da86d52c_4643d56b","updated":"2015-02-04 14:44:26.000000000","message":"I guess we may one day get some heated fights among football fans around it!.. Scary.","commit_id":"b7fcc4569d243bb387a90c881ab79005f350f865"}]}
