)]}'
{"neutron/plugins/ml2/drivers/helpers.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"40d44ca291094ae7448abe952e394499499504d9","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        network_type \u003d self.get_type()"},{"line_number":121,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":122,"context_line":"            select \u003d (session.query(self.model)."},{"line_number":123,"context_line":"                      filter_by(allocated\u003dFalse, **filters).with_for_update())"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            alloc \u003d select.first()"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_675a7e1f","line":123,"updated":"2015-01-15 17:03:59.000000000","message":"Instead of locking have you considered changing the isolation level of the transaction? In the last months several patches have been trying the remove the \"FOR UPDATE\" lock in the Neutron code. There have been discussions about issues similar to this one, please have a look at https://review.openstack.org/#/c/129288/","commit_id":"fa3b1cbf0ef7363e5e46c0ccd2679a81ba45c8b6"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"11ba61974cef82875744022bd118a765f59b6d4e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                           \"segment\": raw_segment})"},{"line_number":144,"context_line":"                return alloc"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # Not expected code path since the with_for_update was in use,"},{"line_number":147,"context_line":"        # the update expected to raise or succeed"},{"line_number":148,"context_line":"        LOG.error(_LE(\"Allocate %(type)s segment from pool, \""},{"line_number":149,"context_line":"                  \"attempt %(attempt)s failed with segment \""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_ba9da6bd","line":146,"updated":"2015-02-17 16:28:12.000000000","message":"This code path not expected to be reached even on galera.\nSo we can remove the whole count related code path.","commit_id":"fa3b1cbf0ef7363e5e46c0ccd2679a81ba45c8b6"}]}
