)]}'
{"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"9842592848fe1ca2688ac180e6426222067330c9","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            security_group_rules)"},{"line_number":343,"context_line":"        ipv4_iptables_rules \u003d []"},{"line_number":344,"context_line":"        ipv6_iptables_rules \u003d []"},{"line_number":345,"context_line":"        # incorporate fixed egress rules"},{"line_number":346,"context_line":"        if direction \u003d\u003d EGRESS_DIRECTION:"},{"line_number":347,"context_line":"            self._add_fixed_egress_rules(port,"},{"line_number":348,"context_line":"                                         ipv4_iptables_rules,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_73d90f56","line":345,"updated":"2015-01-19 14:05:40.000000000","message":"Perhaps \"include\" would sound better here and below.","commit_id":"952b2eb8f771dcce5cf4750d5788818181c2339b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"93a4743b9989287bbcf9552ad9787320704ca5f8","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            security_group_rules)"},{"line_number":343,"context_line":"        ipv4_iptables_rules \u003d []"},{"line_number":344,"context_line":"        ipv6_iptables_rules \u003d []"},{"line_number":345,"context_line":"        # incorporate fixed egress rules"},{"line_number":346,"context_line":"        if direction \u003d\u003d EGRESS_DIRECTION:"},{"line_number":347,"context_line":"            self._add_fixed_egress_rules(port,"},{"line_number":348,"context_line":"                                         ipv4_iptables_rules,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_81de01d9","line":345,"in_reply_to":"3a961159_278ca1d7","updated":"2015-01-20 14:02:51.000000000","message":"Done","commit_id":"952b2eb8f771dcce5cf4750d5788818181c2339b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"1c572e83af6bc1d519407979725a34341fa2325f","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            security_group_rules)"},{"line_number":343,"context_line":"        ipv4_iptables_rules \u003d []"},{"line_number":344,"context_line":"        ipv6_iptables_rules \u003d []"},{"line_number":345,"context_line":"        # incorporate fixed egress rules"},{"line_number":346,"context_line":"        if direction \u003d\u003d EGRESS_DIRECTION:"},{"line_number":347,"context_line":"            self._add_fixed_egress_rules(port,"},{"line_number":348,"context_line":"                                         ipv4_iptables_rules,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_278ca1d7","line":345,"in_reply_to":"3a961159_73d90f56","updated":"2015-01-19 16:04:10.000000000","message":"As a non native speaker both sound good to me. If you\u0027re sure ping me here or in IRC and I will change it.","commit_id":"952b2eb8f771dcce5cf4750d5788818181c2339b"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b67f7bc2b23aa30ed03a2766eb9b1f2a82e6383b","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                                         ipv4_iptables_rules,"},{"line_number":349,"context_line":"                                         ipv6_iptables_rules)"},{"line_number":350,"context_line":"        # incorporate fixed ingress rules"},{"line_number":351,"context_line":"        if direction \u003d\u003d INGRESS_DIRECTION:"},{"line_number":352,"context_line":"            ipv6_iptables_rules +\u003d self._accept_inbound_icmpv6()"},{"line_number":353,"context_line":"        # incorporate IPv4 and IPv6 iptable rules from security group"},{"line_number":354,"context_line":"        ipv4_iptables_rules +\u003d self._convert_sgr_to_iptables_rules("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_0df5eacb","line":351,"updated":"2015-01-20 12:02:43.000000000","message":"nit: elif","commit_id":"952b2eb8f771dcce5cf4750d5788818181c2339b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"93a4743b9989287bbcf9552ad9787320704ca5f8","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                                         ipv4_iptables_rules,"},{"line_number":349,"context_line":"                                         ipv6_iptables_rules)"},{"line_number":350,"context_line":"        # incorporate fixed ingress rules"},{"line_number":351,"context_line":"        if direction \u003d\u003d INGRESS_DIRECTION:"},{"line_number":352,"context_line":"            ipv6_iptables_rules +\u003d self._accept_inbound_icmpv6()"},{"line_number":353,"context_line":"        # incorporate IPv4 and IPv6 iptable rules from security group"},{"line_number":354,"context_line":"        ipv4_iptables_rules +\u003d self._convert_sgr_to_iptables_rules("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_a1ea1d75","line":351,"in_reply_to":"3a961159_0df5eacb","updated":"2015-01-20 14:02:51.000000000","message":"Done","commit_id":"952b2eb8f771dcce5cf4750d5788818181c2339b"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"9842592848fe1ca2688ac180e6426222067330c9","unresolved":false,"context_lines":[{"line_number":355,"context_line":"            ipv4_sg_rules)"},{"line_number":356,"context_line":"        ipv6_iptables_rules +\u003d self._convert_sgr_to_iptables_rules("},{"line_number":357,"context_line":"            ipv6_sg_rules)"},{"line_number":358,"context_line":"        # finally add the rules to the port chain on a given direction"},{"line_number":359,"context_line":"        self._add_rules_to_chain_v4v6(self._port_chain_name(port, direction),"},{"line_number":360,"context_line":"                                      ipv4_iptables_rules,"},{"line_number":361,"context_line":"                                      ipv6_iptables_rules)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_f3717f46","line":358,"updated":"2015-01-19 14:05:40.000000000","message":"Not sure which preposition would be the correct one, but \u0027on\u0027 sounds wrong to me. I\u0027d use either \u0027of\u0027 (meaning port chain belonging to a given direction) or simply \u0027for\u0027.","commit_id":"952b2eb8f771dcce5cf4750d5788818181c2339b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"93a4743b9989287bbcf9552ad9787320704ca5f8","unresolved":false,"context_lines":[{"line_number":355,"context_line":"            ipv4_sg_rules)"},{"line_number":356,"context_line":"        ipv6_iptables_rules +\u003d self._convert_sgr_to_iptables_rules("},{"line_number":357,"context_line":"            ipv6_sg_rules)"},{"line_number":358,"context_line":"        # finally add the rules to the port chain on a given direction"},{"line_number":359,"context_line":"        self._add_rules_to_chain_v4v6(self._port_chain_name(port, direction),"},{"line_number":360,"context_line":"                                      ipv4_iptables_rules,"},{"line_number":361,"context_line":"                                      ipv6_iptables_rules)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_1cab56d8","line":358,"in_reply_to":"3a961159_6796a9f1","updated":"2015-01-20 14:02:51.000000000","message":"Done","commit_id":"952b2eb8f771dcce5cf4750d5788818181c2339b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"1c572e83af6bc1d519407979725a34341fa2325f","unresolved":false,"context_lines":[{"line_number":355,"context_line":"            ipv4_sg_rules)"},{"line_number":356,"context_line":"        ipv6_iptables_rules +\u003d self._convert_sgr_to_iptables_rules("},{"line_number":357,"context_line":"            ipv6_sg_rules)"},{"line_number":358,"context_line":"        # finally add the rules to the port chain on a given direction"},{"line_number":359,"context_line":"        self._add_rules_to_chain_v4v6(self._port_chain_name(port, direction),"},{"line_number":360,"context_line":"                                      ipv4_iptables_rules,"},{"line_number":361,"context_line":"                                      ipv6_iptables_rules)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_6796a9f1","line":358,"in_reply_to":"3a961159_f3717f46","updated":"2015-01-19 16:04:10.000000000","message":"Here I can\u0027t do anything else but agree.\n\u0027for a given direction\u0027 sounds good.","commit_id":"952b2eb8f771dcce5cf4750d5788818181c2339b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ac1ab9d14481d63b07814582652cb5b94dcc7a24","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        return remote_sg_ids"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _add_rule_by_security_group(self, port, direction):"},{"line_number":331,"context_line":"        chain_name \u003d self._port_chain_name(port, direction)"},{"line_number":332,"context_line":"        # select rules for current direction"},{"line_number":333,"context_line":"        security_group_rules \u003d self._select_sgr_by_direction(port, direction)"},{"line_number":334,"context_line":"        security_group_rules +\u003d self._select_sg_rules_for_port(port, direction)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_3aa03df4","side":"PARENT","line":331,"updated":"2015-01-20 22:44:11.000000000","message":"I don\u0027t think removing this and using the call directly below helps readability, perhaps just moving this down to right before the _add_rules_to_chain_v4v6() call would be better.  That would leave all four occurences similar by having them all load the name into a local variable first.  Just my opinion of course...","commit_id":"8ba3079445bea3033b42a5d78f9db6d3c3bd328b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ca69cb8079082f030641e6690b49ec27a16a54e","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        return remote_sg_ids"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _add_rule_by_security_group(self, port, direction):"},{"line_number":331,"context_line":"        chain_name \u003d self._port_chain_name(port, direction)"},{"line_number":332,"context_line":"        # select rules for current direction"},{"line_number":333,"context_line":"        security_group_rules \u003d self._select_sgr_by_direction(port, direction)"},{"line_number":334,"context_line":"        security_group_rules +\u003d self._select_sg_rules_for_port(port, direction)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_6401d0ae","side":"PARENT","line":331,"in_reply_to":"1a930d6b_34eabf0f","updated":"2015-01-23 20:20:28.000000000","message":"I guess I could go either way, it was just that the other three occurrences of this call all save to a local variable (two actually need to, _remove_chain() doesn\u0027t, but does).  That\u0027s what my eye noticed.","commit_id":"8ba3079445bea3033b42a5d78f9db6d3c3bd328b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"140c2f12d3cc0e82a403d14fd2ab0a5013186fc5","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        return remote_sg_ids"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _add_rule_by_security_group(self, port, direction):"},{"line_number":331,"context_line":"        chain_name \u003d self._port_chain_name(port, direction)"},{"line_number":332,"context_line":"        # select rules for current direction"},{"line_number":333,"context_line":"        security_group_rules \u003d self._select_sgr_by_direction(port, direction)"},{"line_number":334,"context_line":"        security_group_rules +\u003d self._select_sg_rules_for_port(port, direction)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_34eabf0f","side":"PARENT","line":331,"in_reply_to":"1a930d6b_3aa03df4","updated":"2015-01-22 22:15:10.000000000","message":"I disagree, with a super clear function name like that, it doesn\u0027t hurt. \n\nI had it as a separate variable over L358 on a different patch, but then I stopped seeing the value of the extra line.\n\nBtw, if you have a strong opinion here, we can move it.\n\nWhat do others think?","commit_id":"8ba3079445bea3033b42a5d78f9db6d3c3bd328b"}]}