)]}'
{"neutron/agent/securitygroups_rpc.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"82ed1a3010e2820df5ec67bf30f33b4cdcc5d3f4","unresolved":false,"context_lines":[{"line_number":413,"context_line":"                                        fanout\u003dTrue)"},{"line_number":414,"context_line":"            cctxt.cast(context, \u0027security_groups_provider_updated\u0027,"},{"line_number":415,"context_line":"                       devices_to_update\u003ddevices_to_update)"},{"line_number":416,"context_line":"        except messaging.UnsupportedVersion:"},{"line_number":417,"context_line":"            cctxt \u003d self.client.prepare(version\u003dSG_RPC_VERSION,"},{"line_number":418,"context_line":"                                        topic\u003dself._get_security_group_topic(),"},{"line_number":419,"context_line":"                                        fanout\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_c8ccab38","line":416,"updated":"2015-02-02 06:37:58.000000000","message":"do you get this exception for a cast?","commit_id":"8bd83c55f1cbe0049a519a6f130731644abe20e7"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a29f2ef082ca8e29dd7e9ed6ae32c5f2d94ca2bd","unresolved":false,"context_lines":[{"line_number":413,"context_line":"                                        fanout\u003dTrue)"},{"line_number":414,"context_line":"            cctxt.cast(context, \u0027security_groups_provider_updated\u0027,"},{"line_number":415,"context_line":"                       devices_to_update\u003ddevices_to_update)"},{"line_number":416,"context_line":"        except messaging.UnsupportedVersion:"},{"line_number":417,"context_line":"            cctxt \u003d self.client.prepare(version\u003dSG_RPC_VERSION,"},{"line_number":418,"context_line":"                                        topic\u003dself._get_security_group_topic(),"},{"line_number":419,"context_line":"                                        fanout\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_3a966995","line":416,"in_reply_to":"da86d52c_c8ccab38","updated":"2015-02-02 09:22:09.000000000","message":"in oslo.messaging I see a version check also for the cast method.","commit_id":"8bd83c55f1cbe0049a519a6f130731644abe20e7"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"7e37d392a06ad5980c85489f447b82289bebec0a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":"# history"},{"line_number":32,"context_line":"#   1.1 Support Security Group RPC"},{"line_number":33,"context_line":"SG_RPC_VERSION \u003d \"1.1\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"security_group_opts \u003d ["},{"line_number":36,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_4fa57402","side":"PARENT","line":33,"updated":"2015-02-05 17:37:03.000000000","message":"this is referenced from other modules too\n\nubuntu@compute2:/opt/stack/neutron$ grep -rl SG_RPC_VERSION neutron\nneutron/agent/securitygroups_rpc.py\nneutron/plugins/nec/agent/nec_neutron_agent.py\nneutron/plugins/oneconvergence/agent/nvsd_neutron_agent.py","commit_id":"06233db2e790891c20c2b9a72a2b38146d928b60"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"50ed65b041f544e8193df5717495075973a6b239","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":"# history"},{"line_number":32,"context_line":"#   1.1 Support Security Group RPC"},{"line_number":33,"context_line":"SG_RPC_VERSION \u003d \"1.1\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"security_group_opts \u003d ["},{"line_number":36,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_873a5ecb","side":"PARENT","line":33,"in_reply_to":"da86d52c_4fa57402","updated":"2015-02-10 10:18:35.000000000","message":"oops I missed that, I will revert this change, I think it\u0027s the best option.","commit_id":"06233db2e790891c20c2b9a72a2b38146d928b60"},{"author":{"_account_id":8792,"name":"Manish Godara","email":"manishg@yahoo-inc.com","username":"manishg"},"change_message_id":"b4facd9992dd8b4744fe3d9746fd140c42b3a953","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                                         devices_to_update\u003dNone):"},{"line_number":409,"context_line":"        \"\"\"Notify provider updated security groups.\"\"\""},{"line_number":410,"context_line":"        try:"},{"line_number":411,"context_line":"            cctxt \u003d self.client.prepare(version\u003d\u00271.3\u0027,"},{"line_number":412,"context_line":"                                        topic\u003dself._get_security_group_topic(),"},{"line_number":413,"context_line":"                                        fanout\u003dTrue)"},{"line_number":414,"context_line":"            cctxt.cast(context, \u0027security_groups_provider_updated\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_2953fb6b","line":411,"updated":"2015-02-04 23:00:38.000000000","message":"Might be better to name \u00271.3\u0027 so it\u0027s clear where all it applies.  I\u0027m okay with \u00271.3\u0027 as well .","commit_id":"ff4b861f7e320e7671b85ec577c5d96852d8ed3e"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"7daf68b5d80bbd5a622dec1bf02e949d9ed3d8a7","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                                         devices_to_update\u003dNone):"},{"line_number":409,"context_line":"        \"\"\"Notify provider updated security groups.\"\"\""},{"line_number":410,"context_line":"        try:"},{"line_number":411,"context_line":"            cctxt \u003d self.client.prepare(version\u003d\u00271.3\u0027,"},{"line_number":412,"context_line":"                                        topic\u003dself._get_security_group_topic(),"},{"line_number":413,"context_line":"                                        fanout\u003dTrue)"},{"line_number":414,"context_line":"            cctxt.cast(context, \u0027security_groups_provider_updated\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_c015c949","line":411,"in_reply_to":"da86d52c_2953fb6b","updated":"2015-02-05 06:37:19.000000000","message":"Since it\u0027s only one method using it, I\u0027d leave as it is","commit_id":"ff4b861f7e320e7671b85ec577c5d96852d8ed3e"},{"author":{"_account_id":8792,"name":"Manish Godara","email":"manishg@yahoo-inc.com","username":"manishg"},"change_message_id":"b4facd9992dd8b4744fe3d9746fd140c42b3a953","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            cctxt \u003d self.client.prepare(version\u003d\u00271.3\u0027,"},{"line_number":412,"context_line":"                                        topic\u003dself._get_security_group_topic(),"},{"line_number":413,"context_line":"                                        fanout\u003dTrue)"},{"line_number":414,"context_line":"            cctxt.cast(context, \u0027security_groups_provider_updated\u0027,"},{"line_number":415,"context_line":"                       devices_to_update\u003ddevices_to_update)"},{"line_number":416,"context_line":"        except messaging.UnsupportedVersion:"},{"line_number":417,"context_line":"            cctxt \u003d self.client.prepare(version\u003dSG_RPC_BASE_VERSION,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_897b07f4","line":414,"updated":"2015-02-04 23:00:38.000000000","message":"would it make sense to make sure devices_to_update is not None in this case?  For v1.3 we should be getting valid list I think.","commit_id":"ff4b861f7e320e7671b85ec577c5d96852d8ed3e"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"7daf68b5d80bbd5a622dec1bf02e949d9ed3d8a7","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            cctxt \u003d self.client.prepare(version\u003d\u00271.3\u0027,"},{"line_number":412,"context_line":"                                        topic\u003dself._get_security_group_topic(),"},{"line_number":413,"context_line":"                                        fanout\u003dTrue)"},{"line_number":414,"context_line":"            cctxt.cast(context, \u0027security_groups_provider_updated\u0027,"},{"line_number":415,"context_line":"                       devices_to_update\u003ddevices_to_update)"},{"line_number":416,"context_line":"        except messaging.UnsupportedVersion:"},{"line_number":417,"context_line":"            cctxt \u003d self.client.prepare(version\u003dSG_RPC_BASE_VERSION,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_5b01cc03","line":414,"in_reply_to":"da86d52c_897b07f4","updated":"2015-02-05 06:37:19.000000000","message":"The server implementation can handle devices_to_update \u003d None so a check in this case is probably redundant.","commit_id":"ff4b861f7e320e7671b85ec577c5d96852d8ed3e"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"a025724831cdfbc6ebde55bcec0e4e125589662f","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                                        fanout\u003dTrue)"},{"line_number":415,"context_line":"            cctxt.cast(context, \u0027security_groups_provider_updated\u0027,"},{"line_number":416,"context_line":"                       devices_to_update\u003ddevices_to_update)"},{"line_number":417,"context_line":"        except oslo_messaging.UnsupportedVersion:"},{"line_number":418,"context_line":"            cctxt \u003d self.client.prepare(version\u003dSG_RPC_VERSION,"},{"line_number":419,"context_line":"                                        topic\u003dself._get_security_group_topic(),"},{"line_number":420,"context_line":"                                        fanout\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_a9071e80","line":417,"updated":"2015-02-10 19:57:20.000000000","message":"You will never get this exception since cast() is being used.  The only thing you can really do here is just assume the other side has been properly upgraded and supports \u00271.3\u0027.","commit_id":"63e9ad3a1b756b2f176ce7c231a920d28b8757c0"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"29627a37f159ad054fe779b7ce01a7afd3647a55","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                                        fanout\u003dTrue)"},{"line_number":415,"context_line":"            cctxt.cast(context, \u0027security_groups_provider_updated\u0027,"},{"line_number":416,"context_line":"                       devices_to_update\u003ddevices_to_update)"},{"line_number":417,"context_line":"        except oslo_messaging.UnsupportedVersion:"},{"line_number":418,"context_line":"            cctxt \u003d self.client.prepare(version\u003dSG_RPC_VERSION,"},{"line_number":419,"context_line":"                                        topic\u003dself._get_security_group_topic(),"},{"line_number":420,"context_line":"                                        fanout\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_b33f75b3","line":417,"in_reply_to":"da86d52c_a9071e80","updated":"2015-02-11 11:05:02.000000000","message":"Thanks Russell! I had the same comment by another reviewer in a previous review and I looked at the code in oslo.messaging trying to understand the workflow better. I\u0027d appreciate your help here. From my understanding, _dispatch in (oslo/messaging/rpc/dispatcher.py ) seems to throw UnsupportedVersion regardless of the rpc method used. There\u0027s no check to see if it\u0027s a cast or a call. What am I missing? Thanks!!","commit_id":"63e9ad3a1b756b2f176ce7c231a920d28b8757c0"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"bf0c1438ca0fb00917d1cc4f01992f8e55f0d060","unresolved":false,"context_lines":[{"line_number":406,"context_line":"    def security_groups_provider_updated(self, context,"},{"line_number":407,"context_line":"                                         devices_to_update\u003dNone):"},{"line_number":408,"context_line":"        \"\"\"Notify provider updated security groups.\"\"\""},{"line_number":409,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.3\u0027,"},{"line_number":410,"context_line":"                                    topic\u003dself._get_security_group_topic(),"},{"line_number":411,"context_line":"                                    fanout\u003dTrue)"},{"line_number":412,"context_line":"        cctxt.cast(context, \u0027security_groups_provider_updated\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_b8432512","line":409,"updated":"2015-03-17 19:22:05.000000000","message":"so if the server has been upgraded, but the agents have not, will this work?","commit_id":"d8616a072fd5a68310eefdda6bcc86dc848a1dd1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a8656af3fb302bcc0d9625b4e89babb3a7625361","unresolved":false,"context_lines":[{"line_number":406,"context_line":"    def security_groups_provider_updated(self, context,"},{"line_number":407,"context_line":"                                         devices_to_update\u003dNone):"},{"line_number":408,"context_line":"        \"\"\"Notify provider updated security groups.\"\"\""},{"line_number":409,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.3\u0027,"},{"line_number":410,"context_line":"                                    topic\u003dself._get_security_group_topic(),"},{"line_number":411,"context_line":"                                    fanout\u003dTrue)"},{"line_number":412,"context_line":"        cctxt.cast(context, \u0027security_groups_provider_updated\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_19d5fce4","line":409,"in_reply_to":"9a80dd14_b8432512","updated":"2015-03-18 09:45:51.000000000","message":"yes, it\u0027s backward compatible.","commit_id":"d8616a072fd5a68310eefdda6bcc86dc848a1dd1"}],"neutron/db/securitygroups_rpc_base.py":[{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"ee7ca7fbb2c92d4c1f931d29cfedf21fa92a6c01","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        occurs and the plugin agent fetches the update provider"},{"line_number":148,"context_line":"        rule in the other RPC call (security_group_rules_for_devices)."},{"line_number":149,"context_line":"        \"\"\""},{"line_number":150,"context_line":"        security_groups_provider_updated_networks \u003d set()"},{"line_number":151,"context_line":"        sec_groups \u003d set()"},{"line_number":152,"context_line":"        for port in ports:"},{"line_number":153,"context_line":"            if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_15a95c24","line":150,"updated":"2015-03-17 19:17:06.000000000","message":"at 41 chars this variable is very long and leads to  statements spanning lines below. I think the security_groups_ is redundant (it\u0027s in the module name), at least sg_provider_updated_networks would be better.","commit_id":"d8616a072fd5a68310eefdda6bcc86dc848a1dd1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a8656af3fb302bcc0d9625b4e89babb3a7625361","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        occurs and the plugin agent fetches the update provider"},{"line_number":148,"context_line":"        rule in the other RPC call (security_group_rules_for_devices)."},{"line_number":149,"context_line":"        \"\"\""},{"line_number":150,"context_line":"        security_groups_provider_updated_networks \u003d set()"},{"line_number":151,"context_line":"        sec_groups \u003d set()"},{"line_number":152,"context_line":"        for port in ports:"},{"line_number":153,"context_line":"            if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_746d1fcc","line":150,"in_reply_to":"9a80dd14_15a95c24","updated":"2015-03-18 09:45:51.000000000","message":"will do","commit_id":"d8616a072fd5a68310eefdda6bcc86dc848a1dd1"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3d4d93dcdcc0935a0c26822dc8d826f499d594ac","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                sec_groups |\u003d set(port.get(ext_sg.SECURITYGROUPS))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        if sg_provider_updated_networks:"},{"line_number":167,"context_line":"            ports_query \u003d context.session.query(models_v2.Port).filter("},{"line_number":168,"context_line":"                models_v2.Port.network_id.in_("},{"line_number":169,"context_line":"                    sg_provider_updated_networks))"},{"line_number":170,"context_line":"            ports_to_update \u003d [p[\u0027id\u0027] for p in ports_query]"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ab451fb_b1c1fb30","line":167,"updated":"2015-04-17 20:23:06.000000000","message":"Can we restrict the query to just the id here?","commit_id":"b49463dfaa0fad36f9945ab1ae2259f832f4dea4"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"5e2086ef9695df270103f99edeafbf6c0805a9d6","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                sec_groups |\u003d set(port.get(ext_sg.SECURITYGROUPS))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        if sg_provider_updated_networks:"},{"line_number":167,"context_line":"            ports_query \u003d context.session.query(models_v2.Port).filter("},{"line_number":168,"context_line":"                models_v2.Port.network_id.in_("},{"line_number":169,"context_line":"                    sg_provider_updated_networks))"},{"line_number":170,"context_line":"            ports_to_update \u003d [p[\u0027id\u0027] for p in ports_query]"}],"source_content_type":"text/x-python","patch_set":13,"id":"7ad32947_62905b96","line":167,"in_reply_to":"3ab451fb_b1c1fb30","updated":"2015-04-27 20:46:10.000000000","message":"Good point, thanks!","commit_id":"b49463dfaa0fad36f9945ab1ae2259f832f4dea4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3d4d93dcdcc0935a0c26822dc8d826f499d594ac","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        if sg_provider_updated_networks:"},{"line_number":167,"context_line":"            ports_query \u003d context.session.query(models_v2.Port).filter("},{"line_number":168,"context_line":"                models_v2.Port.network_id.in_("},{"line_number":169,"context_line":"                    sg_provider_updated_networks))"},{"line_number":170,"context_line":"            ports_to_update \u003d [p[\u0027id\u0027] for p in ports_query]"},{"line_number":171,"context_line":"            self.notifier.security_groups_provider_updated("}],"source_content_type":"text/x-python","patch_set":13,"id":"3ab451fb_5199976d","line":168,"updated":"2015-04-17 20:23:06.000000000","message":"Could this list of ports queried be long?  Could we avoid this new db query?  It might take a little bit of extra work but might be worth some discussion.\n\nHere\u0027s what I\u0027m thinking.  In this proposal, we query here to get the devices\u0027 ids and send that list to the agent.  The agent sends the device ids back in a call to security_group_info_for_devices to get the rules for the ports.\n\nIt may be a bit more work but we could just send down the network ids that we have here and let the agent send that back in a modified call to security_group_info_for_devices called security_group_info_for_networks or something.","commit_id":"b49463dfaa0fad36f9945ab1ae2259f832f4dea4"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"5e2086ef9695df270103f99edeafbf6c0805a9d6","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        if sg_provider_updated_networks:"},{"line_number":167,"context_line":"            ports_query \u003d context.session.query(models_v2.Port).filter("},{"line_number":168,"context_line":"                models_v2.Port.network_id.in_("},{"line_number":169,"context_line":"                    sg_provider_updated_networks))"},{"line_number":170,"context_line":"            ports_to_update \u003d [p[\u0027id\u0027] for p in ports_query]"},{"line_number":171,"context_line":"            self.notifier.security_groups_provider_updated("}],"source_content_type":"text/x-python","patch_set":13,"id":"7ad32947_2274a39a","line":168,"in_reply_to":"3ab451fb_5199976d","updated":"2015-04-27 20:46:10.000000000","message":"The list of ports can be long, you are right. Thanks for your suggestion, I get your point. Anyway we\u0027d spare the query to get the devices here but then later in security_group_info_for_networks we\u0027d have to execute the query anyway to get the ports associated with the network. Not sure if it\u0027s worth it. Am I missing something?","commit_id":"b49463dfaa0fad36f9945ab1ae2259f832f4dea4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1dd54cd2e23a4ea325468530af08c30e1c4cfab7","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        if sg_provider_updated_networks:"},{"line_number":167,"context_line":"            ports_query \u003d context.session.query(models_v2.Port).filter("},{"line_number":168,"context_line":"                models_v2.Port.network_id.in_("},{"line_number":169,"context_line":"                    sg_provider_updated_networks))"},{"line_number":170,"context_line":"            ports_to_update \u003d [p[\u0027id\u0027] for p in ports_query]"},{"line_number":171,"context_line":"            self.notifier.security_groups_provider_updated("}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_9f2a8be6","line":168,"in_reply_to":"7ad32947_2274a39a","updated":"2015-05-26 18:46:03.000000000","message":"The agent would send back the network ids and we\u0027d use that in place of the port ids in the query to get the security group information.  That is the idea.  We wouldn\u0027t have to run this query to get the port ids, we could change the query to take network ids instead of ports (L255).  So, we still save this query.","commit_id":"b49463dfaa0fad36f9945ab1ae2259f832f4dea4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1dd54cd2e23a4ea325468530af08c30e1c4cfab7","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                                      sg_db.SecurityGroupRule)"},{"line_number":253,"context_line":"        query \u003d query.join(sg_db.SecurityGroupRule,"},{"line_number":254,"context_line":"                           sgr_sgid \u003d\u003d sg_binding_sgid)"},{"line_number":255,"context_line":"        query \u003d query.filter(sg_binding_port.in_(ports.keys()))"},{"line_number":256,"context_line":"        return query.all()"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def _select_ips_for_remote_group(self, context, remote_group_ids):"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_bf2b0794","line":255,"updated":"2015-05-26 18:46:03.000000000","message":"We\u0027d have to get the networks list down to here and change this filter to join the models_v2.Port table on port_id and filter on Port.network_id directly in this query.","commit_id":"b49463dfaa0fad36f9945ab1ae2259f832f4dea4"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"1ff8293a970bebca6f838a9b41e3e6c92b565c70","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                                      sg_db.SecurityGroupRule)"},{"line_number":253,"context_line":"        query \u003d query.join(sg_db.SecurityGroupRule,"},{"line_number":254,"context_line":"                           sgr_sgid \u003d\u003d sg_binding_sgid)"},{"line_number":255,"context_line":"        query \u003d query.filter(sg_binding_port.in_(ports.keys()))"},{"line_number":256,"context_line":"        return query.all()"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def _select_ips_for_remote_group(self, context, remote_group_ids):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3afb71cf_d261eaa9","line":255,"in_reply_to":"3afb71cf_459a0116","updated":"2015-06-08 10:46:48.000000000","message":"It seems reasonable to me, thanks a lot!","commit_id":"b49463dfaa0fad36f9945ab1ae2259f832f4dea4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"65ca63af5ef2d39f2ae8f0017391bfcd836be59d","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                                      sg_db.SecurityGroupRule)"},{"line_number":253,"context_line":"        query \u003d query.join(sg_db.SecurityGroupRule,"},{"line_number":254,"context_line":"                           sgr_sgid \u003d\u003d sg_binding_sgid)"},{"line_number":255,"context_line":"        query \u003d query.filter(sg_binding_port.in_(ports.keys()))"},{"line_number":256,"context_line":"        return query.all()"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def _select_ips_for_remote_group(self, context, remote_group_ids):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3afb71cf_459a0116","line":255,"in_reply_to":"7a016987_b69f5b5e","updated":"2015-06-05 18:24:40.000000000","message":"I hope I\u0027m not beating a dead horse.  The new security_group_info_for_networks will have to do a similar query but the query on L168 is still saved and the RPC message is smaller (potentially much smaller).\n\nThe call to _get_devices_info will need a network list analog which will in turn need an analog for get_ports_from_devices.\n\nThe whole thing gets more efficient.  However, there is a cost that seems to be snowballing a bit.  But, I still think there is opportunity.  I think we could merge this patch with the existing scope and maybe put up the work you started down these lines as a follow-on.  We can discuss the merits and return on investment of this approach in that new patch.","commit_id":"b49463dfaa0fad36f9945ab1ae2259f832f4dea4"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"297b03d0a5de18930943601583ea71259ed738d7","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                                      sg_db.SecurityGroupRule)"},{"line_number":253,"context_line":"        query \u003d query.join(sg_db.SecurityGroupRule,"},{"line_number":254,"context_line":"                           sgr_sgid \u003d\u003d sg_binding_sgid)"},{"line_number":255,"context_line":"        query \u003d query.filter(sg_binding_port.in_(ports.keys()))"},{"line_number":256,"context_line":"        return query.all()"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def _select_ips_for_remote_group(self, context, remote_group_ids):"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_b69f5b5e","line":255,"in_reply_to":"7a016987_bf2b0794","updated":"2015-05-28 14:54:06.000000000","message":"Carl nice idea, I was implementing it when I realized that I need to query the list of port belonging to a network anyway because I need to get the devices info, as it\u0027s done here  [1] . My half baked patch is here [2] but at this point I don\u0027t think it\u0027s worth it.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/api/rpc/handlers/securitygroups_rpc.py#L113\n[2] https://github.com/rossella/neutron/commit/35eb0460b5ee6bd8cb84e9beef612db08f1a3395","commit_id":"b49463dfaa0fad36f9945ab1ae2259f832f4dea4"}],"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":10393,"name":"nlahouti","email":"nader.lahouti@gmail.com","username":"nlahouti"},"change_message_id":"50d4c91d26d06ca05db402b5a884c4c3c4858e0b","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":121,"context_line":"    #   1.2 Support DVR (Distributed Virtual Router) RPC"},{"line_number":122,"context_line":"    #   1.3 Added param network_id to security_groups_provider_updated"},{"line_number":123,"context_line":"    target \u003d messaging.Target(version\u003d\u00271.2\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def __init__(self, integ_br, tun_br, local_ip,"},{"line_number":126,"context_line":"                 bridge_mappings, root_helper,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_cb7d33e9","line":123,"updated":"2015-01-29 20:09:40.000000000","message":"Shouldn\u0027t version be changed to 1.3?","commit_id":"52ca53eb9793975559f42467d9d7af20105848d5"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"caf78e5eb386012ee2ba4186230811c1770292f2","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":121,"context_line":"    #   1.2 Support DVR (Distributed Virtual Router) RPC"},{"line_number":122,"context_line":"    #   1.3 Added param network_id to security_groups_provider_updated"},{"line_number":123,"context_line":"    target \u003d messaging.Target(version\u003d\u00271.2\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def __init__(self, integ_br, tun_br, local_ip,"},{"line_number":126,"context_line":"                 bridge_mappings, root_helper,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_11a3e001","line":123,"in_reply_to":"fa81d914_cb7d33e9","updated":"2015-01-30 11:34:49.000000000","message":"yes, thanks!","commit_id":"52ca53eb9793975559f42467d9d7af20105848d5"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"342d32e5bf28fd11aaa2f9bad896655f6fba9521","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    #   1.0 Initial version"},{"line_number":120,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":121,"context_line":"    #   1.2 Support DVR (Distributed Virtual Router) RPC"},{"line_number":122,"context_line":"    #   1.3 Added param network_id to security_groups_provider_updated"},{"line_number":123,"context_line":"    target \u003d messaging.Target(version\u003d\u00271.3\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def __init__(self, integ_br, tun_br, local_ip,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_8c95878a","line":122,"updated":"2015-02-02 13:43:43.000000000","message":"network_id? Should this be devices_to_update?\n\nI don\u0027t know what the RPC conventions are, but is it really necessary to bump the version here.  Would old agents just ignore the \u0027devices_to_update\u0027 kwarg anyway?","commit_id":"8bd83c55f1cbe0049a519a6f130731644abe20e7"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"60be273ba0fcb8ba3ce446a13f7041100125c04f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    #   1.0 Initial version"},{"line_number":120,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":121,"context_line":"    #   1.2 Support DVR (Distributed Virtual Router) RPC"},{"line_number":122,"context_line":"    #   1.3 Added param network_id to security_groups_provider_updated"},{"line_number":123,"context_line":"    target \u003d messaging.Target(version\u003d\u00271.3\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def __init__(self, integ_br, tun_br, local_ip,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_b31f7507","line":122,"in_reply_to":"da86d52c_8c95878a","updated":"2015-02-04 13:02:57.000000000","message":"Thanks I will change that. Regarding the version I think it should be updated, see [1] , even if it\u0027s a backward compatible change the minor version should be increased. That\u0027s how it was done for similar changes in the past\n\n[1] http://docs.openstack.org/developer/oslo.messaging/target.html#target-versions","commit_id":"8bd83c55f1cbe0049a519a6f130731644abe20e7"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"51531d6c986c37eb0f98c0f1b75db90d524c017d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    #   1.0 Initial version"},{"line_number":120,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":121,"context_line":"    #   1.2 Support DVR (Distributed Virtual Router) RPC"},{"line_number":122,"context_line":"    #   1.3 Added param network_id to security_groups_provider_updated"},{"line_number":123,"context_line":"    target \u003d messaging.Target(version\u003d\u00271.3\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def __init__(self, integ_br, tun_br, local_ip,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_e9501ad6","line":122,"in_reply_to":"da86d52c_b31f7507","updated":"2015-02-04 13:47:46.000000000","message":"Ok - thanks, still trying to understand this... So that link says:\n\n\"A backwards compatible change could be something like adding a new method, adding an argument to an existing method (but not requiring it), or changing the type for an existing argument (but still handling the old type as well).\n\nIt is not clear to me that you have made such a change in this patchset.","commit_id":"8bd83c55f1cbe0049a519a6f130731644abe20e7"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"28e34f12eb5294554b90ecdb473fd67d5951b0a6","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    #   1.0 Initial version"},{"line_number":120,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":121,"context_line":"    #   1.2 Support DVR (Distributed Virtual Router) RPC"},{"line_number":122,"context_line":"    #   1.3 Added param network_id to security_groups_provider_updated"},{"line_number":123,"context_line":"    target \u003d messaging.Target(version\u003d\u00271.3\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def __init__(self, integ_br, tun_br, local_ip,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_2944b748","line":122,"in_reply_to":"da86d52c_c03ea9d9","updated":"2015-02-05 17:30:57.000000000","message":"Yeah thanks - was looking at the kwargs param.","commit_id":"8bd83c55f1cbe0049a519a6f130731644abe20e7"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"100d448d9a6401d12c10331a455b53bfc0f9ac93","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    #   1.0 Initial version"},{"line_number":120,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":121,"context_line":"    #   1.2 Support DVR (Distributed Virtual Router) RPC"},{"line_number":122,"context_line":"    #   1.3 Added param network_id to security_groups_provider_updated"},{"line_number":123,"context_line":"    target \u003d messaging.Target(version\u003d\u00271.3\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def __init__(self, integ_br, tun_br, local_ip,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_c03ea9d9","line":122,"in_reply_to":"da86d52c_e9501ad6","updated":"2015-02-05 06:35:35.000000000","message":"RPC is complicated, especially in Neutron! I added an argument to an existing method, I added devices_to_update to security_groups_provider_updated , hope it\u0027s clear now.","commit_id":"8bd83c55f1cbe0049a519a6f130731644abe20e7"}]}
