)]}'
{"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3d9c9e5253c2cdc709b944e6758f13ec5396623a","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    @classmethod"},{"line_number":329,"context_line":"    def check_version(cls):"},{"line_number":330,"context_line":"        return None"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    @classmethod"},{"line_number":333,"context_line":"    def existing_dhcp_networks(cls, conf, root_helper):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_25b18f8f","line":330,"updated":"2015-01-23 16:10:03.000000000","message":"Use \"pass\" instead of \"return None\" . I imagine \"return None\" has no special meaning, it\u0027s only there not to get the NotImplemented exception. Am I missing something?","commit_id":"b39a02486771f8b1140d87fb4252fe69303f343e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"777473c2f612d6dbeb82b2fc37001327a867b132","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    @classmethod"},{"line_number":329,"context_line":"    def check_version(cls):"},{"line_number":330,"context_line":"        return None"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    @classmethod"},{"line_number":333,"context_line":"    def existing_dhcp_networks(cls, conf, root_helper):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_37cd0a86","line":330,"in_reply_to":"1a930d6b_25b18f8f","updated":"2015-01-26 15:57:33.000000000","message":"Done","commit_id":"b39a02486771f8b1140d87fb4252fe69303f343e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a470808925d52505803c7c3c459e76d6e3293e3b","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    NEUTRON_RELAY_SOCKET_PATH_KEY \u003d \u0027NEUTRON_RELAY_SOCKET_PATH\u0027"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    @classmethod"},{"line_number":292,"context_line":"    def check_version(cls):"},{"line_number":293,"context_line":"        pass"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_1d8828c4","line":292,"updated":"2015-01-26 18:51:00.000000000","message":"Why do we still need this method? Can we refactor this out?","commit_id":"332204fec7e96339947aa662b25adc9925609c4f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"be54197cebf0b9a489daf86b82751720cc6e332a","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    NEUTRON_RELAY_SOCKET_PATH_KEY \u003d \u0027NEUTRON_RELAY_SOCKET_PATH\u0027"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    @classmethod"},{"line_number":292,"context_line":"    def check_version(cls):"},{"line_number":293,"context_line":"        pass"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_a885fd5a","line":292,"in_reply_to":"1a930d6b_1d8828c4","updated":"2015-01-27 08:10:48.000000000","message":"The answer is described in commit message. Basically, dhcp drivers are pluggable, and other drivers may still decide the method is used.\n\nSo we can\u0027t remove it from DhcpBase. And we need to override it not to get NotImplemented exception.","commit_id":"332204fec7e96339947aa662b25adc9925609c4f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"d7414db4b92db93d5f578be9f256f4e7f82613d9","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    NEUTRON_RELAY_SOCKET_PATH_KEY \u003d \u0027NEUTRON_RELAY_SOCKET_PATH\u0027"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    @classmethod"},{"line_number":292,"context_line":"    def check_version(cls):"},{"line_number":293,"context_line":"        pass"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_86666028","line":292,"in_reply_to":"1a930d6b_a885fd5a","updated":"2015-01-27 16:18:25.000000000","message":"doh thanks!","commit_id":"332204fec7e96339947aa662b25adc9925609c4f"}],"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"62e82d57508cbba12d704abc67297f35e7ada44d","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        out \u003d agent_utils.execute(cmd)"},{"line_number":148,"context_line":"        m \u003d re.search(r\"version (\\d+\\.\\d+)\", out)"},{"line_number":149,"context_line":"        ver \u003d float(m.group(1)) if m else 0"},{"line_number":150,"context_line":"        if ver \u003c get_minimal_dnsmasq_version_supported():"},{"line_number":151,"context_line":"            return False"},{"line_number":152,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":153,"context_line":"        LOG.debug(\"Exception while checking minimal dnsmasq version. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_a8d67d51","line":150,"updated":"2015-01-20 15:38:27.000000000","message":"I think that a bit of logging information here maybe helpful especially few words when in debug mode.","commit_id":"97a2963d6d96e4f114bb0edcefa78ab60865b845"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bdc22857b69f8ed624e6042d28864b7426cd6dfd","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        out \u003d agent_utils.execute(cmd)"},{"line_number":148,"context_line":"        m \u003d re.search(r\"version (\\d+\\.\\d+)\", out)"},{"line_number":149,"context_line":"        ver \u003d float(m.group(1)) if m else 0"},{"line_number":150,"context_line":"        if ver \u003c get_minimal_dnsmasq_version_supported():"},{"line_number":151,"context_line":"            return False"},{"line_number":152,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":153,"context_line":"        LOG.debug(\"Exception while checking minimal dnsmasq version. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_dca38741","line":150,"in_reply_to":"3a961159_a8d67d51","updated":"2015-01-20 17:02:24.000000000","message":"If we return False, we\u0027ll log it in sanity_check.py, line 100.","commit_id":"97a2963d6d96e4f114bb0edcefa78ab60865b845"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3d9c9e5253c2cdc709b944e6758f13ec5396623a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        out \u003d agent_utils.execute(cmd)"},{"line_number":148,"context_line":"        m \u003d re.search(r\"version (\\d+\\.\\d+)\", out)"},{"line_number":149,"context_line":"        ver \u003d float(m.group(1)) if m else 0"},{"line_number":150,"context_line":"        if ver \u003c get_minimal_dnsmasq_version_supported():"},{"line_number":151,"context_line":"            return False"},{"line_number":152,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":153,"context_line":"        LOG.debug(\"Exception while checking minimal dnsmasq version. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_a5de5f0f","line":150,"updated":"2015-01-23 16:10:03.000000000","message":"why do you need a getter here? It could simply be:\n\nif ver \u003c MINIMUM_DNSMASQ_VERSION","commit_id":"b39a02486771f8b1140d87fb4252fe69303f343e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"777473c2f612d6dbeb82b2fc37001327a867b132","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        out \u003d agent_utils.execute(cmd)"},{"line_number":148,"context_line":"        m \u003d re.search(r\"version (\\d+\\.\\d+)\", out)"},{"line_number":149,"context_line":"        ver \u003d float(m.group(1)) if m else 0"},{"line_number":150,"context_line":"        if ver \u003c get_minimal_dnsmasq_version_supported():"},{"line_number":151,"context_line":"            return False"},{"line_number":152,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":153,"context_line":"        LOG.debug(\"Exception while checking minimal dnsmasq version. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_d7a92691","line":150,"in_reply_to":"1a930d6b_a5de5f0f","updated":"2015-01-26 15:57:33.000000000","message":"Done","commit_id":"b39a02486771f8b1140d87fb4252fe69303f343e"}],"neutron/cmd/sanity_check.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"55b4d3447fa1d677f3e3179bcdc5035cb705c2d1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"def check_dnsmasq_version():"},{"line_number":98,"context_line":"    result \u003d checks.dnsmasq_version_supported()"},{"line_number":99,"context_line":"    if not result:"},{"line_number":100,"context_line":"        LOG.error(_LE(\u0027Dnmasq version is considered too low. \u0027"},{"line_number":101,"context_line":"                      \u0027Please update to at least %s.\u0027),"},{"line_number":102,"context_line":"                  checks.get_minimal_dnsmasq_version_supported())"},{"line_number":103,"context_line":"    return result"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_d1ffa965","line":100,"updated":"2015-01-23 17:38:55.000000000","message":"\"The installed version of dnsmasq is too old.\"","commit_id":"b39a02486771f8b1140d87fb4252fe69303f343e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"777473c2f612d6dbeb82b2fc37001327a867b132","unresolved":false,"context_lines":[{"line_number":97,"context_line":"def check_dnsmasq_version():"},{"line_number":98,"context_line":"    result \u003d checks.dnsmasq_version_supported()"},{"line_number":99,"context_line":"    if not result:"},{"line_number":100,"context_line":"        LOG.error(_LE(\u0027Dnmasq version is considered too low. \u0027"},{"line_number":101,"context_line":"                      \u0027Please update to at least %s.\u0027),"},{"line_number":102,"context_line":"                  checks.get_minimal_dnsmasq_version_supported())"},{"line_number":103,"context_line":"    return result"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_177e4e19","line":100,"in_reply_to":"1a930d6b_d1ffa965","updated":"2015-01-26 15:57:33.000000000","message":"Done","commit_id":"b39a02486771f8b1140d87fb4252fe69303f343e"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"55b4d3447fa1d677f3e3179bcdc5035cb705c2d1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    result \u003d checks.dnsmasq_version_supported()"},{"line_number":99,"context_line":"    if not result:"},{"line_number":100,"context_line":"        LOG.error(_LE(\u0027Dnmasq version is considered too low. \u0027"},{"line_number":101,"context_line":"                      \u0027Please update to at least %s.\u0027),"},{"line_number":102,"context_line":"                  checks.get_minimal_dnsmasq_version_supported())"},{"line_number":103,"context_line":"    return result"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_51f3b99d","line":101,"updated":"2015-01-23 17:38:55.000000000","message":"\"... at least version %s.\"","commit_id":"b39a02486771f8b1140d87fb4252fe69303f343e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"777473c2f612d6dbeb82b2fc37001327a867b132","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    result \u003d checks.dnsmasq_version_supported()"},{"line_number":99,"context_line":"    if not result:"},{"line_number":100,"context_line":"        LOG.error(_LE(\u0027Dnmasq version is considered too low. \u0027"},{"line_number":101,"context_line":"                      \u0027Please update to at least %s.\u0027),"},{"line_number":102,"context_line":"                  checks.get_minimal_dnsmasq_version_supported())"},{"line_number":103,"context_line":"    return result"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_377b4a29","line":101,"in_reply_to":"1a930d6b_51f3b99d","updated":"2015-01-26 15:57:33.000000000","message":"Done","commit_id":"b39a02486771f8b1140d87fb4252fe69303f343e"}]}
