)]}'
{"neutron/agent/securitygroups_rpc.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"0ebaad22e8cccaaf4f2f1e2febd2ccf328fa93df","unresolved":false,"context_lines":[{"line_number":372,"context_line":"class SecurityGroupAgentRpc(SecurityGroupAgentRpcMixin):"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def __init__(self, context, plugin_rpc, root_helper,"},{"line_number":375,"context_line":"                 defer_refresh_firewall\u003dFalse):"},{"line_number":376,"context_line":"        self.context \u003d context"},{"line_number":377,"context_line":"        self.plugin_rpc \u003d plugin_rpc"},{"line_number":378,"context_line":"        self.root_helper \u003d root_helper"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_475f9a72","line":375,"updated":"2015-01-23 03:07:46.000000000","message":"You\u0027ve got a default arg of False here, and yet pass None in the next block.  Make this None and don\u0027t pass an arg in the first case?","commit_id":"38420418e63d88e7529041989142b5b8c9032d21"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"8c34ef356241f1879624f547a9ffc1edc175c5f5","unresolved":false,"context_lines":[{"line_number":372,"context_line":"class SecurityGroupAgentRpc(SecurityGroupAgentRpcMixin):"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def __init__(self, context, plugin_rpc, root_helper,"},{"line_number":375,"context_line":"                 defer_refresh_firewall\u003dFalse):"},{"line_number":376,"context_line":"        self.context \u003d context"},{"line_number":377,"context_line":"        self.plugin_rpc \u003d plugin_rpc"},{"line_number":378,"context_line":"        self.root_helper \u003d root_helper"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_9b4b8086","line":375,"in_reply_to":"1a930d6b_1c5dd3e9","updated":"2015-01-23 16:53:15.000000000","message":"I\u0027m thinking you meant the first hunk of the changes to the next file?  If so, that None is for the root_helper arg.  :-)","commit_id":"38420418e63d88e7529041989142b5b8c9032d21"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"34da94840d5862f31b616031fbcdaf81f9acebe7","unresolved":false,"context_lines":[{"line_number":372,"context_line":"class SecurityGroupAgentRpc(SecurityGroupAgentRpcMixin):"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def __init__(self, context, plugin_rpc, root_helper,"},{"line_number":375,"context_line":"                 defer_refresh_firewall\u003dFalse):"},{"line_number":376,"context_line":"        self.context \u003d context"},{"line_number":377,"context_line":"        self.plugin_rpc \u003d plugin_rpc"},{"line_number":378,"context_line":"        self.root_helper \u003d root_helper"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_1c5dd3e9","line":375,"in_reply_to":"1a930d6b_475f9a72","updated":"2015-01-23 13:25:29.000000000","message":"Can you point to where None is passed for defer_refresh_firewall?  I\u0027m not seeing it for some reason.","commit_id":"38420418e63d88e7529041989142b5b8c9032d21"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"9031c4f6826cfb12d191f75e84b89c6576e4e84a","unresolved":false,"context_lines":[{"line_number":372,"context_line":"class SecurityGroupAgentRpc(SecurityGroupAgentRpcMixin):"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def __init__(self, context, plugin_rpc, root_helper,"},{"line_number":375,"context_line":"                 defer_refresh_firewall\u003dFalse):"},{"line_number":376,"context_line":"        self.context \u003d context"},{"line_number":377,"context_line":"        self.plugin_rpc \u003d plugin_rpc"},{"line_number":378,"context_line":"        self.root_helper \u003d root_helper"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_9619978a","line":375,"in_reply_to":"1a930d6b_9b4b8086","updated":"2015-01-23 17:25:53.000000000","message":"I fell foul to the same confusion as Doug. Can you use named arguments in the tests, please?","commit_id":"38420418e63d88e7529041989142b5b8c9032d21"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eb78e9b477eb1ff34c10f75f9527f3c515bad41c","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"class SecurityGroupAgentRpc(SecurityGroupAgentRpcMixin):"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def __init__(self, context, plugin_rpc, root_helper,"},{"line_number":375,"context_line":"                 defer_refresh_firewall\u003dFalse):"},{"line_number":376,"context_line":"        self.context \u003d context"},{"line_number":377,"context_line":"        self.plugin_rpc \u003d plugin_rpc"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_505e4077","line":374,"updated":"2015-01-24 18:53:22.000000000","message":"Maybe it\u0027s just me, but I personally hate classes that override __init__ and don\u0027t call to super().__init__(). Mostly because it would break children that would like to do multiple inheritance. It\u0027s so selfish of those parents that attempt to bind their children!\n\nBut it\u0027s just me I guess.","commit_id":"414d044e25dbf265e8ab4644bb3f49e34539f9a4"}]}