)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"75c2b7be87a1ca0737d3151a097d7c11d2ddad9e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add compose function to utils to wipe out lambdas"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In our crusade against lambdas, we need the appropriate"},{"line_number":10,"context_line":"functional weaponry to eliminate some uses that the standard"},{"line_number":11,"context_line":"operators cannot cover. This patch adds a compose function"},{"line_number":12,"context_line":"so lambdas that use the passed in variable in an inner function"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a930d6b_0191fa46","line":9,"updated":"2015-01-23 08:30:09.000000000","message":"The first time I hear about the crusade. With all due respect, could you please publish the appeal from Alexios I Komnenos? It seems that by going this route, we may loose a lot of godfearing people in the battle for vague reason.","commit_id":"0503ed2a74d684b7cb27c18398337784f0feee74"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"133e566eb0e873f5f2fe1c746cd56d3c117ff8aa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add compose function to utils to wipe out lambdas"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In our crusade against lambdas, we need the appropriate"},{"line_number":10,"context_line":"functional weaponry to eliminate some uses that the standard"},{"line_number":11,"context_line":"operators cannot cover. This patch adds a compose function"},{"line_number":12,"context_line":"so lambdas that use the passed in variable in an inner function"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a930d6b_06df4b3c","line":9,"in_reply_to":"1a930d6b_0191fa46","updated":"2015-01-23 10:12:42.000000000","message":"I found surprisingly few results when searching for Alexios I Komnenos\u0027s stance on the lambda calculus.","commit_id":"0503ed2a74d684b7cb27c18398337784f0feee74"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3abfa9ea0d02d8ef81d8f976e5fd18aa4459b647","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add compose function to utils to wipe out lambdas"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In our crusade against lambdas, we need the appropriate"},{"line_number":10,"context_line":"functional weaponry to eliminate some uses that the standard"},{"line_number":11,"context_line":"operators cannot cover. This patch adds a compose function"},{"line_number":12,"context_line":"so lambdas that use the passed in variable in an inner function"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a930d6b_265fe773","line":9,"in_reply_to":"1a930d6b_06df4b3c","updated":"2015-01-23 10:17:24.000000000","message":"Yeah. They say he used operator module.","commit_id":"0503ed2a74d684b7cb27c18398337784f0feee74"}],"neutron/agent/linux/ovs_lib.py":[{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"7b46a9bd0585f29e6f19ab4fde1cd1b2b9876128","unresolved":false,"context_lines":[{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        if not self.full_ordered:"},{"line_number":556,"context_line":"            action_flow_tuples.sort("},{"line_number":557,"context_line":"                key\u003dn_utils.compose(self.weights.get, operator.itemgetter(0)))"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        grouped \u003d itertools.groupby(action_flow_tuples,"},{"line_number":560,"context_line":"                                    key\u003doperator.itemgetter(0))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_6da475a6","line":557,"updated":"2015-01-23 05:24:58.000000000","message":"Just because my knuckles drag on the ground, here\u0027s the caveman version of this function for comparison:\n\n def apply_flows(self):\n   action_flows \u003d collections.defaultdict(list)\n   for action, flow in self.action_flow_tuples.iteritems():\n     action_flows[action].append(flow)\n   self.action_flow_tuples \u003d []\n\n   actions \u003d action_flows.keys()\n   if not self.full_ordered:\n     actions.sort(key\u003dself.weights.get)\n\n   for action in actions:\n     flows \u003d action_flows[action]\n     self.br.do_action_flows(action, flows)\n\nI like groupby(), but it seems like most of the existing function is about massaging to/from the right format to be able to use groupby() ...","commit_id":"0503ed2a74d684b7cb27c18398337784f0feee74"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"133e566eb0e873f5f2fe1c746cd56d3c117ff8aa","unresolved":false,"context_lines":[{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        if not self.full_ordered:"},{"line_number":556,"context_line":"            action_flow_tuples.sort("},{"line_number":557,"context_line":"                key\u003dn_utils.compose(self.weights.get, operator.itemgetter(0)))"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        grouped \u003d itertools.groupby(action_flow_tuples,"},{"line_number":560,"context_line":"                                    key\u003doperator.itemgetter(0))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_135a2bf3","line":557,"in_reply_to":"1a930d6b_6da475a6","updated":"2015-01-23 10:12:42.000000000","message":"Yeah, but my compose function is going to look pretty stupid as a part of this patch if I don\u0027t use it. ;)\n\nYour suggestion is definitely a much better cleanup though.","commit_id":"0503ed2a74d684b7cb27c18398337784f0feee74"}]}