)]}'
{"neutron/db/agentschedulers_db.py":[{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"657ea99cea5de9510863ef69dd92a2a38b43389d","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                    context, binding.network_id, dhcp_notifier)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def get_dhcp_agents_hosting_networks("},{"line_number":273,"context_line":"            self, context, network_ids, active\u003dNone, admin_state_up\u003dNone):"},{"line_number":274,"context_line":"        if not network_ids:"},{"line_number":275,"context_line":"            return []"},{"line_number":276,"context_line":"        query \u003d context.session.query(NetworkDhcpAgentBinding)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_144eac6f","line":273,"updated":"2015-02-03 05:26:47.000000000","message":"Should admin_state_up be default to True to keep calls to get_dhcp_agents_hosting_networks with active\u003dTrue backward compatible?","commit_id":"975fbc373ae23a3c9086ba8e93fd494454fb0362"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"35ae65762d83af38e4b9d7bc78a7766e8b457d45","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                    context, binding.network_id, dhcp_notifier)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def get_dhcp_agents_hosting_networks("},{"line_number":273,"context_line":"            self, context, network_ids, active\u003dNone, admin_state_up\u003dNone):"},{"line_number":274,"context_line":"        if not network_ids:"},{"line_number":275,"context_line":"            return []"},{"line_number":276,"context_line":"        query \u003d context.session.query(NetworkDhcpAgentBinding)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_f48bd865","line":273,"in_reply_to":"da86d52c_144eac6f","updated":"2015-02-03 05:36:19.000000000","message":"admin_state_up filtering has always been broken.\nmaking admin_state_up\u003dTrue default would actually break the existing callers.","commit_id":"975fbc373ae23a3c9086ba8e93fd494454fb0362"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"181153574d67dc7e8d16017da0982a26aaa7211a","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                    context, binding.network_id, dhcp_notifier)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def get_dhcp_agents_hosting_networks("},{"line_number":273,"context_line":"            self, context, network_ids, active\u003dNone, admin_state_up\u003dNone):"},{"line_number":274,"context_line":"        if not network_ids:"},{"line_number":275,"context_line":"            return []"},{"line_number":276,"context_line":"        query \u003d context.session.query(NetworkDhcpAgentBinding)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_98c37c56","line":273,"in_reply_to":"da86d52c_33cc786a","updated":"2015-02-04 03:44:14.000000000","message":"yes, it\u0027s same as the current behavior, which is ensured by some of UTs.\n\nnote that the filter at L.287 has always been broken and effectively ignored.\n(until this patch fixed it)","commit_id":"975fbc373ae23a3c9086ba8e93fd494454fb0362"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"2f30f9c00acf83ef0832e3c2acb7b0fb73f87aff","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                    context, binding.network_id, dhcp_notifier)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def get_dhcp_agents_hosting_networks("},{"line_number":273,"context_line":"            self, context, network_ids, active\u003dNone, admin_state_up\u003dNone):"},{"line_number":274,"context_line":"        if not network_ids:"},{"line_number":275,"context_line":"            return []"},{"line_number":276,"context_line":"        query \u003d context.session.query(NetworkDhcpAgentBinding)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_33cc786a","line":273,"in_reply_to":"da86d52c_f48bd865","updated":"2015-02-04 00:37:15.000000000","message":"What I worry about is when active\u003dTrue when calling this method (used by many places in current code), admin_state_up is None by default. the filter at line 287 won\u0027t be used as before when active\u003dTrue.","commit_id":"975fbc373ae23a3c9086ba8e93fd494454fb0362"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"fca549cd0463fa93c8b07aed16086964042755ff","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                self._schedule_network("},{"line_number":287,"context_line":"                    context, saved_binding[\u0027net\u0027], dhcp_notifier)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def get_dhcp_agents_hosting_networks("},{"line_number":290,"context_line":"            self, context, network_ids, active\u003dNone, admin_state_up\u003dNone):"},{"line_number":291,"context_line":"        if not network_ids:"},{"line_number":292,"context_line":"            return []"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a6ced46_a44af2a9","line":289,"updated":"2015-03-25 02:48:59.000000000","message":"You already have a million +1\u0027s/2\u0027s so I\u0027m not going to -1 at this point, but personally I would not add admin_state_up in this patch. I\u0027d file a separate bug and if there\u0027s any future patch that actually needs to filter on admin_state_up, then that patch should make the change. Adding an optional parameter that no one currently needs makes no sense.","commit_id":"96aa9f93600d6e97394ad725e095d5539848ca2d"}],"neutron/scheduler/dhcp_agent_scheduler.py":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"82e7f11e3576d694217ff2ffcb054ddb7314c787","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # subnets whose enable_dhcp is false"},{"line_number":67,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":68,"context_line":"            dhcp_agents \u003d plugin.get_dhcp_agents_hosting_networks("},{"line_number":69,"context_line":"                context, [network[\u0027id\u0027]])"},{"line_number":70,"context_line":"            if len(dhcp_agents) \u003e\u003d agents_per_network:"},{"line_number":71,"context_line":"                LOG.debug(\u0027Network %s is hosted already\u0027,"},{"line_number":72,"context_line":"                          network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_a101ed07","line":69,"updated":"2015-01-30 05:41:47.000000000","message":"Another patch on review [1] is also doing the same thing.\nIn my opinion [1] should be added as a dependency to this patch.\n\n[1] https://review.openstack.org/#/c/138659/","commit_id":"cd23f0f13bbdb3e7509c38609ddad5d96d314348"}],"neutron/tests/unit/test_dhcp_scheduler.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"018835be6dcc941d51e9ed5de33b175b55125ad0","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        host_ids \u003d set(a[\u0027host\u0027] for a in agents)"},{"line_number":272,"context_line":"        self.assertEqual(expected, host_ids)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def test_get_dhcp_agents_hosting_networks(self):"},{"line_number":275,"context_line":"        agents \u003d self._create_and_set_agents_down([\u0027host-a\u0027, \u0027host-b\u0027], 1)"},{"line_number":276,"context_line":"        agents +\u003d self._create_and_set_agents_down([\u0027host-c\u0027, \u0027host-d\u0027], 1,"},{"line_number":277,"context_line":"                                                   admin_state_up\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_df9de30b","line":274,"updated":"2015-02-03 22:35:33.000000000","message":"Looks like a good set of assertions. However, it might be nice to break these assertions out into their own test cases. It would be easier to work though unit test failures that way. It would also help to name the test cases a little more descriptively as well, someone may have to stare at this for a while in the future to be able to understand the assertions being made by this test case.","commit_id":"975fbc373ae23a3c9086ba8e93fd494454fb0362"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"711a68ebef3594d9d01c6353e51e58f1b549e94c","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        host_ids \u003d set(a[\u0027host\u0027] for a in agents)"},{"line_number":272,"context_line":"        self.assertEqual(expected, host_ids)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def test_get_dhcp_agents_hosting_networks(self):"},{"line_number":275,"context_line":"        agents \u003d self._create_and_set_agents_down([\u0027host-a\u0027, \u0027host-b\u0027], 1)"},{"line_number":276,"context_line":"        agents +\u003d self._create_and_set_agents_down([\u0027host-c\u0027, \u0027host-d\u0027], 1,"},{"line_number":277,"context_line":"                                                   admin_state_up\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_58c90458","line":274,"in_reply_to":"da86d52c_df9de30b","updated":"2015-02-04 03:49:54.000000000","message":"Done","commit_id":"975fbc373ae23a3c9086ba8e93fd494454fb0362"}]}