)]}'
{"doc/source/devref/contribute.rst":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bb2f1e7842181dcc1ab39bb49b18c25eb8792760","unresolved":false,"context_lines":[{"line_number":395,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":396,"context_line":"| networking-arista_            |          ml2          |    no     |       yes        |   [B]   |              |"},{"line_number":397,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":398,"context_line":"| networking-brocade_           |          ml2          |           |                  |         |              |"},{"line_number":399,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":400,"context_line":"| networking-cisco_             |                       |           |                  |         |              |"},{"line_number":401,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a80dd14_c5cdc432","line":398,"updated":"2015-03-09 18:22:54.000000000","message":"what about l3? not sure why the l3 changes in this patch are relevant. Can you elaborate? Also, what about the rest of the columns here?","commit_id":"cfd61713e6024224a271c5c5e553278c08caa108"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"328c478d0a612feccafda9b4f25301c3825ea022","unresolved":false,"context_lines":[{"line_number":395,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":396,"context_line":"| networking-arista_            |          ml2          |    no     |       yes        |   [B]   |              |"},{"line_number":397,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":398,"context_line":"| networking-brocade_           |          ml2          |           |                  |         |              |"},{"line_number":399,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":400,"context_line":"| networking-cisco_             |                       |           |                  |         |              |"},{"line_number":401,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a80dd14_0157c258","line":398,"in_reply_to":"9a80dd14_c5cdc432","updated":"2015-03-10 00:57:26.000000000","message":"This patch removes ml2 and l3 plugin simultaneously due to the fact that here is a common hardware specific file shared by both. So removing both at the same time makes sense.\n\nI have now filled in the other columns as well.","commit_id":"cfd61713e6024224a271c5c5e553278c08caa108"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"db00e68075ab1e729063a69da6ca146ae4cd696a","unresolved":false,"context_lines":[{"line_number":434,"context_line":""},{"line_number":435,"context_line":".. _networking-brocade:"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"* Git: https://github.com/stackforge/networking-brocade"},{"line_number":438,"context_line":"* Pypi: https://pypi.python.org/pypi/networking-brocade"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a80dd14_846100ab","line":437,"updated":"2015-03-10 00:41:25.000000000","message":"Launchpad?","commit_id":"60790efd26ad05b8ce689e912c7eaa974d0e2317"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"dc6add31f793ecae339ab96d1813d42d765467c8","unresolved":false,"context_lines":[{"line_number":434,"context_line":""},{"line_number":435,"context_line":".. _networking-brocade:"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"* Git: https://github.com/stackforge/networking-brocade"},{"line_number":438,"context_line":"* Pypi: https://pypi.python.org/pypi/networking-brocade"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a80dd14_4480e88a","line":437,"in_reply_to":"9a80dd14_846100ab","updated":"2015-03-10 01:02:22.000000000","message":"Added.","commit_id":"60790efd26ad05b8ce689e912c7eaa974d0e2317"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f3102564dd6fd14cad532b0ee35538f7bd5859f5","unresolved":false,"context_lines":[{"line_number":400,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":401,"context_line":"| networking-arista_            |          ml2          |    no     |       yes        |   [B]   |              |"},{"line_number":402,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":403,"context_line":"| networking-brocade_           |        ml2,l3(svi)    |   yes     |       yes        |   [B]   |     Kilo     |"},{"line_number":404,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":405,"context_line":"| networking-cisco_             |  core,ml2,l3,fw,vpn   |    yes    |       yes        |   [B]   |              |"},{"line_number":406,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9a80dd14_34600735","line":403,"updated":"2015-03-12 06:04:56.000000000","message":"why not [C]?\nmy understanding is that, if \"State\" is [B], \"Completed in\" should be left empty.","commit_id":"f205c4db4943b0f65d5cde59b001db0a2b4d91f0"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"57bd5e9258a9628e68bd639fa380ffa20145f650","unresolved":false,"context_lines":[{"line_number":400,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":401,"context_line":"| networking-arista_            |          ml2          |    no     |       yes        |   [B]   |              |"},{"line_number":402,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":403,"context_line":"| networking-brocade_           |        ml2,l3(svi)    |   yes     |       yes        |   [B]   |     Kilo     |"},{"line_number":404,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":405,"context_line":"| networking-cisco_             |  core,ml2,l3,fw,vpn   |    yes    |       yes        |   [B]   |              |"},{"line_number":406,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9a80dd14_805227dc","line":403,"in_reply_to":"9a80dd14_00b71cf6","updated":"2015-03-12 23:03:40.000000000","message":"I\u0027ll clarify:\nThere are 2 different L3 plugins:\n\n1. Hardware switch (VDX) also referred to as SVI\n(this one is in this patch-set). This is a hardware router.\n\n2. Software router (Vyatta vRouter, based on a virtual machine)\n(this one is in patch-set [1]) This is a software router.\n[1] https://review.openstack.org/#/c/159056/\n\nYes the status of these are complete. Will mark it [C]\n\nI will clarify this better.","commit_id":"f205c4db4943b0f65d5cde59b001db0a2b4d91f0"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"57bd5e9258a9628e68bd639fa380ffa20145f650","unresolved":false,"context_lines":[{"line_number":400,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":401,"context_line":"| networking-arista_            |          ml2          |    no     |       yes        |   [B]   |              |"},{"line_number":402,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":403,"context_line":"| networking-brocade_           |        ml2,l3(svi)    |   yes     |       yes        |   [B]   |     Kilo     |"},{"line_number":404,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":405,"context_line":"| networking-cisco_             |  core,ml2,l3,fw,vpn   |    yes    |       yes        |   [B]   |              |"},{"line_number":406,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9a80dd14_c0a25fad","line":403,"in_reply_to":"9a80dd14_34600735","updated":"2015-03-12 23:03:40.000000000","message":"Agreed.\n(This response is for the [B] -\u003e [C] comment.)","commit_id":"f205c4db4943b0f65d5cde59b001db0a2b4d91f0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c974d2f9427645565e52e111206ad8450aa67352","unresolved":false,"context_lines":[{"line_number":400,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":401,"context_line":"| networking-arista_            |          ml2          |    no     |       yes        |   [B]   |              |"},{"line_number":402,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":403,"context_line":"| networking-brocade_           |        ml2,l3(svi)    |   yes     |       yes        |   [B]   |     Kilo     |"},{"line_number":404,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":405,"context_line":"| networking-cisco_             |  core,ml2,l3,fw,vpn   |    yes    |       yes        |   [B]   |              |"},{"line_number":406,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9a80dd14_00b71cf6","line":403,"in_reply_to":"9a80dd14_34600735","updated":"2015-03-12 19:37:40.000000000","message":"Agreed. If this is completed in Kilo, the State should be marked as complete [C].\n\nAlso I am confused by the (svi) inline. Change [1], is bringing a new router service plugin and I assume it\u0027s !\u003d from svi.\n\n[1] https://review.openstack.org/#/c/159056/","commit_id":"f205c4db4943b0f65d5cde59b001db0a2b4d91f0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c974d2f9427645565e52e111206ad8450aa67352","unresolved":false,"context_lines":[{"line_number":443,"context_line":""},{"line_number":444,"context_line":"* Git: https://github.com/stackforge/networking-brocade"},{"line_number":445,"context_line":"* Launchpad: https://launchpad.net/networking-brocade"},{"line_number":446,"context_line":"* Pypi: https://pypi.python.org/pypi/networking-brocade"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":""},{"line_number":449,"context_line":".. _networking-cisco:"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9a80dd14_80c22c51","line":446,"updated":"2015-03-12 19:37:40.000000000","message":"For the joy of Yamamoto, when you respin, this should be PyPI, but I don\u0027t mind if you forget ;)","commit_id":"f205c4db4943b0f65d5cde59b001db0a2b4d91f0"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"57bd5e9258a9628e68bd639fa380ffa20145f650","unresolved":false,"context_lines":[{"line_number":443,"context_line":""},{"line_number":444,"context_line":"* Git: https://github.com/stackforge/networking-brocade"},{"line_number":445,"context_line":"* Launchpad: https://launchpad.net/networking-brocade"},{"line_number":446,"context_line":"* Pypi: https://pypi.python.org/pypi/networking-brocade"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":""},{"line_number":449,"context_line":".. _networking-cisco:"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9a80dd14_20aedb98","line":446,"in_reply_to":"9a80dd14_80c22c51","updated":"2015-03-12 23:03:40.000000000","message":"Of course.","commit_id":"f205c4db4943b0f65d5cde59b001db0a2b4d91f0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2669c365c3501ab5fa372b8a02c9b5d7586a99a7","unresolved":false,"context_lines":[{"line_number":400,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":401,"context_line":"| networking-arista_            |          ml2          |    no     |       yes        |   [B]   |              |"},{"line_number":402,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":403,"context_line":"| networking-brocade_           |   VDX: ml2,l3(svi)    |   yes     |       yes        |   [C]   |     Kilo     |"},{"line_number":404,"context_line":"|                               |  vyatta vRouter: l3   |           |                  |         |              |"},{"line_number":405,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":406,"context_line":"| networking-cisco_             |  core,ml2,l3,fw,vpn   |    yes    |       yes        |   [B]   |              |"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a80dd14_b4704941","line":403,"updated":"2015-03-12 23:12:42.000000000","message":"thanks for clearing that up. This cell would be complete if you just listed l3, regardless of the specific options, but this doesn\u0027t hurt. I just hope this does not set a bad example, because if we start listing all the possible combinations for all plugins, this table becomes a mess.\n\nBesides, the vyatta contribution does not belong here, so this is technically jumping ahead. Please consider just listing ml2,l3. You can expand in your readme file","commit_id":"0709da0c82d5176d180d70f1104d0754c1c5ca76"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"13cc19f150cbc27bad2634939df6ea68f96efb1f","unresolved":false,"context_lines":[{"line_number":400,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":401,"context_line":"| networking-arista_            |          ml2          |    no     |       yes        |   [B]   |              |"},{"line_number":402,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":403,"context_line":"| networking-brocade_           |   VDX: ml2,l3(svi)    |   yes     |       yes        |   [C]   |     Kilo     |"},{"line_number":404,"context_line":"|                               |  vyatta vRouter: l3   |           |                  |         |              |"},{"line_number":405,"context_line":"+-------------------------------+-----------------------+-----------+------------------+---------+--------------+"},{"line_number":406,"context_line":"| networking-cisco_             |  core,ml2,l3,fw,vpn   |    yes    |       yes        |   [B]   |              |"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a80dd14_6f235cbd","line":403,"in_reply_to":"9a80dd14_b4704941","updated":"2015-03-12 23:49:30.000000000","message":"changed it to minimal set of ml2 and l3\nWill expand this in the stackforge README.md","commit_id":"0709da0c82d5176d180d70f1104d0754c1c5ca76"}],"neutron/plugins/ml2/drivers/brocade/mechanism_brocade.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9d77eec601e386688d02384c3afff16418c75c50","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ML2_BROCADE \u003d [cfg.StrOpt(\u0027address\u0027, default\u003d\u0027\u0027,"},{"line_number":25,"context_line":"                          help\u003d_(\u0027The address of the host to SSH to\u0027)),"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a80dd14_091f3b6d","line":22,"updated":"2015-03-13 01:38:33.000000000","message":"you might want to remove this as it\u0027s now unused","commit_id":"939439503865dd904a9d99e3f1b7296814dfef0a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"00d2364c245ee7c9fbc5cae03034de19e6f9cde2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ML2_BROCADE \u003d [cfg.StrOpt(\u0027address\u0027, default\u003d\u0027\u0027,"},{"line_number":25,"context_line":"                          help\u003d_(\u0027The address of the host to SSH to\u0027)),"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a80dd14_cc99b17a","line":22,"in_reply_to":"9a80dd14_091f3b6d","updated":"2015-03-13 01:42:31.000000000","message":"I suspect this needs a rebase now that [1] merged:\n\n[1] https://review.openstack.org/#/c/159638/","commit_id":"939439503865dd904a9d99e3f1b7296814dfef0a"}],"neutron/services/l3_router/brocade/l3_router_plugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bb2f1e7842181dcc1ab39bb49b18c25eb8792760","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self._driver \u003d driver.NOSdriver()"},{"line_number":74,"context_line":"        LOG.info(_LI(\"rbridge id %s\"), self._switch[\u0027rbridge_id\u0027])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def create_router(self, context, router):"},{"line_number":77,"context_line":"        \"\"\"Creates a vrf on NOS device.\"\"\""},{"line_number":78,"context_line":"        LOG.debug(\"BrocadeSVIPlugin.create_router called: \")"},{"line_number":79,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_207f6e16","side":"PARENT","line":76,"updated":"2015-03-09 18:22:54.000000000","message":"are these changes relevant? I don\u0027t see this plugin switching to the vendor-specific one. Can you elaborate?","commit_id":"c9bd7f0dc8c82e908da3eab87189e682b8f7473e"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"328c478d0a612feccafda9b4f25301c3825ea022","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self._driver \u003d driver.NOSdriver()"},{"line_number":74,"context_line":"        LOG.info(_LI(\"rbridge id %s\"), self._switch[\u0027rbridge_id\u0027])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def create_router(self, context, router):"},{"line_number":77,"context_line":"        \"\"\"Creates a vrf on NOS device.\"\"\""},{"line_number":78,"context_line":"        LOG.debug(\"BrocadeSVIPlugin.create_router called: \")"},{"line_number":79,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_41929af6","side":"PARENT","line":76,"in_reply_to":"9a80dd14_207f6e16","updated":"2015-03-10 00:57:26.000000000","message":"This plugin in this file call into hardware specific (NETCONF) interface. This file is mostly specific to Brocade as well. Hence removing most of the stuff.\n\nfor example: self._driver.create_router below will call make send netconf requests to the VDX switch.","commit_id":"c9bd7f0dc8c82e908da3eab87189e682b8f7473e"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"39d4d462a507b5c42389c57c9f8f27a498982098","unresolved":false,"context_lines":[{"line_number":44,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class BrocadeSVIPlugin(router.L3RouterPlugin):"},{"line_number":48,"context_line":"    \"\"\"Brocade SVI service Plugin.\"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_bd852ed0","line":47,"updated":"2015-03-10 06:24:45.000000000","message":"who still uses this class?","commit_id":"d5fe5b3022be5fcc3b53f6b2b095acdc583a08ac"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"04603e6a014221379917a343f059b2a1a76794f5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class BrocadeSVIPlugin(router.L3RouterPlugin):"},{"line_number":48,"context_line":"    \"\"\"Brocade SVI service Plugin.\"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_869d5f5c","line":47,"in_reply_to":"9a80dd14_bd852ed0","updated":"2015-03-10 16:55:53.000000000","message":"This class may get invoked due to an error condition. I am adding a log error message to that will indicate this. SVI plugin in loaded as part of invocation from the ml2 plugin.","commit_id":"d5fe5b3022be5fcc3b53f6b2b095acdc583a08ac"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6e42961f4854046830b06fee9f3dbe0084e5bb10","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        super(BrocadeSVIPlugin, self).__init__()"},{"line_number":50,"context_line":"        self._switch \u003d None"},{"line_number":51,"context_line":"        self._driver \u003d None"},{"line_number":52,"context_line":"        LOG.error(_LE(\"Brocade VDX L3 SVI plugin has new location: %s\"),"},{"line_number":53,"context_line":"                  \"networking_brocade/vdx/services/l3_router/l3_router_plugin\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_1136f5e7","line":51,"updated":"2015-03-11 00:26:54.000000000","message":"are L50-51 necessary?","commit_id":"1e5bf18a0cebab0c50967532cc9a97c227461a95"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"d532ae866135bbc0d7dc38967ac932cce50fd715","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        super(BrocadeSVIPlugin, self).__init__()"},{"line_number":50,"context_line":"        self._switch \u003d None"},{"line_number":51,"context_line":"        self._driver \u003d None"},{"line_number":52,"context_line":"        LOG.error(_LE(\"Brocade VDX L3 SVI plugin has new location: %s\"),"},{"line_number":53,"context_line":"                  \"networking_brocade/vdx/services/l3_router/l3_router_plugin\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_b157e9c9","line":51,"in_reply_to":"9a80dd14_1136f5e7","updated":"2015-03-11 00:41:41.000000000","message":"Agreed, they are not necessary. I can correct that right away.","commit_id":"1e5bf18a0cebab0c50967532cc9a97c227461a95"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4967a26d30605c6b7abe157b43ac681bfa5dbe93","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self._switch \u003d None"},{"line_number":51,"context_line":"        self._driver \u003d None"},{"line_number":52,"context_line":"        LOG.error(_LE(\"Brocade VDX L3 SVI plugin has new location: %s\"),"},{"line_number":53,"context_line":"                  \"networking_brocade/vdx/services/l3_router/l3_router_plugin\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_f1ade1eb","line":53,"updated":"2015-03-11 00:36:54.000000000","message":"Is this class needed in order to throw the error only? Do you actually need the message? Isn\u0027t the other codes unnecessary even if you need it?","commit_id":"1e5bf18a0cebab0c50967532cc9a97c227461a95"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"d532ae866135bbc0d7dc38967ac932cce50fd715","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self._switch \u003d None"},{"line_number":51,"context_line":"        self._driver \u003d None"},{"line_number":52,"context_line":"        LOG.error(_LE(\"Brocade VDX L3 SVI plugin has new location: %s\"),"},{"line_number":53,"context_line":"                  \"networking_brocade/vdx/services/l3_router/l3_router_plugin\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_11ca756e","line":53,"in_reply_to":"9a80dd14_f1ade1eb","updated":"2015-03-11 00:41:41.000000000","message":"That is exactly what I was talking to Yamamoto. This is here only for transitioning from the old scheme to the new scheme. Apps that build config file (like devstack as an instance) may create a configuration that is no longer valid, so a some hand-holding is why this exists.\n\nIn reality if there was no history, i really dont need this.","commit_id":"1e5bf18a0cebab0c50967532cc9a97c227461a95"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d46d964216edac646d914ed6c84f7db121a60a26","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def __init__(self):"},{"line_number":45,"context_line":"        \"\"\"Initialize Brocade L3 (SVI) Plugin"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        Specify switch address and db configuration."},{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        super(BrocadeSVIPlugin, self).__init__()"},{"line_number":50,"context_line":"        LOG.error(_LE(\"Brocade VDX L3 SVI plugin has new location: %s\"),"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a80dd14_0c6edc96","line":47,"updated":"2015-03-11 01:24:01.000000000","message":"while i personally prefer to remove this class entirely,\ni have no strong enough opinion.\n\nif you want to keep this for now, can you update docstring to\nexplain the purpose and plan?\neg. this is to produce a nicer error message than \"class not found\",\nthis will be removed after a release cycle, etc.","commit_id":"384d03d20f35ed5f59ad76ef41ce7737d587ad38"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"682a47bc151eb7022b63ce4dc2605d5b0ce72dbe","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def __init__(self):"},{"line_number":45,"context_line":"        \"\"\"Initialize Brocade L3 (SVI) Plugin"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        Specify switch address and db configuration."},{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        super(BrocadeSVIPlugin, self).__init__()"},{"line_number":50,"context_line":"        LOG.error(_LE(\"Brocade VDX L3 SVI plugin has new location: %s\"),"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a80dd14_29daade9","line":47,"in_reply_to":"9a80dd14_0c6edc96","updated":"2015-03-11 04:12:22.000000000","message":"I have added text to indicate that this is not the correct version to use. It is not clear when the final removal will take place.","commit_id":"384d03d20f35ed5f59ad76ef41ce7737d587ad38"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2f7a305a3e6680af0a3f1f7414eaaaec42be41dc","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        Specify switch address and db configuration."},{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        super(BrocadeSVIPlugin, self).__init__()"},{"line_number":50,"context_line":"        LOG.error(_LE(\"Brocade VDX L3 SVI plugin has new location: %s\"),"},{"line_number":51,"context_line":"                  \"networking_brocade/vdx/services/l3_router/l3_router_plugin\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a80dd14_4cc4545f","line":49,"updated":"2015-03-11 01:26:00.000000000","message":"If my understanding is correct about your purpose, this line, L24-L36 and class extends are also unnecessary, aren\u0027t they?","commit_id":"384d03d20f35ed5f59ad76ef41ce7737d587ad38"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"682a47bc151eb7022b63ce4dc2605d5b0ce72dbe","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        Specify switch address and db configuration."},{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        super(BrocadeSVIPlugin, self).__init__()"},{"line_number":50,"context_line":"        LOG.error(_LE(\"Brocade VDX L3 SVI plugin has new location: %s\"),"},{"line_number":51,"context_line":"                  \"networking_brocade/vdx/services/l3_router/l3_router_plugin\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a80dd14_09ede98b","line":49,"in_reply_to":"9a80dd14_4cc4545f","updated":"2015-03-11 04:12:22.000000000","message":"We do need the config registration/options for sure.","commit_id":"384d03d20f35ed5f59ad76ef41ce7737d587ad38"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ab2916b8128727c7586fd3718c2221086fddb052","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        LOG.error(_LE(\"Brocade VDX L3 SVI plugin has new location: %s\"),"},{"line_number":51,"context_line":"                  \"networking_brocade/vdx/services/l3_router/l3_router_plugin\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_ec16de54","line":51,"updated":"2015-03-11 08:48:27.000000000","message":"do you intentionally keep it running after emitting this error?\nor missing \"raise SystemExit(1)\" here?","commit_id":"9c75083c42496ecb12dc752e9c0c19be99777b20"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"6d60efcddefb4ae1ea4b2234cf15d847ace25cfe","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        LOG.error(_LE(\"Brocade VDX L3 SVI plugin has new location: %s\"),"},{"line_number":51,"context_line":"                  \"networking_brocade/vdx/services/l3_router/l3_router_plugin\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_5620289b","line":51,"in_reply_to":"9a80dd14_b00dec37","updated":"2015-03-12 01:01:33.000000000","message":"Based on the IRC discussion, i will remove this class definition.","commit_id":"9c75083c42496ecb12dc752e9c0c19be99777b20"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"e7d84dfb1500fd033c697c52e174252a903cce46","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        LOG.error(_LE(\"Brocade VDX L3 SVI plugin has new location: %s\"),"},{"line_number":51,"context_line":"                  \"networking_brocade/vdx/services/l3_router/l3_router_plugin\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_f5ebd6d9","line":51,"in_reply_to":"9a80dd14_ec16de54","updated":"2015-03-11 23:36:11.000000000","message":"I will change this if there is another updated needed. Otherwise I think this is quite fine as is.","commit_id":"9c75083c42496ecb12dc752e9c0c19be99777b20"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"822ee3f530723d8f8f8ad44ab9c02003969807ab","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        LOG.error(_LE(\"Brocade VDX L3 SVI plugin has new location: %s\"),"},{"line_number":51,"context_line":"                  \"networking_brocade/vdx/services/l3_router/l3_router_plugin\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_b00dec37","line":51,"in_reply_to":"9a80dd14_f5ebd6d9","updated":"2015-03-11 23:57:14.000000000","message":"I am actually puzzle...what this is for, exactly?","commit_id":"9c75083c42496ecb12dc752e9c0c19be99777b20"}],"setup.cfg":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c974d2f9427645565e52e111206ad8450aa67352","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    bigswitch \u003d neutron.plugins.ml2.drivers.mech_bigswitch.driver:BigSwitchMechanismDriver"},{"line_number":175,"context_line":"    ofagent \u003d networking_ofagent.plugins.ml2.drivers.mech_ofagent:OfagentMechanismDriver"},{"line_number":176,"context_line":"    mlnx \u003d neutron.plugins.ml2.drivers.mlnx.mech_mlnx:MlnxMechanismDriver"},{"line_number":177,"context_line":"    brocade \u003d networking_brocade.vdx.ml2driver.mechanism_brocade:BrocadeMechanism"},{"line_number":178,"context_line":"    fslsdn \u003d neutron.plugins.ml2.drivers.freescale.mechanism_fslsdn:FslsdnMechanismDriver"},{"line_number":179,"context_line":"    sriovnicswitch \u003d neutron.plugins.ml2.drivers.mech_sriov.mech_driver:SriovNicSwitchMechanismDriver"},{"line_number":180,"context_line":"    nuage \u003d neutron.plugins.ml2.drivers.mech_nuage.driver:NuageMechanismDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":18,"id":"9a80dd14_00855c06","line":177,"updated":"2015-03-12 19:37:40.000000000","message":"is it intentional that you don\u0027t have any entry for the l3 plugin in \u0027service_plugins\u0027?","commit_id":"f205c4db4943b0f65d5cde59b001db0a2b4d91f0"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"57bd5e9258a9628e68bd639fa380ffa20145f650","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    bigswitch \u003d neutron.plugins.ml2.drivers.mech_bigswitch.driver:BigSwitchMechanismDriver"},{"line_number":175,"context_line":"    ofagent \u003d networking_ofagent.plugins.ml2.drivers.mech_ofagent:OfagentMechanismDriver"},{"line_number":176,"context_line":"    mlnx \u003d neutron.plugins.ml2.drivers.mlnx.mech_mlnx:MlnxMechanismDriver"},{"line_number":177,"context_line":"    brocade \u003d networking_brocade.vdx.ml2driver.mechanism_brocade:BrocadeMechanism"},{"line_number":178,"context_line":"    fslsdn \u003d neutron.plugins.ml2.drivers.freescale.mechanism_fslsdn:FslsdnMechanismDriver"},{"line_number":179,"context_line":"    sriovnicswitch \u003d neutron.plugins.ml2.drivers.mech_sriov.mech_driver:SriovNicSwitchMechanismDriver"},{"line_number":180,"context_line":"    nuage \u003d neutron.plugins.ml2.drivers.mech_nuage.driver:NuageMechanismDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":18,"id":"9a80dd14_009d570a","line":177,"in_reply_to":"9a80dd14_00855c06","updated":"2015-03-12 23:03:40.000000000","message":"Yes it is intentional. l3 service plugin class is specified in this manner:\n\nThe L3 service plugin class can be specified in /etc/neutron/neutron.conf file in its [default] section. Any application creating the neutron.conf needs to specify the class to invoke,\n\ndevstack provides additional help by allowing a define of ML2_L3_PLUGIN which can essentially do the above automatically.","commit_id":"f205c4db4943b0f65d5cde59b001db0a2b4d91f0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e382a501a4db712d96dcc795516189b49af0fc9d","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    bigswitch \u003d neutron.plugins.ml2.drivers.mech_bigswitch.driver:BigSwitchMechanismDriver"},{"line_number":175,"context_line":"    ofagent \u003d networking_ofagent.plugins.ml2.drivers.mech_ofagent:OfagentMechanismDriver"},{"line_number":176,"context_line":"    mlnx \u003d neutron.plugins.ml2.drivers.mlnx.mech_mlnx:MlnxMechanismDriver"},{"line_number":177,"context_line":"    brocade \u003d networking_brocade.vdx.ml2driver.mechanism_brocade:BrocadeMechanism"},{"line_number":178,"context_line":"    fslsdn \u003d neutron.plugins.ml2.drivers.freescale.mechanism_fslsdn:FslsdnMechanismDriver"},{"line_number":179,"context_line":"    sriovnicswitch \u003d neutron.plugins.ml2.drivers.mech_sriov.mech_driver:SriovNicSwitchMechanismDriver"},{"line_number":180,"context_line":"    nuage \u003d neutron.plugins.ml2.drivers.mech_nuage.driver:NuageMechanismDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":18,"id":"9a80dd14_d405bd7a","line":177,"in_reply_to":"9a80dd14_009d570a","updated":"2015-03-12 23:11:54.000000000","message":"ok, reason why I am asking is that the vyatta change in [1] does provide one. So, do you want to be consistent or not?\n\n[1] https://review.openstack.org/#/c/159056/5/setup.cfg","commit_id":"f205c4db4943b0f65d5cde59b001db0a2b4d91f0"}]}
