)]}'
{"neutron/scheduler/dhcp_agent_scheduler.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"196a5a63eb2d8e72867f52af5ad7590feb21517c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            if not enabled_dhcp_agents:"},{"line_number":80,"context_line":"                LOG.warn(_LW(\u0027No more DHCP agents\u0027))"},{"line_number":81,"context_line":"                return"},{"line_number":82,"context_line":"            # filter our dead agents, but not those"},{"line_number":83,"context_line":"            # which are dead because they are starting up"},{"line_number":84,"context_line":"            active_dhcp_agents \u003d ["},{"line_number":85,"context_line":"                agent for agent in set(enabled_dhcp_agents)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_fc045f16","line":82,"updated":"2015-02-18 07:42:46.000000000","message":"nit: the comment may be confusing as it\u0027s unclear where starting agents are handled in this context. Consider moving to is_eligible_agent() or just removing.","commit_id":"ef4cccb00d4c95145482f34775a2572c55b8072c"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7cf8952c0846928f429a52e3ba274fa8030ad3ab","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            if not enabled_dhcp_agents:"},{"line_number":80,"context_line":"                LOG.warn(_LW(\u0027No more DHCP agents\u0027))"},{"line_number":81,"context_line":"                return"},{"line_number":82,"context_line":"            # filter our dead agents, but not those"},{"line_number":83,"context_line":"            # which are dead because they are starting up"},{"line_number":84,"context_line":"            active_dhcp_agents \u003d ["},{"line_number":85,"context_line":"                agent for agent in set(enabled_dhcp_agents)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_e409e684","line":82,"in_reply_to":"da86d52c_fc045f16","updated":"2015-02-19 14:31:13.000000000","message":"Done","commit_id":"ef4cccb00d4c95145482f34775a2572c55b8072c"}],"neutron/tests/unit/openvswitch/test_agent_scheduler.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c5cb479978de0903819ca1805bfe5165e86e85d9","unresolved":false,"context_lines":[{"line_number":488,"context_line":"                               },"},{"line_number":489,"context_line":"            \u0027agent_type\u0027: constants.AGENT_TYPE_DHCP}"},{"line_number":490,"context_line":"        self._register_one_agent_state(dhcp_hosta)"},{"line_number":491,"context_line":"        eligible_agent_str \u003d (\u0027neutron.db.agentschedulers_db.\u0027"},{"line_number":492,"context_line":"                              \u0027DhcpAgentSchedulerDbMixin.is_eligible_agent\u0027)"},{"line_number":493,"context_line":"        with mock.patch(eligible_agent_str) as eligible_agent:"},{"line_number":494,"context_line":"            eligible_agent.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_c9d8b620","line":491,"updated":"2015-02-11 12:19:15.000000000","message":"what if mock both is_agent_down() and agent_is_starting_up() and add tests for their combinations?","commit_id":"064adbe97e237e56bfa488d51952d7ff890f9123"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"651d52843122fcaf9b62f4f744921487fa9bdd18","unresolved":false,"context_lines":[{"line_number":488,"context_line":"                               },"},{"line_number":489,"context_line":"            \u0027agent_type\u0027: constants.AGENT_TYPE_DHCP}"},{"line_number":490,"context_line":"        self._register_one_agent_state(dhcp_hosta)"},{"line_number":491,"context_line":"        eligible_agent_str \u003d (\u0027neutron.db.agentschedulers_db.\u0027"},{"line_number":492,"context_line":"                              \u0027DhcpAgentSchedulerDbMixin.is_eligible_agent\u0027)"},{"line_number":493,"context_line":"        with mock.patch(eligible_agent_str) as eligible_agent:"},{"line_number":494,"context_line":"            eligible_agent.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_3a1ff671","line":491,"in_reply_to":"da86d52c_c9d8b620","updated":"2015-02-17 16:42:00.000000000","message":"I\u0027ll add separate test for DhcpAgentSchedulerDbMixin.is_eligible_agent","commit_id":"064adbe97e237e56bfa488d51952d7ff890f9123"}]}