)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"90c3c93a846cc7352a85ace664aede1b51c89a15","unresolved":false,"context_lines":[{"line_number":11,"context_line":"\u0027time\u0027 module for monkey_patching to detect which \u0027subprocess\u0027"},{"line_number":12,"context_line":"module to import."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This can cause issues when things like test frameworks import"},{"line_number":15,"context_line":"modules that monkey_patch, as the order imports are made can break"},{"line_number":16,"context_line":"this kind of check. It is always good to monkey patch as soon as"},{"line_number":17,"context_line":"possible, hence trying to do the patching in neutron/__init__.py."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_a0fdde70","line":14,"updated":"2015-02-07 09:15:22.000000000","message":"I understand the intention, but I would like to see whether there is proof or notes to reproduce these issues you\u0027re talking about.\n\nNo bug report and not enough information as to what is the extent of the problem...I feel pretty uneasy to +1/2 this patch.","commit_id":"7eff565b00d5abd80d39096f9b6244252f00a533"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab0d30e5eb39319230708d454ca013e1cf27a917","unresolved":false,"context_lines":[{"line_number":11,"context_line":"\u0027time\u0027 module for monkey_patching to detect which \u0027subprocess\u0027"},{"line_number":12,"context_line":"module to import."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This can cause issues when things like test frameworks import"},{"line_number":15,"context_line":"modules that monkey_patch, as the order imports are made can break"},{"line_number":16,"context_line":"this kind of check. It is always good to monkey patch as soon as"},{"line_number":17,"context_line":"possible, hence trying to do the patching in neutron/__init__.py."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_e0d996f5","line":14,"in_reply_to":"da86d52c_a0fdde70","updated":"2015-02-07 09:51:37.000000000","message":"I guess Terry may mention #1418541 here.","commit_id":"7eff565b00d5abd80d39096f9b6244252f00a533"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d20597c169a72011b3dda948fc19974c6aece8aa","unresolved":false,"context_lines":[{"line_number":19,"context_line":"This is an alternative to https://review.openstack.org/#/c/153225/"},{"line_number":20,"context_line":"which just patches neutron/tests/__init__.py. Unfortunately, just"},{"line_number":21,"context_line":"monkey_patching in tests/__init__.py didn\u0027t fix all of the issues"},{"line_number":22,"context_line":"I ran into. For example, tempest tests were failing with timeouts."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-bug: #1418541"},{"line_number":25,"context_line":"Change-Id: I7f2115a99acae5b6d61aab2f7334f498b8d99858"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da86d52c_8a038c0c","line":22,"updated":"2015-02-08 18:39:15.000000000","message":"This interesting. What kind of timeout was triggered? It\u0027d be interesting to understand how neutron failed in this case. More for curiosity other than anything else.","commit_id":"bec45e5e32de9b984a140e490fa2ecc4ccfca5f6"}],"neutron/__init__.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"58e2be0c6a4ce2c0166418ba3122dad619a45a98","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if not os.environ.get(\u0027NO_EVENTLET\u0027):"},{"line_number":20,"context_line":"    import eventlet"},{"line_number":21,"context_line":"    eventlet.monkey_patch()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_6004947e","line":20,"updated":"2015-02-09 19:00:52.000000000","message":"just idle curiosity...but why is Neutron the only project experiencing this issue? I can see that every project does its own monkey business, so that makes me wonder if we\u0027ll ever get rid of this nonsense.","commit_id":"bec45e5e32de9b984a140e490fa2ecc4ccfca5f6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00135562253c15003c7aa0150c82b48b1c1ee248","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if not os.environ.get(\u0027NO_EVENTLET\u0027):"},{"line_number":20,"context_line":"    import eventlet"},{"line_number":21,"context_line":"    eventlet.monkey_patch()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_7a4a8084","line":20,"in_reply_to":"da86d52c_6004947e","updated":"2015-02-09 20:12:35.000000000","message":"Other projects may haven\u0027t yet consumed oslo.concurrency or were lucky to have proper test order generated by testr.","commit_id":"bec45e5e32de9b984a140e490fa2ecc4ccfca5f6"}]}
