)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"1a0ae7b764c6b952ea0604b603b3b4649af112c4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The value for Vxlan UDP port value should be updated in"},{"line_number":10,"context_line":"\u0027ml2_vxlan_endpoints\u0027 table with the values"},{"line_number":11,"context_line":"configured in ml2_conf.ini at L2 agent side."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The tunnel_sync() rpc should send the UDP port to it."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da86d52c_14b5fecc","line":11,"updated":"2015-02-09 06:17:12.000000000","message":"from the code change I don\u0027t see the value for vxlan udp port is updated with values in ml2_conf.ini but the value in neutron.plugins.common.constants is used instead.","commit_id":"896cd66327444aeb83d8b743f0f2aafc9176fe56"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"1e8a0c2cfd539c497d21247ff762d69827ec39ce","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The value for Vxlan UDP port value should be updated in"},{"line_number":10,"context_line":"\u0027ml2_vxlan_endpoints\u0027 table with the values"},{"line_number":11,"context_line":"configured in ml2_conf.ini at L2 agent side."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The tunnel_sync() rpc should send the UDP port to it."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da86d52c_94456eb5","line":11,"in_reply_to":"da86d52c_14b5fecc","updated":"2015-02-09 06:21:19.000000000","message":"Please find the test case for the same in patch-set2 in test_tunnel_type.py\n\nIt\u0027s getting updated. If you don\u0027t pass the udp_port then I will take p_const.VXLAN_UDP_PORT.","commit_id":"896cd66327444aeb83d8b743f0f2aafc9176fe56"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"5171a49d9c27bdf6e6f2335461d70c8128fb24ab","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implementation:"},{"line_number":16,"context_line":"tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027."},{"line_number":17,"context_line":"Added update_endpoint method to update the upd_port value."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"It also includes small code re-factoring."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ba7be1f8_5a342449","line":17,"updated":"2015-02-26 18:53:30.000000000","message":"upd_port--\u003eudp_port.\n\nI will update it if I need to post another patch-set :)","commit_id":"f0226aeaf306d6287d94938aea4b3f48cb170183"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f085fa091d31c5b792cae419efd8540791d0fc4a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implementation:"},{"line_number":16,"context_line":"tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027."},{"line_number":17,"context_line":"Added update_vxlan_endpoint method to update the udp_port value."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"It also includes small code re-factoring."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba7be1f8_6a4ad756","line":17,"updated":"2015-02-27 11:40:54.000000000","message":"I don\u0027t believe it\u0027s a good thing to make it VXLAN specific. There should be common interface for all tunnels.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"277354ee572242718ca40ae9c771ea422e2c37fa","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implementation:"},{"line_number":16,"context_line":"tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027."},{"line_number":17,"context_line":"Added update_vxlan_endpoint method to update the udp_port value."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"It also includes small code re-factoring."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba7be1f8_4dd7edbf","line":17,"in_reply_to":"ba7be1f8_0aa4fb55","updated":"2015-02-27 12:33:26.000000000","message":"Other tunnels may need something similar later. But look at the race issue due to multiple transactions used. I think it won\u0027t be possible to handle it without making add_endpoint handle update for us.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"07e9668b506b5b49ef4d98b603de8ee5dde65083","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implementation:"},{"line_number":16,"context_line":"tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027."},{"line_number":17,"context_line":"Added update_vxlan_endpoint method to update the udp_port value."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"It also includes small code re-factoring."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba7be1f8_0aa4fb55","line":17,"in_reply_to":"ba7be1f8_6a4ad756","updated":"2015-02-27 12:04:33.000000000","message":"But the changes we are doing here just for VXLAN that\u0027s why I remove it from abstract method.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f085fa091d31c5b792cae419efd8540791d0fc4a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027."},{"line_number":17,"context_line":"Added update_vxlan_endpoint method to update the udp_port value."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"It also includes small code re-factoring."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1373359"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba7be1f8_cad4a349","line":19,"updated":"2015-02-27 11:40:54.000000000","message":"A bug fix should include just the changes that are needed, for potential backports.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"277354ee572242718ca40ae9c771ea422e2c37fa","unresolved":false,"context_lines":[{"line_number":16,"context_line":"tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027."},{"line_number":17,"context_line":"Added update_vxlan_endpoint method to update the udp_port value."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"It also includes small code re-factoring."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1373359"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba7be1f8_adc6a914","line":19,"in_reply_to":"ba7be1f8_6a4d77c4","updated":"2015-02-27 12:33:26.000000000","message":"I would be glad to, but I\u0027m not a core reviewer for neutron. :)","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"3ca5dd304a8be584bdf95016bb9cffdd4696c99c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027."},{"line_number":17,"context_line":"Added update_vxlan_endpoint method to update the udp_port value."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"It also includes small code re-factoring."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1373359"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba7be1f8_d83559f8","line":19,"in_reply_to":"ba7be1f8_adc6a914","updated":"2015-02-27 12:52:28.000000000","message":"Cool :)\n\nPlease don\u0027t be so rigid to allow me in doing small code refactoring in this patchset itself.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"07e9668b506b5b49ef4d98b603de8ee5dde65083","unresolved":false,"context_lines":[{"line_number":16,"context_line":"tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027."},{"line_number":17,"context_line":"Added update_vxlan_endpoint method to update the udp_port value."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"It also includes small code re-factoring."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1373359"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ba7be1f8_6a4d77c4","line":19,"in_reply_to":"ba7be1f8_cad4a349","updated":"2015-02-27 12:04:33.000000000","message":"Do you want me to post separate patchset to address all small code refactoring. In that case, I would expect you should be the first one to give +2 to me.\n\nPlease don\u0027t mind :)","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"526f834c6aaafd95d52957ca27e1b4a41ca7dea9","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"P.S: It also includes small code refactoring which I came"},{"line_number":19,"context_line":"across while doing the code changes and its good to have"},{"line_number":20,"context_line":"them as part of this patch."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #1373359"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"9a80dd14_714b6c2b","line":20,"updated":"2015-03-12 08:29:58.000000000","message":"this change has too many \"small refactoring\".\nsome files seem to have only such changes.\nhow about separating them for easier review?","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"e537b04786bfceaa81843865d38370f1f7d4ceea","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"P.S: It also includes small code refactoring which I came"},{"line_number":19,"context_line":"across while doing the code changes and its good to have"},{"line_number":20,"context_line":"them as part of this patch."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #1373359"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"9a80dd14_b40312b7","line":20,"in_reply_to":"9a80dd14_714b6c2b","updated":"2015-03-12 08:46:31.000000000","message":"Sorry, I am not comfortable it doing it in separate patch-set.","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"814df9b4f9b79830f99c831e189e3d50b0ee4708","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Implementation:"},{"line_number":16,"context_line":"tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"P.S: It also includes small code refactoring which I came"},{"line_number":19,"context_line":"across while doing the code changes and its good to have"},{"line_number":20,"context_line":"them as part of this patch."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1a6ced46_02b6bf3d","line":18,"updated":"2015-03-22 23:06:13.000000000","message":"I think it\u0027s the first time I see a post scriptum in a commit message!\nPerhaps it is unnecessary, but if you want to keep it, I\u0027ll be very pedant and ask you to do punctuation properly: \"P.S.:\"\n\nAaaah I love being pedant sooo much!","commit_id":"3e917c3227ffad56257badf8926ef29ccad702b3"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"d39ed8e9bbc56855d61937f68cfecd7d7ceec39e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Implementation:"},{"line_number":16,"context_line":"tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"P.S: It also includes small code refactoring which I came"},{"line_number":19,"context_line":"across while doing the code changes and its good to have"},{"line_number":20,"context_line":"them as part of this patch."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1a6ced46_bb76f2d6","line":18,"in_reply_to":"1a6ced46_02b6bf3d","updated":"2015-03-23 04:56:43.000000000","message":"Good catch, I will correct it :)","commit_id":"3e917c3227ffad56257badf8926ef29ccad702b3"}],"neutron/agent/rpc.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"f68cdb520d79f12668a108fcbbbe8cf9f0e1ccb2","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def tunnel_sync(self, context, tunnel_ip, tunnel_type\u003dNone, host\u003dNone,"},{"line_number":122,"context_line":"                    udp_port\u003dNone):"},{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            cctxt \u003d self.client.prepare(version\u003d\u00271.4\u0027)"},{"line_number":125,"context_line":"            res \u003d cctxt.call(context, \u0027tunnel_sync\u0027, tunnel_ip\u003dtunnel_ip,"},{"line_number":126,"context_line":"                             tunnel_type\u003dtunnel_type, host\u003dhost,"},{"line_number":127,"context_line":"                             udp_port\u003dudp_port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_1f99846e","line":124,"updated":"2015-02-09 15:58:31.000000000","message":"You are adding a new parameter you should bump the version. You can\u0027t reuse 1.4 .See [1]\n\n[1] http://docs.openstack.org/developer/oslo.messaging/target.html#target-versions","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"337e7f8ac8a80d18856116506b9f539f91e6df20","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def tunnel_sync(self, context, tunnel_ip, tunnel_type\u003dNone, host\u003dNone,"},{"line_number":122,"context_line":"                    udp_port\u003dNone):"},{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            cctxt \u003d self.client.prepare(version\u003d\u00271.4\u0027)"},{"line_number":125,"context_line":"            res \u003d cctxt.call(context, \u0027tunnel_sync\u0027, tunnel_ip\u003dtunnel_ip,"},{"line_number":126,"context_line":"                             tunnel_type\u003dtunnel_type, host\u003dhost,"},{"line_number":127,"context_line":"                             udp_port\u003dudp_port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_70c62f4b","line":124,"in_reply_to":"da86d52c_1f99846e","updated":"2015-02-09 16:28:49.000000000","message":"Should I use 1.5?\n\nI feel we should go with 1.4 only since its a dependent patchset and don\u0027t need new RPC version.","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"509bd8cda8d28712b7116c7c7c196f3d451343ea","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def tunnel_sync(self, context, tunnel_ip, tunnel_type\u003dNone, host\u003dNone,"},{"line_number":122,"context_line":"                    udp_port\u003dNone):"},{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            cctxt \u003d self.client.prepare(version\u003d\u00271.4\u0027)"},{"line_number":125,"context_line":"            res \u003d cctxt.call(context, \u0027tunnel_sync\u0027, tunnel_ip\u003dtunnel_ip,"},{"line_number":126,"context_line":"                             tunnel_type\u003dtunnel_type, host\u003dhost,"},{"line_number":127,"context_line":"                             udp_port\u003dudp_port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_f745b015","line":124,"in_reply_to":"da86d52c_70c62f4b","updated":"2015-02-09 18:05:51.000000000","message":"You should use 1.5, what\u0027s the relationship between rpc versioning and patchset dependencies? I don\u0027t understand your explanation.","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"66b180ba90f474342e74b553b30e039d3595552d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def tunnel_sync(self, context, tunnel_ip, tunnel_type\u003dNone, host\u003dNone,"},{"line_number":122,"context_line":"                    udp_port\u003dNone):"},{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            cctxt \u003d self.client.prepare(version\u003d\u00271.4\u0027)"},{"line_number":125,"context_line":"            res \u003d cctxt.call(context, \u0027tunnel_sync\u0027, tunnel_ip\u003dtunnel_ip,"},{"line_number":126,"context_line":"                             tunnel_type\u003dtunnel_type, host\u003dhost,"},{"line_number":127,"context_line":"                             udp_port\u003dudp_port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_1e4966b7","line":124,"in_reply_to":"da86d52c_e5409637","updated":"2015-02-10 03:51:22.000000000","message":"Thanks for understanding :)\nProbably, I will find out some way to do it.","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"7767ddbd0bfd5951cbee980fc6cbcb1a3a46230e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def tunnel_sync(self, context, tunnel_ip, tunnel_type\u003dNone, host\u003dNone,"},{"line_number":122,"context_line":"                    udp_port\u003dNone):"},{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            cctxt \u003d self.client.prepare(version\u003d\u00271.4\u0027)"},{"line_number":125,"context_line":"            res \u003d cctxt.call(context, \u0027tunnel_sync\u0027, tunnel_ip\u003dtunnel_ip,"},{"line_number":126,"context_line":"                             tunnel_type\u003dtunnel_type, host\u003dhost,"},{"line_number":127,"context_line":"                             udp_port\u003dudp_port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e5409637","line":124,"in_reply_to":"da86d52c_f745b015","updated":"2015-02-09 18:31:19.000000000","message":"I see your point now, you upgraded the rpc version to 1.4 in the patch from which this change depends. It\u0027s confusing. If you want to use the same version 1.4 for adding both parameters then you should modify the method in the same patch, use version 1.4 to add both host and udp_port. Otherwise I fear you have to use version 1.4 for host and then bump again 1.5 for udp_port to avoid inconsistencies. Your 2 patches even if they depend on each other can be merged in different moments, there\u0027s no guarantee that they will be both merged at the same time so rpc version should be managed accordingly.","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f9e7ae15b9d018f3732a0201c7ff306c7e7f240e","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        except oslo_messaging.UnsupportedVersion:"},{"line_number":130,"context_line":"            LOG.warn(_LW(\u0027Tunnel synchronization requires a server upgrade.\u0027))"},{"line_number":131,"context_line":"            cctxt \u003d self.client.prepare()"},{"line_number":132,"context_line":"            res \u003d cctxt.call(context, \u0027tunnel_sync\u0027, tunnel_ip\u003dtunnel_ip,"},{"line_number":133,"context_line":"                             tunnel_type\u003dtunnel_type, host\u003dhost)"},{"line_number":134,"context_line":"        return res"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_d0fe056b","line":132,"updated":"2015-02-20 22:36:05.000000000","message":"Wait... Both 1.4 and 1.5 were added during the Kilo cycle. If you upgrade the agent before the server, and the agent fires off this method, it\u0027ll get a non supported version exception but the fall back will fail as well. I think you should remove the host parameter from the fallback, or introduce a second layer of fallback.","commit_id":"7b1dee27118806b93696eb28fc4f47dcc046b099"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"c3951f79bdc4c573bba66d7a048f86addef62487","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        except oslo_messaging.UnsupportedVersion:"},{"line_number":130,"context_line":"            LOG.warn(_LW(\u0027Tunnel synchronization requires a server upgrade.\u0027))"},{"line_number":131,"context_line":"            cctxt \u003d self.client.prepare()"},{"line_number":132,"context_line":"            res \u003d cctxt.call(context, \u0027tunnel_sync\u0027, tunnel_ip\u003dtunnel_ip,"},{"line_number":133,"context_line":"                             tunnel_type\u003dtunnel_type, host\u003dhost)"},{"line_number":134,"context_line":"        return res"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_7d928a58","line":132,"in_reply_to":"ba7be1f8_d0fe056b","updated":"2015-02-21 13:51:54.000000000","message":"Done","commit_id":"7b1dee27118806b93696eb28fc4f47dcc046b099"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"526f834c6aaafd95d52957ca27e1b4a41ca7dea9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"              return value to include fixed_ips and device_owner for"},{"line_number":89,"context_line":"              the device port"},{"line_number":90,"context_line":"        1.4 - tunnel_sync rpc signature upgrade to obtain \u0027host\u0027"},{"line_number":91,"context_line":"        1.5 - tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027"},{"line_number":92,"context_line":"    \u0027\u0027\u0027"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def __init__(self, topic):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_916d409c","line":91,"updated":"2015-03-12 08:29:58.000000000","message":"i\u0027m not sure if it\u0027s a good idea to have a parameter sepecific to a particular tunneling technology.\ncan you try to make it more generic?","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"e1f6b7458a313e0485b150acf647bd5ac6b98e07","unresolved":false,"context_lines":[{"line_number":88,"context_line":"              return value to include fixed_ips and device_owner for"},{"line_number":89,"context_line":"              the device port"},{"line_number":90,"context_line":"        1.4 - tunnel_sync rpc signature upgrade to obtain \u0027host\u0027"},{"line_number":91,"context_line":"        1.5 - tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027"},{"line_number":92,"context_line":"    \u0027\u0027\u0027"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def __init__(self, topic):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_69e52ea7","line":91,"in_reply_to":"9a80dd14_54bad66e","updated":"2015-03-12 16:28:15.000000000","message":"Hi Yamamoto,\n\nYou have given a nice suggestion, what I am thinking right now is let this patch merge. \n\nIn the separate patch-set we could create a \"tunnel_params\" dict and add \u0027tunnel_ip\u0027, \u0027tunnel_type\u0027, \u0027host\u0027 and \u0027udp_port\u0027 into tunnel_params dict and pass that dict as part of tunnel_sync in ovs_neutron_agent.py\n\n                details \u003d self.plugin_rpc.tunnel_sync(self.context, self.tunnel_params)\n\nWhat do you think?","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"16737853234376564175003c4ddd7d303507fa51","unresolved":false,"context_lines":[{"line_number":88,"context_line":"              return value to include fixed_ips and device_owner for"},{"line_number":89,"context_line":"              the device port"},{"line_number":90,"context_line":"        1.4 - tunnel_sync rpc signature upgrade to obtain \u0027host\u0027"},{"line_number":91,"context_line":"        1.5 - tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027"},{"line_number":92,"context_line":"    \u0027\u0027\u0027"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def __init__(self, topic):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_9766d5eb","line":91,"in_reply_to":"9a80dd14_69e52ea7","updated":"2015-03-13 09:48:42.000000000","message":"it\u0027s better to avoid intermediate steps for rpc changes.\nfor compat reasons.","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"fbb5416620187f02adf2faeaee6a4ad1bdace760","unresolved":false,"context_lines":[{"line_number":88,"context_line":"              return value to include fixed_ips and device_owner for"},{"line_number":89,"context_line":"              the device port"},{"line_number":90,"context_line":"        1.4 - tunnel_sync rpc signature upgrade to obtain \u0027host\u0027"},{"line_number":91,"context_line":"        1.5 - tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027"},{"line_number":92,"context_line":"    \u0027\u0027\u0027"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def __init__(self, topic):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_54bad66e","line":91,"in_reply_to":"9a80dd14_74951a3f","updated":"2015-03-12 09:00:14.000000000","message":"how about having \"tunnel_params\" dict argument which contains tunnel technology specific parameters?","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"e537b04786bfceaa81843865d38370f1f7d4ceea","unresolved":false,"context_lines":[{"line_number":88,"context_line":"              return value to include fixed_ips and device_owner for"},{"line_number":89,"context_line":"              the device port"},{"line_number":90,"context_line":"        1.4 - tunnel_sync rpc signature upgrade to obtain \u0027host\u0027"},{"line_number":91,"context_line":"        1.5 - tunnel_sync rpc signature upgrade to obtain \u0027udp_port\u0027"},{"line_number":92,"context_line":"    \u0027\u0027\u0027"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def __init__(self, topic):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_74951a3f","line":91,"in_reply_to":"9a80dd14_916d409c","updated":"2015-03-12 08:46:31.000000000","message":"Can you please guide me, How we could make it generic?","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"526f834c6aaafd95d52957ca27e1b4a41ca7dea9","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            res \u003d cctxt.call(context, \u0027tunnel_sync\u0027, tunnel_ip\u003dtunnel_ip,"},{"line_number":135,"context_line":"                             tunnel_type\u003dtunnel_type, host\u003dhost,"},{"line_number":136,"context_line":"                             udp_port\u003dudp_port)"},{"line_number":137,"context_line":"        except oslo_messaging.UnsupportedVersion:"},{"line_number":138,"context_line":"            LOG.warn(_LW(\u0027Tunnel synchronization requires a server upgrade.\u0027))"},{"line_number":139,"context_line":"            cctxt \u003d self.client.prepare()"},{"line_number":140,"context_line":"            res \u003d cctxt.call(context, \u0027tunnel_sync\u0027, tunnel_ip\u003dtunnel_ip,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_ce2ab78f","line":137,"updated":"2015-03-12 08:29:58.000000000","message":"should fallback to 1.4 first?","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"16737853234376564175003c4ddd7d303507fa51","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            res \u003d cctxt.call(context, \u0027tunnel_sync\u0027, tunnel_ip\u003dtunnel_ip,"},{"line_number":135,"context_line":"                             tunnel_type\u003dtunnel_type, host\u003dhost,"},{"line_number":136,"context_line":"                             udp_port\u003dudp_port)"},{"line_number":137,"context_line":"        except oslo_messaging.UnsupportedVersion:"},{"line_number":138,"context_line":"            LOG.warn(_LW(\u0027Tunnel synchronization requires a server upgrade.\u0027))"},{"line_number":139,"context_line":"            cctxt \u003d self.client.prepare()"},{"line_number":140,"context_line":"            res \u003d cctxt.call(context, \u0027tunnel_sync\u0027, tunnel_ip\u003dtunnel_ip,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_97db357b","line":137,"in_reply_to":"9a80dd14_747c3a21","updated":"2015-03-13 09:48:42.000000000","message":"ok, i don\u0027t insist.","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"e537b04786bfceaa81843865d38370f1f7d4ceea","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            res \u003d cctxt.call(context, \u0027tunnel_sync\u0027, tunnel_ip\u003dtunnel_ip,"},{"line_number":135,"context_line":"                             tunnel_type\u003dtunnel_type, host\u003dhost,"},{"line_number":136,"context_line":"                             udp_port\u003dudp_port)"},{"line_number":137,"context_line":"        except oslo_messaging.UnsupportedVersion:"},{"line_number":138,"context_line":"            LOG.warn(_LW(\u0027Tunnel synchronization requires a server upgrade.\u0027))"},{"line_number":139,"context_line":"            cctxt \u003d self.client.prepare()"},{"line_number":140,"context_line":"            res \u003d cctxt.call(context, \u0027tunnel_sync\u0027, tunnel_ip\u003dtunnel_ip,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_747c3a21","line":137,"in_reply_to":"9a80dd14_ce2ab78f","updated":"2015-03-12 08:46:31.000000000","message":"I understand, Kindly see the Assaf concern in earlier patch-set.\nhttps://review.openstack.org/#/c/153891/8/neutron/agent/rpc.py","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"}],"neutron/plugins/ml2/drivers/type_gre.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f085fa091d31c5b792cae419efd8540791d0fc4a","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            gre_endpoint.save(session)"},{"line_number":157,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":158,"context_line":"            gre_endpoint \u003d (session.query(GreEndpoints)."},{"line_number":159,"context_line":"                            filter_by(ip_address\u003dip).first())"},{"line_number":160,"context_line":"            LOG.warning(_LW(\"Gre endpoint with ip %s already exists\"), ip)"},{"line_number":161,"context_line":"        return gre_endpoint"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_2a67ffeb","line":159,"updated":"2015-02-27 11:40:54.000000000","message":"Why the change?","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"07e9668b506b5b49ef4d98b603de8ee5dde65083","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            gre_endpoint.save(session)"},{"line_number":157,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":158,"context_line":"            gre_endpoint \u003d (session.query(GreEndpoints)."},{"line_number":159,"context_line":"                            filter_by(ip_address\u003dip).first())"},{"line_number":160,"context_line":"            LOG.warning(_LW(\"Gre endpoint with ip %s already exists\"), ip)"},{"line_number":161,"context_line":"        return gre_endpoint"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_2a761fd9","line":159,"in_reply_to":"ba7be1f8_2a67ffeb","updated":"2015-02-27 12:04:33.000000000","message":"I feel using first() is better over one() here.\n\nhttp://docs.sqlalchemy.org/en/rel_0_9/orm/query.html","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"277354ee572242718ca40ae9c771ea422e2c37fa","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            gre_endpoint.save(session)"},{"line_number":157,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":158,"context_line":"            gre_endpoint \u003d (session.query(GreEndpoints)."},{"line_number":159,"context_line":"                            filter_by(ip_address\u003dip).first())"},{"line_number":160,"context_line":"            LOG.warning(_LW(\"Gre endpoint with ip %s already exists\"), ip)"},{"line_number":161,"context_line":"        return gre_endpoint"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_0dedf58b","line":159,"in_reply_to":"ba7be1f8_2a761fd9","updated":"2015-02-27 12:33:26.000000000","message":"That\u0027s a noble goal but belongs to another bug fix.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7cc069143d12c63a4097454887afe575edd54088","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            gre_endpoint.save(session)"},{"line_number":157,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":158,"context_line":"            gre_endpoint \u003d (session.query(GreEndpoints)."},{"line_number":159,"context_line":"                            filter_by(ip_address\u003dip).first())"},{"line_number":160,"context_line":"            LOG.warning(_LW(\"Gre endpoint with ip %s already exists\"), ip)"},{"line_number":161,"context_line":"        return gre_endpoint"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a80dd14_14b167e1","line":159,"updated":"2015-03-05 07:30:46.000000000","message":"is there a test for this?","commit_id":"ba489cfe8c85cfe9d4a14e7c9364225ef9312e0a"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"454cf3d13d5b04496dd9af08c119e229b045c8b7","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            gre_endpoint.save(session)"},{"line_number":157,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":158,"context_line":"            gre_endpoint \u003d (session.query(GreEndpoints)."},{"line_number":159,"context_line":"                            filter_by(ip_address\u003dip).first())"},{"line_number":160,"context_line":"            LOG.warning(_LW(\"Gre endpoint with ip %s already exists\"), ip)"},{"line_number":161,"context_line":"        return gre_endpoint"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a80dd14_375e6de7","line":159,"in_reply_to":"9a80dd14_14b167e1","updated":"2015-03-05 07:52:41.000000000","message":"What kind of test do you expect for this?\n\nBut, we do have tests for add_endpoint method in test_type_gre.","commit_id":"ba489cfe8c85cfe9d4a14e7c9364225ef9312e0a"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"bef7bdf929a8ae7a5dc34f2308683f4a00c15908","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            gre_endpoint.save(session)"},{"line_number":157,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":158,"context_line":"            gre_endpoint \u003d (session.query(GreEndpoints)."},{"line_number":159,"context_line":"                            filter_by(ip_address\u003dip).first())"},{"line_number":160,"context_line":"            LOG.warning(_LW(\"Gre endpoint with ip %s already exists\"), ip)"},{"line_number":161,"context_line":"        return gre_endpoint"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a80dd14_4d95123f","line":159,"in_reply_to":"9a80dd14_375e6de7","updated":"2015-03-05 08:36:47.000000000","message":"It is just a small improvement in query.I feel using first() is better over one() here.\n\nReference:\nhttp://docs.sqlalchemy.org/en/rel_0_9/orm/query.html","commit_id":"ba489cfe8c85cfe9d4a14e7c9364225ef9312e0a"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"27e2e49142d929d6432fc6454ec9848b43fc0a9c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            gre_endpoint.save(session)"},{"line_number":157,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":158,"context_line":"            gre_endpoint \u003d (session.query(GreEndpoints)."},{"line_number":159,"context_line":"                            filter_by(ip_address\u003dip).first())"},{"line_number":160,"context_line":"            LOG.warning(_LW(\"Gre endpoint with ip %s already exists\"), ip)"},{"line_number":161,"context_line":"        return gre_endpoint"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_264d183f","line":159,"updated":"2015-03-06 11:37:19.000000000","message":"Other reviewers commented about it. You feel that first() is better over one() but actually you are modifying the behaviour of the code. one() would throw an exception if there\u0027s more than one result, why first() will just take the first one.","commit_id":"dff3d93a8b0e9d4689e908e6dbf74604c8861587"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"2937283b455db07756cf123b4c8c6ee22ebe6577","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            gre_endpoint.save(session)"},{"line_number":157,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":158,"context_line":"            gre_endpoint \u003d (session.query(GreEndpoints)."},{"line_number":159,"context_line":"                            filter_by(ip_address\u003dip).first())"},{"line_number":160,"context_line":"            LOG.warning(_LW(\"Gre endpoint with ip %s already exists\"), ip)"},{"line_number":161,"context_line":"        return gre_endpoint"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_260ef83b","line":159,"in_reply_to":"9a80dd14_264d183f","updated":"2015-03-06 11:45:43.000000000","message":"Since, IP_ADDRESS is the Primary Key, so first() is better over One() :)","commit_id":"dff3d93a8b0e9d4689e908e6dbf74604c8861587"}],"neutron/plugins/ml2/drivers/type_tunnel.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"f68cdb520d79f12668a108fcbbbe8cf9f0e1ccb2","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            if udp_port:"},{"line_number":245,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":246,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":247,"context_line":"                    driver.obj.delete_endpoint(tunnel_ip)"},{"line_number":248,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"},{"line_number":249,"context_line":"            else:"},{"line_number":250,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_f2f2276e","line":247,"updated":"2015-02-09 15:58:31.000000000","message":"There should be a check at line 244 since udp_port is taken into consideration only for vxlan not for the other type of tunnel. Also consider updating the comment at line 213 since you add a new case","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"66b180ba90f474342e74b553b30e039d3595552d","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            if udp_port:"},{"line_number":245,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":246,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":247,"context_line":"                    driver.obj.delete_endpoint(tunnel_ip)"},{"line_number":248,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"},{"line_number":249,"context_line":"            else:"},{"line_number":250,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_be3e9a27","line":247,"in_reply_to":"da86d52c_3772e811","updated":"2015-02-10 03:51:22.000000000","message":"May I know why we need to send the tunnel_delete RPC here, we don\u0027t have stale endpoint on Agent side?\n\nHere, we are just populating the neutron db with updated UDP port value, which doesn\u0027t require tunnel_delete RPC.","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"509bd8cda8d28712b7116c7c7c196f3d451343ea","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            if udp_port:"},{"line_number":245,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":246,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":247,"context_line":"                    driver.obj.delete_endpoint(tunnel_ip)"},{"line_number":248,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"},{"line_number":249,"context_line":"            else:"},{"line_number":250,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_3772e811","line":247,"in_reply_to":"da86d52c_f0cbff1b","updated":"2015-02-09 18:05:51.000000000","message":"OK...you should probably notify of tunnel deletion as done in line 240","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"337e7f8ac8a80d18856116506b9f539f91e6df20","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            if udp_port:"},{"line_number":245,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":246,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":247,"context_line":"                    driver.obj.delete_endpoint(tunnel_ip)"},{"line_number":248,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"},{"line_number":249,"context_line":"            else:"},{"line_number":250,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_f0cbff1b","line":247,"in_reply_to":"da86d52c_f2f2276e","updated":"2015-02-09 16:28:49.000000000","message":"For GRE tunnel type udp_port value will be NONE. So, we don\u0027t need to explicitly add any check for tunnel_type.","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f9e7ae15b9d018f3732a0201c7ff306c7e7f240e","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":249,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":250,"context_line":"                    driver.obj.delete_endpoint(tunnel_ip)"},{"line_number":251,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"},{"line_number":252,"context_line":"            else:"},{"line_number":253,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_d0444576","line":250,"updated":"2015-02-20 22:36:05.000000000","message":"I guess you can delete lines 252 and 253, and move line 251 out of the if clause? Just so you don\u0027t repeat the add_endpoint statement.","commit_id":"7b1dee27118806b93696eb28fc4f47dcc046b099"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"6c7a38923eb1d256c0b5a5dfc78b3038c870f3a1","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":249,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":250,"context_line":"                    driver.obj.delete_endpoint(tunnel_ip)"},{"line_number":251,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"},{"line_number":252,"context_line":"            else:"},{"line_number":253,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_d32605ba","line":250,"in_reply_to":"ba7be1f8_9d9f3e5f","updated":"2015-02-21 15:51:18.000000000","message":"Fair enough :)","commit_id":"7b1dee27118806b93696eb28fc4f47dcc046b099"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"c3951f79bdc4c573bba66d7a048f86addef62487","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":249,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":250,"context_line":"                    driver.obj.delete_endpoint(tunnel_ip)"},{"line_number":251,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"},{"line_number":252,"context_line":"            else:"},{"line_number":253,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_9d9f3e5f","line":250,"in_reply_to":"ba7be1f8_d0444576","updated":"2015-02-21 13:51:54.000000000","message":"Nope :)\n\nThis statement would be for tunnel_type VXLAN\n     tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)\n\nand this is for tunnel_type GRE and legacy mode where tunnel_sync doesn\u0027t send upd_port:\n    tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host)\n\nSince, type_gre add_endpoint method excepts only 3 arguments including self .\nhttps://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/type_gre.py#L151 \nbut here we are passing 4 arguments which would be applicable only for VXLAN case.","commit_id":"7b1dee27118806b93696eb28fc4f47dcc046b099"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88608c84b41d343b627014f7ca131603de744f68","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                    driver.obj.delete_endpoint(host_endpoint.ip_address)"},{"line_number":243,"context_line":"            # If udp_port is not passed from an agent it is a legacy mode."},{"line_number":244,"context_line":"            # If udp_port is passed for VXLAN tunnel type, check if there is"},{"line_number":245,"context_line":"            # change in UDP port value and delete the endpoint from DB and"},{"line_number":246,"context_line":"            # add the endpoint with updated UDP port value."},{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba7be1f8_c38dd0d4","line":245,"updated":"2015-02-25 16:05:37.000000000","message":"Should we instead introduce a new update_endpoint method to avoid any race conditions due to using multiple transactions?","commit_id":"91fcbaaacce4033257dbf87006be9144a254740d"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"e8425939ed749c0b97f4a911a0db49821d7cd4ff","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                    driver.obj.delete_endpoint(host_endpoint.ip_address)"},{"line_number":243,"context_line":"            # If udp_port is not passed from an agent it is a legacy mode."},{"line_number":244,"context_line":"            # If udp_port is passed for VXLAN tunnel type, check if there is"},{"line_number":245,"context_line":"            # change in UDP port value and delete the endpoint from DB and"},{"line_number":246,"context_line":"            # add the endpoint with updated UDP port value."},{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba7be1f8_6f28859a","line":245,"in_reply_to":"ba7be1f8_1480fcbe","updated":"2015-02-25 17:01:18.000000000","message":"Done","commit_id":"91fcbaaacce4033257dbf87006be9144a254740d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"792d9a26d78512f4adfc59896881bc0ad9e7c09e","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                    driver.obj.delete_endpoint(host_endpoint.ip_address)"},{"line_number":243,"context_line":"            # If udp_port is not passed from an agent it is a legacy mode."},{"line_number":244,"context_line":"            # If udp_port is passed for VXLAN tunnel type, check if there is"},{"line_number":245,"context_line":"            # change in UDP port value and delete the endpoint from DB and"},{"line_number":246,"context_line":"            # add the endpoint with updated UDP port value."},{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba7be1f8_1480fcbe","line":245,"in_reply_to":"ba7be1f8_6628b29a","updated":"2015-02-25 16:38:52.000000000","message":"I have a concern that we may end up with db conflict errors due to multiple parallel requests incoming. I know it\u0027s a corner case, but still feel we should handle it properly, without leaving place for races.","commit_id":"91fcbaaacce4033257dbf87006be9144a254740d"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"dd0834a033c9d52d0767fc901cb986d46b525927","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                    driver.obj.delete_endpoint(host_endpoint.ip_address)"},{"line_number":243,"context_line":"            # If udp_port is not passed from an agent it is a legacy mode."},{"line_number":244,"context_line":"            # If udp_port is passed for VXLAN tunnel type, check if there is"},{"line_number":245,"context_line":"            # change in UDP port value and delete the endpoint from DB and"},{"line_number":246,"context_line":"            # add the endpoint with updated UDP port value."},{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba7be1f8_6628b29a","line":245,"in_reply_to":"ba7be1f8_c38dd0d4","updated":"2015-02-25 16:31:41.000000000","message":"I am not sure how frequently users would change the UDP_PORT in the deployed  environment.\n\nSo, if we have concerns that it will not work in scale deployment. We could introduce new update_endpoint method :)\n\nPlease suggest and let me know I will address this in next patchset.","commit_id":"91fcbaaacce4033257dbf87006be9144a254740d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a6479bd6f4c090288e21e09aba872d8f4b7d8e50","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        pass"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def update_endpoint(self, ip, host\u003dNone, udp_port\u003dNone):"},{"line_number":99,"context_line":"        \"\"\"Update the endpoint in the type_driver database."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        param ip: the IP address of the endpoint"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_cfc92e7b","line":98,"updated":"2015-02-26 22:50:13.000000000","message":"Should be marked as abstractmethod","commit_id":"f0226aeaf306d6287d94938aea4b3f48cb170183"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"ebf54f94857c6d1b9b3312630c6992a03879ba4a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        pass"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def update_endpoint(self, ip, host\u003dNone, udp_port\u003dNone):"},{"line_number":99,"context_line":"        \"\"\"Update the endpoint in the type_driver database."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        param ip: the IP address of the endpoint"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_49036f76","line":98,"in_reply_to":"ba7be1f8_cfc92e7b","updated":"2015-02-27 06:26:35.000000000","message":"Done","commit_id":"f0226aeaf306d6287d94938aea4b3f48cb170183"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a6479bd6f4c090288e21e09aba872d8f4b7d8e50","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        \"\"\"Update the endpoint in the type_driver database."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        param ip: the IP address of the endpoint"},{"line_number":102,"context_line":"        param host: the Host name of the endpoint"},{"line_number":103,"context_line":"        param udp_port: udp port number for vxlan endpoint"},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_8faf3694","line":102,"updated":"2015-02-26 22:50:13.000000000","message":"Host -\u003e host","commit_id":"f0226aeaf306d6287d94938aea4b3f48cb170183"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"ebf54f94857c6d1b9b3312630c6992a03879ba4a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        \"\"\"Update the endpoint in the type_driver database."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        param ip: the IP address of the endpoint"},{"line_number":102,"context_line":"        param host: the Host name of the endpoint"},{"line_number":103,"context_line":"        param udp_port: udp port number for vxlan endpoint"},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_69083392","line":102,"in_reply_to":"ba7be1f8_8faf3694","updated":"2015-02-27 06:26:35.000000000","message":"Done","commit_id":"f0226aeaf306d6287d94938aea4b3f48cb170183"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a6479bd6f4c090288e21e09aba872d8f4b7d8e50","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        param ip: the IP address of the endpoint"},{"line_number":102,"context_line":"        param host: the Host name of the endpoint"},{"line_number":103,"context_line":"        param udp_port: udp port number for vxlan endpoint"},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        pass"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_2fa00aa5","line":103,"updated":"2015-02-26 22:50:13.000000000","message":"udp -\u003e UDP, vxlan -\u003e VXLAN","commit_id":"f0226aeaf306d6287d94938aea4b3f48cb170183"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"ebf54f94857c6d1b9b3312630c6992a03879ba4a","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        param ip: the IP address of the endpoint"},{"line_number":102,"context_line":"        param host: the Host name of the endpoint"},{"line_number":103,"context_line":"        param udp_port: udp port number for vxlan endpoint"},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        pass"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_a9022b6d","line":103,"in_reply_to":"ba7be1f8_2fa00aa5","updated":"2015-02-27 06:26:35.000000000","message":"Done","commit_id":"f0226aeaf306d6287d94938aea4b3f48cb170183"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a6479bd6f4c090288e21e09aba872d8f4b7d8e50","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":258,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":259,"context_line":"                    driver.obj.update_endpoint(tunnel_ip, udp_port)"},{"line_number":260,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"},{"line_number":261,"context_line":"            else:"},{"line_number":262,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host)"},{"line_number":263,"context_line":"            tunnels \u003d driver.obj.get_endpoints()"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_0feee6b4","line":260,"updated":"2015-02-26 22:50:13.000000000","message":"I don\u0027t follow the logic of the code. So you first update, then add the same tunnel? I now suspect that what you really need is making add_endpoint handle the case when a tunnel already exists, and if so, update it instead of adding a new one.\n\nThoughts?","commit_id":"f0226aeaf306d6287d94938aea4b3f48cb170183"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e022ea48dbe181ec21699a1ec1f3ba405dbd7e53","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":258,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":259,"context_line":"                    driver.obj.update_endpoint(tunnel_ip, udp_port)"},{"line_number":260,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"},{"line_number":261,"context_line":"            else:"},{"line_number":262,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host)"},{"line_number":263,"context_line":"            tunnels \u003d driver.obj.get_endpoints()"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_4a36f3e8","line":260,"in_reply_to":"ba7be1f8_09f17795","updated":"2015-02-27 11:36:06.000000000","message":"You still use two transactions that are racy (one to get endpoint, another one to add/update it).","commit_id":"f0226aeaf306d6287d94938aea4b3f48cb170183"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"ebf54f94857c6d1b9b3312630c6992a03879ba4a","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":258,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":259,"context_line":"                    driver.obj.update_endpoint(tunnel_ip, udp_port)"},{"line_number":260,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"},{"line_number":261,"context_line":"            else:"},{"line_number":262,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host)"},{"line_number":263,"context_line":"            tunnels \u003d driver.obj.get_endpoints()"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_09f17795","line":260,"in_reply_to":"ba7be1f8_0feee6b4","updated":"2015-02-27 06:26:35.000000000","message":"How about this:\n\n            if udp_port:\n                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)\n                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:\n                    driver.obj.update_endpoint(tunnel_ip, udp_port)\n                else:\n                    tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)\n             else:\n                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host)","commit_id":"f0226aeaf306d6287d94938aea4b3f48cb170183"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"07e9668b506b5b49ef4d98b603de8ee5dde65083","unresolved":false,"context_lines":[{"line_number":228,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"                if (ip_endpoint and ip_endpoint.host is None"},{"line_number":231,"context_line":"                    and host_endpoint is None):"},{"line_number":232,"context_line":"                    driver.obj.delete_endpoint(ip_endpoint.ip_address)"},{"line_number":233,"context_line":"                elif (ip_endpoint and ip_endpoint.host !\u003d host):"},{"line_number":234,"context_line":"                    msg \u003d (_(\"Tunnel IP %(ip)s in use with host %(host)s\"),"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_2d6719ec","line":231,"updated":"2015-02-27 12:04:33.000000000","message":"here.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"07e9668b506b5b49ef4d98b603de8ee5dde65083","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                    # Notify all other listening agents to delete stale tunnels"},{"line_number":240,"context_line":"                    self._notifier.tunnel_delete(rpc_context,"},{"line_number":241,"context_line":"                        host_endpoint.ip_address, tunnel_type)"},{"line_number":242,"context_line":"                    driver.obj.delete_endpoint(host_endpoint.ip_address)"},{"line_number":243,"context_line":"            # If udp_port is not passed from an agent it is a legacy mode."},{"line_number":244,"context_line":"            # If udp_port is passed for VXLAN tunnel type, check if there is"},{"line_number":245,"context_line":"            # change in UDP port value, update the endpoint with updated"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_8d5e4511","line":242,"updated":"2015-02-27 12:04:33.000000000","message":"here.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f085fa091d31c5b792cae419efd8540791d0fc4a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":249,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":250,"context_line":"                    tunnel \u003d driver.obj.update_vxlan_endpoint(tunnel_ip,"},{"line_number":251,"context_line":"                                                              udp_port)"},{"line_number":252,"context_line":"                else:"},{"line_number":253,"context_line":"                    tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_2aae1fe8","line":250,"updated":"2015-02-27 11:40:54.000000000","message":"As I said in prev patchset, the code is still racy (it uses two transactions to create/update tunnels).","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"07e9668b506b5b49ef4d98b603de8ee5dde65083","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":249,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":250,"context_line":"                    tunnel \u003d driver.obj.update_vxlan_endpoint(tunnel_ip,"},{"line_number":251,"context_line":"                                                              udp_port)"},{"line_number":252,"context_line":"                else:"},{"line_number":253,"context_line":"                    tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_ed6d01ce","line":250,"in_reply_to":"ba7be1f8_2aae1fe8","updated":"2015-02-27 12:04:33.000000000","message":"Sorry, I didn\u0027t get you.\nPlease share the scenario where this could happen.\n\nActually, everywhere in the code we delete the endpoint and add it again. Since, you raised this concern. Please guide me how to do that.\n\nCode snippet would be better.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1f92271bf2ed019b02d037ca9431fbd5b0842cf2","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":249,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":250,"context_line":"                    tunnel \u003d driver.obj.update_vxlan_endpoint(tunnel_ip,"},{"line_number":251,"context_line":"                                                              udp_port)"},{"line_number":252,"context_line":"                else:"},{"line_number":253,"context_line":"                    tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_fe25a55c","line":250,"in_reply_to":"ba7be1f8_3801153a","updated":"2015-02-27 13:21:59.000000000","message":"Right. Just report a bug first.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"b459c8f8bdb0c32e180d4ae0e40bfcfdf19470cb","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":249,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":250,"context_line":"                    tunnel \u003d driver.obj.update_vxlan_endpoint(tunnel_ip,"},{"line_number":251,"context_line":"                                                              udp_port)"},{"line_number":252,"context_line":"                else:"},{"line_number":253,"context_line":"                    tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_75c46b5f","line":250,"in_reply_to":"ba7be1f8_3a2102b5","updated":"2015-02-27 16:01:44.000000000","message":"Hi Ihar,\n\nCould you please explain me this:\n\n\"Now we have two endpoints for the same IP address with different ports (I guess that is not what we would expect).\"\n\n\nI feel it is impossible because IP_ADDRESS is the primary key in ml2_vxlan_endpoint tables.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"3ca5dd304a8be584bdf95016bb9cffdd4696c99c","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":249,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":250,"context_line":"                    tunnel \u003d driver.obj.update_vxlan_endpoint(tunnel_ip,"},{"line_number":251,"context_line":"                                                              udp_port)"},{"line_number":252,"context_line":"                else:"},{"line_number":253,"context_line":"                    tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_3801153a","line":250,"in_reply_to":"ba7be1f8_58ab29d6","updated":"2015-02-27 12:52:28.000000000","message":"Sounds good. Let me revert the changes and use delete_endpoint here also.\nOnce, this gets merge, we could handle this for race conditions.\n\nKindly suggests?","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ad7d9d9625dd55aade05cafd0d29e951f09d8f84","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":249,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":250,"context_line":"                    tunnel \u003d driver.obj.update_vxlan_endpoint(tunnel_ip,"},{"line_number":251,"context_line":"                                                              udp_port)"},{"line_number":252,"context_line":"                else:"},{"line_number":253,"context_line":"                    tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_309201a0","line":250,"in_reply_to":"ba7be1f8_75c46b5f","updated":"2015-02-27 16:11:57.000000000","message":"Hmmm. Indeed. It also seems that add_entrypoint has a special handling for duplicates, when it returns the existing one.\n\nIn that case, the only race scenario I can think of is when multiple update requests are incoming, and only the one is served. Though it would be impossible to handle the case keeping in mind that the order of messages is undetermined.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"277354ee572242718ca40ae9c771ea422e2c37fa","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":249,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":250,"context_line":"                    tunnel \u003d driver.obj.update_vxlan_endpoint(tunnel_ip,"},{"line_number":251,"context_line":"                                                              udp_port)"},{"line_number":252,"context_line":"                else:"},{"line_number":253,"context_line":"                    tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_58ab29d6","line":250,"in_reply_to":"ba7be1f8_ed6d01ce","updated":"2015-02-27 12:33:26.000000000","message":"Consider two threads (A and B), each receiving tunnel_sync with udp_port set to A_PORT and B_PORT. The race scenario is:\n\n- A checks whether tunnel exists and receives nothing.\n- B checks whether tunnel exists and receives nothing.\n- A adds endpoint with A_PORT.\n- B adds endpoint with B_PORT.\n\nNow we have two endpoints for the same IP address with different ports (I guess that is not what we would expect).\n\nI think the only way to avoid it is check for tunnel existence under the same transaction that will update it, if present. Probably meaning, making add_endpoint aware of potential tunnel existence.\n\nBTW I agree the code above looks racy too. Maybe the race should be handled in a separate patch (you may report a bug and assign it to me if you don\u0027t feel like doing it).","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"f83681adc14d73deef2aa57f9ec9992cf5a05deb","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            if udp_port:"},{"line_number":248,"context_line":"                ip_endpoint \u003d driver.obj.get_endpoint_by_ip(tunnel_ip)"},{"line_number":249,"context_line":"                if ip_endpoint and ip_endpoint.udp_port !\u003d udp_port:"},{"line_number":250,"context_line":"                    tunnel \u003d driver.obj.update_vxlan_endpoint(tunnel_ip,"},{"line_number":251,"context_line":"                                                              udp_port)"},{"line_number":252,"context_line":"                else:"},{"line_number":253,"context_line":"                    tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_3a2102b5","line":250,"in_reply_to":"ba7be1f8_fe25a55c","updated":"2015-02-27 15:51:10.000000000","message":"Done","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"526f834c6aaafd95d52957ca27e1b4a41ca7dea9","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            msg \u003d _(\"Network type value needed by the ML2 plugin\")"},{"line_number":207,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        udp_port \u003d kwargs.get(\u0027udp_port\u0027)"},{"line_number":210,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":211,"context_line":"        driver \u003d self._type_manager.drivers.get(tunnel_type)"},{"line_number":212,"context_line":"        if driver:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_31365453","line":209,"updated":"2015-03-12 08:29:58.000000000","message":"how about:\nudp_port \u003d kwargs.get(\u0027udp_port\u0027, 4789)\n\nand remove the conditional in L247.","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"e537b04786bfceaa81843865d38370f1f7d4ceea","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            msg \u003d _(\"Network type value needed by the ML2 plugin\")"},{"line_number":207,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        udp_port \u003d kwargs.get(\u0027udp_port\u0027)"},{"line_number":210,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":211,"context_line":"        driver \u003d self._type_manager.drivers.get(tunnel_type)"},{"line_number":212,"context_line":"        if driver:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_b4c4f240","line":209,"in_reply_to":"9a80dd14_31365453","updated":"2015-03-12 08:46:31.000000000","message":"It is only for VXLAN not for GRE.","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"fbb5416620187f02adf2faeaee6a4ad1bdace760","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            msg \u003d _(\"Network type value needed by the ML2 plugin\")"},{"line_number":207,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        udp_port \u003d kwargs.get(\u0027udp_port\u0027)"},{"line_number":210,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":211,"context_line":"        driver \u003d self._type_manager.drivers.get(tunnel_type)"},{"line_number":212,"context_line":"        if driver:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_74251ac1","line":209,"in_reply_to":"9a80dd14_b4c4f240","updated":"2015-03-12 09:00:14.000000000","message":"ok","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"2bf05bbd6931fe3dc784f21dddf3c640f6078b35","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                    self._notifier.tunnel_delete(rpc_context,"},{"line_number":241,"context_line":"                        host_endpoint.ip_address, tunnel_type)"},{"line_number":242,"context_line":"                    driver.obj.delete_endpoint(host_endpoint.ip_address)"},{"line_number":243,"context_line":"            # If udp_port is not passed from an agent it is a legacy mode."},{"line_number":244,"context_line":"            # If udp_port is passed for VXLAN tunnel type, check if there is"},{"line_number":245,"context_line":"            # change in UDP port value, delete the endpoint from DB and"},{"line_number":246,"context_line":"            # add the endpoint with updated UDP port value."}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_a148fb2d","line":243,"updated":"2015-03-19 12:07:26.000000000","message":"I think this code inside a generic tunnel class is confusing, you could pass the args to the add_endpoint and handle this logic inside the VXLAN driver\n(Future tunnel types might also have additional parameters)\n\n(or even add a specific tunnel args structure as i think was suggested, but that can wait for another changeset)\n\nBy doing that you also dont need the above \"udp_port \u003d ....\" statment","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"fb4ef16cbf8b4c4f20007db23be3be8d6ee70770","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                    self._notifier.tunnel_delete(rpc_context,"},{"line_number":241,"context_line":"                        host_endpoint.ip_address, tunnel_type)"},{"line_number":242,"context_line":"                    driver.obj.delete_endpoint(host_endpoint.ip_address)"},{"line_number":243,"context_line":"            # If udp_port is not passed from an agent it is a legacy mode."},{"line_number":244,"context_line":"            # If udp_port is passed for VXLAN tunnel type, check if there is"},{"line_number":245,"context_line":"            # change in UDP port value, delete the endpoint from DB and"},{"line_number":246,"context_line":"            # add the endpoint with updated UDP port value."}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_73e334d8","line":243,"in_reply_to":"9a80dd14_53ee3023","updated":"2015-03-19 13:08:28.000000000","message":"@Romil: No problem, please open a bug to fix this and assign it to me, i will gladly help with this\n\nI will remove my -1","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"bf8f94a663dd74ce2aaddcdbb37924aa14c022ab","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                    self._notifier.tunnel_delete(rpc_context,"},{"line_number":241,"context_line":"                        host_endpoint.ip_address, tunnel_type)"},{"line_number":242,"context_line":"                    driver.obj.delete_endpoint(host_endpoint.ip_address)"},{"line_number":243,"context_line":"            # If udp_port is not passed from an agent it is a legacy mode."},{"line_number":244,"context_line":"            # If udp_port is passed for VXLAN tunnel type, check if there is"},{"line_number":245,"context_line":"            # change in UDP port value, delete the endpoint from DB and"},{"line_number":246,"context_line":"            # add the endpoint with updated UDP port value."}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_d7c12d4f","line":243,"in_reply_to":"9a80dd14_610e038e","updated":"2015-03-19 12:47:47.000000000","message":"I would change the add_endpoint method signature and pass it with kwargs (it will be used inside the VXLAN driver (or ignored in case of GRE and the other tunnels)\n\n(a better solution would be to pass specific tunnel args structure from kwargs but that is a future enhancement, i wouldn\u0027t do it in this path)","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"15e30d6e900244ca303c87555fa3f118b35a85e8","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                    self._notifier.tunnel_delete(rpc_context,"},{"line_number":241,"context_line":"                        host_endpoint.ip_address, tunnel_type)"},{"line_number":242,"context_line":"                    driver.obj.delete_endpoint(host_endpoint.ip_address)"},{"line_number":243,"context_line":"            # If udp_port is not passed from an agent it is a legacy mode."},{"line_number":244,"context_line":"            # If udp_port is passed for VXLAN tunnel type, check if there is"},{"line_number":245,"context_line":"            # change in UDP port value, delete the endpoint from DB and"},{"line_number":246,"context_line":"            # add the endpoint with updated UDP port value."}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_53c1d0e2","line":243,"in_reply_to":"9a80dd14_73e334d8","updated":"2015-03-19 13:14:44.000000000","message":"@Gal: Sure, I will do, it would be great if we could work together.\n\nThanks :)","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"a22a7be937bd0abca31e0346b0b4209cd3865be3","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                    self._notifier.tunnel_delete(rpc_context,"},{"line_number":241,"context_line":"                        host_endpoint.ip_address, tunnel_type)"},{"line_number":242,"context_line":"                    driver.obj.delete_endpoint(host_endpoint.ip_address)"},{"line_number":243,"context_line":"            # If udp_port is not passed from an agent it is a legacy mode."},{"line_number":244,"context_line":"            # If udp_port is passed for VXLAN tunnel type, check if there is"},{"line_number":245,"context_line":"            # change in UDP port value, delete the endpoint from DB and"},{"line_number":246,"context_line":"            # add the endpoint with updated UDP port value."}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_610e038e","line":243,"in_reply_to":"9a80dd14_a148fb2d","updated":"2015-03-19 12:15:49.000000000","message":"In that case, we may need to check for tunnel_types:\n\nif tunnel_type\u003d\u003d\u0027vxlan\u0027\n  tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)\nelse:\n  tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host)\n\n\nWould it be fine???","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"b8b9c3611e8d1cc11084a94224cab897256007f7","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                    self._notifier.tunnel_delete(rpc_context,"},{"line_number":241,"context_line":"                        host_endpoint.ip_address, tunnel_type)"},{"line_number":242,"context_line":"                    driver.obj.delete_endpoint(host_endpoint.ip_address)"},{"line_number":243,"context_line":"            # If udp_port is not passed from an agent it is a legacy mode."},{"line_number":244,"context_line":"            # If udp_port is passed for VXLAN tunnel type, check if there is"},{"line_number":245,"context_line":"            # change in UDP port value, delete the endpoint from DB and"},{"line_number":246,"context_line":"            # add the endpoint with updated UDP port value."}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_f7dd5115","line":243,"in_reply_to":"9a80dd14_d7c12d4f","updated":"2015-03-19 12:49:54.000000000","message":"So here you only have:\n\ntunnel \u003d driver.obj.add_endpoint(tunnep_ip, host, kwargs)\n\nand handle this structure inside any driver that needs it","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"7e453721688df0ad2ec6d4b9357fc4d45089b489","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                    self._notifier.tunnel_delete(rpc_context,"},{"line_number":241,"context_line":"                        host_endpoint.ip_address, tunnel_type)"},{"line_number":242,"context_line":"                    driver.obj.delete_endpoint(host_endpoint.ip_address)"},{"line_number":243,"context_line":"            # If udp_port is not passed from an agent it is a legacy mode."},{"line_number":244,"context_line":"            # If udp_port is passed for VXLAN tunnel type, check if there is"},{"line_number":245,"context_line":"            # change in UDP port value, delete the endpoint from DB and"},{"line_number":246,"context_line":"            # add the endpoint with updated UDP port value."}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_53ee3023","line":243,"in_reply_to":"9a80dd14_f7dd5115","updated":"2015-03-19 13:01:24.000000000","message":"@Gal: Let\u0027s not insist me to put unnecessary effort, let this patchset go AS-IS and later on we could enhance the add_endpoint like this:\n\n      tunnel \u003d driver.obj.add_endpoint(**kwargs)\n\nWhat do you think?","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"526f834c6aaafd95d52957ca27e1b4a41ca7dea9","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            entry \u003d {\u0027tunnels\u0027: tunnels}"},{"line_number":256,"context_line":"            # Notify all other listening agents"},{"line_number":257,"context_line":"            self._notifier.tunnel_update(rpc_context, tunnel.ip_address,"},{"line_number":258,"context_line":"                                         tunnel_type)"},{"line_number":259,"context_line":"            # Return the list of tunnels IP\u0027s to the agent"},{"line_number":260,"context_line":"            return entry"},{"line_number":261,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_518748d7","line":258,"updated":"2015-03-12 08:29:58.000000000","message":"what\u0027s the plain for tunnel_update?","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"57c5c36dd8dffb03a4f3c82183f1602f211bbbf7","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            entry \u003d {\u0027tunnels\u0027: tunnels}"},{"line_number":256,"context_line":"            # Notify all other listening agents"},{"line_number":257,"context_line":"            self._notifier.tunnel_update(rpc_context, tunnel.ip_address,"},{"line_number":258,"context_line":"                                         tunnel_type)"},{"line_number":259,"context_line":"            # Return the list of tunnels IP\u0027s to the agent"},{"line_number":260,"context_line":"            return entry"},{"line_number":261,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_5a02fd6f","line":258,"in_reply_to":"9a80dd14_1fa5d7b4","updated":"2015-03-12 09:43:56.000000000","message":"Hi Yamamoto,\n\nThis is the agent side tunnel_sync and tunnel_update methods:\n\n    def tunnel_sync(self):\n        try:\n            for tunnel_type in self.tunnel_types:\n                details \u003d self.plugin_rpc.tunnel_sync(self.context,\n                                                      self.local_ip,\n                                                      tunnel_type,\n                                                      cfg.CONF.host)\n                if not self.l2_pop:\n                    tunnels \u003d details[\u0027tunnels\u0027]\n                    for tunnel in tunnels:\n                        if self.local_ip !\u003d tunnel[\u0027ip_address\u0027]:\n                            remote_ip \u003d tunnel[\u0027ip_address\u0027]\n                            remote_ip_hex \u003d self.get_ip_in_hex(remote_ip)\n                            if not remote_ip_hex:\n                                continue\n                            tun_name \u003d \u0027%s-%s\u0027 % (tunnel_type, remote_ip_hex)\n                            self._setup_tunnel_port(self.tun_br,\n                                                    tun_name,\n                                                    tunnel[\u0027ip_address\u0027],\n                                                    tunnel_type)\n\n    def tunnel_update(self, context, **kwargs):\n        LOG.debug(\"tunnel_update received\")\n        if not self.enable_tunneling:\n            return\n        tunnel_ip \u003d kwargs.get(\u0027tunnel_ip\u0027)\n        tunnel_ip_hex \u003d self.get_ip_in_hex(tunnel_ip)\n        if not tunnel_ip_hex:\n            return\n        tunnel_type \u003d kwargs.get(\u0027tunnel_type\u0027)\n        if not tunnel_type:\n            LOG.error(_LE(\"No tunnel_type specified, cannot create tunnels\"))\n            return\n        if tunnel_type not in self.tunnel_types:\n            LOG.error(_LE(\"tunnel_type %s not supported by agent\"),\n                      tunnel_type)\n            return\n        if tunnel_ip \u003d\u003d self.local_ip:\n            return\n        tun_name \u003d \u0027%s-%s\u0027 % (tunnel_type, tunnel_ip_hex)\n        if not self.l2_pop:\n            self._setup_tunnel_port(self.tun_br, tun_name, tunnel_ip,\n                                    tunnel_type)\n\nHere, in both the methods we  call _setup_tunnel_port()\n\n    def _setup_tunnel_port(self, br, port_name, remote_ip, tunnel_type):\n        ofport \u003d br.add_tunnel_port(port_name,\n                                    remote_ip,\n                                    self.local_ip,\n                                    tunnel_type,\n                                    self.vxlan_udp_port,\n                                    self.dont_fragment)\n\nThis _setup_tunnel_port uses the udp_port_value configured in its agent. \n\nNow, can you please educate me, Do we really need to send the upd_port value as part of tunnel_update and tunnel_sync to make the agents tweak it\u0027s tunneling accordingly???","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"6456fe00fc9c1e634a20d65a58a9806389ca89df","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            entry \u003d {\u0027tunnels\u0027: tunnels}"},{"line_number":256,"context_line":"            # Notify all other listening agents"},{"line_number":257,"context_line":"            self._notifier.tunnel_update(rpc_context, tunnel.ip_address,"},{"line_number":258,"context_line":"                                         tunnel_type)"},{"line_number":259,"context_line":"            # Return the list of tunnels IP\u0027s to the agent"},{"line_number":260,"context_line":"            return entry"},{"line_number":261,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_04fb50c1","line":258,"in_reply_to":"9a80dd14_373fe988","updated":"2015-03-16 06:22:50.000000000","message":"Good question, Since Neutron server is our controller and it should have correct values configured by l2 agents. \n\nNow, if you think that we don\u0027t use udp_port values populated in ml2_vxlan_endpoint table then why do we have this field in the table???\n\n(IP, Host) fields are more than enough.","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"e537b04786bfceaa81843865d38370f1f7d4ceea","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            entry \u003d {\u0027tunnels\u0027: tunnels}"},{"line_number":256,"context_line":"            # Notify all other listening agents"},{"line_number":257,"context_line":"            self._notifier.tunnel_update(rpc_context, tunnel.ip_address,"},{"line_number":258,"context_line":"                                         tunnel_type)"},{"line_number":259,"context_line":"            # Return the list of tunnels IP\u0027s to the agent"},{"line_number":260,"context_line":"            return entry"},{"line_number":261,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_54ebb6af","line":258,"in_reply_to":"9a80dd14_518748d7","updated":"2015-03-12 08:46:31.000000000","message":"Kindly, let me know what we need to do for the tunnel_update?","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"fbb5416620187f02adf2faeaee6a4ad1bdace760","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            entry \u003d {\u0027tunnels\u0027: tunnels}"},{"line_number":256,"context_line":"            # Notify all other listening agents"},{"line_number":257,"context_line":"            self._notifier.tunnel_update(rpc_context, tunnel.ip_address,"},{"line_number":258,"context_line":"                                         tunnel_type)"},{"line_number":259,"context_line":"            # Return the list of tunnels IP\u0027s to the agent"},{"line_number":260,"context_line":"            return entry"},{"line_number":261,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_740c3a43","line":258,"in_reply_to":"9a80dd14_54ebb6af","updated":"2015-03-12 09:00:14.000000000","message":"how could this change be useful without notifying agent?\ncan you explain what\u0027s your purpose?\ni thought it was to make agents tweak it\u0027s tunneling accordingly.","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"16737853234376564175003c4ddd7d303507fa51","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            entry \u003d {\u0027tunnels\u0027: tunnels}"},{"line_number":256,"context_line":"            # Notify all other listening agents"},{"line_number":257,"context_line":"            self._notifier.tunnel_update(rpc_context, tunnel.ip_address,"},{"line_number":258,"context_line":"                                         tunnel_type)"},{"line_number":259,"context_line":"            # Return the list of tunnels IP\u0027s to the agent"},{"line_number":260,"context_line":"            return entry"},{"line_number":261,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_373fe988","line":258,"in_reply_to":"9a80dd14_5a02fd6f","updated":"2015-03-13 09:48:42.000000000","message":"when i made the comment,\ni thought your purpose was to make it specificy the remote port.\nif i was wrong, it\u0027s ok.  sorry for noise.\n\nhowever, i\u0027m still not sure what\u0027s the purpose of this change.\nyou said you want to put the correct values in the endpoint table.\nmy question is that what you will use the correct port values for.","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"8c9f7bf26961a4da22607c6a84f1bd8519911438","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            entry \u003d {\u0027tunnels\u0027: tunnels}"},{"line_number":256,"context_line":"            # Notify all other listening agents"},{"line_number":257,"context_line":"            self._notifier.tunnel_update(rpc_context, tunnel.ip_address,"},{"line_number":258,"context_line":"                                         tunnel_type)"},{"line_number":259,"context_line":"            # Return the list of tunnels IP\u0027s to the agent"},{"line_number":260,"context_line":"            return entry"},{"line_number":261,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_1fa5d7b4","line":258,"in_reply_to":"9a80dd14_740c3a43","updated":"2015-03-12 09:11:00.000000000","message":"The purpose of this patchset is to populate the ml2_vxlan_endpoint table with correct UDP port value based on agent configurations.\n\nProbably, I will try to do the agent side changes if required.\n\nThanks for raising this concern :)","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"526f834c6aaafd95d52957ca27e1b4a41ca7dea9","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            # Notify all other listening agents"},{"line_number":257,"context_line":"            self._notifier.tunnel_update(rpc_context, tunnel.ip_address,"},{"line_number":258,"context_line":"                                         tunnel_type)"},{"line_number":259,"context_line":"            # Return the list of tunnels IP\u0027s to the agent"},{"line_number":260,"context_line":"            return entry"},{"line_number":261,"context_line":"        else:"},{"line_number":262,"context_line":"            msg \u003d _(\"Network type value \u0027%s\u0027 not supported\") % tunnel_type"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_f1c75c10","line":259,"updated":"2015-03-12 08:29:58.000000000","message":"what\u0027s the plan for agent side?","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"fbb5416620187f02adf2faeaee6a4ad1bdace760","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            # Notify all other listening agents"},{"line_number":257,"context_line":"            self._notifier.tunnel_update(rpc_context, tunnel.ip_address,"},{"line_number":258,"context_line":"                                         tunnel_type)"},{"line_number":259,"context_line":"            # Return the list of tunnels IP\u0027s to the agent"},{"line_number":260,"context_line":"            return entry"},{"line_number":261,"context_line":"        else:"},{"line_number":262,"context_line":"            msg \u003d _(\"Network type value \u0027%s\u0027 not supported\") % tunnel_type"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_9f3547dd","line":259,"in_reply_to":"9a80dd14_d4bfa6a8","updated":"2015-03-12 09:00:14.000000000","message":"same as above.","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"e537b04786bfceaa81843865d38370f1f7d4ceea","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            # Notify all other listening agents"},{"line_number":257,"context_line":"            self._notifier.tunnel_update(rpc_context, tunnel.ip_address,"},{"line_number":258,"context_line":"                                         tunnel_type)"},{"line_number":259,"context_line":"            # Return the list of tunnels IP\u0027s to the agent"},{"line_number":260,"context_line":"            return entry"},{"line_number":261,"context_line":"        else:"},{"line_number":262,"context_line":"            msg \u003d _(\"Network type value \u0027%s\u0027 not supported\") % tunnel_type"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_d4bfa6a8","line":259,"in_reply_to":"9a80dd14_f1c75c10","updated":"2015-03-12 08:46:31.000000000","message":"Kindly, let me know what we need to do for the agent side changes for UDP port change?","commit_id":"25348e630f12e46f998b9f1441c6d3964e03dde8"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"998016449da197864a5ebd21adf25edc43013143","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        param ip: the IP address of the endpoint"},{"line_number":52,"context_line":"        param host: the host name of the endpoint"},{"line_number":53,"context_line":"        param udp_port: UDP port number for VXLAN endpoint"},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        pass"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa963961_c43f3c24","line":53,"updated":"2015-03-26 20:39:57.000000000","message":"Might need to create a new class that inherits from this, to expose a tunnel type that uses the UDP protocol and a port #? Mostly because even if we change the kwarg from udp_port -\u003e port, what about L2TP?","commit_id":"4a6743955860f7daf3b5fb2a4d7613afcc0dd249"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"af5954655d0cd56877036ba26dfa4f826914790a","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        param ip: the IP address of the endpoint"},{"line_number":52,"context_line":"        param host: the host name of the endpoint"},{"line_number":53,"context_line":"        param udp_port: UDP port number for VXLAN endpoint"},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        pass"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa963961_7fcb6873","line":53,"updated":"2015-03-26 16:33:29.000000000","message":"should we really pollute this base contract with a specific tunneling technology? I\u0027d be tempted to say \u0027no\u0027.","commit_id":"4a6743955860f7daf3b5fb2a4d7613afcc0dd249"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"3c9772dfb3432ae102388d31c8297430c979111c","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        param ip: the IP address of the endpoint"},{"line_number":52,"context_line":"        param host: the host name of the endpoint"},{"line_number":53,"context_line":"        param udp_port: UDP port number for VXLAN endpoint"},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        pass"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa963961_888ff422","line":53,"in_reply_to":"fa963961_05262dce","updated":"2015-03-27 12:18:12.000000000","message":"@Armando: Reference link for the discussion we had at PS20:\n\nhttps://review.openstack.org/#/c/153891/17/neutron/plugins/ml2/drivers/type_tunnel.py\n\nPlease, let us know what needs to be done. \nThis patchset has already gone various review cycle.","commit_id":"4a6743955860f7daf3b5fb2a4d7613afcc0dd249"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d981700ffe44d851b80f5cd8ffb07b9896f093bc","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        param ip: the IP address of the endpoint"},{"line_number":52,"context_line":"        param host: the host name of the endpoint"},{"line_number":53,"context_line":"        param udp_port: UDP port number for VXLAN endpoint"},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        pass"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa963961_bfeb30b0","line":53,"in_reply_to":"fa963961_7fcb6873","updated":"2015-03-26 16:34:56.000000000","message":"Maybe we can keep it generic enough that this can be useful not just for VXLAN?","commit_id":"4a6743955860f7daf3b5fb2a4d7613afcc0dd249"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"3a5bd9fec97188ea5394693d195d45a80a9b5a5c","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        param ip: the IP address of the endpoint"},{"line_number":52,"context_line":"        param host: the host name of the endpoint"},{"line_number":53,"context_line":"        param udp_port: UDP port number for VXLAN endpoint"},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        pass"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa963961_05262dce","line":53,"in_reply_to":"fa963961_c43f3c24","updated":"2015-03-27 11:56:43.000000000","message":"I was proposing in previous patch sets that a tunnel specific args structure should be used as the last parameter, that way specific tunnel data can be used and handled in the specific driver.\n\nFor now, the entire kwargs can be used to call the driver and have that logic implemented inside the VXLAN driver\n(I don\u0027t mind filling a bug and fixing this after Romil submit this patch, unless he will fix it here)","commit_id":"4a6743955860f7daf3b5fb2a4d7613afcc0dd249"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"af5954655d0cd56877036ba26dfa4f826914790a","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                        host_endpoint.ip_address, tunnel_type)"},{"line_number":255,"context_line":"                    driver.obj.delete_endpoint(host_endpoint.ip_address)"},{"line_number":256,"context_line":"            # If udp_port is not passed from an agent it is a legacy mode."},{"line_number":257,"context_line":"            # If udp_port is passed for VXLAN tunnel type, check if there is"},{"line_number":258,"context_line":"            # change in UDP port value, delete the endpoint from DB and"},{"line_number":259,"context_line":"            # add the endpoint with updated UDP port value."},{"line_number":260,"context_line":"            if udp_port:"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa963961_3f9cc068","line":257,"updated":"2015-03-26 16:33:29.000000000","message":"not sure if we can pollute this here.","commit_id":"4a6743955860f7daf3b5fb2a4d7613afcc0dd249"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"3a5bd9fec97188ea5394693d195d45a80a9b5a5c","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                        host_endpoint.ip_address, tunnel_type)"},{"line_number":255,"context_line":"                    driver.obj.delete_endpoint(host_endpoint.ip_address)"},{"line_number":256,"context_line":"            # If udp_port is not passed from an agent it is a legacy mode."},{"line_number":257,"context_line":"            # If udp_port is passed for VXLAN tunnel type, check if there is"},{"line_number":258,"context_line":"            # change in UDP port value, delete the endpoint from DB and"},{"line_number":259,"context_line":"            # add the endpoint with updated UDP port value."},{"line_number":260,"context_line":"            if udp_port:"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa963961_8518fd85","line":257,"in_reply_to":"fa963961_3f9cc068","updated":"2015-03-27 11:56:43.000000000","message":"My comment above would solve this by calling this:\n\ntunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, kwargs)\n\n(UDP port specific code inside VXLAN driver)\n\n(partial solution until a specific tunnel args structure is introduced )","commit_id":"4a6743955860f7daf3b5fb2a4d7613afcc0dd249"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"7bfd6a724215293877a64f9620d0fe18ed56583d","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                    driver.obj.delete_endpoint(ip_endpoint.ip_address)"},{"line_number":387,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host, udp_port)"},{"line_number":388,"context_line":"            else:"},{"line_number":389,"context_line":"                tunnel \u003d driver.obj.add_endpoint(tunnel_ip, host)"},{"line_number":390,"context_line":"            tunnels \u003d driver.obj.get_endpoints()"},{"line_number":391,"context_line":"            entry \u003d {\u0027tunnels\u0027: tunnels}"},{"line_number":392,"context_line":"            # Notify all other listening agents"}],"source_content_type":"text/x-python","patch_set":23,"id":"9abb7d3a_65bde0b6","line":389,"updated":"2016-05-31 14:11:13.000000000","message":"This patchset is mostly a rebase/cleanup of the previous one.\nThis piece of code could go indeed in add_endpoint() with additional kwargs argument. Should it go in this patchset, or a follow-up patch?","commit_id":"34057389d4177d43f81b99234f8f4a1c926c0ef0"}],"neutron/plugins/ml2/drivers/type_vxlan.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a6479bd6f4c090288e21e09aba872d8f4b7d8e50","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":176,"context_line":"            session.query(VxlanEndpoints).filter_by(ip_address\u003dip).delete()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def update_endpoint(self, ip, udp_port):"},{"line_number":179,"context_line":"        LOG.debug(\"update_vxlan_endpoint() called for ip %s\", ip)"},{"line_number":180,"context_line":"        session \u003d db_api.get_session()"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_8f865612","line":178,"updated":"2015-02-26 22:50:13.000000000","message":"method signature is different from the one defined in base class.","commit_id":"f0226aeaf306d6287d94938aea4b3f48cb170183"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"ebf54f94857c6d1b9b3312630c6992a03879ba4a","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":176,"context_line":"            session.query(VxlanEndpoints).filter_by(ip_address\u003dip).delete()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def update_endpoint(self, ip, udp_port):"},{"line_number":179,"context_line":"        LOG.debug(\"update_vxlan_endpoint() called for ip %s\", ip)"},{"line_number":180,"context_line":"        session \u003d db_api.get_session()"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_a9878bd6","line":178,"in_reply_to":"ba7be1f8_8f865612","updated":"2015-02-27 06:26:35.000000000","message":"Done","commit_id":"f0226aeaf306d6287d94938aea4b3f48cb170183"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f085fa091d31c5b792cae419efd8540791d0fc4a","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            vxlan_endpoint.save(session)"},{"line_number":165,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":166,"context_line":"            vxlan_endpoint \u003d (session.query(VxlanEndpoints)."},{"line_number":167,"context_line":"                              filter_by(ip_address\u003dip).first())"},{"line_number":168,"context_line":"            LOG.warning(_LW(\"Vxlan endpoint with ip %s already exists\"), ip)"},{"line_number":169,"context_line":"        return vxlan_endpoint"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_aa812f4f","line":167,"updated":"2015-02-27 11:40:54.000000000","message":"Can you elaborate why the change?","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"07e9668b506b5b49ef4d98b603de8ee5dde65083","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            vxlan_endpoint.save(session)"},{"line_number":165,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":166,"context_line":"            vxlan_endpoint \u003d (session.query(VxlanEndpoints)."},{"line_number":167,"context_line":"                              filter_by(ip_address\u003dip).first())"},{"line_number":168,"context_line":"            LOG.warning(_LW(\"Vxlan endpoint with ip %s already exists\"), ip)"},{"line_number":169,"context_line":"        return vxlan_endpoint"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_6db8312b","line":167,"in_reply_to":"ba7be1f8_aa812f4f","updated":"2015-02-27 12:04:33.000000000","message":"See my comments in type_gre.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7cc069143d12c63a4097454887afe575edd54088","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"VXLAN_UDP_PORT \u003d 4789"},{"line_number":33,"context_line":"MAX_VXLAN_VNI \u003d 16777215"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"vxlan_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":13,"id":"9a80dd14_b4c17b30","side":"PARENT","line":32,"updated":"2015-03-05 07:30:46.000000000","message":"this could be put into another patch set which may make the review process a little quicker. It is unrelated to this patch","commit_id":"7cd356964cb45509994c98c9933452786a485aae"},{"author":{"_account_id":14838,"name":"Gandharva","email":"gandharva666@gmail.com","username":"Gandharva"},"change_message_id":"d8bfc1a6efce6a0e719ab70b6d155bef75d8583f","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"VXLAN_UDP_PORT \u003d 4789"},{"line_number":33,"context_line":"MAX_VXLAN_VNI \u003d 16777215"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"vxlan_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":13,"id":"9a80dd14_e894f438","side":"PARENT","line":32,"in_reply_to":"9a80dd14_179a4963","updated":"2015-03-05 08:59:28.000000000","message":"I agree with Romil :-) Its unnecessary to keep this simple changes in another patch.","commit_id":"7cd356964cb45509994c98c9933452786a485aae"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"454cf3d13d5b04496dd9af08c119e229b045c8b7","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"VXLAN_UDP_PORT \u003d 4789"},{"line_number":33,"context_line":"MAX_VXLAN_VNI \u003d 16777215"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"vxlan_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":13,"id":"9a80dd14_179a4963","side":"PARENT","line":32,"in_reply_to":"9a80dd14_b4c17b30","updated":"2015-03-05 07:52:41.000000000","message":"Please, don\u0027t be rigid for this :)\n\nThese are all just nit changes and I don\u0027t feel requires separate review. It would be very difficult for a developer(especially for me) to maintain in their workspace.\n\nAlso, I have mentioned this in the commit message explicitly. \n\nHope you understand.","commit_id":"7cd356964cb45509994c98c9933452786a485aae"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"27e2e49142d929d6432fc6454ec9848b43fc0a9c","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            vxlan_endpoint.save(session)"},{"line_number":165,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":166,"context_line":"            vxlan_endpoint \u003d (session.query(VxlanEndpoints)."},{"line_number":167,"context_line":"                              filter_by(ip_address\u003dip).first())"},{"line_number":168,"context_line":"            LOG.warning(_LW(\"Vxlan endpoint with ip %s already exists\"), ip)"},{"line_number":169,"context_line":"        return vxlan_endpoint"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_e6b22005","line":167,"updated":"2015-03-06 11:37:19.000000000","message":"ditto","commit_id":"dff3d93a8b0e9d4689e908e6dbf74604c8861587"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"814df9b4f9b79830f99c831e189e3d50b0ee4708","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        return (session.query(VxlanEndpoints)."},{"line_number":156,"context_line":"                filter_by(ip_address\u003dip).first())"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def add_endpoint(self, ip, host, udp_port\u003dp_const.VXLAN_UDP_PORT):"},{"line_number":159,"context_line":"        LOG.debug(\"add_vxlan_endpoint() called for ip %s\", ip)"},{"line_number":160,"context_line":"        session \u003d db_api.get_session()"},{"line_number":161,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a6ced46_42eef723","line":158,"updated":"2015-03-22 23:06:13.000000000","message":"as a part of the \"useful refactoring\" you could have brought these constants in neutron.common.constants, but it\u0027s not important","commit_id":"3e917c3227ffad56257badf8926ef29ccad702b3"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"d39ed8e9bbc56855d61937f68cfecd7d7ceec39e","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        return (session.query(VxlanEndpoints)."},{"line_number":156,"context_line":"                filter_by(ip_address\u003dip).first())"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def add_endpoint(self, ip, host, udp_port\u003dp_const.VXLAN_UDP_PORT):"},{"line_number":159,"context_line":"        LOG.debug(\"add_vxlan_endpoint() called for ip %s\", ip)"},{"line_number":160,"context_line":"        session \u003d db_api.get_session()"},{"line_number":161,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a6ced46_5b689ef5","line":158,"in_reply_to":"1a6ced46_42eef723","updated":"2015-03-23 04:56:43.000000000","message":"Sure, I like the idea, I will do it.","commit_id":"3e917c3227ffad56257badf8926ef29ccad702b3"}],"neutron/plugins/ml2/rpc.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"f68cdb520d79f12668a108fcbbbe8cf9f0e1ccb2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    #   1.3 get_device_details rpc signature upgrade to obtain \u0027host\u0027 and"},{"line_number":46,"context_line":"    #       return value to include fixed_ips and device_owner for"},{"line_number":47,"context_line":"    #       the device port"},{"line_number":48,"context_line":"    #   1.4 tunnel_sync rpc signature upgrade to obtain \u0027host\u0027 and \u0027udp_port\u0027"},{"line_number":49,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.4\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def __init__(self, notifier, type_manager):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_ffc030e2","line":48,"updated":"2015-02-09 15:58:31.000000000","message":"ditto, version needs to be bumped","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"337e7f8ac8a80d18856116506b9f539f91e6df20","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    #   1.3 get_device_details rpc signature upgrade to obtain \u0027host\u0027 and"},{"line_number":46,"context_line":"    #       return value to include fixed_ips and device_owner for"},{"line_number":47,"context_line":"    #       the device port"},{"line_number":48,"context_line":"    #   1.4 tunnel_sync rpc signature upgrade to obtain \u0027host\u0027 and \u0027udp_port\u0027"},{"line_number":49,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.4\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def __init__(self, notifier, type_manager):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_50012b38","line":48,"in_reply_to":"da86d52c_ffc030e2","updated":"2015-02-09 16:28:49.000000000","message":"ditto","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"}],"neutron/plugins/ofagent/agent/ofa_neutron_agent.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f9e7ae15b9d018f3732a0201c7ff306c7e7f240e","unresolved":false,"context_lines":[{"line_number":784,"context_line":"    def tunnel_sync(self):"},{"line_number":785,"context_line":"        resync \u003d False"},{"line_number":786,"context_line":"        try:"},{"line_number":787,"context_line":"            for tunnel_type in self.tunnel_types:"},{"line_number":788,"context_line":"                if tunnel_type \u003d\u003d p_const.TYPE_VXLAN:"},{"line_number":789,"context_line":"                    self.plugin_rpc.tunnel_sync(self.context,"},{"line_number":790,"context_line":"                                                self.local_ip,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_f087890d","line":787,"updated":"2015-02-20 22:36:05.000000000","message":"Please see my comment in the OVS agent.","commit_id":"7b1dee27118806b93696eb28fc4f47dcc046b099"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"c3951f79bdc4c573bba66d7a048f86addef62487","unresolved":false,"context_lines":[{"line_number":784,"context_line":"    def tunnel_sync(self):"},{"line_number":785,"context_line":"        resync \u003d False"},{"line_number":786,"context_line":"        try:"},{"line_number":787,"context_line":"            for tunnel_type in self.tunnel_types:"},{"line_number":788,"context_line":"                if tunnel_type \u003d\u003d p_const.TYPE_VXLAN:"},{"line_number":789,"context_line":"                    self.plugin_rpc.tunnel_sync(self.context,"},{"line_number":790,"context_line":"                                                self.local_ip,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_1d6eee01","line":787,"in_reply_to":"ba7be1f8_f087890d","updated":"2015-02-21 13:51:54.000000000","message":"Done","commit_id":"7b1dee27118806b93696eb28fc4f47dcc046b099"}],"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f9e7ae15b9d018f3732a0201c7ff306c7e7f240e","unresolved":false,"context_lines":[{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"    def tunnel_sync(self):"},{"line_number":1336,"context_line":"        try:"},{"line_number":1337,"context_line":"            for tunnel_type in self.tunnel_types:"},{"line_number":1338,"context_line":"                if tunnel_type \u003d\u003d p_const.TYPE_VXLAN:"},{"line_number":1339,"context_line":"                    details \u003d self.plugin_rpc.tunnel_sync(self.context,"},{"line_number":1340,"context_line":"                                                          self.local_ip,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_70c5595a","line":1337,"updated":"2015-02-20 22:36:05.000000000","message":"You can get rid of the if/else here in the OF agent:\n\nvxlan_port \u003d self.vxlan_udp_port if tunnel_type \u003d\u003d p_const.TYPE_VXLAN else None\n\ndetails \u003d self.plugin_rpc.tunnel_sync(...)","commit_id":"7b1dee27118806b93696eb28fc4f47dcc046b099"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"c3951f79bdc4c573bba66d7a048f86addef62487","unresolved":false,"context_lines":[{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"    def tunnel_sync(self):"},{"line_number":1336,"context_line":"        try:"},{"line_number":1337,"context_line":"            for tunnel_type in self.tunnel_types:"},{"line_number":1338,"context_line":"                if tunnel_type \u003d\u003d p_const.TYPE_VXLAN:"},{"line_number":1339,"context_line":"                    details \u003d self.plugin_rpc.tunnel_sync(self.context,"},{"line_number":1340,"context_line":"                                                          self.local_ip,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_fd091a96","line":1337,"in_reply_to":"ba7be1f8_70c5595a","updated":"2015-02-21 13:51:54.000000000","message":"Done","commit_id":"7b1dee27118806b93696eb28fc4f47dcc046b099"}],"neutron/tests/unit/ml2/test_type_gre.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a6479bd6f4c090288e21e09aba872d8f4b7d8e50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ba7be1f8_cf4f6ebd","updated":"2015-02-26 22:50:13.000000000","message":"Changes for the file do not seem relevant.","commit_id":"f0226aeaf306d6287d94938aea4b3f48cb170183"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f085fa091d31c5b792cae419efd8540791d0fc4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ba7be1f8_caed8327","updated":"2015-02-27 11:40:54.000000000","message":"As was said in prev patchset, the changes for the file are irrelevant.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"07e9668b506b5b49ef4d98b603de8ee5dde65083","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ba7be1f8_8d8c8581","in_reply_to":"ba7be1f8_caed8327","updated":"2015-02-27 12:04:33.000000000","message":"It makes it look better, that\u0027s why I have done.","commit_id":"2e546ae33cd845efd9148199247a26820ce21f0b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7cc069143d12c63a4097454887afe575edd54088","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        self.assertIsNone(self.driver.delete_endpoint(TUNNEL_IP_ONE))"},{"line_number":98,"context_line":"        # Get all the endpoints and verify its empty."},{"line_number":99,"context_line":"        endpoints \u003d self.driver.get_endpoints()"},{"line_number":100,"context_line":"        self.assertNotIn(TUNNEL_IP_ONE, endpoints)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a80dd14_14e887b3","line":98,"updated":"2015-03-05 07:30:46.000000000","message":"unrelated to this patch","commit_id":"ba489cfe8c85cfe9d4a14e7c9364225ef9312e0a"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"454cf3d13d5b04496dd9af08c119e229b045c8b7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        self.assertIsNone(self.driver.delete_endpoint(TUNNEL_IP_ONE))"},{"line_number":98,"context_line":"        # Get all the endpoints and verify its empty."},{"line_number":99,"context_line":"        endpoints \u003d self.driver.get_endpoints()"},{"line_number":100,"context_line":"        self.assertNotIn(TUNNEL_IP_ONE, endpoints)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a80dd14_d7b6f1db","line":98,"in_reply_to":"9a80dd14_14e887b3","updated":"2015-03-05 07:52:41.000000000","message":"ditto","commit_id":"ba489cfe8c85cfe9d4a14e7c9364225ef9312e0a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7cc069143d12c63a4097454887afe575edd54088","unresolved":false,"context_lines":[{"line_number":134,"context_line":"class GreTypeRpcCallbackTest(test_type_tunnel.TunnelRpcCallbackTestMixin,"},{"line_number":135,"context_line":"                             test_rpcapi.RpcCallbacksTestCase,"},{"line_number":136,"context_line":"                             testlib_api.SqlTestCase):"},{"line_number":137,"context_line":"    DRIVER_CLASS \u003d type_gre.GreTypeDriver"},{"line_number":138,"context_line":"    TYPE \u003d p_const.TYPE_GRE"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a80dd14_34ed8bc4","line":137,"updated":"2015-03-05 07:30:46.000000000","message":"ditto","commit_id":"ba489cfe8c85cfe9d4a14e7c9364225ef9312e0a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0b582f0a3be2193058ce658032c68b7a763dd123","unresolved":false,"context_lines":[{"line_number":159,"context_line":"class GreTypeRpcCallbackTest(test_type_tunnel.TunnelRpcCallbackTestMixin,"},{"line_number":160,"context_line":"                             test_rpcapi.RpcCallbacksTestCase,"},{"line_number":161,"context_line":"                             testlib_api.SqlTestCase):"},{"line_number":162,"context_line":"        DRIVER_CLASS \u003d type_gre.GreTypeDriver"},{"line_number":163,"context_line":"        TYPE \u003d p_const.TYPE_GRE"}],"source_content_type":"text/x-python","patch_set":20,"id":"da9b358b_59a9ab7a","side":"PARENT","line":162,"updated":"2015-03-31 00:28:25.000000000","message":"whoops!","commit_id":"97372fe6ff1ac620927bba0c2e9d0dfdb012c93d"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"68b35354a474b8df634722d716a0f55be2e27bb6","unresolved":false,"context_lines":[{"line_number":159,"context_line":"class GreTypeRpcCallbackTest(test_type_tunnel.TunnelRpcCallbackTestMixin,"},{"line_number":160,"context_line":"                             test_rpcapi.RpcCallbacksTestCase,"},{"line_number":161,"context_line":"                             testlib_api.SqlTestCase):"},{"line_number":162,"context_line":"        DRIVER_CLASS \u003d type_gre.GreTypeDriver"},{"line_number":163,"context_line":"        TYPE \u003d p_const.TYPE_GRE"}],"source_content_type":"text/x-python","patch_set":20,"id":"da9b358b_a8ca9b6c","side":"PARENT","line":162,"in_reply_to":"da9b358b_59a9ab7a","updated":"2015-03-31 04:27:08.000000000","message":"It is intentional :)","commit_id":"97372fe6ff1ac620927bba0c2e9d0dfdb012c93d"}],"neutron/tests/unit/ml2/test_type_tunnel.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"f68cdb520d79f12668a108fcbbbe8cf9f0e1ccb2","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        kwargs \u003d {\u0027tunnel_ip\u0027: TUNNEL_IP_ONE, \u0027host\u0027: None}"},{"line_number":319,"context_line":"        self._test_tunnel_sync_raises(kwargs)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def test_tunnel_sync_called_for_endpoint_with_vxlan_upd_port_changed(self):"},{"line_number":322,"context_line":"        if self.TYPE \u003d\u003d p_const.TYPE_VXLAN:"},{"line_number":323,"context_line":"            self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE,"},{"line_number":324,"context_line":"                                     p_const.VXLAN_UDP_PORT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_ff4e7095","line":321,"updated":"2015-02-09 15:58:31.000000000","message":"typo: s/upd/udp","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"337e7f8ac8a80d18856116506b9f539f91e6df20","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        kwargs \u003d {\u0027tunnel_ip\u0027: TUNNEL_IP_ONE, \u0027host\u0027: None}"},{"line_number":319,"context_line":"        self._test_tunnel_sync_raises(kwargs)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def test_tunnel_sync_called_for_endpoint_with_vxlan_upd_port_changed(self):"},{"line_number":322,"context_line":"        if self.TYPE \u003d\u003d p_const.TYPE_VXLAN:"},{"line_number":323,"context_line":"            self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE,"},{"line_number":324,"context_line":"                                     p_const.VXLAN_UDP_PORT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_30a4b756","line":321,"in_reply_to":"da86d52c_ff4e7095","updated":"2015-02-09 16:28:49.000000000","message":"Done","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"f68cdb520d79f12668a108fcbbbe8cf9f0e1ccb2","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE,"},{"line_number":324,"context_line":"                                     p_const.VXLAN_UDP_PORT)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"            kwargs \u003d {\u0027tunnel_ip\u0027: TUNNEL_IP_ONE, \u0027tunnel_type\u0027: self.TYPE,"},{"line_number":327,"context_line":"                      \u0027host\u0027: HOST_ONE, \u0027udp_port\u0027: 1234}"},{"line_number":328,"context_line":"            with contextlib.nested("},{"line_number":329,"context_line":"                mock.patch.object(self.notifier, \u0027tunnel_update\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_d2b9a3ed","line":326,"updated":"2015-02-09 15:58:31.000000000","message":"lines 326 to 339 are an adapted copy/paste of _test_tunnel_sync . Instead of doing that why don\u0027t you modify _test_tunnel_sync to check the udp_port?\nAdding after line 249:\n\nif self.TYPE \u003d\u003d p_const.TYPE_VXLAN:\n    self.assertEqual(kwargs[\u0027udp_port\u0027], tunnel[\u0027udp_port\u0027])\n\nshould be enough.","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"337e7f8ac8a80d18856116506b9f539f91e6df20","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE,"},{"line_number":324,"context_line":"                                     p_const.VXLAN_UDP_PORT)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"            kwargs \u003d {\u0027tunnel_ip\u0027: TUNNEL_IP_ONE, \u0027tunnel_type\u0027: self.TYPE,"},{"line_number":327,"context_line":"                      \u0027host\u0027: HOST_ONE, \u0027udp_port\u0027: 1234}"},{"line_number":328,"context_line":"            with contextlib.nested("},{"line_number":329,"context_line":"                mock.patch.object(self.notifier, \u0027tunnel_update\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_abbaf607","line":326,"in_reply_to":"da86d52c_d2b9a3ed","updated":"2015-02-09 16:28:49.000000000","message":"Ok, I will try.","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"f68cdb520d79f12668a108fcbbbe8cf9f0e1ccb2","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                    self.assertEqual(kwargs[\u0027host\u0027], tunnel[\u0027host\u0027])"},{"line_number":337,"context_line":"                    self.assertEqual(kwargs[\u0027udp_port\u0027], tunnel[\u0027udp_port\u0027])"},{"line_number":338,"context_line":"                self.assertTrue(tunnel_update.called)"},{"line_number":339,"context_line":"                self.assertFalse(tunnel_delete.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_d5b98ded","line":339,"updated":"2015-02-09 15:58:31.000000000","message":"looking at the code in type_tunnel.py (line 247-248) I was under the impression that if the udp port changes then the endpoint gets deleted and created again. That\u0027s the expected behaviour I think. So why here we check that the endpoint is not deleted, what am I missing?","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"66b180ba90f474342e74b553b30e039d3595552d","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                    self.assertEqual(kwargs[\u0027host\u0027], tunnel[\u0027host\u0027])"},{"line_number":337,"context_line":"                    self.assertEqual(kwargs[\u0027udp_port\u0027], tunnel[\u0027udp_port\u0027])"},{"line_number":338,"context_line":"                self.assertTrue(tunnel_update.called)"},{"line_number":339,"context_line":"                self.assertFalse(tunnel_delete.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_1e4406b6","line":339,"in_reply_to":"da86d52c_37f7485b","updated":"2015-02-10 03:51:22.000000000","message":"see my comments on type_tunnel.","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"509bd8cda8d28712b7116c7c7c196f3d451343ea","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                    self.assertEqual(kwargs[\u0027host\u0027], tunnel[\u0027host\u0027])"},{"line_number":337,"context_line":"                    self.assertEqual(kwargs[\u0027udp_port\u0027], tunnel[\u0027udp_port\u0027])"},{"line_number":338,"context_line":"                self.assertTrue(tunnel_update.called)"},{"line_number":339,"context_line":"                self.assertFalse(tunnel_delete.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_37f7485b","line":339,"in_reply_to":"da86d52c_8bc37237","updated":"2015-02-09 18:05:51.000000000","message":"As commented on type_tunnel.py I see that you didn\u0027t add there a tunnel_delete notification. I think you might want to fix that and fix the test accordingly.","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"337e7f8ac8a80d18856116506b9f539f91e6df20","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                    self.assertEqual(kwargs[\u0027host\u0027], tunnel[\u0027host\u0027])"},{"line_number":337,"context_line":"                    self.assertEqual(kwargs[\u0027udp_port\u0027], tunnel[\u0027udp_port\u0027])"},{"line_number":338,"context_line":"                self.assertTrue(tunnel_update.called)"},{"line_number":339,"context_line":"                self.assertFalse(tunnel_delete.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_8bc37237","line":339,"in_reply_to":"da86d52c_d5b98ded","updated":"2015-02-09 16:28:49.000000000","message":"Here, we just checked tunnel_delete RPC is not called.\n\ndelete_endpoint will delete the endpoint from neutron DB and add_endpoint adds it again if there existing and passed udp_port doesn\u0027t match.","commit_id":"a69a8c6c8ec7ec4d39f26be6ecd1ea68a9eb8287"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f9e7ae15b9d018f3732a0201c7ff306c7e7f240e","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            self.assertTrue(tunnel_update.called)"},{"line_number":251,"context_line":"            if delete_tunnel:"},{"line_number":252,"context_line":"                self.assertTrue(tunnel_delete.called)"},{"line_number":253,"context_line":"            if udp_port:"},{"line_number":254,"context_line":"                self.assertEqual(kwargs[\u0027udp_port\u0027], tunnel[\u0027udp_port\u0027])"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def _test_tunnel_sync_raises(self, kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_3023e106","line":253,"updated":"2015-02-20 22:36:05.000000000","message":"The tunnel variable here is the last tunnel in the \u0027tunnels\u0027 collection. Is this intentional?","commit_id":"7b1dee27118806b93696eb28fc4f47dcc046b099"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"c3951f79bdc4c573bba66d7a048f86addef62487","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            self.assertTrue(tunnel_update.called)"},{"line_number":251,"context_line":"            if delete_tunnel:"},{"line_number":252,"context_line":"                self.assertTrue(tunnel_delete.called)"},{"line_number":253,"context_line":"            if udp_port:"},{"line_number":254,"context_line":"                self.assertEqual(kwargs[\u0027udp_port\u0027], tunnel[\u0027udp_port\u0027])"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def _test_tunnel_sync_raises(self, kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_7d744acf","line":253,"in_reply_to":"ba7be1f8_3023e106","updated":"2015-02-21 13:51:54.000000000","message":"Yes...anyway we are just adding single endpoint.","commit_id":"7b1dee27118806b93696eb28fc4f47dcc046b099"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"6c7a38923eb1d256c0b5a5dfc78b3038c870f3a1","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            self.assertTrue(tunnel_update.called)"},{"line_number":251,"context_line":"            if delete_tunnel:"},{"line_number":252,"context_line":"                self.assertTrue(tunnel_delete.called)"},{"line_number":253,"context_line":"            if udp_port:"},{"line_number":254,"context_line":"                self.assertEqual(kwargs[\u0027udp_port\u0027], tunnel[\u0027udp_port\u0027])"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def _test_tunnel_sync_raises(self, kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_d34d2574","line":253,"in_reply_to":"ba7be1f8_7d744acf","updated":"2015-02-21 15:51:18.000000000","message":"I think it\u0027s bad habit to reference a loop variable outside of the context of the loop. It wouldn\u0027t work in other languages that shall remain nameless but are far preferable (Please nobody kill me). Maybe tunnels[0][\u0027udp_port\u0027]?","commit_id":"7b1dee27118806b93696eb28fc4f47dcc046b099"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88608c84b41d343b627014f7ca131603de744f68","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        kwargs \u003d {\u0027tunnel_ip\u0027: TUNNEL_IP_TWO, \u0027tunnel_type\u0027: self.TYPE,"},{"line_number":295,"context_line":"                  \u0027host\u0027: HOST_ONE}"},{"line_number":296,"context_line":"        self._test_tunnel_sync(kwargs, delete_tunnel\u003dTrue)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def test_tunnel_sync_called_with_used_tunnel_ip_case_one(self):"},{"line_number":299,"context_line":"        self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba7be1f8_86492633","line":296,"updated":"2015-02-25 16:05:37.000000000","message":"Just wondering, why the change.","commit_id":"91fcbaaacce4033257dbf87006be9144a254740d"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"dd0834a033c9d52d0767fc901cb986d46b525927","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        kwargs \u003d {\u0027tunnel_ip\u0027: TUNNEL_IP_TWO, \u0027tunnel_type\u0027: self.TYPE,"},{"line_number":295,"context_line":"                  \u0027host\u0027: HOST_ONE}"},{"line_number":296,"context_line":"        self._test_tunnel_sync(kwargs, delete_tunnel\u003dTrue)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def test_tunnel_sync_called_with_used_tunnel_ip_case_one(self):"},{"line_number":299,"context_line":"        self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba7be1f8_e9e0f5ce","line":296,"in_reply_to":"ba7be1f8_86492633","updated":"2015-02-25 16:31:41.000000000","message":"Just to ensure that when I pass delete_tunnel\u003dTrue\n\nIt should consider third argument in def _test_tunnel_sync(self, kwargs, delete_tunnel\u003dFalse, udp_port\u003dFalse)\n\nand when I pass udp_port\u003dTrue\n\nIt should consider fourth argument in def _test_tunnel_sync(self, kwargs, delete_tunnel\u003dFalse, udp_port\u003dFalse)","commit_id":"91fcbaaacce4033257dbf87006be9144a254740d"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"e8425939ed749c0b97f4a911a0db49821d7cd4ff","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        kwargs \u003d {\u0027tunnel_ip\u0027: TUNNEL_IP_TWO, \u0027tunnel_type\u0027: self.TYPE,"},{"line_number":295,"context_line":"                  \u0027host\u0027: HOST_ONE}"},{"line_number":296,"context_line":"        self._test_tunnel_sync(kwargs, delete_tunnel\u003dTrue)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def test_tunnel_sync_called_with_used_tunnel_ip_case_one(self):"},{"line_number":299,"context_line":"        self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba7be1f8_8f75b9cc","line":296,"in_reply_to":"ba7be1f8_94cf8c55","updated":"2015-02-25 17:01:18.000000000","message":"Done","commit_id":"91fcbaaacce4033257dbf87006be9144a254740d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"792d9a26d78512f4adfc59896881bc0ad9e7c09e","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        kwargs \u003d {\u0027tunnel_ip\u0027: TUNNEL_IP_TWO, \u0027tunnel_type\u0027: self.TYPE,"},{"line_number":295,"context_line":"                  \u0027host\u0027: HOST_ONE}"},{"line_number":296,"context_line":"        self._test_tunnel_sync(kwargs, delete_tunnel\u003dTrue)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def test_tunnel_sync_called_with_used_tunnel_ip_case_one(self):"},{"line_number":299,"context_line":"        self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba7be1f8_94cf8c55","line":296,"in_reply_to":"ba7be1f8_e9e0f5ce","updated":"2015-02-25 16:38:52.000000000","message":"Hm? It looks like you\u0027re testing python syntax, which is not something we should do.","commit_id":"91fcbaaacce4033257dbf87006be9144a254740d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88608c84b41d343b627014f7ca131603de744f68","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        self._test_tunnel_sync_raises(kwargs)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def test_tunnel_sync_called_for_endpoint_with_vxlan_udp_port_changed(self):"},{"line_number":322,"context_line":"        if self.TYPE \u003d\u003d p_const.TYPE_VXLAN:"},{"line_number":323,"context_line":"            self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE,"},{"line_number":324,"context_line":"                                     p_const.VXLAN_UDP_PORT)"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba7be1f8_260f9ae2","line":322,"updated":"2015-02-25 16:05:37.000000000","message":"Why isn\u0027t the test located in neutron/tests/unit/ml2/test_type_vxlan.py?","commit_id":"91fcbaaacce4033257dbf87006be9144a254740d"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"dd0834a033c9d52d0767fc901cb986d46b525927","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        self._test_tunnel_sync_raises(kwargs)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def test_tunnel_sync_called_for_endpoint_with_vxlan_udp_port_changed(self):"},{"line_number":322,"context_line":"        if self.TYPE \u003d\u003d p_const.TYPE_VXLAN:"},{"line_number":323,"context_line":"            self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE,"},{"line_number":324,"context_line":"                                     p_const.VXLAN_UDP_PORT)"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba7be1f8_a948bdcc","line":322,"in_reply_to":"ba7be1f8_260f9ae2","updated":"2015-02-25 16:31:41.000000000","message":"I feel it let this test case be here itself, coz here we are testing tunnel_sync RPC in VXLAN case where there is a change in udp_port value which is not applicable for GRE.\n\nSince, it deals with tunnel_sync so it should be here.","commit_id":"91fcbaaacce4033257dbf87006be9144a254740d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"792d9a26d78512f4adfc59896881bc0ad9e7c09e","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        self._test_tunnel_sync_raises(kwargs)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def test_tunnel_sync_called_for_endpoint_with_vxlan_udp_port_changed(self):"},{"line_number":322,"context_line":"        if self.TYPE \u003d\u003d p_const.TYPE_VXLAN:"},{"line_number":323,"context_line":"            self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE,"},{"line_number":324,"context_line":"                                     p_const.VXLAN_UDP_PORT)"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba7be1f8_f492884a","line":322,"in_reply_to":"ba7be1f8_a948bdcc","updated":"2015-02-25 16:38:52.000000000","message":"Right. And that\u0027s a problem, isn\u0027t it? You test VXLAN specific thing in a common test case. Remember, this test case will be executed for each tunnel type, for no reason. And it\u0027s not only noop, it will run setUp() and tearDown() for nothing.","commit_id":"91fcbaaacce4033257dbf87006be9144a254740d"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"e8425939ed749c0b97f4a911a0db49821d7cd4ff","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        self._test_tunnel_sync_raises(kwargs)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def test_tunnel_sync_called_for_endpoint_with_vxlan_udp_port_changed(self):"},{"line_number":322,"context_line":"        if self.TYPE \u003d\u003d p_const.TYPE_VXLAN:"},{"line_number":323,"context_line":"            self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE,"},{"line_number":324,"context_line":"                                     p_const.VXLAN_UDP_PORT)"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba7be1f8_da5ccd1b","line":322,"in_reply_to":"ba7be1f8_f492884a","updated":"2015-02-25 17:01:18.000000000","message":"Done","commit_id":"91fcbaaacce4033257dbf87006be9144a254740d"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"27e2e49142d929d6432fc6454ec9848b43fc0a9c","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        super(TunnelRpcCallbackTestMixin, self).setUp()"},{"line_number":237,"context_line":"        self.driver \u003d self.DRIVER_CLASS()"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def _test_tunnel_sync(self, kwargs, delete_tunnel\u003dFalse, udp_port\u003dFalse):"},{"line_number":240,"context_line":"        with contextlib.nested("},{"line_number":241,"context_line":"            mock.patch.object(self.notifier, \u0027tunnel_update\u0027),"},{"line_number":242,"context_line":"            mock.patch.object(self.notifier, \u0027tunnel_delete\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_667550f9","line":239,"updated":"2015-03-06 11:37:19.000000000","message":"I suggest renaming udp_port to udp_port_specified. udp_port is confusing, reading quickly I was expecting a port number not a boolean","commit_id":"dff3d93a8b0e9d4689e908e6dbf74604c8861587"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4fea3f002fbdc871ec5a0ed40fd8628bd84bf0d8","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        super(TunnelRpcCallbackTestMixin, self).setUp()"},{"line_number":237,"context_line":"        self.driver \u003d self.DRIVER_CLASS()"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def _test_tunnel_sync(self, kwargs, delete_tunnel\u003dFalse, udp_port\u003dFalse):"},{"line_number":240,"context_line":"        with contextlib.nested("},{"line_number":241,"context_line":"            mock.patch.object(self.notifier, \u0027tunnel_update\u0027),"},{"line_number":242,"context_line":"            mock.patch.object(self.notifier, \u0027tunnel_delete\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_ca9d16be","line":239,"in_reply_to":"9a80dd14_110dac37","updated":"2015-03-06 15:00:03.000000000","message":"udp\u003d would be even shorter and still clearer.","commit_id":"dff3d93a8b0e9d4689e908e6dbf74604c8861587"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"2937283b455db07756cf123b4c8c6ee22ebe6577","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        super(TunnelRpcCallbackTestMixin, self).setUp()"},{"line_number":237,"context_line":"        self.driver \u003d self.DRIVER_CLASS()"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def _test_tunnel_sync(self, kwargs, delete_tunnel\u003dFalse, udp_port\u003dFalse):"},{"line_number":240,"context_line":"        with contextlib.nested("},{"line_number":241,"context_line":"            mock.patch.object(self.notifier, \u0027tunnel_update\u0027),"},{"line_number":242,"context_line":"            mock.patch.object(self.notifier, \u0027tunnel_delete\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_110dac37","line":239,"in_reply_to":"9a80dd14_667550f9","updated":"2015-03-06 11:45:43.000000000","message":"I will do it, if I may need to put another patch.","commit_id":"dff3d93a8b0e9d4689e908e6dbf74604c8861587"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"88d04f60dff6d620610007eb8f43a09591372e70","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        super(TunnelRpcCallbackTestMixin, self).setUp()"},{"line_number":237,"context_line":"        self.driver \u003d self.DRIVER_CLASS()"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def _test_tunnel_sync(self, kwargs, delete_tunnel\u003dFalse, udp_port\u003dFalse):"},{"line_number":240,"context_line":"        with contextlib.nested("},{"line_number":241,"context_line":"            mock.patch.object(self.notifier, \u0027tunnel_update\u0027),"},{"line_number":242,"context_line":"            mock.patch.object(self.notifier, \u0027tunnel_delete\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_85ef91e8","line":239,"in_reply_to":"9a80dd14_ca9d16be","updated":"2015-03-06 15:22:18.000000000","message":"Sorry, udp\u003d would be quite confusing to me.\n\nI may prefer renaming to udp_port_specified or udp_port_passed :)","commit_id":"dff3d93a8b0e9d4689e908e6dbf74604c8861587"}],"neutron/tests/unit/ml2/test_type_vxlan.py":[{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"5171a49d9c27bdf6e6f2335461d70c8128fb24ab","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.assertNotIn(TUNNEL_IP_ONE, endpoints)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_update_endpoint(self):"},{"line_number":97,"context_line":"        self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE, VXLAN_UDP_PORT_ONE)"},{"line_number":98,"context_line":"        # Update the endpoint with updated udp port value."},{"line_number":99,"context_line":"        self.driver.update_endpoint(TUNNEL_IP_ONE, VXLAN_UDP_PORT_TWO)"},{"line_number":100,"context_line":"        # Get the endpoint."}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_fa1958d1","line":97,"updated":"2015-02-26 18:53:30.000000000","message":"Add one blank line here, just for consistency in file.","commit_id":"f0226aeaf306d6287d94938aea4b3f48cb170183"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"27e2e49142d929d6432fc6454ec9848b43fc0a9c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"TUNNEL_IP_TWO \u003d \"10.10.10.20\""},{"line_number":27,"context_line":"HOST_ONE \u003d \u0027fake_host_one\u0027"},{"line_number":28,"context_line":"HOST_TWO \u003d \u0027fake_host_two\u0027"},{"line_number":29,"context_line":"VXLAN_UDP_PORT_ONE \u003d 4789"},{"line_number":30,"context_line":"VXLAN_UDP_PORT_TWO \u003d 9874"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_467bec27","line":29,"updated":"2015-03-06 11:37:19.000000000","message":"just curious, why did you change this?","commit_id":"dff3d93a8b0e9d4689e908e6dbf74604c8861587"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"2937283b455db07756cf123b4c8c6ee22ebe6577","unresolved":false,"context_lines":[{"line_number":26,"context_line":"TUNNEL_IP_TWO \u003d \"10.10.10.20\""},{"line_number":27,"context_line":"HOST_ONE \u003d \u0027fake_host_one\u0027"},{"line_number":28,"context_line":"HOST_TWO \u003d \u0027fake_host_two\u0027"},{"line_number":29,"context_line":"VXLAN_UDP_PORT_ONE \u003d 4789"},{"line_number":30,"context_line":"VXLAN_UDP_PORT_TWO \u003d 9874"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_f11e585e","line":29,"in_reply_to":"9a80dd14_467bec27","updated":"2015-03-06 11:45:43.000000000","message":"Because 4789 is the default UDP_PORT we use with VXLAN.","commit_id":"dff3d93a8b0e9d4689e908e6dbf74604c8861587"}]}
