)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"10034d6a33c27a09bf4b43b550b2b58ad2149d20","unresolved":false,"context_lines":[{"line_number":23,"context_line":"l3 agent."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The logic is simple, no need to rewrite UT."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I659c7e1b8a3b0d95657c7edfafff1ca832287b78"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_027b457b","line":26,"updated":"2015-02-12 16:15:17.000000000","message":"can you create a bug for that? In the bug could you please explain more in details what was your problem and add a traceback or snippet of the logs. It would help reviewers to understand more clearly what you are fixing here.","commit_id":"2cc6618971b76f1c6ef045399d8d8effb310aac2"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"4b1230c030d5929803c7f2c150d12d428cfb3288","unresolved":false,"context_lines":[{"line_number":23,"context_line":"l3 agent."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The logic is simple, no need to rewrite UT."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I659c7e1b8a3b0d95657c7edfafff1ca832287b78"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_5fccef61","line":26,"in_reply_to":"da86d52c_027b457b","updated":"2015-02-14 02:09:37.000000000","message":"Sorry, I will fix this later.","commit_id":"2cc6618971b76f1c6ef045399d8d8effb310aac2"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"7dafd132899600c8d08b6b459d9a8383a5e436f1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"we get from method _create_port_db to notify"},{"line_number":24,"context_line":"l3 agent."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The logic is simple, no need to rewrite UT."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I659c7e1b8a3b0d95657c7edfafff1ca832287b78"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da86d52c_05630fde","line":26,"updated":"2015-02-13 21:27:52.000000000","message":"If there was a flaw in the logic then you should be able to write a new unit test to expose the flaw and show that this patch fixes it.  Writing a UT that clearly shows this may help you make your case here.\n\nAlso, this absolutely needs a bug report with the details of the flaw as was mentioned by Rossella.","commit_id":"4b9b7c2b2d67cc421f6427b930ab15b43d01de57"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"90f3ed2b4fde9f9b36413afec148878e6e3ccdd2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Method _get_host_port_if_changed should be only"},{"line_number":10,"context_line":"used on updating action, like update_port, not"},{"line_number":11,"context_line":"creating action, like create_port and create_port_bulk."},{"line_number":12,"context_line":"But current code will invode _get_host_port_if_changed"},{"line_number":13,"context_line":"both in port updating and creating action. This patch"},{"line_number":14,"context_line":"will fix this."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_c6f22a6e","line":12,"updated":"2015-03-20 14:46:17.000000000","message":"s/invode/invoke","commit_id":"95b7ca4af29c62b17f00f32e9d7852c94dccea18"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"754319f798bf1030ef8e625a7ca303a988276c2d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Method _get_host_port_if_changed should be only"},{"line_number":10,"context_line":"used on updating action, like update_port, not"},{"line_number":11,"context_line":"creating action, like create_port and create_port_bulk."},{"line_number":12,"context_line":"But current code will invode _get_host_port_if_changed"},{"line_number":13,"context_line":"both in port updating and creating action. This patch"},{"line_number":14,"context_line":"will fix this."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_93c5cd5d","line":12,"in_reply_to":"9a80dd14_c6f22a6e","updated":"2015-03-20 15:02:21.000000000","message":"Done","commit_id":"95b7ca4af29c62b17f00f32e9d7852c94dccea18"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"90f3ed2b4fde9f9b36413afec148878e6e3ccdd2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"object as parameter. That\u0027s the reason why we need"},{"line_number":19,"context_line":"invoke _get_host_port_if_changed(we need compare rpc"},{"line_number":20,"context_line":"parameters with db updated result to judge whether port"},{"line_number":21,"context_line":"host binding changed), and use it return value as"},{"line_number":22,"context_line":"parameter to invoke an l3 agent notification."},{"line_number":23,"context_line":"To binding changed case, subnet will be fetched from"},{"line_number":24,"context_line":"port, then processing will fetch related routers and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_8650322d","line":21,"updated":"2015-03-20 14:46:17.000000000","message":"s/it/its","commit_id":"95b7ca4af29c62b17f00f32e9d7852c94dccea18"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"754319f798bf1030ef8e625a7ca303a988276c2d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"object as parameter. That\u0027s the reason why we need"},{"line_number":19,"context_line":"invoke _get_host_port_if_changed(we need compare rpc"},{"line_number":20,"context_line":"parameters with db updated result to judge whether port"},{"line_number":21,"context_line":"host binding changed), and use it return value as"},{"line_number":22,"context_line":"parameter to invoke an l3 agent notification."},{"line_number":23,"context_line":"To binding changed case, subnet will be fetched from"},{"line_number":24,"context_line":"port, then processing will fetch related routers and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_b3c0114b","line":21,"in_reply_to":"9a80dd14_8650322d","updated":"2015-03-20 15:02:21.000000000","message":"Done","commit_id":"95b7ca4af29c62b17f00f32e9d7852c94dccea18"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"90f3ed2b4fde9f9b36413afec148878e6e3ccdd2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"parameters with db updated result to judge whether port"},{"line_number":21,"context_line":"host binding changed), and use it return value as"},{"line_number":22,"context_line":"parameter to invoke an l3 agent notification."},{"line_number":23,"context_line":"To binding changed case, subnet will be fetched from"},{"line_number":24,"context_line":"port, then processing will fetch related routers and"},{"line_number":25,"context_line":"l3-agents to notify. To binding dischanged case, the"},{"line_number":26,"context_line":"port object, notification method received will be None,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_1a8012f6","line":23,"updated":"2015-03-20 14:46:17.000000000","message":"s/To/For\n\nalso in in lines: 25, 32","commit_id":"95b7ca4af29c62b17f00f32e9d7852c94dccea18"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"754319f798bf1030ef8e625a7ca303a988276c2d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"parameters with db updated result to judge whether port"},{"line_number":21,"context_line":"host binding changed), and use it return value as"},{"line_number":22,"context_line":"parameter to invoke an l3 agent notification."},{"line_number":23,"context_line":"To binding changed case, subnet will be fetched from"},{"line_number":24,"context_line":"port, then processing will fetch related routers and"},{"line_number":25,"context_line":"l3-agents to notify. To binding dischanged case, the"},{"line_number":26,"context_line":"port object, notification method received will be None,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_d3a2e5ac","line":23,"in_reply_to":"9a80dd14_1a8012f6","updated":"2015-03-20 15:02:21.000000000","message":"Done","commit_id":"95b7ca4af29c62b17f00f32e9d7852c94dccea18"},{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"90f3ed2b4fde9f9b36413afec148878e6e3ccdd2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"parameter to invoke an l3 agent notification."},{"line_number":23,"context_line":"To binding changed case, subnet will be fetched from"},{"line_number":24,"context_line":"port, then processing will fetch related routers and"},{"line_number":25,"context_line":"l3-agents to notify. To binding dischanged case, the"},{"line_number":26,"context_line":"port object, notification method received will be None,"},{"line_number":27,"context_line":"and no notification will do."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_5a4c4a42","line":25,"updated":"2015-03-20 14:46:17.000000000","message":"s/dischanged/unchanged","commit_id":"95b7ca4af29c62b17f00f32e9d7852c94dccea18"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"754319f798bf1030ef8e625a7ca303a988276c2d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"parameter to invoke an l3 agent notification."},{"line_number":23,"context_line":"To binding changed case, subnet will be fetched from"},{"line_number":24,"context_line":"port, then processing will fetch related routers and"},{"line_number":25,"context_line":"l3-agents to notify. To binding dischanged case, the"},{"line_number":26,"context_line":"port object, notification method received will be None,"},{"line_number":27,"context_line":"and no notification will do."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_f3a529b5","line":25,"in_reply_to":"9a80dd14_5a4c4a42","updated":"2015-03-20 15:02:21.000000000","message":"Done. Thx, :)","commit_id":"95b7ca4af29c62b17f00f32e9d7852c94dccea18"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"13df71ef3432bfa31ddae111f88ba67ced0e0fa8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"will fix this."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"If a port host binding changed, method"},{"line_number":17,"context_line":"_notify_l3_agent_new_port should be invoked with a port"},{"line_number":18,"context_line":"object as parameter. That\u0027s the reason why we need"},{"line_number":19,"context_line":"invoke _get_host_port_if_changed(we need compare rpc"},{"line_number":20,"context_line":"parameters with db updated result to judge whether port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a80dd14_44e4683b","line":17,"updated":"2015-03-20 18:17:00.000000000","message":"_notify_l3_agent_new_port has been removed, so just mention about the registry_notifier here.","commit_id":"c882edce9c48e61ddced81b182a465a25502966b"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"126d1049cce61a82e121166976d56c10769b92fb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"will fix this."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"If a port host binding changed, method"},{"line_number":17,"context_line":"_notify_l3_agent_new_port should be invoked with a port"},{"line_number":18,"context_line":"object as parameter. That\u0027s the reason why we need"},{"line_number":19,"context_line":"invoke _get_host_port_if_changed(we need compare rpc"},{"line_number":20,"context_line":"parameters with db updated result to judge whether port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a75e904_555a3684","line":17,"in_reply_to":"9a80dd14_44e4683b","updated":"2015-03-21 22:13:43.000000000","message":"Done. Thx, :)","commit_id":"c882edce9c48e61ddced81b182a465a25502966b"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"13df71ef3432bfa31ddae111f88ba67ced0e0fa8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"so directly use db updated result, the mech_context"},{"line_number":38,"context_line":"object, to invoke notification method will make sense."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Cloases-Bug: #1411883"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Change-Id: I659c7e1b8a3b0d95657c7edfafff1ca832287b78"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a80dd14_c4c77896","line":40,"updated":"2015-03-20 18:17:00.000000000","message":"Typo in \"Closes\".","commit_id":"c882edce9c48e61ddced81b182a465a25502966b"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"126d1049cce61a82e121166976d56c10769b92fb","unresolved":false,"context_lines":[{"line_number":37,"context_line":"so directly use db updated result, the mech_context"},{"line_number":38,"context_line":"object, to invoke notification method will make sense."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Cloases-Bug: #1411883"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Change-Id: I659c7e1b8a3b0d95657c7edfafff1ca832287b78"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a75e904_755f3273","line":40,"in_reply_to":"9a80dd14_c4c77896","updated":"2015-03-21 22:13:43.000000000","message":"Done","commit_id":"c882edce9c48e61ddced81b182a465a25502966b"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"94e549a6dd1befd93ae7ba5c40150b6dfdf55501","unresolved":false,"context_lines":[{"line_number":35,"context_line":" _get_host_port_if_changed will return None. But indeed,"},{"line_number":36,"context_line":"we need notify related l3-agents that new port created,"},{"line_number":37,"context_line":"so directly use db updated result, the mech_context"},{"line_number":38,"context_line":"object, to invoke notification method will make sense."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Closes-Bug: #1411883"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baa041b7_7bf2589c","line":38,"updated":"2015-04-01 18:13:23.000000000","message":"This bug mentioned below seems to have resolved with the current changes that had happened in the ml2 plugin for register_notify function.\nSo for this patch you may need to either file another bug or remove the line below, since it is no longer directly related to the bug description provided in the \"Closes-bug\" line.","commit_id":"ae5350dbbf9546f4013f47f726d0954b3c6e8092"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"7909af9e299db2baa9f37c30e0d1bf57a273d399","unresolved":false,"context_lines":[{"line_number":35,"context_line":" _get_host_port_if_changed will return None. But indeed,"},{"line_number":36,"context_line":"we need notify related l3-agents that new port created,"},{"line_number":37,"context_line":"so directly use db updated result, the mech_context"},{"line_number":38,"context_line":"object, to invoke notification method will make sense."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Closes-Bug: #1411883"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baa041b7_6d74d09b","line":38,"in_reply_to":"baa041b7_7bf2589c","updated":"2015-04-02 03:50:35.000000000","message":"Done :)","commit_id":"ae5350dbbf9546f4013f47f726d0954b3c6e8092"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9cab2942f40e5456143219cac9aa509881d59fd","unresolved":false,"context_lines":[{"line_number":36,"context_line":"we need notify related l3-agents that new port created,"},{"line_number":37,"context_line":"so directly use db updated result, the mech_context"},{"line_number":38,"context_line":"object, to invoke notification method will make sense."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Change-Id: I659c7e1b8a3b0d95657c7edfafff1ca832287b78"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"baa041b7_924ddd74","line":39,"updated":"2015-04-02 13:32:03.000000000","message":"You do need to file a bug for this fix. Also as already requested, add details in the bug reports, possibly log snippets, otherwise it\u0027s hard to understand what you are fixing. You are trying really hard here to explain but a detailed bug report would help more than these long paragraphs. Thanks!","commit_id":"39c7830d43db550db7500d898e2805c9eb2abca3"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"376eb19aebf2d6d1483037743705de7af2e0c42c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"we need notify related l3-agents that new port created,"},{"line_number":37,"context_line":"so directly use db updated result, the mech_context"},{"line_number":38,"context_line":"object, to invoke notification method will make sense."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Change-Id: I659c7e1b8a3b0d95657c7edfafff1ca832287b78"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"baa041b7_e8ee758a","line":39,"in_reply_to":"baa041b7_4eae912f","updated":"2015-04-02 16:53:53.000000000","message":"hi ZongKai Li,\nYes what you have stated above is right. \nBut please go ahead and file a new bug on this and then add the details on that bug reports and then push this patch.","commit_id":"39c7830d43db550db7500d898e2805c9eb2abca3"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"21a48ca2957b85c4b7116e33ff1084a2e7ef8761","unresolved":false,"context_lines":[{"line_number":36,"context_line":"we need notify related l3-agents that new port created,"},{"line_number":37,"context_line":"so directly use db updated result, the mech_context"},{"line_number":38,"context_line":"object, to invoke notification method will make sense."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Change-Id: I659c7e1b8a3b0d95657c7edfafff1ca832287b78"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"baa041b7_4eae912f","line":39,"in_reply_to":"baa041b7_924ddd74","updated":"2015-04-02 15:01:55.000000000","message":"Hi, Rossella, thanks for your review and comments.\nI\u0027ve just updated this patch set in the morning in my day time, and yeah, thanks for you noticed the way I try to explain here.\n\nMaybe you would check Swami\u0027s comments on my patch set 8. Yes, before this patch set, my patch is for https://bugs.launchpad.net/neutron/+bug/1411883, which is reported by Swami, but recently Swami test it again, seems the issue will not reproduce again, so he added comments on my patch set 8 to tell me that I should remove the bug\u0027s id, so I did.\n\nAnd in that bug report page, Swami suggested that I can still go on. I think the misusing of method _get_host_port_if_changed still can be fixed, even the previous bug seems no more reproduced. So any suggestion you have willing to share, :), please just let me know.","commit_id":"39c7830d43db550db7500d898e2805c9eb2abca3"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"8f8c1f2dc0e70e3d024af4343842c21c7804b0fb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"we need notify related l3-agents that new port created,"},{"line_number":37,"context_line":"so directly use db updated result, the mech_context"},{"line_number":38,"context_line":"object, to invoke notification method will make sense."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Change-Id: I659c7e1b8a3b0d95657c7edfafff1ca832287b78"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"baa041b7_830eaa32","line":39,"in_reply_to":"baa041b7_e8ee758a","updated":"2015-04-02 16:59:03.000000000","message":"Sure, I will do that later.","commit_id":"39c7830d43db550db7500d898e2805c9eb2abca3"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"10034d6a33c27a09bf4b43b550b2b58ad2149d20","unresolved":false,"context_lines":[{"line_number":927,"context_line":"        attrs \u003d port[\u0027port\u0027]"},{"line_number":928,"context_line":"        result, mech_context \u003d self._create_port_db(context, port)"},{"line_number":929,"context_line":"        new_host_port \u003d self._get_host_port_if_changed(mech_context, attrs)"},{"line_number":930,"context_line":"        new_host_port \u003d new_host_port if new_host_port else result "},{"line_number":931,"context_line":"        self._notify_l3_agent_new_port(context, new_host_port)"},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_220be924","line":930,"updated":"2015-02-12 16:15:17.000000000","message":"when a new port comes up the host ID should be set while previously was None so this line should work.","commit_id":"2cc6618971b76f1c6ef045399d8d8effb310aac2"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"42114f14f7c87ad9f8a4a27ff72f8a50bb055274","unresolved":false,"context_lines":[{"line_number":927,"context_line":"        attrs \u003d port[\u0027port\u0027]"},{"line_number":928,"context_line":"        result, mech_context \u003d self._create_port_db(context, port)"},{"line_number":929,"context_line":"        new_host_port \u003d self._get_host_port_if_changed(mech_context, attrs)"},{"line_number":930,"context_line":"        new_host_port \u003d new_host_port if new_host_port else result "},{"line_number":931,"context_line":"        self._notify_l3_agent_new_port(context, new_host_port)"},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_a2a6f9a8","line":930,"in_reply_to":"da86d52c_220be924","updated":"2015-02-12 16:27:44.000000000","message":"Oh, sorry, Rossella, do you clear my Commit Message?\nPlease read it first, or again!\n\nThe thing I try to fix here is to pass a port obj created in _create_port_db not None obj to _notify_l3_agent_new_port.\n\nCurrently, _get_host_port_if_changed will return a new port or None(the case host_port is not changed), None will cause port created on host but couldn\u0027t get a l3 agent notification.","commit_id":"2cc6618971b76f1c6ef045399d8d8effb310aac2"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"7dafd132899600c8d08b6b459d9a8383a5e436f1","unresolved":false,"context_lines":[{"line_number":927,"context_line":"        attrs \u003d port[\u0027port\u0027]"},{"line_number":928,"context_line":"        result, mech_context \u003d self._create_port_db(context, port)"},{"line_number":929,"context_line":"        new_host_port \u003d self._get_host_port_if_changed(mech_context, attrs)"},{"line_number":930,"context_line":"        new_host_port \u003d new_host_port if new_host_port else result"},{"line_number":931,"context_line":"        self._notify_l3_agent_new_port(context, new_host_port)"},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_c544971d","line":930,"updated":"2015-02-13 21:27:52.000000000","message":"The code (before this patch) says that the agent should only need to be notified if the port has changed.  Your patch seems to contradict that without changing that logic.  It is very confusing the way it reads with this patch.  If the old code is wrong, let\u0027s change it to be correct rather than just adding a confusing band-aid.\n\nHowever, we need to see a detailed bug report describing the problem here before we can say anything about this problem.","commit_id":"4b9b7c2b2d67cc421f6427b930ab15b43d01de57"}],"neutron/tests/unit/ml2/test_ml2_plugin.py":[{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"b2f76b9bd299e30a7f32af85efdcf65542dc5e43","unresolved":false,"context_lines":[{"line_number":1388,"context_line":"                              return_value\u003d{\u0027L3_ROUTER_NAT\u0027: l3plugin}),"},{"line_number":1389,"context_line":"        ):"},{"line_number":1390,"context_line":"            plugin \u003d self._create_plugin_for_create_update_port("},{"line_number":1391,"context_line":"                mock.MagicMock())"},{"line_number":1392,"context_line":"            # deleting the port will call dvr_vmarp_table_update, which will"},{"line_number":1393,"context_line":"            # run the transaction balancing function defined in this test"},{"line_number":1394,"context_line":"            plugin.delete_port(self.context, \u0027fake_id\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_24484f5b","line":1391,"updated":"2015-03-20 20:27:05.000000000","message":"new_host_port\u003dmock.MagicMock()","commit_id":"c882edce9c48e61ddced81b182a465a25502966b"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"126d1049cce61a82e121166976d56c10769b92fb","unresolved":false,"context_lines":[{"line_number":1388,"context_line":"                              return_value\u003d{\u0027L3_ROUTER_NAT\u0027: l3plugin}),"},{"line_number":1389,"context_line":"        ):"},{"line_number":1390,"context_line":"            plugin \u003d self._create_plugin_for_create_update_port("},{"line_number":1391,"context_line":"                mock.MagicMock())"},{"line_number":1392,"context_line":"            # deleting the port will call dvr_vmarp_table_update, which will"},{"line_number":1393,"context_line":"            # run the transaction balancing function defined in this test"},{"line_number":1394,"context_line":"            plugin.delete_port(self.context, \u0027fake_id\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a75e904_9553ce6b","line":1391,"in_reply_to":"9a80dd14_24484f5b","updated":"2015-03-21 22:13:43.000000000","message":"Done. Thx, :)","commit_id":"c882edce9c48e61ddced81b182a465a25502966b"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a9cab2942f40e5456143219cac9aa509881d59fd","unresolved":false,"context_lines":[{"line_number":1325,"context_line":"            self.notify.assert_called_once_with(\u0027port\u0027, \u0027after_create\u0027,"},{"line_number":1326,"context_line":"                plugin, **kwargs)"},{"line_number":1327,"context_line":""},{"line_number":1328,"context_line":"    def test_create_port_bulk_rpc_outside_transaction(self):"},{"line_number":1329,"context_line":"        with contextlib.nested("},{"line_number":1330,"context_line":"            mock.patch.object(ml2_plugin.Ml2Plugin, \u0027__init__\u0027),"},{"line_number":1331,"context_line":"            mock.patch.object(base_plugin.NeutronDbPluginV2, \u0027create_port\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"baa041b7_b2e4613b","line":1328,"updated":"2015-04-02 13:32:03.000000000","message":"this test seems identical to the previous one. Where is the bulk operation? Anyway how is this related to your patch?","commit_id":"39c7830d43db550db7500d898e2805c9eb2abca3"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"21a48ca2957b85c4b7116e33ff1084a2e7ef8761","unresolved":false,"context_lines":[{"line_number":1325,"context_line":"            self.notify.assert_called_once_with(\u0027port\u0027, \u0027after_create\u0027,"},{"line_number":1326,"context_line":"                plugin, **kwargs)"},{"line_number":1327,"context_line":""},{"line_number":1328,"context_line":"    def test_create_port_bulk_rpc_outside_transaction(self):"},{"line_number":1329,"context_line":"        with contextlib.nested("},{"line_number":1330,"context_line":"            mock.patch.object(ml2_plugin.Ml2Plugin, \u0027__init__\u0027),"},{"line_number":1331,"context_line":"            mock.patch.object(base_plugin.NeutronDbPluginV2, \u0027create_port\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"baa041b7_51707072","line":1328,"in_reply_to":"baa041b7_b2e4613b","updated":"2015-04-02 15:01:55.000000000","message":"Oops, let me see.\n\nThis part, test_create_port_bulk_rpc_outside_transaction, is not added by me, I got it by having my patch set 5 been rebased, so I\u0027m not the author of this test, but I do modify it.\n\nMaybe you have willing to check ml2/plugin.py in my patch, and you also need expand the toggle part, you will find I did some modify in method create_port_buld, so maybe I also need modify this test. So any more opinion you want to share?\n\nBtw, thanks for your review.","commit_id":"39c7830d43db550db7500d898e2805c9eb2abca3"}]}