)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ce69466af7d88b1199583f98a14a474747e4cadd","unresolved":false,"context_lines":[{"line_number":1301,"context_line":"def _prevent_l3_port_deletion_callback(resource, event, trigger, **kwargs):"},{"line_number":1302,"context_line":"    context \u003d kwargs[\u0027context\u0027]"},{"line_number":1303,"context_line":"    port_id \u003d kwargs[\u0027port_id\u0027]"},{"line_number":1304,"context_line":"    port_check \u003d kwargs[\u0027port_check\u0027]"},{"line_number":1305,"context_line":"    l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":1306,"context_line":"        constants.L3_ROUTER_NAT)"},{"line_number":1307,"context_line":"    if l3plugin and port_check:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_2e1ac16e","line":1304,"updated":"2015-02-20 11:22:37.000000000","message":"can you make port_check a named arg and then pass **kwargs directly into prevent_l3_port_deletion? \n\nI\u0027m not a fan of unnecessarily unpacking kwargs since it eats up so much space.","commit_id":"98e35e9bba44e99ac3ac4eab378bacb657e124a2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"394e6d2ed87ce4a3b7330e9550e4422b1c57ea7f","unresolved":false,"context_lines":[{"line_number":1301,"context_line":"def _prevent_l3_port_deletion_callback(resource, event, trigger, **kwargs):"},{"line_number":1302,"context_line":"    context \u003d kwargs[\u0027context\u0027]"},{"line_number":1303,"context_line":"    port_id \u003d kwargs[\u0027port_id\u0027]"},{"line_number":1304,"context_line":"    port_check \u003d kwargs[\u0027port_check\u0027]"},{"line_number":1305,"context_line":"    l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":1306,"context_line":"        constants.L3_ROUTER_NAT)"},{"line_number":1307,"context_line":"    if l3plugin and port_check:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_7531cbeb","line":1304,"in_reply_to":"ba7be1f8_2e1ac16e","updated":"2015-02-20 21:46:09.000000000","message":"Kevin and I discussed about this on IRC. I personally would like to move away from kwargs long term and pass a well define event payload. However, I feel that can only take place when we start passing objects everywhere. For now, this is a good enough stop-gap solution.","commit_id":"98e35e9bba44e99ac3ac4eab378bacb657e124a2"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ce69466af7d88b1199583f98a14a474747e4cadd","unresolved":false,"context_lines":[{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"def _notify_routers_callback(resource, event, trigger, **kwargs):"},{"line_number":1312,"context_line":"    context \u003d kwargs[\u0027context\u0027]"},{"line_number":1313,"context_line":"    router_ids \u003d kwargs[\u0027router_ids\u0027]"},{"line_number":1314,"context_line":"    l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":1315,"context_line":"        constants.L3_ROUTER_NAT)"},{"line_number":1316,"context_line":"    l3plugin.notify_routers_updated(context, router_ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_6e2bd982","line":1313,"updated":"2015-02-20 11:22:37.000000000","message":"ditto","commit_id":"98e35e9bba44e99ac3ac4eab378bacb657e124a2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"394e6d2ed87ce4a3b7330e9550e4422b1c57ea7f","unresolved":false,"context_lines":[{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"def _notify_routers_callback(resource, event, trigger, **kwargs):"},{"line_number":1312,"context_line":"    context \u003d kwargs[\u0027context\u0027]"},{"line_number":1313,"context_line":"    router_ids \u003d kwargs[\u0027router_ids\u0027]"},{"line_number":1314,"context_line":"    l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":1315,"context_line":"        constants.L3_ROUTER_NAT)"},{"line_number":1316,"context_line":"    l3plugin.notify_routers_updated(context, router_ids)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_3a93c2a4","line":1313,"in_reply_to":"ba7be1f8_6e2bd982","updated":"2015-02-20 21:46:09.000000000","message":"see above.","commit_id":"98e35e9bba44e99ac3ac4eab378bacb657e124a2"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ce69466af7d88b1199583f98a14a474747e4cadd","unresolved":false,"context_lines":[{"line_number":1321,"context_line":"registry.subscribe("},{"line_number":1322,"context_line":"    vpn_callback, resources.ROUTER_INTERFACE, events.BEFORE_DELETE)"},{"line_number":1323,"context_line":"registry.subscribe("},{"line_number":1324,"context_line":"    _prevent_l3_port_deletion_callback, resources.PORT, events.BEFORE_DELETE)"},{"line_number":1325,"context_line":"registry.subscribe("},{"line_number":1326,"context_line":"    _notify_routers_callback, resources.PORT, events.AFTER_DELETE)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_23581a56","line":1324,"updated":"2015-02-20 11:22:37.000000000","message":"Don\u0027t these seem like something we should have the service plugins do themselves during initialization?","commit_id":"98e35e9bba44e99ac3ac4eab378bacb657e124a2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"394e6d2ed87ce4a3b7330e9550e4422b1c57ea7f","unresolved":false,"context_lines":[{"line_number":1321,"context_line":"registry.subscribe("},{"line_number":1322,"context_line":"    vpn_callback, resources.ROUTER_INTERFACE, events.BEFORE_DELETE)"},{"line_number":1323,"context_line":"registry.subscribe("},{"line_number":1324,"context_line":"    _prevent_l3_port_deletion_callback, resources.PORT, events.BEFORE_DELETE)"},{"line_number":1325,"context_line":"registry.subscribe("},{"line_number":1326,"context_line":"    _notify_routers_callback, resources.PORT, events.AFTER_DELETE)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_9fc74012","line":1324,"in_reply_to":"ba7be1f8_23581a56","updated":"2015-02-20 21:46:09.000000000","message":"if you suggesting to wrap this into a subscribe method that\u0027s gonna be called at init, the reason why I did not make this explicit is the following:\n\nMultiple l3 service plugins (potentially out of tree) may need this rule enforced. If I made the subscription explicit in [1] I would have potentially broken other l3 service plugins. Having the subscription be implicit does preserve the existing behavior, and avoid fixing it manually in each and every plugin in. That said, I can make this explicit in the reference l3 plugin, and leave the implicit subscription for sake of bw compat. The subscription operation is idempotent so there\u0027s no harm in registering the same callback multiple times.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/services/l3_router/l3_router_plugin.py","commit_id":"98e35e9bba44e99ac3ac4eab378bacb657e124a2"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"190cb06129fb1efdca275c38a1319bb888b2da35","unresolved":false,"context_lines":[{"line_number":1299,"context_line":""},{"line_number":1300,"context_line":""},{"line_number":1301,"context_line":"def _prevent_l3_port_delete_callback(resource, event, trigger, **kwargs):"},{"line_number":1302,"context_line":"    context \u003d kwargs[\u0027context\u0027]"},{"line_number":1303,"context_line":"    port_id \u003d kwargs[\u0027port_id\u0027]"},{"line_number":1304,"context_line":"    port_check \u003d kwargs[\u0027port_check\u0027]"},{"line_number":1305,"context_line":"    l3plugin \u003d manager.NeutronManager.get_service_plugins().get("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_b59ef505","line":1302,"updated":"2015-02-27 09:51:15.000000000","message":"gross, but I can learn to live with this over time. :)","commit_id":"8c38cd6b1977931aa4e024d1c27472fa2e48df89"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9348c185bfa4c56955b0ce7e4b23a724b3578f5b","unresolved":false,"context_lines":[{"line_number":978,"context_line":"            # Otherwise it\u0027s a stale port that can be removed"},{"line_number":979,"context_line":"            fixed_ips \u003d port_db[\u0027fixed_ips\u0027]"},{"line_number":980,"context_line":"            if fixed_ips:"},{"line_number":981,"context_line":"                reason \u003d \u0027has device owner %s\u0027 % port_db[\u0027device_owner\u0027]"},{"line_number":982,"context_line":"                raise n_exc.ServicePortInUse(port_id\u003dport_db[\u0027id\u0027],"},{"line_number":983,"context_line":"                                             reason\u003dreason)"},{"line_number":984,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_557fb0aa","line":981,"updated":"2015-03-16 08:37:53.000000000","message":"missing translation\n\nthis should be:\n_(\u0027has device owner %s\u0027) % port_db[\u0027device_owner\u0027]","commit_id":"0d25809da979f8e8012dcd7b824120847b7d8713"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"be370a392c75d4ffccbe752361d99499ae66c11c","unresolved":false,"context_lines":[{"line_number":978,"context_line":"            # Otherwise it\u0027s a stale port that can be removed"},{"line_number":979,"context_line":"            fixed_ips \u003d port_db[\u0027fixed_ips\u0027]"},{"line_number":980,"context_line":"            if fixed_ips:"},{"line_number":981,"context_line":"                reason \u003d \u0027has device owner %s\u0027 % port_db[\u0027device_owner\u0027]"},{"line_number":982,"context_line":"                raise n_exc.ServicePortInUse(port_id\u003dport_db[\u0027id\u0027],"},{"line_number":983,"context_line":"                                             reason\u003dreason)"},{"line_number":984,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_dc3bbb35","line":981,"in_reply_to":"9a80dd14_557fb0aa","updated":"2015-03-16 14:22:10.000000000","message":"+1 good catch","commit_id":"0d25809da979f8e8012dcd7b824120847b7d8713"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"444329bb1f3e0044e15975f15b5d28199bbf72f1","unresolved":false,"context_lines":[{"line_number":978,"context_line":"            # Otherwise it\u0027s a stale port that can be removed"},{"line_number":979,"context_line":"            fixed_ips \u003d port_db[\u0027fixed_ips\u0027]"},{"line_number":980,"context_line":"            if fixed_ips:"},{"line_number":981,"context_line":"                reason \u003d \u0027has device owner %s\u0027 % port_db[\u0027device_owner\u0027]"},{"line_number":982,"context_line":"                raise n_exc.ServicePortInUse(port_id\u003dport_db[\u0027id\u0027],"},{"line_number":983,"context_line":"                                             reason\u003dreason)"},{"line_number":984,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_a2e6c6ae","line":981,"in_reply_to":"9a80dd14_dc3bbb35","updated":"2015-03-17 00:17:15.000000000","message":"Done","commit_id":"0d25809da979f8e8012dcd7b824120847b7d8713"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"31a3ae32273f772b20844e81793a32831f0ee40f","unresolved":false,"context_lines":[{"line_number":1313,"context_line":"# from l3_db and may need the callbacks to be processed. Having an implicit"},{"line_number":1314,"context_line":"# subscription (through the module import) preserves the existing behavior,"},{"line_number":1315,"context_line":"# and at the same time it avoids fixing it manually in each and every l3 plugin"},{"line_number":1316,"context_line":"# in outta there. That said, The subscription is also made explicit in the"},{"line_number":1317,"context_line":"# reference l3 plugin. The subscription operation is idempotent so there is no"},{"line_number":1318,"context_line":"# harm in registering the same callback multiple times."},{"line_number":1319,"context_line":"subscribe()"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_91be3763","line":1316,"updated":"2015-03-20 12:47:33.000000000","message":"Nit: in outta -\u003e out","commit_id":"7c7ed5df70e727a72f04154a19863b58d833477b"}],"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1fbbd86b28ebfc9d9ecf223de96626144be86cbb","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    l3plugin.dvr_vmarp_table_update(context, port, \"del\")"},{"line_number":344,"context_line":"    for router in removed_routers:"},{"line_number":345,"context_line":"        try:"},{"line_number":346,"context_line":"            l3plugin.remove_router_from_l3_agent("},{"line_number":347,"context_line":"                context, router[\u0027agent_id\u0027], router[\u0027router_id\u0027])"},{"line_number":348,"context_line":"        except l3agentscheduler.RouterNotHostedByL3Agent:"},{"line_number":349,"context_line":"            # router may have been removed by another process"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_08193579","line":346,"updated":"2015-02-23 12:42:45.000000000","message":"Are remove_router_from_l3_agent called in a global db transaction? If so a db error in remove_router_from_l3_agent (more precisely in _unbind_router) will break the subtransaction and the global transaction \u003d\u003e so all _unbind_router succeed or none will be commited in db.","commit_id":"1cad1edbd7244715b6910d3e0c18b3b876f67e10"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9b22a322121e74f4909d2b156a9253e14026c57f","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    l3plugin.dvr_vmarp_table_update(context, port, \"del\")"},{"line_number":344,"context_line":"    for router in removed_routers:"},{"line_number":345,"context_line":"        try:"},{"line_number":346,"context_line":"            l3plugin.remove_router_from_l3_agent("},{"line_number":347,"context_line":"                context, router[\u0027agent_id\u0027], router[\u0027router_id\u0027])"},{"line_number":348,"context_line":"        except l3agentscheduler.RouterNotHostedByL3Agent:"},{"line_number":349,"context_line":"            # router may have been removed by another process"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_cdfe0fae","line":346,"in_reply_to":"ba7be1f8_08193579","updated":"2015-02-24 17:41:26.000000000","message":"not sure I understand the context of this question, or what you\u0027re asking. I believe this code preserves the old transactional behavior. Do you have evidence that it doesn\u0027t?","commit_id":"1cad1edbd7244715b6910d3e0c18b3b876f67e10"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"86df3dfcf1c5f6c9ad914810cbbf1d88817d1e2a","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    l3plugin.dvr_vmarp_table_update(context, port, \"del\")"},{"line_number":344,"context_line":"    for router in removed_routers:"},{"line_number":345,"context_line":"        try:"},{"line_number":346,"context_line":"            l3plugin.remove_router_from_l3_agent("},{"line_number":347,"context_line":"                context, router[\u0027agent_id\u0027], router[\u0027router_id\u0027])"},{"line_number":348,"context_line":"        except l3agentscheduler.RouterNotHostedByL3Agent:"},{"line_number":349,"context_line":"            # router may have been removed by another process"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_8044bf1b","line":346,"in_reply_to":"ba7be1f8_cdfe0fae","updated":"2015-02-25 09:31:06.000000000","message":"it preserves previous behavior so let\u0027s got for it","commit_id":"1cad1edbd7244715b6910d3e0c18b3b876f67e10"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ce69466af7d88b1199583f98a14a474747e4cadd","unresolved":false,"context_lines":[{"line_number":1113,"context_line":"                resources.PORT, events.BEFORE_DELETE, self, **kwargs)"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"        except exceptions.CallbackFailure:"},{"line_number":1116,"context_line":"            # TODO(armax): add reason when change #153757 merges"},{"line_number":1117,"context_line":"            raise exc.ServicePortInUse(port_id\u003dport_id)"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"    def delete_port(self, context, id, l3_port_check\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_83654647","line":1116,"updated":"2015-02-20 11:22:37.000000000","message":"This has merged.","commit_id":"98e35e9bba44e99ac3ac4eab378bacb657e124a2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"394e6d2ed87ce4a3b7330e9550e4422b1c57ea7f","unresolved":false,"context_lines":[{"line_number":1113,"context_line":"                resources.PORT, events.BEFORE_DELETE, self, **kwargs)"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"        except exceptions.CallbackFailure:"},{"line_number":1116,"context_line":"            # TODO(armax): add reason when change #153757 merges"},{"line_number":1117,"context_line":"            raise exc.ServicePortInUse(port_id\u003dport_id)"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"    def delete_port(self, context, id, l3_port_check\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_ffd67cc4","line":1116,"in_reply_to":"ba7be1f8_83654647","updated":"2015-02-20 21:46:09.000000000","message":"Done","commit_id":"98e35e9bba44e99ac3ac4eab378bacb657e124a2"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ce69466af7d88b1199583f98a14a474747e4cadd","unresolved":false,"context_lines":[{"line_number":1181,"context_line":"            \u0027router_ids\u0027: router_ids,"},{"line_number":1182,"context_line":"            \u0027removed_routers\u0027: removed_routers"},{"line_number":1183,"context_line":"        }"},{"line_number":1184,"context_line":"        registry.notify(resources.PORT, events.AFTER_DELETE, self, **kwargs)"},{"line_number":1185,"context_line":"        try:"},{"line_number":1186,"context_line":"            # Note that DVR Interface ports will have bindings on"},{"line_number":1187,"context_line":"            # multiple hosts, and so will have multiple mech_contexts,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_ae81514c","line":1184,"updated":"2015-02-20 11:22:37.000000000","message":"Is ordering critical here? If the notification can live at the very end, I would like to turn all of this notification handling into a single decorator that can wrap the delete_port operation (doesn\u0027t have to be part of this patch).","commit_id":"98e35e9bba44e99ac3ac4eab378bacb657e124a2"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8d227dc725bcf99af8ae9b92432e2951fa324246","unresolved":false,"context_lines":[{"line_number":1181,"context_line":"            \u0027router_ids\u0027: router_ids,"},{"line_number":1182,"context_line":"            \u0027removed_routers\u0027: removed_routers"},{"line_number":1183,"context_line":"        }"},{"line_number":1184,"context_line":"        registry.notify(resources.PORT, events.AFTER_DELETE, self, **kwargs)"},{"line_number":1185,"context_line":"        try:"},{"line_number":1186,"context_line":"            # Note that DVR Interface ports will have bindings on"},{"line_number":1187,"context_line":"            # multiple hosts, and so will have multiple mech_contexts,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_cae4913d","line":1184,"in_reply_to":"ba7be1f8_9fbca06e","updated":"2015-02-21 01:28:32.000000000","message":"The reason I was partial to a decorator is that I was hoping to keep as much code related to notifications out of the plugin as possible. Similar to the other suggestions I was making, it\u0027s really just a personal preference and doesn\u0027t really matter.","commit_id":"98e35e9bba44e99ac3ac4eab378bacb657e124a2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"394e6d2ed87ce4a3b7330e9550e4422b1c57ea7f","unresolved":false,"context_lines":[{"line_number":1181,"context_line":"            \u0027router_ids\u0027: router_ids,"},{"line_number":1182,"context_line":"            \u0027removed_routers\u0027: removed_routers"},{"line_number":1183,"context_line":"        }"},{"line_number":1184,"context_line":"        registry.notify(resources.PORT, events.AFTER_DELETE, self, **kwargs)"},{"line_number":1185,"context_line":"        try:"},{"line_number":1186,"context_line":"            # Note that DVR Interface ports will have bindings on"},{"line_number":1187,"context_line":"            # multiple hosts, and so will have multiple mech_contexts,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_9fbca06e","line":1184,"in_reply_to":"ba7be1f8_ae81514c","updated":"2015-02-20 21:46:09.000000000","message":"The order is critical in that the notification needs to take place after the delete operation is complete. That a decorator is doable but I am not sure how much benefit will get out of it.\n\nI went with this approach that sounded simpler to my eyes.","commit_id":"98e35e9bba44e99ac3ac4eab378bacb657e124a2"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"190cb06129fb1efdca275c38a1319bb888b2da35","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"        try:"},{"line_number":1105,"context_line":"            # notify interested parties of imminent port deletion;"},{"line_number":1106,"context_line":"            # a failure here prevents the operation from happening"},{"line_number":1107,"context_line":"            kwargs \u003d {"},{"line_number":1108,"context_line":"                \u0027context\u0027: context,"},{"line_number":1109,"context_line":"                \u0027port_id\u0027: port_id,"},{"line_number":1110,"context_line":"                \u0027port_check\u0027: port_check"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_30e69345","line":1107,"updated":"2015-02-27 09:51:15.000000000","message":"why only just a few of the arguments? I say all or nothing!\n\nkwargs \u003d {\n    \u0027resource\u0027: resources.PORT,\n    \u0027event\u0027: events.BEFORE_DELETE,\n    \u0027trigger\u0027: self,\n    \u0027context\u0027: context,\n    \u0027port_id\u0027: port_id,\n    \u0027port_check\u0027: port_check\n}\nregistry.notify(**kwargs)","commit_id":"8c38cd6b1977931aa4e024d1c27472fa2e48df89"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"190cb06129fb1efdca275c38a1319bb888b2da35","unresolved":false,"context_lines":[{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"    def _post_delete_port("},{"line_number":1178,"context_line":"        self, context, port, router_ids, removed_routers, bound_mech_contexts):"},{"line_number":1179,"context_line":"        kwargs \u003d {"},{"line_number":1180,"context_line":"            \u0027context\u0027: context,"},{"line_number":1181,"context_line":"            \u0027port\u0027: port,"},{"line_number":1182,"context_line":"            \u0027router_ids\u0027: router_ids,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_70cf2bb4","line":1179,"updated":"2015-02-27 09:51:15.000000000","message":"ditto","commit_id":"8c38cd6b1977931aa4e024d1c27472fa2e48df89"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"31a3ae32273f772b20844e81793a32831f0ee40f","unresolved":false,"context_lines":[{"line_number":1128,"context_line":""},{"line_number":1129,"context_line":"    def delete_port(self, context, id, l3_port_check\u003dTrue):"},{"line_number":1130,"context_line":"        self._pre_delete_port(context, id, l3_port_check)"},{"line_number":1131,"context_line":"        session \u003d context.session"},{"line_number":1132,"context_line":"        # TODO(armax): get rid of the l3 dependency in the with block"},{"line_number":1133,"context_line":"        removed_routers \u003d []"},{"line_number":1134,"context_line":"        router_ids \u003d []"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_6517b8ee","line":1131,"updated":"2015-03-20 12:47:33.000000000","message":"Nit: Not needed here, it\u0027s done at line 1140.","commit_id":"7c7ed5df70e727a72f04154a19863b58d833477b"}]}
