)]}'
{"quantum/tests/unit/test_l3_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"f3e9916470c5620217b14d38979db860c8fa622a","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        instance.get_routers.assert_called_with(mock.ANY, fields\u003dmock.ANY,"},{"line_number":144,"context_line":"                                                filters\u003dmock.ANY)"},{"line_number":145,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_router_update(self):"},{"line_number":148,"context_line":"        router_id \u003d _uuid()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2FwdE%3D","line":145,"updated":"2012-11-08 05:00:36.000000000","message":"Shouldn\u0027t there be a check to make sure that res.body is actually the expected return value and not only a 200.","commit_id":"260d9d612c3af5e68f6b6208fe50e07fc7df7988"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        instance.get_routers.assert_called_with(mock.ANY, fields\u003dmock.ANY,"},{"line_number":144,"context_line":"                                                filters\u003dmock.ANY)"},{"line_number":145,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_router_update(self):"},{"line_number":148,"context_line":"        router_id \u003d _uuid()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F%2FyY%3D","line":145,"in_reply_to":"AAAALn%2F%2FwYQ%3D","updated":"2012-11-12 09:36:26.000000000","message":"I agree with Mark but however it doesn\u0027t seem to be the scope of this patch. I\u0027ll put this on my TODO list.","commit_id":"260d9d612c3af5e68f6b6208fe50e07fc7df7988"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5ac45b8a86a11f106c74010578cb24f341d4f782","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        instance.get_routers.assert_called_with(mock.ANY, fields\u003dmock.ANY,"},{"line_number":144,"context_line":"                                                filters\u003dmock.ANY)"},{"line_number":145,"context_line":"        self.assertEqual(res.status_int, exc.HTTPOk.code)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_router_update(self):"},{"line_number":148,"context_line":"        router_id \u003d _uuid()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2FwYQ%3D","line":145,"in_reply_to":"AAAALn%2F%2FwdE%3D","updated":"2012-11-08 06:18:52.000000000","message":"Emm..  Found the test of TestL3NatPlugin don\u0027t looks like testing l3 plugin. It tests how controller pass the params to plugin and how contoller return the result. So it similar with test_api_v2.py:JSONV2TestCase doing. How about move all test of TestL3NatPlugin to L3NatDBTestCase and remove TestL3NatPlugin?\nThanks for the view!","commit_id":"260d9d612c3af5e68f6b6208fe50e07fc7df7988"}]}