)]}'
{"quantum/db/l3_db.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"21106a205cd03f0b1b3b48242c77eaa6d8375936","unresolved":false,"context_lines":[{"line_number":525,"context_line":"                fip_qry.filter_by("},{"line_number":526,"context_line":"                    fixed_port_id\u003dfip[\u0027port_id\u0027],"},{"line_number":527,"context_line":"                    floating_network_id\u003dfloatingip_db[\u0027floating_network_id\u0027],"},{"line_number":528,"context_line":"                    fixed_ip_address\u003dinternal_ip_address).one()"},{"line_number":529,"context_line":"                raise l3.FloatingIPPortAlreadyAssociated("},{"line_number":530,"context_line":"                    port_id\u003dfip[\u0027port_id\u0027],"},{"line_number":531,"context_line":"                    fip_id\u003dfloatingip_db[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2FuFQ%3D","line":528,"updated":"2012-11-10 01:08:51.000000000","message":"So with this change, we support:\none fixed port with 10.0.1.1 and 10.0.1.2\nfloaingip1: 7.0.1.1 \u003c-\u003e 10.0.1.1\nfloatingip2: 7.0.1.2 \u003c-\u003e 10.0.1.2\ngate floating_network_id guarantees the SNAT and DNAT rules  are in dirrent name space.\n\nSo this feature need namespace support, right?","commit_id":"ebcb7b5c5e96eb26de0789c4d1248ddb6f830578"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"21106a205cd03f0b1b3b48242c77eaa6d8375936","unresolved":false,"context_lines":[{"line_number":525,"context_line":"                fip_qry.filter_by("},{"line_number":526,"context_line":"                    fixed_port_id\u003dfip[\u0027port_id\u0027],"},{"line_number":527,"context_line":"                    floating_network_id\u003dfloatingip_db[\u0027floating_network_id\u0027],"},{"line_number":528,"context_line":"                    fixed_ip_address\u003dinternal_ip_address).one()"},{"line_number":529,"context_line":"                raise l3.FloatingIPPortAlreadyAssociated("},{"line_number":530,"context_line":"                    port_id\u003dfip[\u0027port_id\u0027],"},{"line_number":531,"context_line":"                    fip_id\u003dfloatingip_db[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2F%2F7Q%3D","line":528,"in_reply_to":"AAAALn%2F%2Ft6g%3D","updated":"2012-11-12 02:27:39.000000000","message":"how do u want to support the same fixed_port and fixed ip to floating ips on different external networks?","commit_id":"ebcb7b5c5e96eb26de0789c4d1248ddb6f830578"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":525,"context_line":"                fip_qry.filter_by("},{"line_number":526,"context_line":"                    fixed_port_id\u003dfip[\u0027port_id\u0027],"},{"line_number":527,"context_line":"                    floating_network_id\u003dfloatingip_db[\u0027floating_network_id\u0027],"},{"line_number":528,"context_line":"                    fixed_ip_address\u003dinternal_ip_address).one()"},{"line_number":529,"context_line":"                raise l3.FloatingIPPortAlreadyAssociated("},{"line_number":530,"context_line":"                    port_id\u003dfip[\u0027port_id\u0027],"},{"line_number":531,"context_line":"                    fip_id\u003dfloatingip_db[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALn%2F%2Ft6g%3D","line":528,"in_reply_to":"AAAALn%2F%2FuFQ%3D","updated":"2012-11-10 12:37:06.000000000","message":"I don\u0027t believe this requires namespaces.  To give some more detail, there are actually TWO new cases supported by this change, though one of them is not really possible with the existing L3 Agent yet.  \n\n1) Multiple floating IPs map to the same port, but to different fixed IPs on the same port.  \n\n2) Multiple floating IPs map to the same port and same fixed IP, but each of the floating IPs is on a different external network.\n\nTo understand this, you have to go back to why we limit duplicate floating IPs in the first place, which is to avoid ambiguity when deciding how to SNAT connections initiated by VMs.  The semantics of floating IPs says that if a VM has a floating IP, that should be the public IP of the VM on the external network, even if the connection was initiated by the VM, rather than be an external host connecting to the floating IP.  If there were multiple floating IPs for the same internal fixed IP, the NAT rule to SNAT these new connections wouldn\u0027t know which floating IP to use.  The exception to this is if the floating IPs on are different external networks, in which case the router should use the floating IP on the external network that its routing the outbound connection to.","commit_id":"ebcb7b5c5e96eb26de0789c4d1248ddb6f830578"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"21106a205cd03f0b1b3b48242c77eaa6d8375936","unresolved":false,"context_lines":[{"line_number":525,"context_line":"                fip_qry.filter_by("},{"line_number":526,"context_line":"                    fixed_port_id\u003dfip[\u0027port_id\u0027],"},{"line_number":527,"context_line":"                    floating_network_id\u003dfloatingip_db[\u0027floating_network_id\u0027],"},{"line_number":528,"context_line":"                    fixed_ip_address\u003dinternal_ip_address).one()"},{"line_number":529,"context_line":"                raise l3.FloatingIPPortAlreadyAssociated("},{"line_number":530,"context_line":"                    port_id\u003dfip[\u0027port_id\u0027],"},{"line_number":531,"context_line":"                    fip_id\u003dfloatingip_db[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2F9YM%3D","line":528,"in_reply_to":"AAAAMH%2F%2F%2BAo%3D","updated":"2012-11-14 05:32:41.000000000","message":"ok, Thanks","commit_id":"ebcb7b5c5e96eb26de0789c4d1248ddb6f830578"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":525,"context_line":"                fip_qry.filter_by("},{"line_number":526,"context_line":"                    fixed_port_id\u003dfip[\u0027port_id\u0027],"},{"line_number":527,"context_line":"                    floating_network_id\u003dfloatingip_db[\u0027floating_network_id\u0027],"},{"line_number":528,"context_line":"                    fixed_ip_address\u003dinternal_ip_address).one()"},{"line_number":529,"context_line":"                raise l3.FloatingIPPortAlreadyAssociated("},{"line_number":530,"context_line":"                    port_id\u003dfip[\u0027port_id\u0027],"},{"line_number":531,"context_line":"                    fip_id\u003dfloatingip_db[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2F%2BAo%3D","line":528,"in_reply_to":"AAAAMH%2F%2F%2F7Q%3D","updated":"2012-11-13 18:35:45.000000000","message":"We\u0027re planning on enabling routers to uplink to multiple external networks... i think sachin is working on a blueprint.  But I don\u0027t think there is a concern in the mean time, as get_assoc_data (above) already does a separate \"reachability check\"  that will prevent a floating IP from being associated with a port if that port is not on a network that has access to a particular external network.","commit_id":"ebcb7b5c5e96eb26de0789c4d1248ddb6f830578"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":527,"context_line":"                    floating_network_id\u003dfloatingip_db[\u0027floating_network_id\u0027],"},{"line_number":528,"context_line":"                    fixed_ip_address\u003dinternal_ip_address).one()"},{"line_number":529,"context_line":"                raise l3.FloatingIPPortAlreadyAssociated("},{"line_number":530,"context_line":"                    port_id\u003dfip[\u0027port_id\u0027],"},{"line_number":531,"context_line":"                    fip_id\u003dfloatingip_db[\u0027id\u0027],"},{"line_number":532,"context_line":"                    fixed_ip\u003dinternal_ip_address,"},{"line_number":533,"context_line":"                    net_id\u003dfloatingip_db[\u0027floating_network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2F7NA%3D","line":530,"updated":"2012-11-15 17:06:46.000000000","message":"It seems this exception might use floating_ip_address keyword argument","commit_id":"01c1a21d08e8f79e21c531cebcc50489708d06ea"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":527,"context_line":"                    floating_network_id\u003dfloatingip_db[\u0027floating_network_id\u0027],"},{"line_number":528,"context_line":"                    fixed_ip_address\u003dinternal_ip_address).one()"},{"line_number":529,"context_line":"                raise l3.FloatingIPPortAlreadyAssociated("},{"line_number":530,"context_line":"                    port_id\u003dfip[\u0027port_id\u0027],"},{"line_number":531,"context_line":"                    fip_id\u003dfloatingip_db[\u0027id\u0027],"},{"line_number":532,"context_line":"                    fixed_ip\u003dinternal_ip_address,"},{"line_number":533,"context_line":"                    net_id\u003dfloatingip_db[\u0027floating_network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2F1oM%3D","line":530,"in_reply_to":"AAAAMH%2F%2F7NA%3D","updated":"2012-11-20 20:42:59.000000000","message":"Done","commit_id":"01c1a21d08e8f79e21c531cebcc50489708d06ea"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":434,"context_line":"        for intf_p in router_intf_ports:"},{"line_number":435,"context_line":"            for fixed_ip in intf_p[\u0027fixed_ips\u0027]:"},{"line_number":436,"context_line":"                if fixed_ip[\u0027subnet_id\u0027] \u003d\u003d internal_subnet_id:"},{"line_number":437,"context_line":"                    router_id \u003d intf_p[\u0027device_id\u0027]"},{"line_number":438,"context_line":"                    router_gw_qry \u003d context.session.query(models_v2.Port)"},{"line_number":439,"context_line":"                    has_gw_port \u003d router_gw_qry.filter_by("},{"line_number":440,"context_line":"                        network_id\u003dexternal_network_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F1Tw%3D","line":437,"updated":"2012-11-20 21:19:05.000000000","message":"Look like lines 437-442 could be moved outside the loop that begins on 435.  If the count is 0, there is no reason to loop through the fixed_ips.  Thoughts?","commit_id":"b0516024677033b09d57aa7c2269ec0d4f379d10"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":434,"context_line":"        for intf_p in router_intf_ports:"},{"line_number":435,"context_line":"            for fixed_ip in intf_p[\u0027fixed_ips\u0027]:"},{"line_number":436,"context_line":"                if fixed_ip[\u0027subnet_id\u0027] \u003d\u003d internal_subnet_id:"},{"line_number":437,"context_line":"                    router_id \u003d intf_p[\u0027device_id\u0027]"},{"line_number":438,"context_line":"                    router_gw_qry \u003d context.session.query(models_v2.Port)"},{"line_number":439,"context_line":"                    has_gw_port \u003d router_gw_qry.filter_by("},{"line_number":440,"context_line":"                        network_id\u003dexternal_network_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F1N0%3D","line":437,"in_reply_to":"AAAAMH%2F%2F1O8%3D","updated":"2012-11-20 22:04:15.000000000","message":"Actually, for a given router-interface port, there is always going to be exactly one fixed-ip, so I think it makes sense to just rewrite the code to make that clear.","commit_id":"b0516024677033b09d57aa7c2269ec0d4f379d10"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":434,"context_line":"        for intf_p in router_intf_ports:"},{"line_number":435,"context_line":"            for fixed_ip in intf_p[\u0027fixed_ips\u0027]:"},{"line_number":436,"context_line":"                if fixed_ip[\u0027subnet_id\u0027] \u003d\u003d internal_subnet_id:"},{"line_number":437,"context_line":"                    router_id \u003d intf_p[\u0027device_id\u0027]"},{"line_number":438,"context_line":"                    router_gw_qry \u003d context.session.query(models_v2.Port)"},{"line_number":439,"context_line":"                    has_gw_port \u003d router_gw_qry.filter_by("},{"line_number":440,"context_line":"                        network_id\u003dexternal_network_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2F1O8%3D","line":437,"in_reply_to":"AAAAMH%2F%2F1Tw%3D","updated":"2012-11-20 21:54:46.000000000","message":"yeah, since the count look-up is likely to be cheaper, it makes sense to do it on the outside.","commit_id":"b0516024677033b09d57aa7c2269ec0d4f379d10"}],"quantum/extensions/l3.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":52,"context_line":"class FloatingIPPortAlreadyAssociated(qexception.InUse):"},{"line_number":53,"context_line":"    message \u003d _(\"Port %(port_id)s has conflicting floating IP %(fip_id)s\""},{"line_number":54,"context_line":"                \" associated with it that already uses external network \""},{"line_number":55,"context_line":"                \" %(net_id)s and fixed IP %(fixed_ip)s\")"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class L3PortInUse(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2F83I%3D","line":55,"updated":"2012-11-14 16:29:38.000000000","message":"The message is a little hard to understand for me. My proposal is: \"Fixed IP %(fixed_ip)s of port %(port_id)s is already associated with floating IP %(fip_id)s on external network %(net_id)\"\n\nIn addition it is better to use floating_ip_address rather than fip_id in the message above. It is easier to understand.","commit_id":"ebcb7b5c5e96eb26de0789c4d1248ddb6f830578"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":52,"context_line":"class FloatingIPPortAlreadyAssociated(qexception.InUse):"},{"line_number":53,"context_line":"    message \u003d _(\"Port %(port_id)s has conflicting floating IP %(fip_id)s\""},{"line_number":54,"context_line":"                \" associated with it that already uses external network \""},{"line_number":55,"context_line":"                \" %(net_id)s and fixed IP %(fixed_ip)s\")"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class L3PortInUse(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2F7O0%3D","line":55,"in_reply_to":"AAAAMH%2F%2F83I%3D","updated":"2012-11-15 16:46:19.000000000","message":"Done","commit_id":"ebcb7b5c5e96eb26de0789c4d1248ddb6f830578"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class FloatingIPPortAlreadyAssociated(qexception.InUse):"},{"line_number":53,"context_line":"    message \u003d _(\"Cannot associated floating IP %(fip_id)s \""},{"line_number":54,"context_line":"               \"(%(floating_ip_address)s) with port %(port_id)s \""},{"line_number":55,"context_line":"               \"using fixed IP %(fixed_ip)s, as that fixed IP already \""},{"line_number":56,"context_line":"               \"has a floating IP on external network %(net_id)s.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2F7OQ%3D","line":53,"updated":"2012-11-15 17:06:46.000000000","message":"associated --\u003e associate","commit_id":"01c1a21d08e8f79e21c531cebcc50489708d06ea"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class FloatingIPPortAlreadyAssociated(qexception.InUse):"},{"line_number":53,"context_line":"    message \u003d _(\"Cannot associated floating IP %(fip_id)s \""},{"line_number":54,"context_line":"               \"(%(floating_ip_address)s) with port %(port_id)s \""},{"line_number":55,"context_line":"               \"using fixed IP %(fixed_ip)s, as that fixed IP already \""},{"line_number":56,"context_line":"               \"has a floating IP on external network %(net_id)s.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2F1oI%3D","line":53,"in_reply_to":"AAAAMH%2F%2F7OQ%3D","updated":"2012-11-20 20:42:59.000000000","message":"Done","commit_id":"01c1a21d08e8f79e21c531cebcc50489708d06ea"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class FloatingIPPortAlreadyAssociated(qexception.InUse):"},{"line_number":53,"context_line":"    message \u003d _(\"Cannot associated floating IP %(fip_id)s \""},{"line_number":54,"context_line":"               \"(%(floating_ip_address)s) with port %(port_id)s \""},{"line_number":55,"context_line":"               \"using fixed IP %(fixed_ip)s, as that fixed IP already \""},{"line_number":56,"context_line":"               \"has a floating IP on external network %(net_id)s.\")"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2F7OI%3D","line":54,"updated":"2012-11-15 17:06:46.000000000","message":"perhaps consider inverting id and ip, putting the id in parentheses","commit_id":"01c1a21d08e8f79e21c531cebcc50489708d06ea"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class FloatingIPPortAlreadyAssociated(qexception.InUse):"},{"line_number":53,"context_line":"    message \u003d _(\"Cannot associated floating IP %(fip_id)s \""},{"line_number":54,"context_line":"               \"(%(floating_ip_address)s) with port %(port_id)s \""},{"line_number":55,"context_line":"               \"using fixed IP %(fixed_ip)s, as that fixed IP already \""},{"line_number":56,"context_line":"               \"has a floating IP on external network %(net_id)s.\")"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2F1oE%3D","line":54,"in_reply_to":"AAAAMH%2F%2F7OI%3D","updated":"2012-11-20 20:42:59.000000000","message":"Done","commit_id":"01c1a21d08e8f79e21c531cebcc50489708d06ea"}]}
