)]}'
{"neutron/agent/linux/ebtables_driver.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"fb45c4a5afdefe84ef4fb97d38817cdf5e02f1f1","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    Acts as a context for the running of ebtables."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    \"\"\""},{"line_number":200,"context_line":"    def __init__(self, namespace, execute, use_atomic_file\u003dTrue):"},{"line_number":201,"context_line":"        \"\"\"Setting up a context for the running of the ebtables utility."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        \u0027execute\u0027 is configurable, since different contexts (test vs."}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_6834bedd","line":200,"updated":"2015-04-28 20:46:08.000000000","message":"i failed to find when an EbtablesCommandContext with use_atomic_file \u003d\u003d True","commit_id":"1b3c1aeee23859b2cb42408875f24433f7f544fb"}],"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":7409,"name":"Eric Pendergrass","email":"epende@gmail.com","username":"epende"},"change_message_id":"c5715e6b0f63adb2c7f544e1f71f9146bae8690b","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                if rule[\u0027direction\u0027] \u003d\u003d direction]"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def _get_mac_ip_pair(self, port):"},{"line_number":219,"context_line":"        # Note(ethuleau): Why? Insted, we should drop RA from a VM port."},{"line_number":220,"context_line":"        #ipv6_rules +\u003d [\u0027-p icmpv6 -j RETURN\u0027]"},{"line_number":221,"context_line":"        mac_ip_pairs \u003d []"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_f87bd826","line":219,"updated":"2015-03-11 19:23:05.000000000","message":"Commented code","commit_id":"1b3c1aeee23859b2cb42408875f24433f7f544fb"}],"neutron/agent/linux/nwfilter.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"eb81220e15756159699b08597937c5c1de5596d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012, Nachi Ueno, NTT MCL, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_9ec2f883","line":1,"updated":"2015-05-30 01:55:43.000000000","message":"???","commit_id":"1b3c1aeee23859b2cb42408875f24433f7f544fb"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"eb81220e15756159699b08597937c5c1de5596d3","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.ebtables.apply()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def defer_apply_on(self):"},{"line_number":113,"context_line":"        self.ebtables.defer_apply_on()"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def defer_apply_off(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_3e89c426","line":112,"updated":"2015-05-30 01:55:43.000000000","message":"i would prefer a context","commit_id":"1b3c1aeee23859b2cb42408875f24433f7f544fb"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"eb81220e15756159699b08597937c5c1de5596d3","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            rule \u003d \u0027\u0027"},{"line_number":126,"context_line":"        rule +\u003d \u0027-j $%s\u0027 % chain_name"},{"line_number":127,"context_line":"        table.add_rule(self.default_chain, rule, top\u003dTrue)"},{"line_number":128,"context_line":"        #table.add_rule(\u0027OUTPUT\u0027, rule, top\u003dTrue)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        # NOTE(ethuleau): Do we need to apply some filters on traffic going to"},{"line_number":131,"context_line":"        # the device (eg. DHCP request of neighbors)?"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_7ec5fc59","line":128,"updated":"2015-05-30 01:55:43.000000000","message":"commented code","commit_id":"1b3c1aeee23859b2cb42408875f24433f7f544fb"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"eb81220e15756159699b08597937c5c1de5596d3","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            # NOTE(ethuleau): we limit DHCP request to not overload DHCP agents"},{"line_number":143,"context_line":"            # One request per second with a burst of 5 (default value) is"},{"line_number":144,"context_line":"            # enough?"},{"line_number":145,"context_line":"            rules +\u003d [\u0027-p IPv4 --ip-proto %s --ip-sport 68 --ip-dport 67 \u0027"},{"line_number":146,"context_line":"                      \u0027--limit 1/s -j ACCEPT\u0027 % proto]"},{"line_number":147,"context_line":"        return rules"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_dede303d","line":145,"updated":"2015-05-30 01:55:43.000000000","message":"It seems an unrelated change?","commit_id":"1b3c1aeee23859b2cb42408875f24433f7f544fb"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"eb81220e15756159699b08597937c5c1de5596d3","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                      \u0027--limit 1/s -j ACCEPT\u0027 % proto]"},{"line_number":147,"context_line":"        return rules"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def _drop_dhcp_offer_rule(self):"},{"line_number":150,"context_line":"        rules \u003d []"},{"line_number":151,"context_line":"        for proto in [\u0027udp\u0027, \u0027tcp\u0027]:"},{"line_number":152,"context_line":"            rules +\u003d [\u0027-p IPv4 --ip-proto %s --ip-sport 67 --ip-dport 68 \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_3ebb04e7","line":149,"updated":"2015-05-30 01:55:43.000000000","message":"_allow_dhcp_request \u003d\u003d __drop_dhcp_offer_rule \u003d\u003e avoid code duplication and prefer something like get_dhcp_request_rules()","commit_id":"1b3c1aeee23859b2cb42408875f24433f7f544fb"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"eb81220e15756159699b08597937c5c1de5596d3","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                      \u0027-j DROP\u0027 % proto]"},{"line_number":154,"context_line":"        return rules"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _setup_mac_ip_antispoofing(self, mac_ip_pairs):"},{"line_number":157,"context_line":"        rules \u003d []"},{"line_number":158,"context_line":"        for mac, ip in mac_ip_pairs:"},{"line_number":159,"context_line":"            if ip is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_fea7acb9","line":156,"updated":"2015-05-30 01:55:43.000000000","message":"method name is confusing as the method setups nothing but builds rules","commit_id":"1b3c1aeee23859b2cb42408875f24433f7f544fb"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"ff47847c6e80afd23f083b858f2fdfc66035e13b","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            if ip is None:"},{"line_number":160,"context_line":"                rules +\u003d [\u0027-p %s -j RETURN\u0027 % mac]"},{"line_number":161,"context_line":"            else:"},{"line_number":162,"context_line":"                rules +\u003d [\u0027-s %s -p %s --ip-source %s -j RETURN\u0027 %"},{"line_number":163,"context_line":"                          (mac, self._get_ip_protocol(ip), ip)]"},{"line_number":164,"context_line":"        return rules"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_c219087b","line":162,"updated":"2015-04-24 15:53:30.000000000","message":"I have to take a closer look at the rules. But one immediate observation is that for IPv6, the rule should be --ip6-source.","commit_id":"1b3c1aeee23859b2cb42408875f24433f7f544fb"}]}
