)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"98789de5734111c9465f51f322e8f418a6cebead","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make updating port mac_address configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To allow tempest tests to be written, add a config variable to"},{"line_number":10,"context_line":"enable/disable update of port mac_address.  Default to true."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-implements blueprint allow-mac-to-be-updated"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_b885575b","line":9,"updated":"2015-02-25 22:00:56.000000000","message":"Curious: Do you mean tempest or functional tests? Is this for tests in the tempest repo or for tests in neutron\u0027s functional test area?","commit_id":"6a6bbbb15e2d7029a92e27469081c9686b148c77"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"ad450fdcd650198359d9bfa3e7c82821596898bb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make updating port mac_address configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To allow tempest tests to be written, add a config variable to"},{"line_number":10,"context_line":"enable/disable update of port mac_address.  Default to true."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-implements blueprint allow-mac-to-be-updated"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_5b1e150d","line":9,"in_reply_to":"ba7be1f8_b885575b","updated":"2015-02-25 22:32:17.000000000","message":"In https://review.openstack.org/#/c/151804, I wrote an api test that fails check-tempest-dsvm-neutron-full-juno.  Of course, updating mac addresses fails on Juno :)","commit_id":"6a6bbbb15e2d7029a92e27469081c9686b148c77"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"98789de5734111c9465f51f322e8f418a6cebead","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To allow tempest tests to be written, add a config variable to"},{"line_number":10,"context_line":"enable/disable update of port mac_address.  Default to true."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-implements blueprint allow-mac-to-be-updated"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5d5c950e265dfea69c47e7842ccd4c81f50f8513"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_784aff55","line":12,"updated":"2015-02-25 22:00:56.000000000","message":"nit:\n    Partially-Implements: blueprint allow-mac-to-be-updated","commit_id":"6a6bbbb15e2d7029a92e27469081c9686b148c77"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"ad450fdcd650198359d9bfa3e7c82821596898bb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To allow tempest tests to be written, add a config variable to"},{"line_number":10,"context_line":"enable/disable update of port mac_address.  Default to true."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-implements blueprint allow-mac-to-be-updated"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5d5c950e265dfea69c47e7842ccd4c81f50f8513"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_7bf039c9","line":12,"in_reply_to":"ba7be1f8_784aff55","updated":"2015-02-25 22:32:17.000000000","message":"Done","commit_id":"6a6bbbb15e2d7029a92e27469081c9686b148c77"},{"author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"change_message_id":"db4677490e1f5513b13df7e9d93cfaabb6cb1803","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To allow tempest tests to be written, add a config variable to"},{"line_number":10,"context_line":"enable/disable update of port mac_address.  Default to true."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements blueprint allow-mac-to-be-updated"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5d5c950e265dfea69c47e7842ccd4c81f50f8513"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba7be1f8_fca7bcba","line":12,"updated":"2015-02-26 01:32:46.000000000","message":"This link is confusing and doesn\u0027t exist. Is the BP reference needed?","commit_id":"9d617f88ac40dd5ddcb6f9d0de612fde9bb5b19a"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"9538e7e04c94d269a9653efc06572dfcb9dbc5ad","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To allow tempest tests to be written, add a config variable to"},{"line_number":10,"context_line":"enable/disable update of port mac_address.  Default to true."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements blueprint allow-mac-to-be-updated"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5d5c950e265dfea69c47e7842ccd4c81f50f8513"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba7be1f8_ae2255a0","line":12,"in_reply_to":"ba7be1f8_fca7bcba","updated":"2015-02-26 13:51:14.000000000","message":"The link is for a blueprint spec. See https://blueprints.launchpad.net/neutron/+spec/allow-mac-to-be-updated\n\nNit: Chuck, there should be a colon after the Implements. :)","commit_id":"9d617f88ac40dd5ddcb6f9d0de612fde9bb5b19a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ef4af723a96acc5bc5e717a8c61deaf933804119","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make updating port mac_address configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To allow tempest tests to be written, add a config variable to"},{"line_number":10,"context_line":"enable/disable update of port mac_address.  Default to true."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1426002"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba7be1f8_29a2424b","line":10,"updated":"2015-03-03 02:16:51.000000000","message":"can you explain how this will be used by tempest tests?\n(if the tests are available somewhere, a pointer is enough.)","commit_id":"17b5470a37f2a0d45ce15264c8f7011467ac9249"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7726ac0ce3affc1886c6e1b7fbb1b71995b544e5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make updating port mac_address configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To allow tempest tests to be written, add a config variable to"},{"line_number":10,"context_line":"enable/disable update of port mac_address.  Because tempest runs against juno, the test needs to check something to avoid running against juno.  Hence this variable, which defaults to true for kilo+."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1426002"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a80dd14_942f17a1","line":10,"updated":"2015-03-05 07:41:08.000000000","message":"please use a new line after 79 characters :)","commit_id":"2090330551e2cab5e71e375b2ef5c78dd7407f26"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"3c3509da18ed6bc69d941da6ff9c7af3cede203a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make updating port mac_address configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To allow tempest tests to be written, add a config variable to"},{"line_number":10,"context_line":"enable/disable update of port mac_address.  Because tempest runs against juno, the test needs to check something to avoid running against juno.  Hence this variable, which defaults to true for kilo+."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1426002"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a80dd14_f22ac78e","line":10,"in_reply_to":"9a80dd14_942f17a1","updated":"2015-03-06 18:36:02.000000000","message":"Done","commit_id":"2090330551e2cab5e71e375b2ef5c78dd7407f26"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7726ac0ce3affc1886c6e1b7fbb1b71995b544e5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To allow tempest tests to be written, add a config variable to"},{"line_number":10,"context_line":"enable/disable update of port mac_address.  Because tempest runs against juno, the test needs to check something to avoid running against juno.  Hence this variable, which defaults to true for kilo+."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1426002"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5d5c950e265dfea69c47e7842ccd4c81f50f8513"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a80dd14_f41db374","line":12,"updated":"2015-03-05 07:41:08.000000000","message":"Please add DocImpact and indicate the config variable","commit_id":"2090330551e2cab5e71e375b2ef5c78dd7407f26"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"3c3509da18ed6bc69d941da6ff9c7af3cede203a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To allow tempest tests to be written, add a config variable to"},{"line_number":10,"context_line":"enable/disable update of port mac_address.  Because tempest runs against juno, the test needs to check something to avoid running against juno.  Hence this variable, which defaults to true for kilo+."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1426002"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5d5c950e265dfea69c47e7842ccd4c81f50f8513"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a80dd14_3220dfab","line":12,"in_reply_to":"9a80dd14_f41db374","updated":"2015-03-06 18:36:02.000000000","message":"Done","commit_id":"2090330551e2cab5e71e375b2ef5c78dd7407f26"}],"etc/neutron.conf":[{"author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"change_message_id":"10f5c52c116724658256e9fe6e01814d3189780a","unresolved":false,"context_lines":[{"line_number":105,"context_line":"# Maximum amount of retries to generate a unique MAC address"},{"line_number":106,"context_line":"# mac_generation_retries \u003d 16"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"# Enable or disable port mac_address updates"},{"line_number":109,"context_line":"# allow_port_mac_address_update \u003d True"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# DHCP Lease duration (in seconds).  Use -1 to"}],"source_content_type":"text/plain","patch_set":5,"id":"ba7be1f8_1599a578","line":108,"updated":"2015-02-26 16:34:15.000000000","message":"Maybe a comment about how this configuration variable is primarily for tempest tests?\n\n\"This is used primarily for tempest tests....\"","commit_id":"1595b4fd6e48adf21e2a1c2c9bf756a799ea0dc1"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"07ec40228a62ee5aacac148fc15b1953c3376800","unresolved":false,"context_lines":[{"line_number":105,"context_line":"# Maximum amount of retries to generate a unique MAC address"},{"line_number":106,"context_line":"# mac_generation_retries \u003d 16"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"# Enable or disable port mac_address updates"},{"line_number":109,"context_line":"# allow_port_mac_address_update \u003d True"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# DHCP Lease duration (in seconds).  Use -1 to"}],"source_content_type":"text/plain","patch_set":5,"id":"ba7be1f8_8e8586d0","line":108,"in_reply_to":"ba7be1f8_1599a578","updated":"2015-02-26 17:30:58.000000000","message":"I think this may be useful, for example, for users of plugins or back ends that can\u0027t support mac address update.","commit_id":"1595b4fd6e48adf21e2a1c2c9bf756a799ea0dc1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7e9b644be367473780a4961f2d5ba5f312c102b7","unresolved":false,"context_lines":[{"line_number":105,"context_line":"# Maximum amount of retries to generate a unique MAC address"},{"line_number":106,"context_line":"# mac_generation_retries \u003d 16"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"# Enable or disable port mac_address updates"},{"line_number":109,"context_line":"# allow_port_mac_address_update \u003d True"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# DHCP Lease duration (in seconds).  Use -1 to"}],"source_content_type":"text/plain","patch_set":9,"id":"9a80dd14_55345d49","line":108,"updated":"2015-03-06 18:51:55.000000000","message":"This is a bad idea, adding a knob just to allow testing sounds backwards to me. Besides, if I understand you correctly, Tempest should be able to handle branches and API\u0027s that have been introduced in different release cycles.\n\nAnother note is about effort [1] where all API tests are moving to Neutron. Granted we are not moving away from Tempest just yet, but I wonder if we need to start adding new tests to the new framework instead.\n\n[1] https://review.openstack.org/#/c/162257/","commit_id":"ea443731b715927b230d0b31ead5b51d71f3fb46"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"change_message_id":"db4677490e1f5513b13df7e9d93cfaabb6cb1803","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1279,"context_line":"        if not cfg.CONF.allow_port_mac_address_update:"},{"line_number":1280,"context_line":"            raise n_exc.BadRequest(msg\u003d\u0027Attribute not allowed in PUT\u0027,"},{"line_number":1281,"context_line":"                                 resource\u003d\u0027port\u0027)"},{"line_number":1282,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1283,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1284,"context_line":"                op\u003d_(\"mac address update\"), port_id\u003did,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_5c7fe814","line":1281,"updated":"2015-02-26 01:32:46.000000000","message":"nit: odd that pep8 didn\u0027t error, but align the R in resource with M in msg.","commit_id":"9d617f88ac40dd5ddcb6f9d0de612fde9bb5b19a"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"9538e7e04c94d269a9653efc06572dfcb9dbc5ad","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1279,"context_line":"        if not cfg.CONF.allow_port_mac_address_update:"},{"line_number":1280,"context_line":"            raise n_exc.BadRequest(msg\u003d\u0027Attribute not allowed in PUT\u0027,"},{"line_number":1281,"context_line":"                                 resource\u003d\u0027port\u0027)"},{"line_number":1282,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1283,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1284,"context_line":"                op\u003d_(\"mac address update\"), port_id\u003did,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_ceb14948","line":1281,"in_reply_to":"ba7be1f8_4bac758c","updated":"2015-02-26 13:51:14.000000000","message":"It\u0027s possible that it is just Gerrit not displaying the line correctly, and they are really lined up. There wasn\u0027t a pep8 failure.","commit_id":"9d617f88ac40dd5ddcb6f9d0de612fde9bb5b19a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"cf4294e8df96f502ee8640be710027c3d8a10241","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1279,"context_line":"        if not cfg.CONF.allow_port_mac_address_update:"},{"line_number":1280,"context_line":"            raise n_exc.BadRequest(msg\u003d\u0027Attribute not allowed in PUT\u0027,"},{"line_number":1281,"context_line":"                                 resource\u003d\u0027port\u0027)"},{"line_number":1282,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1283,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1284,"context_line":"                op\u003d_(\"mac address update\"), port_id\u003did,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_4bac758c","line":1281,"in_reply_to":"ba7be1f8_5c7fe814","updated":"2015-02-26 09:38:46.000000000","message":"It\u0027s not nit, it must be fixed according to the point.","commit_id":"9d617f88ac40dd5ddcb6f9d0de612fde9bb5b19a"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"4c09e4e1088b5826b0430d877a10255cdd68a0c6","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1279,"context_line":"        if not cfg.CONF.allow_port_mac_address_update:"},{"line_number":1280,"context_line":"            raise n_exc.BadRequest(msg\u003d\u0027Attribute not allowed in PUT\u0027,"},{"line_number":1281,"context_line":"                                 resource\u003d\u0027port\u0027)"},{"line_number":1282,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1283,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1284,"context_line":"                op\u003d_(\"mac address update\"), port_id\u003did,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_dddad976","line":1281,"in_reply_to":"ba7be1f8_ceb14948","updated":"2015-02-26 16:26:19.000000000","message":"It was off in the code.  Apparently, pep8 is OK with this, but I fixed anyway.","commit_id":"9d617f88ac40dd5ddcb6f9d0de612fde9bb5b19a"},{"author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"change_message_id":"10f5c52c116724658256e9fe6e01814d3189780a","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1279,"context_line":"        if not cfg.CONF.allow_port_mac_address_update:"},{"line_number":1280,"context_line":"            raise n_exc.BadRequest(msg\u003d\u0027Attribute not allowed in PUT\u0027,"},{"line_number":1281,"context_line":"                                 resource\u003d\u0027port\u0027)"},{"line_number":1282,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1283,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1284,"context_line":"                op\u003d_(\"mac address update\"), port_id\u003did,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_75af417d","line":1281,"updated":"2015-02-26 16:34:15.000000000","message":"I still don\u0027t understand why pep8 isn\u0027t having an issue here.","commit_id":"1595b4fd6e48adf21e2a1c2c9bf756a799ea0dc1"},{"author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"change_message_id":"9bc84de30b267e33fb597112a0ff0c87ae7e50f1","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1279,"context_line":"        if not cfg.CONF.allow_port_mac_address_update:"},{"line_number":1280,"context_line":"            raise n_exc.BadRequest(msg\u003d\u0027Attribute not allowed in PUT\u0027,"},{"line_number":1281,"context_line":"                                   resource\u003d\u0027port\u0027)"},{"line_number":1282,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1283,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1284,"context_line":"                op\u003d_(\"mac address update\"), port_id\u003did,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_98222ca1","line":1281,"updated":"2015-02-26 16:39:10.000000000","message":"You are my hero! \u003c3","commit_id":"887c6f78d92f873e36b1a66505f53a8339231440"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"26c3ccdf477bdc4287798f7f12ff8f0afec3f5b2","unresolved":false,"context_lines":[{"line_number":1277,"context_line":""},{"line_number":1278,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1279,"context_line":"        if not cfg.CONF.allow_port_mac_address_update:"},{"line_number":1280,"context_line":"            raise n_exc.BadRequest(msg\u003d\u0027Attribute not allowed in PUT\u0027,"},{"line_number":1281,"context_line":"                                   resource\u003d\u0027port\u0027)"},{"line_number":1282,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1283,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_3df20370","line":1280,"updated":"2015-02-26 22:25:47.000000000","message":"It should not be a BadRequest exception but an Unsupported one","commit_id":"17b5470a37f2a0d45ce15264c8f7011467ac9249"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"e2bd5e4c3e0be917f1198a06b1c73b6ddb6b7f4c","unresolved":false,"context_lines":[{"line_number":1277,"context_line":""},{"line_number":1278,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1279,"context_line":"        if not cfg.CONF.allow_port_mac_address_update:"},{"line_number":1280,"context_line":"            raise n_exc.BadRequest(msg\u003d\u0027Attribute not allowed in PUT\u0027,"},{"line_number":1281,"context_line":"                                   resource\u003d\u0027port\u0027)"},{"line_number":1282,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1283,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_735aeb84","line":1280,"in_reply_to":"ba7be1f8_040b192c","updated":"2015-03-04 10:26:51.000000000","message":"You are right! I missed that the exception is missing... let\u0027s do not over complicated this commit.","commit_id":"17b5470a37f2a0d45ce15264c8f7011467ac9249"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"85f1964610319af067c0c0b6c80f5f813b56e2ba","unresolved":false,"context_lines":[{"line_number":1277,"context_line":""},{"line_number":1278,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1279,"context_line":"        if not cfg.CONF.allow_port_mac_address_update:"},{"line_number":1280,"context_line":"            raise n_exc.BadRequest(msg\u003d\u0027Attribute not allowed in PUT\u0027,"},{"line_number":1281,"context_line":"                                   resource\u003d\u0027port\u0027)"},{"line_number":1282,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1283,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_040b192c","line":1280,"in_reply_to":"ba7be1f8_3df20370","updated":"2015-02-27 08:58:59.000000000","message":"Hi Edgar, thanks for looking.\n\nMy thinking here was that this check is almost identical to what is done in api/v2/base.py:689, which raises webob.exc.HTTPBadRequest.\n\nAre you thinking that the http status returned to the client should be 501 NotImplemented (not done in neutron yet I think), or would you like to see a new exception based on one of the currently mapped exceptions defined and used here?","commit_id":"17b5470a37f2a0d45ce15264c8f7011467ac9249"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7726ac0ce3affc1886c6e1b7fbb1b71995b544e5","unresolved":false,"context_lines":[{"line_number":1277,"context_line":""},{"line_number":1278,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1279,"context_line":"        if not cfg.CONF.allow_port_mac_address_update:"},{"line_number":1280,"context_line":"            raise n_exc.BadRequest(msg\u003d\u0027Attribute not allowed in PUT\u0027,"},{"line_number":1281,"context_line":"                                   resource\u003d\u0027port\u0027)"},{"line_number":1282,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1283,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_f704d516","line":1280,"range":{"start_line":1280,"start_character":39,"end_line":1280,"end_character":69},"updated":"2015-03-05 07:41:08.000000000","message":"msg\u003d_(\u0027Attribute not allowed in PUT\u0027)","commit_id":"2090330551e2cab5e71e375b2ef5c78dd7407f26"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"3c3509da18ed6bc69d941da6ff9c7af3cede203a","unresolved":false,"context_lines":[{"line_number":1277,"context_line":""},{"line_number":1278,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1279,"context_line":"        if not cfg.CONF.allow_port_mac_address_update:"},{"line_number":1280,"context_line":"            raise n_exc.BadRequest(msg\u003d\u0027Attribute not allowed in PUT\u0027,"},{"line_number":1281,"context_line":"                                   resource\u003d\u0027port\u0027)"},{"line_number":1282,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1283,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_12b91bcc","line":1280,"range":{"start_line":1280,"start_character":39,"end_line":1280,"end_character":69},"in_reply_to":"9a80dd14_f704d516","updated":"2015-03-06 18:36:02.000000000","message":"Done, thanks.","commit_id":"2090330551e2cab5e71e375b2ef5c78dd7407f26"}]}