)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"c363818e577765739f99802fad60b77f37a42608","unresolved":false,"context_lines":[{"line_number":10,"context_line":"dictionary."},{"line_number":11,"context_line":"The reference to the FipNamespace object associated to a router was"},{"line_number":12,"context_line":"stored in a local member variable of method process_router(...)."},{"line_number":13,"context_line":"Once the method finishes, the FipNamespace reference goes away"},{"line_number":14,"context_line":"and the object can get deleted."},{"line_number":15,"context_line":"Adding a member to the DvrRouter Class to hold the reference so"},{"line_number":16,"context_line":"that it can be retained as intended."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa53dc9_a673d97f","line":13,"updated":"2015-04-08 10:04:55.000000000","message":"could you add a unittest to check this scenario?","commit_id":"17db9e530b4fe10e15b388ebd8f867b8b27e3b4c"}],"neutron/agent/l3/dvr_router.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e1665cc70133b47173f75a40f1cb86f4ccca077d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        # Linklocal subnet for router and floating IP namespace link"},{"line_number":31,"context_line":"        self.rtr_fip_subnet \u003d None"},{"line_number":32,"context_line":"        self.dist_fip_count \u003d None"},{"line_number":33,"context_line":"        self.fip_ns \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get_floating_ips(self):"},{"line_number":36,"context_line":"        \"\"\"Filter Floating IPs to be hosted on this agent.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_9170730c","line":33,"updated":"2015-02-25 20:32:41.000000000","message":"Initializing this to None here might be a good idea anyway and would fix cases where the code attempts to read this member before it is formally set to point to a real fip namespace in agent.py L572.  However, I can\u0027t imagine how setting this reference can make any difference in whether this instance can hold a strong reference to the fip namespace object.\n\nI can\u0027t see how this could fix the bug referenced.","commit_id":"06ce336a0dd5e22a0875d823628845f24dea2a1f"},{"author":{"_account_id":14619,"name":"Victor Feitosa","email":"victor.feitosa@lsbd.ufc.br","username":"victorfeitosa"},"change_message_id":"eaa4bc1f86e16154921f43c075834bef8c9e5dc2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.rtr_fip_subnet \u003d None"},{"line_number":32,"context_line":"        self.dist_fip_count \u003d None"},{"line_number":33,"context_line":"        self.fip_ns \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get_floating_ips(self):"},{"line_number":36,"context_line":"        \"\"\"Filter Floating IPs to be hosted on this agent.\"\"\""},{"line_number":37,"context_line":"        floating_ips \u003d super(DvrRouter, self).get_floating_ips()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_928a3262","line":34,"updated":"2015-02-25 21:04:37.000000000","message":"+1 to what Carl said","commit_id":"06ce336a0dd5e22a0875d823628845f24dea2a1f"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"da40052cda053bf6431dfb106cc97e61728683fb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.rtr_fip_subnet \u003d None"},{"line_number":32,"context_line":"        self.dist_fip_count \u003d None"},{"line_number":33,"context_line":"        self.fip_ns \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get_floating_ips(self):"},{"line_number":36,"context_line":"        \"\"\"Filter Floating IPs to be hosted on this agent.\"\"\""},{"line_number":37,"context_line":"        floating_ips \u003d super(DvrRouter, self).get_floating_ips()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_f9698ef9","line":34,"in_reply_to":"ba7be1f8_928a3262","updated":"2015-02-26 01:15:01.000000000","message":"@Carl, @Victor,\nYes, we can use this as general improvement and I was thinking having an attribute explicitly declared here would help eliminate any concerns whatsoever of maintaining strong reference. I will keep this as a WIP for now and see if we find something more on the bug.","commit_id":"06ce336a0dd5e22a0875d823628845f24dea2a1f"}]}