)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"4a485c8ea0ea4560752285f70d2274846b6885a7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Cisco Nexus1000V supports binding ports using \u0027vemctl\u0027 script."},{"line_number":10,"context_line":"This proposed fix is to allow neutron to set up port bindings"},{"line_number":11,"context_line":"using n1kv interface driver. Corresponding nova changes for vif"},{"line_number":12,"context_line":"driver will be pushed up separately."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I03ec31d83bbeaa5729b45cbe7b257c61e9b197fa"},{"line_number":15,"context_line":"Closes-Bug: 1423295"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_ee715278","line":12,"updated":"2015-03-11 19:31:06.000000000","message":"The bug comment seems to indicate that maybe no Nova change is needed?\n\nIf it is needed, will that be done under the same bug (and hence be Partial-Bug, below), or a separate bug?","commit_id":"31dc84ea725fcebab19ede69dc86ae7995099b1f"},{"author":{"_account_id":8940,"name":"Sourabh Patwardhan","email":"sopatwar@gmail.com","username":"sopatwar"},"change_message_id":"57f52b5d2ef105d13f9633f5d5fe1f6cb010caba","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Cisco Nexus1000V supports binding ports using \u0027vemctl\u0027 script."},{"line_number":10,"context_line":"This proposed fix is to allow neutron to set up port bindings"},{"line_number":11,"context_line":"using n1kv interface driver. Corresponding nova changes for vif"},{"line_number":12,"context_line":"driver will be pushed up separately."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I03ec31d83bbeaa5729b45cbe7b257c61e9b197fa"},{"line_number":15,"context_line":"Closes-Bug: 1423295"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_7e57be02","line":12,"in_reply_to":"9a80dd14_ee715278","updated":"2015-03-12 03:59:22.000000000","message":"@Paul\nThere is a separate bug tracking the corresponding nova change:\nhttps://bugs.launchpad.net/nova/+bug/1423308\n\nThanks for reviewing,\nSourabh","commit_id":"31dc84ea725fcebab19ede69dc86ae7995099b1f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0665ba5ec0323e7bd741ec42e65bec9ec94bdf9e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Cisco Nexus1000V supports binding ports using \u0027vemctl\u0027 script."},{"line_number":10,"context_line":"This proposed fix is to allow neutron to set up port bindings"},{"line_number":11,"context_line":"using n1kv interface driver. Corresponding nova changes for vif"},{"line_number":12,"context_line":"driver will be pushed up separately."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I03ec31d83bbeaa5729b45cbe7b257c61e9b197fa"},{"line_number":15,"context_line":"Closes-Bug: 1423295"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5afe65bd_522f13f6","line":12,"updated":"2015-06-04 06:02:25.000000000","message":"It\u0027d be nice to have the patch referenced as Depends-on:\n\nThat said I agree with Henry, this is certainly not belonging to the Neutron tree.\n\n--Henry:\n\nIt looks like we may need to add rootwrap filters to the potential list of things that we need to take care of in the decomp phase II?","commit_id":"b639e434575501e88cb7e76f8e0ffb5bfc138f22"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e2f03d9514d268f560a41ea3ceb2379cf4267908","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Cisco Nexus1000V supports binding ports using \u0027vemctl\u0027 script."},{"line_number":10,"context_line":"This proposed fix is to allow neutron to set up port bindings"},{"line_number":11,"context_line":"using n1kv interface driver. Corresponding nova changes for vif"},{"line_number":12,"context_line":"driver will be pushed up separately."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I03ec31d83bbeaa5729b45cbe7b257c61e9b197fa"},{"line_number":15,"context_line":"Closes-Bug: 1423295"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afb71cf_61f631d9","line":12,"in_reply_to":"3afb71cf_1846d5bf","updated":"2015-06-05 00:38:28.000000000","message":"@HenryG, thanks for the follow up! It looks to me that we overlooked rootwrap filters in the past and we should clean up what\u0027s left in the existing in-filters filters too.","commit_id":"b639e434575501e88cb7e76f8e0ffb5bfc138f22"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1667bd36660193ef4d759be25a88568e38982236","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Cisco Nexus1000V supports binding ports using \u0027vemctl\u0027 script."},{"line_number":10,"context_line":"This proposed fix is to allow neutron to set up port bindings"},{"line_number":11,"context_line":"using n1kv interface driver. Corresponding nova changes for vif"},{"line_number":12,"context_line":"driver will be pushed up separately."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I03ec31d83bbeaa5729b45cbe7b257c61e9b197fa"},{"line_number":15,"context_line":"Closes-Bug: 1423295"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5afe65bd_e1e50138","line":12,"in_reply_to":"5afe65bd_522f13f6","updated":"2015-06-04 11:46:58.000000000","message":"I think out-of-tree rootwrap filters already work, there are existing examples. But certainly I will add to the doc to make sure we cover the ones still in-tree, and document the recipe.","commit_id":"b639e434575501e88cb7e76f8e0ffb5bfc138f22"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ae74fac0bc0b9aa239dab5a01a3e361dd3833c0a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Cisco Nexus1000V supports binding ports using \u0027vemctl\u0027 script."},{"line_number":10,"context_line":"This proposed fix is to allow neutron to set up port bindings"},{"line_number":11,"context_line":"using n1kv interface driver. Corresponding nova changes for vif"},{"line_number":12,"context_line":"driver will be pushed up separately."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I03ec31d83bbeaa5729b45cbe7b257c61e9b197fa"},{"line_number":15,"context_line":"Closes-Bug: 1423295"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afb71cf_1846d5bf","line":12,"in_reply_to":"5afe65bd_e1e50138","updated":"2015-06-04 21:22:41.000000000","message":"This patch does not quite depends on the nova patch. I would say it complements it. We could have a reference to the nova patch instead of the depends on message.","commit_id":"b639e434575501e88cb7e76f8e0ffb5bfc138f22"}],"neutron/agent/linux/interface.py":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"fe9f27506e4dba7f20fa7c63f51460ef49c05166","unresolved":false,"context_lines":[{"line_number":407,"context_line":"             bridge\u003dNone, namespace\u003dNone, prefix\u003dNone):"},{"line_number":408,"context_line":"        \"\"\"Plug in the interface.\"\"\""},{"line_number":409,"context_line":"        if not ip_lib.device_exists(device_name,"},{"line_number":410,"context_line":"                                    run_as_root\u003dTrue,"},{"line_number":411,"context_line":"                                    namespace\u003dnamespace):"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"            ip \u003d ip_lib.IPWrapper(run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_b888b423","line":410,"updated":"2015-03-27 21:52:34.000000000","message":"probably dont need the run_as_root param anymore","commit_id":"31dc84ea725fcebab19ede69dc86ae7995099b1f"},{"author":{"_account_id":8940,"name":"Sourabh Patwardhan","email":"sopatwar@gmail.com","username":"sopatwar"},"change_message_id":"d686f2df7dffd23c1b1df6f420ea2ef14819d965","unresolved":false,"context_lines":[{"line_number":407,"context_line":"             bridge\u003dNone, namespace\u003dNone, prefix\u003dNone):"},{"line_number":408,"context_line":"        \"\"\"Plug in the interface.\"\"\""},{"line_number":409,"context_line":"        if not ip_lib.device_exists(device_name,"},{"line_number":410,"context_line":"                                    run_as_root\u003dTrue,"},{"line_number":411,"context_line":"                                    namespace\u003dnamespace):"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"            ip \u003d ip_lib.IPWrapper(run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_680904dd","line":410,"in_reply_to":"fa963961_b888b423","updated":"2015-06-04 00:42:21.000000000","message":"Done","commit_id":"31dc84ea725fcebab19ede69dc86ae7995099b1f"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"fe9f27506e4dba7f20fa7c63f51460ef49c05166","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                                    run_as_root\u003dTrue,"},{"line_number":411,"context_line":"                                    namespace\u003dnamespace):"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"            ip \u003d ip_lib.IPWrapper(run_as_root\u003dTrue)"},{"line_number":414,"context_line":"            tap_name \u003d self._get_tap_name(device_name, prefix)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"            root_dev, ns_dev \u003d ip.add_veth(tap_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_78822c02","line":413,"updated":"2015-03-27 21:52:34.000000000","message":"ditto","commit_id":"31dc84ea725fcebab19ede69dc86ae7995099b1f"},{"author":{"_account_id":8940,"name":"Sourabh Patwardhan","email":"sopatwar@gmail.com","username":"sopatwar"},"change_message_id":"d686f2df7dffd23c1b1df6f420ea2ef14819d965","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                                    run_as_root\u003dTrue,"},{"line_number":411,"context_line":"                                    namespace\u003dnamespace):"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"            ip \u003d ip_lib.IPWrapper(run_as_root\u003dTrue)"},{"line_number":414,"context_line":"            tap_name \u003d self._get_tap_name(device_name, prefix)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"            root_dev, ns_dev \u003d ip.add_veth(tap_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_48108801","line":413,"in_reply_to":"fa963961_78822c02","updated":"2015-06-04 00:42:21.000000000","message":"Done","commit_id":"31dc84ea725fcebab19ede69dc86ae7995099b1f"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"fe9f27506e4dba7f20fa7c63f51460ef49c05166","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            cmd \u003d [\u0027vemctl\u0027, \u0027del-port\u0027, \u0027--name\u0027, tap_name]"},{"line_number":440,"context_line":"            utils.execute(cmd, run_as_root\u003dTrue)"},{"line_number":441,"context_line":"            device \u003d ip_lib.IPDevice(device_name,"},{"line_number":442,"context_line":"                                     run_as_root\u003dTrue,"},{"line_number":443,"context_line":"                                     namespace\u003dnamespace)"},{"line_number":444,"context_line":"            device.link.delete()"},{"line_number":445,"context_line":"            LOG.debug(\"Unplugged interface \u0027%s\u0027\", device_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_5887680f","line":442,"updated":"2015-03-27 21:52:34.000000000","message":"ditto","commit_id":"31dc84ea725fcebab19ede69dc86ae7995099b1f"},{"author":{"_account_id":8940,"name":"Sourabh Patwardhan","email":"sopatwar@gmail.com","username":"sopatwar"},"change_message_id":"d686f2df7dffd23c1b1df6f420ea2ef14819d965","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            cmd \u003d [\u0027vemctl\u0027, \u0027del-port\u0027, \u0027--name\u0027, tap_name]"},{"line_number":440,"context_line":"            utils.execute(cmd, run_as_root\u003dTrue)"},{"line_number":441,"context_line":"            device \u003d ip_lib.IPDevice(device_name,"},{"line_number":442,"context_line":"                                     run_as_root\u003dTrue,"},{"line_number":443,"context_line":"                                     namespace\u003dnamespace)"},{"line_number":444,"context_line":"            device.link.delete()"},{"line_number":445,"context_line":"            LOG.debug(\"Unplugged interface \u0027%s\u0027\", device_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_08fbb0c2","line":442,"in_reply_to":"fa963961_5887680f","updated":"2015-06-04 00:42:21.000000000","message":"Done","commit_id":"31dc84ea725fcebab19ede69dc86ae7995099b1f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1667bd36660193ef4d759be25a88568e38982236","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            LOG.error(_LE(\"Failed unplugging interface \u0027%s\u0027\"),"},{"line_number":390,"context_line":"                      device_name)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"class N1KVInterfaceDriver(LinuxInterfaceDriver):"},{"line_number":394,"context_line":"    \"\"\"Driver for creating an internal interface on Cisco Nexus1000V switch.\"\"\""},{"line_number":395,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_81964d3d","line":392,"updated":"2015-06-04 11:46:58.000000000","message":"Armando, I see this module already contains a bunch of proprietary VIF types. Should we design a framework to allow out-of-tree VIF types to be added to neutron? Should this be part of the current \"phase 2\" of decomposition, or should we make it a \"phase 3\"? I suspect that the requirement for adding support on the nova side (about which I know very little) might complicate this so I am leaning towards making this a \"phase 3\" work to give us time to get it right.","commit_id":"b639e434575501e88cb7e76f8e0ffb5bfc138f22"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e2f03d9514d268f560a41ea3ceb2379cf4267908","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            LOG.error(_LE(\"Failed unplugging interface \u0027%s\u0027\"),"},{"line_number":390,"context_line":"                      device_name)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"class N1KVInterfaceDriver(LinuxInterfaceDriver):"},{"line_number":394,"context_line":"    \"\"\"Driver for creating an internal interface on Cisco Nexus1000V switch.\"\"\""},{"line_number":395,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_01badde1","line":392,"in_reply_to":"5afe65bd_81964d3d","updated":"2015-06-05 00:38:28.000000000","message":"@Henry: it sounds to me that we already support out-of-tree VIF types. See [1] for instance. So there\u0027s really no need to retain this code in tree. As a matter of fact I see this an oversight of decomp phase I. Am I missing something?\n\n[1] https://github.com/stackforge/networking-midonet/blob/master/devstack/functions#L64","commit_id":"b639e434575501e88cb7e76f8e0ffb5bfc138f22"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ae74fac0bc0b9aa239dab5a01a3e361dd3833c0a","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            LOG.error(_LE(\"Failed unplugging interface \u0027%s\u0027\"),"},{"line_number":390,"context_line":"                      device_name)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"class N1KVInterfaceDriver(LinuxInterfaceDriver):"},{"line_number":394,"context_line":"    \"\"\"Driver for creating an internal interface on Cisco Nexus1000V switch.\"\"\""},{"line_number":395,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_d3513e10","line":392,"in_reply_to":"5afe65bd_81964d3d","updated":"2015-06-04 21:22:41.000000000","message":"Historically, I have seen the nova team looking at neutron interface drivers patches being merged before merging them in nova. Like Henry mentioned, this will need coordination across projects so phase 3 sounds more appropriate. We also need to consider the fact that nova team is trying to generalize their vif driver implementation in L, although it remains unclear how they plan to proceed with it.","commit_id":"b639e434575501e88cb7e76f8e0ffb5bfc138f22"}],"neutron/extensions/portbindings.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1667bd36660193ef4d759be25a88568e38982236","unresolved":false,"context_lines":[{"line_number":69,"context_line":"             VIF_TYPE_802_QBH, VIF_TYPE_HYPERV, VIF_TYPE_MIDONET,"},{"line_number":70,"context_line":"             VIF_TYPE_MLNX_HOSTDEV, VIF_TYPE_HW_VEB,"},{"line_number":71,"context_line":"             VIF_TYPE_DVS, VIF_TYPE_OTHER, VIF_TYPE_DISTRIBUTED,"},{"line_number":72,"context_line":"             VIF_TYPE_VROUTER, VIF_TYPE_N1KV]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"VNIC_NORMAL \u003d \u0027normal\u0027"},{"line_number":75,"context_line":"VNIC_DIRECT \u003d \u0027direct\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_21cd5966","line":72,"updated":"2015-06-04 11:46:58.000000000","message":"Note to self: This list looks painful. There must be a better way.","commit_id":"b639e434575501e88cb7e76f8e0ffb5bfc138f22"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e2f03d9514d268f560a41ea3ceb2379cf4267908","unresolved":false,"context_lines":[{"line_number":69,"context_line":"             VIF_TYPE_802_QBH, VIF_TYPE_HYPERV, VIF_TYPE_MIDONET,"},{"line_number":70,"context_line":"             VIF_TYPE_MLNX_HOSTDEV, VIF_TYPE_HW_VEB,"},{"line_number":71,"context_line":"             VIF_TYPE_DVS, VIF_TYPE_OTHER, VIF_TYPE_DISTRIBUTED,"},{"line_number":72,"context_line":"             VIF_TYPE_VROUTER, VIF_TYPE_N1KV]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"VNIC_NORMAL \u003d \u0027normal\u0027"},{"line_number":75,"context_line":"VNIC_DIRECT \u003d \u0027direct\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_c1b3a509","line":72,"in_reply_to":"5afe65bd_21cd5966","updated":"2015-06-05 00:38:28.000000000","message":"perhaps we can turn this to be config driven.","commit_id":"b639e434575501e88cb7e76f8e0ffb5bfc138f22"}]}