)]}'
{"neutron/agent/l3/agent.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"1f012436bf26a000a6ed4f2f5d2d4a7223e1edc6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        1.4 - Added L3 HA update_router_state. This method was reworked in"},{"line_number":78,"context_line":"              to update_ha_routers_states"},{"line_number":79,"context_line":"        1.5 - Added update_ha_routers_states"},{"line_number":80,"context_line":"        1.5 - DVR support: new L3 plugin methods added."},{"line_number":81,"context_line":"              - delete_agent_gateway_port"},{"line_number":82,"context_line":"    \"\"\""},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_7ab1dce0","line":80,"updated":"2015-06-03 17:00:26.000000000","message":"version should be bumped","commit_id":"0fdc728c13c8e9bea15eb791ae894a0dc7f07038"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"a2949faec5a30d2c3b1fd8af4355b69e3c7d9473","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        1.4 - Added L3 HA update_router_state. This method was reworked in"},{"line_number":78,"context_line":"              to update_ha_routers_states"},{"line_number":79,"context_line":"        1.5 - Added update_ha_routers_states"},{"line_number":80,"context_line":"        1.5 - DVR support: new L3 plugin methods added."},{"line_number":81,"context_line":"              - delete_agent_gateway_port"},{"line_number":82,"context_line":"    \"\"\""},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_a4673324","line":80,"in_reply_to":"5afe65bd_7ab1dce0","updated":"2015-06-03 19:22:51.000000000","message":"Done","commit_id":"0fdc728c13c8e9bea15eb791ae894a0dc7f07038"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"1f012436bf26a000a6ed4f2f5d2d4a7223e1edc6","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def delete_agent_gateway_port(self, context, fip_net):"},{"line_number":135,"context_line":"        \"\"\"Delete an agent_gateway_port.\"\"\""},{"line_number":136,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.5\u0027)"},{"line_number":137,"context_line":"        return cctxt.call(context, \u0027delete_agent_gateway_port\u0027,"},{"line_number":138,"context_line":"                          host\u003dself.host, network_id\u003dfip_net)"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_7ae8bcb4","line":136,"updated":"2015-06-03 17:00:26.000000000","message":"version should be bumped see [1]\n\n[1] http://docs.openstack.org/developer/oslo.messaging/target.html#target-versions","commit_id":"0fdc728c13c8e9bea15eb791ae894a0dc7f07038"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"a2949faec5a30d2c3b1fd8af4355b69e3c7d9473","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def delete_agent_gateway_port(self, context, fip_net):"},{"line_number":135,"context_line":"        \"\"\"Delete an agent_gateway_port.\"\"\""},{"line_number":136,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.5\u0027)"},{"line_number":137,"context_line":"        return cctxt.call(context, \u0027delete_agent_gateway_port\u0027,"},{"line_number":138,"context_line":"                          host\u003dself.host, network_id\u003dfip_net)"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_c4646f23","line":136,"in_reply_to":"5afe65bd_7ae8bcb4","updated":"2015-06-03 19:22:51.000000000","message":"Done","commit_id":"0fdc728c13c8e9bea15eb791ae894a0dc7f07038"}],"neutron/api/rpc/handlers/l3_rpc.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"e9e74fc86d26d53ee52d22bbbccd48c30ba5549b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    # 1.2 Added methods for DVR support"},{"line_number":42,"context_line":"    # 1.3 Added a method that returns the list of activated services"},{"line_number":43,"context_line":"    # 1.4 Added L3 HA update_router_state. This method was later removed,"},{"line_number":44,"context_line":"    #     since it was unused. The RPC version was not changed"},{"line_number":45,"context_line":"    # 1.5 Added update_ha_routers_states"},{"line_number":46,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.5\u0027)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_8880aac1","line":44,"updated":"2015-06-04 13:39:22.000000000","message":"history needs to be updated","commit_id":"afac5a92ce2cd261c52534652f790b31001100b5"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"e9e74fc86d26d53ee52d22bbbccd48c30ba5549b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    # 1.3 Added a method that returns the list of activated services"},{"line_number":43,"context_line":"    # 1.4 Added L3 HA update_router_state. This method was later removed,"},{"line_number":44,"context_line":"    #     since it was unused. The RPC version was not changed"},{"line_number":45,"context_line":"    # 1.5 Added update_ha_routers_states"},{"line_number":46,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.5\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_0826fa14","line":45,"updated":"2015-06-04 13:39:22.000000000","message":"you should bump the version here too. Sorry I forgot that in my previous review","commit_id":"afac5a92ce2cd261c52534652f790b31001100b5"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"926bb7e002315840bbae3cb90b38c4e8572c90d0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    # 1.4 Added L3 HA update_router_state. This method was later removed,"},{"line_number":44,"context_line":"    #     since it was unused. The RPC version was not changed"},{"line_number":45,"context_line":"    # 1.5 Added update_ha_routers_states"},{"line_number":46,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.5\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @property"},{"line_number":49,"context_line":"    def plugin(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_a558238b","line":46,"updated":"2015-06-04 18:12:33.000000000","message":"Right, this should now be \u00271.6\u0027.  Please also take a look at CI, because if this didn\u0027t cause any new failures, the testing is insufficient.","commit_id":"afac5a92ce2cd261c52534652f790b31001100b5"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"926bb7e002315840bbae3cb90b38c4e8572c90d0","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        LOG.debug(\u0027Updating HA routers states on host %s: %s\u0027, host, states)"},{"line_number":227,"context_line":"        self.l3plugin.update_routers_states(context, states, host)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def delete_agent_gateway_port(self, context, **kwargs):"},{"line_number":230,"context_line":"        \"\"\"Delete Agent Gateway port for FIP.\"\"\""},{"line_number":231,"context_line":"        network_id \u003d kwargs.get(\u0027network_id\u0027)"},{"line_number":232,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_051c97bf","line":229,"updated":"2015-06-04 18:12:33.000000000","message":"I personally prefer seeing the kwargs explicitly listed instead of using \"**kwargs\".  I realize this is consistent with the rest of the file, though.","commit_id":"afac5a92ce2cd261c52534652f790b31001100b5"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"3ea2ba4d06df489c929ca5b94aa0646b6b7ecbaa","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    #     since it was unused. The RPC version was not changed"},{"line_number":45,"context_line":"    # 1.5 Added update_ha_routers_states"},{"line_number":46,"context_line":"    # 1.6 Added method delete_agent_gateway_port for DVR Routers"},{"line_number":47,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.5\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"},{"line_number":50,"context_line":"    def plugin(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afb71cf_21c1592f","line":47,"updated":"2015-06-05 00:43:46.000000000","message":"This still needs to be changed to 1.6","commit_id":"e8e4c07cfbc7ffe6c23e60581a26a5dfc0b35cc4"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"85f5026199b922f8b57745afb200fd2fdaf1aac1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    #     since it was unused. The RPC version was not changed"},{"line_number":45,"context_line":"    # 1.5 Added update_ha_routers_states"},{"line_number":46,"context_line":"    # 1.6 Added method delete_agent_gateway_port for DVR Routers"},{"line_number":47,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.5\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"},{"line_number":50,"context_line":"    def plugin(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afb71cf_85f79cf4","line":47,"in_reply_to":"3afb71cf_21c1592f","updated":"2015-06-08 17:22:37.000000000","message":"Done","commit_id":"e8e4c07cfbc7ffe6c23e60581a26a5dfc0b35cc4"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"ebb1a5d95c87b4bdbb25ed3cefcce0185da205c9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # 1.5 Added update_ha_routers_states"},{"line_number":46,"context_line":"    # 1.6 Added method delete_agent_gateway_port for DVR Routers"},{"line_number":47,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.5\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"},{"line_number":50,"context_line":"    def plugin(self):"},{"line_number":51,"context_line":"        if not hasattr(self, \u0027_plugin\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afb71cf_e49fcfb2","line":48,"updated":"2015-06-05 01:04:45.000000000","message":"+1","commit_id":"e8e4c07cfbc7ffe6c23e60581a26a5dfc0b35cc4"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"85f5026199b922f8b57745afb200fd2fdaf1aac1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # 1.5 Added update_ha_routers_states"},{"line_number":46,"context_line":"    # 1.6 Added method delete_agent_gateway_port for DVR Routers"},{"line_number":47,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.5\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"},{"line_number":50,"context_line":"    def plugin(self):"},{"line_number":51,"context_line":"        if not hasattr(self, \u0027_plugin\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afb71cf_45dac479","line":48,"in_reply_to":"3afb71cf_e49fcfb2","updated":"2015-06-08 17:22:37.000000000","message":"Done","commit_id":"e8e4c07cfbc7ffe6c23e60581a26a5dfc0b35cc4"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"3ea2ba4d06df489c929ca5b94aa0646b6b7ecbaa","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        State must be in: (\u0027active\u0027, \u0027standby\u0027)."},{"line_number":222,"context_line":"        \"\"\""},{"line_number":223,"context_line":"        states \u003d kwargs.get(\u0027states\u0027)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        LOG.debug(\u0027Updating HA routers states on host %s: %s\u0027, host, states)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afb71cf_01dd3d14","line":224,"updated":"2015-06-05 00:43:46.000000000","message":"If you\u0027re updating anyway, it would be good to remove the unrelated whitespace change here","commit_id":"e8e4c07cfbc7ffe6c23e60581a26a5dfc0b35cc4"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"85f5026199b922f8b57745afb200fd2fdaf1aac1","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        State must be in: (\u0027active\u0027, \u0027standby\u0027)."},{"line_number":222,"context_line":"        \"\"\""},{"line_number":223,"context_line":"        states \u003d kwargs.get(\u0027states\u0027)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        LOG.debug(\u0027Updating HA routers states on host %s: %s\u0027, host, states)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afb71cf_05e4cc38","line":224,"in_reply_to":"3afb71cf_01dd3d14","updated":"2015-06-08 17:22:37.000000000","message":"Done","commit_id":"e8e4c07cfbc7ffe6c23e60581a26a5dfc0b35cc4"}]}
